- 24 Oct, 2019 40 commits
-
-
Meredith Lane authored
TBR=benwells@chromium.org Bug: 1017305 Change-Id: I8c8129ea2728ab2750a8528b98385255763baa94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880230Reviewed-by:
Meredith Lane <meredithl@chromium.org> Commit-Queue: Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#709274}
-
Yue Zhang authored
This reverts commit 079d6cd8. Reason for revert: Land the test class but disable the test for now. Original change's description: > Revert "Add multi-window behavior test for GTS" > > This reverts commit ef605722. > > Reason for revert: the test consistently fails on Android N > > Original change's description: > > Add multi-window behavior test for GTS > > > > This CL adds a class for testing mult-window related operations in GTS. > > It only contains one test case so far for GTS without group enabled. > > Will add group related tests in a later patch. > > > > Bug: 983170 > > Change-Id: I36761705effba417abbcb715c8e4bbb6c2b266dc > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857604 > > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > > Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#707949} > > TBR=yusufo@chromium.org,wychen@chromium.org,yuezhanggg@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 983170, 1017141 > Change-Id: I736a4e0649f462a6f3325c16209242cd31525067 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876388 > Reviewed-by: Alex Ilin <alexilin@chromium.org> > Commit-Queue: Alex Ilin <alexilin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#708614} TBR=yusufo@chromium.org,wychen@chromium.org,alexilin@chromium.org,yuezhanggg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 983170, 1017141 Change-Id: I051805a99a20ebc1a508e2d98b46711f02ef8d89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879468Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#709273}
-
Caleb Rouleau authored
For other stories (namely the MSE ones), we should not enable the metric since it cannot produce good data but instead produces a few measurements with 0 values that just confuse people. For example see crbug.com/982383. This changelist also fixes the issue with the measure_memory member variable of the media story set. That attribute was true for everything since it was shared within the story set, so it would have turned on memory metrics for MSE Pages. For system_health benchmarks, we have have some benchmarks that produce cpu usage metrics and some that produce memory metrics. This is done purposefully since producing memory dumps is cpu-intensive which skews the cpu usage results. In the future, media benchmark could adopt a similar approach. However, using the GetExtraTracingMetrics() function, media benchmark could have some stories produce memory measurements and some produce cpu usage measurements within the same benchmark. This changelist happens to provide the structure that would allow that. I tested this by running ./run_benchmark media.desktop --browser=system --story='video.html?src=tulip2.vp9.webm&background' --output-format=html --output-dir=/usr/local/google/home/crouleau/output and checking that memory metrics were produced in the html output. and then running ./run_benchmark media.desktop --browser=system --story=mse.html?media=aac_audio.mp4 --output-format=html --output-dir=/usr/local/google/home/crouleau/output and checking that no memory metrics were produced in the html output. Bug: 982383 Change-Id: I02a6171e240a426521c7516cb1bdf489072cebd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879779 Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#709272}
-
Yulun Wu authored
This reverts commit a57dd0eb. Reason for revert: Moving release notes notification behind a feature flag instead Original change's description: > CrOS: disable release notes for M78. > > Bug: 1016946 > Change-Id: Ib9bb97271e18eb1428eded141068a4c0526a8096 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872481 > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > Commit-Queue: Yulun Wu <yulunwu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#708776} TBR=alemate@chromium.org,yulunwu@chromium.org Change-Id: Ib0edac6352a69fa3a4b012055c431b37445f0f92 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1016946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879695Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#709271}
-
Hans Wennborg authored
Bug: 1016945 Change-Id: Ide11a3e8f26ed447668f1497daf4392d0ba0d605 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879889 Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Reid Kleckner <rnk@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#709270}
-
Henrique Nakashima authored
It is scheduled with a random delay between 0ms and 59999ms. When it is exactly 0, the delayed task is actually executed as a regular task, and since it is scheduled just before the task that starts native, it runs without native, causing a crash. Moving recordMetrics() to after native is initialized fixes the issue. Bug: 1017130 Change-Id: Ica5d0a125b93433bd2291a6c73ac30d3fd890aa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880172 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#709269}
-
Andrew Xu authored
When the scrollable shelf is enabled, use ScrollableShelfView as the shelf button delegate for the shelf app buttons. It helps to build the connection between the app button and the topmost view in hotseat widget. This CL should not bring any noticeable change. Bug: 1010219 Change-Id: I0e4e3a810a72094a108af459561ebb306808c2f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869554 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#709268}
-
Mostyn Bramley-Moore authored
We no longer use any LGPL code from Mesa, so let's remove that license from the corresponsing README.chromium file. Also, GLES/glext.h, GLES/gl.h and GLES/glplatform.h are made available under another license that is not already mentioned- "SGI Free Software B License Version 2.0". Let's add this license text. Note that the reference URL for this license is now a broken link, and these header files do not include the actual license themselves. The license text added by this patch was taken from this (reputable) source: https://spdx.org/licenses/SGI-B-2.0.html BUG=873321 Change-Id: I324fe79c070a996bcab9ff78021f45572d6bbf39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813353 Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#709267}
-
Ahmed Mehfooz authored
This change fixes a number of crashes caused by the message center widget being destroyed without it's animations being cleaned up properly. Change-Id: If70b46d530867721785cd208db937207c6dcc865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877256 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#709266}
-
Daniel Murphy authored
This CL take the LevelDBFactory in leveldb_env.h, and split it up into: * leveldb_factory.h, which contains the part of the previous LevelDBFactory that deals only with LevelDB and LevelDBState. This is cleaned up a bit to hold the options and other configuration that doesn't change. * transactional_leveldb_factory.h, which contains the Transactional LevelDB factory parts. The rest of the CL is refactoring the code to use these two new factories. Some tests are updated to be a little cleaner. Bug: 1015212 Change-Id: I8d70958e1c5892cd908792db8eab45e584ece97a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865038 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#709265}
-
Tatiana Buldina authored
Change-Id: Iec38375f55151e73cc3bb72683d1b4ee3cb2b01a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721852Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#709264}
-
Hiroki Nakagawa authored
This is a follow-up for: https://chromium-review.googlesource.com/c/chromium/src/+/1772933/3/third_party/blink/renderer/platform/weborigin/url_security_origin_map.h#42 For code simplification, this CL moves BlobURLNullOriginMap from core/fileapi/public_url_manager.cc to its own file in platform/blob/. This enables to remove platform/weborigin/url_security_origin_map.h that was used for exposing BlobURLNullOriginMap from PublicURLManager in core/ to SecurityOrigin in platform/ (see SecurityOrigin::SetBlobURLNullOriginMap() in the original code). Also, this CL simplifies class instance relationship. Before this CL, BlobURLNullOriginMap was a process global object, and BlobURLOriginMap that actually managed pairs of blob URL and "null" security origin was a thread specific object. BlobURLNullOriginMap served as the interface of the thread specific object. (process global) BlobURLNullOriginMap == accesses ==> (thread specific) BlobURLOriginMap == manages ==> pairs of blob URL and "null" origin After this CL, BlobURLNullOriginMap is a thread specific object and contains pairs of blob URL and "null" security origin. An instance of BlobURLNullOriginMap is accessed via BlobURLNullOriginMap::GetInstance(). (thread specific) BlobURLNullOriginMap == manages ==> pairs of blob URL and "null" origin. Change-Id: I17c76c41d6a2bfddc66049a53268bba955808c5f Bug: 987130 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864497 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#709263}
-
Bailey Berro authored
This change introduces a fuzzer for the PpdLineReader class that calls NextLine on random buffers with randon max_line_lengths. Change-Id: I5aa22e1dbe4fd88a2dee1fed6bd740e3c0fdfad2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874593Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#709262}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ife7608d48fa68af134dfea7ecbed89267c5be7f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879570Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709261}
-
John Z Wu authored
This is required to have password automatically filled when landing on a secure page for which the user has credentials for. - Moved credential_manager_util from //ios/chrome/browser/passwords to //components/password_manager/ios - Refactored functions of ios_security_state_tab_helper into security_state_utils in //components/security_state/ios - Removed ios_security_state_tab_helper - Move insecure_input_tab_helper in to //components/security_state/ios Bug: 1007540 Change-Id: I09140fa04d0a80f1409e41437f58fbb4cb311c1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854464Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#709260}
-
Natalie Chouinard authored
Add chouinard@chromium.org to //chrome/browser/android/preferences/OWNERS Change-Id: I71a160063df1e7914e47a15b56fa4733dd9ffda5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879820Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#709259}
-
Suzy Li authored
This reverts commit 05e16b52. Reason for revert: Clank should use the GmsCore implementation of isUVPAA, see crbug.com/1017587 Original change's description: > Remove unused callback and handler for isUVPAA > > This CL aims at removing rest of the code to use gmscore isUVPAA. > > This CL is the third of 3 CLs to add isUVPAA implemenration on clank > and remove the flow to call isUVPAA that gmscore supports. > First CL: > https://chromium-review.googlesource.com/c/chromium/src/+/1739973 > Second CL: > https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/1587528 > > Bug: n/a > Change-Id: I8f045738e3b3213184e7109bb42f1924ad8c55b0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750406 > Commit-Queue: Suzy Li <suzyli@google.com> > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#686483} TBR=kenrb@chromium.org,suzyli@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1017587 Change-Id: Ieb9e7b9c18a9f36775fdf4b579637a34e55a4959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880127Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Suzy Li <suzyli@google.com> Cr-Commit-Position: refs/heads/master@{#709258}
-
Etienne Pierre-doray authored
This CL cause NetworkService::CreateForTesting to use a mock NetworkChangeNotifier which does not observe network changes Bug: 1011275 Change-Id: I6de34b7a5f6c5af5128cfc000ed63481f3351325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864359 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#709257}
-
Moe Ahmadi authored
Prevents the remove icon from getting focus by preventing the default action on 'mousedown' event. Otherwise, the realbox wrapper's focusin handler selects the given match which fills in the realbox input. Bug: 1017497 Change-Id: I9522d83079b9a05e815e6020cc383504180e4fab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877659 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#709256}
-
Owen Min authored
When CloudExtensionRequestEnabled policy is set to true, all extensions are blocked by default. User can send request for block-by-default extension to admin. Bug: 1006899 Change-Id: I715ece27267bc38d894ffaee2c143fe8b200e430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872816Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#709255}
-
Steven Bingler authored
Change the cookies used in the HttpOnlyCookieChange tests to be marked as secure. This is in order to prevent test breakage when cookies become SameSite-by-Default. Bug: 1016512 Change-Id: I776575d1d1151c119c869376616c4ed76bd7ebf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879653 Commit-Queue: Steven Bingler <bingler@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#709254}
-
Jacques Newman authored
Without this change, placeholder's static text is considered to be Read-Only. This would be confusing to AT users. With this change, if a node is queried for UIA_IsReadOnlyAttributeId, we determine if the node is placeholder text. If so, the read-only value exposed to UIA should match the read-only value of the parent. Bug: 1017457 Change-Id: I79c41adaeccfd4a8173ab5a6d89c8cde1f6a0477 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877308Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Commit-Queue: Jacques Newman <janewman@microsoft.com> Cr-Commit-Position: refs/heads/master@{#709253}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/21b8d3ff0a35..c09baddc696f Created with: gclient setdep -r src-internal@c09baddc696f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:1004848,chromium:984162,chromium:b/139535718 Change-Id: I7c667e8c2ebe25ec5fb5c148d58fe067e528bb20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879420Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709252}
-
Bailey Berro authored
Change-Id: I05015028fd7ecf82188aad9dff8f31d2b1ed4579 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874812Reviewed-by:
-
Mason Freed authored
This flag was disabled by default, but was always enabled when the HTMLImports flag was enabled. It therefore served no purpose, other than as a plan for future internal Chromium features that still depended on HTML Imports. There are places in code that still require HTML Imports, but those directly enable the HTMLImports flag, such as [1]. Removing this flag simplifies the process of understanding what is using HTML Imports. Bug: 911943 Change-Id: I89ed53a83e414c2d549c0056600a8583d820c873 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879950 Commit-Queue: Mason Freed <masonfreed@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#709250}
-
Ken MacKay authored
This allows external processes to receive loopback audio directly from the mixer. Merge-With: eureka-internal/325957 Bug: internal b/138938216 Bug: internal b/127963522 Test: yes Change-Id: Id04ae81badf8d7a74329394dde58bbac8218e517 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864820Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#709249}
-
Robert Sesek authored
This removes a hurdle around object lifetimes for an upcoming change that makes TemplateURLParser asynchronous. Bug: 699342 Change-Id: I92d88f221d7c06f48d6f3e3a9e21f34514c70661 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877188Reviewed-by:
Kevin Bailey <krb@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#709248}
-
Henrique Nakashima authored
Bug: 995916 Change-Id: I5fa12d55d08f69243a83fd685cc9c3aa44a3add5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873906 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#709247}
-
John Lee authored
- Add more accessible labels for title and alert states. - Move the focusable target from TabElement's host to inner #tab element to allow aria-labelledby to work. - Add role and tabindex to appropriate elements. - Does not update focus outline UI. Screenshot examples of what is read out: https://imgur.com/a/o0Hmu3a Bug: 1017472 Change-Id: I230e810fadf92749c2ecf824bb92eb4d8c45774d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877194 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#709246}
-
Philip Rogers authored
Benchmark owner list: go/chrome-benchmarks How to update benchmark owners: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/benchmark/benchmark_ownership.md Change-Id: Ie32ea8e90adc8e4db881ee697829d62ce545ecda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879312 Auto-Submit: Philip Rogers <pdr@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#709245}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/f9b58fba9eab..cb771c6c486e git log f9b58fba9eab..cb771c6c486e --date=short --no-merges --format='%ad %ae %s' 2019-10-24 saklein@chromium.org Sdk/Create: Additional replace checks. 2019-10-24 anushruth@chromium.org deploy_chrome: Add logs to check the process blocking umount if it fails 2019-10-24 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@cb771c6c486e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I98620b5a8c69293021f8232f5a0118bba845fa97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879419Reviewed-by:
-
Gayane Petrosyan authored
In this CL create a simple dialog with a close button. The dialog also displays Share/Scan tabs but no functionality is implemented for those. screenshot: https://screenshot.googleplex.com/JHExGzx6ds6.png Bug: 993920 Change-Id: I056c8397d640092ac7c3aa56e3d0a983a9551cf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869884 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1f094d33. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: Iebc533ea228b9214abe14b560955b9c06f87e012 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880047Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709242}
-
Michael Ludwig authored
This updates the CanPassBeDrawnDirectly logic to allow for SolidColorDrawQuads, although it still has the requirement that the quad is opaque with src-over blending. Bug: 1013735 Change-Id: I433e00561c72f0e8069e7ae1ecf7ab066eb518b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860936 Commit-Queue: Michael Ludwig <michaelludwig@google.com> Reviewed-by:
weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#709241}
-
Dale Curtis authored
Since we have been unable to join on the VideoDecoderStats table due to processing times and lack of cross correlation per resolution, metrics leadership has asked we add this field directly to watch time calculations. This adds a new callback to the WatchTimeReporter for pulling the PipelineStatistics object (just like VideoDecodeStatsReporter does) and uses that to collect an initial and then subsequent relative values as watch time reporting ticks along. BUG=1002567 TEST=updated unittests R=chcunningham Change-Id: I3cf3a3bf779021e9677d8b511a8066efdeeb492b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869341 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
-
Caleb Rouleau authored
Before, we did direct story_set manipulation. This is a bad pattern however per crbug.com/980758 and we would prefer to delete that functionality. Note that this problem could have been solved instead by passing --run-full-story-set into options_for_unittests, but then we would not be removing the usage of RemoveStory, and we would not be running the abridged stories as the smoke tests. Bug: 980758, 965158 Change-Id: I027783d0920409df2d645b7fe8f6c26392aee3fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874821Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#709239}
-
Matt Menke authored
With the removal of URLRequestFileJob and URLRangeRequestJob, these classes are no longer in use. Bug: 934009 Change-Id: I68632b3d79609d72762c4fd8a186eac6d5d7c36b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869726 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#709238}
-
Matt Menke authored
They weren't being used in production, other than URLRequestDataJob::BuildResponse(), which just wraps DataURL::BuildResponse, which this CL migrates both existing consumers to. Also slightly clean up the DataURL API. Bug: 934009 TBR: kojii@chromium.org Change-Id: Iea9ec1b607c25bcbc4ee80c12f498c2ad6832e42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869725 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
-
Dan Beam authored
* border-radius on matches: 8px -> 16px * search magnifying glass icons (in matches): 20px -> 16px * change search icon in realbox to Google G icon Fixed: 1017495 Change-Id: I34005dda8e39a91efd35ec884d50e37050af300f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877618 Auto-Submit: Dan Beam <dbeam@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
-
Tibor Goldschwendt authored
This simplifies the selection code and prepares for moving components into modules. Bug: 870055 Change-Id: I7042eb396cb114a74f7e77933f644184d411ce7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874610 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#709235}
-
