- 24 Oct, 2018 40 commits
-
-
Gauthier Ambard authored
This CL fixes the way the utils are checking if the preferred content size category is an accessibility category for iOS 10. Even if iOS 10 support will be dropped, the code should be correct. Bug: 895804 Change-Id: I4ba1066b7eef712534da876777013476513c060a Reviewed-on: https://chromium-review.googlesource.com/c/1297417Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#602282}
-
Gauthier Ambard authored
New files are needed by the MDC repo. Bug: 898170 Change-Id: Ib48862834df9d677db459e5efccee761269f49a9 Reviewed-on: https://chromium-review.googlesource.com/c/1296500Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#602281}
-
Leszek Swirski authored
This reverts commit 42aaff47. Reason for revert: Blocking a revert for https://crbug.com/894796 Original change's description: > [blink] Remove work stealing > > Work stealing is deprecated by script streaming on the task scheduler, > and broken anyway by ScriptResource-controlled script streaming. > > Bug: 557466 > Bug: 761977 > Bug: 865098 > Bug: 866868 > Change-Id: Ie01d239b052ad7499e9884687bf95376a5cf6f9a > Reviewed-on: https://chromium-review.googlesource.com/c/1258168 > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org> > Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#601921} TBR=hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org,leszeks@chromium.org,jochen@chromium.org Change-Id: I0017e6580c01f5da934a6a13af0b8b01641c0c39 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 557466, 761977, 865098, 866868 Reviewed-on: https://chromium-review.googlesource.com/c/1297421Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#602280}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f426f506dc36..84fbe1444f3c Created with: gclient setdep -r src-internal@84fbe1444f3c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Id7eeb57a1f3e93921463de2a450e70b3b1663f71 Reviewed-on: https://chromium-review.googlesource.com/c/1297330Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#602279}
-
Eric Willigers authored
The functional pseudo-class like :matches() with 0 specificity is now named :where(). https://drafts.csswg.org/selectors/#zero-matches BUG=898215 Change-Id: Ic4d3feccc2fca566e54bb0076b4248b7958788c2 Reviewed-on: https://chromium-review.googlesource.com/c/1296606Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#602278}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/130258cf..2e57da0a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I374ca00ae3b01c20a26ff02b7ab611dcab9a7fbc Reviewed-on: https://chromium-review.googlesource.com/c/1297737Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#602277}
-
Fumitoshi Ukai authored
Bug: 835732 Change-Id: I04f6e2cbb3808355d4d9d86b99dbffa34ecd6f74 Reviewed-on: https://chromium-review.googlesource.com/c/1290711Reviewed-by:
Shinya Kawanaka <shinyak@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Fumitoshi Ukai <ukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#602276}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4257a53431af..f426f506dc36 Created with: gclient setdep -r src-internal@f426f506dc36 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I2b936396d9882af849bb14996c55febde71a44ab Reviewed-on: https://chromium-review.googlesource.com/c/1296988Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#602275}
-
Alexander Hendrich authored
With network service we can't modify cookie headers anymore to store the start/end times of GAIA redirects to/from SAML IdP. Instead we will only use the domain based filtering (*google.<TLD> or *youtube.<TLD>) to filter out GAIA cookies. Bug: 887061 Change-Id: Iac1c2a9b267b61a788269931ab8318c13a7a0666 Reviewed-on: https://chromium-review.googlesource.com/c/1296539Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#602274}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/49353683320d..70bd0b72f3f8 git log 49353683320d..70bd0b72f3f8 --date=short --no-merges --format='%ad %ae %s' 2018-10-24 mtklein@google.com Revert "Some more clean-up of YUVA code" 2018-10-24 csmartdalton@google.com ccpr: Harden the path cache 2018-10-23 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-10-23 csmartdalton@google.com ccpr: Don't use the GrContext id for the path cache id 2018-10-23 jvanverth@google.com Some more clean-up of YUVA code Created with: gclient setdep -r src/third_party/skia@70bd0b72f3f8 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel BUG=chromium:897510,chromium:897413,chromium:897245,chromium:897507,chromium:897510,chromium:897413,chromium:897245,chromium:897507 TBR=brianosman@chromium.org Change-Id: I681acc9f101d006ae523d155a7c0975098f166c9 Reviewed-on: https://chromium-review.googlesource.com/c/1297829Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#602273}
-
Jan Krcal authored
This CL makes the old Directory controller react to the toggle in Payments methods as well. Bug: 898141 Change-Id: I09918c9aace663376f7beb0ed0cd5f2ef3854b0e Reviewed-on: https://chromium-review.googlesource.com/c/1296598 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Florian Uunk <feuunk@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#602272}
-
Gauthier Ambard authored
This CL moves the util files living in ios/c/b/ui to the correct folder ios/c/b/ui/util. Bug: none Change-Id: Icbd9b1cfe17b8af434f48647446071843e6e37ea Reviewed-on: https://chromium-review.googlesource.com/c/1296534 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#602271}
-
Ramin Halavati authored
Traffic annotation auditor binaries for Windows and Linux are updated after the change crrev.com/c/1291813. Bug: 876855 Change-Id: I7490b23e192e4c02ca753cae5f3762758deccfb2 TBR: nicolaso@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1297358Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#602270}
-
Sergey Ulanov authored
Fuchsia's mediacodec API uses NV12 to encode decoded output frames, so it's useful to support them in VideoFrame and the renderer. Bug: 876519 Change-Id: I4863cfbf47fb9e2ba034b239eaa7f485e1f87dd4 Reviewed-on: https://chromium-review.googlesource.com/c/1297601Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#602269}
-
Alexey Baskakov authored
This unifies the API for both old and new implementations of InstallManager interface. Bug: 891172 Change-Id: I95086c897c4fe3d6f58bf8e8e88050b0e5692118 Reviewed-on: https://chromium-review.googlesource.com/c/1295616 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#602268}
-
Joel Hockey authored
chrome.fileManagerPrivate.sharePathWithCrostini changed name to chrome.fileManagerPrivate.sharePathsWithCrostini and takes array of Entry in order to simplify case where multiple paths are being shared at a single time. Requires a custom barrier closure in CrostiniSharePath to capture the first instance of an error and respond with it when done. Bug: 878324 Change-Id: I1f308028abda9db92990cc73ad8d7598aee118fe Reviewed-on: https://chromium-review.googlesource.com/c/1293094 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#602267}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Iad5c8952daf2805026e23a5340e558861fd79710 Reviewed-on: https://chromium-review.googlesource.com/c/1296987Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#602266}
-
Mikel Astiz authored
These features are enabled by default with M71 and seem effective according to experiments on canary&dev, so there's no need to keep these feature toggles around. These features may also be the cause for certain unrelated test flakiness on TSAN, presumably because test-only feature overrides are not thread safe. Bug: 887068,892550 Change-Id: Ia57e1f161f726db05e2322568da51d3681df8751 Reviewed-on: https://chromium-review.googlesource.com/c/1296504Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#602265}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/10ebffa1d5f3..4257a53431af Created with: gclient setdep -r src-internal@4257a53431af The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Iea121ce6bf45664306eccb27f72ef601214e90e5 Reviewed-on: https://chromium-review.googlesource.com/c/1296986Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#602264}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 50fe66c6. With Chromium commits locally applied on WPT: f79c6fe7 "Reimplementing getDatabaseNames() as databases() for indexeddb." 57cc1d42 "Added 304 CSP test and removed "content-*" prefix from headers to ignore on 304" 89bcea96 "[run_web_tests] Remove extra baselines after crrev.com/c/1277654" 36e64bc7 "Updating tests for Window onerror is not triggered bug fix." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/26619 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=markdittmer No-Export: true Change-Id: Ia321142a2749c26fbce00751f4f2d3bff01314c4 Reviewed-on: https://chromium-review.googlesource.com/c/1297736 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#602263}
-
Alan Cutter authored
Mark virtual/scroll_customization/fast/scroll-behavior/smooth-scroll/keyboard-scroll.html as timing out This is a follow up to https://chromium-review.googlesource.com/c/1297733 to also cover the virtual version of this test. TBR=sahel@chromium.org NOTRY=true Bug: 898378 Change-Id: I2c9748f00f6e58b287c0f50c2b68f312d104dd2c Reviewed-on: https://chromium-review.googlesource.com/c/1297750Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#602262}
-
David Jacobo authored
Receive usage metrics for sharing files feature in ARC, then store them via UMA. Bug: b/112469474 Change-Id: I4f34475ab0c38bae2ed9a2bb4e02a0654553a814 Reviewed-on: https://chromium-review.googlesource.com/c/1289516 Commit-Queue: David Jacobo <djacobo@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#602261}
-
Alan Cutter authored
TBR=pdr@chromium.org Bug: 898394 Change-Id: I0286d9374cd941546798de6f6507c8f81f436c7d Reviewed-on: https://chromium-review.googlesource.com/c/1297770Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#602260}
-
Tetsui Ohkubo authored
In order to look visually consistent with UnifiedSystemTray, notification popup ordering should be inverted on Chrome OS. To implement that, this CL adds MOVE_UP_FOR_INVERSE animation state to MessagePopupCollection. TEST=MessagePopupCollectionTest BUG=876769 Change-Id: I0dcb5c20c8bc3e76f44b32c989b7c935d0e2f676 Reviewed-on: https://chromium-review.googlesource.com/c/1290450 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#602259}
-
Antonio Gomes authored
BUG=890771 Change-Id: I9fbb028db7c7e4c259885aa804ef475bb79deb47 Reviewed-on: https://chromium-review.googlesource.com/c/1296872Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#602258}
-
Satoshi Niwa authored
Design doc : go/arc-file-picker BUG=b:64281746 TEST=out/Default/unit_tests --gtest_filter="ArcSelectFilesHandlerTest.*" Change-Id: I38fdcf214ddc08a986086f6d96943bfe69d53e30 Reviewed-on: https://chromium-review.googlesource.com/c/1272341 Commit-Queue: Satoshi Niwa <niwa@chromium.org> Reviewed-by:
Shuhei Takahashi <nya@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#602257}
-
Joel Hockey authored
Only persist shares from right-click > Share with Linux. Do not persist shares that are done for the purpose of opening a file with a linux app. Share with Linux is only supported for directories (not files), but open with linux app will share only the selected files, and not the containing directories. Also needed to fix chrome.fileManagerPrivate.executeTask jsdoc to correctly declare that callback receives !chrome.fileManagerPrivate.TaskResult. I'm not sure why closure compiled previously without this fix. Bug: 878324 Change-Id: Idfe0728cd817ba406b0dd1a1eb80c561944f1ce6 Reviewed-on: https://chromium-review.googlesource.com/c/1290581Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#602256}
-
Alex Danilo authored
File manager added support for using MIME types for icon display in https://codereview.chromium.org/1158923004 and used a mixture of string literals and Regexp constructors. The RegExp constructors need escaping of the strings so they lex correctly. This change corrects those strings. BUG=chromium:675506 TEST=Manually checked, automated lexer in bug report was personal project by the reporter. Signed-off-by:
Alex Danilo <adanilo@chromium.org> Change-Id: I2241b87231d75d0d1b2d2c7b8bdfe13a6d3a0770 Reviewed-on: https://chromium-review.googlesource.com/c/1296934Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#602255}
-
Xinghua Cao authored
Driver may create a compatibility profile context when collect graphics information on Linux platform, but command buffer service gets a core profile context when supports GLX_ARB_create_context, so make them identically. Try to collect graphics information based on core profile context after disabling platform extensions. BUG=867675 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ibf0abc1942532d6518fb7c65ebb857dc4d509171 Reviewed-on: https://chromium-review.googlesource.com/c/1247531Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Xinghua Cao <xinghua.cao@intel.com> Cr-Commit-Position: refs/heads/master@{#602254}
-
Satoshi Niwa authored
and fill StartArcMiniContainerRequest with the flag value in arc_session_impl Refrence CL: http://crrev.com/c/617748 TEST=Manually confirmed that the flag value is passed to arc-setup BUG=b:117814025 Change-Id: If2eb9a71fcd565af45aba7de77cc40f80acb7f37 Reviewed-on: https://chromium-review.googlesource.com/c/1295974 Commit-Queue: Satoshi Niwa <niwa@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#602253}
-
Alex Danilo authored
The 'New folder' menu item should create a folder with the same case for the folder name. This implements that, and updates the test. BUG=chromium:894971 TEST=Ran all the FilesApp tests Signed-off-by:
Alex Danilo <adanilo@chromium.org> Change-Id: I34728d64c90082a1a791054d3ba2d5493af79c7e Reviewed-on: https://chromium-review.googlesource.com/c/1295130Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#602252}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/63963f35905f..10ebffa1d5f3 Created with: gclient setdep -r src-internal@10ebffa1d5f3 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie991c685b619fb2264658ca4a099546a8d75212a Reviewed-on: https://chromium-review.googlesource.com/c/1296985Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#602251}
-
Xianzhu Wang authored
For fixing SlimmingPaintV2 scrolling background painting and invalidation, we need a single place to get the accurate value of the background paint location. Bug: 732611 Change-Id: I0ad696395d73c9c19078e13e9a32cf9dbd0c628f Reviewed-on: https://chromium-review.googlesource.com/c/1297586 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#602250}
-
Esmael El-Moslimany authored
This is a follow-up CL to creating an alternative radio group called cr-radio-group and replacing all usages of paper-radio-group with cr-radio-group. Bug: 888922 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I6637190f8eb63409c16ff70f6a7bc65872442780 Reviewed-on: https://chromium-review.googlesource.com/c/1277526 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#602249}
-
Karan Bhatia authored
- Allow manifest version 2 to be used as "max_manifest_version". - Allow manifest version 3 to be used as "min_manifest_version". BUG=896897 Change-Id: I72009c94bb715b7de3606b013d8e4eb5c94f44af Reviewed-on: https://chromium-review.googlesource.com/c/1292903 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#602248}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/73f3917e89ca..41ed3e083ed5 git log 73f3917e89ca..41ed3e083ed5 --date=short --no-merges --format='%ad %ae %s' 2018-10-23 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision b1cb8571..5e500373 (601125:602066) Created with: gclient setdep -r src/third_party/webrtc@41ed3e083ed5 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I70217a4e62655c53e4d61d7b105fd03bd010c931 Reviewed-on: https://chromium-review.googlesource.com/c/1296866Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#602247}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f57470be7f99..63963f35905f Created with: gclient setdep -r src-internal@63963f35905f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Idd571ce51d826dc6a1f93fe7ef8c34de0829a88b Reviewed-on: https://chromium-review.googlesource.com/c/1297121Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#602246}
-
Jun Mukai authored
This CL changes the order of HideImpl and giving up the focus within DesktopWindowTreeHostMus. As is written in the comment, this is because some code like WindowActivityWatcher assumes the window is already invisible when the window gives up the focus. BUG=896080 TEST=interactive_ui_tests --enable-features=SingleProcessMash Change-Id: I48a45bbea87c2e66d9827d2f7776b038edfca512 Reviewed-on: https://chromium-review.googlesource.com/c/1297401Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#602245}
-
Xianzhu Wang authored
- Replace LayoutObject::SetBackgroundChangedSinceLastPaintInvaldiation() with LayoutObject::SetBackgroundNeedsFullPaintInvalidation(). - Previously we used SetShouldDoFullPaintInvalidation( PaintInvalidationReason::kBackground) in some cases, but it may miss invalidation of background painted on the scrolling contents layer. Now use the new method in all cases that the background needs full paint invalidation. - Move all view background paint invalidation into BoxPaintInvalidator. This simplifies the call sites which now just call SetShouldCheckForPaintInvalidation(), and make it possible to do just incremental invalidation instead of full invalidation when the browser control hides and background at the bottom appears on Android. - Other cleanups - New tests This is a preparation for SPv2 scrolling background invalidation. Bug: 732611 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I0d51d0788e614021c177de478e8cf70e5507aa7f Reviewed-on: https://chromium-review.googlesource.com/c/1289994 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#602244}
-
James Cook authored
It seems to pass now. Bug: 831826 Change-Id: Idacf939fcc05a76fa14824ffa3f5f2cc4f68f984 Reviewed-on: https://chromium-review.googlesource.com/c/1297403Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#602243}
-