- 20 Jul, 2020 40 commits
-
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I9e8e888b4ba8e46f7691a6c0a98804e813e20705 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308033Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790115}
-
Angela Yoeurng authored
This fixes a bug that causes a "ghost" remove suggestion button when button row is enabled, and removes duplicate logic. Bug: 1106062 Change-Id: I377b875fe2ec114c3ca9e708fa35cdf1c822f7f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304938Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Angela Yoeurng <yoangela@chromium.org> Cr-Commit-Position: refs/heads/master@{#790114}
-
Yao Xiao authored
- If there is a small overlay in the page (e.g. sticky ad on the side), and the user shrinks the viewport to make the overlay centered & relatively large, we don't want to consider it to be a "popup". - Changed all relevant tests to promise_test for better readability. - Removed most waitings in web_tests by disabling the frequency capping. - A bugfix: It was a no-op to compare last_detection_main_frame_size_ and main_frame_size after setting them equal. This patch moves the setting after the comparison. - An improvement/fix: for the current overlay candidate, always check element->IsAdRelated() in each detection, and update its ad status if it becomes an ad. Bug: 1032681 Change-Id: If1d945be69d51289cf3314b5700e265772f0087e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291211Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/master@{#790113}
-
Yuwei Huang authored
* Add stream request support to ProtobufHttpStatus, which includes some refactoring in the code. * Make ProtobufHttpClient directly own the requests, to make lifetime managing less painful. Bug: 1103416 Change-Id: I9c1f62acb4e02cd968387bc4cc34db8dd6268c25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299536 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#790112}
-
phillis authored
This moves installation logic for all OS hooks currently including shortcuts, shortcuts menu, file handler, run on OS login, quick launch bar to OsIntegrationManager. Bug: 1098027 Change-Id: I46765a7493274a545ffbfef274bdbfc7d3fecf2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2272120 Commit-Queue: Phillis Tang <phillis@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Anqing Zhao <anqing@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#790111}
-
Christopher Cameron authored
If the default assignment operator is called when |this| is populated, then the members will be moved in declared order. As a consequence, |this->representation_| will be overwritten and therefore deleted before |this_->scoped_read_access_|, which will cause a DCHECK (because scoped accesses may not outlive their representation). Bug: 894929 Change-Id: If342c05343511074376ac360b12fe3dd0eca94b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307150Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#790110}
-
David Bienvenu authored
Adds base::debug::alias for key_path and value when reading from windows registry. Bug: 1106328 Change-Id: Ibb936708ffd8b2ce6b759e61095528db2990a483 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304977 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#790109}
-
manuk authored
Before this CL, the input 'yz' could autocomplete '[x]yz yz'. With this CL, 'yz' will instead autocomplete '[xyz ]yz'. This isn't common because providers don't usually suggest suggestions when they only match the input midword. But, in examples like the above, the 2nd match would allow providers to provide the suggestion while RAC would match the 1st occurrence of the input. Bug: 1062446 Change-Id: Ic41feb7845f51c488e7cf6e9b731af4b81f6d08c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303645Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#790108}
-
Wez authored
Bug: 1107418 Change-Id: I6f6523e7f40382658e2d3f34b04fe48464658759 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306159 Auto-Submit: Wez <wez@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#790107}
-
Chris Harrelson authored
This code was originally added in [1]. The web_test added in that CL still passes, as does a subsequent related unittest added in another CL (PaintLayerPainterTest, PaintPhasesUpdateOnLayerAddition). I'm not sure what caused these to keep passing with the code removed - there is a reference in [1] to re-use of DisplayItemClient pointers, perhaps that was improved since then? [1] https://codereview.chromium.org/1403963002 The bug reported in issue 541544 also does not reproduce with this CL applied. Bug: 1104794 Change-Id: I91addcea57c217dd1f971fcc4dbae0cd518c7011 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307610 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#790106}
-
Richard Townsend authored
A change in dependencies means that a component with a MIDL dependency (third_party/iacccessible2) is now compiled for the x64 host and arm64. This caused problems because the host win_clang_x64 generated files typically live in out/<t>/win_clang_x64/gen/third_party/iaccessible2 whereas the arm64 files live in out/<t>/gen/third_party/iaccessible2, meaning that (when the path is rebased) the midl action tried to copy files from a missing win_clang_x64 directory in iaccessible2. Using the root_gen_dir instead fixes this depth mismatch. Bug: 1105878 Change-Id: I9403b0024c394b339168e47275d23240b55c3574 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302054Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Richard Townsend <richard.townsend@arm.com> Cr-Commit-Position: refs/heads/master@{#790105}
-
Sergey Ulanov authored
Previously VideoCaptureDeviceFactoryFuchsia was logging an ERROR when DeviceWatcher connection is disconnected, while this error is expected in some environments. In this change: 1. Fixed CastRunner to close DeviceWatcher with ZX_ERR_UNAVAILABLE when no applications have camera access. 2. Fixed VideoCaptureDeviceFactoryFuchsia to avoid logging errors for ZX_ERR_UNAVAILABLE. 3. Improved handling of disconnected state in VideoCaptureDeviceFactoryFuchsia: now it will reconnect the channel in CreateDevice(). 4. Added unittests for (3). TBR=guidou@chromium.org Bug: fuchsia:54060 Change-Id: Ib39fd1ef0d1a787f762bcd961196800105e45b97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246877 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: -
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8b4eeffd4628..b655a28e1097 2020-07-20 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I0e43c49ac916751c4d7d87ca86db696bd7eb8bcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308351Reviewed-by:
-
Akihiro Ota authored
This change does the following: 1. Adds CSS according to initial UI mocks 2. Adds JSDoc to member functions 3. Removes quotes from object keys 4. Removes underscores from function names. 5. Changes instances of "test" or "test area" to "practice" according to UX feedback. We also make these changes in the code for consistency. 6. Changes many instances of "container" to "screen". 7. Rename "routing page" to "main menu" per UI feedback. 8. General clean up and use less verbose language. --enable-experimental-accessibility-chromevox-tutorial flag. Manually verify that tutorial loads with new UI. Move through the tutorial using ChromeVox and verify no behavior change. Bug: 1075752 Change-Id: I4895d7ad153a5adf1fc1471b637ca0156cea6b99 AX-Relnotes: N/A Test: Run Chrome with the Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304443Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#790102}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: If933bbfe386d8b33878d5bf963a8f9cad091d7b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307657Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#790101}
-
Will Harris authored
The patching of user32!GetSystemMetrics no longer works on latest builds of Windows. The test is also disabled. There are tests for presence of the CFI flags in checkbins.py and a test for CFG within chromium binaries in base_unittests so no need for this additional test. BUG=584575 Change-Id: I0985d888ff371f826906639d3ca6faece50cb617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308409Reviewed-by:
Alex Gough <ajgo@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#790100}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b6e086dc..82a184f9 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Idc300c47989e819f4a249702fe58545dcdeae503 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308309Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790099}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I22e106407b96ca34c09e819cd68d14a2ce5101db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308358Reviewed-by:
-
Julian Mentasti-Meza authored
CreateFullPagePDF generates a single page PDF of the WebView and invokes a callback with the data. Bug: 1103777 Change-Id: I37683139e7b6bde34a86d96c9a6cce9c3db0f48a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293159 Commit-Queue: Julian Mentasti-Meza <jmentasti@google.com> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#790097}
-
Ilia Samsonov authored
Bug: 1068400 Change-Id: I947ea0889508b2d8522ef737750a74c48e69e64e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295814Reviewed-by:
-
Tim Volodine authored
Disable the following tests because they are failing on L/M Tablet Tester bots: TabStripTest#testCloseAllIncognitoTabsFromTabMenu TabStripTest#testCloseLastIncognitoTab TabStripTest#testCloseTabWithManyTabs TabStripTest#testNewIncognitoTabFromMenuAtNormalStrip TabStripTest#testSwitchStripStackersWithIncognito TabStripTest#testTabSelectionViewDoesNotBreakModelSwitch TabStripTest#testToggleIncognitoMode Note: TabStripTest#testSelectWithManyTabs was disabled in crbug.com/1107395. BUG=1107543,1107395 TBR=dtrainor@chromium.org Change-Id: I638033bf1f9b12e009dfbd2ff8b2e2128d000373 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308469Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#790095}
-
Torne (Richard Coles) authored
The function uses adb pull to fetch a directory, and relies on being able to do "adb pull /foo/src /existing/dir" and get a directory "/existing/dir/src" containing the files from "/foo/src". The adb pull helper checks that the pull succeeded by seeing if the destination path exists after the pull, but since the destination is an existing host directory this check always passes no matter what happened in the pull. Append the actual directory name we're interested in copying to the destination, so that the check will work as expected; this way if the pull doesn't work we will fail during the pull instead of failing when we do os.listdir() subsequently. Bug: 1106750 Change-Id: I73b4966cde926f756d5e6774d73b1bf27adaacf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308031Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#790094}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0dee9b0c410f..c8ae494401bc 2020-07-20 robertphillips@google.com Clean up more tests wrt GrContext 2020-07-20 jcgregorio@google.com Fix swiftshader Dockerfile. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: I1e8c161f6279b699af9e82e0a68b88d48bb9cfbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307810Reviewed-by:
-
Elly Fong-Jones authored
This is part of the process described in r783671. This change: 1) Adds an alias from installer::InitialPreferences to the existing installer::MasterPreferences 2) Migrates the chrome first run code to use that new alias Next steps are migrating every other client of MasterPreferences to use the new alias, then renaming the class itself. Bug: 1097204 Change-Id: I8c2f5d5a61aa127f116a255dbc2727b2f027559e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300600Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#790092}
-
Ben Pastene authored
It currently defaults to the 'release' image, which is internal & Google-only. We have some public testers that need to flash to the 'full' images. Adding the flag should let us do that by passing down the right type of image based on GN args, which get bound to tests via generated wrapper scripts. Bug: 1057152 Change-Id: Ib1a82eb16ca274fe1e04946b588ec2dc2e049c77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303981 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#790091}
-
Anders Hartvoll Ruud authored
A few not-so-related changes: - No need to use pointers to StyleCascade anymore, since it now always exists. - Rename ApplyAnimatedStandardProperties to ApplyAnimatedStyle, since that name definitely does not make sense anymore. (Both standard and custom properties are now applied here, unlike the non-CSSCascade branch). - Rename ApplyBaseComputedStyle to ApplyBaseStyle, for "symmetry" with ApplyAnimatedStyle. (It doesn't make sense to a "apply" a "computed style" anyway: the computed style is the output of the process, not the input). - Forward declare StyleCascade in style_resolver.h, and reorder list of forward declarations. (style_cascade.h is now not included in any other header, which is nice). Change-Id: I0db1c9f3dec3e06100009848bbedaece509e5874 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298007Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#790090}
-
Adam Rice authored
ReadableStream::LockAndDisturb() can no longer throw now that the V8 Extras implementation has been removed. Remove the ExceptionState& argument. Also remove the ScriptState::Scope from the method which is not needed. ReadableStream::GetReaderNotForAuthorCode() is never called on a locked stream, so it cannot throw. Remove the ExceptionState& argument. In order to ensure that ReadableStream::GetReaderNotForAuthorCode() is not called on a locked stream, check in BodyStreamBuffer::ExtractBody() whether the stream is locked or disturbed and throw an exception. This is only done when FetchUploadStreaing is enabled. This actually improves our alignment with the Fetch Standard and improves our test pass rate. Many fetch-related methods no longer need an ExceptionState& argument either, so remove those unneeded arguments too. Bug: 1010794 Change-Id: I6c84f8bff006c696edca13b7a46fcbc10c142201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217830 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#790089}
-
Vladimir Levin authored
The primary amount of work this patch does is ensures that RenderPassId is an explicit type that cannot be implicitly converted to other types (using util::IdType from base). Note that there is also a split between RenderPass and (new) RenderPassInternal classes. This is in preparation for having a CompositorRenderPass and AggregatedRenderPass which would differ at least in the type of Id that they have (possibly with more differences if there is something Compositor uses that Aggregator does not). R=weiliangc@chromium.org Bug: 1106418 Change-Id: Iaf6a5e4f654652d5dc724b20ba8908ddeeeec087 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305189Reviewed-by:
weiliangc <weiliangc@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#790088}
-
Daniel Classon authored
Fix: Add missing import to OsResetPageTest that caused a failure in Polymer3. Polymer3 tests failed in post-submit but weren't run in pre submit, leading to the error going unnoticed and forcing revert. Reverted CL: https://chromium-review.googlesource.com/c/chromium/src/+/2306122 Reason for revert: "Newly added test is failing: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/19641 https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8874475110456145024/+/steps/browser_tests/0/logs/Deterministic_failure:_OSSettingsResetPageV3Test.All__status_FAILURE_/0 Original CL: parameter from the URL and then focus on elements containing that settingId. Imported in the OS Reset Page." https: //chromium-review.googlesource.com/c/chromium/src/+/2296008/21 Description: "Added the Polymer Behavior to fetch the settingId Bug: 1084154 Change-Id: Ida343c79467d22571fe2a218c39c7e405f399800 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306556 Commit-Queue: Daniel Classon <dclasson@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#790087}
-
Sam Sebree authored
This change uses native_theme_base.cc to update the styling for the text input native controls in dark mode. Change-Id: I974f40933b755016aad46607f40f3899d8349be6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303604Reviewed-by:
Yu Han <yuzhehan@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Sam Sebree <sasebree@microsoft.com> Cr-Commit-Position: refs/heads/master@{#790086}
-
Ben Mason authored
Bug: 1023634 Change-Id: I72e977935e55c57df06fe8e21eaa14b8773fc833 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307811 Commit-Queue: Ben Mason <benmason@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#790085}
-
Robert Ogden authored
When Isolated Prerender encounters an ineligible redirect that is not the final URL, the after srp metrics do not get correctly updated. This CL fixes that by checking the whole redirect chain from the end to the beginning for metrics. Note that in practice this is only likely to affect the metrics on AMP pages and ads, since the Google SRP shortcuts redirect chains that Google doesn't otherwise create. Bug: 1106942 Change-Id: I26499291a4e8039d78524daf0d34dd4bc383af69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307535Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#790084}
-
Dave Tapuska authored
Move the message into blink with a callback. Progressively we will move the implementation into blink. But moving the message first allows us to move some of the implementation in stages. BUG=1097816 Change-Id: Ice0c372d4a6e83edffe2191b146a25144248a476 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302771 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#790083}
-
Megan Jablonski authored
Ensure that the focus is traversing on the language in which the page is translated. Bug: 1105807 Change-Id: I14a2b7a957c5ad8b581ca25a0d89a406ba3bfc52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300321Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Megan Jablonski <megjablon@chromium.org> Cr-Commit-Position: refs/heads/master@{#790082}
-
Alan Screen authored
This reverts commit 5eb76db1. Reason for revert: regression as reported in crbug.com/1107297 Original change's description: > Uncouple PDF printing metafile usage from plugin > > Printing from within the context of a pepper plugin for a Flash object > started crashing once the print composite usage stopped the inefficient > practice of generating metafiles for both individual pages and the full > document, in r751614. > > Even though this issue of printing a Flash object is not of much > interest because of Flash being near end-of-life, we can at least not > crash the tab on users who happen to invoke such a print. > > This restores ability of print preview to complete and provide page > images, although the content of the Flash object is empty. This at > least matches the behavior prior to r751614. > > Bug: 1098860 > Change-Id: I86f7030ade0f126d6994b810f26775bf8cfe2693 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298036 > Reviewed-by: Stefan Zager <szager@chromium.org> > Reviewed-by: Daniel Hosseinian <dhoss@chromium.org> > Commit-Queue: Alan Screen <awscreen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#789239} TBR=szager@chromium.org,awscreen@chromium.org,dhoss@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1098860 Change-Id: Ibe61026c24800742ee6810ca681243caa19976f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306920 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
-
Erik Chen authored
Change-Id: I9f4d492117256fa55cb96c4dbbfe064d5daf9f35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308190 Auto-Submit: Erik Chen <erikchen@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#790080}
-
Jimmy Gong authored
- Update the dialog text to have darker font and adjust padding. Before: https://screenshot.googleplex.com/51O69JaSOtH After: https://screenshot.googleplex.com/8J34MFu6N45 Bug: 1106144 Change-Id: I5df2c17e1c1edf62473131423ede8721dca27a73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304978 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Broadwell AFDO profile from 86-4181.3-1594633791-benchmark-86.0.4206.0-r1 to 86-4181.3-1595240638-benchmark-86.0.4207.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I5548e4dcd9e11d52a28da09bd32610d7c0c5a959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308361Reviewed-by:
-
Olivier Li authored
The new behavior (back-end dispatches to the ThreadPool) has been the default on stable since 84.0.4147.0. This CL includes some cleanup of base::Thread specific mechanisms now that a base::Thread is never explicitly instantiated. Bug: 1014464, 1067191 Change-Id: I64ecaaf2f68f39eff4600bc7bbcdd0f560fc724a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304774 Commit-Queue: Oliver Li <olivierli@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#790077}
-
Bettina authored
When the blocklist updates, the blacklist state map may be empty or does not include the remotely disabled extension. This means that not even a "NOT_MALWARE" is sent for the extension. The extension then gets put into no_longer_blocked which is not what is expected. Bug: 1107040 Change-Id: Ia58f0d7b831b54b02843d5c03f9179e84ec11ac5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305598 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#790076}
-
