GitLab

1. Remove the OnClientConnectionClosed() IPC from GPU to browser.  The
   browser never used the IPC so it wasn't necessary.
2. Destroy CompositorFrameSinkImpl when the client connection is closed.
   The object is useless after that point so it can be cleaned up.
3. Don't destroy RootCompositorFrameSinkImpl when the client connection
   is closed. The display compositor will continue to produce frames.

Bug: 814475
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Ie9a96ee504013435c23b05cf6dbaa3fda4e0fd33
Reviewed-on: https://chromium-review.googlesource.com/993993Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548305}

For support navigation change by gesture, we need to populate scroll
phase event from Direct Manipulation. We add a new flag
PrecisionTouchpadScrollPhase for this in case we want to turn off
this CL.

Bug: 647140
Change-Id: Id815d3d0b5ee09bc13aaa1c99423364fef04c310
Reviewed-on: https://chromium-review.googlesource.com/967103Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Martin Barbella <mbarbella@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: Sahel Sharifymoghaddam <sahel@chromium.org>
Commit-Queue: Jianpeng Chao <chaopeng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548304}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=amineer@chromium.org

Change-Id: Ie4c4e791eb4e4fd74f234f147c0942d092e2a851
Reviewed-on: https://chromium-review.googlesource.com/996854Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548303}

Fixed jumping during mouse wheel zoom.
Fixed jitter in network flamechart panning when main flamechart is panned with the mouse.
Fixed misplaced hover/selection after zooming.

Change-Id: I75bce65f8392922fa3e32f72731eebbce52b5450
Reviewed-on: https://chromium-review.googlesource.com/994285
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548302}

This reverts commit 52d81474.

Reason for revert: This causes display settings crash. crbug.com/829190

Original change's description:
> Actually check whether extension is in kiosk mode
> 
> Add the missing check for actually being in kiosk mode, but keep the
> autotest bail to simplify testing of the feature.
> 
> BUG=chromium:826568
> TEST=Ran autotest, verified that extension can't access edid.
> 
> Change-Id: I8f93e29d8d977b0977b3eb597ce2aae263b4e9b9
> Reviewed-on: https://chromium-review.googlesource.com/982619
> Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> Commit-Queue: Felix Ekblom <felixe@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#548147}

TBR=stevenjb@chromium.org,felixe@chromium.org

Change-Id: I0c72734b027c4920eb4ab341ca0813c645870f6c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:826568
Reviewed-on: https://chromium-review.googlesource.com/996933Reviewed-by: Weidong Guo <weidongg@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548301}

No logic changes. Just a spelling fix in a comment.

TBR=blundell@chromium.org

Bug: None
Change-Id: Ice5f572a695706850fb1a1e88d91a229ab7034df
Reviewed-on: https://chromium-review.googlesource.com/996895Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548300}

Copy the current members of API_OWNERS to //third_party/WebKit/OWNERS.
This CL has no behavior changes.

Change-Id: Ia82002c5a266c951ed80b63721fc35a952071390
Reviewed-on: https://chromium-review.googlesource.com/987592
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548299}

The individual bridges can always convert from Profile* to profile id
easily, but the reverse is not true. This is an issue when the profile
manager is shutting down because the reverse lookup depends on the
profile manager still being operational.

Unlike when the bridge is handling interactions with a notification,
the profile must already be loaded when Display(), Close() or
GetDisplayed() is called.

This is blocking fixing some bugs in NotificationPlatformBridgeChromeOs:
https://chromium-review.googlesource.com/c/chromium/src/+/979268

Bug: none
Change-Id: Ibcb2b61cf2f03408a432edfd0a252ec01e9fe30b
Reviewed-on: https://chromium-review.googlesource.com/982648
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548298}

PopupWindow.showAtLocation takes the window token from the view passed
in, and AnchoredPopupWindow passes in the root view. This all means that
it's very unlikely that there is a mistake in set up that can cause
BadTokenException. So the only explanation is that the Activity actually
is gone or hidden, which is a real edge case. So just swallow the
exception instead.

Bug: 826052
Change-Id: Ib966d8900530a25b93849ff17b91431df5e38c43
Reviewed-on: https://chromium-review.googlesource.com/996561
Commit-Queue: Bo <boliu@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548297}

This patch adds support for some grid properties.

We add a new <flex> CSS value object, which meant rebaselining all the tests.

We're failing some tests because the 'grid', 'grid-template' and
'grid-gap' shorthands don't serialize to anything [1], so Typed OM
can't create an unsupported style value from it. Not sure if this is
a bug...

[1] https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/css/StylePropertySerializer.cpp?type=cs&l=406

Bug: 820299
Change-Id: I8ff871fffed2977ca20a623bd283d7cbdc247870
Reviewed-on: https://chromium-review.googlesource.com/984756
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548296}

This patch introduces an infinite deadline as a possible DeadlinePolicy
choice. This would be used in the future when a forced surface
synchronization is requested.

R=fsamuel@chromium.org, piman@chromium.org

Bug: 667551
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Iad25d2fd7a8c65e5b53034b448029f463ed717a3
Reviewed-on: https://chromium-review.googlesource.com/996762Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548295}

This patch adds launcher items for Crostini apps, which launch apps via
a D-Bus call to concierge (the D-Bus client code is also added in this
patch).

There are of course a lot of things missing, e.g. proper icons, name
localization, the context menu for app icons, and updating the launcher
when the registry is updated.

Bug: 821662
Change-Id: I12f9be995a56a29ed438a54c38d8f55cd140dffb
Reviewed-on: https://chromium-review.googlesource.com/995113Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548294}

BUG=none
TEST=none
TBR=estade

Change-Id: Ida938109e9ce253f9c496be144c3ca5828f609a6
Reviewed-on: https://chromium-review.googlesource.com/996919Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548293}

Creating a set of RootFrameSinks which will be updated at every
registering/unregistering of support if it's a root support. Also adding
a method to get the children FrameSinkIds by parent. Both of these will
be used to build a FrameSink tree. We intend to track all the FrameSinks
that are created/destroyed, even those that correpond to tooltips,
options menu, etc. Since we create a RootCompositorFrameSink for a
tooltip or the options menu we keep all the RootFrameSinkIds in a set and
insert into this set or erase from the set when RootFrameSink is created
or destroyed respectively.

Adding a method to get a FrameSinkSupport by id. This will be used for
CSS properties and additional attributes (like LastBeginFrameArgs).

Bug: 816802
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I41a69716a591a7f8c57cd7785a45036730b731c8
Reviewed-on: https://chromium-review.googlesource.com/984035Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Illia Martyniuk <illiam@google.com>
Cr-Commit-Position: refs/heads/master@{#548292}

Create an origin trial for WebXR and a separate one for exposing controllers as Gamepads.
Controllers will still be exposed as Gamepads by default for WebVR origin trial, but must be
enabled separately for WebXR.

Bug: 779691

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I639b259ea2a583bdbd3f18b6d30b7e107cdb21c1
Reviewed-on: https://chromium-review.googlesource.com/982679
Commit-Queue: Anna Offenwanger <offenwanger@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548291}

- Add MRDialogControllerViewsImpl stub
- Rename MRDialogControllerImpl to MRDialogControllerWebUIImpl
- Factor out parts that are common across WebUI and Views into
  MRDialogControllerImplBase
- MediaRouterDialogControllerImplBase::GetOrCreateForWebContents() is
  implemented in two places: mrdc_views_impl.cc for builds with Views,
  mrdc_webui_impl.cc for builds without.

Bug: 826091
Change-Id: I276d46ba870b837c5b35f48a4921a3df356aa565
Reviewed-on: https://chromium-review.googlesource.com/990572Reviewed-by: Derek Cheng <imcheng@chromium.org>
Reviewed-by: Adam Parker <amp@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548290}

VR wants to support autofill popup behind a flag.
We can remove the check completely when the flag is removed.

Bug: 819881
Change-Id: I390a6fd425b81238f255d85dc84f18e41291828e
Reviewed-on: https://chromium-review.googlesource.com/992889Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Amirhossein Simjour <asimjour@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548289}

This CL checks VEA flush behavior by adding two states: CS_FLUSHING
and CS_FLUSHED. Now the encoding flow becomes:

- Set state from CS_ENCODING to CS_FLUSHING
  when the client sends the last frame and calls VEA::Flush(flush_cb)
- Set state from CS_FLUSHING to CS_FINISHED
  when the client receives the last encoded frame
- Set state from CS_FINISHED to CS_FLUSHED
  when flush_cb(success=true) is called
- Set state to CS_ERROR if either of situation is true:
  - flush_cb(success=false) is called before last encoded frame is
    received
  - flush_cb(success=true) is not called in a period of time
    (e.g 200 ms) from VEA::Flush() is called.

BUG=chromium:820313
TEST=Run video_encode_accelerator_unittest at scarlet device

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I2a83b0e7f902575b084ae4ccf85f3ba7d5f74819
Reviewed-on: https://chromium-review.googlesource.com/908370Reviewed-by: Kuang-che Wu <kcwu@chromium.org>
Commit-Queue: Chih-Yu Huang <akahuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548288}

Notifications can be disabled for a number of
reasons. This logs those reasons with UMA.

This is a retry of my earlier CL, but does
not abort if getting settings failed (not
a fatal failure anyway).

Bug: 734095
Change-Id: I9a04f666e8181d87fd945fcdcac0c3a0371aa2f0
Reviewed-on: https://chromium-review.googlesource.com/995536Reviewed-by: Xi Cheng <chengx@chromium.org>
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548287}

In https://chromium-review.googlesource.com/c/chromium/src/+/957645, I
accidentally introduced a crash (crbug/828814) which could occur if
content verification was running as Chrome was shutting down.

According to |KeyedServiceBaseFactory::AssertContextWasntDestroyed|,
service getting (ExtensionRegistry is a service) should only be done on
the main thread.

This CL stores the data which was read from the extensionregistry
(the extension's background scripts, page and content script file_paths)
in the ContentVerifierIOData instead.

Bug: 828814,809088
Change-Id: I7d2a326c5ea609f996bd0af2a6d490108a99e772
Reviewed-on: https://chromium-review.googlesource.com/996489
Commit-Queue: proberge <proberge@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548286}

When panning, rather than only waiting for a mouse move event before
switching to the hand cursor, check for middle mouse up/down events in
non-link areas and switch from/to the hand cursor immediately.

BUG=234933

Change-Id: I29661a7f60ccafdc710c639ab1206a566705272e
Reviewed-on: https://chromium-review.googlesource.com/996384Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548285}

After the user clicks on details on the page info dialog always dismiss
the page info dialog. By doing so, the dialog disappears in VR before
showing the user the exit VR request. That is consistent with what
happens when the user clicks the site settings button.

Bug: 829043
Change-Id: Id51477f08cf693107d11044c7ca2ec477c0118f8
Reviewed-on: https://chromium-review.googlesource.com/996305
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548284}

ExtensionTestMessageListener::WaitUntilSatisfied() is used to wait for
a specific message from an extension and return a result.
WaitUntilSatisfied() returns a bool indicating success, but this can be
false (i.e., failure) in certain circumstances. Add WARN_UNUSED_RESULT
so that callers must handle the returned bool, rather than only waiting
for the listener to be satisfied.

Bug: None
TBR=benwells@chromium.org (apps/, c/b/apps/)
TBR=stevenjb@chromium.org (c/b/chromeos, c/b/ui/ash/launcher/)

Change-Id: Ied7b2cd5e5006531a117158812dad5d39b673786
Reviewed-on: https://chromium-review.googlesource.com/989278
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548283}

On all other platforms //device/usb uses a custom backend. This patch
ensures that we are not including libusb in unexpected build
configurations.

Change-Id: Ia1b68e86048af7ed98d27b19f46f74ceba50097b
Reviewed-on: https://chromium-review.googlesource.com/996407Reviewed-by: Jun Cai <juncai@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548282}

Also, dropped the word "container" from AXPosition::Create...PositionInContainerObject for better readability and faster typing.
R=dmazzoni@chromium.org, aleventhal@chromium.org

Bug: 639340
Change-Id: I75c10bb35435a7cad9988e30a54af60f525bb29c
Reviewed-on: https://chromium-review.googlesource.com/995639
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548281}

This relaxes the check for the Samsung workaround landed in
http://crrev/c/924115, so that the workaround applies for Samsung's
other mail app which also reproduces this behavior.

Although the other mail app is referred to as
"com.samsung.android.email.provider" in our communication with them, its
implementation is actually split among 5 different APKs, and it is
"*.composer" which actually exhibits the bug.

As it turns out, the bug reproduces under the exact same sequence of
URL navigations as the other app (a file:// URL followed by
loadDataWithBaseURL("email://")).

As with http://crrev/c/924115, this is also meant as a temporary
workaround.

Bug: 781535
Test: Use both Samsung apps, test the 3 repro conditions listed in b/70696775.
Change-Id: Ic897a33dc52b78e83eaada5b4b66c555a0eb3679
Reviewed-on: https://chromium-review.googlesource.com/981691
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548280}

This allows a target to include private headers it wouldn't otherwise be
able to include. A target can provide a list of patterns of friend
targets that allow dependent targets to bypass public header checking.

A proper dependency path is still required, this applies only to the
concept of public/private headers on a target. Without this, it's
difficult to make a target be explicit about its public headers while
also allowing that target's own tests to use internal headers.

BUG=732993

Change-Id: I1cb94c7ac0db6f74cdcd49d08bcabedf70ea3eb0
Reviewed-on: https://chromium-review.googlesource.com/994453
Commit-Queue: Brett Wilson <brettw@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548279}

https://chromium-review.googlesource.com/c/chromium/src/+/681850 changed
the default run loop on Mac, which broke our capturer (it started
returning zero-size frames for all but the initial capture). I'm not
sure what our dependency on MessagePumpCFRunLoop is, but switching to a
UI thread means that the capturer has access to one again.

Change-Id: I9ac8ac19f325f88f9e758613f50ac2a2a00dc01d
Bug: 827300
Reviewed-on: https://chromium-review.googlesource.com/996296Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548278}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/68c9ef31..447b127a

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I709a3df80d9fd16893c40a1cbeddf8cf39bf9432
Reviewed-on: https://chromium-review.googlesource.com/996037Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548277}

https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/5baad932589a..dee930847568

$ git log 5baad9325..dee930847 --date=short --no-merges --format='%ad %ae %s'
2018-03-30 fdegans Prepare for |is_posix| switch in the Fuchsia build

Created with:
  roll-dep src/third_party/ffmpeg

Bug: 812974
Change-Id: I28381804667b9b6a2fd085545db6bf3c80cd3009
Reviewed-on: https://chromium-review.googlesource.com/996474Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548276}

Cleanup: there is no logic changes in this CL.

I tried making an edit in this file and found there were many small
style issues*. These changes, done separately, can keep my other CL
cleaner:
- fix use of NULL instead of nullptr
- fix lines over 80 chars long
- fix 3 space indenting
- fix 1 space indent on eol comments
- fix use of assert true for comparison
- fix suggetion to suggestion

*Which create a big list of warnings, making it hard to see if I've
introduced new issues.

TBR=mpearson@chromium.org

Bug: None
Change-Id: I4252ea4c62f33ff201ee80179150c7f10b13084f
Reviewed-on: https://chromium-review.googlesource.com/996752
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548275}

This adds VrPopupWindow to VrUiWidgetFactory. As a result, if the
web content asks for a autofill popup, the Vr compatible one will
show.

Bug: 819881
Change-Id: Ia0ef837eaf4fea744472337feeb1b658d3cfb24d
Reviewed-on: https://chromium-review.googlesource.com/986887
Commit-Queue: Amirhossein Simjour <asimjour@chromium.org>
Reviewed-by: Biao She <bshe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548274}

Bug: 812974
Change-Id: If3b39236ddc753f8ef3f8caab4b8c2a5b12497fd
Reviewed-on: https://chromium-review.googlesource.com/988799
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Tommi <tommi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548273}

Bug: 793301
Change-Id: I439f64d2c68c965881ab69b297b0bbabfd68b31d
Reviewed-on: https://chromium-review.googlesource.com/986053
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548272}

BUG=none
TEST=none
TBR=rjkroege@chromium.org

Change-Id: Ic63d88124d37c50f6bea881b5afcd888c7fc4fca
Reviewed-on: https://chromium-review.googlesource.com/996808
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548271}

Added a "MacViewsAutofillPopup" feature flag and
--mac-views-autofill-popup switch. If it's enabled,
show the Autofill popup view using toolkit instead of
cocoa.

Removed AutofillPopupBaseView FocusManager accelerator code.
The code is no longer necessary since it was added for a now
obsolete rAc dialog. The autofill popup will get dismissed by
the web contents, which listens for the accelerators.

This is a reland of
https://chromium-review.googlesource.com/c/chromium/src/+/889983

The CL was reverted because of a crash (https://crbug.com/809830)
which was caused by the popup's container view's window set to
nil.

Bug: 728182
Change-Id: I02f74b5627e6559c4e4dd77a35860e77d000a0d5
Reviewed-on: https://chromium-review.googlesource.com/974106Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548270}

When an extension is granted tab permission using activeTab (in response to say
clicking on its browser action), the extension is granted permission to the
tab's origin for the duration of the tab lifetime.

When this happens for a tab with a file url loaded, the extension gets
permission to the file scheme on the tab. This allows, for example, the
extension to read the contents of the page using apis like
chrome.tabs.executeScript. For file urls, this is not ideal since this does not
respect the "Allow access to file URLs" extension setting.

This CL changes this behavior, gating the access to the file scheme on the tab,
on the extension having explicit file access. This CL also adds extensive test
coverage for the behavior of tabs.executeScript on pages with file urls loaded
into them.

BUG=816685

Change-Id: I9175bb1883006fe594a93262c6825a962c285037
Reviewed-on: https://chromium-review.googlesource.com/994264
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548269}

Instead of writing base::Version(version_info::GetVersionNumber()).

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I0a2c0826ffced29d22151bac51537da227b6dd95
Reviewed-on: https://chromium-review.googlesource.com/989092Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548268}

Users of AGSA have long had feedback that the download complete notification
resulting from CCT usage is incongruent with the perceived usage of AGSA
instead of Chrome. This attempts to fix it by suppressing the download complete
notification for versions of AGSA that support issuing their own notification

Bug: 812022
Change-Id: I099e8a3db0bb4984cfd2782d5442cffabbacf765
Reviewed-on: https://chromium-review.googlesource.com/952025
Commit-Queue: Cathy Li <chili@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548267}

When calling the build/android/tombstones.py script, used to
extract tombstones and properly resolve symbols for Chromium
libraries, 'aapt dump badging' is called repeatedly on all
files matching $CHROMIUM_OUTPUT_DIR/apks/*.apk, in order to
extract their package names.

This patch helps speed up this process considerably by caching
the result for each APK (hence each file will be read only once
now).

Time comparison for the following command (for an Android/x86 build).

  third_party/android_platform/development/scripts/stack.py \
      --arch x86 \
      --output-directory out/Emulator \
      --more-info \
      /tmp/tombstone_08

Before: 1m 48s  -->  After: 23s    (same results)

+ Rename symbols.GetAapt() to _GetAapt() to make it private,
  and use constants.ANDROID_SDK_TOOLS to find the location of
  the 'aapt' binary used to extract package names. Note that
  the use of the SDK_HOME environment is preserved unchanged
  at the moment (though is probably not needed).

+ Rename GetApkPackageName() to _GetApkPackageName() and
  remove its 'aapt' parameter and speed it with a small
  cache.

+ Rename GetCandidateApks() to _GetCandidateApks() and
  use a small cache to avoid hitting the filesystem everytime
  this is called, since the result will not change between
  invokations.

+ Simplify GetMatchingApks() implementation.

+ Fix minor typos.

NOTE: There are still many many things that are really wrong
      in this script. In particular, it cannot work properly
      with component builds, and will fail to work in the
      future when Chromium will be installed as a set of
      APK splits. Another point is the reliance on the global
      ARCH variable which is liberally modified directly by
      other Python scripts all over the place (ugh...).

      These will be addressed in future CLs.

BUG=774267
R=agrieve@chromium.org,hzl@chromium.org, jbudorick@chromium.org, mattcary@chromium.org

Change-Id: If130a668dd592b682d7fa98012745704a74fb850
Reviewed-on: https://chromium-review.googlesource.com/995932
Commit-Queue: David Turner <digit@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548266}