GitLab

It currently just uses 1.0. Instead, fetch it with
ui::GetScaleFactorForNativeView and invalidate it when the scale factor
changes.

This is a small fix for a simple HiDPI bug, but eventually we will be
able to scrap CachedLabel: The performance improvement it offers will be
redundant with http://crbug.com/240037.

BUG=368493

Review URL: https://codereview.chromium.org/405373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284649 0039d316-1c4b-4281-b951-d872f2087c98

Originally, AppListDialogContentsView extended WidgetDelegate directly,
and was not being detected as a dialog correctly on some platforms.
Updated AppListDialogContentsView to now be a DialogDelegate.

BUG=388637

Review URL: https://codereview.chromium.org/405873003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284648 0039d316-1c4b-4281-b951-d872f2087c98

This matches current definition in the design doc[1] and unifies phase name between Chromium and Blink. Telemetry already expects both "i" and "I" values [2].

It used to be "I" in Chromium but it was changed in https://chromiumcodereview.appspot.com/12252058/

[1] https://docs.google.com/a/chromium.org/document/d/1CvAClvFfyA5R-PhYUmn5OOQtYMH4h6I0nSsKchNAySU/edit#
[2] https://code.google.com/p/chromium/codesearch#chromium/src/tools/telemetry/telemetry/timeline/trace_event_importer.py&q=%22elif%20phase%20==%20'I'%20or%20phase%20==%20'i':%22&sq=package:chromium&type=cs&l=252

BUG=None

Review URL: https://codereview.chromium.org/399423005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284644 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284643 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Revert of Update V8 to version 3.28.30 (based on bleeding_edge revision r22489). (https://codereview.chromium.org/405313002/)

Reason for revert:
See https://code.google.com/p/chromium/issues/detail?id=395882

The reason for the test failures in blink has been fixed with the last blink roll.

Original issue's description:
> Revert of Update V8 to version 3.28.30 (based on bleeding_edge revision r22489). (https://codereview.chromium.org/407733005/)
> 
> Reason for revert:
> Seems to be causing xss-DENIED-method-with-iframe-proto.html to time out on multiple bots; see http://crbug.com/395882 .
> 
> Original issue's description:
> > Update V8 to version 3.28.30 (based on bleeding_edge revision r22489).
> > 
> > Please reply to the V8 sheriff svenpanne@chromium.org in case of problems.
> > 
> > TBR=svenpanne@chromium.org
> > 
> > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284420
> 
> TBR=svenpanne@chromium.org,machenbach@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284572

TBR=svenpanne@chromium.org,pkasting@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/411453003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284642 0039d316-1c4b-4281-b951-d872f2087c98

Also removes the unused tpm_token_name_ member from TPMTokenLoader.

BUG=NONE
R=stevenjb@chromium.org

Review URL: https://codereview.chromium.org/408853004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284641 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284640 0039d316-1c4b-4281-b951-d872f2087c98

'WebURLRequest::TargetType' has been dropped in Blink in favor of
'RequestContext' and 'FrameType', matching the Fetch specification's
changes, and allowing both more granularity in various Blink-side checks
and more clarity around the thing that caused a request, and the frame
that the request affects.

This CL should have zero practical effect, as it's simply hoisting the
translation work that 'WebURLRequest::setTargetType' is already doing
up into the content layer to bring us one step closer to removing the
concept entirely.

BUG=390497

Review URL: https://codereview.chromium.org/409583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284639 0039d316-1c4b-4281-b951-d872f2087c98

When an X.509 certificate appears invalid because it is expired or not yet 
valid, but we have reason to believe the clock is wrong, help users find out 
how to fix their clock.

A future CL will run a check for the time at startup (and periodically
after?) and raise an infobar with similar functionality, as well.

BUG=349653

Review URL: https://codereview.chromium.org/397713007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284638 0039d316-1c4b-4281-b951-d872f2087c98

The api will be used by Easy Unlock component app. Currently it contains
methods needed for establishing secure communication channel on top of
(unprotected) bluetooth.

BUG=390230

Review URL: https://codereview.chromium.org/391513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284637 0039d316-1c4b-4281-b951-d872f2087c98

BUG=395468

Review URL: https://codereview.chromium.org/409543005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284636 0039d316-1c4b-4281-b951-d872f2087c98

BUG=394273

Review URL: https://codereview.chromium.org/399003002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284635 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/401053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284634 0039d316-1c4b-4281-b951-d872f2087c98

1. android uses stlport in ndk library,
   and this library does not have same demangled name with libc++ stl.
   so we can get rid of tc-std-* from android policies.
2. tc-stl-node and tc-stl-vector have same stackstrace.
   so I changed std-node to std-other to hook all other std mallocs.
3. tc-toplevel-string regex has changed.

Bug=None
NOTRY=True

Review URL: https://codereview.chromium.org/387313003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284633 0039d316-1c4b-4281-b951-d872f2087c98

It needs to depend on the allocator gyp target to pick up the
/NODEFAULTLIBS flags for libcmt.lib and libcmtd.lib and avoid
link errors about multiple definitions of allocation related
symbols.

BUG=
TEST=extensions_unittests links in non-components Debug build on Win

Review URL: https://codereview.chromium.org/394353008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284632 0039d316-1c4b-4281-b951-d872f2087c98

The file names now match the class name.

BUG=none
TEST=none
R=estade@chromium.org

Review URL: https://codereview.chromium.org/404553008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284631 0039d316-1c4b-4281-b951-d872f2087c98

VisualStudio does not understand it \u escape sequences like \u00E8 in
UTF8 strings. The fix is to use Wide strings and convert them into UTF8
using base::WideToUTF8() utility.

BUG=395401

Review URL: https://codereview.chromium.org/403233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284629 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Run the vda_unitest on GLX and EGL machines.

Review URL: https://codereview.chromium.org/400353007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284628 0039d316-1c4b-4281-b951-d872f2087c98

[ServiceWorker] Propagates ServiceWorker fetched response's URL and wasFetchedViaServiceWorker flag.

If the request was fetched via a ServiceWorker, the URL of the response could be different from the URL of the original request. 
The URL must be checked in the renderer process for CSP and CORS.

So in this patch I introduce was_fetched_via_service_worker flag and original_url_via_service_worker which are set in ServiceWorkerURLRequestJob and propagated to the renderer process.


This change depends on http://crrev.com/370733002 and http://crrev.com/378473002.

BUG=373120

Review URL: https://codereview.chromium.org/375513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284627 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Disable exceptions on Windows also in the shared_library build (https://codereview.chromium.org/404853002/)

Reason for revert:
Speculative revert to try to fix chrome_elf_unittests on Win7 x64.
http://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20%282%29/builds/18370
  AddDllsFromRegistryToBlacklist
  LoadBlacklistedLibrary

I'll reland if that's not it.


Original issue's description:
> Disable exceptions on Windows also in the shared_library build
> 
> They were previously only disabled in static_library builds. This is believed
> to have been due to problems with old MSVC versions, but it should work now.
> 
> This change is relevant for Clang, which currently doesn't support exceptions
> on Windows.
> 
> Last time I attempted to do this, it broke some tests due to a debug assertion.
> Gtest had previously been catching the exception, but with exceptions disabled
> it crashed. Those tests were actually broken in static_library Debug builds
> too, but we don't seem to have bots for that. After Blink r176189, we no longer
> hit that debug assertion, so the tests now pass.
> 
> BUG=82385
> TEST=blink_platform_unittests --gtest_filter=DateTimeFormatTest.CommonPattern,
>      content_browsertests --gtest_filter=RenderViewImplTest.SetEditableSelectionAndComposition
>      webkit_unit_tests
> 
> R=thakis@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284519

TBR=maruel@chromium.org,thakis@chromium.org,hans@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=82385

Review URL: https://codereview.chromium.org/410613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284626 0039d316-1c4b-4281-b951-d872f2087c98

On Windows the message pump code tried to manage the systemwide timer resolution to fire delayed tasks with better than 15ms resolution but it was buggy:

1- A short task that was not followed by any other task will leave the systemwide timer pegged to 1ms

2- After we decided to crank up the timer we would 'lease' the timer for 1 second, for no good reason.

Both issues are detrimental to battery power.

The source of both problems is that we tried to decide with incomplete information. This patch solves that by having 1 bit for each pending task that requires a high resolution timer and a sum of the number of tasks that require high res timers.

BUG=153139
TEST=included here, also see the bug for manual testing.

Review URL: https://codereview.chromium.org/395913006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284625 0039d316-1c4b-4281-b951-d872f2087c98

Subsequent calls to EmbedRoot are now delegated to the window manager. This allows an application that was not created via the embed flow to obtain a connection to the view manager by asking the view manager init service to embed it somewhere. The init service just forwards this to the window manager. This is effectively like asking the window manager to create a toplevel window.

R=sky@chromium.org
BUG=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284322

Review URL: https://codereview.chromium.org/403083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284624 0039d316-1c4b-4281-b951-d872f2087c98

invalidation_util.cc has the following include:

invalidation_util.cc is in the target
sync_internal_api. sync_internal_api doesn't depend on
cacheinvalidation_proto_cpp which is what generates types.pb.h.

BUG=395846
TEST=none
R=tim@chromium.org

Review URL: https://codereview.chromium.org/410503002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284623 0039d316-1c4b-4281-b951-d872f2087c98

Since hiding Chrome hides all apps, this informs the shims that their
app is hidden. This ensures that a unhide is fired when the shim is next
focused.

BUG=355397

Review URL: https://codereview.chromium.org/403743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284622 0039d316-1c4b-4281-b951-d872f2087c98

Ensure that the members are fully cleaned up during disconnection,
before the object gets destroyed (which can happen on a random thread).
Otherwise the members may be destroyed on the wrong thread, triggering
DCHECKs.

BUG=395312

Review URL: https://codereview.chromium.org/406123002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284621 0039d316-1c4b-4281-b951-d872f2087c98

https://chromium-review.googlesource.com/207610 modified cros-disks to
report, via the GetDeviceProperties DBus method, if a disk is on a
removable device. This CL updates the CrosDisksClient to make sure of
that.

BUG=393345
TEST=Unit tests and manually tested a few removable USB/SD media.

Review URL: https://codereview.chromium.org/391783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284620 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284613 0039d316-1c4b-4281-b951-d872f2087c98

BUG=395357

Review URL: https://codereview.chromium.org/404613007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284611 0039d316-1c4b-4281-b951-d872f2087c98

These crept in from a changelist written before the refactor which landed after it.

BUG=394944

Review URL: https://codereview.chromium.org/400673006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284610 0039d316-1c4b-4281-b951-d872f2087c98

Both BULID files and source code were checking for a Chrome-branded build, but
not also an Official build type.

BUG=388419
TBR=piman@chromium.org

Review URL: https://codereview.chromium.org/406523006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284609 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284608 0039d316-1c4b-4281-b951-d872f2087c98

https://skia.googlesource.com/skia/+log/ad1df153a16b7723d2d4afd13627919fc3ee87ce..b85a0aab6905af8b329539b7573a7555b727d5e5

CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_layout_rel
TBR=robertphillips@google.com
BUG=

Review URL: https://codereview.chromium.org/408073003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284607 0039d316-1c4b-4281-b951-d872f2087c98

Without PurgePluginListCache(), the plugin list info in existing renderer processes
is not updated. User has to close the original tab and open a new tab to be able to
load the plugin.

BUG=394988
TEST=CDM loaded after refreshing tab after CDM update now.

Review URL: https://codereview.chromium.org/400273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284606 0039d316-1c4b-4281-b951-d872f2087c98

This CL does 2 things:

1. The setting of App Launcher dr=1 is now only used for GOOGLE_CHROME_BUILD.

2. Refactoring: In r273321, we extracted AppRegistrationData from BrowserDistribution,
and make it part of BrowserDistribution by composition. In this CL, we
use this new flexibility, and cut the dependence of app_list_service_win.cc
on ChromeAppHostDistribution by just giving it the AppRegistrationData part
it needs.

The required const kAppLauncherGuid now lives in chrome_launcher_support.

BUG=297647

Review URL: https://codereview.chromium.org/374413004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284605 0039d316-1c4b-4281-b951-d872f2087c98

Revert of cc: Change TileManager iterators to be queues. (https://codereview.chromium.org/406543003/)

Reason for revert:
TileManagerTilePriorityQueueTest.EvictionTilePriorityQueueWithOcclusion consistently times out on Win7 bot
http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/29899


Original issue's description:
> cc: Change TileManager iterators to be queues.
> 
> This patch is mostly just moving code around. It moves the iterators
> from tile manager to be in separate files, renames them to be queues.
> 
> It also adds a tile manager client interface for building the queues.
> 
> The rest is just fix ups for the tests.
> 
> R=reveman
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284506

TBR=reveman@chromium.org,vmpstr@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/406183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284604 0039d316-1c4b-4281-b951-d872f2087c98

Before: https://drive.google.com/file/d/0B1B1Up4p2NRMLTQ1ZFc0blIwbzA/edit?usp=sharing
After: https://drive.google.com/file/d/0B1B1Up4p2NRMVUloNWhYY1luQjg/edit?usp=sharing

BUG=NONE
TEST=Start Chrome with --new-profile-management. Click on the avatar button.
The bubble's right edge should be perfectly aligned to the button's edge.

Review URL: https://codereview.chromium.org/404443008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284603 0039d316-1c4b-4281-b951-d872f2087c98

Instead, just use plain gdb, which should be able to handle 32-bit binaries.

NOTRY=true

Review URL: https://codereview.chromium.org/404303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284602 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/409673003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284601 0039d316-1c4b-4281-b951-d872f2087c98

BUG=160586

Review URL: https://codereview.chromium.org/385263004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284600 0039d316-1c4b-4281-b951-d872f2087c98

Adding an Init method to the Broadcaster, that gets invoked while initializing the host.
The Init method broadcasts the original on_power_battery value to the new processes.

BUG=153139

Review URL: https://codereview.chromium.org/401083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284599 0039d316-1c4b-4281-b951-d872f2087c98