GitLab

BUG=762641
TBR=oshima@google.com

Change-Id: Ib25cae8dee9ae82cb2567d99abd2603f3a594125
Reviewed-on: https://chromium-review.googlesource.com/1128759
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573551}

Since the width is given in pixels which is correct
only on the display with the same DSF, the width needs to
be multiplied by phanton window scale / source scale.

BUG=861967
TEST=Manual. See bug for repro step.

Change-Id: Ib073bb705d8998cf07f41f9d646f0c23828b48de
Reviewed-on: https://chromium-review.googlesource.com/1130595Reviewed-by: Jun Mukai <mukai@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573550}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c9b520351974..1e61e482fbbb


Created with:
  gclient setdep -r src-internal@1e61e482fbbb

The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I6534d37e6c439320fa041f365372f430727328c0
Reviewed-on: https://chromium-review.googlesource.com/1130183Reviewed-by: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#573549}

The text representation can be easily copied to the symbolization service.

BUG=803276

Change-Id: Ice8157f0ba7544be4b300d5a97df36d41cc02db6
Reviewed-on: https://chromium-review.googlesource.com/1130498Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573548}

On certain Android devices, when disconnecting from WIFI, the network
code will report NETWORK_TIMEOUT before NETWORK_DISCONNECT and trigger
auto download resumption. And we erase the data downloaded by parallel
requests, so the download percentage will go backwards.

Instead, we should keep the slice info when resume with an error.

TBR=dtrainor@chromium.org, qinmin@chromium.org

Bug: 837128
Change-Id: I59ddb7ff57551beb862884febe2de3f3ee9e1359
Reviewed-on: https://chromium-review.googlesource.com/1130349Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573547}

Methods, like .complete(), show(), etc. always return a new object. They
should probably be marked as [NewObject].

This is no behavior change. So, no requires a "intent to implement".

Releated spec change:
  https://github.com/w3c/payment-request/pull/746

Bug: none
Change-Id: Ib4646a77ab7426310c42011d69c410ef104a91a4
Reviewed-on: https://chromium-review.googlesource.com/1128825Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#573546}

This CL refactors RulesMonitorService. In particular, inner classes
FileSequenceState and FileSequenceBridge are introduced to handle the file
sequence operations. Also, while loading a ruleset on the file sequence, instead
of hopping directly to the IO thread, we return the result to the UI thread,
which then decides what to do. And unloading a ruleset now proceeds directly to
the IO thread instead of hopping to the file sequence first. This refactoring is
in preparation for a subsequent CL which will handle indexed ruleset corruption.

This CL does not introduce any behavior change.

BUG=852058

Change-Id: Idad96dcacc4563c1936890daf3c7bd548b9d4319
Reviewed-on: https://chromium-review.googlesource.com/1119635
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573545}

I don't know what ui/latency does, but the test is small and builds
and runs fine, so just run it.

Also remove now-empty and currently-unused non_mac_chromium_gtests.

Bug: 843511
Change-Id: I71abcab45133bb235f268f34e4df6097758867d4
Reviewed-on: https://chromium-review.googlesource.com/1129680
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573544}

These are histograms that have not been viewed in the last 6 months, but still
report data on the Stable channel. Set these histograms to stop being recorded
for Chrome releases after 2018-08-30. We will file bugs via Monorail (crbug)
reminding owners about the approaching histogram expiry – initially 30 days
prior to expiry, and also with follow-up alerts. The metrics dashboards will
also display a warning for anyone viewing a soon-to-expire histogram.

Owners and/or users of these histograms: Please comment on this CL if you think
that any affected histogram should not have an expiry date set! This should be
uncommon.

Otherwise, there are a few options going forward:
  * If the histogram is no longer needed, please send a follow-up CL to delete
    the recording code and to mark the histogram as <obsolete>. (You can also
    remove the expiry date in the same CL.)
  * If you want to set a different expiry date, please send a follow-up CL to do
    so.
  * If neither of the above apply, then keep an eye out for Monorail bugs as the
    histogram expiry date approaches.
For more info on how unused histograms are identified, see
https://goto.google.com/uma-unused-histograms-cleanup

Bug: 850539
Change-Id: Ie3dea1da3f7a42b0454a79ea1ca77a153629ddc9
Reviewed-on: https://chromium-review.googlesource.com/1126174Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573543}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/92745a5b0e2e..c3975e55e146


git log 92745a5b0e2e..c3975e55e146 --date=short --no-merges --format='%ad %ae %s'
2018-07-09 sergiyb@chromium.org Allow using pipes to specify properties for buildbucket.py


Created with:
  gclient setdep -r src/third_party/depot_tools@c3975e55e146

The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I47a9711bedb0ce4912dc418e09a8f69cd1566b26
Reviewed-on: https://chromium-review.googlesource.com/1130184Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#573542}

These are histograms that have not been viewed in the last 6 months, but still
report data on the Stable channel. Set these histograms to stop being recorded
for Chrome releases after 2018-08-30. We will file bugs via Monorail (crbug)
reminding owners about the approaching histogram expiry – initially 30 days
prior to expiry, and also with follow-up alerts. The metrics dashboards will
also display a warning for anyone viewing a soon-to-expire histogram.

Owners and/or users of these histograms: Please comment on this CL if you think
that any affected histogram should not have an expiry date set! This should be
uncommon.

Otherwise, there are a few options going forward:
  * If the histogram is no longer needed, please send a follow-up CL to delete
    the recording code and to mark the histogram as <obsolete>. (You can also
    remove the expiry date in the same CL.)
  * If you want to set a different expiry date, please send a follow-up CL to do
    so.
  * If neither of the above apply, then keep an eye out for Monorail bugs as the
    histogram expiry date approaches.
For more info on how unused histograms are identified, see
https://goto.google.com/uma-unused-histograms-cleanup

Bug: 850539
Change-Id: Ida5724a5c8587a72c2474189f8888e6c23b12f24
Reviewed-on: https://chromium-review.googlesource.com/1126206
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Nicolas Zea <zea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573541}

* Add back boostForPendingView logic accidentally removed in r554797
* Send updates when frame depth changes, which was missing in r546622.
  Note this fix is limited to OS_ANDROID to maintain the desktop
  workaround for crbug.com/560446
* Also improve testCrossDomainNavigationDoNotLoseImportance to also
  log the calling stack on failure.

Bug: 861826
Change-Id: I0757647a81228a9bfc5fda02d775f62fb6bee723
Reviewed-on: https://chromium-review.googlesource.com/1128573Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573540}

PrepareWriteValue is a procedure to reliably write to GATT
characteristics in a GATT service. A client can PrepareWrite to
various characteristics in a reliable write session and Execute or Abort
those writes later.

For now, BlueZ handles prepare writes by caching them and then sends out
regular write requests to the application in the case of commit, or
silently drops them in the case of abort.

We keep the caching in BlueZ but implement a new function named
PrepareWriteValue() such that applications can tell prepare write
requests from regular write requests. Since BlueZ only sends out the
write requests when the remote device commits, applications not
interested in achieving reliable writes can safely regard all prepare
write requests as regular ones.

A relevant patch is crrev.com/c/1094214

Bug: b:78650442
CQ-DEPEND: CL:1094214
Test: Pass Android CtsVerifier test on GATT server reliable write
Change-Id: If2464cf3a17e7c91dc11dc8f4c37734a2987543e
Reviewed-on: https://chromium-review.googlesource.com/1094316
Commit-Queue: Qiyu Hu <qiyuh@google.com>
Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Rahul Chaturvedi <rkc@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Miao-chen Chou <mcchou@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573539}

BUG=859649
TEST=Covered by unit test

Change-Id: I9c662852659aec26034d0992f530398b5121ad2c
Reviewed-on: https://chromium-review.googlesource.com/1124878Reviewed-by: Jun Mukai <mukai@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573538}

The API used to retrieve the list of layouts does not reflect the
order of the layouts in the control panel.  I don't see another
Win32 API which would give us that ordering so I am now grabbing
the current layout and swapping it with the first element to ensure
it is evaluated first.

BUG=832811

Change-Id: Icef22303e38be4b2680ad8636ba408fcb81239a2
Reviewed-on: https://chromium-review.googlesource.com/1130455Reviewed-by: Gary Kacmarcik <garykac@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573537}

We need to use the pref in components, so move the pref to ui/base so it
can be accessed.

TBR=jam@chromium.org

Bug: 729596
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Iffc7c5c2f459340c14a74787defeab00c6c5589c
Reviewed-on: https://chromium-review.googlesource.com/1125143
Commit-Queue: Ran Ji <ranj@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573536}

The FileSystemProvider API tests load up platform apps that rely on an
external extension's web accessible script to be injected. This script
would normally be blocked by the platform app's CSP. Update the tests to
use an explicit CSP allowing the extension's resource.

Bug: 861815
Change-Id: Ifd2ce1ce01cb6578663b10ac11940cd9a066769f
Reviewed-on: https://chromium-review.googlesource.com/1129473
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573535}

CreateSimpleURLLoaderWithVariationHeaders.

Tons of people call AppendVariationHeaders() with variations::SignedIn::kNo with
the following comment:
  // Note: It's OK to pass SignedIn::kNo if it's unknown, as it does not affect
  // transmission of experiments coming from the variations server.
This CL simply make a version without the sign-in parameter of
AppendVariationHeaders and CreateSimpleULRLoaderWithVariationHeader and remove
those many comments in the code.

BUG=857127

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Id0af5394ce31b117e109033f44a43720d4407197
Reviewed-on: https://chromium-review.googlesource.com/1121669
Commit-Queue: Theresa <twellington@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Zachary Kuznia <zork@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Nicolas Zea <zea@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573534}

BodyStreamBuffer has a ReadableStream instance, but because it's
implemented in V8Extra we cannot holds it as a member (i.e., as a
ScriptValue). Instead, we attach the value to the JS wrapper of the
C++ object. This required us to maintain chains of wrappers,
FetchEvent -> Request -> BodyStreamBuffer for example, manually.

This CL replaces that mechanism with wrapper tracing.

Bug: None
Change-Id: I889ef0d0442d62ad50826a4b487ec234f041a982
Reviewed-on: https://chromium-review.googlesource.com/1124270Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573533}

This change solves two problems related to font colors:
* Changes passed down from UX have requested the use of the subtext/hint
  color for all text in footer rows.
* A bug causes text colors to change (permanently) to incorrect values
  when hover styles are applied. This was observed on Linux under GTK+
  theme only. We don't need to modify text colors during RefreshStyle
  anyway, so the simplest fix is to define these at initialization and
  not touch them again.

Change-Id: I80d2de91bb7067b3dc8fea6f369c83658e15c22a
Bug: 861883, 859887
Reviewed-on: https://chromium-review.googlesource.com/1130015
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573532}

The code stopped working when paper-icon-button-light was updated to its
latest version, which changed the structure of the DOM.

Bug: 860854
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I0c7189752a5ae47eab0024e3e81775a5f93ee7b6
Reviewed-on: https://chromium-review.googlesource.com/1128463Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573531}

This CL connects |enable_canvas_2d_image_chromium| on CrOs, enabling
use of GpuMemoryBuffers for blitting the Skia produced textures onto.

GMBs on CrOs are GL_TEXTURE_EXTERNAL_OES, which can't be used to
CopyTextureCHROMIUM() onto, so CanvasResourceGpuMemoryBuffer gets
a new member (a 2D texture ID), connected to the same GMB, to be
used for that purpose.

Also as pointed during the review, there's no need to hold on to a
Image2DChromium as long as it's bound to a texture (to which we
hold on to), so removing the current |image_id_|.

Bug: 839970
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I375451cca8f4e29e8fd40a4e6aaadc1a49bcd398
Reviewed-on: https://chromium-review.googlesource.com/1056168
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573530}

Outlines should always be rectangular, and the outline paint code forces
the outer/inner radii to zero.

But the shared paint code in BoxBorderPainter::DrawDoubleBorder does not
enforce zero-radii when computing the intermediate double edges.

Update DrawDoubleBorder() to avoid rounded intermediate edges when the
exterior edges are not rounded.

Bug: 861816
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I81cfccfbb3f14568a0aeacb065fc447f583f28c8
Reviewed-on: https://chromium-review.googlesource.com/1129334Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573529}

Bug: 805612
Change-Id: I86af86a62fe2e46691db6bfb2b24da404c93ec1d
Reviewed-on: https://chromium-review.googlesource.com/1130059
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573528}

Proposing to add myself as the owner since I have been maintaining and reviewing
these files and looking forward to cleanups and adding more profiles support
soon.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I73e637c376e91df209f759fb55d5f6ba8d86a219
Reviewed-on: https://chromium-review.googlesource.com/1130230Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Emircan Uysaler <emircan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573527}

This both helps organize the members of UkmRecorderImpl a bit, and
also simplifies the code for Purge(), so that it doesn't need to know
about all of the different fields. This should help make it harder to
accidently add a new field and not delete it during a Purge().

Change-Id: I49558468cfb491c34ef76d2c2801aae72ddc8364
Reviewed-on: https://chromium-review.googlesource.com/1054142
Commit-Queue: Steven Holte <holte@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573526}

https://chromium.googlesource.com/angle/angle.git/+log/d7890bca9b35..c56adf60d141


git log d7890bca9b35..c56adf60d141 --date=short --no-merges --format='%ad %ae %s'
2018-07-09 tobine@google.com Roll Vulkan repos fwd as of 7/3
2018-07-09 jmadill@chromium.org Vulkan: Add driver uniforms set.
2018-07-09 jmadill@chromium.org Vulkan: Roll SPIRV-Tools and SPIRV-Headers.
2018-07-09 jmadill@chromium.org Vulkan: Make DynamicDescriptorPool single pool.
2018-07-09 geofflang@chromium.org Vulkan: Support EGL_ANGLE_surface_orientation for vertical surface flipping.
2018-07-09 jmadill@chromium.org Return an Error from ContextImpl::syncState.


Created with:
  gclient setdep -r src/third_party/angle@c56adf60d141

The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jmadill@chromium.org

Change-Id: I0a67fff7f7d0db7042c340605d9ae848407a64e6
Reviewed-on: https://chromium-review.googlesource.com/1130180Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#573525}

This CL replaces base::Timer with its subclasses.
As base::Timer changes its behavior subject to its construction time
flags, that makes hard to see the actual timer behavior, especially
it's unclear when a timer is injected from other components.
Also, that OnceCallback support of base::Timer is hard to implement on
the dynamically determined invocation pattern.

Bug: 850247
Change-Id: I2a7a85a39ba25da01cec2b151d2911f7dba8029a
Reviewed-on: https://chromium-review.googlesource.com/1128691Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573524}

Bug: 860699
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I3845e42fb4bde966077406d8553a9b74c9a46c22
Reviewed-on: https://chromium-review.googlesource.com/1128177Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573523}

This CL replaces base::Timer with its subclasses.
As base::Timer changes its behavior subject to its construction time
flags, that makes hard to see the actual timer behavior, especially
it's unclear when a timer is injected from other components.
Also, that OnceCallback support of base::Timer is hard to implement on
the dynamically determined invocation pattern.

Bug: 850247
Change-Id: I38b7d932304466a9d86bbd577f9918149914f8ea
Reviewed-on: https://chromium-review.googlesource.com/1128694Reviewed-by: Martin Barbella <mbarbella@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573522}

When the drag ends, TabDragController::ClearTabDraggingInfo() might
trigger a bounds change of the dragged window, which then trigger
TabDragController::OnWidgetBoundsChanged() to be called again to
continue dragging. We should remove TabDragController as an observer of
the dragged widget when the drag is ending as we do not care about any
subsequent moves to the widget.

Bug: 854835
Change-Id: Ia940e7f0a33609bfc19ff9d96861948579fb5dd7
Reviewed-on: https://chromium-review.googlesource.com/1109266Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573521}

We need to disable it:
- when Assistant UI is dismissed.
- when an Assistant interaction is started (e.g. via hotword).

Bug: b:110961300
Change-Id: I97024e9f2681d171c40f54ac5b47c5ed549085b6
Reviewed-on: https://chromium-review.googlesource.com/1119530
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573520}

When chrome://reset-password interstitial is triggered by password reuse,
sets password type in content::OpenURLParams::post_data to pass this info
to reset-password interstitial page. Such that we can have more accurate
uma tracking.

If user directly navigates to chrome://reset-password page, post_data
won't be available. In this case, we log UMA separately for unknown
reused password type.

Bug: 859412
Change-Id: I736180c5325d3680c27a03e1c22992814ced3b9b
Reviewed-on: https://chromium-review.googlesource.com/1123310
Commit-Queue: Jialiu Lin <jialiul@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573519}

https://webrtc.googlesource.com/src.git/+log/7219d053d56a..478313fa8ea2


git log 7219d053d56a..478313fa8ea2 --date=short --no-merges --format='%ad %ae %s'
2018-07-09 buildbot@webrtc.org Roll chromium_revision a9fbefaa..a4679480 (573255:573356)


Created with:
  gclient setdep -r src/third_party/webrtc@478313fa8ea2

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng

BUG=chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I96a97b1bca2793b8b2992f5bc1afa648d6d19a7b
Reviewed-on: https://chromium-review.googlesource.com/1130080Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#573518}

This reverts commit 292ad04d.

Reason for revert: I think this caused an active window test failure, see https://crbug.com/861963

Original change's description:
> Remove makeKeyAndOrderFront: from WebContentsViewMac::Focus().
> 
> WebContentsView::Focus() is supposed to update the first responder of the
> Window, not make the window focused. The latter should go through
> WebContentsDelegate::ActivateContents().
> 
> This logic is usually a no-op because the window receiving the call is the
> active window. But in the case where the user quickly switches windows, this can
> cause the old window to re-take focus.
> 
> This logic was added in 2009 not because it had the right semantics, but to
> match the behavior of Windows: http://codereview.chromium.org/165492.
> 
> Bug: 859614
> Change-Id: I2bc44a825d93159d774c632da17cc2f2d151fc3a
> Reviewed-on: https://chromium-review.googlesource.com/1124772
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Commit-Queue: Erik Chen <erikchen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#573344}

TBR=avi@chromium.org,erikchen@chromium.org

Change-Id: I6ae990055c9a9cf0bd84f7599939e25490178304
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 859614
Reviewed-on: https://chromium-review.googlesource.com/1130141Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573517}

Previously we disabled POST requests from being snapshotted by OPC.
However, this inadvertently prevented SnapshotController from marking
a WebContents as snapshottable, so any POST requests would be unable to
complete - they would hang in downloading state until Chrome exited.
After that, the background loader would take over and error out because
it does not support non-GET requests and would use a GET HTTP request
for a POST resource which typically fails or redirects to a login page
of some kind.

Additionally, extends NavigationSimulator to use the method from
SetMethod when committing navigations, rather than the currently-hardcoded
"GET" method.

Bug: 859403
Change-Id: Ic10dd0b088da9e3ebf2a42e3cca6096eea449d16
Reviewed-on: https://chromium-review.googlesource.com/1125031Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573516}

Depends-On: eureka-internal/182625
Depends-On: eureka-internal/183487
Bug: 79116492
Test: manual / CQ

Change-Id: I9dab6b83145078b3b896a2490a8432500ccdabbe
Reviewed-on: https://chromium-review.googlesource.com/1121594
Commit-Queue: Sunil Kumar <skx@chromium.org>
Reviewed-by: Sergey Volk <servolk@chromium.org>
Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573515}

These are histograms that have not been viewed in the last 6 months, but still
report data on the Stable channel. Set these histograms to stop being recorded
for Chrome releases after 2018-08-30. We will file bugs via Monorail (crbug)
reminding owners about the approaching histogram expiry – initially 30 days
prior to expiry, and also with follow-up alerts. The metrics dashboards will
also display a warning for anyone viewing a soon-to-expire histogram.

Owners and/or users of these histograms: Please comment on this CL if you think
that any affected histogram should not have an expiry date set! This should be
uncommon.

Otherwise, there are a few options going forward:
  * If the histogram is no longer needed, please send a follow-up CL to delete
    the recording code and to mark the histogram as <obsolete>. (You can also
    remove the expiry date in the same CL.)
  * If you want to set a different expiry date, please send a follow-up CL to do
    so.
  * If neither of the above apply, then keep an eye out for Monorail bugs as the
    histogram expiry date approaches.
For more info on how unused histograms are identified, see
https://goto.google.com/uma-unused-histograms-cleanup

Bug: 850539
Change-Id: I517af72120c9748a1e2a09756e832bea20000928
Reviewed-on: https://chromium-review.googlesource.com/1126167
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Henrik Andreasson <henrika@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573514}

This fixes a compiler error.

../../base/sampling_heap_profiler/lock_free_address_hash_set_unittest.cc(148,22):  error: no member named 'make_unique' in namespace 'std'
  auto thread = std::make_unique<WriterThread>(&set, &cancel);
                ~~~~~^
../../base/sampling_heap_profiler/lock_free_address_hash_set_unittest.cc(148,34):  error: 'WriterThread' does not refer to a value
  auto thread = std::make_unique<WriterThread>(&set, &cancel);
                                 ^
../../base/sampling_heap_profiler/lock_free_address_hash_set_unittest.cc(116,7):  note: declared here
class WriterThread : public SimpleThread {
      ^
../../base/sampling_heap_profiler/lock_free_address_hash_set_unittest.cc(148,48):  error: expression result unused [-Werror,-Wunused-value]
  auto thread = std::make_unique<WriterThread>(&set, &cancel);
                                               ^~~~
3 errors generated.

ninja: build stopped: subcommand failed.
Change-Id: I72d5bddf448c091417f9497b6cb751df5a75dff1
Reviewed-on: https://chromium-review.googlesource.com/1129759Reviewed-by: Alexei Filippov <alph@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573513}

Component updater does not force an update if an compatible component is
installed. We provide an option in the Load API to support forced update
check.

BUG=chromium:850798,chromium:859573
TEST=platform_AddPrinter.epson

Change-Id: I1649e0ce641089cd57d4910155fc93e660967df1
Reviewed-on: https://chromium-review.googlesource.com/1119199Reviewed-by: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Xiaochu Liu <xiaochu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573512}