GitLab

A "mouse click" is comprised of a mousedown and a mouseup. During a
mousedown on a scrollbar arrow, a GSB and a GSU are queued up in the
CompositorThreadEventQueue. On mouseup, a GSE gets added to the queue.
These gesture events are VSync aligned. However, if the user is rapidly
clicking on the arrow, we will get another mousedown before the queued
up GSE (from the first mouse click) has had a chance to be processed.
This new mousedown now ends up calling InputHandlerScrollEnd and that
in turn sets handling_gesture_on_impl_thread_ to false. When the queued
up GSE from the first mouse click finally gets dispatched, it notices
that handling_gesture_on_impl_thread_ is false and hence, leads to
DCHECK(!currently_active_gesture_device_.has_value()) failing. This CL
fixes the bug by clearing currently_active_gesture_device_ when the
ongoing scroll ends.

Bug: 1068062
Change-Id: Ie953c1336c2b74895dd0853da7c229928e137fdd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2191198
Commit-Queue: Rahul Arakeri <arakeri@microsoft.com>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770838}

This reverts commit 8a79ddf4.

Reason for revert: Breaks the build.
https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8879743677570880208/+/steps/compile/0/stdout
Need to investigate gn/build issue.

Original change's description:
> Android: New build target chrome/browser/contextmenu
> 
> This CL moves some interfaces for context menu under
> chrome/browser/contextmenu and defines a new modularized target.
> 
> This allows TabDelegateFactory class to chrome/browser/tab, and
> put |TabImpl.updateAttachment| back to Tab interface.
> 
> Bug: 952703
> Change-Id: Ie5534ce07c8e84593e6033141501e3f3a0ba4704
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201796
> Reviewed-by: Theresa  <twellington@chromium.org>
> Reviewed-by: Ted Choc <tedchoc@chromium.org>
> Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#770805}

TBR=nyquist@chromium.org,tedchoc@chromium.org,twellington@chromium.org,jinsukkim@chromium.org

Change-Id: I7e86f199aa960b5c3b4bb00609f6d51c1aed1856
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 952703
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211076Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770837}

Bug: 1035448
Change-Id: Ib029e2c3115a5f0d8e9d3c9dcfd014e5851f827b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209339Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770836}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/bc0292ca..56b912f2

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org

Change-Id: Id476920ed709f3e04eec2bf68ef740ebf286b7a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210446Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770835}

They no longer use the JSONReader API, other than some enum and string
constant definitions that a later commit will hopefully move over from
JSONReader to JSONParser, once the JSONReader call sites have been
weaned off the JsonParseError enum (crbug.com/1070409).

Originally, there was a single JSON decoder implementation, and the
distinction between json_parser.h and json_reader.h was blurry. More
recently (crbug.com/c/1069271), we are experimenting with alternative
JSON decoder implementations. We may eventually settle on a winner, but
during the transition period, there may be several implementations. The
desired split is for json_reader.h to be the public API and for
json_parser.h to be *a* private implementation (the existing one).

In this new world, it is a layering violation for the lower level
JSONParser code and tests to rely on the higher level JSONReader API.
This commit helps address some of that concern: JSONParser tests now use
the JSONParser API, apart from the enum+string caveat mentioned above.

Bug: 1069271
Bug: 1070409
Change-Id: I5f261ae808b14997ddb748670b14ff4107f4dd33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208837Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Nigel Tao <nigeltao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770834}

https://dawn.googlesource.com/dawn.git/+log/78f7e8640f14..13e565a5999c

2020-05-20 rharrison@chromium.org Rolling 4 dependencies

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: cwallez@google.com
Change-Id: I51b46fca1fec9e0aeec4eea29c8db884b8cbed68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210647Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#770833}

Instead of taking a SearchConcept as a parameter, take some of the
fields included in a SearchConcept. This refactor is required for
modifying URLs for parent subpages/sections, which do not necessarily
have an associated SearchConcept.

Bug: 1082249, 1071700
Change-Id: I953643bb0b82d06270689582b1956bd4e4377b6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211062
Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Regan Hsu <hsuregan@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770832}

The previous test patterns had some overlap in them e.g.
SubPageDefault.DiskResizeOpensWhenClicked would run for both
SubPageDefault and DiskResize test suites. Remove the overlap.

Bug: chromium:1082027
Test: Run browser tests, check the DiskResizeOpens... test only runs once
Change-Id: Ib296c872b596f1ecac390bd2f5c26ce991785da7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210330Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Nic Hollingum <hollingum@google.com>
Commit-Queue: David Munro <davidmunro@google.com>
Cr-Commit-Position: refs/heads/master@{#770831}

- Use iron-dropdown instead of native <select> to support displaying
  printer status icons inside the dropdown. Using iron-dropdown is a
  temporary workaround and will need to be replaced with another
  dropdown element in the future.

Bug: 1059607
Change-Id: I7598600ebb21e7d604ba416eb0a8938bd45e584c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2177274
Commit-Queue: Gavin Williams <gavinwill@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770830}

Bug: 100227
Change-Id: I8fd81f1d1584ba49fad35d9d30caec07d92dd8b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210797
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770829}

Bug: 1085209
Change-Id: I9868b9a7012e9dc7d23a710fea21186d8b73107a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210798Reviewed-by: Tanya Gupta <tgupta@chromium.org>
Commit-Queue: Gayane Petrosyan <gayane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770828}

This reverts commit 496003a3.

Reason for revert: Appears to still be breaking the build. See: https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8879762809032212800/+/steps/compile/0/stdout

Original change's description:
> Reland "Add simple info bar to opt-out for conditional tab strip"
> 
> This reverts commit 2808b517.
> 
> Reason for revert: Add missed dependency.
> 
> Original change's description:
> > Revert "Add simple info bar to opt-out for conditional tab strip"
> >
> > This reverts commit e4d36bfb.
> >
> > Reason for revert: breaks download stream compile, might be build issue. please do "gn check target".
> >
> > https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8879764778699702672/+/steps/compile/0/stdout
> >
> > Original change's description:
> > > Add simple info bar to opt-out for conditional tab strip
> > >
> > > This CL adds an info bar for conditional tab strip to allow user to
> > > opt-out the feature. Some behavior of the info bar:
> > >
> > > * It will show after three consecutive sessions of dismissals.
> > > * If user clicks the "Don't show again" button, conditional tab strip
> > >   will never show for this user in later sessions.
> > > * If user clicks the "Show later" button, conditional tab strip
> > >   will show again for this user in later sessions, and the info bar will
> > >   never reshow.
> > > * If user clicks the dismiss button to dismiss the info bar, the info
> > >   bar will reshow after another three consecutive dismissal, but the
> > >   limit times of info bar showing is two, i.e. 6 consecutive sessions of
> > >   dismissal.
> > > * When the info bar shows, the undo snackbar will not show.
> > >
> > > Note that this is the simple version of info bar that we want, in that
> > > it is tied to one tab and cannot live across tab navigation.
> > >
> > > Bug: 1076295
> > > Change-Id: Icbb322af639ff5cf4ab8421d12ce428cc1b006eb
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206216
> > > Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
> > > Reviewed-by: Evan Stade <estade@chromium.org>
> > > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
> > > Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
> > > Reviewed-by: Matthew Jones <mdjones@chromium.org>
> > > Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#770632}
> >
> > TBR=estade@chromium.org,yusufo@chromium.org,mdjones@chromium.org,wychen@chromium.org,hnakashima@chromium.org,yuezhanggg@chromium.org
> >
> > Change-Id: Id57987bdbf4cb0bb461e9b3ee44f636fa9db330e
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 1076295
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209899
> > Reviewed-by: Xing Liu <xingliu@chromium.org>
> > Commit-Queue: Xing Liu <xingliu@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#770647}
> 
> TBR=estade@chromium.org,yusufo@chromium.org,mdjones@chromium.org,wychen@chromium.org,xingliu@chromium.org,hnakashima@chromium.org,yuezhanggg@chromium.org
> 
> # Not skipping CQ checks because this is a reland.
> 
> Bug: 1076295
> Change-Id: I89ec83eb3211a090f8e21004418eede65330959d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209902
> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
> Reviewed-by: Yue Zhang <yuezhanggg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#770763}

TBR=estade@chromium.org,yusufo@chromium.org,mdjones@chromium.org,wychen@chromium.org,xingliu@chromium.org,hnakashima@chromium.org,yuezhanggg@chromium.org

Change-Id: I0681a7197eead16839263f4bdada5058856e73e7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1076295
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210973Reviewed-by: Kyle Milka <kmilka@chromium.org>
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770827}

https://android.googlesource.com/platform/external/perfetto.git/+log/f663d41a441e..169feea71d1f

2020-05-20 treehugger-gerrit@google.com Merge "Mark exhaustive time_in_state snapshots"
2020-05-20 simonmacm@google.com Merge "Add counter annotations for time-in-state probes."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I785ab047190b7b735f1776b8f639952a7164ecb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210646Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#770826}

This CL cleans up the disabled feature flags for Assistant not currently
in use, specifically |kEnableClearCutLog|.

This CL also cleans up some code missed in chromium:2207860 which was a
related CL that did a similar clean-up of the launched feature flags
instead.

Bug: b:156993255
Test: Does not change behavior
Change-Id: I3624e3fd15934c3b5bf0dcae43fc58c49d92281d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210324Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Abhijeet Singh <siabhijeet@google.com>
Cr-Commit-Position: refs/heads/master@{#770825}

Most PDFiumAPIStringBufferSizeInBytesAdapter users use it in almost
identical ways, just with different PDFium APIs. It would be nice to
consolidate the repeated code. This adapter is also bit hard to use. To
address these issues, add a templated CallPDFiumWideStringBufferApi()
wrapper to avoid the repeated code, and hide the complexities of the
adapter. Then move PDFiumAPIStringBufferSizeInBytesAdapter to a nested
internal namespace, because it is now just an implementation detail.

Similarly, add CallPDFiumStringBufferApi() for use with
PDFiumAPIStringBufferAdapter<std::string>, and make
PDFiumAPIStringBufferAdapter part of the internal namespace.

For the rare use cases that cannot use either of the two helper
functions above, expose PDFiumAPIStringBufferAdapter outside of the
internal namespace.

Change-Id: I542e442c23d52f7322ec79a1a516fb8c48b28bb5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208604
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Daniel Hosseinian <dhoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770824}

Bug: 1073844
Change-Id: Ic4997f6bcf7905d28cdfa9d8fef62293a5e03722
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160973
Commit-Queue: Roman Aleksandrov <raleksandrov@google.com>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770823}

https://skia.googlesource.com/skia.git/+log/c5eb5c7127b2..87caae61cdf1

2020-05-20 scroggo@google.com Move SkBitmapRegionCodec into client_utils/android
2020-05-20 jlavrova@google.com Remove canvas save/translate/restore when it's not needed.
2020-05-20 egdaniel@google.com Reland "Implement submit API to GrContext."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC lovisolo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: lovisolo@google.com
Change-Id: I8961b0386c5b9c084da55b98d64b2d63877f7e01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210657Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#770822}

Covers a few more cases where feed code should not run because of the
feature flag being disabled or the feed being disabled by enterprise
policy.

Once https://chromium-review.googlesource.com/c/chromium/src/+/2197483
lands, FeedServiceBridge.isEnabled() should be checked before creating
the FeedSurfaceProvider.

Bug: 1044139
Change-Id: Iddc455c50532a9860887d134a1e3899e91048136
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210794Reviewed-by: Dan H <harringtond@chromium.org>
Commit-Queue: Ian Wells <iwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770821}

1. AppState now advertises when safe mode has completed.
2. SceneControllers now don't do anything while Safe Mode is active.
3. AppState now uses a foreground scene to display safe mode.
4. MainController waits for Safe Mode to complete before any
scene-event-related setup.
5. Scenes now observe AppState, and access it directly
(and not through MainController).

Bug: 1080907
Change-Id: Ifffcd7cf7dd822d068268cc4a3709221acea2caf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2193657
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770820}

Previously, it was theoretically possible for this method to encounter
an integer overflow. This CL prevents that by capping the value at max
int.

Bug: 1085171
Change-Id: Ib4e7208a8f4322c3ccaedc092fe853593df2cb01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210934
Auto-Submit: Scott Little <sclittle@chromium.org>
Commit-Queue: Megan Jablonski <megjablon@chromium.org>
Reviewed-by: Megan Jablonski <megjablon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770819}

Fixed: 1083021
Change-Id: Id73d266856482bffd2dd89584eb426fa6670d559
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203270Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770818}

In order to bind a local associated interface you need to use the testing
API. While the API is poorly named due to mojo team previously did agree
that the ForTesting suffix should be removed for cases such as these.

BUG=1084849,1085031,1082648
TBR=tommycli@chromium.org

Change-Id: I2413fcc8633cd3db75f3c4eefcff763b29ca714c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210488Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770817}

This change also implements the ReportingServiceSettings class.

Bug: 1069068
Change-Id: I2c045380180aec65ff99d0b9f8d19d5e7928aae1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210875
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Reviewed-by: Dominique Fauteux-Chapleau <domfc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770816}

RenderWidget::QueueMessage() used to request a main frame after queuing
a swap promise. This request was moved into the LTH::QueueSwapPromise()
to be able to check whether we are already inside a main frame or not
(see r498671). This means that other calls to QueueSwapPromise() will
have the same side effect which is not necessary. For example, it might
cause reporting of EventLatency metrics when the event has not caused
any actual update, just because a swap promise was queued in the event
handling code. This CL moves the call to SetNeedsAnimate() back out of
QueueSwapPromise(), by calling a new function called
SetNeedsAnimateIfNeeded() which will only sets needs-animate flag if a
main frame is not in progress.

Bug: 1085074
Change-Id: I2fd29cb013f13fad0c86c624b5f57a0d62b9fb2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202529Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770815}

Bug: 960012
Change-Id: I4cb28adc3172adbd6ad9583e2a84393fad2bc750
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209375Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770814}

This CL adds new events to record transport parameters,
and implements the right QuicConnectionDebugVisitor calls
to access the transport parameters. I've confirmed that
they show up in netlog locally.

R=nharper@chromium.org

Change-Id: I297c57c594eea349b46e40654063e8c9140e39f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210783
Auto-Submit: David Schinazi <dschinazi@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Reviewed-by: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770813}

There is no need to mock hasSwitch since it doesn't seem to be used
anymore, at least not in the code being tested.

BUG=912236
TEST=browser_tests --gtest_filter="FileManagerJsTest.FileTasks"

Change-Id: I78cba36159bc00074e18d635dc21ef64e7622d4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206871Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: François Degros <fdegros@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770812}

This change makes Trust Tokens configurable in two origin trial modes:
- "Standard": issuance requires the "TrustTokens" origin trial
(runtime_enabled_feature.json5) be active; redemption and signing don't
- "Third party": all three operations require the trial be active

This fairly complex configuration is motivated by the fact that we don't
know whether we'll be running a standard origin trial or a third party
origin trial [1], as the code for the latter has landed but not
launched, so we need to be able to decide dynamically.

This is implemented by gating all three Trust Tokens operations behind
the same RuntimeEnabledFeature [2] and having a runtime check for the
presence of the origin trial during issuance:
- in "standard" mode, the RuntimeEnabledFeature is always on (so long
as the corresponding base::Feature is; see below), so all three
operations are always available, but issuance will fail in contexts
without configured origin trial tokens;
- in "third party" mode, the RuntimeEnabledFeature is left off even if
the base::Feature is enabled: the Origin Trials framework will enable
it, activating all operations, if there is an origin trial token.

In both modes, we unconditionally require that the kTrustTokens
base::Feature be enabled in order to execute any of the operations: if
it's disabled, the Blink RuntimeEnabledFeature will start disabled and,
additionally, the origin trial will not be permitted to activate
(because of the new logic in OriginTrialContext).

I wrote up a slightly longer description of the constraints and the
implementation rationale: https://bit.ly/configuring-trust-tokens

[1]:
https://docs.google.com/document/u/1/d/1xALH9W7rWmX0FpjudhDeS2TNTEOXuPn4Tlc9VmuPdHA/edit
[2]: The entry point for each operation is identical (e.g. you use
the trustToken argument to RequestInit whether it's an issuance,
redemption, or signing operation), so it's not possible to vary the
"enabled or not" decision at an IDL level depending on the operation.

Fixed: 1081739
Change-Id: I1e63f2c12a1e2a158011fa5e95676b48f36e38dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199910
Commit-Queue: David Van Cleve <davidvc@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Jason Chase <chasej@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770811}

This cl adds an EDU coexistence information screen.
A screenshot of the screen is here: https://drive.google.com/file/d/16DErhvB0RNawBqhfUqMuh9nIz0AgHLYV/view?usp=sharing

Bug: 1082336
Change-Id: Ie02c67142f82c7aa90ba741acd6d7312c34594fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208087Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Reviewed-by: Anastasiia N <anastasiian@chromium.org>
Commit-Queue: Yilkal Abe <yilkal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770810}

This templatized class is only ever used for base::string16. Since that
is the only string type it will be used with in the foreseeable future,
remove the overhead of the template.

Change-Id: I7a62e83ab612c1d7e7b2461a50bc7be7be0768f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207737Reviewed-by: Daniel Hosseinian <dhoss@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770809}

ClusterFuzz found null-dereference READ in
scoped_refptr<mojo::SimpleWatcher::Context>::operator bool.
This bug already existed before HeapMojo wrappers were introduced.
We are not sure the root cause, but HeapMojo wrappers could sanitize
the issue.

Bug: 1049056, 1079286
Change-Id: I9f0fae6921024525891841bc942ac3a521a0a015
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208780Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Commit-Queue: Minoru Chikamune <chikamune@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770808}

The underlying dropdown menu model already supports showing icons and
secondary labels.

This CL add such support to the combobox model. When an item is selected
the main label is shown inside in the combobox together with the icon.
Secondary labels are displayed only inside the dropdown menu.

Bug: 1044038
Change-Id: Ibe3cc37464bfd8e416aeadec62827b8ca103d13f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207386
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770807}

Change-Id: Ic33b2b06c13d57196a87e1e065502445da6a25a7
Bug: 1053232
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210421Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Auto-Submit: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770806}

This CL moves some interfaces for context menu under
chrome/browser/contextmenu and defines a new modularized target.

This allows TabDelegateFactory class to chrome/browser/tab, and
put |TabImpl.updateAttachment| back to Tab interface.

Bug: 952703
Change-Id: Ie5534ce07c8e84593e6033141501e3f3a0ba4704
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201796Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770805}

Still haven't added the part to get the content types yet, so it is not hooked up yet. Instead, another method is added to provide all the options.

Bug: 1079467
Change-Id: Ia6326db8d7aa01dab2690485f6891418b3f4d11a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197524
Commit-Queue: Sophey Dong <sophey@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770804}

Unify the suppressions between WebGL 1.0 and 2.0 for:
  conformance/more/functions/readPixelsBadArgs.html
  conformance/more/functions/texImage2DHTML.html
  conformance/more/functions/texSubImage2DHTML.html
  conformance/textures/misc/origin-clean-conformance-offscreencanvas.html
  conformance/textures/misc/origin-clean-conformance.html

Bug: 1082525, 1083100
Change-Id: Ic6cd0abb27ee434a4a5263264283a568d1d0ee23
Tbr: shrekshao@google.com
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209687Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770803}

Recent NDKs don't ship a gcc binary any more, so the detection of the
NDK fails, even if specified via --ndk-dir.

Bug: 1084750
Change-Id: I323cfdc04ecbeb53fde864d41f55bf3270ea33b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207577Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770802}

This is a reland of 40eb3bd7. Don't
change use-vulkan tag to be vulkan since that's already used by ANGLE.

Original change's description:
> Fix GPU integration test tags
>
> Both [no-]skia-renderer and [no-]use-vulkan tags in GPU integration
> tests were based on the command line. Code assumed that if there was
> nothing on the command line then the feature was disabled which was
> incorrect.
>
> Change the tags to be based on if the feature is enabled or not. Also
> change use-vulkan to just be vulkan for brevity.
>
> Bug: 1069551, 1084569
> Change-Id: I33fdbfb4d8078127f066f4a86a267477e4e9e020
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209348
> Reviewed-by: Zhenyao Mo <zmo@chromium.org>
> Commit-Queue: kylechar <kylechar@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#770579}

Bug: 1069551, 1084569
Change-Id: Ia9a816e18b0de283185ccda7c14e6e412fdf1eaf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210627Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770801}

The assigned machine is in mac 10.14 so os can't be os.MAC_10_15. This
is to fix the infra failures caused by this wrong config.

bug: 1085198
Change-Id: Ia8a64508045f3fb7ee8b021d61f97faf7755ecba
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211043
Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org>
Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770800}

Invalidation was done for :-webkit-full-screen, but not the standardized
:fullscreen pseudo class.

Issue created for making :-webkit-full-screen an alias: 1085151

Bug: 1082663
Change-Id: I17ce7da26158fe6ea37c02241938861658960f84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209217Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770799}