- 03 Dec, 2019 40 commits
-
-
Collin Baker authored
When a new window is opened in touch mode, or any windows switch to touch mode, the tab strip starts open. Fixed: 1028384 Change-Id: Ie50c4df7725ebe4841d29ba84382638418df2f2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941057 Commit-Queue: Collin Baker <collinbaker@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#721074}
-
Erik Chen authored
The test suite has 10 minutes of real work, and 4 minutes of per-shard overhead. By using 2 shards, we keep total runtime at 9 minutes, without wasting too many resources on overhead. Change-Id: Idcf5acc332845547229caf2cf2005c2db6fc0d2b Bug: 1030341 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933384 Commit-Queue: Erik Chen <erikchen@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#721073}
-
Yue Zhang authored
Right now when Duet and GridTabSwitcher are both turned on, the bottom toolbar shows at the top of the screen in landscape mode. This CL changes this behavior so that in landscape mode, we keep showing the original top toolbar for GridTabSwitcher instead of the Duet bottom toolbar. So far the change is only visible when Duet and GTS are both turned on and TabGroups is turned off. Bug: 1012014 Change-Id: Ia6c6ed5dddfccb33c4b51374f483e60dda99fb84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929352 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#721072}
-
Joe Mason authored
The previous solution can only capture logs after the child process creates a ScopedLogging object. We see flaky crashes in sandbox creation that happen before that so this will let us see the child process stack traces. Also moves some functions that were exported from ipc_test_util.h to be private to proto_chrome_prompt_ipc_unittest.cc, which is the only test that still uses them. Bug: 1030333 Change-Id: Ie30eed3b16631721e81a420b3b70f1ec5f0d9a0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948483Reviewed-by:
proberge <proberge@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#721071}
-
Nico Weber authored
Bug: 999871 Change-Id: I04f7bcff1ed4ff7c17573980301647a64b29836d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947474 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#721070}
-
Lachlan Ford authored
The RETURN_IF_XR_FAILED macro previously required a local variable to already exist for it to function correctly. This change removes that requirement. Change-Id: Ib0ebb5855abfe8788f906235d2bec95b13eb6655 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934394 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#721069}
-
Mei Liang authored
This CL adds accessiblity strings for closing suggestion. In addition, it updates description for other closing suggestion related strings. Change-Id: Ie3c87ae4b91273a818b8b8950e59ca7b9c284709 Bug: 1004570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935045 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#721068}
-
minch authored
The back gesture kSwipingFromLeftEdgeToGoBack feature is disabled by default, and is only enabled on the devices that has hotseat feature enabled (i.e., on Krane and on Dogfood devices). Bug: 1030122, 1002733 Change-Id: Ie6fed45ff8df7113bc86923c23ac9e581da64937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947947Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#721067}
-
Kurt Catti-Schmidt authored
There is a bug that text selections cannot be expanded via keyboard shortcuts (i.e. control+shift+down) with Narrator running. This is because Narrator intercepts the keyboard shortcuts and instead performs selections via UIA. When GetSelection was implemented, we followed a restriction that is visible in Edge and Inspect, where no selection was reported if it spans multiple nodes. It turns out that this is not entirely true - a selection will be reported that spans multiple nodes if the text range originally spanned those nodes. This appears to be a side-effect or bug that isn't anywhere in the UIA spec. Rather than attempt to model this behavior more exactly, this change simply removes the cross-node restrictions on GetSelection entirely, which fixes Narrator's text selection issues. Bug: 1029901 Change-Id: Ifad1ae4f4bd48122bffd44bfbd974e8de96b7493 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946983Reviewed-by:
Ian Prest <iapres@microsoft.com> Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#721066}
-
Ben Pastene authored
This reverts commit 9f51fb75. Reason for revert: internal linux builds broken with "no member named 'start_hidden' in 'base::LaunchOptions'" from https://ci.chromium.org/p/chrome/builders/ci/linux-google-rel eg: https://ci.chromium.org/p/chrome/builders/ci/linux-google-rel/13653 Original change's description: > Refactor the recovery component action handler for Windows. > > This CL refactors the implementation of the recovery component action > handler for Windows so that most of the code can be reused in the > future for macOS recovery component. It also adds a unit test. > > Bug: 1029953 > Change-Id: Iead0b562ae311560b3ca0eacd8d417bedd007331 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946020 > Reviewed-by: Joshua Pawlicki <waffles@chromium.org> > Commit-Queue: Sorin Jianu <sorin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#721041} TBR=sorin@chromium.org,waffles@chromium.org Change-Id: I9cac86b0150217bc5e10915b4f54ce4a72365d08 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1029953 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949071Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#721065}
-
Michael Crouse authored
This change records the duration of successfully evaluating a prediction model. No timing is recording if the evaluation fails or a cached result is used. Bug: 1001194 Change-Id: I73b1f11cdfb7c9cbc4759e4de13b182c6e2e0b66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946926Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#721064}
-
Alex Gough authored
These pipes were used by Inter-Module Comms (IMC) but this was disabled some time ago. (see https://crbug.com/nativeclient/3864) Bug: 1023583 Change-Id: I8c6c573d32d6a7fff2218b8a3739d66684665185 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934867Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Mark Seaborn <mseaborn@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#721063}
-
Dominic Battre authored
Chrome contains Autofill{CreditCard,Profile}Enabled and {CreditCard,Profile}AutofillEnabled function calls. This CL unifies them to the former. This CL does not modify the CWVPreferences interface on iOS because that's a public interface. Bug: 1027122 Change-Id: Iba26414d7ba9635ab2c2b9aa9f4e2d2cfb44a61e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929233Reviewed-by:Jared Saul <jsaul@google.com> Reviewed-by:
vitaliii <vitaliii@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#721062}
-
Avery Musbach authored
The present CL fixes what happens if you switch to tablet mode when the following criteria are met: 1. There are at least two displays. 2. There is only one window. 3. The window is active. 4. The window is snapped on the primary display. Without the present CL, NOTREACHED is hit (Issue 1024309), and there is also a crash if DCHECKs are disabled (Issue 1024325). Fixed: 1024309, 1024325 Change-Id: Ie1a6e378067076c7dbd8ec3ed388e70cd9382611 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938463 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#721061}
-
Dave Tapuska authored
Move the sudden termination enumeration to mojo and move the message to be transported on the LocalFrameHost mojom interface. BUG=1008432 Change-Id: I090df4df1e53b8dc5f4173e917a72d6bd1d33225 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928048 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#721060}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8c0012bc5c16..a002a375f2cc git log 8c0012bc5c16..a002a375f2cc --date=short --first-parent --format='%ad %ae %s' 2019-12-03 rslawik@google.com Merge "Cleanup: remove deprecated fields" 2019-12-03 lalitm@google.com Merge "trace_processor: don't reset ion memory counters" 2019-12-03 lalitm@google.com Merge "trace_processor: cleanup ugly double function call to get col by name" 2019-12-03 primiano@google.com Merge "Remove some other libprotobuf deps from perfetto cmdline client" Created with: gclient setdep -r src/third_party/perfetto@a002a375f2cc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I3c9e7d7869db728062873b17ff3c2ef211e9ee33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948983Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721059}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7b9a9186c365..4b6a26740234 git log 7b9a9186c365..4b6a26740234 --date=short --first-parent --format='%ad %ae %s' 2019-12-03 changhaohan@chromium.org Leverage CDP error signal for timezone emulation 2019-12-03 aerotwist@chromium.org Migrates js_main/ to esm Created with: gclient setdep -r src/third_party/devtools-frontend/src@4b6a26740234 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I49affd5ee94615497c04148a5a75c01f792e2003 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948970Reviewed-by:
-
Dave Tapuska authored
With change http://crrev.com/c/1659011 the secure state was incorrectly passed always as true into origin trials. While this shouldn't matter because origin trial tokens have not been issued for insecure origins in the pastthat is being experimented with and I was alerted to the oversight in my CL. This change moves the initialization of the SecureContextState after the origin is determined but before origin trials are initialized. BUG=970360 Change-Id: I8001f15d8e6ffac6d4b043f1f35529fece9977ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940561 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
-
Friedrich Horschig authored
Unfortunate timing may lead the threshold calculation to request a height for an internal state (e.g. calling expand() right after requestShowContent() before the animation finishes). Transition from/to internal states should always succeed, so consider a threshold cleared if one of the states in transition is internal. Bug: 1028783 Change-Id: I8650845c23e1ba9f13fd8c79c7e021637d824777 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939414 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Auto-Submit: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
-
Vasilii Sukhanov authored
Bug: 986298 Change-Id: I18c57d1987c64b5c303a02ffb8097d9b011b313f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948896 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#721055}
-
Trevor Perrier authored
This CL adds the list android_bundle_locales_as_resources which formats all locales for .xml resource outputs. It then uses this new list in all the android output list in all build targets that used have .xml outputs. In addition the following two .grd files were missing .xml outputs for the most recently added locales on Android. And these were updated. - chrome/android/features/keyboard_accessory/internal/java/strings/ android_keyboard_accessory_strings.grd - chrome/browser/touch_to_fill/android/internal/java/strings/ android_touch_to_fill_strings.grd No new locales were added to apk bundles. Bug: 812837 Change-Id: Ib9587def0aceb6894b27a8b3dc39ce920c768377 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940949 Commit-Queue: Trevor Perrier <perrier@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#721054}
-
Armando Miraglia authored
To reduce the risk of issues by posting WTF::String objects, this CL postpones the conversion to when the result is available in std::string rather than before posting the closure. Bug: 1028536 Change-Id: I6560f788d76973551f66041af7abe85965cddd54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944674 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#721053}
-
Dominic Farolino authored
Current spec discussion is heading in the direction of ultimately not considering a request's initiator origin when determining the referrer, and instead preferring Chrome's old behavior. We need a resolve by the branch point (12/05), so this CL preemptively reverts, for the last time, the previous referrer changes introduced in crrev.com/c/1808663, restoring the referrer-computing logic in //net and Blink to the original behavior. A future CL will change the WPT expectations so that Chrome passes the tests, since it seems we will change the spec to match Chrome's old behavior here. R=yhirano@chromium.org TBR=caseq@chromium.org,kinuko@chromium.org,lizeb@chromium.org Bug: 1021908 Change-Id: I9ffeb3e3982b141a101242d2fc7004b753a6e681 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946861Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#721052}
-
Oleg Davydov authored
Historically we've computed extension resources' hashes in ContentHash::CreateHashes, but logically it's a job for ComputedHashes class, so now we do it in ComputedHashes::Compute method. In the future this will allow us to reuse ComputedHashes::Create for other purposes (eg. testing or computing hashes upon installation for self-hosted extensions). Bug: 796395, 958794 Change-Id: Ie16c53ee682a4b8066dd2e929e13cbbc5be2d6ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913415 Commit-Queue: Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#721051}
-
Jonathan Backer authored
Official builds remove logging on CHECKs to save space. Plus, we should remove the CHECK before branch. Instead we should lose the context. Bug: 1026629 Change-Id: Ifa8c1ff1bdfad10d5f7535fa680f41197708aaa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948520 Commit-Queue: Jonathan Backer <backer@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Auto-Submit: Jonathan Backer <backer@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#721050}
-
Takumi Fujimoto authored
This reverts commit d065c828. Reason for revert: Suspected to be a culprit for a webkit_layout_tests failure: https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/49404 https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/49405 Original change's description: > Rebaseline GPU raster image tests after opaqueness tracking change > > Bug: 1028116 > Change-Id: I06e931ff71384883181db349dc269cd324da6975 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940447 > Auto-Submit: Brian Salomon <bsalomon@google.com> > Commit-Queue: Robert Phillips <robertphillips@google.com> > Reviewed-by: Robert Phillips <robertphillips@google.com> > Cr-Commit-Position: refs/heads/master@{#720956} TBR=bsalomon@google.com,robertphillips@google.com Change-Id: I18c368734f65de7e818fe029afaa1d2e960ebab1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1028116 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947600Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#721049}
-
jongdeok.kim authored
This CL adds 'explicit' to gfx::Insets constructors to prevent from unexpected construction. Change-Id: I2cd049ba3c1f5446014301ede13c79fe71e1b3c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943648 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#721048}
-
Peng Huang authored
Bug: 1012401 Change-Id: I579ae08f993073049b9677e90efc42239cd76490 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948521Reviewed-by:
-
Balazs Engedy authored
Given that we are going to provide users with a checkbox on chrome://settings/content/notification to directly turn on quiet prompts if they so choose, there is no need to expose options on chrome://flags to force the quiet prompt UI. In addition, QuietNotificationsPromptConfig::Activation no longer makes sense. Activation::kNever and Activation::kAlways now have the same semantics as the checkbox on chrome://settings/content/notification, but clearly, the user decision should take precedence, so it is pointless to have those activation states in the first place. The state Activation::kAdaptive previously had the semantics of gating the quiet prompt UI on AdaptiveNotificationPermissionUiSelector's result but now we have three different ways to turn on the quiet UI, so this lacks sufficient granularity today. Instead, it should always be possible for the user to turn on/off quiet mode manually, and there should be two boolean variation parameters that gate whether 1) the quiet state will be turned on adaptively by three consecutive denies, or by Safe Browsing. This CL implements the first for now. Bug: 1028642 Change-Id: I7a1c216c4ec121110023e1e1ac0f3ed4baa76b2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945822 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#721046}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/392bb2bdc686..a61151f11cbe git log 392bb2bdc686..a61151f11cbe --date=short --first-parent --format='%ad %ae %s' 2019-12-03 perezju@chromium.org [tracing] Add khokhlov to relevant OWNERS files 2019-12-03 khokhlov@google.com [py_trace_event] Clear global state at the end of the trace session Created with: gclient setdep -r src/third_party/catapult@a61151f11cbe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1029008,chromium:990304 Tbr: sadrul@google.com Change-Id: Ib56ae34dfcddfbbbd9a449c677f40d3b777b88ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948913Reviewed-by:
-
Egor Pasko authored
The Memory.Experimental.Renderer2.Malloc is unreliable on Windows (equally for other processes: Browser2.Malloc, Extension2.Malloc, etc.) Clarified this in a comment to the histogram suffix, with a reference to related past discussion in crbug. Bug: None Change-Id: If9efb446fd76c74daa327869daa01f2530f4a9f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948439 Commit-Queue: Egor Pasko <pasko@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#721044}
-
Markus Handell authored
Instead of passing the video encoding on creation, pass it on each frame instead. This enables the muxer to be created before the encoding of the stream is known. Bug: 1013590 Change-Id: If33ba3f7ac3633d2c3e9de16f0e027d6605006ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893853 Commit-Queue: Markus Handell <handellm@google.com> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#721043}
-
Joe Downing authored
This CL removes the ChromotingTestDriver and associated classes. These were used as a sort of native C++ Webapp stand-in but our backend has changed so much that none of this code will run w/o being rewritten. The FTL Playground is a better, working utility so we should just use that for now. Change-Id: Ic3dda75516a5a3486f2daf9a273b4a9fd588557a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946733 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#721042}
-
Sorin Jianu authored
This CL refactors the implementation of the recovery component action handler for Windows so that most of the code can be reused in the future for macOS recovery component. It also adds a unit test. Bug: 1029953 Change-Id: Iead0b562ae311560b3ca0eacd8d417bedd007331 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946020Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#721041}
-
Yun Liu authored
This CL should after https://chromium-review.googlesource.com/c/chromium/src/+/1918719 Bug: 985581 Change-Id: Ib8731e21db5f4d93f44da36eaddfe755b95c53f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918639 Commit-Queue: Yun Liu <yliuyliu@google.com> Reviewed-by:
-
Kevin McNee authored
TabStripModel::kNoTab is static const member that is declared and initialized, but never defined. This causes linker errors when attempting to use this in test assertions. We provide the necessary definition and update tests that were working around this by using CHECKs instead of proper test assertions. Bug: None Change-Id: Ifc47e86815d6f71b6c337ea0634d109e841fb85a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946859Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#721039}
-
Mugdha Lakhani authored
to silently succeed when called for an unactivated service worker. Registration requires an activated service worker, so if unregister is called on an inactive service worker, we can assume there's no periodic sync registration and silently succeed. Bug: 1030237 Change-Id: I90d574b0a951b0908ba000e77db6ff9f70c7ddc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948440 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#721038}
-
Yun Liu authored
PowerMock depends on 2.5+ Bug: 512198 Change-Id: I38e27bbafa5699ad75403c9139d983b75be10337 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947626Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/b64fbfec4dcd..8ffeadb66ea7 git log b64fbfec4dcd..8ffeadb66ea7 --date=short --first-parent --format='%ad %ae %s' 2019-12-03 srisser@google.com Make Vk::Stringify return std::string Created with: gclient setdep -r src/third_party/swiftshader@8ffeadb66ea7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I20acfa01c566a293dc786c6ae8e2958a4539233e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948620Reviewed-by:
-
Koji Ishii authored
Following bot results are included. 509 512 513 87 lines were removed and 16 lines were deflaked by consecutive results since 498. TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: I4da63b288c1e1071d57fb15c3089f7f4dda386da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948366Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#721035}
-
