- 29 Aug, 2019 40 commits
-
-
Evan Stade authored
Bug: 998625 Change-Id: I6466a5b21e8ba51751d133649633df14b06be4bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774880Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#691633}
-
Owen Min authored
This is the second half of moving plugins in enterprise report from profile to browser. 1) Plugin information is put into basic request. 2) Basic request generation is async. 3) Full profile report is filled once the basic request is ready. Bug: 956237 Change-Id: I1e5919f8f61bed4b17a548c9d6708fc7538dc7b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775139Reviewed-by:
Marc-André Decoste <mad@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#691632}
-
Renjie Tang authored
https://quiche.googlesource.com/quiche.git/+log/6c73c33b7d8c..edeeb47d60bc $ git log 6c73c33b7..edeeb47d6 --date=short --no-merges --format='%ad %ae %s' 2019-08-27 bnc Wait for data to arrive in EndToEndTest.FlowControlsSynced. 2019-08-27 renjietang Remove notion of static stream in QuicStreamIdManager. 2019-08-26 nharper Enable simplify stop waiting in quic http EndToEndTests 2019-08-26 nharper QuicToyClient provides a hostname to CreateDefaultProofVerifier 2019-08-26 rch Allow QUIC end_to_end and quic_server tests to pass if the listening port is specified as 0 to allow Chrome tests to use 0 instead of attempting to find an unused port (which is hard). Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I4f5d79bbd1b331251b347732b5280d71e48273ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772480 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#691631}
-
Jan Wilken Dörrie authored
This change contains a small number fixes for the upcoming base::string16 switch to std::u16string. Bug: 911896 Change-Id: I2fabb795c61d6711f0818d655b400593398fd779 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773223Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#691630}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b4a6128e28a3..16946e3781ec git log b4a6128e28a3..16946e3781ec --date=short --no-merges --format='%ad %ae %s' 2019-08-29 sprang@webrtc.org Remove unused StorageType enum 2019-08-29 jakobi@webrtc.org Remove minimum bucket returned by histogram quantile function. Created with: gclient setdep -r src/third_party/webrtc@16946e3781ec If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: If7dc4995bf95687d462f48cd5f50e45e9dcd8a9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776199Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691629}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 52323b9f. With Chromium commits locally applied on WPT: 5546163a "Temporarily send `Sec-Fetch-*` headers via non-secure transport." d3b97055 "Update simulateUserActivation to match webxr-test-api spec" 2d090a27 "[WPT/referrer-policy] Call getRequestURLs() for each subtest" 90789f54 "Implement fallback to element anchor" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: dcheng@chromium.org, palmer@chromium.org: external/wpt/domparsing eirage@chromium.org: external/wpt/pointerlock yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I7aa58793a15ca711c5f259799d276320a7706d62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775863Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691628}
-
Denis Solonkov authored
This change adds the folder and stub of a compression script for the project. The overall idea of the project is to reduce the size of the library by compressing rarely used code and decompressing it on demand. For more information see README.md and the tracking bug. Bug: 998082 Change-Id: Idbb303a38cd73b0d31c5ce897e11bfdc3e1243a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768715 Commit-Queue: Denis Solonkov <solonkovda@google.com> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#691627}
-
Matthias Körber authored
Removed some unjustified |std::move| calls and converted |char *| arguments to |base::StringPiece|. Change-Id: I70ca792efaf5bb51eff23df99cba7ee1aa7380e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768351Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#691626}
-
Jonathan Backer authored
FrameResourceFence was introduced in https://chromium-review.googlesource.com/c/chromium/src/+/1600617 to properly support display of video from GpuMemoryBuffers. Idea is that DisplayResourceProvider will signal that a fence is needed (https://cs.chromium.org/chromium/src/components/viz/service/display/display_resource_provider.cc?rcl=b42e627df3d2285cccb73e90ace0c96667a42652&l=514) and later check if the fence has passed before deleting the resource (https://cs.chromium.org/chromium/src/components/viz/service/display/display_resource_provider.cc?rcl=b42e627df3d2285cccb73e90ace0c96667a42652&l=657). This CL does 2 things. (1) Fixes a bug where we were previously signaling the fence in DisplayResourceProvider::LockForRead, when we shouldn't have. We should only signal the fence once it is safe to delete. (2) Only sets |on_finished_callback| if some resource needed a readlock fence. This microoptimization improves performance on RendererPerfTest. Bug: 974359 Change-Id: If72985b566a6082382c0baf6887408fa42bb9299 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775100Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#691625}
-
Khushal Sagar authored
A failure to allocate a CanvasResource should be handled safely. R=fserb@chromium.org Bug: 994979 Change-Id: I93303b7874a0286621344f7f9a6cdab9495e0919 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772303 Auto-Submit: Khushal <khushalsagar@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#691624}
-
Sigurd Schneider authored
The element with the color collapsed to zero width, because its only content was a whitespace character that got collapsed. I replaced it with a zero-width whitespace, this way the element gets the right width from CSS. Bug: chromium:996774 Change-Id: Ie6322196c7575b0c1b2c402b97bb2928f62ed114 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774631Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#691623}
-
Vadym Doroshenko authored
This CL replaces PasswordFormManager->NewPasswordFormManager. The main difference is that a constructor of form managers are different: PasswordFormManager takes PasswordForm NewPasswordFormManager takes FormData (which is converted to PasswordForm inside NewPasswordFormManager during parsing). Bug: 949519 Change-Id: I44dbd48b8c61d8c72d779eaf4feefed826271582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774622Reviewed-by:
-
Matt Falkenhagen authored
This is a follow-up to r689906. It converts code added since then. Also, this fixes a flaky DCHECK hit when trying to use the KeepAliveRegistry after shutdown, when running the VerifyShutdownBehavior test locally. I think this happens when the core thread is the UI thread because we immediately try to make keep alive object instead of posting a task to the UI thread to do so. [ RUN ] BackgroundSyncBrowserTest.VerifyShutdownBehavior [FATAL:keep_alive_registry.cc(107)] Check failed: !is_shutting_down_. ... 3 KeepAliveRegistry::Register() 4 BackgroundSyncControllerImpl::BackgroundSyncEventKeepAliveImpl::BackgroundSyncEventKeepAliveImpl() 5 BackgroundSyncControllerImpl::CreateBackgroundSyncEventKeepAlive() 6 content::(anonymous namespace)::CreateBackgroundSyncEventKeepAliveOnUIThread() 7 content::BackgroundSyncManager::DidResolveRegistrationImpl() Bug: 824858 Change-Id: I5d2ad7878cbd35203fe81fda013f1a839ee89c7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772415Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#691621}
-
Jamie Madill authored
Will be used for the ANGLE integration. Bug: angleproject:3876 Change-Id: I5689526555f529423395be3fb891424f6041a568 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773703Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#691620}
-
kylechar authored
We were inadvertently turning on OOP-R for browser UI when the following features were enabled: 1. DefaultEnableOopRasterization 2. VizDisplayCompositor 3. UiGpuRasterization Add UiOopRasterization feature to control OOP-R for browser UI. The only platform this should have any impact on is Chrome OS where all three features are enabled at ToT but not fully launched yet. Bug: 995885 Change-Id: Iae4474a181f0a52a852b80f0d0b2dc45510aab18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765665 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
-
Robert Sesek authored
This will replace //base/third_party/dmg_fp. dmg_fp takes at least one mutex for every conversion, which is sub-optimal for performance. The new double-conversion library comes from V8, and it is also used in Blink. A future CL will move Blink onto this copy in //base. Compatibility risk is high because things may rely on specific output output behaviors of the old implementation. Bug: 95729 Change-Id: I6b08093ff4e38e257629f1fcf1d4f095e170c24a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698345 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
-
Yutaka Hirano authored
To resolve OOR-CORS blocking enterprise issues, this CL defines kExtraSafelistedHeaderNames. This is a very short term fix and violates layer in order to make it mergeable. We'll use it only for M77. This affects only the OOR-CORS enabled path. Bug: 999052 Change-Id: I66ab8f298ed761aa3d78d02fa521d1c08f492fed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774010 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#691617}
-
Robbie Gibson authored
The root cause was that the contentView of the grid cell was getting set to black, instead of the same as the top bar background color, causing a brief flicker to black as different views faded in and out. Also removes a now-unnecessary iOS 13 SDK compiler guard. Bug: 997165 Change-Id: I56ed43b35aa3f61a22df5b0abf9c1398a8e513f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771905Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#691616}
-
Max Moroz authored
This reverts commit 0d648721. Reason for revert: this didn't help, the iOS bots should either use the Chromium bundled Clang or don't build fuzzers Original change's description: > Revert "[base] Use FuzzedDataProvider included in LLVM package." > > This reverts commit 20d2671d. > > Reason for revert: Causes build failures on iOS bots, see: https://crbug.com/999096 > > Original change's description: > > [base] Use FuzzedDataProvider included in LLVM package. > > > > Bug: 991200 > > Change-Id: Iee88e3a81057d509e18a2875a3070c5abc17c959 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774303 > > Auto-Submit: Max Moroz <mmoroz@chromium.org> > > Commit-Queue: Lei Zhang <thestig@chromium.org> > > Reviewed-by: Lei Zhang <thestig@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#691207} > > TBR=thestig@chromium.org,mmoroz@chromium.org > > Change-Id: I044f8863f8fa7e2bb9e70b0f33e73fdd8bfa2a29 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 991200, 999096 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776043 > Reviewed-by: Oskar Sundbom <ossu@chromium.org> > Commit-Queue: Oskar Sundbom <ossu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#691575} TBR=thestig@chromium.org,mmoroz@chromium.org,ossu@chromium.org Change-Id: Ic811649e40c0932146f8fc275e142f47adc3f5f8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 991200, 999096 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776203Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#691615}
-
Christian Dullweber authored
Bug: 967668 Change-Id: I7c87919cc901d0e7253a49df510fe4cfc930ce30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776044 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#691614}
-
Peter Wen authored
This adds a guard rail metric for how long module installer framework code runs during startup. It allows us to measure the current state in the wild as well as improvements down the line. Also clean up references to the backend, moving static methods to instance methods. We end up initializing SplitInstallManagerFactory in recordModuleAvailability and also calling ModuleInstaller#init, so there was no benefit to keeping it a static method. Bug: 994030 Change-Id: I711d257fed83324202082a9947e4391da859e6b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774100 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
Nicolas Ouellet-Payeur authored
The `check_network_annotations' step on CQ now uses the `python_script' backend instead of the `clang_tool' backend, making it much faster and (hopefully) less flaky. Also changes the default backend to `python_script', when running traffic_annotation_auditor.exe locally. Bug: 966883 Change-Id: Icc608a15608418328774019d3ef25994201e3104 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762747Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/01615892494a..6dc3546ccbe4 git log 01615892494a..6dc3546ccbe4 --date=short --no-merges --format='%ad %ae %s' 2019-08-29 lalitm@google.com trace_processor: add macro for generating zero boilerplate tables Created with: gclient setdep -r src/third_party/perfetto@6dc3546ccbe4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: chromium:135177627 Change-Id: I90acd29e29a52419a2350f8cb610a49e8cfc3241 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775677Reviewed-by:
-
Xida Chen authored
Most of the test cases in webkit-transform-interpolation-005.html are already covered in transform-interpolation-005.html, except for 2 test cases, and this CL ports those two cases to wpt. Bug: 900581 Change-Id: I4ef5d0322877a6820db686e1c8a54a89fec53bcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775662Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#691610}
-
Rayan Kanso authored
Bug: 997200 Change-Id: If0de01ac867d143a02870d5856dd97b9f7e4c0b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773256Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#691609}
-
Oskar Sundbom authored
It triggers MSAN errors. Fix is in progress. Tbr: thestig@chromium.org Bug: 999076 Change-Id: I98786def4ca52ef871a2061981c651a223b12f33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776028 Commit-Queue: Oskar Sundbom <ossu@chromium.org> Reviewed-by:
Oskar Sundbom <ossu@chromium.org> Cr-Commit-Position: refs/heads/master@{#691608}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/56ab188a1a0a..fb8b9bf493bb Created with: gclient setdep -r src-internal@fb8b9bf493bb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I9d9415517f5bb7c1b8a8574c1d97ae2f8fc42b1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775616Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691607}
-
Antonio Gomes authored
... now that its clients got Onion souped. BUG=787254, 704136 R=guidou@chromium.org, haraken@chromium.org Change-Id: I8092b60a41165d515ade8b1ac6e628c491168ec5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775004 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#691606}
-
Vadym Doroshenko authored
This CL replaces PasswordFormManager->NewPasswordFormManager. The main difference is that a constructor of form managers are different: PasswordFormManager takes PasswordForm NewPasswordFormManager takes FormData (which is converted to PasswordForm inside NewPasswordFormManager during parsing). Bug: 949519 Change-Id: I0db3bf7bffb8d0bf31bd2f2357b18a7466552f9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774287Reviewed-by:
-
Jan Wilken Dörrie authored
This change implements using strong booleans for the creation of CredentialLeakTypes. These are implemented using util::StrongAlias, which increases type-safety and prevents accidental assignment between separate boolean parameters. Furthermore, this change performs some other small clean-ups. Bug: 986317 Change-Id: I5d08b634921d36abe5a8d1354398fb7a6761b825 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768353 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/6dcd4dc56a9d..b4a6128e28a3 git log 6dcd4dc56a9d..b4a6128e28a3 --date=short --no-merges --format='%ad %ae %s' 2019-08-29 nisse@webrtc.org Delete unneeded dependencies on libjingle_peerconnection_api 2019-08-29 philipel@webrtc.org Increased event log visualizer RTP clock estimation tolerance. 2019-08-29 srte@webrtc.org Fix for tsan failue in real time scenario tests. Created with: gclient setdep -r src/third_party/webrtc@b4a6128e28a3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I7c473df9af9d810a7f9551dc3977afee2a1e54da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775617Reviewed-by:
-
Ivana Zuzic authored
Since we're planning to launch the same editing activity in two different cases, a new generic interface for launching the editing activity and saving the changes on passwords has been added. It's called password_change_delegate. Two different delegates will implement it in two possible use cases. In the first use case the editing activity is launched from the password viewing activity or from the password list displayed in the saved password preferences. In that case the password entry already exists in the store and needs to be changed. In the second use case the editing activity is launched from the InfoBar when a new password was detected and still hasn't been saved in the store. In that case, another delegate will implement the interface and it will have to create new password records in the store. Because we can't rely on PasswordManagerPresenter persisting through the process, the delegate and the PasswordEntryBridge need to stay alive while the password editing activity exists. They need to be destroyed when the password editing activity is destroyed. Bug: 377410 Change-Id: I53be371375a590c9b928e98800b0be24a36f333d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768524Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Ivana Zuzic <izuzic@google.com> Cr-Commit-Position: refs/heads/master@{#691602}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3e737ddc..2acf62ad Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I36a1d5847c30339e3c9febaa3dbb46d196f8409e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773413Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691601}
-
Antonio Gomes authored
This is phase 1.7 on the design document [1]. [1] https://docs.google.com/document/d/1AJKVA5U4nDkyDB9p4ROrggWXadCxyy-grKaE9KS5vOU/ Files were move to renderer/platform/peerconnection directly, and a factory header was added (namely [2]), so that content/ continue to access RTCVideoEncoder's functionality. [2] //t_p/blink/public/platform/modules/peerconnection/web_rtc_video_encoder_factory.h As part of the move to Blink, this CL also embeds the declaration of base::Feature "kWebRtcScreenshareSwEncoding" into rtc_video_encoder.cc|h, and remove the respective content declaration from [3]. [3] //content/public/common/content_features.cc|h BUG=787254 R=guidou@chromium.org, haraken@chromium.org TBR=kinuko@chromium.org Change-Id: Ibf3bc012443afd9d2112ab88133b41b844f00fba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775002 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
kylechar <kylechar@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#691600}
-
Kent Tamura authored
This removes script_forbidden_scope.h dependency from platform/heap/handle.h. This CL reduces estimated pre-processed size of platform/heap/handle.h by 0.5MB. Bug: 242216 Change-Id: I901d582599ac0a5c581efb4fbe9faa76772bf0af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775643Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#691599}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/9d20c5a52d62..fdfb44eeed33 git log 9d20c5a52d62..fdfb44eeed33 --date=short --no-merges --format='%ad %ae %s' 2019-08-29 vapier@chromium.org cros_collections: workaround <=Python-2.7.8 bug Created with: gclient setdep -r src/third_party/chromite@fdfb44eeed33 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I2a364ce76f665ab7f8980766f48d550bae9c4f3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775610Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ieedccdce0a024c6e985a3890d7a46c60adf17a65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775612Reviewed-by:
-
Julie Jeongeun Kim authored
This CL converts LockHandleAssociatedPtr and LockHandleAssociatedPtrInfo to new Mojo types. It also updates Granted from lock_manager.mojom. Bug: 955171, 978694 Change-Id: I02ba0cdbe52f8f04b3e4514a1f335917db368559 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771365 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#691596}
-
Julie Jeongeun Kim authored
This CL converts BlobURLTokenRequest to new Mojo types. It updates ResolveForNavigation and Clone from blob_url_store.mojom and methods and members with new Mojo types. Bug: 955171, 978694 Change-Id: Ib18e1c3834e6b0c6129cd2c9b1f13930a06a909d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772791Reviewed-by:
-
Mohamed Abdelhalim authored
NavigationHandleImpl::GetDelegate usages are replaced by NavigationRequest::GetDelegate, and state_for_testing() is removed. Bug: 916537 Change-Id: Ib772f416453a471ce0cac8c917563060f57a3d83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773148Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Mohamed Abdelhalim <zetamoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#691594}
-
