GitLab

Prior instrumentation indicates potential memory corruption detected
in creating the bloom filter and prefix set.  Add new code to see if
it's transient (probably memory corruption) or persistent (probably
code flaws).

BUG=71832


Review URL: https://chromiumcodereview.appspot.com/10857002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151641 0039d316-1c4b-4281-b951-d872f2087c98

introduced in http://src.chromium.org/viewvc/chrome?view=rev&revision=151399

BUG=None
TEST=None

R=kalman@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10823322

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151640 0039d316-1c4b-4281-b951-d872f2087c98

there can be ordering problems with shutdown.

BUG=137342
TEST=none
R=stevenjb@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10857009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151639 0039d316-1c4b-4281-b951-d872f2087c98

R=jhawkins@chromium.org
BUG=none


Review URL: https://chromiumcodereview.appspot.com/10855137

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151638 0039d316-1c4b-4281-b951-d872f2087c98

EGL only recognizes the GL_FRAMEBUFFER target for
glFramebufferTexture2D.  Also mark GL_DRAW_FRAMEBUFFER
as an invalid parameter to OpenGLES framebuffer
object functions, as only GL_FRAMEBUFFER is valid.

Also, use the _EXT versions of framebuffer enums on other targets,
to regularize with the use of EXT functions.

BUG=chrome-os-partner:11070
TEST=local build, run on ARM

Change-Id: I14d495f0195491df186b60f164ce342e7e5c9463


Review URL: https://chromiumcodereview.appspot.com/10827310

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151637 0039d316-1c4b-4281-b951-d872f2087c98

Skipping few failing tests from gpu_tests, performance_ui_tests and sync_integration_tests on coverage bot.

Review URL: https://chromiumcodereview.appspot.com/10837246

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151636 0039d316-1c4b-4281-b951-d872f2087c98

http://crbug.com/125937
TBR=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10825353

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151635 0039d316-1c4b-4281-b951-d872f2087c98

BUG=125846
TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10827344

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151631 0039d316-1c4b-4281-b951-d872f2087c98

Also moved NameToValue() and ValueToName() from jingle_messages.cc to name_value_map.h . These functions simplify string<->enum mapping.

BUG=137135

Review URL: https://chromiumcodereview.appspot.com/10829324

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151629 0039d316-1c4b-4281-b951-d872f2087c98

initialized.

This change reverts the change to renderer_main.cc in the following
CL:

 https://chromiumcodereview.appspot.com/10779040

BUG=140688
TBR=jam@chromium.org, kaiwang@chromium.org, jamesr@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10830328

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151628 0039d316-1c4b-4281-b951-d872f2087c98

Plus sort-headers.py that I forgot to do in the latest patch.

BUG=125846
TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10832287

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151627 0039d316-1c4b-4281-b951-d872f2087c98

Currently, it is read from OS (if available) or set to 5 seconds (on Windows). In some cases the OS provides ridiculous values (30s on Mac). 

This change hard-codes the timeout to 1 second, which is the default used by getaddrinfo on Windows and Mac.

BUG=124437


Review URL: https://chromiumcodereview.appspot.com/10826212

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151626 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151624 0039d316-1c4b-4281-b951-d872f2087c98

I want r621 for the NaCl SDK to build gtest, but the rest look minor.

618: fix address past end of stack in death test
619: wiki change
620: pump.py doesn't split long IWYU lines
621: fix building gtest on native client with glibc

BUG=none

Review URL: https://chromiumcodereview.appspot.com/10830312

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151623 0039d316-1c4b-4281-b951-d872f2087c98

BUG=142727

Review URL: https://chromiumcodereview.appspot.com/10823335

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151622 0039d316-1c4b-4281-b951-d872f2087c98

These stub classes are used when building Chrome on Linux with
chromeos=1. They allow sufficient UI to work to show a Bluetooth
adapter, enable and disable it, and show an unconnected fake device
associated with it.

This can be trivially extended to provide all manner of fake
Bluetooth information for UI development.

BUG=chromium-os:28555
TEST=out/Debug/chrome

Change-Id: I7af28be76355fad735389aaf2fa499d0a8dfd76b


Review URL: https://chromiumcodereview.appspot.com/10823301

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151621 0039d316-1c4b-4281-b951-d872f2087c98

Right now it is just c_salt/test moved over, but the goal is to use this to
allow gtest to forward test results to the browser, and from there to a local
server.

BUG=none
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/10854137

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151620 0039d316-1c4b-4281-b951-d872f2087c98

Move Variations stuff into variations/ directories and add OWNERS files for the variations client team.

BUG=None
TEST=No user visible changes.
Review URL: https://chromiumcodereview.appspot.com/10828314

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151619 0039d316-1c4b-4281-b951-d872f2087c98

Also, remove use of RenderViewHostImpl from WebContentsObserver as it is not needed.

BUG=98716


Review URL: https://chromiumcodereview.appspot.com/10823315

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151617 0039d316-1c4b-4281-b951-d872f2087c98

Contributed by skonig@chromium.org

BUG=142514
TEST="Manual - run the app without the app ID added to the whitelist and confirm it fails.  Then run again with app ID added to the whitelist and confirm it works."

Review URL: https://chromiumcodereview.appspot.com/10834315

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151616 0039d316-1c4b-4281-b951-d872f2087c98

BUG=116317
TEST=compiles
Review URL: https://chromiumcodereview.appspot.com/10823328

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151615 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE
TEST=NONE.
Review URL: https://chromiumcodereview.appspot.com/10832312

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151614 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151613 0039d316-1c4b-4281-b951-d872f2087c98

Rolling the DEPS of Breakpad in order to get the file descriptor support for
generating minidumps, it is needed on Android.

BUG=None
TEST=Breakpad unit-tests should compile and run.


Review URL: https://chromiumcodereview.appspot.com/10825329

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151612 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151610 0039d316-1c4b-4281-b951-d872f2087c98

R=pkasting@chromium.org
BUG=137836


Review URL: https://chromiumcodereview.appspot.com/10829305

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151609 0039d316-1c4b-4281-b951-d872f2087c98

TBR=yutak@chromium.org
BUG=none


Review URL: https://chromiumcodereview.appspot.com/10824301

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151608 0039d316-1c4b-4281-b951-d872f2087c98

BUG=115936


Review URL: https://chromiumcodereview.appspot.com/10825264

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151607 0039d316-1c4b-4281-b951-d872f2087c98

BUG=142706


Review URL: https://chromiumcodereview.appspot.com/10827332

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151606 0039d316-1c4b-4281-b951-d872f2087c98

* Add public methods AddEntryToDirectory, RemoveEntryFromParent and RefreshDirectory to GDataDirectoryService, as well as private helper RefreshDirectoryInternal. Also make RefreshFileInternal private. All of these take FileMoveCallback.
* Add OnDirectoryChangeFileMoveCallback to handle callbacks of RemoveEntryFromParent and RefreshDirectory. AddEntryToDirectory uses OnMoveEntryToDirectoryWithFileMoveCallback.
* AddEntryToDirectory and RemoveEntryFromParent just call GDataDirectory's methods AddEntry and RemoveEntry.
* Logic of GDataFileSystem::RequestDirectoryRefreshByEntry is now in GDataDirectoryService::RefreshDirectoryInternal.
* AddUploadedFileOnUIThread has been broken up with new continuation functions ContinueAddUploadedFile and AddUploadedFileToCache, as well as AddUploadedFileParams, to ensure proper ordering of function invocations.
* MoveEntryToDirectory no longer accepts null callbacks.
* Ensure parent_ pointer is correct at all times. It needs to be reset in RemoveChild, and be NULL in AddEntry.

BUG=137725
TEST=unit tests.
Review URL: https://chromiumcodereview.appspot.com/10829277

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151605 0039d316-1c4b-4281-b951-d872f2087c98

BUG=141635
TEST=Unittest


Review URL: https://chromiumcodereview.appspot.com/10825327

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151604 0039d316-1c4b-4281-b951-d872f2087c98

Revert 151586 - [net/dns] Resolve AF_UNSPEC on dual-stacked systems. Sort addresses according to RFC3484.

BUG=113993
TEST=./net_unittests --gtest_filter=AddressSorter*:HostResolverImplDnsTest.DnsTaskUnspec

Review URL: https://chromiumcodereview.appspot.com/10442098

TBR=szym@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10855163

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151603 0039d316-1c4b-4281-b951-d872f2087c98

Rid the world of the last of views::Event types: TouchEvent, GestureEvent, MouseWheelEvent, ScrollEvent and DropTargetEvent, in favor of ui::Event derivatives.

http://crbug.com/125937
TBR=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10824295

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151602 0039d316-1c4b-4281-b951-d872f2087c98

ChunkDemuxerTest.TestDurationChangeTimestampOffset tickled a precision error in
32-bit linux due to the division by InSecondsF(). This situation can be avoided
by moving the double -> TimeDelta conversion into WebMediaPlayerImpl so that
ChunkDemuxer can compute all times in terms of TimeDeltas.

BUG=NONE

Review URL: https://chromiumcodereview.appspot.com/10823300

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151601 0039d316-1c4b-4281-b951-d872f2087c98

Splits out the IP routing parameters (address, netmask, gateway) from
the name server parameter, so that we can override just the name
servers or the routing parameters, and get the other one from DHCP.

Also adds a new widget class: EditableTextField, that allows a static
display value when not editable, and an edit field when editable, with
the ability to do validation and has a model that can be reverted.

This new class is used for the basis of an IP Address input field that
does correct IP address validation.

Also, the new StaticIP dialog now sets/gets the shill properties for
static IP instead of setting IPConfig objects (which isn't supported by
shill), which should fix manual static IP configuration.

BUG=chromium:129052
TEST=Ran on device and tested StaticIP configuration, ran some unit tests.


Review URL: https://chromiumcodereview.appspot.com/10827283

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151600 0039d316-1c4b-4281-b951-d872f2087c98

As a response to the suggestion made by satorux@, here is an initial OWNERS file
for chromeos/display.  To begin with, I am adding myself and sque@ since other
frequent contributors should be inherited from chromeos/OWNERS.

BUG=none
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10832304

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151599 0039d316-1c4b-4281-b951-d872f2087c98

Mostly a refactor of the picker controller, plus an initial (not complete - missing throbber image support) version of the Gtk dialog

BUG=137281


Review URL: https://chromiumcodereview.appspot.com/10827238

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151598 0039d316-1c4b-4281-b951-d872f2087c98

Unreviewed build fix. Submit for miu@chromium.org

TBR=mihaip@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10823331

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151597 0039d316-1c4b-4281-b951-d872f2087c98

BUG=122908
TBR=oshima@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10829176
Patch from Harry McCleave <harrym@chromium.org>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151596 0039d316-1c4b-4281-b951-d872f2087c98

BUG=121174

Review URL: https://chromiumcodereview.appspot.com/10809094

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151595 0039d316-1c4b-4281-b951-d872f2087c98