- 17 Dec, 2020 40 commits
-
-
Ted Choc authored
Makes BlankCTATabInitialStateRule more robust: * Handles the activity being restarted as part of the test. * Handles the case where all tabs are closed. Performance metrics: 117777 -> 77156 BUG=989569 Change-Id: Ib1281d1160a76595c6ef5ead3cde2a7fcd370293 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596034 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#838233}
-
Scott Violet authored
This verifies intersection observer properly reflects overflow-clip-margin on an ancestor. BUG=1157843 TEST=test only change Change-Id: I9c9839294df8ffb88b42947aa87c7cc5222f5a6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593812Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#838232}
-
Xida Chen authored
This is a code health CL, no behaviour change is expected. Bug: 1152278 Change-Id: Ic4a28f6b32b30427c8a5da2f72e1c3a55c85595a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597639Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#838231}
-
Gavin Williams authored
Set the dir attribute based on the language to enable RTL based styling. http://screen/3NMj5SV79ka7cFW Bug: 1059779 Change-Id: I7dc492fde9724d5cac9529b8866db2eb4d87a632 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597757Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#838230}
-
Mike Dougherty authored
Bug: 1159836 Change-Id: Iddc347d1ea2c79f4ab330345fe2c2782d21e1849 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596865 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Megan Jablonski <megjablon@chromium.org> Auto-Submit: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Cr-Commit-Position: refs/heads/master@{#838229}
-
yiyix authored
After allocate a large buffer in memory and creating canvas, it will trigger the garbage collection from v8, which will trigger HtmlCanvasElement::Dispose to be called. This call will cause the canvas element detached from the |host|. However the |host| is saved as a valid callback in the observer list of the canvas resource provider. Calling this |host| without canvas element causes this access to poison address. In my fix, after garbage collection is triggered and dispose is called, DiscardResourceProvider() is called as well, so it removes itself from the observer list. Bug: 1158266 Change-Id: I40bfc24ff5dcdb7a248114220100b6dd54ac06f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595734 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#838228}
-
Sean Gilhuly authored
This reverts commit fbeb26e5. Reason for revert: Suspected cause of https://crbug.com/1159974 Original change's description: > Re-land #2 "Use new vulkan-deps repo for all Vulkan dependencies." > > Re-land #2 includes update to licenses.py and removes stale files. > > Re-land includes missing headers directory. > > This replaces several grouped dependencies with one meta-repo. > The meta-repo will allow us to group multiple inter-dependent > deps rolls into one single roll. This solves the problem of > separate rollers breaking because of the inter-dependencies. > It also allows ANGLE and Chrome to share common bits like the > README and .gitignore files. > > Bug: angleproject:5390 > Bug: 1153258 > Change-Id: Ie425e232096a25711dd90e84a6d91bf3324903ab > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595457 > Commit-Queue: Dirk Pranke <dpranke@google.com> > Reviewed-by: Dirk Pranke <dpranke@google.com> > Auto-Submit: Jamie Madill <jmadill@chromium.org> > Cr-Commit-Position: refs/heads/master@{#838196} TBR=thakis@chromium.org,dpranke@google.com,jmadill@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I60ab236419d36f55cf84c294f5a4e69f23c4c9c6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: angleproject:5390 Bug: 1153258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595256Reviewed-by:
Sean Gilhuly <sgilhuly@chromium.org> Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#838227}
-
David Bokan authored
This CL is the fist in a series to convert DataItem from the deprecated base::Callback (and Bind) to [Once|Repeating]Callback. See the relation chain of CLs for the complete change. This CL starts by converting a set of injectable callbacks used for unit tests to observe this class. These callbacks may be called repeatedly after being registered so they are RepeatingCallbacks. However, ItemFactoryCallback and ItemStoreDeleter both take a callback as a parameter. The unit test implementations only invoke these parameters once so we convert them to the "Once" variant. The RegisteredValuesCallback is a type defined in DataItem and used elsewhere. For now, we add a "Once" typedef to prevent changing too much. This will be removed in a downstream patch once all uses of the ambiguous form are removed. Bug: 1152268 Change-Id: I694df544b97ede7b1e5aa8af388ca4ed186d8156 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595932Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#838226}
-
Dominique Fauteux-Chapleau authored
This is a necessary step into getting per-profile Connectors to work, as some configurations could use different tokens per Connector when some are set at the machine scope while others are set at the profile scope. This also updates |authorization_callbacks_| and |pending_validate_data_upload_request_| to use the same mapping pattern as |can_upload_enterprise_data_|, this is actually a bug in how that was updated to map to Connectors in crrev.com/c/2499082 Bug: 1148789 Change-Id: Ib216dbfba5ade900c035513b70f2d07176bb87bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593761Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#838225}
-
cfredric authored
Change-Id: Ic19e456fa6e0c345dcaacebabd9b3f96aad33573 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595616Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Chris Fredrickson <cfredric@chromium.org> Cr-Commit-Position: refs/heads/master@{#838224}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fdd70108b562..692a30f556f5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC kmilka@google.com,gayane@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1106990 Tbr: kmilka@google.com,gayane@google.com Change-Id: Icb1f248ceb8d00a99e62d4e0b5f64ada5276411a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597736Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838223}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Id016c18f85fd20f5a410e3324933a72b7e8c8d71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597110Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838222}
-
Caleb Raitto authored
Requested by drott@ in crrev.com/c/2587435. Bug: 1025945 Change-Id: Ibcf257dabde32da874fd300b91e01d597d7d3a42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597458 Commit-Queue: Caleb Raitto <caraitto@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#838221}
-
Brian Sheedy authored
Removes expectations for the trace_test suite that have been determined to be stale. This only touches expectations that have passed 100% of the time on all builders. Bug: 648369, 978516, 969117, 1079393, 1155766 Change-Id: I257c4c51a8559186f63f0d02dc0d263e4383e908 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593973Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#838220}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/1ca6504eb7bb..1cc5b3357d2f 2020-12-17 amaiorano@google.com Optimize reciprocal sqrt operation 2020-12-17 amaiorano@google.com Optimize reciprocal operation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I73d3d1677653c69b3bcd35c60a227938018b480a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596785Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1608206305-43a406c5421ed694ad09e180106f1be95f3f52fa.profdata to chrome-mac-master-1608228003-46045c0c93c49596749cbb8f995ccd6fff023e1f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib231082fe1ad63d1e46325c83371de32a90cc6b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595394Reviewed-by:
-
Shimi Zhang authored
This is only available on S and above to make the whole platform consistent. The newly added flag and all the plumbing are for this purpose, so we could write the check in Android specific code. One issue still left for this feature, when the selection direction is changed, we need to pass a right position to magnifier. However the way we handling this case for teardrop handle selection change isn't working in some cases. We need to plumbing the direction information from renderer to browser. I'll do that in a separate CL. Bug: 1157372 Change-Id: I1c7edadad74dbef79a5b6ecf2c01f172bee097e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582521 Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
K. Moon <kmoon@chromium.org> Reviewed-by:
Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#838217}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7df55c21d64b..0b514ec56375 2020-12-17 brgoddar@microsoft.com Add basic Har importer unit test If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1159439 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia174393301e59dc147a22c1e3697646474f13196 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597716Reviewed-by:
-
Hidehiko Abe authored
We do not want to have runtime global static initialization. Currently, EnumTable hits the error, and the any code change for the files including EnumTable::instance causes bot failure, even if it is totally independent. This CL is the short term fix of the problem by changing instance fields to GetInstance methods. For the long term, we're switching to code generation. Thus, this CL tries to minimize the effort of the fix, rather than entier refactoring related constexpr. BUG=1158681 TEST=Ran on bots. Change-Id: Ia3400dd178ba9d5056e6543ccaf8a754559484b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594830Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
John Williams <jrw@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#838215}
-
Brian Sheedy authored
Updates the GPU unexpected pass finder script to output a list of bugs associated with removed stale expectations in several formats. This will make it easier to close out any necessary bugs and include the affected bugs in the CL description. Bug: 998329 Change-Id: Ia426974eb63c4123505787cd8bc010d6ccea1b91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594368 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
-
Evan Stade authored
Bug: 1147268 Change-Id: I78cf9a52db2e86004a113581544959711d212340 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594188 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#838213}
-
Clemens Arbesser authored
Starting with M-88, this new parameter must be explicitly set by all autofill_assistant triggers. The goal is to ensure that we will only show the bottom sheet immediately if the caller specifically requests this. While this was implicitly the case even before this change, it was more difficult to read and, more importantly, maintain. The corresponding change in the backend is currently under review, see cl/347804327. Bug: b/175677469 Change-Id: I7ed095e50af1a1f03d1fe49dc3fb67986859a059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595427 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Marian Fechete <marianfe@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#838212}
-
Xiaocheng Hu authored
Bug: 687225 Change-Id: I61798b274718a4de4e40fa4eb2af7a5ec8536b0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596825Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#838211}
-
Ahmed Mehfooz authored
Bug: 1156228 Change-Id: Ibdb45ebbd6b54d3316e16844e75ebf4a12560757 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597739Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#838210}
-
Jan Wilken Dörrie authored
This change simplifies the implementation of base::CharTraits and adds a specialization for wchar_t, leveraging clang's builtins if available. Bug: None Change-Id: Icedc3f8dc65a507552703ac5a30e062cc248e847 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596151Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#838209}
-
Joey Arhar authored
Without this patch, anchors can be stuck in the :active state if contenteditable is enabled before :active is removed. The special logic for anchors and contenteditable was added a long time ago [1], and the purpose was to prevent anchors from being clicked and navigating the page while in contenteditable. This patch makes SetActive capable of removing :active during contenteditable, which preserves the original intention of preventing anchors from navigating during contenteditable. [1] http://crrev.com/1d651243ad5b85bac9ebc8611a991a23d72d2f95 Fixed: 1007941 Change-Id: Ib51b846e99fd212a478f1278b3568bda4e5886a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595978 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#838208}
-
Chan Li authored
Change-Id: I776a940ec14c265af90d55517296222ba484741f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597186Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#838207}
-
Leonard Grey authored
Bug: 1152274 Change-Id: Id9df3bf030c8f979c8332beefe00880d50566d5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596133Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#838206}
-
Stepan Khapugin authored
Swap temporary strings for final ones. Bug: 1138892 Change-Id: Id74a69a4932539a0c69cda3b2b35136bdab42789 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596265Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#838205}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/fc4ac702..63b0f421 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib759877a9d2fe3b27fe3a0395ec545041e95ad7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595683Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838204}
-
Mikel Astiz authored
This patch allows the signin web page in the webview to post a message (method 'syncTrustedVaultKeys') that allows propagating the sync trusted vault encryption keys to the login-related code in the browser (GaiaScreenHandler), as part of the user authentication procedure. Messages are ignored if the client is not actually interested in these keys, which is controlled via feature toggle (disabled by default). A URL parameter is used to let the server know whether this API is enabled. The actual logic to implement this API is not included in this patch and instead a TODO is added for follow-up patches. Change-Id: I388f163e945551b1689f4d1ced3486a40511d22b Bug: 1081651 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589854 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#838203}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1762dd71. With Chromium commits locally applied on WPT: 45a15b95 "Cannot balance columns based on overflow block-size." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: Iff34f3051d4b61c7e9e79c9d7d8f1fb92a0a9793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597539Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838202}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1608206305-4389a6a6a359fb8abf452a6f4bc1a98be145b6cd.profdata to chrome-linux-master-1608228003-2821a99b00a027cd64fd6af5e6dc909e05bfef5c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I3676796359ceb47b47d773032f085abf6a7afd0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595393Reviewed-by:
-
Yi Gu authored
Bug: 1152282 Change-Id: I338c7a2cfb25348dda524a75fe0dc82483f8abb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595620 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#838200}
-
Daniel Cheng authored
When swapping in a new frame, the only frame tree pointer that will be set to a valid value is the parent. As such, `Swap()` is more about completing linkage of the new frame into the frame tree. Take advantage of that fact to eliminate: - the conditional branches for unlinking new frame from its previous and next siblings (as it will never have any siblings) - the conditional branches for updating the new frame's parent's first and last child (as the parent will never be aware of the new frame yet) In addition, `Detach()` already intentionally skips updating the frame tree pointer fields that `Swap()` needs, so skip the caching of the old frame's frame tree pointer values. The old values could become incorrect if JS dispatched during teardown of the old frame mutates the frame tree (e.g. mutations that affect adjacent siblings). Finally, `Swap()` was capturing `new_frame->parent_` at the beginning of `Swap()`: however, it may not even be set when initially calling into `Swap()`. Instead, since the conditional branches that consumed this value have been eliminated, skip caching this value as well. Bug: 1139872 Change-Id: I099e2486d532e4c784def583b70cd50ecca76326 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597190 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#838199}
-
Shakti Sahu authored
Bug: None Change-Id: I347e159bf8913e36239019f227bacb6389ed3122 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594182Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#838198}
-
Sven Zheng authored
Bug: 1157567 Change-Id: Icebc4367286fcb7372b9c6e7c8909b84d9dc9917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591487 Commit-Queue: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#838197}
-
Jamie Madill authored
Re-land #2 includes update to licenses.py and removes stale files. Re-land includes missing headers directory. This replaces several grouped dependencies with one meta-repo. The meta-repo will allow us to group multiple inter-dependent deps rolls into one single roll. This solves the problem of separate rollers breaking because of the inter-dependencies. It also allows ANGLE and Chrome to share common bits like the README and .gitignore files. Bug: angleproject:5390 Bug: 1153258 Change-Id: Ie425e232096a25711dd90e84a6d91bf3324903ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595457 Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
-
Guillaume Jenkins authored
Adds logic to the settings view controller to replace the sign-in item with an info button item that grays out the sign-in option. The info button's popover menu explains that sign-in is disable by the managed browser's organization, and provides a link to the chrome://management page for more information. As part of this change, the TableViewInfoButtonItem class was modified to support changing the color of the cell's main text and letting callers provide a pre-instantiated UIImage. Passing an image rather than an image name is necessary in the case of sign-in, because the image must be created by the SigninResourcesProvider. In addition, the EnterpriseInfoPopoverViewController was modified to enable one of the disabled constructors, which lets callers provide the primary text message. Screenshots of the new UI when sign-in is disabled: https://screenshot.googleplex.com/38X86W24GXm2Ej5 https://screenshot.googleplex.com/9yee95xBSJ7u3D6 UI mocks: go/bling-enterprise-q42020 (slide 6) Bug: 1155745 Change-Id: I099c67b93023fb3f78181bdfeae13dcb73a0e59e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591388 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#838195}
-
Chris Fredrickson authored
This TODO was addressed in https://crrev.com/c/2571806. Change-Id: I0c0b28e8cc9af0a6662a3da02f8550d86dd23733 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595718 Commit-Queue: Chris Fredrickson <cfredric@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Auto-Submit: Chris Fredrickson <cfredric@chromium.org> Reviewed-by:
-
