GitLab

https://dawn.googlesource.com/dawn.git/+log/ce2adba679a3..f5c44772a699

git log ce2adba679a3..f5c44772a699 --date=short --no-merges --format='%ad %ae %s'
2019-09-04 cwallez@chromium.org Use the agreed upon include path for spirv-cross.

Created with:
  gclient setdep -r src/third_party/dawn@f5c44772a699

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
TBR=cwallez@google.com

Bug: None
Change-Id: I6a457f860ce284fbfb1a80ce2cb484e091b6da0f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784389Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#693087}

The unified-consent flag is still being used for ChromeOS - the current
target milestone to run the experiment is M78. This CL extends the
expiry milestone for the unified-consent flag accordingly.

Bug: None
Change-Id: I54a9697fe028e26330fb8d47c67eeb30149407e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776029Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693086}

This is a reland of c96f561e

This CL has no changes compared to the original one. The error was on CL
https://crrev.com/c/1778671 (already relanded in https://crrev.com/c/1782514).

Original change's description:
> Remove web_rtc_video_encoder_factory.h from the Blink API
>
> ... now that its solely client has been Onion soup'ed [1].
>
> [1] https://crrev.com/c/1778673/
>
> BUG=787254
> R=guidou@chromium.org, haraken@chromium.org
>
> Change-Id: Iec6d37197e2899f3381029b0e9b628c8d927722b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778674
> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Guido Urdaneta <guidou@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#692769}

TBR=guidou@chromium.org

Bug: 787254
Change-Id: I70c21c22fac29972fe122ff21ee7c430f89b5acf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783166Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#693085}

Bakes enabled flags directly into pageVisibility instead of checking
it separately. This is cleaner, easier to understand and uses less code.

Also adds management indicator to OS people page (forgot this in
CL:1695350).

BUG=chromium:952232
TEST=Check that both regular and guest sessions look as expected.

Change-Id: Ie350c5c1544c7a3a82c0538fa89effd2c75a971b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710550
Commit-Queue: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Kush Sinha <sinhak@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693084}

TBR=treib@chromium.org

Bug: 1000455
Change-Id: Ife8b6a15bc9063fb10316a09b95e7e0de0661a98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782847Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693083}

Also define a constant and use the constant everywhere we interact with
Acorn, as we were using 3 different ecmaVersions.

Bug: 999794
Change-Id: I56043ebccdb7767180af2f4a6c337f1f58ff187b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778617
Commit-Queue: Tim van der Lippe <tvanderlippe@google.com>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693082}

We only build //media/gpu/linux when use_vaapi or use_v4l2_codec
buildflag is enabled. However, some files include the header files in
//media/gpu/linux when OS_CHROMEOS is defined.

This CL adds a new buildflag USE_CHROMEOS_MEDIA_ACCELERATION to
replace "USE_VAAPI or USE_V4L2_CODEC". Also it fixes the build
condition, and make sure the code could be compiled with these
combination:

1.  target_os = "chromeos"
    use_vaapi = true
    use_v4l2_codec = false

2.  target_os = "chromeos"
    use_vaapi = false
    use_v4l2_codec = false

3.  target_os = "linux"
    use_vaapi = false
    use_v4l2_codec = false

4.  target_os = "linux"
    use_vaapi = true
    use_v4l2_codec = false

BUG=chromium:996074
TEST=compile image_processor_test successfully with the gn args above

Change-Id: If0319791d97f23ee68b138925cd849f3d1eec764
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763649Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
Commit-Queue: Chih-Yu Huang <akahuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693081}

unittest

This CL change to test most of the test cases in JEA unittest using
aligned images so that they won't be ignored when testing with V4L2 JEA.

Bug: b/140471190
Test: jpeg_encode_accelerator_unittest
Change-Id: Ibccc48678dc1d6fd204ef77b3aa52d428225fafd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782281Reviewed-by: Ricky Liang <jcliang@chromium.org>
Commit-Queue: Wei Lee <wtlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693080}

This CL is based on https://webrtc-review.googlesource.com/c/webrtc.DEPS/+/151129.

Bug: 997673
Change-Id: I607b957bd7313a81ab8f6f8413456b3bc9958661
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781684
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693079}

There is a new field in stream params in order to know who uses CRAS.
Set it to CRAS_CLIENT_TYPE_CHROME for any stream from Chrome.

BUG=chromium:988295
TEST="cras_test_client --dump_a" can see the client type is Chrome.

Change-Id: Ife759e8f96889970ae5874ac284578df67d81b7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768596Reviewed-by: Olga Sharonova <olka@chromium.org>
Commit-Queue: Yu-Hsuan Hsu <yuhsuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693078}

Fix some unmatched #undefs that were supposed to cancel the effect of
their matching #define.

Bug: None.
Test: Successful build on arm-generic target.
Change-Id: Iaf0119a28158661a20acf7bc4a9d86fc37f40cc2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782302
Auto-Submit: Alexandre Courbot <acourbot@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Commit-Queue: Alexandre Courbot <acourbot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693077}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dffeb4a33ca1..7ea46aa7ee53


Created with:
  gclient setdep -r src-internal@7ea46aa7ee53

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: I411cacae3f0eaf4978ca65da0811e8e6584369c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784384Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#693076}

As measured by the histogram Signin.TokenServiceDiceCompatible, we
see that ~1% of the users on Canary are not migrating their tokens
correctly for Dice.

This CL removes the edge cases in ShouldMigrateToDice(), so that all
users should now migrate their token service for Dice.

The edge cases were:
1) account tracker service migration not completed
2) hosted domain information missing

The migration will now have the following behavior for these cases:
1) Dice migration will happen even if the account tracker migration
is not done
2) if the hosted domain information is missing, we use
IsNonEnterpriseUser(). This parses the email of the user and matches
the domain with a list of known non-enterprise domains. If the domain
is known to be non-enterprise, the token won't be revoked. Otherwise,
the token is likely to be enterprise and should be revoked.

Change-Id: I1d7fb12874e274edd8aea8af27fb5f77fa9f8b24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782617Reviewed-by: Monica Basta <msalama@chromium.org>
Commit-Queue: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693075}

Entering those strings in a <input type=number> leads to validation messages not being displayed in certain cases:
- rangeUnderflow (bug985330)
- rangeOverflow
- stepMisMatch

This is due to Decimal::FromString not recognizing it as valid, hence returning NaN incorrectly. decimal.h and the spec:
https://html.spec.whatwg.org/#valid-floating-point-number say it should be supported.

Fixes it and adds appropriate tests in wtf_unittests and in web_tests.

Bug: 985330
Change-Id: Ic3a3bb1ca855ebcc13f96aac16c31937a2cba0cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773262
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693074}

https://chromium.googlesource.com/angle/angle.git/+log/a1bf69967a32..1f6f69209ec2

git log a1bf69967a32..1f6f69209ec2 --date=short --no-merges --format='%ad %ae %s'
2019-09-04 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src 2c5ed16ba97d..9b3cc3e05337 (5 commits)

Created with:
  gclient setdep -r src/third_party/angle@1f6f69209ec2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC jmadill@chromium.org,jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jmadill@chromium.org,jmadill@google.com

Bug: chromium:None
Change-Id: Ie95392236b897780b413f6b2b2864438e6354957
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784383Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#693073}

Bug: 975524
Change-Id: Iafd0d275778777146af7c1cd47389facb127af31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778873
Commit-Queue: David Roger <droger@chromium.org>
Commit-Queue: Alex Ilin <alexilin@chromium.org>
Reviewed-by: Alex Ilin <alexilin@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Auto-Submit: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693072}

After https://crrev.com/c/1726051, the software compositing
path became broken. The reason is that WaylandCanvasSurface
used to be sending pending buffers without waiting for the last
submitted buffer to be processed. This resulted in hitting
the DCHECK(!pending_buffer_) on the host side.

This CL fixes the issue by implementing a queue of pending buffers
and limiting the possible number of buffers that can be created.

Basically, it does the same job as GbmSurfacelessWayland now.

Bug: 930664
Change-Id: Ia3af20e8dbfc74f672ffbf8fb2a3661182a9723e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780825
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693071}

Bug: 975588
Change-Id: I6915f7bd49909b3bdec9e0ed61d8c1938d7c9bd1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782159
Commit-Queue: David Roger <droger@chromium.org>
Commit-Queue: Alex Ilin <alexilin@chromium.org>
Auto-Submit: David Roger <droger@chromium.org>
Reviewed-by: Alex Ilin <alexilin@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693070}

https://chromium.googlesource.com/catapult.git/+log/e7c719c3e85f..decbf9926c9c

git log e7c719c3e85f..decbf9926c9c --date=short --no-merges --format='%ad %ae %s'
2019-09-04 perezju@chromium.org [Telemetry] Write intermediate results during results.Finalize

Created with:
  gclient setdep -r src/third_party/catapult@decbf9926c9c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC simonhatch@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=simonhatch@google.com

Bug: chromium:981349
Change-Id: Id28cd97bbb4454e50f1687487e789f632958626c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784382Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#693069}

Remove references in /base/test/launcher

MessageLoopForIO is going away soon. Use SingleThreadTaskExecutor for
main functions and SingleThreadTaskEnvironment for tests instead. Both
are no op changes.

This CL was uploaded by git cl split.

R=erikchen@chromium.org

Bug: 891670
Change-Id: Ic8ca95716f8679b687f586893f7033802f022432
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780827
Auto-Submit: Carlos Caballero <carlscab@google.com>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Carlos Caballero <carlscab@google.com>
Cr-Commit-Position: refs/heads/master@{#693068}

MessagePumpType should be used instead.

Bug: 891670
Change-Id: I6e73c7d3197beca3885aefbf71a7a64a26e42efb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777868
Auto-Submit: Carlos Caballero <carlscab@google.com>
Commit-Queue: Carlos Caballero <carlscab@google.com>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693067}

This CL converts DocumentInterfaceBroker{Ptr, Request} in content,
blink, extension and media to the new Mojo types and uses
pending_remote<blink.mojom.DocumentInterfaceBroker> in
document_scoped_interface_bundle.mojom and
pending_receiver<blink.mojom.DocumentInterfaceBroker> in
frame_messages.mojom.

Bug: 955171, 978694
Change-Id: Ic0ccabb445febbf8b2bd81aa754fc0abecfb77b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781900
Commit-Queue: Miyoung Shin <myid.shin@igalia.com>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693066}

This CL fixes a race-condition in CoverageView, and makes CSSModel
remember whether it was covering CSS data after suspension.


Bug: chromium:1000155
Change-Id: I5a454fbb10090e3f0bcdd69dd416336895a47b20
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781460
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693065}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/80aa9325dba3..dcb680fa3dff

git log 80aa9325dba3..dcb680fa3dff --date=short --no-merges --format='%ad %ae %s'
2019-09-04 vapier@chromium.org cros_run_unit_tests: sanity check --packages
2019-09-04 vapier@chromium.org cros_run_unit_tests: do not reraise final failure

Created with:
  gclient setdep -r src/third_party/chromite@dcb680fa3dff

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: Iea9bc366a8a97e0d6f1eb7c340a27e5c5557ef75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784381Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#693064}

This change is meant to provide extra information to debug
UNEXPECTED_JS_ERROR and UNEXPECTED_ERROR we get from time to time in
production.

Bug: b/139791239
Change-Id: I74b4d284a70e9a4082ce64b493f1fdd6c0a7488a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771910
Commit-Queue: Stephane Zermatten <szermatt@chromium.org>
Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693063}

blink::ImageLayerBridge::RegisteredBitmap declares now its move constructor and
assignment operator as noexcept with default implementation. This requires all its
parts to be move constructible and assignable. SharedBitmapIdRegistration was
missing noexcept declarations.

Bug: 819294
Change-Id: I1304e4666141355c61780d69d1669b5c49df4baf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768616Reviewed-by: enne <enne@chromium.org>
Commit-Queue: José Dapena Paz <jose.dapena@lge.com>
Cr-Commit-Position: refs/heads/master@{#693062}

Adds an option to show the total footprint of an allocator (one of malloc(),
partition_alloc and V8) in parse_smaps.py.

Example output:
$ tools/android/native_lib_memory/parse_smaps.py --pid 12803 \
  --show-allocator-footprint partition_alloc
[...]
Footprint from partition_alloc: 13648 kB

Bug: 998048
Change-Id: I9b9b062565e56188979c43380a411bca0f2db282
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781645
Commit-Queue: Benoit L <lizeb@chromium.org>
Reviewed-by: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693061}

Periodic reclaim is enabled by default, remove the feature. As a consequence,
remove the no-op DeprecatedReclaim() call, and its call site.

Bug: 942512
Change-Id: I916dfa1f1aee17bc3f3ac8a1de16ea2c1d987b0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782698Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693060}

Add a new VP8 accelerator that supports the upstream UAPI for VP8.

This is just a port of the legacy VP8 accelerator to use the upstream
headers and request API. It has not been thoroughly tested yet.

Bug: 965375
Test: None yet.

Change-Id: Ib06b2cc39a32beefa7314ae03d9ea15f8abc90f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761883
Commit-Queue: Alexandre Courbot <acourbot@chromium.org>
Auto-Submit: Alexandre Courbot <acourbot@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693059}

TBR=manucornet@chromium.org

Bug: 1000463
Change-Id: I99fbce482a66932c70d0af8dfb911f11bd7242ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782844Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693058}

The previous owners are no longer working at Google
and thus do not have access to UMA.

R=yangguo@chromium.org, bmeurer@chromium.org

Change-Id: I6b967c831d4ee6ea00de851e50087a5c6a3977c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777866Reviewed-by: Michael Hablich <hablich@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Auto-Submit: Michael Hablich <hablich@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693057}

Code pinning was an experiment, which is not supported on mainstream Android
platforms. Remove the code for it.

Bug: 929926
Change-Id: I5f0cbd8ba90e3c1b3eaa87850b41b16642257025
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781148Reviewed-by: Egor Pasko <pasko@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693056}

TBR=lanwei@chromium.org

Bug: 1000530
Change-Id: I87915513ddc6735bd383d5bd96d703cae79c65a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782842Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693055}

New ArcPictureInPicture flag set to enabled by default determines whether
picture-in-picture is enabled/disabled in ARC. Enabled does not
necessarily mean the feature is activated in ARC, but rather that if
the Android developer option setting is set to DEFAULT, then this flag
can determine whether the feature is activated or not.

Android CLs: ag/9303889 ag/9309348

allows PIP to run if "Default" is selected in developer options
--disable-features=ArcPictureInPicture in /etc/chrome_dev.conf disallows
PIP to run if "Default" is selected in developer options

Bug: 140200582
Test: --enable-features=ArcPictureInPicture in /etc/chrome_dev.conf
Change-Id: I84ffaf43baf750244f285b705f3ddfd8750b9431
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783805Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: Eliot Courtney <edcourtney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693054}

This CL changes the height of permission rows to match mocks.

Old view: https://bugs.chromium.org/p/chromium/issues/attachment?aid=409972&signed_aid=4Um3E86MJiRgjVynZpjLcQ==&inline=1
New view: https://bugs.chromium.org/p/chromium/issues/attachment?aid=409971&signed_aid=IzrDIjCWG_3pVKqgbk0Vxg==&inline=1

Bug: 999929
Change-Id: I8806bc2d585ea6e32e5081120ebe0cfa4461112b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784025
Auto-Submit: Jeevan Shikaram <jshikaram@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693053}

Scroll issue introduced CL:1636665, which replaced a call to
mergeItems() method in a base class to super, however the immediate
parent class |Grid| also has the mergeItems() method, which was
interfering with the scroll. This CL reverts back to call this method
from |List| base class.

Test: manually
Bug: 993068
Change-Id: I19d225dcc4277a409e824c7cac580c571ba1f051
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783690
Auto-Submit: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693052}

- If swiped over the peek threshold, fades to 50% opacity.
- If items to show in the navigation sheet <= 3,
  skip peek state and expand fully.

Bug: 991765, 991794
Change-Id: I64200e7405c51922c20d08c882036627148b5038
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778102Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693051}

A JavaScript URL can not be created with an empty string. Attempting to
do so will throw an exception, so check if the strings are non empty
first.

Additionally, postMessage can not be called with an empty string for the
targetOrigin parameter. If the iframe element does not have a src
attribute, use “*” instead to forward the context menu message to a
child frame.

Bug: 911899
Change-Id: I866bec11fa48c3a0ef5b95a6a628a64384d9da59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779423
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Auto-Submit: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693050}

With this change, callers have to write
new LoginDatabase(path, IsAccountStore(true))
instead of
new LoginDatabase(path, /*is_account_store=*/true)
which is clearer (no way to forget the comment), especially if any
other (boolean) parameters are added at any later point.

Bug: 998455
Change-Id: Ieb81b06ec86b628ecb2471a8be83b87b0807070e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782168Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693049}

Bug: 994291

Change-Id: I8b507abd244faa0058c575becf46aae7e6b3bb24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780837
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693048}