GitLab

+ Change omnibox/ntp search hint text color to 54% black
+ Change suggestion view list top and bottom padding to 8dp

BUG=723042

Review-Url: https://codereview.chromium.org/2930713002
Cr-Commit-Position: refs/heads/master@{#478833}

Revert of [Extensions Bindings] Avoid passing the event filter to JS (patchset #4 id:140001 of https://codereview.chromium.org/2924683002/ )

Reason for revert:
New test seems to be flaky on Mac...

https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.mac%2FMac10.9_Tests__dbg_%2F41569%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests%2F0%2Flogs%2FExtensionBindingsApiTest.EventOverriding%2F0

Original issue's description:
> [Extensions Bindings] Avoid passing the event filter to JS
>
> Currently, in JS bindings, we pass the event filter to JS, and then pass
> it back to C++ to find matching event listeners. This can cause problems
> because the object could be tweaked by monkey-patching, and we aren't
> correctly checking.
>
> Instead of updating the checks to safely interact with the object, just
> avoid passing it to JS altogether. Instead, pass the ids of the relevant
> listeners directly to JS. This avoids the security issue and is also
> more performant.
>
> Add a regression test.
>
> BUG=702946
>
> Review-Url: https://codereview.chromium.org/2924683002
> Cr-Commit-Position: refs/heads/master@{#478742}
> Committed: https://chromium.googlesource.com/chromium/src/+/229f3b010af25c9bc38c01cfc7c403d8b5fdecf0

TBR=jbroman@chromium.org,lazyboy@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=702946

Review-Url: https://codereview.chromium.org/2936673004
Cr-Commit-Position: refs/heads/master@{#478832}

Note there is a NavigatorContentUtilsClientMock.cpp so trying to merge the
definition and the Impl is not that interesting.

Bug: 712963
Change-Id: I6c1c8fb5ebc521b8748866483e8283ab408ace16
Reviewed-on: https://chromium-review.googlesource.com/531913Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478831}

This check asserts that the main frame's SecurityOrigin hasn't changed
between updating the plugin list and accessing the DOMPluginArray.

Bug: 731239
Change-Id: Ifa247045f1415d6b593fd18f626b1ddc37222aec
Reviewed-on: https://chromium-review.googlesource.com/531994Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Lucas Furukawa Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478830}

This CL extends the ResourceCoordinatorInterface to remove children.
the ResourceCoordinatorInterface has been updated, as well as the
CoordinationUnit, it's mojo interface definition, and unittests. A
few header issues were added based on a linter pass.

R=oysteine@chromium.org,nasko@chromium.org
BUG=724306

Review-Url: https://codereview.chromium.org/2929883002
Cr-Commit-Position: refs/heads/master@{#478829}

We've collected enough data to make the decision. Remove it to save
binary size.

Bug: 584616
Change-Id: I8edda0afdde749a56f6b47fd377ab37dda420afb
Reviewed-on: https://chromium-review.googlesource.com/530867Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478828}

BUG=none

Review-Url: https://codereview.chromium.org/2934923002
Cr-Commit-Position: refs/heads/master@{#478827}

This reverts commit 2be632d5.

Reason for revert: Upstream WPT failing linter. Will reland with lint erros fixed

Original change's description:
> Add web platform tests for ViewportAPI.
> 
> Bug: 635031
> Change-Id: If116b73922b27263fc5934f85939a95ad861ffd0
> Reviewed-on: https://chromium-review.googlesource.com/528374
> Commit-Queue: David Bokan <bokan@chromium.org>
> Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#478718}

TBR=bokan@chromium.org,dtapuska@chromium.org
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 635031

Change-Id: Iae9c03e0ee0f625e4e95ccf2f81d1b14d6b64c90
Reviewed-on: https://chromium-review.googlesource.com/532196Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478826}

Moves to use a promise instead of a callback for event emitable items.

R=dgozman
BUG=None

Change-Id: I1d4cd1084127d73d9ed96a9dddcef1e0d8a5fe7d
Reviewed-on: https://chromium-review.googlesource.com/527660
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478825}

BUG=731711

Review-Url: https://codereview.chromium.org/2928423003
Cr-Commit-Position: refs/heads/master@{#478824}

Now that FFmpeg is no longer configured to check for GSM containers, there
is no need to look for it in the FFmpeg context.

BUG=711774
TEST=media_unittests still pass (although there was no specific test for GSM)

Change-Id: I3d34010097be177554c31ac083341fbfee0a7cc9
Reviewed-on: https://chromium-review.googlesource.com/530164Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478823}

To adhere to Coding Guidelines for Cocoa, rename this method to
|webState:didPruneNavigationItemsWithCount:|.

Bug: 
Change-Id: Ibc07ab7012e1490b03e2e5ff814270ce4186ab11
Reviewed-on: https://chromium-review.googlesource.com/531464Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478822}

Bug: 707029, 706592
Change-Id: I08963922fd177c0023e9be1f6eb82491b4f33dcb
Reviewed-on: https://chromium-review.googlesource.com/531658Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478821}

Reland of Moves mojo_js_integration_tests into blink. (patchset #1 id:1 of https://codereview.chromium.org/2926143002/ )

Reason for revert:
Fixed failing tests.

Original issue's description:
> Revert of Moves mojo_js_integration_tests into blink. (patchset #11 id:190001 of https://codereview.chromium.org/2734783008/ )
>
> Reason for revert:
> Seems related to webkit failures of the JsToCpp tests. E.x. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.10/builds/34530.
>
> Original issue's description:
> > Moves mojo_js_integration_tests into blink.
> >
> > BUG=699569
> >
> > Review-Url: https://codereview.chromium.org/2734783008
> > Cr-Commit-Position: refs/heads/master@{#477549}
> > Committed: https://chromium.googlesource.com/chromium/src/+/dd57fa764813de09d159a232eeef1bb21b0ccc1e
>
> TBR=jbroman@chromium.org,dpranke@chromium.org,yzshen@chromium.org,alokp@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=699569
>
> Review-Url: https://codereview.chromium.org/2926143002
> Cr-Commit-Position: refs/heads/master@{#477653}
> Committed: https://chromium.googlesource.com/chromium/src/+/6536a56d25c245bd109e32ed49240bfc04f8890f

TBR=jbroman@chromium.org,dpranke@chromium.org,yzshen@chromium.org,jwd@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=699569

Review-Url: https://codereview.chromium.org/2920383004
Cr-Commit-Position: refs/heads/master@{#478820}

Header files should be listed in the sources list, so gn analyze
can work.

https://docs.google.com/spreadsheets/d/15az3FMl-jAS0mx4E9XVSBVHVpmEzo-9EAGY0ywe7bZs/edit#gid=0

https://groups.google.com/a/chromium.org/d/topic/chromium-dev/1kK45mVemBc/discussion

BUG=661774
TBR=jamescook@chromium.org

Change-Id: I68020668044858be898ce6d18392ee8610cf22f4
Reviewed-on: https://chromium-review.googlesource.com/531030
Commit-Queue: Thiago Farina <tfarina@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478819}

This patch removes orientation() and scroll_element_id() from
ScrollbarLayerInterface as these are not used. The corresponding
getters/setters on ScrollbarLayerImplBase are needed but the Layer
interface is only used to pass these values along.

BUG: 723263
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I4631dc469b1f6776f3e6d4246bed39d94316822f
Reviewed-on: https://chromium-review.googlesource.com/530490Reviewed-by: Chris harrelson <chrishtr@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478818}

This hooks up the ozone code so it can deal with --use-gl=swiftshader
flag correctly.

BUG=704285
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2926423002
Cr-Commit-Position: refs/heads/master@{#478817}

BUG=644725

Change-Id: I37cefb2eedbf8d1771413eb0b5f70370ed7de9dd
Reviewed-on: https://chromium-review.googlesource.com/531671Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478816}

R=xiyuan@chromium.org
BUG=730037
TEST=tested that enabling the new launcher with
--enable-features=EnableFullscreenAppList, search box will show "Search
your Chromebook, apps, web..." hint text; disabling the flag falls to
current behavior.

Review-Url: https://codereview.chromium.org/2934883002
Cr-Commit-Position: refs/heads/master@{#478815}

Walk up the layer tree from a layer that needs an
AncestorChildClippingMaskLayer to find all border radius clips to
apply. Several auxiliary changes were required. The code in CLM for
determining if a mask layer is needed has also been reworked to
test against all clips.

Make LayerClipRecorder::CollectRoundedRectClips a public static member
so that CLM can use it to determine if the mask layer is required. Also
expand the conditions in which LayerClipRecorder uses the method to
catch all cases where masks need rounded clips.

Make several PaintLayer methods const, because they can be and we need
them so.

New tests for various cases of border radius where not just the parent
layer needs checking, or where we need to skip over the parent layer and
still check.

R=chrishtr@chromium.org
BUG=672561
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2923683002
Cr-Commit-Position: refs/heads/master@{#478814}

The optimization reduces the cost of the invocation path from
ObjectPaintInvalidator to CC layer for rectangles covered by
parent objects. However, the optimization is not applicable to
SPv2 causing some text-based-repaint tests producing different
results.

To reduce differences, for SPv1, still track the optimized rectangle
but the rectangle won't affect any other functionality including
raster-under-invalidation checking.

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I8642470dd8058dcde25ae6b5392c6ed572ba405f
Reviewed-on: https://chromium-review.googlesource.com/529525
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Chris harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478813}

Background: the original client-based preview fallback support that
existed in RenderFrameImpl::SendDidCommitProvisionalLoad for main
frame responses was removed in CL 2856223008. This CL now adds fallback
support back in at the same call site but introduces a helper method
to better isolate the (now more complicated) logic with unittests.

This CL also adds integration tests that cover ECT header test coverage requested in bug 691135.

BUG=701802,691135

Review-Url: https://codereview.chromium.org/2910783002
Cr-Commit-Position: refs/heads/master@{#478812}

Change-Id: I5f27a3208aa76435c126ce7b1f041d5739fd64d6
Reviewed-on: https://chromium-review.googlesource.com/530037
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478811}

(Client side malware detection is already enabled on https).

BUG=730895

Review-Url: https://codereview.chromium.org/2927123004
Cr-Commit-Position: refs/heads/master@{#478810}

This is a follow-up https://codereview.chromium.org/2883143003 that
brings back tracking of timelines started with page reload (the meaning
of which is somewhat different now).

Change-Id: I8cde7aba72290dd99b42ddb36d2b1f3a989d0a9c
Reviewed-on: https://chromium-review.googlesource.com/531875Reviewed-by: Alexei Filippov <alph@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478809}

This change adds another variation to the swipe logic experiment;
enabling swipe on the expand button. This change also generalizes the
allowed swipe range to work with or without the experiments enabled.

- "restrict-area" will only work if there is no expand button.
- "button-only" will only work if the expand button is enabled.

BUG=731288

Change-Id: I04f7479c91827bb0bc1019d0e86c7b75588c7c00
Reviewed-on: https://chromium-review.googlesource.com/530094
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478808}

Remove windows-specific baselines, since they now match all other platforms.

BUG=731153
TBR=qyearsley

Review-Url: https://codereview.chromium.org/2940433002
Cr-Commit-Position: refs/heads/master@{#478807}

BUG=732060

Review-Url: https://codereview.chromium.org/2933893002
Cr-Commit-Position: refs/heads/master@{#478806}

On most platforms, right-clicking a misspelled word only selects it and shows
suggestions in the context menu if you right-clik in the interior of the word.
In https://codereview.chromium.org/2925363002, I modified some of the spellcheck
code (specifically, the method that replaces the misspelled word) to support the
case where we have a caret selection immediately before or after a word, since
tapping at a word boundary should open the spellcheck menu on Android (this
feature is still in progress, but this is the behavior for a native EditText
widget, so we're trying to match it.)

This CL adds a test case to verify we don't accidentally change the behavior for
other platforms.

BUG=715365

Review-Url: https://codereview.chromium.org/2932123002
Cr-Commit-Position: refs/heads/master@{#478805}

This behavior is no longer supported.

BUG=731922

Review-Url: https://codereview.chromium.org/2934663002
Cr-Commit-Position: refs/heads/master@{#478804}

BUG=672489

Review-Url: https://codereview.chromium.org/2931323002
Cr-Commit-Position: refs/heads/master@{#478803}

Currently only being used on FontCache, to be used on other Font-related
classes.

Bug: 730692
Change-Id: I58f66d6cf59dca83be5133fc273136ce408e5b2e
Reviewed-on: https://chromium-review.googlesource.com/531753
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478802}

BUG=729197
TBR=groby@chromium.org

Review-Url: https://codereview.chromium.org/2927193002
Cr-Commit-Position: refs/heads/master@{#478801}

BUG=661774

Review-Url: https://codereview.chromium.org/2936433002
Cr-Commit-Position: refs/heads/master@{#478800}

BUG=none

Change-Id: Ic4359354e152c4af266554252a3728af1efd0e02
Reviewed-on: https://chromium-review.googlesource.com/529584
Commit-Queue: David Benjamin <davidben@chromium.org>
Reviewed-by: Steven Valdez <svaldez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478799}

Use RepeatingCallback for BindingSet connection error handlers because
the error handlers can be called for each entry in the set.

BUG=NONE
TEST=mojo_public_bindings_unittests

Review-Url: https://codereview.chromium.org/2932193002
Cr-Commit-Position: refs/heads/master@{#478798}

Screenshot of the change in the bug.

Since the entry response time is given as an internal UTC format, I added wrapper methods to Time.h to convert it to standard UTC format.

BUG=727922

Review-Url: https://codereview.chromium.org/2928833002
Cr-Commit-Position: refs/heads/master@{#478797}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/7ba431f75da5..e663166b9cf3

$ git log 7ba431f75..e663166b9 --date=short --no-merges --format='%ad %ae %s'
2017-06-12 benjhayden Fix histogram-span for Histograms with a single sample with diagnostics.
2017-06-12 charliea Move myself to tracing/ OWNERS emeriti
2017-06-12 phsilva Remove left-over file from story runner unittests
2017-06-12 xunjieli Add initial web-page-replay-go code
2017-06-12 benjhayden Replace some single quotes in value/ui/ with double-quotes for consistency.
2017-06-12 benjhayden Add instantiation tests for date-range-span.
2017-06-12 charliea Stops the BattOr shell after receiving an invalid git hash
2017-06-12 kraynov Android systrace: Graphics memory reporting in atrace_helper.
2017-06-12 simonhatch Telemetry - Generate TagMap diagnostic in benchmark and attach to results.
2017-06-12 benjhayden Fix polymer_postload in tracing/ui.

Created with:
  roll-dep src/third_party/catapult


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I38b0071240ac342bf1da9d5cf5d6f2855f9cbb3b
Reviewed-on: https://chromium-review.googlesource.com/531784
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478796}

If the bottom_sheet_snackbar_container is the last view in the
coordinator layout, the margin property is not respected. This change
moves the empty_container_stub to be the last item since order for
this item is not particularly important.

BUG=732222

Change-Id: I5eb506cf0da38a252f579b4d2d11d82794b6b71d
Reviewed-on: https://chromium-review.googlesource.com/531803Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478795}

DirectCompositionSurfaceWin remains as the host of the DCLayerTree,
while DirectCompositionChildSurfaceWin handles drawing to the
IDCompositionSurface itself. This will allow us to have more Surfaces
in the layer tree in the future.

BUG=726957
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2926763002
Cr-Commit-Position: refs/heads/master@{#478794}