GitLab

Some links open a new tab while navigating, given that we redirect some
of the traffic to ARC, it can be necessary to close any unused tab.

Since we are closing the contained WebContents on a tab, we need to make
sure the callback within the UI doesn't get called twice, since intent
picker has an observer for the WebContents.

BUG=647806
TEST=manual test

Review-Url: https://codereview.chromium.org/2347273002
Cr-Commit-Position: refs/heads/master@{#419335}

Revert of Add a broken page to dummy_benchmark.noisy_benchmark_1 (patchset #1 id:1 of https://codereview.chromium.org/2334323003/ )

Reason for revert:
Reverting the changes to as we have enough revisions to perform bisect FYI jobs

Original issue's description:
> Add a broken page to dummy_benchmark.noisy_benchmark_1
>
> *PERF SHERRIF: this CL intentionally breaks dummy_benchmark.noisy_benchmark_1
> for intergration testing purpose.
>
> BUG=646628
> NOTRY=true
>
> Committed: https://crrev.com/522a347da44b43e8bbf58ad29e246dc3dab3872c
> Cr-Commit-Position: refs/heads/master@{#418971}

TBR=nednguyen@google.com,sullivan@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=646628

Review-Url: https://codereview.chromium.org/2345393002
Cr-Commit-Position: refs/heads/master@{#419334}

Enables support on non-ANGLE desktop platforms (Mac/Linux) and GLES platforms supporting NV_sRGB_formats (Tegra).

This is tested by WebGL conformance test
conformance/extensions/webgl-compressed-texture-s3tc-srgb.html

BUG=630498
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=haraken@chromium.org

Review-Url: https://codereview.chromium.org/2337833002
Cr-Commit-Position: refs/heads/master@{#419333}

BUG=None
TEST=None
R=sbc@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk;master.tryserver.chromium.win:win_nacl_sdk
BUG=646185

Review-Url: https://codereview.chromium.org/2342353003
Cr-Commit-Position: refs/heads/master@{#419332}

This CL changes the ripple to trigger on mouse down rather than mouse
up. This better matches other uses of paper-ripple.

BUG=645190
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2341593002
Cr-Commit-Position: refs/heads/master@{#419331}

This CL moves the circle/dot part of the toggle button slightly. It also adjusts the shadow and translation. These
adjustments are needed for the compact toggle button.

BUG=646003
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2344083002
Cr-Commit-Position: refs/heads/master@{#419330}

Passes an IPC::Channel* to OnFilterAdded instead of IPC::Sender*.

This is changing so that filters can use more than just
the Sender interface of the Channel, and namely so they can get at
remote associated interfaces.

BUG=612500
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2349713003
Cr-Commit-Position: refs/heads/master@{#419329}

Adds no-op APIs to cache navigation info for custom tabs like
url, title and content screenshot and send them via a callback
to the client app.

BUG=647342

Review-Url: https://codereview.chromium.org/2348573002
Cr-Commit-Position: refs/heads/master@{#419328}

Currently, HTTP/1.0 requests are causing http_server.cc to crash.
Code shouldn't crash when it is supplied with bad data. Simply
move into an error state and close the connection instead.

BUG=

Review-Url: https://codereview.chromium.org/2314073003
Cr-Commit-Position: refs/heads/master@{#419327}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/1a9a50a459c9e3c081719d3e835cac213c319136 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
depot_tools:
  https://crrev.com/7e16cf303221bbcf81d632924e19ddc888da9c3b owners.py: partial fix for owners-check perf regression (nick@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=642793

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2349733004
Cr-Commit-Position: refs/heads/master@{#419326}

https://docs.google.com/document/d/1IZ7HtM0BZlMgNyYo6AUHGL84k
RTnH4qt3fd-hXqfjvs/edit#

Review-Url: https://codereview.chromium.org/2339093003
Cr-Commit-Position: refs/heads/master@{#419325}

Xcode 8 should be installed upstream already, so in order to land
changes than use iOS10 SDK we need to update the bots.

BUG=none

Review-Url: https://codereview.chromium.org/2347943002
Cr-Commit-Position: refs/heads/master@{#419324}

This size was incorrectly reduced in commit
8cbe5d69.

This commit also adds DVLOG()s to most methods. These should
have been there from the beginning.

BUG=647723

Review-Url: https://codereview.chromium.org/2345633006
Cr-Commit-Position: refs/heads/master@{#419323}

This CL makes most SequencedWorkerPoolTest a TestWithParam. The parameter
controls whether redirection to TaskScheduler is enabled.

BUG=622400

Review-Url: https://codereview.chromium.org/2285633003
Cr-Commit-Position: refs/heads/master@{#419322}

Revert of Update MB to use `gn analyze`. (patchset #9 id:160001 of https://codereview.chromium.org/2298403002/ )

Reason for revert:
Need to add "aura_builder", probably others ...

Original issue's description:
> Update MB to use `gn analyze`.
>
> Now that GN supports a form of `analyze` directly, this patch
> updates //tools/mb to use it rather than working awkwardly through
> `gn refs`. The MB implementation now is mostly responsible for
> mapping ninja targets to labels, calling GN, and then mapping returned
> labels back to ninja targets. Eventually we should update the
> recipes to just pass labels around instead.
>
> One significant change is that now we need entries in gn_isolate_map.pyl
> for every target listed in 'additional_compile_targets' and
> 'isolated_scripts' as well as in 'gtest_tests', because we have to remap
> everything to the GN labels, not just tests for swarming.
>
> We should switch everything to using GN labels directly, but that'll require
> follow-on CLs.
>
> R=brettw@chromium.org
> BUG=555273
>
> Committed: https://crrev.com/9aba8b21177df3ed3e897d5c500d845fbf5523e6
> Cr-Commit-Position: refs/heads/master@{#419315}

TBR=phajdan.jr@chromium.org,brettw@chromium.org,kbr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=555273

Review-Url: https://codereview.chromium.org/2341403004
Cr-Commit-Position: refs/heads/master@{#419321}

BUG=555865

Review-Url: https://codereview.chromium.org/2341393002
Cr-Commit-Position: refs/heads/master@{#419320}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/07a33586eff8451bbc84366055c3cfa36e7b6fea Roll recipe dependencies (nontrivial). (recipe-roller@chromium.org)
  https://crrev.com/79d8d758281609aa49b9b9af7e18cc187c2ee814 Disable CompilerInfoCache for a while (shinyak@chromium.org)
  https://crrev.com/a8f07009101d46553ea5d4bce1353ecb365dd3a5 Revert "Roll recipe dependencies (nontrivial)." (tandrii@chromium.org)
  https://crrev.com/cbca79967afa4f28df6b0ede337db6138eeb167b Add asan=1 to GYP_DEFINES for Dart asan builds (whesse@google.com)
  https://crrev.com/25b922d8edc1927c3af4bb4a8f7db6434096dca0 WebRTC: Disable iOS API Framework Builder. (ehmaldonado@chromium.org)
  https://crrev.com/769dbabae3b7ff11023dd1b393fcd2a12e165c65 Make sure goma_ctl is running during wasm_llvm build (sbc@chromium.org)
  https://crrev.com/2e89429885f7c2503565cb12d564d0f6f58a42f1 Fix Webkit capitalization for N CTS tests. (mikecase@chromium.org)
  https://crrev.com/e549894cc4f86f3f2107e3686d561ff83331a267 crashpad/continuous: Use bot_update. (dnj@chromium.org)
  https://crrev.com/f74386f7e19ff3f32693d222262d1a3ee79799ef Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
depot_tools:
  https://crrev.com/972ac5040176acd90c8a1ce412f75d19f77cc4e8 bot_update: ensure correct depot_tools checkout is used. (tandrii@chromium.org)
  https://crrev.com/15a248123d9032061486cd2d4b3f64369c93a9a5 Revert of bot_update: ensure correct depot_tools checkout is used. (patchset #2 id:20001 of https://codereview.chromium.org/2346973003/ ) (tandrii@chromium.org)
  https://crrev.com/7f245d07b2282f9847072fccddf7162a7e632a2d Bump git-on-windows bleeding edge version to 2.10.0. (vadimsh@chromium.org)
  https://crrev.com/6ac12ffd596e338c43e25dc3889e8ac552c2e885 Make bot_update.py print git version it uses. (vadimsh@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=635641,chromium:647812,webrtc:6372,647446

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2343293002
Cr-Commit-Position: refs/heads/master@{#419319}

Shares some of the build rules from ChromeVox, but with no extension tests or
Closure compilation rules yet. We can add those later as needed.

If you run Chrome with the --enable-experimental-accessibility-features
flag, then toggling the Select-to-speak checkbox in the accessibility
preferences loads or unloads this component extension, as verified by the
presence of the (empty) background script in chrome://inspect

BUG=593887
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
TBR=rdevlin.cronin

Review-Url: https://codereview.chromium.org/2216433004
Cr-Commit-Position: refs/heads/master@{#419318}

https://chromium.googlesource.com/skia.git/+log/b6318bf44dd8..67ac33e1f1a1

$ git log b6318bf44..67ac33e1f --date=short --no-merges --format='%ad %ae %s'
2016-09-16 bungeman Remove SK_DECLARE_LEGACY_CREATE_FROM_FONTDATA.
2016-09-16 msarett Fix filling of incomplete images in SkSampledCodec
2016-09-16 halcanary SkPDF:  Implement /ActualText to make text extraction correct.
2016-09-16 mtklein format GN files, and invert if->config to config->if
2016-09-16 tomhudson Improve ColorStopOptimizer safety

BUG=647481

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=djsollen@google.com

Review-Url: https://codereview.chromium.org/2348003002
Cr-Commit-Position: refs/heads/master@{#419317}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/57bf8bed..485e2dcf

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2348823003
Cr-Commit-Position: refs/heads/master@{#419316}

Now that GN supports a form of `analyze` directly, this patch
updates //tools/mb to use it rather than working awkwardly through
`gn refs`. The MB implementation now is mostly responsible for
mapping ninja targets to labels, calling GN, and then mapping returned
labels back to ninja targets. Eventually we should update the
recipes to just pass labels around instead.

One significant change is that now we need entries in gn_isolate_map.pyl
for every target listed in 'additional_compile_targets' and
'isolated_scripts' as well as in 'gtest_tests', because we have to remap
everything to the GN labels, not just tests for swarming.

We should switch everything to using GN labels directly, but that'll require
follow-on CLs.

R=brettw@chromium.org
BUG=555273

Review-Url: https://codereview.chromium.org/2298403002
Cr-Commit-Position: refs/heads/master@{#419315}

BUG=647049

Review-Url: https://codereview.chromium.org/2333333004
Cr-Commit-Position: refs/heads/master@{#419314}

On Mac OS X, the accessible name of an object can be exposed in three
different ways:

AXTitle: for visible text
AXDescription: for accessible text (like image "alt" or aria-label)
AXTitleUIElement: for controls labeled by another element

VoiceOver is kind of picky, it only wants us to expose just one of the
three, not multiple ones, but to be more confusing it ignores
AXTitleUIElement if it's not a control.

The bug here was that there was an obscure case where a checkbox's
name came from a label, but the label's text was "hidden" by a
heuristic that tries to combine the checkbox and its text into a
single element for simplicity. All of that is fine, but we were
exposing AXTitleUIElement for the checkbox when the element it
pointed to had empty text.

The fix is just to make sure the element pointed to by
AXTitleUIElement actually has text, otherwise we fall back on
AXTitle.

BUG=646846

Review-Url: https://codereview.chromium.org/2348663002
Cr-Commit-Position: refs/heads/master@{#419313}

BUG=647712

Review-Url: https://codereview.chromium.org/2345673005
Cr-Commit-Position: refs/heads/master@{#419312}

This fixes the main remaining assertion in legacy/ng interop.

BUG=635619
R=eae@chromium.org,ikilpatrick@chromium.org,glebl@chromium.org

Review-Url: https://codereview.chromium.org/2347283002
Cr-Commit-Position: refs/heads/master@{#419311}

This will make it easier to add a content/ directory to the previews
component later.

BUG=

Review-Url: https://codereview.chromium.org/2333003002
Cr-Commit-Position: refs/heads/master@{#419310}

1) This will set a writing mode to the fragment builder so it can be used at the time when we calculate a physical fragment.
2) Change computeMargin to accept 2 more parameters: Direction and writing mode.

TEST=NGBlockLayoutAlgorithmTest.LayoutBlockChildrenWithWritingMode
BUG=635619

Review-Url: https://codereview.chromium.org/2347773002
Cr-Commit-Position: refs/heads/master@{#419309}

Reset |oobe_ui_| in ShowLoginScreen is legacy code back when there
are separate OobeDisplay and LoginDisplay. OobeDisplay is no longer
needed when login screen is shown. This has changed as there is
only one LoginDisplay and |oobe_ui_| is used for both OOBE and login.
And it should not change during the lifetime of WizardController.

BUG=647742

Review-Url: https://codereview.chromium.org/2341613006
Cr-Commit-Position: refs/heads/master@{#419308}

Slightly increase some thresholds for tests that were failing on OSX
10.11.

TBR=hongchan@chromium.org
BUG=626449
TEST=constructor/periodicwave.html

Review-Url: https://codereview.chromium.org/2345913004
Cr-Commit-Position: refs/heads/master@{#419307}

This change clears the recorded event cache in the
OverlayPanelEventFilter when it does not consume a touch event. This
should prevent beginning event streams with something other than
ACTION_DOWN.

BUG=613069

Review-Url: https://codereview.chromium.org/2342223002
Cr-Commit-Position: refs/heads/master@{#419306}

BUG=607690

Review-Url: https://codereview.chromium.org/2331053002
Cr-Commit-Position: refs/heads/master@{#419305}

BUG=594160

Review-Url: https://codereview.chromium.org/2345873002
Cr-Commit-Position: refs/heads/master@{#419304}

ArcWallpaperService now observes wallpaper change
and notifies Android, which will use it to broadcast
ACTION_WALLPAPER_CHANGED.

Test=Change wallpaper with CrOS wallpaper picker
  and verify with Android app that listens wallpaper
  changed broadcast.

Bug=642465

Review-Url: https://codereview.chromium.org/2345153002
Cr-Commit-Position: refs/heads/master@{#419303}

BUG=647480
TEST=manual

Review-Url: https://codereview.chromium.org/2340933004
Cr-Commit-Position: refs/heads/master@{#419302}

Hide developer accelerators behind --ash-developer-shortcuts command line
switch.

BUG=642945,642551

Review-Url: https://codereview.chromium.org/2323863002
Cr-Commit-Position: refs/heads/master@{#419301}

These are not ready to be exposed as API yet, as the structure and types
of errors is still being adjusted.

They aren't needed for testing either, since it is using text
comparisons.

BUG=634443

Review-Url: https://codereview.chromium.org/2342973003
Cr-Commit-Position: refs/heads/master@{#419300}

Rename DownloadItemViewMd to DownloadItemView.
Remove a whole bunch of unused assets. Huzzah!

BUG=none

Review-Url: https://codereview.chromium.org/2346043002
Cr-Commit-Position: refs/heads/master@{#419299}

This cl adds very basic tests for general trace wrappers features. And enables TraceWrappables runtime enabled feature for tests!

LOG=no
BUG=468240

Review-Url: https://codereview.chromium.org/2301213003
Cr-Commit-Position: refs/heads/master@{#419298}

BUG=555865

Review-Url: https://codereview.chromium.org/2344273002
Cr-Commit-Position: refs/heads/master@{#419297}

The "!!" trick is applied to domAutomationController.send instead
of the expression. This could cause DomAutomationController to drop
result of a non-boolean expression. As a result, ExpectTrue etc times
out.

BUG=
TEST=JsChecker::ExpectTrue with non-boolean expression should not time out.

Review-Url: https://codereview.chromium.org/2347013002
Cr-Commit-Position: refs/heads/master@{#419296}