- 19 Nov, 2020 40 commits
-
-
Nicholas Verne authored
In most cases we remove the (Beta). Otherwise we replace with "Linux development environment". Bug: 1140370 Change-Id: I156ca81b989d3f50f8119f62c8f4a89c6362a383 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508102 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
David Munro <davidmunro@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#829176}
-
Przemek Pietrzkiewicz authored
This patch: - fixes a comment which I think meant kCloneAll where it says kEmpty - makes the single arg constructor explicit Bug: None Change-Id: Id0fb554a3caf06cb2d655fb06a8307cfedc2595a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547302Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Przemek Pietrzkiewicz <ppi@chromium.org> Cr-Commit-Position: refs/heads/master@{#829175}
-
Ryo Hashimoto authored
BUG=b:171408795 TEST=Launch Play Store Change-Id: I9bff72a850d74bfb226f14ca3a90afca325ad29e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540047 Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#829174}
-
Jaeyong Bae authored
This patch changes the code to return empty string for CSSStyleDeclaration.cssText. Discussion at: https://github.com/w3c/csswg-drafts/issues/1033 Makes tests pass: external/wpt/css/cssom/cssstyledeclaration-csstext.html Bug: 1146888 Change-Id: Ibca415b7606d2cc5110ca633c87a77fac3e74ca8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546305Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com> Cr-Commit-Position: refs/heads/master@{#829173}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3a578ae35233..16973d613fed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I49d18b5d093ddbae00b8f0c2c19b3b9db2d8bd45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549841Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829172}
-
Joe DeBlasio authored
This CL updates the field trial testing config to match the final stage of the MIX-DL rollout on both android and desktop platforms. Strictly speaking, we'll briefly hit a slightly different configuration in Android first, but this is the configuration that is higher risk, the equivalent config has been tested on Desktop, and the configurations don't change the code paths exercised by the field trial testing anyway. Bug: 960819 Change-Id: I251ba5c20a30ab6532d48a22e8e6ed8eb0fee1d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548310 Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#829171}
-
Moe Ahmadi authored
Canary experiment: cl/339288320 Beta experiment: cl/342939379 Bug: 1136654, 1136649 Change-Id: I447848638b80bf645de919b62ac14a5d499a55c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547920 Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
Rohit Agarwal authored
This CL removes the deprecated method and update the call site to use the overload WebContentsFactory#createWebContents on profile instead. Bug: 1149861 Change-Id: Id5ed7b30646bbd520127280daeae342eb02eff42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543351 Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#829169}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/1f2fcddd3963..671914c28e82 2020-11-18 greg@lunarg.com Fix buffer oob instrumentation for matrix refs (#4025) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cnorthrop@google.com,kainino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,cnorthrop@google.com,kainino@google.com Change-Id: I4c7e2d7d054f22e1395a3e4052f3a059d3000478 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549461Reviewed-by:
-
anina koehler authored
This cl removes the mapping between extension ID and window title for the login-screen extension and uses the existing behavior feature instead. Bug: 1145126 Change-Id: I86bef81b140f5b9aa51fa9a87d8053e85d2ff7d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527024 Commit-Queue: Anina Koehler <aninak@google.com> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#829167}
-
arthursonzogni authored
Fix https://crbug.com/1147567 and add a regression test. This is meant to be merged back into M88 beta. No new navigations should start in a non current frame. There is a DCHECK and a DumpWithoutCrashing. It was triggered in M88. What happened: - Start with nested documents: A(B(C)). - C adds a beforeunload handler. - B starts a navigation, waiting for C. - The WebContents is closed, deleting C, then B, and then A. By deleting C, the navigations in B can begin, but this happen in the middle of destructing B. This is fixed by putting the code responsible for continuing the navigation in a new task. This is indeed the current behavior for the second part of the "if" already. This patch just generalize it to both clauses. A lot of things can be done to improve the architecture here, but this patch is meant to be merged into M88, so it should stay short to minimize the change. Bug: 1147567 Fixed: 1147567 Change-Id: I980c7da56b9f02b2644ebcb9a9401637848d9c34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544967Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#829166}
-
Andres Olivares authored
crrev.com/c/2536371 disables a layout test on DevTools console to allow for a change on DevTools' public API to roll. Since the change has been rolled already, this enables the test again and updates it to the new API. Bug: chromium:1011811 Change-Id: I092b4aa82e90fa0926eb9de9b24b028e13156847 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547304 Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Auto-Submit: Andres Olivares <andoli@chromium.org> Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#829165}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2d31db0b3751..3a578ae35233 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ia28c06486037dec00458a8e50dc283d468349661 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548358Reviewed-by:
-
Shubham Aggarwal authored
Migrate uses of the relevant set_* functions on the sql::Database object to use the new DatabaseOptions constructor instead. This change should have no intended behavioral effect. Bug: 1126968 Change-Id: Iaafca49a4b5440fce538d6918a0f136074ff9c43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548276Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#829163}
-
Aya ElAttar authored
- Changed the toasts shown for clipboard blocked pastes to bubbles according to the new mocks. - Moved all the clipboard notifications related functions to dlp_clipboard_notification_helper.h/.cc Bug: 1148224, 1131670 Change-Id: I69a99b1a99d08cbc6ea47852d3ce6a3a7fdace66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532564 Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Reviewed-by:
Aya Elsayed <ayaelattar@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#829162}
-
Pavol Marko authored
Adds a chrome Feature to disable closing idle sockets on memory pressure. This only applies to Profile NetworkContexts. Bug: 1150526 Test: new browser test Change-Id: I0e4f18d8faa4f365bdd7dc404003e147ca47aa8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547723Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#829161}
-
Rakina Zata Amni authored
NavigationRequest::CreateForCommit currently only needs a few parts of DidCommitProvisionalLoad_Params to create a NavigationRequest. To aid our removal of DidCommitProvisionalLoad_Params, we should make clear which ones we actually need. This CL also removes some dependencies that we don't actually need (e.g. method), and kills renderers that try to send a non-initial-commit about:blank navigation that the browser doesn't know about (the browser doesn't have a NavigationRequest for that navigation). For more context: - navigation-dev thread: https://groups.google.com/a/chromium.org/g/navigation-dev/c/8BsDvk-1gCU/m/-lrIxA1wCAAJ - NavigationRequest creation at DidCommit cases: https://docs.google.com/document/d/1UjdxiDJ3sgVDbp0CZpsSntdwAYNMSfc2qajX4nzXfLY/edit - DidCommit params removal plan: https://docs.google.com/document/d/18FeFEnfH_hTeGH7b_qkIto8pGtxdU54msnPlWo-qldA/edit Bug: 131832, 1133115 Change-Id: If23861e2473c5d7968859fc701f40f34f0248e93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475093 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#829160}
-
Joel Hockey authored
Not all paths in a VM can be mapped to a path in the host. Paths in crostini homedir and /mnt/chromeos are fine. E.g. /mnt/chromeos/MyFiles/file => <cyrptohome>/MyFiles/file. But /etc/mime.types is not accessible to the host and cannot be mapped to a valid host path, so we will map it as 'vmfile:termina:/etc/mime.types'. If the drop target is the crostini container, we will do the reverse mapping and provide file:///etc/mime.types, but if we fail to do the reverse mapping for the drop target (e.g. drop target is arc or Plugin VM), we will clear the path from the drop data. Since chrome accesses OSExchangeData directly without allowing exo to do any reverse mapping, chrome will attempt to use a path such as file:///vmfile:termina:/etc/mime.types which is intended to fail. Bug: 1144138 Bug: 1146319 Change-Id: I91c62b5183f054311cba2ef474dda0f12766db83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546677Reviewed-by:
Jason Lin <lxj@google.com> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#829159}
-
Morten Stenshorne authored
https://chromium-review.googlesource.com/c/chromium/src/+/2523426 adds things to third_party/eigen3 , not third_party/eigen, so this was most likely a typo. Bug: 1121333 Change-Id: I2cd34e88026142df479d7573dbf63cecf8f0d501 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549301Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#829158}
-
Fredrik Söderqvist authored
This abstracts away most of the accesses to the Page object, reducing the amount of boilerplate a bit. It'll also make it easier to transition away from the current Page/Document setup to allow sharing some code with SVG resource documents. Also add a LayoutRoot() for additional simplification. Bug: 109212 Change-Id: I7db0e29cbe28cc31c1f1df0546a3266abf6141e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544970Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#829157}
-
Mihai Sardarescu authored
The Gaia ID present in the CHROME_CONNECTED is only used for Google Drive and Docs to auto-enable offline mode. However this feature is not available on Chrome iOS, so we should stop including the Gaia ID in the CHROME_CONNECTED cookie. Bug: 1149943 Change-Id: Iffdbff19a43180922e2a184879a2922ed0d731e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543152 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#829156}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a06769a8ea10..a3d1e7c68c67 2020-11-19 bmeurer@chromium.org [ts] Typecheck extensions/LanguageExtensionEndPoint.js with TypeScript 2020-11-19 szuend@chromium.org TypeScript-ify ui/TextPrompt.js 2020-11-19 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I467777a00e436f585356d3346e1826f8742fd0c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549421Reviewed-by:
-
Mike West authored
This reverts commit 074c395f. Reason for revert: This patch landed in https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/21376, where three ~related `browser_test` items began failing consistently: * SystemFeaturesPolicyTest.DisableCameraAfterInstall * SystemFeaturesPolicyTest.DisableCameraBeforeInstall * ExtensionPolicyTest.ExtensionInstallBlocklistComponentApps These failures are really verbose, but it looks like the core is: ``` ../../chrome/browser/policy/extension_policy_browsertest.cc:401: Failure Value of: registry->enabled_extensions().GetByID(extension_misc::kCameraAppId) Actual: false Expected: true ``` Original change's description: > Reland "[CCA] Run CCA as SWA by default" > > This reverts commit 5dec0310. > > Reason for revert: LKGM update: crbug.com/1148527 > > Original change's description: > > Revert "[CCA] Run CCA as SWA by default" > > > > This reverts commit 46b6fd15. > > > > Reason for revert: > > > > camera.CCAUISmoke.fake is failing on chromeos-eve-chrome and camera.CCAUI* is listed as test coverage for this CL, so I am speculating that it is the cause. See: > > https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-chrome/11136 > > > > Original change's description: > > > [CCA] Run CCA as SWA by default > > > > > > Bug: b/172345161 > > > Test: tast run [DUT] camera.CCAUI* > > > Change-Id: I10484c9263f3e4c560028aef272cd3db88c47b31 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509834 > > > Commit-Queue: Wei Lee <wtlee@chromium.org> > > > Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> > > > Auto-Submit: Wei Lee <wtlee@chromium.org> > > > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#825657} > > > > TBR=ortuno@chromium.org,wtlee@chromium.org > > > > Change-Id: I5464fbcd7f1a03cd157122ad66c6ee13ad111630 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: b/172345161 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529360 > > Reviewed-by: Henrik Boström <hbos@chromium.org> > > Commit-Queue: Henrik Boström <hbos@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#825818} > > TBR=hbos@chromium.org,ortuno@chromium.org,wtlee@chromium.org > > Bug: b/172345161 > Change-Id: Ie6d18656a2b247d8eec260319594e7355337c5af > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547645 > Reviewed-by: Wei Lee <wtlee@chromium.org> > Reviewed-by: Shik Chen <shik@chromium.org> > Commit-Queue: Wei Lee <wtlee@chromium.org> > Cr-Commit-Position: refs/heads/master@{#829079} TBR=shik@chromium.org,hbos@chromium.org,ortuno@chromium.org,wtlee@chromium.org Change-Id: I31ad4e34332a5c54a0a4bd2c2f98dfe7e6544016 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/172345161 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549842Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#829154}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1605732977-d582403d24e72f4b574d0b095493057d717a9e6c.profdata to chrome-win64-master-1605743960-03e8e3c00d664b0272fc9bec8fbd6eb12ca9ed48.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I3b43ea7c938a850b4085175e5ac5a4249a8ec572 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548606Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3a578ae35233..16973d613fed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I02219e631374e971a799836b882f7210ea92988b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549401Reviewed-by:
-
Chrome Cunningham authored
This makes reset() match the spec. All pending/active work should be aborted and any late arriving outputs should not make it to JS. Bug: 1121340 Change-Id: I4963a39023320e081e2d2c13bba2d43fed990f91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541646 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#829151}
-
anina koehler authored
Bug: None Change-Id: I921ea0c990f1b20f6e993e136e472f14df6d2175 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539195 Commit-Queue: Anina Koehler <aninak@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
Hajime Hoshi authored
WebFilesystem doesn't have notions of handlers or connections, then it should be safe to allow pages with WebFilesystem to be put into the BFcache. Let's allow WebFilesystem for BFcache in order to improve the BFcache hit rate. This is implemented behind a flag and the feature is disabled by default. This means that this CL doesn't change the behavior by default. We might enable the feature later. Bug: 1144133 Change-Id: Idf5d9cfb8a4365ae65743c2becc7a4ef8ec66999 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531155 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#829149}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I0c44f09a9606445e7de459a882c47b34c4c0a5f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549721Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829148}
-
Maksim Sadym authored
Reland "Fix node screenshot. Part 1. Add `captureBeyondViewport` param to CDP command `captureScreenshot`." This reverts commit 85d844e3. Reason for revert: reland initial commit with disabled flaky test. Original change's description: > Revert "Fix node screenshot. Part 1. Add `captureBeyondViewport` param to CDP command `captureScreenshot`." > > This reverts commit 114bc6ab. > > Reason for revert: CaptureScreenshotTest.CaptureScreenshotBeyondViewport_InnerScrollbarsAreShown is failing consistently on linux-chromeos-rel: > > https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/42849 > https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/42850 > > Original change's description: > > Fix node screenshot. Part 1. Add `captureBeyondViewport` param to CDP command `captureScreenshot`. > > > > 1. Add `captureBeyondViewport` param to CDP command `captureScreenshot`. > > 2. Use `WebSettingsImpl::SetMainFrameClipsContent(false)` to force the whole page to be rendered. > > 3. Set `hide_scrollbars` to avoid artificial scrollbars. > > 4. Set `record_whole_document` to force the whole page to be rendered. > > 5. Removed DCHECK from `third_party/blink/renderer/core/frame/visual_viewport.cc`, as soon as it didn't expect to have preferences to be changed "on the flight". > > > > Details: https://bugs.chromium.org/p/chromium/issues/detail?id=1003629#c37 > > > > Screenshots: > > > > - Before: https://i.imgur.com/yt6WZRx.png > > - Patchset #1: https://i.imgur.com/VsocJ3L.png - artificial scrollbars. > > - Patchset #3: > > * https://imgur.com/UVqpzUQ - line breaks are not exactly the same as in original view. > > * https://imgur.com/MXpgHOl > > * https://imgur.com/haxemcr - not aligned with the node. > > * https://imgur.com/RbdlYVT > > - Patchset #18: > > * https://imgur.com/EWUmn0O > > * https://imgur.com/DUrQ1yF > > * https://imgur.com/cT5oBSi - perfectly aligned. > > * https://imgur.com/Jy4UWtf - no artificial scrollbars (because of the view extended). > > > > Bug: 1003629 > > Change-Id: I6bbc85cd0995626a8b1fb748ec9048c9d586200e > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470876 > > Commit-Queue: Maksim Sadym <sadym@chromium.org> > > Auto-Submit: Maksim Sadym <sadym@chromium.org> > > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#827440} > > TBR=dgozman@chromium.org,wangxianzhu@chromium.org,pdr@chromium.org,caseq@chromium.org,sigurds@chromium.org,sadym@chromium.org > > Change-Id: Iaa9b6ee9f5584adbb4a521808e2d201834a6a6dc > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1003629 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538543 > Reviewed-by: Scott Little <sclittle@chromium.org> > Commit-Queue: Scott Little <sclittle@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827505} TBR=dgozman@chromium.org,wangxianzhu@chromium.org,pdr@chromium.org,caseq@chromium.org,sclittle@chromium.org,sigurds@chromium.org,sadym@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1003629 Change-Id: I2d394d77d0235762c61449ff8e90573de4c0c5d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545524Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Maksim Sadym <sadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#829147}
-
Timothy Loh authored
This CL makes the CrosUsbDetector unmount filesystems from USB drives before sharing them with a VM. Currently USB drives are not allowed by the permission broker unless the VID:PID is explicitly allowed in enterprise policy, although we intend to change this behaviour after M88 branches. Mounted archive files from the USB will be unmounted, but zip files require the files-zip-mount flag turned on first (see bug 912236). The attach flow is restructured from a recursive flow (retry from start upon error) to a linear flow, making it easier to reason about. A subsequent CL will update the settings UI pages to show an error if unmounting (or any other step in the attach process) fails. Bug: 1146325 Change-Id: Id0ea4805fbdf901b56391929c2c4ef204380d9e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517231 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#829146}
-
Sergei Glazunov authored
This is a prerequisite for a subsequent CL that will allow us to enable cookies and tags/refcounts independently for a given partition. In addition, fix a regression in PartitionAllocTest.Bookkeeping, which occurs when BRP is enabled. Bug: 1073933 Change-Id: I7557e89e4dc51082ba043a0697f974a7d30c8c5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540984 Commit-Queue: Sergei Glazunov <glazunov@google.com> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8645ae9d..47d4ef3f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3688635721a8938e984d22ef6c663c4d73b12cb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548965Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829144}
-
Daniel Cheng authored
Bug: none Change-Id: I5f9ad4c4b10090b8fb9d76acf86f24cf71d5d1c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548964 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Auto-Submit: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#829143}
-
Zhaoliang Ma authored
There is no need to create |input_buffers_| when import mode is used, this CL limits the input buffer creation to non-import mode. Bug: b:172209195 Test: apprtc on atlas Change-Id: Idc42cc6b87add2564fc2b31d771477d9c71aefeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548886 Commit-Queue: Zhaoliang Ma <zhaoliang.ma@intel.com> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#829142}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1605743960-c6eb23d92bd5ebb2b738686f930937312c075c5e.profdata to chrome-linux-master-1605765502-afac6c1491dbda42eb7f9fa994b3ce280c680afd.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I840cc76540ec3bce66c0eca9629659eb3268c044 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549420Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/004bf3ee3fb4..d40c6d7f3bef If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC keishi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: keishi@google.com Change-Id: I66d9828a630dad5fde1829e679fcf9f80f8abddd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548807Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829140}
-
Paul Wankadia authored
https://chromium.googlesource.com/external/github.com/google/re2.git/+log/a84f9718f35f..9e5430536b59 $ git log a84f9718f..9e5430536 --date=short --no-merges --format='%ad %ae %s' 2020-11-17 junyer Make benchmarks use substrings of a random text buffer. 2020-11-15 twpayne Add note about Go Unicode character classes 2020-10-26 junyer Fix symbol visibility and add test coverage. 2020-10-13 junyer Get the conditional right this time. Sigh. 2020-10-13 junyer Don't support ParseFrom() on MSVC. It can cause ICEs. Created with: roll-dep src/third_party/re2/src R=thakis@chromium.org Change-Id: I46f07ce3400f21210bed61e07825f340a6232d30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548962 Commit-Queue: Paul Wankadia <junyer@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#829139}
-
Antonio Sartori authored
The Content Security Policies code under services/network and the relative mojo types still misses support for a few CSP directives. We need to support all CSP directives in order to use it as a replacement to the Blink types, and also if we want to add Content Security Policies to the Policy Container (see attached bugs). This CL implements support for the directive 'trusted-types'. Bug: 1021462,1149272 Change-Id: I78797427f9239e1b57aca3e71d4de83e9897e7a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539907Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Avi Drissman authored
@available works now for macOS 11.0; use it. Fixed: 1105187, 1115294 Change-Id: Icecd3b71b913e474629aa2e9c8be4936954e9689 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545080 Commit-Queue: Dominik Röttsches <drott@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#829137}
-
