- 28 Aug, 2019 40 commits
-
-
henrika authored
This is a minor change on how the audio format is setup for low-latency input streams on Windows in combination with a microphone with 4 channels. Previous changes have resolved mutli-channel issues in combination with DISCRETE channel layout but this particular device reports QUAD and we must therefore change how the channel mask parameter is acquired. Before this patch we asked the device and it said QUAD but that does not match the fact that the core audio layer forces number of channels to 2 for multi-channel cases. Hence, we had a conflict of 2 channels and QUAD. With the fix below, the final format will contain 2 channels and STEREO and it resolves the issue. In summary: avoid asking the device about it channel format since it can conflict with what the CoreAudioUtil class has set. The change has been verified by a reporting user and I have tested it on other multi-channel devices as well. Bug: 933976 Change-Id: I3b566afbd35bcf3afb9684b81bf06ee9bd4daded Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772877 Commit-Queue: Henrik Andreasson <henrika@chromium.org> Reviewed-by:
Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#691127}
-
Ivan Sandrk authored
Add a new policy type to wrap remote commands into policy data. See go/cros-secure-commands Option 1 for details. This is a sync of server side CLs cl/265498483 & cl/265476022. Bug: 891222 Change-Id: I018ee312c9a5856112cb4a2b02a2bdc4a2a62e7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774439 Auto-Submit: Ivan Šandrk <isandrk@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#691126}
-
Antonio Gomes authored
This is phase 1.5 on the design document [1]. [1] https://docs.google.com/document/d/1AJKVA5U4nDkyDB9p4ROrggWXadCxyy-grKaE9KS5vOU/ rtc_stats.cc|h define various classes, eg RTCStats, RTCStatsMember and RTCStatsReport. This CL moves both cc and h files to renderer/platform/peerconnection, and exposes factory methods to their functionality keep being accessible to content/ The factory methods are placed on the existing header web_rtc_stats.h. BUG=787254 R=guidou@chromium.org, haraken@chromium.org Change-Id: I0255c8283175d15aa6b4558f4486b371c67c8b2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772550 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#691125}
-
Huanzhong Huang authored
Surface the cookie controls toggle in privacy settings. Implemented behind the ImprovedCookieControls flag. Bug: 967668 Change-Id: I0ed43b7ac7f3022c1678261a372aa8aa0e1964f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677170 Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#691124}
-
Oskar Sundbom authored
This reverts commit 62dc00e2. Reason for revert: The test is flaky, see: https://crbug.com/998467 Original change's description: > Detects a client redirect loop with DeferAllScript > > Navigating to some websites with DeferAllScript enabled for that site > could cause a client redirect loop. A previous CL > (https://chromium-review.googlesource.com/c/chromium/src/+/1739493) > implemented this in a different way but that CL is not > mergeable back. > > This CL alternates it in a different way which also fixes the problem > and can be merged back. > > All the logic is behind a finch parameter and so can be easil turned off > using finch. > > Tested by commenting out the older code. This will also > be tested by beta builders using browser tests. > > Change-Id: Icb1075580d12890fe0ee9e902925eaf212744d37 > Bug: 987062 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760667 > Commit-Queue: Tarun Bansal <tbansal@chromium.org> > Reviewed-by: Robert Ogden <robertogden@chromium.org> > Reviewed-by: Doug Arnett <dougarnett@chromium.org> > Reviewed-by: Ryan Sturm <ryansturm@chromium.org> > Auto-Submit: Tarun Bansal <tbansal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#690983} TBR=tbansal@chromium.org,dougarnett@chromium.org,robertogden@chromium.org,ryansturm@chromium.org,mcrouse@chromium.org Change-Id: I92ea7e5e01a0c7471510dea85f1b7edc57a49233 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 987062, 998467 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768345Reviewed-by:
Oskar Sundbom <ossu@chromium.org> Commit-Queue: Oskar Sundbom <ossu@chromium.org> Cr-Commit-Position: refs/heads/master@{#691123}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b6bdad04c621..8e42ececca71 git log b6bdad04c621..8e42ececca71 --date=short --no-merges --format='%ad %ae %s' 2019-08-28 rmcilroy@chromium.org [Tracing] Remove runtimeStatsMetric Created with: gclient setdep -r src/third_party/catapult@8e42ececca71 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=skyostil@google.com Bug: chromium:688342 Change-Id: I9fec171cf61aff5043c6379dcb274f2ccbd87e25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774054Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691122}
-
Jan Krcal authored
This reverts commit 55420155. Reason for revert: We've instrumented a critical path that we're suspecting with debugging logs (https://chromium-review.googlesource.com/c/chromium/src/+/1771904). And we need to see a few flakes of the tests to look in the logs. I'll disable it again soon after. Original change's description: > Disable SingleClientWalletSyncTest.SameUpdatesAreIgnored on ASan/TSan > > The test is disabled due to high flakiness. > > TBR: treib@chromium.org > Bug: 997912 > Change-Id: Ifa5e1cc89354163622a6a6ca593498c6fe3a6028 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771974 > Commit-Queue: Jan Krcal <jkrcal@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Reviewed-by: Jan Krcal <jkrcal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#690763} TBR=treib@chromium.org,jkrcal@chromium.org Change-Id: I575243fb135ea5fe6cbcd0669f366b7eef51e456 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 997912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774282Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#691121}
-
Marc Treib authored
plus corresponding chrome://flags entry. It doesn't do anything yet. Bug: 998455 Change-Id: I8bb339702528bde41d451a6b4d57e41f61835b6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768342Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#691120}
-
Rayan Kanso authored
Bug: 980291 Change-Id: I951ce25bb15e17f48b974f30a8b8e074f83f8e32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771975 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#691119}
-
Robert Sesek authored
OCMock prior to 3.3 is thread-hostile, and Chromium uses v3.1.5 currently. This is causing memory errors under ASan. Bug: 997782 Change-Id: I987139e2e1bc89743d8e51956010b8738cfdce7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773542Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#691118}
-
Jérôme Lebel authored
SigninPromoViewMediator should not send update notification to its consumer when the sign-in is in progress. This is to avoid updating the sign-in promo from cold state to warm state while the sign-in is not over. Bug: 986746 Change-Id: I4f4386034549394eb556e6e48254d97dc4590656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718370 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#691117}
-
Christian Dullweber authored
Add a page action icon and a bubble view to control third-party cookie blocking. Replaces the "Cookies blocked" icon when enabled. https://screenshot.googleplex.com/3jFhD5uJj1W.png Bug: 967668 Change-Id: Id498f3f569ef940d1cb277dc8ea629c7de329cfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1685382 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#691116}
-
Yasmin authored
Before: One device: Send to pixel 2XL Multiple device: Send to devices After: One device: https://screenshot.googleplex.com/h7ggmzB8TZz Multiple device: https://screenshot.googleplex.com/mduLZUSpqLb Bug: 996676 Change-Id: I775de0d561859b21f5b8ebf6721aa19fcea005c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768591Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Yasmin Molazadeh <yasmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#691115}
-
Marc Treib authored
After crrev.com/c/1768775 it's unused, except for some tests. Some of these are updated to use GROUP_PASSWORD instead (the only remaining non-UI non-USS group, which will actually also be removed soon), and some, where that was not easily possible, are just removed. Bug: 853688 Change-Id: I361e27bfb85c22b781498ee4468b9f6dd57dbcce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773138Reviewed-by:
-
Jake Hughes authored
This is the first CL of an artefact investigating precise stack map support for garbage collection in Blink / V8 using experimental LLVM features. The bulk of this change is made up of two main components: - A parser for reading the .llvm_stackmap section (generated by LLVM) into a table for use by the GC. - A simple stack walking mechanism, which, once called, traverses the call stack bottom up frame by frame searching for a gc rootset in the root table. This also fleshes out a few helper API functions (see gc/gc_api.h) which can be used when calling into the gc library from user code. The idea for this gc/ directory is to be compiled as a library. It is then linked to user code which has be compiled with the relevent LLVM IR passes for generating stack maps at pre-defined safepoints. The code for which will be forthcoming in a separate CL. Bug: 978892 Change-Id: Ia2cb40881460b6a084babab9986df6c5303b41f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768770 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#691113}
-
Rayan Kanso authored
TBR=timvolodine@chromium.org Bug: 998478 Change-Id: Ib7b24f28474773be6cfa6b0dc3e9f1c3a8497be3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768343Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#691112}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0f0281d3e2a8..9a49709304f6 Created with: gclient setdep -r src-internal@9a49709304f6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: I176b35f629a978a81b544c46f092ad6920a02c6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774050Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691111}
-
Marc Treib authored
Instead of a custom build step that mangled the sources for java compilation. In the past, the script mangled the protos to be compatible with the proto nano library, but this hasn't been necessary for a while (we've been using proto lite already). Now all it did was add two java_* options to the files. It's easier and harmless to just add these options into the files themselves. This was triggered by crrev.com/c/1773256 which wants to expose some of the sync protos to java (outside of tests). Bug: 998429 Change-Id: Ic4165d732b9a04d49938ce1fe06ca9d4bc735427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772165 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
-
Oskar Sundbom authored
Tbr: pkasting@chromium.org Bug: 998403 Change-Id: Ie5de3f9336b6fcc5c5e49e21465f4a3a68402f7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773141Reviewed-by:
-
Rayan Kanso authored
All Android JNI calls to native will be routed via SharingServiceProxy which calls into SharingServiceProxyAndroid. SharingServiceProxyAndroid then either handles the request directly or forwards it to one of the sharing handlers. TBR=estevenson@chromium.org Bug: 996320, 997200 Change-Id: I0d30048938bf51439c19aa52b9d9e775dfc41fe3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768339 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#691108}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a203388eab27..8e62744aa4a1 git log a203388eab27..8e62744aa4a1 --date=short --no-merges --format='%ad %ae %s' 2019-08-28 primiano@google.com Move build flags to generated file, stop using cflags Created with: gclient setdep -r src/third_party/perfetto@8e62744aa4a1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: chromium:132678367 Change-Id: I138662254bc2ba815d838899b2450465ee9e579c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774047Reviewed-by:
-
Jérôme Lebel authored
Adding a callback counter into FakeChromeIdentityService to be able to run the runloop until all callbacks are called. This helps to cleanup the SigninPromoViewMediatorTest to test image updates in the sign-in promo view. Therefore WarmStateConfigureSigninPromoViewWithImage is now useless. Related to: + crrev.com/c/1760793 + crrev.com/c/1718370 Change-Id: I6f625ba6715db207574a9bba3715edad2c2cfd10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764151Reviewed-by:
-
Andrei Chulkov authored
Change-Id: I6178d17add00beb32ac7067638c8119cb4ed236f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773216 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#691105}
-
Alex Chau authored
- Include fcm_token and encryption_info in all non-Ack SharingMessage, so we can send Ack without looking up sync preference. This allow Ack to be sent reliably and own't be affected by delay for above data propagating through sync - Store encryption_info in local preference, so we can embed it in SharingMessage without looking up GcmEncryptionProvider - Add method to fast lookup Device from SharingSyncPreference - Removed logic in SharingFCMSender that clean up GONE device, because this will race with device trying to registering at the same time, and results in device not in sync preference after registration. As we're migrating to DeviceInfo we won't be able to clean up other devices in the future as well. Bug: 988975 Change-Id: I2d0f7051fe1a31aa7a2db9e3494584b475aa7052 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768702 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/886698bc3fdd..6f24d8a79388 git log 886698bc3fdd..6f24d8a79388 --date=short --no-merges --format='%ad %ae %s' 2019-08-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/glslang/src a3bc04b278ed..f27bd2aa2e3f (4 commits) Created with: gclient setdep -r src/third_party/angle@6f24d8a79388 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Bug: chromium:None Change-Id: I43f8f0a02ca610885cc827e2826c6827c9231e72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774048Reviewed-by:
-
Peter Beverloo authored
The test relies on closing a notification to be faster than SW -> document communication, which until recently was true, but is not a guaranteed contract. Bug: 997824 Change-Id: I32141ed13acd85b7e74e9f14c5493b156c69870f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768341Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#691102}
-
Tsuyoshi Horo authored
Bug: 998359 Change-Id: Id9c7290487bd8ae001c28a02a7a629c3727a30d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772210Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#691101}
-
Oskar Sundbom authored
This reverts commit 887f778e. Reason for revert: Breaks MSan tests Original change's description: > Roll src/third_party/swiftshader a9da772f0587..04e148570dbb (8 commits) > > https://swiftshader.googlesource.com/SwiftShader.git/+log/a9da772f0587..04e148570dbb > > git log a9da772f0587..04e148570dbb --date=short --no-merges --format='%ad %ae %s' > 2019-08-28 capn@google.com Make round-robin task enqueue index thread safe > 2019-08-27 bclayton@google.com Device: Migrate Renderer to Yarn > 2019-08-27 bclayton@google.com Device: Don't use a global for the cluster count. > 2019-08-27 bclayton@google.com Some minor code tidying. > 2019-08-27 bclayton@google.com Pipeline: Use Yarn to make compute multi-threaded. > 2019-08-27 bclayton@google.com Vulkan: Build a yarn::Scheduler and pass it down to the vk::Queue. > 2019-08-27 bclayton@google.com vk::Queue: Lazily construct Renderers > 2019-08-27 bclayton@google.com Yarn: Don't zero-initialize data in Pool<T>::Item::construct() > > Created with: > gclient setdep -r src/third_party/swiftshader@04e148570dbb > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/swiftshader-chromium-autoroll > Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > TBR=swiftshader-team+autoroll@google.com > > Bug: chromium:b/139010488,chromium:b/139142453,chromium:b/139142453,chromium:b/139142453,chromium:b/139142453,chromium:b/139010488,chromium:b/139142453 > Change-Id: Iceb60a95f44801f390732a1506641ace01c4e131 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774264 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#691066} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,swiftshader-team+autoroll@google.com Change-Id: I58b3d9d5fb39b0db4e2fedac3a29ca1f1e5a3998 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:b/139010488, chromium:b/139142453, 998457 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773142Reviewed-by:
-
Yoshifumi Inoue authored
This patch markes following CSS properties layout dependent: - margin-block-start, margin-block-end - margin-inline-start, margin-inline-end - padding-block-start, padding-block-end - padding-inline-start, padding-inline-end for improving browser interoperatiblity. This patch is follow up of the CL[1] to fix following tests: - css/css-logical/parsing/margin-block-inline-computed.html - css/css-logical/parsing/padding-block-inline-computed.html [1] http://crrev.com/c/1760419 Import WPT tests Bug: 995612 Change-Id: If754cdcb7085ffa10cf965301f46f7aace33032d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774421Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#691099}
-
Rune Lillesveen authored
No behavioral change. Change-Id: I054cd7f3743d0021f52241f2839297c0ae97bcf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768340 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#691098}
-
Clemens Arbesser authored
This fixes a bug where the client would not correctly end a PR action for some invalid protos. Note: this is likely *not* b/140008909, but I can't yet confirm. This also fixes a bug where the client should fail the PR if a login choice was requested but no options are available (e.g., for websites which do not offer guest checkout). In practice, this is unlikely to happen, but the case should be handled regardless. Bug: 806868 Change-Id: I68174fa84e72fbfe209272cc62d6461970762fe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771604 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#691097}
-
Rouslan Solomakhin authored
https://chromium.googlesource.com/chromium/deps/hunspell_dictionaries.git/+log/ecb3c4f4ce2c..681ca92480ec $ git log ecb3c4f4c..681ca9248 --date=short --no-merges --format='%ad %ae %s' 2019-08-23 msmiljanic.gm Replace plain text Serbian dictionary with rule based dictionary. Created with: roll-dep src/third_party/hunspell_dictionaries R=gujen@chromium.org Bug: 997228 Change-Id: I2737accf1293ebcfa7b4903ce92ba5755835be60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769176 Auto-Submit: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#691096}
-
Rayan Kanso authored
This reverts commit d0788ba8. Reason for revert: Breaking the build (crbug.com/998383) Bug: 998383 Original change's description: > Don't compile DownloadService in Android. > > Bug: 996380 > Change-Id: I57e49cad315fb038ef4b9dfb71293f49f64c749f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769728 > Commit-Queue: Bettina Dea <bdea@chromium.org> > Reviewed-by: Daniel Rubery <drubery@chromium.org> > Cr-Commit-Position: refs/heads/master@{#690903} TBR=bdea@chromium.org,drubery@chromium.org Change-Id: I441fa51291798df8d4243f197ecad0090c43638f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 996380 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774279Reviewed-by:
-
David Jean authored
With 32 bits build gone, iOS can use the posix implementation of TimeExploded, which is faster. Bug: 985061 Change-Id: Ic1d42ebddfa2d0bb0d37bb7b2086683914aa87a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763679 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#691094}
-
Mike West authored
URLs like `https://whatever.com:0/` have an opaque origin, as they're rejected in the SchemeHostPort constructor (see [1] and [2]). This means that they fail the `IsOriginSecure()` check, and crash the renderer, which is a bit unfortunate, as they're going to fail to load regardless. This patch excludes URLs with opaque origins from the referrer check in order to avoid that crash. [1]: https://cs.chromium.org/chromium/src/url/scheme_host_port.h?rcl=90e84c7240870d52c224cb8c07b52545a2ef7cef&l=83 [2]: https://cs.chromium.org/chromium/src/url/scheme_host_port.cc?rcl=90e84c7240870d52c224cb8c07b52545a2ef7cef&l=85 Bug: 960312 Change-Id: I39a41e3148554fda36e52d1f0c9934f52a2b8dff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771906 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#691093}
-
Dominik Röttsches authored
The promise resolution was already wrapped in calling it inside the right execution context, but the reject was not. Add the correct execution context and schedule rejecting the promise if font loading for a local() font fails when it is triggered by an implicit UA-triggered load. Spec reference: https://drafts.csswg.org/css-font-loading/#font-face-load in particular the last normative paragraph: "User agents can initiate font loads on their own, whenever they determine that a given font face is necessary to render something on the page. When this happens, they must act as if they had called the corresponding FontFace’s load() method described here." Thanks to Roel Nieskens (pixelambacht@) for the helpful bug report and reproduction test case. Bug: 996687 Change-Id: Icb5d75675b8a2e0b3f100808645a1e2e550cfcd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771607 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#691092}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7096a4a9fc5b..0f0281d3e2a8 Created with: gclient setdep -r src-internal@0f0281d3e2a8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Iba6155c369448cc52caf79f5fde91da4010e5971 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772455Reviewed-by:
-
Mohamed Amir Yosef authored
This patch adds logging for the dropped invalidations in Sync browser tests. This will help investigate some flaky tests. Invalidation are dropped if they are received before an FCMNetworkHandler is actually assigned and listening for FCM messages. Change-Id: I10409bfdda7b0616da6e45a6ecd5f00b3cd5bef0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771904 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
-
Jessica Tallon authored
A crash can sometimes happen when there the base and extent are equal and there are no valid nodes going rightward. This fixes it so in this situation it should have the selection on the same leftward node. Bug: 989162 Bug: 987702 Change-Id: I10a05125367f561ed5b4ba2b3d533907caf8b7ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760303Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Jessica Tallon <jtallon@igalia.com> Cr-Commit-Position: refs/heads/master@{#691089}
-
Keishi Hattori authored
ScheduledAction::Execute is only ever called by DOMTimer::Fired which is called as a task. So the stack is simple and we should be able to add AllowedStackScope and allow cooperative scheduling. Bug: 804661 Change-Id: Ida6d3605810469d0e95b6e72ded3f1aed05ad341 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743236 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
-
