- 23 Mar, 2020 40 commits
-
-
Brian Sheedy authored
This is a reland of e9f81dc4 Failures that caused the revert are semi-expected and only on a bot marked as experimental. Original change's description: > Switch Win Exp bot to 26.20.100.7870 > > Switches the GPU Win10 Intel experimental bot to trigger tests on > machins with driver 26.20.100.7870 to test the stability. > > TBR=ynovikov@chromium.org > > Bug: 1053803 > Change-Id: I3fa8467656312288add0658a3e4b7dfb9c5ac2d8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111470 > Reviewed-by: Brian Sheedy <bsheedy@chromium.org> > Reviewed-by: Yuly Novikov <ynovikov@chromium.org> > Commit-Queue: Yuly Novikov <ynovikov@chromium.org> > Cr-Commit-Position: refs/heads/master@{#751911} TBR=ynovikov@chromium.org Bug: 1053803 Change-Id: I9cd2367326cd9314434f0a4f34618e959b605b7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115777Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#752600}
-
Nico Weber authored
Bug: 346399 Change-Id: Ie7c99842e8630c606f3bb135e83ed14ecac5d5d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116597 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#752599}
-
Vasilii Sukhanov authored
Bug: 1049177 Change-Id: I42c3fce0c89859199d82db053fd899a2ed464e02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115655 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#752598}
-
Sahel Sharify authored
This cl moves PayerData.java class into components/payments so that the WebPaymentIntentHelper.java class can use it without depending on chrome/browser. It also introduces a new Address class and its converter utility class so that PayerData.java does not depend on mojom.PaymentAddress. Change-Id: Idb737bc2697212af7542d3abbd1488461a7d3074 Bug: 1026667 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110678 Commit-Queue: Sahel Sharify <sahel@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#752597}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e9340f3aaa1e..abf84e73de6c Created with: gclient setdep -r src-internal@abf84e73de6c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1016929,chromium:1063174 Tbr: jbudorick@google.com Change-Id: I9a1d10165b66e5299f627e5674de893db817497e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116471Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#752596}
-
Clark DuVall authored
Bug: 1025609 Change-Id: Ie4aca6a905a1f6818faf09be00499e1986d16880 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065413 Commit-Queue: Clark DuVall <cduvall@chromium.org> Auto-Submit: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#752595}
-
Jinsuk Kim authored
Multiple ProfileDestroyers destroying a single Profile is sorted out in ProfileDestroyer::DestroyOffTheRecordProfileNow by the first destroyer nulling out the pointer to the Profile in the others so they won't destroy the same Profile again. It has a bug breaking out the loop after handling the first one. The right way is finding and nulling out all the Destroyers. This CL fixes it. Bug: 1029677 Change-Id: I7d8efe60a28613040e0a2afd9db0640ea3602c2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113391 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#752594}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/1dea10da0ae8..85201b613e63 git log 1dea10da0ae8..85201b613e63 --date=short --first-parent --format='%ad %ae %s' 2020-03-23 rmhasan@google.com [Telemetry] Add SUPPORTED_PLATFORM_TAGS list to Benchmark class Created with: gclient setdep -r src/third_party/catapult@85201b613e63 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:992603 Tbr: sadrul@google.com Change-Id: Iea388a40bbef3d402713836c0581640db9ef6ca3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116692Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#752593}
-
Mila Green authored
Bug: 1064059 Change-Id: Id8362f5f70f82a5732b32746a71e4131223923a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116593Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Mila Green <milagreen@chromium.org> Cr-Commit-Position: refs/heads/master@{#752592}
-
Emilio Cobos Álvarez authored
See https://github.com/WICG/construct-stylesheets/issues/62 for the rejected promise bit. On top of that we were not returning so we were incorrectly applying the styles. Bug: 1063809 Change-Id: I63aa937f66871e3b8eee577a7f2ddd873f45d2c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116092 Commit-Queue: Emilio Cobos Álvarez <emilio@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Auto-Submit: Emilio Cobos Álvarez <emilio@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#752591}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/dcbd802564ed..3e74fb81116b git log dcbd802564ed..3e74fb81116b --date=short --first-parent --format='%ad %ae %s' 2020-03-23 thestig@chromium.org Disambiguate CFX_PathData::IsRect(). 2020-03-23 thestig@chromium.org Use more spans in CGdiplusExt::DrawPath(). 2020-03-23 thestig@chromium.org Remove manual memory allocation in CGdiplusExt::DrawPath(). 2020-03-23 thestig@chromium.org Remove some unneeded includes. 2020-03-21 nigi@chromium.org Fix rendering issue for PDFs with incorrect first-page hint data. Created with: gclient setdep -r src/third_party/pdfium@3e74fb81116b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1012237 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I1876b21d517db9ba967b1a3e6ff1d8d8f52cff02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116693Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#752590}
-
Clark DuVall authored
Passing command line arguments now works with, for example: $ autoninja -C out/Release run_weblayer_shell $ out/Release/bin/run_weblayer_shell https://google.com \ --args='--weblayer-user-data-dir=/data/data/org.chromium.weblayer.shell/some_dir' Bug: 1063945 Change-Id: Iffdda53a56950f74dd58df63faa5cb8604988ee3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116598Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#752589}
-
Andrey Kosyakov authored
... originally regressed by https://chromium-review.googlesource.com/c/chromium/src/+/2107302 Bug: 1063506, 1059968 Change-Id: Id7fd285c9e5cf9a70981e34c4645f778fbf2899f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113801 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#752588}
-
Peter Kasting authored
Bug: 968222 Change-Id: I5c9a711686f6af8d550b33e18e7b9419e016d09b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114406 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Tien Mai <tienmai@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#752587}
-
Adam Langley authored
This reverts commit aa1faf82, i.e. it relands fccf3a8f. (After thinking about structure padding and writing a comment, I forgot to actually handle it! Probably too complex anyway; do something dumber.) > Revert "Give the desktop a public key in QR handshakes." > > This reverts commit fccf3a8f. > > Reason for revert: > This CL breaks on Linux MSan bot > FidoCableDiscoveryTest.TestDiscoveryFindsNewAppleDevice > FidoCableDiscoveryTest.TestDiscoveryFindsIncorrectDevice > > First failure: > https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests/22909 > > Original change's description: > > Give the desktop a public key in QR handshakes. > > > > This change switches the QR-based handshake from NNpsk0 to KNpsk0. I.e. > > it gives the desktop a public-key. That key is included in the QR code > > and means that an attacker who sees the QR code cannot impersonate the > > desktop and pair with the phone. (The other direction is still possible, > > however, and seems fundamental without the user entering a confirmation > > code on the desktop.) > > > > BUG=1002262 > > > > Change-Id: I7254a8aa17df71d2bcabb4371a1c18914ed20641 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109032 > > Commit-Queue: Adam Langley <agl@chromium.org> > > Auto-Submit: Adam Langley <agl@chromium.org> > > Reviewed-by: Martin Kreichgauer <martinkr@google.com> > > Cr-Commit-Position: refs/heads/master@{#752196} > > TBR=agl@chromium.org,martinkr@google.com > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1002262 > Change-Id: Id75ad0bab2862b3dafe73d20cf762883cc24faf9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113771 > Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> > Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> > Cr-Commit-Position: refs/heads/master@{#752403} BUG=10022628 Change-Id: I993eab544edd2eca6bc5c5923f9dab9b2d07c393 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115799 Commit-Queue: Adam Langley <agl@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#752586}
-
Mikel Astiz authored
When the user goes through a reauth flow to retrieve trusted vault keys, the page should be closed upon completion. In order to achieve this, NavigateParams.created_with_opener is set to true, which allows Javascript on the page to close itself. In addition, the reuse of the NTP is disallowed because, in many relevant scenarios such as FRE, the NTP is the only existing tab and cannot be closed. As a fallback mechanism, a URL parameter is added to the reauth URL, in case the page decides to redirect instead of closing (or if closing the tab was rejected). Change-Id: I124ddd299c47a7c5705b410829a38130ea78e208 Bug: 1062977 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108731 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#752585}
-
rbpotter authored
Bug: 1026426 Change-Id: I909df5d209fa574def562b572d5dcf4ad8c774e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113817 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#752584}
-
Wenbin Zhang authored
Refactoring work to make the process_perf_results cleaner. Bug: chromium:1045256 Change-Id: I8f5304364a111d5d7319cca7a297650af0ab721d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115698 Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#752583}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I6e4869ebbb0c3cfbac28a29994c000601e6b8bfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115797Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#752582}
-
Nico Weber authored
No behavior change. Bug: 346399 Change-Id: Ia658bb2a3ba42f7da364688691bd926bb0c0bbb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115783 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#752581}
-
John Lee authored
https://imgur.com/a/d54f4Ql Fixed: 1063811 Change-Id: I2cf58c15bbd9b5fe005c94e29e582acc3a32c829 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116012Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#752580}
-
Steven Bennetts authored
For c/b/ui/ash/network OWNERS (will update in a followup): TBR=khorimoto@chromium.org Bug: 1054951 Change-Id: Ic24e51c04ca75a62a65bcdbfdba276580878dc02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079131Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#752579}
-
Robert Ma authored
No-Try: True Bug: 1062984 Change-Id: I26141a5bb5c53765c6cabbc30e09cd2de4b92f27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115767 Auto-Submit: Robert Ma <robertma@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#752578}
-
Tina Wang authored
chrome/browser/browser_process.h imports chrome/common/buildflags.h but doesn't include the target in BUILD.gn. chrome/test/base/testing_profile.h ditto. As the result, the files above maybe compiled before the buildflags.h is generated, which caused multiple flaky build failure. This CL added necessary target to deflake the build. TBR=sky@chromium.org Bug: 1063513 Change-Id: Ic3a74260351937382a9eabd32b9251d8d6057cd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116591 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by:
Tina Wang <tinazwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#752577}
-
Jeremy Apthorp authored
This removes logic in the MessagePort mojo handler that prevents MessagePorts from starving the message loop. This logic is redundant since https://chromium-review.googlesource.com/c/chromium/src/+/1145692. Change-Id: I379a8429675844837b5e51390cb803a288c2fe81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112954Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Jeremy Apthorp <jeremya@chromium.org> Cr-Commit-Position: refs/heads/master@{#752576}
-
danakj authored
The file contains one class and should represent the name of that class. R=nasko@chromium.org Bug: 866140 Change-Id: I7fe53fd31c593ac5053883480e2a274527d97542 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113437 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#752575}
-
Jeff Yoon authored
The iOS generate wrapper template sets xctest and xcode parallelization to true (in ios/third_party/earl_grey/ios_eg_test.gni. Some EG tests don't utilize xctest, so we want to explicitly turn those off. Setting xctest = false for those tests in .gn files. Adding the test-arg for ios_chrome_settings_egtest in the manner that run.py expects it in. Change-Id: Id5ee79f08a34c4e9e3db84769287ee51b735bd29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112750Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#752574}
-
Clark DuVall authored
This change allows the preview tab to tell PermissionRequestManager to drop any permission requests it receives for the associated WebContents. TBR=andypaicu@chromium.org Bug: 1057951 Change-Id: I65ee35fbaf2081cc99d8384a5b0818fc9f026ef3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112812 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#752573}
-
Martin Kreichgauer authored
The existing kU2FCryptotoken{Register,Sign} UseCounters are currently counted by Blink after the cryptotoken extension issues a WebAuthn request. Blink counts them to the ExecutionContext from which the WebAuthn request originates, which belongs to the cryptotoken Chrome extension. Instead, increment those UseCounters on the cryptotoken side, using the MainFrame of the tab associated with the U2F request, so that the recorded events are attributed to the site that actually made the U2F request. Change-Id: I672df8d2abdd0a32af887f2cb37fdb3e11c3338e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107708 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#752572}
-
Andrew Grieve authored
And rely on device_dependencies.py to prevent .stamp from being pushed to devices rather than a shim group() Change-Id: I4b0f50657d81b366ec1f81af9cc32e58e62380e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112815Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#752571}
-
Rob Buis authored
Map displaystyle attribute using math-style [1] as defined here [2]. Use the mapped internal math-style value for laying out fractions, i.e. pick the relevant metrics based on the math-style. [1] https://mathml-refresh.github.io/mathml-core/#the-math-style-property [2] https://mathml-refresh.github.io/mathml-core/#dfn-displaystyle Bug: 1023296 Change-Id: Ie12eb43275c5ca773c8f824e1f4c1a0f9f232b85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105317Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Frédéric Wang <fwang@igalia.com> Commit-Queue: Rob Buis <rbuis@igalia.com> Cr-Commit-Position: refs/heads/master@{#752570}
-
Tommy C. Li authored
Currently we make a histogram log for each match position that changed asynchronously. This is a valuable metric, because it's proportional to the number of pixels that are changed that the user can see. But it also has the weakness of allowing a single match to displace multiple matches and generate multiple log counts. In other words, more bins are logged if more matches exist. This CL adds a analogous boolean histogram that logs True if ANY match positions change, and False if NONE of the match positions change: Omnibox.MatchStability.AsyncMatchChangedInAnyPosition I suspect both types of logging with be complementary. This new one should also be normalized by: Omnibox.Start.WantAsyncMatches::True Bug: 1062706 Change-Id: Ia325c15f3dfe67631613a136ede7bde51363ad39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108531 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#752569}
-
Wei-Yin Chen (陳威尹) authored
Bug: 1064009 Change-Id: I6be262615deaeb9b237345540888ec57ac0fdcca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114401Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#752568}
-
Nathan Zabriskie authored
We are almost ready to fully turn off ContextGL on the Shared main thread context as part of the OOPR Canvas project. This CL replaces instances of ContextGL with the equivalent RasterInterface APIs in AcceleratedStaticBitmapImage. Bug: 1018898 Change-Id: Idf289c02273564ee987066e08421ac4b15384c2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116532Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com> Cr-Commit-Position: refs/heads/master@{#752567}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/96e601c0..e1cd685a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibcb6b22434708f159c824cd84ce554bd9c7bb110 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115766Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#752566}
-
Kham Udom authored
Fixed the background and foreground on the tab-header when on focused. Set border on dialog and fix the color on the background and inputs. Before: https://imgur.com/a/iEyWDf7 After: https://imgur.com/a/iVnvDpc Bug: 1048378 Change-Id: I59312eff672a7f9386e7e78223ba0e5c58cd3eb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109493Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Kham Udom <khamu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#752565}
-
Matthew Mourgos authored
This change updates the OOBE gesture intro page to have vertical spacing between items set at 16px. Also, spacing between the icons and text to the right is set to 8px. On the marketing OOBE screen the accessibility link has been moved down to go along side the dialog button (next button). Also the color of the link is change to be google blue 600. Bug: 1062090 Change-Id: Ic1714ed07b19f3575702ed436f1e71f8778632f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106750 Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#752564}
-
Demetrios Papadopoulos authored
There are two such entry points and only one should be shown at a given time, based on whether signinAllowed is true/false. Incorrectly, both of them were showing when signinAllowed=false. Existing tests were failing to catch the problem, and erroneously succeeded. Fixing tests as well. Fixed: 1063451 Change-Id: Ic0b6046b2f6e5934a76133ca95a702f9bc79bd46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112899 Commit-Queue: dpapad <dpapad@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#752563}
-
Rafael Cintron authored
If CreateSwapChainForComposition fails, we cannot draw content to the browser window. Failure here is indicative of an unrecoverable driver bug. Hence, terminate immediately and let the browser process start a fresh new instance. Bug: 1054217 Change-Id: I1f8af2893a4e23159b6fb543ed669fe6f9e34ea6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111056Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com> Cr-Commit-Position: refs/heads/master@{#752562}
-
Wei-Yin Chen (陳威尹) authored
Bug: 1058196 Change-Id: I712b731ebe31811aa07cdea42f3adb2b819a2325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111776 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#752561}
-