- 06 Jan, 2021 40 commits
-
-
David Tseng authored
<settings-switch-access-action-assignment-dialog id="switchAccessActionAssignmentDialog" on-close="onSwitchAccessActionAssignmentDialogClose_" action="[[action_]]"> is how a dialog is expected to be used (from the switch access subpage). switch_access_awction_assignment_dialog_test neglects to set |action| above, leading to a test-only failure. Previously, SwitchAccessActionAssignmentDialog's |this.assignemnts| did not depend on |this.action| for its initial value; it now does. Fix by assigning action in test. Original change description This change implements the infrastructure for assignment and capture of Switch Access keys tied to a specific type of input device (internal, usb, bluetooth). Along the way, it also cleans up unused code, obsoleted preferences. It does not hook up the final UI for the device type which will be handled separately once UX is finalized. TBR=jamescook@chromium.org,dtseng@chromium.org,michaelpg@chromium.org,josiahk@google.com,zentaro@chromium.org,rhalavati@chromium.org Test: preexisting ash_unittests AX-Relnotes: n/a Bug: 1163226 Change-Id: Iad97fb938e84240eee15cc3f5bc009368ed22c4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613009Reviewed-by:David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#840631}
-
Ryan Hansberry authored
Fixed: 1160907 Change-Id: Ib38775ae2d687fe624a36f1fcf63226a541ffc9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612032 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Auto-Submit: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#840630}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1609923503-9b9894a01ac9daf80ce951069eff07585fba216a.profdata to chrome-win64-master-1609934346-02960af12c9c6cfb124c9f1bb5033b3eb2b936e3.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I0e71659c33f971023e3b9bff43b34ab53fecd1b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613113Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840629}
-
Jun Kokatsu authored
This change clean up unnecessary test cases in the NoTrustedTypesViolation test. Also added few things that makes debugging of the test failure more easier. Bug: 1115643 Change-Id: I12e77b3038046337f8002850f5c28806dd722acd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610486Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Jun Kokatsu <Jun.Kokatsu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#840628}
-
Ella Ge authored
These usages of ChromeActivity can be easily replaced by Activity. Bug: 1155353, 1155804 Change-Id: I307cc9708dde7237b9d4e4630c03cd58dc1f7a15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605877Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#840627}
-
Monica Basta authored
Rename the label from 'Chrome name and picture' to 'Customize your Chrome profile' if the spaces experiment is on. Bug: 1147088 Change-Id: I717c4b403bdb3452b13ba170ad5a251219370a34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612887Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#840626}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202101060600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/_2IUiaMakoAVmovMPZQalk_OvCtn2wuY52u81Pw-egYC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: help-app@grotations.appspotmail.com Change-Id: I9d4bd14fce4121b65963e7402ea56f7fa37c0733 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613165Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840625}
-
Austin Sullivan authored
Currently, there are two methods to create a FileWriter via its Manager. One of these methods used to return a raw pointer to the FileWriter. Now, it returns a WeakPtr. Bug: N/A Change-Id: I00af3d05c762362a9b26f359510f475ed6827bf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599671 Commit-Queue: Austin Sullivan <asully@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#840624}
-
Maksim Sisov authored
This is a reland of a489cfcd 1144179 is a P0 issue. Instead of reverting the entire patch, just disable overlay delegation for non-lacros. Original change's description: > [ozone/wayland] Ensure root_surface is committed last in a frame > > wl_surface.commits of a frame can happen asynchronously due to wl_buffer > import delay, frame callbacks, etc. This asynchrony can cause visual > glitches when the root_surface commits before its subsurfaces commit. > > This CL ensures that a root_surface commit always happens after other > commits in a frame. > > Change-Id: I7c83e122c4cdee42e6b8aca74875fa71b6c1ab5a > Bug: 1144179 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547395 > Commit-Queue: Kramer Ge <fangzhoug@chromium.org> > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Reviewed-by: Maksim Sisov (GMT+2) <msisov@igalia.com> > Cr-Commit-Position: refs/heads/master@{#834327} Bug: 1144179, 1162867 Change-Id: Ibad3c9b44378967b826496971205a12d55a1417c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611709 Auto-Submit: Maksim Sisov <msisov@igalia.com> Commit-Queue: Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#840623}
-
Morten Stenshorne authored
This reverts commit ac10443d. Reason for revert: Probably breaking mini_installer_tests and ProcessSnapshotTest.CrashpadInfoChild https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/112543 Original change's description: > [PartitionAlloc] Better freelist corruption detection. > > Some PartitionAlloc crashes are likely due to freelist > corruption. PartitionAlloc has two types of freelists: in the central > allocator, and in the thread cache. The central allocator one already > has a DCHECK() to verify that subsequent entries belong the same > superpage, which doesn't hold for the thread cache freelists. > > This CL: > - Makes these crash lead to a NOINLINE function > - Add an interity check to all freelists. > > This is not meant to be a security mitigation, but to prevent against > accidental issues. > > Bug: 998048 > Change-Id: I21aedfe2b6363069362514a8edd6cd5bdea1acfc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582218 > Commit-Queue: Benoit L <lizeb@chromium.org> > Reviewed-by: Chris Palmer <palmer@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840587} TBR=palmer@chromium.org,haraken@chromium.org,lizeb@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Idd7f8213dae35146d4ada835cd443505f88749ce No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 998048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612968Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#840622}
-
Clemens Arbesser authored
This brings them in line with regular script preconditions. Bug: b/175785117 Change-Id: I3fbc991b6c7a97c6b8134b989795cc4e96c44311 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611718 Commit-Queue: Clemens Arbesser <arbesser@google.com> Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Auto-Submit: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#840621}
-
Daniel Murphy authored
This flag is used by developers for automated webapp testing. Extending the life, and re-assigning myself as owner. Bug: 1159277 Change-Id: Ib10f09aa4deaa1bdb3de8a3ced87053dab37e6cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612487Reviewed-by:
Dominick Ng <dominickn@chromium.org> Auto-Submit: Daniel Murphy <dmurph@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#840620}
-
Nancy Wang authored
The new ModifyWindowInfo function will be used by FullRestoreSaveHandler::SaveWindowInfo in CL:2597519 to modify and save the window information for the restore data. Modify the unit tests to verify the window info modification function. Move the position of the AppRestoreData constructor function, and the field restore_bounds name to consistent with the WindowInfo structure. BUG=1146900 Change-Id: I0e5755ffdf966d29139be67bf9a9a00a981c7df6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598084Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#840619}
-
Dave Tapuska authored
This is a reland of crrev.com/3da5569e with a rename of the class PepperPluginInstance to PepperPluginInstanceHost on the browser side. The two classes named the same caused vtable confusion on the debug build and the browser side class was getting called from the renderer code. Naming the classes separately avoids this confusion. This adds some base plumbing for pepper plugin instance handling. The pepper renderer code allocates and manages the PepperPluginInstanceImpl, this creates the correct encapsulation moving code out of RenderFrameImpl. On the browser side a PepperPluginInstance is created to handle the messages and relay them to the WebContentsImpl which use to handle the processing of Pepper messages. BUG=1157519 Change-Id: I45b238ce76bde0db35a9fd74baddb04333ebb593 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611047Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#840618}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6a718c4e909e..cdde253e4082 2021-01-06 brianosman@google.com Runtime effects: Disallow bitwise ops and integer remainder If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC johnstiles@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: johnstiles@google.com Change-Id: I3faedde605dc07b783aabde49d1b9cf387ec2839 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613109Reviewed-by:
-
Joshua Pawlicki authored
Also introduces an in-process test server. Also increases logging levels on the mac server. Also adjusts NSUserDefaults domain to allow test and app code to communicate. Bug: 1142591, 1119857 Fixed: 1142591, 1119857 Change-Id: Ic4f2f16924aba95a01186f07f488a0e49322fd87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518214 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#840616}
-
Ian Clelland authored
As part of removing the ExperimentalProductivityFeatures flag, the current experimental Permissions and Document Policy features are moved to a single new flag, introduced here as ExperimentalPolicies. Change-Id: Ib395cd9a1d54e727749cbcfaca1e905608c65a8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601056 Commit-Queue: Ian Clelland <iclelland@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#840615}
-
Ewann authored
This CL defines what we consider to be a small device. Bug: 1152730, 922511 Change-Id: I9b7fad0b45c20f823cf1655483b5c8ccff3ccfcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600902Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Cr-Commit-Position: refs/heads/master@{#840614}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202101060600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/-wDCr73uudKYVUOYqQJOHIYQHhh7Luoz49wve50i6eoC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/175639859 Tbr: media-app@grotations.appspotmail.com Change-Id: I0639043c9f5afa2460a962ef7a4cb61ba9437576 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613164Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/382bf2883fa9..8ef860714479 2021-01-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from ff29e249d317 to b9e179f1f239 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Change-Id: I59738c83be4c47ab458c99207f3c352a0ea9d9c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613006Reviewed-by:
-
Morten Stenshorne authored
This reverts commit 9b04f2c2. Reason for revert: Most likely broke AppControllerProfilePickerBrowserTest.LockedProfileReopenWithNoWindows on Mac 10.11 https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/59140 Original change's description: > [profiles] The profile picker supports the force signin policy > > This CL removes the restriction that disables the profile picker if the > force signin enterprise policy is enabled. > > Force signin dialogs will be hosted by the profile picker if the > corresponding feature is enabled. > > Bug: 1156096 > Change-Id: I19ec58afc7a451fbd868eae5e3d8d13899e78719 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595412 > Reviewed-by: David Roger <droger@chromium.org> > Commit-Queue: Alex Ilin <alexilin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840575} TBR=droger@chromium.org,alexilin@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I698a89a9214fd179994706d40ae58498cff4b9c7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1156096 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611270Reviewed-by:
-
cfredric authored
Bug: 1143756 Change-Id: Iedb06734ee09b9529f80952370f238df25110a83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611584 Commit-Queue: Chris Fredrickson <cfredric@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#840610}
-
Tanmoy Mollik authored
FeedSurfaceMediator and ChromeBackupWatcher Replace IdentityManager.Observer.(onPrimaryAccountSet/Cleared) calls with onPrimaryAccountChanged call. Bug: 1158855 Change-Id: Ic9233c925b36188c7c52e183c52bed9044d86cc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603575 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#840609}
-
Stephen Nusko authored
each of these are failing 10% of runs for mac-arm_dtk_arm-perf. Bug: 1163528 Change-Id: I367ced10531dc3cb374170ffcb484dc98567ec35 Cc: mythria@chromium.org,tmrts@chromium.org No-Try: True Tbr: johnchen@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611954Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Commit-Queue: Stephen Nusko <nuskos@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#840608}
-
Monica Basta authored
This CL adds the edit avatar button in the local profile creation flow. Bug: 1162443 Change-Id: Ie6b9c1907dde8fbd5609ab28b77cace32ff69b18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607305 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
-
WangHui authored
Rename *_web_view.h/cc to *_webview.h/cc to be consistent with other file styles and some code cleanup. Bug:None Change-Id: I782ac7c4d20943e48fb98366b611675f8a6575ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602972 Commit-Queue: HuiWang <wanghui210@huawei.com> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#840606}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I49da68522ed2dee1ce23aa81c39ee13d24e9859f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613004Reviewed-by:
-
Zach Kirschenbaum authored
This reverts commit 0ec4e032. Reason for revert: so in the reland, we can remove NOTREACHED Original change's description: > Revert "[fuchsia] handle RetrySystemUpdate reboot reason" > > This reverts commit 394a78b4. > > Reason for revert: this breaks something > > Original change's description: > > [fuchsia] handle RetrySystemUpdate reboot reason > > > > In this change, we add support for RetrySystemUpdate. Also, we stop > > mapping `RebootSource::OTA` to `StateControlRebootReason::SystemUpdate` > > because reboots for system updates should only be called from > > fuchsia.git -- the code we remove isn't being run anyway. > > > > BUG=fuchsia:64591 > > TEST=cast_reboot_unittests > > > > Change-Id: Ic15f86d31d3985d2fa5a2a3957c5ca61066cd476 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600053 > > Reviewed-by: Sergey Volk <servolk@chromium.org> > > Commit-Queue: Zach Kirschenbaum <zkbaum@google.com> > > Cr-Commit-Position: refs/heads/master@{#838871} > > TBR=spang@chromium.org,servolk@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,zkbaum@google.com > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: fuchsia:64591 > Change-Id: I9a2dd0fe105b1750c733925a8320a2f4e71cded2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611448 > Reviewed-by: Sergey Volk <servolk@chromium.org> > Commit-Queue: Zach Kirschenbaum <zkbaum@google.com> > Cr-Commit-Position: refs/heads/master@{#840361} TBR=spang@chromium.org,servolk@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,zkbaum@google.com Bug: fuchsia:64591 Change-Id: I4d6fffa0df883dbb6dae6add7f8e81aedcd0a95c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611526 Commit-Queue: Zach Kirschenbaum <zkbaum@google.com> Reviewed-by:
Sergey Volk <servolk@chromium.org> Cr-Commit-Position: refs/heads/master@{#840604}
-
Morten Stenshorne authored
This reverts commit 20ec4591. Reason for revert: StartupTracingTest failures. https://ci.chromium.org/p/chromium/builders/ci/win-asan/16653 Original change's description: > Reland "[tracing] Align --trace-startup and --enable-tracing." > > This is a reland of 0823dbae > > Original change's description: > > [tracing] Align --trace-startup and --enable-tracing. > > > > Use StartupTracingController both for --trace-startup (primary use case: > > browser startup perf profiling) and --enable-tracing (primary use case: > > browser test tracing). > > > > Due to historical reasons both flags are kept, but now their behaviour > > is mostly the same. If both are present, --trace-startup takes > > precedence. > > > > Differences: > > - `trace-startup` finishes after 5 seconds by default, while `enable-tracing` > > continues until the browser is closed. (--trace-startup-duration overrides > > both). > > - `trace-startup-file` always treats the path as absolute, while if > > `enable-tracing-output` ends with /, it uses the provided value as the > > directory and generates the base name based on the current runtime > > metadata. > > > > R=skyostil@chromium.org,eseckler@chromium.org > > BUG=1157954 > > > > Change-Id: Ia76316aa8927b431784e2fb94c8e42e4e2c0b479 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589834 > > Reviewed-by: Nasko Oskov <nasko@chromium.org> > > Reviewed-by: Eric Seckler <eseckler@chromium.org> > > Commit-Queue: Alexander Timin <altimin@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#839992} > > TBR=skyostil@chromium.org,eseckler@chromium.org,nasko@chromium.org > > Bug: 1157954 > Change-Id: Ic16992026beebddea39c8a6b247b4301512057e9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609139 > Commit-Queue: Alexander Timin <altimin@chromium.org> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840015} TBR=nasko@chromium.org,skyostil@chromium.org,altimin@chromium.org,eseckler@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1157954 Change-Id: Icfe2c800d65223f4b603370e1a7f50c2ee01283b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611268Reviewed-by:
-
Sebastien Lalancette authored
Bug: 1110944 Change-Id: I83d2e15de5ef086c86a55c064159e7b75c69e251 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611049Reviewed-by:
-
Mihai Sardarescu authored
Methods OnPrimaryAccountSet/Cleared() are deprecated, so this CL changes the chrome/browser/password_manager/* to override the method OnPrimaryAccountChanged(). Bug: 1163126 Change-Id: I5d3439b94ef7214debf58439c46078b70dbfc305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611245Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Auto-Submit: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#840601}
-
Ulan Degenbaev authored
Change-Id: Ic9c6c58d324f93cfab923b45200eec9131732fd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612995Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#840600}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/74f1b6be4a91..c6345ca36de9 2021-01-06 emacs.nolkaf@hilbrich.tk * meson.build: Fix 'png' build option (#59458). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: Ieb07820ab0fea8a203a59bc8cfd5b207b83faadc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612804Reviewed-by:
Ben Wagner <bungeman@chromium.org> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#840599}
-
Alex Ilin authored
Keep the picker disabled on startup until: - multiple profiles were used in the last 28 days, or - the picker has been shown once A new prefs::kBrowserProfilePickerShown pref is added to track whether the picker has been shown before. Bug: 1063856 Change-Id: Ia35a3b2212b3811ed592d81fa516bc1ffc07accc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598848 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
-
Peng Huang authored
* Fix tiling problem in OutputPresenterX11 * Do not handle IdleNotify event, since we will always wait on the x11 fence before reusing the buffer. Bug: 1153156 Change-Id: I308e9f7346c8fea5ba5939e4c3fe17b733e7e535 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596104Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#840597}
-
Robbie Gibson authored
When the thumb strip is in peeked state (horizontal tab thumbnails), switching tabs should not close the thumb strip. Bug: 1155211 Change-Id: I8b6e7312af391538dbea155a10433e8ade9d01fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600983 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#840596}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1609912549-c91a8fa5efe894cd1dbcbf24f242fd8e4fea7dac.profdata to chrome-linux-master-1609934346-e8075e70051f1cf5498240cc23c791e5411fb4de.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I613b247379325e578df949111ba1e50e6797eb28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611880Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1609912549-27b0371d28f026dcf49b02c005becd8eabbb3dbd.profdata to chrome-mac-master-1609934346-5c74c9288bb90a2547279b7951f6e0eb771b0f27.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic166f33b3cd934c7f9556b6066553a0e633fbf38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611879Reviewed-by:
-
Ben Mason authored
This reverts commit 2a3f2a4e. Reason for revert: Suspected build failure: crbug.com/1163418 Original change's description: > Not link ANGLE statically on Android for stable and beta channels > > Bug: 1161513 > Change-Id: Ia0a82f44b878dbcb7589a2aec9ec597ff517660b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600390 > Reviewed-by: Zhenyao Mo <zmo@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Peng Huang <penghuang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840191} TBR=penghuang@chromium.org,zmo@chromium.org,kbr@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: If804b48a0b27fe6873fcdeafa3ca7530027348a0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1161513 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610922Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#840593}
-
Stephen Nusko authored
This reverts commit 30d16f41. Reason for revert: crbug/1163513 android perf build is broken due to missing module six. Original change's description: > Roll Catapult from de6e3a9d85af to 6c876045de14 (1 revision) > > https://chromium.googlesource.com/catapult.git/+log/de6e3a9d85af..6c876045de14 > > 2021-01-05 jbudorick@chromium.org devil: make devil_env_test pass under py3. > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/catapult-autoroll > Please CC matthewdeluca@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Bug: chromium:1007101 > Tbr: matthewdeluca@google.com > Change-Id: I2e0359bddda1f8287cfd881439299926ad0fc2e0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611890 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#840364} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,matthewdeluca@chromium.org Change-Id: I85025d04a0f56ef302e06b658a2da6c66a9ff61c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1007101 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612520Reviewed-by:
-
