GitLab

Revert of mac: Fix tab dragging visual bug in Yosemite. (reland) (https://codereview.chromium.org/393933003/)

Reason for revert:
Broke TestActivate and TestFullscreen on Mac 10.6 Tests (http://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests%20%282%29/builds/53658)

Original issue's description:
> mac: Fix tab dragging visual bug in Yosemite. (reland)
> 
> -----------------Reland Description------------------
> Core animation was turned on in M35. The fullscreen window was not layer
> backed, but should have been. This original CL exposed this bug.
> 
> -----------------Original Description------------------
> In OSX 10.10+, all views must be added to the NSWindow's contentView. Some
> views (like the tab strip and the profile icon) are placed on top of the title
> bar and require special treatment. All other views are added as subviews of
> 'chromeContentView' in TabWindowController. This allows tab dragging and
> fullscreen logic to easily move the views that don't need special treatment.
> 
> This CL also removes the instances where a VersionIndependentWindow's
> contentView gets replaced by setContentView:. Instead, the 'chromeContentView'
> gets passed around as a subview. This allows VersionIndependentWindow to remove
> another of its internal hacks.
> 
> Original CL link: https://codereview.chromium.org/379293003/
> BUG=392239
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283456

TBR=andresantoso@chromium.org,shess@chromium.org,erikchen@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=392239

Review URL: https://codereview.chromium.org/398903003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283563 0039d316-1c4b-4281-b951-d872f2087c98

R=sky@chromium.org

Review URL: https://codereview.chromium.org/398023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283562 0039d316-1c4b-4281-b951-d872f2087c98

R=sky@chromium.org

Review URL: https://codereview.chromium.org/392253004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283561 0039d316-1c4b-4281-b951-d872f2087c98

Add flags from debian/rules, and disable assembly modules.

BUG=344505, 313751, 389216
TBR=glider@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/393023010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283560 0039d316-1c4b-4281-b951-d872f2087c98

In particular on the Swarming bots.

R=dbeam@chromium.org
BUG=376299
NOTRY=true

Review URL: https://codereview.chromium.org/398113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283559 0039d316-1c4b-4281-b951-d872f2087c98

Added combined shadow assets used by the class ui::wm::Shadow and remove the unneeded
assets for individual shadow patches.

BUG=377319
TEST=run 1.0x, 1.25x and 2.0x scale factor and verify all shadows are rendered correctly.
R=ccameron@chromium.org, oshima@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/385123005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283558 0039d316-1c4b-4281-b951-d872f2087c98

gpu: Update CHROMIUM_copy_texture.txt to reflect that GL_TEXTURE_RECTANGLE_ARB is a supported source target.

BUG=366710
TBR=piman@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/395213002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283557 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

Review URL: https://codereview.chromium.org/388053003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283556 0039d316-1c4b-4281-b951-d872f2087c98

Also sorted css rules for dots.

BUG=375191
NOTRY=true

Review URL: https://codereview.chromium.org/397543003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283555 0039d316-1c4b-4281-b951-d872f2087c98

BUG=160586

Review URL: https://codereview.chromium.org/383263005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283554 0039d316-1c4b-4281-b951-d872f2087c98

This allows to remove weak pointers between different WebContents,
and pointer from DevToolsController to WebContents of DevToolsWindow.
The latter one proved to be stale sometimes and caused crashes.

Once bug 392031 is resolved, AllowOtherViews can be removed.

BUG=392914,392917,392971,392031

Review URL: https://codereview.chromium.org/388803003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283553 0039d316-1c4b-4281-b951-d872f2087c98

First phase of extending the relocation packer for arm64.

Upgrade logging to be streams-based.  Add new unit tests to cover logging
and checking features.  Mechanical changes to logging call sites.

Also correct a type promotion issue that causes incorrect DT_RELCOUNT
adjustments when the packer is compiled as a 32-bit Linux binary.

BUG=385553

Review URL: https://codereview.chromium.org/392653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283552 0039d316-1c4b-4281-b951-d872f2087c98

This will help ASan reports appear on stderr when content_shell is run from CMD.exe console or on ClusterFuzz

See also http://crrev.com/275067 where the same was applied to chrome.exe

BUG=345874

Review URL: https://codereview.chromium.org/394853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283551 0039d316-1c4b-4281-b951-d872f2087c98

BUG=367239
TBR=toyoshim

Review URL: https://codereview.chromium.org/397623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283550 0039d316-1c4b-4281-b951-d872f2087c98

This is a follow-up to https://codereview.chromium.org/337053005.

BUG=224596

Review URL: https://codereview.chromium.org/392233003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283549 0039d316-1c4b-4281-b951-d872f2087c98

This is the duplicate of https://codereview.chromium.org/373043003. The bubble turned to be unresponsive on Windows. This CL has a workaround. The original problem is in infrastructure. It's to be fixed in  BubbleDelegateView.
set_use_focusless(true) has adverse effect on Windows.
1) The bubble can't be the active window (which is not desired behavior).
2) The bubble doesn't get WM_LBUTTONDOWN event. Therefore, all the buttons get stuck.
We call set_use_focusless(false) after the bubble is shown. Thus, it can get focus and mouse events properly.

BUG=383821

Review URL: https://codereview.chromium.org/396973002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283548 0039d316-1c4b-4281-b951-d872f2087c98

SymbolizationLoop.process_line() has been factored out and can now be used to symbolize the reports line by line.

BUG=235466
NOTRY=true

Review URL: https://codereview.chromium.org/397983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283547 0039d316-1c4b-4281-b951-d872f2087c98

In order to track UMA accurately we only need to track it when there is an actual prompt for permission, not when the permission was saved for the domain. I have re-purposed the PermissionDecided method for this which was essentially doing nothing before.

BUG=392145
TBR=fgorski,tommi

Review URL: https://codereview.chromium.org/371933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283546 0039d316-1c4b-4281-b951-d872f2087c98

The previous code writes the parsed metadata to |metadata| dictionary
remembered in |this.rootParser_|, but this is wrong.

The parser class is shared among multiple parses, so to correctly
distinguish concurrent parsing activity, it cannot store states
in the member fields.

BUG=172989

Review URL: https://codereview.chromium.org/391313003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283545 0039d316-1c4b-4281-b951-d872f2087c98

|willRequestAfterPreconnect| was removed from blink::WebFrameClient at
blink r178134, thus this override is never called.

BUG=386888

Review URL: https://codereview.chromium.org/395093002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283544 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283543 0039d316-1c4b-4281-b951-d872f2087c98

(This is a much larger change than its diff suggests. If it breaks something, please revert first and ask questions later.)

R=davidben@chromium.org, eroman@chromium.org, rsleevi@chromium.org

Review URL: https://codereview.chromium.org/345063006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283542 0039d316-1c4b-4281-b951-d872f2087c98

video_decoder_shim.cc uses libyuv, and the build fails if we're not
building in component=shared_library mode and enable_webrtc=0:

In file included from ../../third_party/libyuv/include/libyuv.h:15:0,
                 from ../../content/renderer/pepper/video_decoder_shim.cc:25:
../../third_party/libyuv/include/libyuv/compare.h:14:32: fatal error: libyuv/basic_types.h: No such file or directory
 #include "libyuv/basic_types.h"
                                ^

R=dmichael@chromium.org, bbudge@chromium.org

Review URL: https://codereview.chromium.org/393813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283541 0039d316-1c4b-4281-b951-d872f2087c98

Doing some sorting and splitting of data to make large amounts
of changes easier to study.

BUG=

Review URL: https://codereview.chromium.org/375063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283540 0039d316-1c4b-4281-b951-d872f2087c98

The home-card can be in a minimized state. In this state, only a narrow line
is displayed at the bottom of the screen, and dragging it up shows the overview
mode. When a window is selected in the overview mode, the home-card is minimized
again.

BUG=381224
R=mukai@chromium.org, oshima@chromium.org

Review URL: https://codereview.chromium.org/394043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283539 0039d316-1c4b-4281-b951-d872f2087c98

Before, the FakeProvidedFileSystem had some hardcoded responses. However, since
FileStreamWriter is coming soon, we will need to verify if the file on the
file system is changed correctly.

For that, FakeProvidedFileSystem has been refactored, so it is possible to add
and get fake files and verify their values.

TEST=unit_tests: *FileSystemProvider*
BUG=391362

Review URL: https://codereview.chromium.org/393233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283538 0039d316-1c4b-4281-b951-d872f2087c98

split off from https://codereview.chromium.org/388963002/

BUG=160586

Review URL: https://codereview.chromium.org/390183003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283537 0039d316-1c4b-4281-b951-d872f2087c98

https://codereview.chromium.org/385553002/ uses BackoffEntry, but it requires a lot of changes, so it probably won't be merged to M37. I suggest to merge this small fix.

BUG=377725
TEST=manual

Review URL: https://codereview.chromium.org/383183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283536 0039d316-1c4b-4281-b951-d872f2087c98

Enables most of compiler warning on ASan build.

BUG=162783

Review URL: https://codereview.chromium.org/391743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283535 0039d316-1c4b-4281-b951-d872f2087c98

When only image is opened then on long press context menu appears.
From context menu on selection of "open image" page reloads which
does not make sense.Added condition to hide option "open image"
if page url and image url for which context menu appears is same.

BUG=270682

Review URL: https://codereview.chromium.org/396063009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283534 0039d316-1c4b-4281-b951-d872f2087c98

Adding component/auto_login_parser/BUILD.gn.

TBR=jochen

Review URL: https://codereview.chromium.org/382943003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283533 0039d316-1c4b-4281-b951-d872f2087c98

BUG=329247

Review URL: https://codereview.chromium.org/393803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283530 0039d316-1c4b-4281-b951-d872f2087c98

Selecting the "Cached images and files" in the Clear Browsing Data
dialog will now remove all idle ephemeral apps.

BUG=392007
TEST=browser_tests

Review URL: https://codereview.chromium.org/383703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283529 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283528 0039d316-1c4b-4281-b951-d872f2087c98

Port QueryHistoryAndBookmarks and QuerySearchTerms methods to use
CancelableTaskTracker instead of CancelableRequestConsumer.

BUG=371818

Review URL: https://codereview.chromium.org/369673009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283527 0039d316-1c4b-4281-b951-d872f2087c98

BUG=393019
NOTRY=true

Review URL: https://codereview.chromium.org/394593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283526 0039d316-1c4b-4281-b951-d872f2087c98

X11 implementation of PlatformWindow does not correctly process XInput2
yet. So do not listen for mouse-events there.

BUG=none
R=sky@chromium.org

Review URL: https://codereview.chromium.org/394323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283524 0039d316-1c4b-4281-b951-d872f2087c98

Apps&Extensions for supervised users: Add Extension::WAS_INSTALLED_BY_CUSTODIAN flag and proto entry.

Currently, supervised users can not use Apps/Extensions at all. In the future, their custodian will be able to remotely install Apps/Extensions for them. This CL introduces a new extension flag and corresponding proto entry that marks these extensions, so we can allow only those in the client.

Relevant design doc section: https://docs.google.com/a/google.com/document/d/1rqahhrErR_HiZ04v-Skb_kvXeyOfnTvBPFvKwAxuf10/edit#heading=h.ptivtbjwlda5

BUG=390520

Review URL: https://codereview.chromium.org/353493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283522 0039d316-1c4b-4281-b951-d872f2087c98

google
infobars
invalidation
navigation_intercaption
network_time
password_manager
plugins
search_provider_logos
sessions

R=viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/397953005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283521 0039d316-1c4b-4281-b951-d872f2087c98

BUG=245926
TEST=manually

Review URL: https://codereview.chromium.org/395083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283519 0039d316-1c4b-4281-b951-d872f2087c98