- 21 Sep, 2018 40 commits
-
-
Sam McNally authored
Bug: 854481 Change-Id: I090cd08474d41793b7a03b7d363d523b8a06c432 Reviewed-on: https://chromium-review.googlesource.com/1238034 Commit-Queue: Sam McNally <sammc@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#593096}
-
Taiju Tsuiki authored
This reverts commit ef4667cb. Reason for revert: This causes an MSan test failure on ProfileChooserViewExtensionsTest. Logs are: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20MSan%20Tests/11695 https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8934841590894310960/+/steps/browser_tests/0/logs/ProfileChooserViewExtensionsTest.InvokeUi_Guest/0 Original change's description: > Remove IsLegacySupervised() obsolete API > > Since legacy supervised users are unsupported assume any call returns false > and simplify the code accordingly. IsSupervised() calls are for now not affected > > Signed-off-by: Guido Trotter <ultrotter@chromium.org> > Bug: 882802 > Change-Id: Id2f382aed0f919970dde46544bfacadde9247935 > Reviewed-on: https://chromium-review.googlesource.com/1233577 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Dan Erat <derat@chromium.org> > Cr-Commit-Position: refs/heads/master@{#592845} TBR=avi@chromium.org,derat@chromium.org,dcheng@chromium.org,poromov@chromium.org,jochen@chromium.org,ultrotter@chromium.org Change-Id: I6c65d4272d36389d1b65e507cc135a77bb99a4e9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 882802 Reviewed-on: https://chromium-review.googlesource.com/1238113Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#593095}
-
Sam McNally authored
https://crrev.com/591294 removed the code for Drive apps, removing three API endpoints. The URL generator methods for those endpoints were left behind. Remove them as well as the option to use the internal endpoint; no remaining Drive API usage requires using the internal endpoint. Bug: 826090 Change-Id: I99a0a60b3b9862d6a399b083d882b9a947cafc78 Reviewed-on: https://chromium-review.googlesource.com/1236617Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#593094}
-
Sam McNally authored
Bug: 854481 Change-Id: I3c6fd0ed9eb32410cde74b940bedf4cd1323bea7 Reviewed-on: https://chromium-review.googlesource.com/1235492 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#593093}
-
Byoungkown authored
After adding "use_jumbo_build=true" args in GN, jumbo build can be enable. Bug: 869381 Change-Id: Ic6af47b97a7a6b1e39508d9c757bb83bab01b194 Reviewed-on: https://chromium-review.googlesource.com/1204371Reviewed-by:
Adrienne Porter Felt <felt@chromium.org> Commit-Queue: Byoungkwon Ko <codeimpl@gmail.com> Cr-Commit-Position: refs/heads/master@{#593092}
-
Sergei Datsenko authored
Bug: None Change-Id: Ia4bf1985967999b9542a6ba172eccd6f3007aabb Reviewed-on: https://chromium-review.googlesource.com/1237900Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#593091}
-
Anand K. Mistry authored
This fixes up includes to follow Chromium style, and follow IWYU. BUG=None Change-Id: I18c6170bc7746a57d7edcb796961056717ce8966 Reviewed-on: https://chromium-review.googlesource.com/1237800Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#593090}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/82e0e444a5c5..05cf051f0252 git log 82e0e444a5c5..05cf051f0252 --date=short --no-merges --format='%ad %ae %s' 2018-09-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 52ea49706fd7..a977acc85769 (2 commits) Created with: gclient setdep -r src/third_party/skia@05cf051f0252 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@chromium.org Change-Id: I3d2dac58787e819b93c428d69ddd4a7fb351821a Reviewed-on: https://chromium-review.googlesource.com/1237814Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593089}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2133ff9907da..036176db7c24 Created with: gclient setdep -r src-internal@036176db7c24 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie45b8ee44853588587e2bcaa2f1ffa39b47deedb Reviewed-on: https://chromium-review.googlesource.com/1237815Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593088}
-
John Delaney authored
Record the size of ad resources according to MIME type. This will help us understand which resources are using up more network bytes and allow us to better estimate the effect any ad intervention will have. Only HTML/JS/CSS/Image/Video are recorded as they are expected to capture most of the resources commonly seen in ads. It is expected that these metrics will not be completely accurate because requests do not always contain the correct content type. It is assumed that the MIME type in the response header is a suitable proxy resource type. Bug: 881049 Change-Id: I000466fb3fe5467c4f73527cb4cedbd7709d7c3f Reviewed-on: https://chromium-review.googlesource.com/1219900 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#593087}
-
Taiju Tsuiki authored
This reverts commit 22a72b84. Reason for revert: KeyboardEndToEndFormTest.NavigateToNewPageWithAutoFocusShowsKeyboard is failing on the bot. Logs are: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/7919 https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8934817998655936048/+/steps/browser_tests/0/logs/KeyboardEndToEndFormTest.NavigateToNewPageWithAutoFocusShowsKeyboard/0 Original change's description: > [VK] Add browser tests for navigation. > > There are some rules for showing/hiding the virtual keyboard when > navigating to a new page / tab. Added some tests to make sure we don't > regress these scenarios. > > Bug: 849995 > Change-Id: I2fee098943b6073a0d1c1f8b86cdf1a3b35455e5 > Reviewed-on: https://chromium-review.googlesource.com/1233097 > Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> > Commit-Queue: Darren Shen <shend@chromium.org> > Cr-Commit-Position: refs/heads/master@{#593007} TBR=yhanada@chromium.org,shend@chromium.org Change-Id: If842c48eea3a0e45b936a5b9ba3d47faeb21fb9f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 849995 Reviewed-on: https://chromium-review.googlesource.com/1237898Reviewed-by:
-
Taiju Tsuiki authored
This reverts commit 50439b88. Reason for revert: Mac bots start failing after this CL on HungRendererControllerTest. The error logs are below. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/29038 https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8934838111834185888/+/steps/unit_tests_on__none__GPU_on_Mac_on_Mac-10.11/0/logs/HungRendererControllerTest.TestKillButton/0 Original change's description: > mac: Remove unused TabDialogsMac/TabDialogsCocoa. > > Bug: 832676 > Change-Id: I0fb8d4b1f0197dab0b988a52741724f63a18ee9f > Reviewed-on: https://chromium-review.googlesource.com/1236178 > Commit-Queue: Nico Weber <thakis@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#592819} TBR=ellyjones@chromium.org,thakis@chromium.org Change-Id: I6554e741ef31bc99da0c90e3c4fd2bb8826a741f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 832676 Reviewed-on: https://chromium-review.googlesource.com/1237797Reviewed-by:
-
Mustafa Emre Acer authored
Bug: 870038 Change-Id: I856efd083382cb27f01ea37abbfcbb04941ec0c4 Reviewed-on: https://chromium-review.googlesource.com/1176582 Commit-Queue: Adrienne Porter Felt <felt@chromium.org> Reviewed-by:
-
Chris Lu authored
While the app is clearing browsing data, web usage is not enabled. So to prevent CHECK crash, return nil when StaticHtmlNativeContent is not presenting web content. Bug: 857199 Change-Id: I76320563f3237198e29c508c01e6c8df51da6a9c Reviewed-on: https://chromium-review.googlesource.com/1237404 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#593083}
-
Devlin Cronin authored
A few of the name values for the menu entries in the ExtensionContextMenuModel were a little misleading. Remap the following (<old> -> <new>): - NAME -> HOME_PAGE (opens the extension's home page, or the webstore if a separate home page was not specified). - CONFIGURE - OPTIONS (opens the extension's options page) - MANAGE -> MANAGE_EXTENSIONS (opens the chrome://extensions page) No functional change is intended; this is purely a renaming of code values. Bug: None Change-Id: Iabac73bf3bd7d85ea02b23379a9a19eeef02cf21 Reviewed-on: https://chromium-review.googlesource.com/1229774Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#593082}
-
Kunihiko Sakamoto authored
Bug: 876968 Change-Id: Iae1f26e63a4c607b68f6cb85d2d46594a682a27c Reviewed-on: https://chromium-review.googlesource.com/1237793Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#593081}
-
Ryo Hashimoto authored
To prevent translation errors by making it clear that the display is not erased from some kind of list, but was disconnected from the device. BUG=None TEST=None Change-Id: I456db3b6492a7041b53413cffae0ca1ab9f360dc Reviewed-on: https://chromium-review.googlesource.com/1234075Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#593080}
-
Taiju Tsuiki authored
This reverts commit fce6f1f0. Reason for revert: Mac bots start failing after this on ZoomDecorationTest. Logs are: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/15388 https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8934822664204431200/+/steps/browser_tests_on__none__GPU_on_Mac_on_Mac-10.12.6/0/logs/ZoomDecorationTest.BubbleAtDefaultZoom__x2f_1/0 Original change's description: > mac: Remove unused cocoa bookmarks code. > > Bug: 832676 > Change-Id: I7a307c33ad6daf44cc2c170829f03cfdc488da4b > Reviewed-on: https://chromium-review.googlesource.com/1236177 > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Commit-Queue: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#592940} TBR=ellyjones@chromium.org,thakis@chromium.org,rsesek@chromium.org Change-Id: I5cee6336950065ba9ba0053334892092d2ebe308 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 832676 Reviewed-on: https://chromium-review.googlesource.com/1238033Reviewed-by:
-
Noel Gordon authored
This variable was added in [1] but the patch never used the variable, remove it. [1] https://goo.gl/Fnvppi (good read btw, explaining why file manager has many separate initialization steps). Bug: 887792 Change-Id: Ic9af3447382589bf27fc84fe7a6613c2a269d75d Reviewed-on: https://chromium-review.googlesource.com/1237894 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#593078}
-
Xianzhu Wang authored
Transform with perspective mapping sometimes doesn't work for cull rect. See the bug for details. Bug: 887558 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I4d2c086f957454c6cb90a8c679e7dc5b37b95c3f Reviewed-on: https://chromium-review.googlesource.com/1236660 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#593077}
-
John Abd-El-Malek authored
With https://chromium-review.googlesource.com/c/chromium/src/+/1235593, Gmail re-loads correctly after a network process crash. However if Gmail isn't reloaded or opened in a new tab, it still thinks it's disconnected because its subresource requests are failing. The problem is that ServiceWorkerSubresourceLoader::fallback_factory_ was a ChildURLLoaderFactoryBundle (which doesn't handle updating after crashes) instead of being a HostChildURLLoaderFactoryBundle (which is properly updated after a crash). Bug: 884007 Change-Id: I63d61811005a57f1a43ec91961fd5c5f5de5d0e8 Reviewed-on: https://chromium-review.googlesource.com/1237720Reviewed-by:
-
Charles Zhao authored
EquivToProtoLite compares two Message or MessageLite by comparing each subfield. Bug: 884140 Change-Id: Ic9ecf9497a6beafd0c739134fe25f506b618527f Reviewed-on: https://chromium-review.googlesource.com/1236015Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Charles . <charleszhao@chromium.org> Cr-Commit-Position: refs/heads/master@{#593075}
-
Weilun Shi authored
Using percentage width instead of constant number width for the collection/image tiles. Leaving one percent width for the scrollbar. Screencast: https://screencast.googleplex.com/cast/NDYwMjgyNjA0NzA5NDc4NHxmNTgxMjYyOC0yNQ Bug: 874742 Change-Id: I54f303a3ec294502669b26f0a6d31388e67b35dc Reviewed-on: https://chromium-review.googlesource.com/1237515Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#593074}
-
Alan Cutter authored
This CL makes HostedAppOpaqueBrowserFrameViewTest force enable Mac Views to fix a crash on mac-cocoa-rel. Bug: 885164 Change-Id: I8cd754954c9119a65c8aca94b7a07f2159e3f95d Reviewed-on: https://chromium-review.googlesource.com/1237733Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#593073}
-
Stuart Langley authored
This adds a "drive/Computers" folder to ResourceMetadata, so that we should always have a valid path for the top level Computers folder regardless of the sync engine being used. This makes it easier on the UI side as we do not need to special case any handling for sync engine, and if we do not find a "drive/Computers" path than we can treat it as a real error. Bug: 884020 Change-Id: Ib30e65a00f7e9e62ceb89b47715f591ffba9e041 Reviewed-on: https://chromium-review.googlesource.com/1237016Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#593072}
-
Justin DeWitt authored
This implements a periodic background task that attempts to fetch the Explore Sites catalog approximately daily. Fetch implementation is left to a future CL, as is initiating the background task. Bug: 867488 Change-Id: I808a7bacd9f20c3c1dbcaf84acd413eb7353c644 Reviewed-on: https://chromium-review.googlesource.com/1236506Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#593071}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/6f7c60dde99f..15abb5c68f71 git log 6f7c60dde99f..15abb5c68f71 --date=short --no-merges --format='%ad %ae %s' 2018-09-21 dtu@chromium.org [pinpoint] Fix clipping on stats page duration histograms. Created with: gclient setdep -r src/third_party/catapult@15abb5c68f71 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:887168 TBR=sullivan@chromium.org Change-Id: I2615e7a3b726218680731a9f0bcd4dbe1128d002 Reviewed-on: https://chromium-review.googlesource.com/1237476Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/38801cf97996..2133ff9907da Created with: gclient setdep -r src-internal@2133ff9907da The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Iad9b25c8a9f9613ef6b3e85bb97d25f2d43eba28 Reviewed-on: https://chromium-review.googlesource.com/1237813Reviewed-by:
-
Noel Gordon authored
Call DOMContentLoaded directly. Update comments. Bug: 887792 Change-Id: Ib688e8dda1b74ff065e91a980099050ca19cb8a4 Reviewed-on: https://chromium-review.googlesource.com/1237018Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7ea977bc5e41..82e0e444a5c5 git log 7ea977bc5e41..82e0e444a5c5 --date=short --no-merges --format='%ad %ae %s' 2018-09-21 brianosman@google.com Remove a largue quantity of 4444 and/or dithering code 2018-09-21 halcanary@google.com SkPDF: add SK_API to new public factory. Created with: gclient setdep -r src/third_party/skia@82e0e444a5c5 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@chromium.org Change-Id: Ie827a67ca65e21edc1ec98d6f5bade8d979dcbde Reviewed-on: https://chromium-review.googlesource.com/1237478Reviewed-by:
-
Andrew Moylan authored
This function makes a basic call using the ML Service client library. Doing this triggers the ML Service daemon to be started (via D-Bus service activation) and the D-Bus -> Mojo IPC bootstrap to occur. The VoidCallback is invoked when the basic call (LoadModel on the test model) completes successfully. Tested: - Ran it with a Chrome OS Tast test (testing successful bootstrap) - Added a test to the test.js covering the case of failure to connect to ML Service Bug: 836102 Change-Id: I509eab4a518a933109095eec1ece811bc30e4f99 Reviewed-on: https://chromium-review.googlesource.com/1229878Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Andrew Moylan <amoylan@chromium.org> Cr-Commit-Position: refs/heads/master@{#593066}
-
Han Leon authored
BUG= Change-Id: I9fbb5e4423d099e77c2b8c95dd9bc53d4eb90e36 Reviewed-on: https://chromium-review.googlesource.com/1234914Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#593065}
-
Tetsui Ohkubo authored
According to QA we still need notification border shadow on Win7 Aero. TEST=manual BUG=882826 Change-Id: Ia69a366188b595ff6e0c61c4b4f3c06a57c70580 Reviewed-on: https://chromium-review.googlesource.com/1233014 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#593064}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I786751498c62b52c02e17b2eba542b0e5b8705ce Reviewed-on: https://chromium-review.googlesource.com/1237873Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#593063}
-
Christian Biesinger authored
Also mark NGInlineBoxState as not heap allocated. R=kojii@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I0c605c6123cab202190e9415cc9cb9a81d0cd832 Reviewed-on: https://chromium-review.googlesource.com/1237237 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#593062}
-
Aldo Culquicondor authored
This wrapper allows to use the same macros for GL commands. They will make use of native GL or the command buffer, depending on the platform. Windows is the first platform to use the command buffer. All vr targets build for all platforms, but they fail to run on Windows, due to missing dependencies. These will be added in a followup CL. For now, disable the tests from the trybots. Bug: 884256 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I8802ea37a82cd29d4356e7d4601952077d20dd4a Reviewed-on: https://chromium-review.googlesource.com/1226028Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Cr-Commit-Position: refs/heads/master@{#593061}
-
Yiming Zhou authored
Bug: 847905 Change-Id: Ic8da3d3d2214a06cf0cc8a180d66a81fbc89ed90 Reviewed-on: https://chromium-review.googlesource.com/1214208 Commit-Queue: Yiming Zhou <uwyiming@google.com> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#593060}
-
yoshiki iguchi authored
There was the bug that a toast didn't get hidden if it was removed just after unlocking the screen. This bug had been introduced by http://crrev.com/b7c2ea2a2ca1fa8b7eb8aece0bee0a965735dcda. Toast changes the window container which it belongs to referring the current device lock status: locked or unlocked, because chrome os has different window containers for locked and unlocked desktop. That commit had changed the timing of changing the window container and that had caused the bug. We had the code not to hide a toast on animation, but that change had added an animation on the changing. This CL removes the code, since it is no longer necessary because the change timing was changed. Bug: 887800 Test: manual Change-Id: I2942227af9bc9eebb8c5881920341f25d68e91d5 Reviewed-on: https://chromium-review.googlesource.com/1235513 Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#593059}
-
Scott Chen authored
This CL adds a very basic landing page for the NUX onboarding experience. To test this CL, add --enable-features=NuxOnboardingForceEnabled. Current progress screenshot: https://imgur.com/a/2OBLbyq There will be follow-up CLs to make it look more like the mocks, as well as add other views for NUX. Bug: 874142 Change-Id: Ie643def26d657fadfbbf556dd03df7cddf5976cc Reviewed-on: https://chromium-review.googlesource.com/1235114 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#593058}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8c9d5d0fbbbc..38801cf97996 Created with: gclient setdep -r src-internal@38801cf97996 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I984ca0dd421f33bff7622d9c18d9d380bc02c77b Reviewed-on: https://chromium-review.googlesource.com/1237477Reviewed-by:
-
