- 07 Mar, 2019 40 commits
-
-
Nate Fischer authored
No change to production logic, only tests. The #setAcceptCookie() API should not expose already-set cookies via the "Cookie" header or via document.cookie. Current test coverage only checks WebView does not honor the Set-Cookie header or assignments to document.cookie. So, this adds a test to handle this case. This test does not work (yet) for the network service path, so this adds the test to the filter. This also removes an accidentally duplicated line in another test (which I observed while writing this one). R=tobiasjs@chromium.org Bug: 936317 Test: run_webview_instrumentation_test_apk \ Test: -f=CookieManagerTest.testAcceptCookie_falseDoNotSendCookies Cq-Include-Trybots: master.tryserver.chromium.android:android_mojo Change-Id: Ic0ed4b73d6f7fd2275438b63fc2c01a4d76d9c8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507282Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#638741}
-
Mitsuru Oshima authored
Added new uma stats to replace old stats: Event.DownEventCount.PerInputFormFactorDestinationCombination2 Bug: 926040 Test: Updated & added new test in PointerMetricsRecorder unittest. Change-Id: Ic2410100428c61bde1c780afd3ee6e04db376063 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1443459 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#638740}
-
Leonardo Padilha authored
Bug: 919132 Change-Id: I4db14c49af64028e4c72b493a7988f46d2369c16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509312Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Leonardo Padilha <ldaguilar@chromium.org> Cr-Commit-Position: refs/heads/master@{#638739}
-
Joe DeBlasio authored
This reverts commit bfa0a0c5. Reason for revert: Out of an abundance of caution as suspected actual culprit behind https://chromium-review.googlesource.com/c/chromium/src/+/1509333 Original change's description: > Cleanup Lookalike interstitial browser tests. > > This is a cleanup CL to add a few missing, and simplify existing, > interstitial tests. It also includes a few unaddressed nits from earlier > CLs. > > Bug: 927924 > Change-Id: Iaa177d8dfc69d127b6ba2af5c8f508d5e5d8db83 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497756 > Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> > Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> > Reviewed-by: Michael Wasserman <msw@chromium.org> > Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#638286} TBR=msw@chromium.org,meacer@chromium.org,jdeblasio@chromium.org Change-Id: Ie0b186fd3b3455c13eb1077cb134411416136da2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 927924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509463Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#638738}
-
Etienne Pierre-doray authored
TBR=rockot@chromium.org Bug: 939289 Change-Id: I86ad8878e2dcd97589425038fdf0ed2871252ee6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509492Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#638737}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/699655f07b93..eefd8e8457a3 git log 699655f07b93..eefd8e8457a3 --date=short --no-merges --format='%ad %ae %s' 2019-03-07 benjhayden@chromium.org Add report-controls for spa 2019-03-07 benjhayden@chromium.org Fix empty BatchIterator for spa. 2019-03-07 benjhayden@chromium.org Add a drawer to chromeperf-app 2019-03-07 benjhayden@chromium.org Add chart-timeseries for spa 2019-03-07 mattcary@chromium.org Devil: enable parsing a manifest from an android bundle. 2019-03-07 simonhatch@chromium.org Dashboard - Change Pinpoint stats to 7 days Created with: gclient setdep -r src/third_party/catapult@eefd8e8457a3 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:918193,chromium:918193,chromium:918193,chromium:918193,chromium:931269,chromium:924564 TBR=sullivan@chromium.org Change-Id: I97f6cef6717206bc26633301c1211187c02a0d29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509101Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638736}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/db5c5ade84ad..b139178fb593 git log db5c5ade84ad..b139178fb593 --date=short --no-merges --format='%ad %ae %s' 2019-03-07 vadimsh@chromium.org [lucicfg] Bump lucicfg version 1.3.2 -> 1.5.3. 2019-03-07 ehmaldonado@chromium.org Revert "Avoid unnecessary invocations of "git fetch"" Created with: gclient setdep -r src/third_party/depot_tools@b139178fb593 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:938627 TBR=agable@chromium.org Change-Id: I7f31f68119321b0b5b9966fb81cde4b98261cc7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509100Reviewed-by:
-
Kristi Park authored
Bug: 923563 Change-Id: I9b1b3b84f35a312deac8ad8b0b286d64c3b6b2a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1474674 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#638734}
-
Reid Kleckner authored
This aligns the chromium.clang waterfall swarming configuration with the configuration used for chromium.win. Use the 'win10' mixin as a shorter spelling for: 'swarming': { 'dimension_sets': { 'os': 'Windows-10-1503' } } } ... and use that on the CrWinASan bots, which are also all x64 bots. R=hans@chromium.org, thakis@chromium.org NOTRY=true Bug: 939003 Change-Id: I52d33f47b37c0973336695269a499ca9ad2373c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505894 Commit-Queue: Reid Kleckner <rnk@chromium.org> Reviewed-by:Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#638733}
-
Ella Ge authored
AverageLag are calculated from latency_info.scroll_update_delta. It was set from GestureScrollUpdate event's delta_y; however, scroll prediction is done after scroll_update_delta set, which means the AverageLag did not count in the prediction result. This CL adds setting the scroll_update_delta from GSU, so it will count in the prediction change as well. Bug: 836352 Change-Id: I979e0da617dbfdfa6735aee33958cb9dac9b8331 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509102Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#638732}
-
Erik Luo authored
In the Styles sidebar pane, user agent style sections: - Properties within an inherited section that do not contribute to the cascade (not inheritable) are hidden. - Non-matching selector pieces are hidden. The goal is to reduce visual noise in the UI without affecting style debugging. Screenshot: https://imgur.com/a/2s5wIn8 Bug: 929536 Change-Id: Icaea2edcbb8560273469605f263449edd51bade2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500775Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#638731}
-
Jeffrey Cohen authored
Bug: 910390 Change-Id: I87d9aa4751c6abb53a549ceabb57a55a5236efff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508924 Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#638730}
-
Leonard Grey authored
Bug: 931359 Change-Id: Id017e32692583f81fb30709bf7d26bb6bd2d731a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506560Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#638729}
-
Jared Saul authored
Change-Id: I54d188e1ddcc80aa9563934be7ac89470e00cadc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506449 Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by:
-
Etienne Pierre-doray authored
TBR=rockot@chromium.org Bug: 939037 Change-Id: I8124bcbbd54d5b4b3bebfa35d5bbca55443260d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509362Reviewed-by:
-
Khushal authored
TBR=piman@chromium.org Bug: 938765 Change-Id: Ic1c54b3a489fc056f43d7d2f353e418645a9d33c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508923Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#638726}
-
Jared Saul authored
Change-Id: Ic5b6943efaace6033d6adb9b665676f20990eb4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509135 Commit-Queue: Jared Saul <jsaul@google.com> Commit-Queue: Tommy Martino <tmartino@chromium.org> Auto-Submit: Jared Saul <jsaul@google.com> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#638725}
-
Takashi Toyoshima authored
Chrome Extensions can generate internal redirects in webRequest::onBeforeRequest event handler. See Life cycle of requests below. https://developer.chrome.com/extensions/webRequest Without OOR-CORS, WebRequestProxyingURLLoaderFactory generates virtual response for Blink, and Blink-CORS handles the redirects. Simply said, it rewrites the Origin header to be 'null' for cross-origin redirects. Detailed steps are: 1. A certain request is made by Blink. 2. webRequest::onBeforeRequest intercepts the request, and generates an internal redirect response with status 307. 3. Blink receives the generated response and Blink-CORS handles cross-origin redirects if it is needed, e.g. using Origin: null But, if OOR-CORS is enabled, Blink does nothing. Detailed steps are: 1. and 2. is ditto 3. Blink receives the generated response and Blink-CORS is disabled and does nothing. Just new request for the redirect is made. 4. The request is handled in NetworkService, with OOR-CORS. It sets Origin header for such cross-origin request, but the value is based on the request initiator's origin. So the proxy needs to craft its ResourceRequest so that the OOR-CORS can set a proper Origin header, null for such internal redirect cases. My approach in this patch set is: 1. Set null origin to the ResourceRequest.request_initiator to pretend the retained origin flag is set. See https://fetch.spec.whatwg.org/#concept-request-tainted-origin 2. But WebRequestInfo is initialized with copied ResourceRequest that has the original request_initiator. 2. is needed for webRequest events. See API document below. https://developer.chrome.com/extensions/webRequest#event-onBeforeRequest That says the initiator does not change through redirects. Following tests in ExtensionWebRequestApiTest.WebRequestBlocking failed if OOR-CORS is enabled without this patch. - crossOriginAnonymousRedirect() - crossOriginCredentialedRedirect() - syncXhrsFromOurselfAreInvisible() And this patch fixes them to pass. Bug: 909633 Change-Id: I755db213256605c72015ab21c845e649bc35e319 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503273 Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#638724}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d926e1bf. With Chromium commits locally applied on WPT: 68d5240e "[ChromeDriver] Set key modifiers with mouse actions" 682affef "Implemented setPlaybackRate for scroll-linked Worklet Animations." 2b037bdc "[Animation Worklet] Fix flaky worklet-animation-with-fill-mode.https.html" fc735f1b "[IndexedDB] Fixed DisjointRangeLockManager usage in IndexedDB" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I06207a2c52a93d333c3c9c3be0553342aca12259 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508919Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638723}
-
Etienne Pierre-doray authored
MachineLevelUserCloudPolicyPolicyFetchTest.Test is flaky on all platforms. TBR=zmin@chromium.org Bug: 939261 Change-Id: I2e1a6403ffc1b56f753320eceaa26e5fdec0b5fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509332Reviewed-by:
-
Olga Gerchikov authored
Root cause for the flakiness: 1.Due to crbug.com/937382, composited worklet animation current time is not identical to the current time passed to the animator instance in the worklet scope (which is passed through to local time in this test). 2.Not waiting enough for the compositing thread to update the styles. The fix: 1.Changed the test to compare against reference worklet animation's effect local time that has default playback rate. 2.Explicitly wait for the style updates before comparing to the expected results. Bug: 915352 Change-Id: I35cb3f89048568bc830aff8a6473f6d2aef5aaeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497789 Commit-Queue: Olga Gerchikov <gerchiko@microsoft.com> Reviewed-by:Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#638721}
-
Corentin Wallez authored
Texture sharing between OpenGL and Metal on Mac has to be done through IOSurfaces so we add a SharedImageBackingFactory for this OS-specific mechanism. SharedImageBackingFactory starts with supports for producing GLTexture SharedImage representations as well as legacy mailboxes. Support for other representations will be added in later commits. BUG=chromium:938895 Change-Id: I4aa5faf026c273b3a02820ed08c3a502e6769678 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505511 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by:
-
Ken Buchanan authored
This CL adds metrics to track the following: - errors resulting from invalid relying party domain - number of allowed credentials in options during credential requests - number of excluded credentials in options during credential creation Bug: 803825 Change-Id: Ib37476ef329251831a14209000b904a8e353efb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504297 Commit-Queue: Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#638719}
-
Elly Fong-Jones authored
Bug: None Change-Id: I9bd5def390e5fbe18d19b42d23540797a7a99d81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509353 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#638718}
-
Elly Fong-Jones authored
This change removes: autofill-preview-style enable-chromevox-developer-option enable-gesture-navigation enable-home-launcher enable-nup-printing enable-policy-tool enable-service-worker-servicification enable-sync-pseudo-uss-passwords offline-bookmarks slide-top-chrome-with-page-scrolls sync-standalone-transport from flag-metadata.json. Bug: None Change-Id: I93df644583b97c9f8907870d0b35255b2f10a064 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509335 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#638717}
-
Will Harris authored
https://helpx.adobe.com/security/products/flash-player/apsb19-06.html BUG=412078 TBR=jschuh@chromium.org Change-Id: Icd60dcb0157f23b6decdba389897ec55e31c6845 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508785Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#638716}
-
David Bienvenu authored
This was a regression caused by crrev.com/c/1326621, which showed/hid the root window on Restore/Minimize. In turn this caused DesktopNativeWidgetAura::IsVisible() to return false for minimized widgets, because |content_window_| was not visible. Fix is to use TargetVisibility() instead of IsVisible(). Bug: 813093, 927489 Change-Id: I7cb97ccae6452320ee4a906875535f618e1ab013 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1406069Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#638715}
-
Reid Kleckner authored
It fails in Windows component builds from what I can tell. It fails this CHECK: FATAL:simulator.cc(45)] Check failed: emplace_times_result.second. This suggests to me that some initializer is running more than once because it gets linked into multiple DLLs, and the code can't cope with that. TBR=rch@chromium.org, shend@chromium.org, vasilvv@chromium.org NOTRY=true Bug: 938773 Change-Id: Id8b2b270bc9df0a957003af0677654c8a0989086 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509105Reviewed-by:
Reid Kleckner <rnk@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#638714}
-
dstockwell authored
This is a reland of 99d553b3 This was reverted due to timeouts waiting for the Web Assembly module to load on debug builds. The test has now been disabled for that configuration. Original change's description: > pdf: Switch to the threaded version of ink > > Updates the resource manager to not require a mime type when loading > a bundled resource. This is the same as the behavior in [1]. > > [1] https://cs.chromium.org/chromium/src/extensions/browser/extension_protocols.cc?q=extension_protocols.cc&sq=package:chromium&dr&l=340 > > Bug: 902646 > Change-Id: Ib65eafd6fc900351a9270317a711c9d3ab092f80 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501194 > Commit-Queue: dstockwell <dstockwell@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#638324} Bug: 902646 Change-Id: I9fa70cad6892a24185e12b7cd72f46773a98a8a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508433 Auto-Submit: dstockwell <dstockwell@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: dstockwell <dstockwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#638713}
-
chrome://usb-internalsNancy Li authored
This change added 'Device' tab to the chrome://usb-internals page, and can display all the real devices that connected to the machine. Bug: 928923 Change-Id: Ie1f3c2dcea69dabdfb43ea5dbe1ae516573cd694 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1473710 Commit-Queue: Nancy Li <nancyly@google.com> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#638712}
-
Mugdha Lakhani authored
This removes all checks for feature flags, removes the feature flags themselves, and updates any affected tests. Intent to Ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/-iAATJCpcNY Bug: 704729 Change-Id: I69bfd29787ad5d3299991cfa1b77f33c597a8e57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508092 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#638711}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/356474278798..3cfa438106ff git log 356474278798..3cfa438106ff --date=short --no-merges --format='%ad %ae %s' 2019-03-07 cferris@google.com Update for new function malloc_init. Created with: gclient setdep -r src/third_party/perfetto@3cfa438106ff The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I4fd6e5089a3b43ce1ee44291e416efc5522c864b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509133Reviewed-by:
-
Jun Mukai authored
When the draggable_regions->getBounds() has smaller width than the widget's width, the inset decreases the top regions of the widget but inversion is computed against draggable_regions width, so it misses some additional client areas asides the draggable regions. Instead, the inversion needs to be computed against the areas decreased by the inset. Bug: 939094 Test: manually Change-Id: Ia1b509b6ec5cf1ba10b44919b1da73eb03942608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509097 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
-
Robert Liao authored
This reverts commit 4f9a19f1. Reason for revert: Suspected in causing webkit_layout_test failures https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests%20%28dbg%29/9784 * media/video-played-collapse.html * virtual/video-surface-layer/media/video-played-collapse.html Original change's description: > AudioService: Fixes for loopback underruns/timing issues. > > Fixes a "choppy audio" issue on platforms with certain audio timing > parameters/scenarios. Investigation on crbug.com/934770 led to the > realization that three related problems needed to be addressed: > > 1. Fix the "gap" detection in audio::SnooperNode to check in BOTH > directions, not just one direction; and on both the input and output > flows. This accounts for the case where a device-switch in > audio::OutputController results in a sudden drastic shift in the delay > timestamps. > > 2. Add automatically-increasing capture delay logic to > audio::LoopbackStream to ensure the reads from all nodes' delay buffer > will never result in underrun. > > 3. Increased the accuracy of media::FakeAudioWorker/OutputStream by: a) > addressing a subtle source of error in task scheduling delay math due to > integer truncation; b) exposing timestamps to worker callbacks that > allow FakeAudioOutputStream to provide a |delay| and |delay_timestamp| > that behaves just like a real AudioOutputStream. This "lessens the blow" > of a device-switch to SnooperNode. > > Bug: 934770 > Change-Id: Ia75f18b2be3ad905f27d6ad882df9632764bb81c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504981 > Commit-Queue: Yuri Wiitala <miu@chromium.org> > Reviewed-by: Max Morin <maxmorin@chromium.org> > Reviewed-by: Oskar Sundbom <ossu@chromium.org> > Reviewed-by: Weiyong Yao <braveyao@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#638427} TBR=dalecurtis@chromium.org,miu@chromium.org,braveyao@chromium.org,maxmorin@chromium.org,ossu@chromium.org Change-Id: I845f547c60481ebde0ae24d1a83d59f2f750f7e3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 934770 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509365Reviewed-by:
-
Victor Vasiliev authored
Merge internal change: 237089889 R=rch@chromium.org Change-Id: I8051e8cb9260833d678884a0affcb272ada8cd12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507194 Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#638707}
-
Philip Rogers authored
Due to existing regressions, this patch disables BlinkGenPropertyTrees. For completeness (to prevent another http://crbug.com/935195), tested: +------------------------------------------------+-----------+------------+ | flag | pre-patch | post-patch | +------------------------------------------------+-----------+------------+ | no flag | BGPT on | BGPT on* | | --enable-features=BlinkGenPropertyTrees | BGPT on | BGPT on | | --disable-features=BlinkGenPropertyTrees | BGPT off | BGPT off | | --enable-blink-features=BlinkGenPropertyTrees | BGPT on | BPGT on | | --disable-blink-features=BlinkGenPropertyTrees | BGPT off | BGPT off | +------------------------------------------------+-----------+------------+ * This is due to the finch field trial testing config. content/child/runtime_features.cc now checks for experimental web platform features because the BlinkGenPropertyTrees flag is fully controlled by the feature default in third_party/blink/common/features.cc and would be disabled in web tests (formerly layout tests) without this check. Bug: 836884 Change-Id: I590e1b7c697c7c70cf3c4c5121483b2dd76c74df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505836Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
-
John Delaney authored
These deps(introduced by https://crrev.com/74efc1ddfa7c8) are causing some builds to flake because the mojom headers are being exported before the mojom c++ sources are generated. Moving the mojom dep to public deps will prevent this from occuring. See bug for more info. Bug: 939044 Change-Id: I9f0c6d2a5bf0f1c7f7d016b1170e8c2c5d2d02c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506765 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#638705}
-
Dmitry Titov authored
Writing timestamp before the actual reporting may actually result in skipping the reporting and waiting another week before the next opportunity. Move the timestamp writing to the after the reporting was actually done. Bug: 939213 Change-Id: I540d1780ed95c361959732655796270e95787dc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507393Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Dmitry Titov <dimich@chromium.org> Cr-Commit-Position: refs/heads/master@{#638704}
-
Marco Paniconi authored
https://chromium.googlesource.com/webm/libvpx.git/+log/d64e328624e0..8256c8b297c8 $ git log d64e32862..8256c8b29 --date=short --no-merges --format='%ad %ae %s' 2019-03-06 marpan vp9-rtc: Improve mode check on flat blocks in screen mode 2019-03-06 marpan vp9-denoiser: Bias to last for golden long term 2019-03-04 johannkoenig add -Wmissing-prototypes Created with: roll-dep src/third_party/libvpx/source/libvpx R=johannkoenig@google.com Change-Id: I4e4b198174b59f023a7e1e399785adeed12d58dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508602Reviewed-by:
Tom Finegan <tomfinegan@chromium.org> Commit-Queue: Marco Paniconi <marpan@google.com> Cr-Commit-Position: refs/heads/master@{#638703}
-
Donn Denman authored
Updates the requests that we send to the server to use the next higher API level for Coca, when enabled by the Definitions Feature. We will use this to activate contextual definitions. This API level supports returning the full search URLs from the server, so we don't need to build them from scratch on the client. These new search URLs get passed through the system, and is the only thing touching most of the files in this CL. We also update our Field Trial support for Contextual Search to allow a Feature-param on the Definitions Feature to specify the Coca integration level so we can have multiple finch-controlled experiment arms that control server-functionality. We plan to use this for different triggering levels for Definition cards. BUG=936695 Change-Id: I0666d07000447a9cfb4be5a2344d29c24c47f4a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501759 Commit-Queue: Donn Denman <donnd@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#638702}
-
