GitLab

Bug: 812974
Change-Id: If3b39236ddc753f8ef3f8caab4b8c2a5b12497fd
Reviewed-on: https://chromium-review.googlesource.com/988799
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Tommi <tommi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548273}

Bug: 793301
Change-Id: I439f64d2c68c965881ab69b297b0bbabfd68b31d
Reviewed-on: https://chromium-review.googlesource.com/986053
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548272}

BUG=none
TEST=none
TBR=rjkroege@chromium.org

Change-Id: Ic63d88124d37c50f6bea881b5afcd888c7fc4fca
Reviewed-on: https://chromium-review.googlesource.com/996808
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548271}

Added a "MacViewsAutofillPopup" feature flag and
--mac-views-autofill-popup switch. If it's enabled,
show the Autofill popup view using toolkit instead of
cocoa.

Removed AutofillPopupBaseView FocusManager accelerator code.
The code is no longer necessary since it was added for a now
obsolete rAc dialog. The autofill popup will get dismissed by
the web contents, which listens for the accelerators.

This is a reland of
https://chromium-review.googlesource.com/c/chromium/src/+/889983

The CL was reverted because of a crash (https://crbug.com/809830)
which was caused by the popup's container view's window set to
nil.

Bug: 728182
Change-Id: I02f74b5627e6559c4e4dd77a35860e77d000a0d5
Reviewed-on: https://chromium-review.googlesource.com/974106Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548270}

When an extension is granted tab permission using activeTab (in response to say
clicking on its browser action), the extension is granted permission to the
tab's origin for the duration of the tab lifetime.

When this happens for a tab with a file url loaded, the extension gets
permission to the file scheme on the tab. This allows, for example, the
extension to read the contents of the page using apis like
chrome.tabs.executeScript. For file urls, this is not ideal since this does not
respect the "Allow access to file URLs" extension setting.

This CL changes this behavior, gating the access to the file scheme on the tab,
on the extension having explicit file access. This CL also adds extensive test
coverage for the behavior of tabs.executeScript on pages with file urls loaded
into them.

BUG=816685

Change-Id: I9175bb1883006fe594a93262c6825a962c285037
Reviewed-on: https://chromium-review.googlesource.com/994264
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548269}

Instead of writing base::Version(version_info::GetVersionNumber()).

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I0a2c0826ffced29d22151bac51537da227b6dd95
Reviewed-on: https://chromium-review.googlesource.com/989092Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548268}

Users of AGSA have long had feedback that the download complete notification
resulting from CCT usage is incongruent with the perceived usage of AGSA
instead of Chrome. This attempts to fix it by suppressing the download complete
notification for versions of AGSA that support issuing their own notification

Bug: 812022
Change-Id: I099e8a3db0bb4984cfd2782d5442cffabbacf765
Reviewed-on: https://chromium-review.googlesource.com/952025
Commit-Queue: Cathy Li <chili@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548267}

When calling the build/android/tombstones.py script, used to
extract tombstones and properly resolve symbols for Chromium
libraries, 'aapt dump badging' is called repeatedly on all
files matching $CHROMIUM_OUTPUT_DIR/apks/*.apk, in order to
extract their package names.

This patch helps speed up this process considerably by caching
the result for each APK (hence each file will be read only once
now).

Time comparison for the following command (for an Android/x86 build).

  third_party/android_platform/development/scripts/stack.py \
      --arch x86 \
      --output-directory out/Emulator \
      --more-info \
      /tmp/tombstone_08

Before: 1m 48s  -->  After: 23s    (same results)

+ Rename symbols.GetAapt() to _GetAapt() to make it private,
  and use constants.ANDROID_SDK_TOOLS to find the location of
  the 'aapt' binary used to extract package names. Note that
  the use of the SDK_HOME environment is preserved unchanged
  at the moment (though is probably not needed).

+ Rename GetApkPackageName() to _GetApkPackageName() and
  remove its 'aapt' parameter and speed it with a small
  cache.

+ Rename GetCandidateApks() to _GetCandidateApks() and
  use a small cache to avoid hitting the filesystem everytime
  this is called, since the result will not change between
  invokations.

+ Simplify GetMatchingApks() implementation.

+ Fix minor typos.

NOTE: There are still many many things that are really wrong
      in this script. In particular, it cannot work properly
      with component builds, and will fail to work in the
      future when Chromium will be installed as a set of
      APK splits. Another point is the reliance on the global
      ARCH variable which is liberally modified directly by
      other Python scripts all over the place (ugh...).

      These will be addressed in future CLs.

BUG=774267
R=agrieve@chromium.org,hzl@chromium.org, jbudorick@chromium.org, mattcary@chromium.org

Change-Id: If130a668dd592b682d7fa98012745704a74fb850
Reviewed-on: https://chromium-review.googlesource.com/995932
Commit-Queue: David Turner <digit@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548266}

Bug: 826773
Change-Id: Iae8f5732fcfad8fbe81c9b9dab36cdcd9679c1dd
Reviewed-on: https://chromium-review.googlesource.com/990975
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548265}

Builder was renamed in
https://chromium-review.googlesource.com/c/chromium/tools/build/+/988819,
but I forgot to apply that rename in
https://chromium-review.googlesource.com/c/chromium/src/+/988816

TBR=nodir,dpranke

NOTRY=true

Bug: 782863
Change-Id: I35a74f670ebcc3ae266086eba800d41fe95b77e3
Reviewed-on: https://chromium-review.googlesource.com/993976
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548264}

Centrally set up a temp directory to be used as download directory.
Remove lots of ad-hoc code in individual tests doing the same. While
this is a nice cleanup in itself, the main motivation is the plan to
restrict download location to only specifically whitelisted directory
subtrees on Chrome OS in a subsequent code change without all the
existing tests having to worry about that detail.

BUG=chromium:818138
TEST=Compiles and passes tests.

Change-Id: I88bd945d544c7536c3e1a884928c3e72200efc9d
Reviewed-on: https://chromium-review.googlesource.com/953942Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Mattias Nissler <mnissler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548263}

Bug: None
Change-Id: I5d24ad95d415a665e5317a803f3b05efff603429
TBR: rsesek
Reviewed-on: https://chromium-review.googlesource.com/996578Reviewed-by: Chris Palmer <palmer@chromium.org>
Commit-Queue: Chris Palmer <palmer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548262}

Enters splitview when focus is on transient child. Use
MruWindowListForCycle instead of MruWindowList because the latter counts
transient child as well, which would give a wrong limit when checking
the minimum amount of windows to open splitview.

Test: ash_unittests SplitViewControllerTest.*
Bug: 827245
Change-Id: Ibe7985fa52f5d4a03b033311540c8385d01b53ee
Reviewed-on: https://chromium-review.googlesource.com/985901Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548261}

Reland of the original CL with fix on Mac.

Original CL Description:

This is a ServiceTest tha runs CdmService in-process (packaged) which
covers some basic interaction between CdmService and CdmFactoryImpl.

TBR=jrummell@chromium.org,tsepez@chromium.org

Bug: 826039
Test: Adds new tests to media_service_unittests
Change-Id: Ieb087d7d4690d80965b4c2d3b04d7c497bf9560b
Reviewed-on: https://chromium-review.googlesource.com/994460Reviewed-by: John Rummell <jrummell@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548260}

Adjust padding and sizing for KeywordHintView in touch mode.

Screenshots -
https://drive.google.com/file/d/1DGPFQ1tJUyJPbZ_ncrI8Ny06skmNdJck/view?usp=sharing

Bug: 801583
Change-Id: I972705e816ed43db39117c7dc58d1fdbd2dbd517
Reviewed-on: https://chromium-review.googlesource.com/942642
Commit-Queue: Patti <patricialor@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548259}

This is largely a copy-and-paste from GLES2DecoderImpl, with some minor
cleanup.

- added a vertex array manager to RasterDecoderImpl and copied
  associated boilerplate because it was required by
  CopyTextureCHROMIUMResourceManager

- copied GLES2DecoderImpl::CopySubTextureHelper as
  RasterDecoderImpl::CopySubTexture with very minor modification
  (e.g. raster is given a destination texture ID instead of the target
  that GLES2 takes)

- added a unittest to verify that source and destination textures are
  cleared appropriately

Bug: 789238
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I1eb50e43cc52ee9931a483ab89f9cdbdf47e2332
Reviewed-on: https://chromium-review.googlesource.com/993763
Commit-Queue: Jonathan Backer <backer@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548258}

The GroupCoordinator will be used in the new Audio Service loopback and
muting features. It tracks one or more audio outputs that are members of
the same group, and notifies interested entities (e.g., a muter, a
loopback mixer, etc.) of membership changes to the group.

Bug: 824019
Change-Id: I9b8b1564e8fa7977d2d8dd21c466c7cbf5cdd3f2
Reviewed-on: https://chromium-review.googlesource.com/987093Reviewed-by: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548257}

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ie30ec32ff379dca98f964e2a0de0e786eec8026f
Reviewed-on: https://chromium-review.googlesource.com/994498Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Sasha Morrissey <sashab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548256}

Offline pages need a custom version of the menu items shown by CCT. This
change creates a custom UI type for presenting offline pages that
properly configures the menu and also disables the "powered by Chrome"
footer.

Bug: 824807
Change-Id: Ic20f03ee152b8f538161810e87bc0e514886a3e7
Reviewed-on: https://chromium-review.googlesource.com/996395Reviewed-by: Jian Li <jianli@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548255}

This came up as part of an effort to switch |is_posix| to false in Fuchsia.

Bug: 812974
Change-Id: Ic8d4b745e4e88620d6ad598223d41d0b3ca08a3f
Reviewed-on: https://chromium-review.googlesource.com/988850Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548254}

This brings it up to revision 6aa3b57955fed5e137d0306478e1a4b424a6d392, which includes the following two changes:

* Support for reversed dates in timeRange() and dateRange():
  https://hg.mozilla.org/mozilla-central/rev/cd913073f87c
* Additional validation of IP(v4) literals in isInNet:
  https://hg.mozilla.org/mozilla-central/rev/dd66d01e757c

Bug: 827292
Change-Id: I3d6670c7ceed0fc1bc453d6892922ffb047ab2bc
Reviewed-on: https://chromium-review.googlesource.com/986949
Commit-Queue: Eric Roman <eroman@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548253}

Bug: 829092
Change-Id: Ibfe49a09148cfcd7b6fb489eadfbc5b43bb682ec
Reviewed-on: https://chromium-review.googlesource.com/996570Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548252}

Replacing tdresser@

Change-Id: I74625e1844b5403fc63a7d20d98aaaff1529f6a6
Reviewed-on: https://chromium-review.googlesource.com/993397Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548251}

CRWWebController removes WKWebView when the web process is evicted
(crbug/815248). This leaves WKBasedNavigationManager in an inconsistent
state as previous_item_index_ may not be -1, but GetItemCount() is 0.
This causes a crash in OnNavigationItemCommitted() when user starts a
new navigation by typing into the omnibox.

Fix the crash by guarding the pointer dereference with a nullptr check.

Bug: 797756
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ie553efbe7bb558a8af955ca6f64e2b8aea58aacd
Reviewed-on: https://chromium-review.googlesource.com/996436Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548250}

This reverts commit ef18e86a.

Reason for revert: Make sure apk_merger.py works with and without the
unwind file, till downstream cl lands. Also rebase on:
https://chromium-review.googlesource.com/c/chromium/src/+/994545
and remove workaround for crbug/828528.

Original change's description:
> Revert "Enable extracting unwind table on official builds without channel"
>
> This reverts commit 16e808d7.
>
> Reason for revert: Merge step still failing.
>
> Original change's description:
> > Enable extracting unwind table on official builds without channel
> >
> > The original cl was here:
> > https://chromium-review.googlesource.com/c/chromium/src/+/990092
> > This CL fixes the following problems with the original CL:
> > 1. The apk_merger script fails because the unwind tables were only added
> >    in 32-bit apk. The merger script expects all the files to be same and
> >    the ones different should be checked.
> >  1a. The resources.arsc is non-hermetic and ordering is affected by
> >      adding file to only one apk. As a workaround for crbug/828528,
> >      add an empty (valid) unwind table file to the 64 bit monochrome
> >      apk to make the resource.arsc consistent.
> >  1b. The merger script simply adds all the files in apk which are not
> >      same. To keep the script simple and functional, the unwind resource
> >      is renamed to unwind_cfi_32 and unwind_cfi_empty in respective
> >      builds and the app_merger is updated to specify this file is
> >      expected to be different and included. This causes an extra file
> >      (4 byte) in the merged apk.
> >
> > 2. The unwind tables were always generated for "libchrome.so" for all
> >    chrome apks. The different chrome_apk(s) have different shared
> >    libraries like libchromefortest, etc.. So, update the unwind asset to
> >    get unwind table for the right library for each apk. Only adds assets
> >    to *_public_apk(s).
> >
> > 3. The monochrome_apk_checker was failing because the unwind file
> >    included was different in chrome_apk and monochrome_apk. This CL adds
> >    the asset to all apk at the same time and adds exception for this
> >    file.
> >
> > BUG=819888
> > TBR=dpranke@chromium.org
> >
> > Change-Id: Ibceeeacc19fa424d519891b8c17e349ee6c2dfd6
> > Reviewed-on: https://chromium-review.googlesource.com/991236
> > Commit-Queue: Siddhartha S <ssid@chromium.org>
> > Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
> > Reviewed-by: Bo <boliu@chromium.org>
> > Reviewed-by: agrieve <agrieve@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#547993}
>
> TBR=boliu@chromium.org,dpranke@chromium.org,mariakhomenko@chromium.org,changwan@chromium.org,ssid@chromium.org,agrieve@chromium.org
>
> Change-Id: I0a96e213133b6cb21c36db365b7c72f0f4642c8e
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 819888
> Bug: 828879
> Reviewed-on: https://chromium-review.googlesource.com/995697
> Reviewed-by: Anthony Berent <aberent@chromium.org>
> Commit-Queue: Anthony Berent <aberent@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#548066}

TBR=dpranke@chromium.org,mariakhomenko@chromium.org

Bug: 819888, 828879
Change-Id: I2eba81de32632bea90171ece4cba1a4144c55d25
Reviewed-on: https://chromium-review.googlesource.com/996272
Commit-Queue: Siddhartha S <ssid@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Siddhartha S <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548249}

Changed chrome://connection-help UI to automatically expand a section
if it matches the interstitial that caused the redirection.
Also removed windows only section on non-windows platforms.

Change-Id: I1287a4bdbc95d9cd5052212194450e72a3ebb18e
Reviewed-on: https://chromium-review.googlesource.com/988838
Commit-Queue: Carlos IL <carlosil@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548248}

This CL has no intended behavior change.

In addition to moving and renaming the classes, this CL:
  * Renamed all classes to remove "memlog_" or "profiling_" prefixes.
  * Removed profiling_constants.h and profiling_constants.cc, which were unused.
  * Moved binding logic from profiling_client.cc into chrome_content_client.cc
    to meet DEPs requirements.

Change-Id: I1ea59ef056c0592c29ff4b1a39412c17ed1c0219
Bug: 827545
Reviewed-on: https://chromium-review.googlesource.com/995872Reviewed-by: Cait Phillips <caitkp@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548247}

There could be an ordering issue with the teardown
of a tab with an infobar after the infobar change
in r547527. Watch the "infobar manager gone" callback
and ensure a correct order.

For correctness, this makes the change in all the
other places that change used the infobar observer
except for InfoBarObserver, which is changed this
way in https://crrev.com/c/991468 .

BUG=354380, 828552

Change-Id: I21add007c5b2d725dc2985cbd268d3d4674978b6
Reviewed-on: https://chromium-review.googlesource.com/996372Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548246}

Net.HttpContentLengthWithValidOCL
Net.HttpContentLengthCacheable
Net.HttpContentLengthCacheable4Hours
Net.HttpContentLengthCacheable24Hours

Bug: 821242
Change-Id: I54d0cd8004cd837e43ecd4dea9a0b431bad5d644
Reviewed-on: https://chromium-review.googlesource.com/996247Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548245}

It is behind the flag "FormDataEvent". The flag is off by default, and
tests will be added later.

Bug: 825684
Change-Id: If152940a52e684a1c64f75ee2f60fbd18b91954d
Reviewed-on: https://chromium-review.googlesource.com/995114Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548244}

This reverts commit 970f8498.

Reason for revert: Appears to be causing leaks in chromeos_unittests (PipeReaderTest.Cancel).

Bot: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/

Build failure: 
https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.memory%2FLinux_Chromium_OS_ASan_LSan_Tests__1_%2F26886%2F%2B%2Frecipes%2Fsteps%2Fchromeos_unittests%2F0%2Fstdout

Original change's description:
> Reduce leaks in PostTaskAndReplyImpl::PostTaskAndReply.
> 
> Before, there was always a leak when the RunTaskAndPostReply callback
> posted by PostTaskAndReplyImpl::PostTaskAndReply didn't run.
> 
> With this CL, the "task" is never leaked and the "reply" is only
> leaked if the execution environment is shutdown before the deletion
> happens (e.g. MessageLoop deleted, TaskScheduler shutdown).
> 
> Bug: 807013
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> Change-Id: I05205d1b0250811abe61e2204ba32919d16c16c0
> Reviewed-on: https://chromium-review.googlesource.com/902191
> Reviewed-by: François Doray <fdoray@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Reviewed-by: Gabriel Charette <gab@chromium.org>
> Commit-Queue: François Doray <fdoray@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#548034}

TBR=sky@chromium.org,gab@chromium.org,fdoray@chromium.org,kbr@chromium.org,tzik@chromium.org

Change-Id: Ib91c72333fabb4e33c1689c5ad39a5ed53ce3beb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 807013
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/996732Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548243}

Start talking to the new, component-specific bridge rather than the
SnippetsBridge.

Also, make ContextualSuggestionsBridge and ContextualSuggestionsCluster
package protected to enforce ContextualSuggestionsCoordinator being
the only Java class visible outside of the package.

BUG=822945,827654

Change-Id: Ib599a1ec9f6af53046c71c8b762b64398cb306cc
Reviewed-on: https://chromium-review.googlesource.com/996404
Commit-Queue: Theresa <twellington@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548242}

The DCHECK() asserted that the status was ERROR_DETECTED whenever
GetReasonToClose() was called. However, this function is also intended
to be called when connections are closed normally.

Bug: 829083
Change-Id: Iaee6948cf38ef3ee3ddfbde8681ec9a840928662
Reviewed-on: https://chromium-review.googlesource.com/996310Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548241}

Bug: 758733
Change-Id: I0b4cac2f3bc605383e835184ef7c27c51be1be4a
Reviewed-on: https://chromium-review.googlesource.com/994144
Commit-Queue: Peter Williamson <petewil@chromium.org>
Reviewed-by: Yafei Duan <romax@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548240}

This patch adds an UMA metric for the time spent in
ScrollingCoordinator::UpdateAfterCompositingChangeIfNeeded when a
compositing-related change does need an update.

Bug: 826883
Change-Id: I49949aa286bfc2c3c265b9ba99e2b7cd5a33b90b
Reviewed-on: https://chromium-review.googlesource.com/994541Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548239}

crrev.com/c/728325 disabled fetching/using an ICC file for display color
correction if enough information was available in the monitor EDID. This
was based on the wrong assumption that either one or the other would be
present, but not both.  This CL reenables the use of (download of) the ICC
file for monitor colorimetry, using the EDID provided info as a fallback.

On the implementation:
DisplayConfigurator::NotifyDisplayStateObservers() pings DisplayColorManager
when there's new Display info. The later calls ApplyDisplayColorCalibration()
directly or after fetching the ICC file. In either case, if all steps
succeed, SetColorCorrection() is called; at this step we are sure that the
found/downloaded ICC file is good, and we can remove the usage of the EDID
provided ColorSpace.

Bug: 828102
Change-Id: Id799f8412ea06d781712884b1d02694f124860c6
Reviewed-on: https://chromium-review.googlesource.com/990494Reviewed-by: Greg Levin <glevin@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548238}

Sometime Android system fails to extract library. Manually extract them to
cache directory and load as needed.

Bug: 806998
Change-Id: I7ccff04435cb5201e410c71bde741e52687329ab
Reviewed-on: https://chromium-review.googlesource.com/930332
Commit-Queue: Ran Ji <ranj@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548237}

This is necessary in order to land CL [1].  I've been trying for a few weeks to
land it, but there's always new merge conflicts due to changed layout test
baselines.  This CL bans changes in third_party/WebKit/LayoutTests for a few
hours while I rebase and land CL [1].

[1] https://chromium-review.googlesource.com/c/chromium/src/+/976083

BUG=787020
R=dpranke

Change-Id: I24bf199e20e5d5da1fc84e1ac8e64320213527d0
Reviewed-on: https://chromium-review.googlesource.com/996633Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548236}

Adds a test that validates that the third-party libraries used by the
chrome media gallery util service are using the right CPU info.
This is going to be usefull for an upcoming CL that changes how that
information is set (it'll be passed through IPC).

Bug: 823931
Change-Id: I9e9586af8615739db0baf36ed547ef017546adb5
Reviewed-on: https://chromium-review.googlesource.com/996392Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548235}

TBR=kbr@chromium.org

No-Try: True
Change-Id: I3b6e7a4bfe81a67b0d67b334b09217fd02b2c579
Reviewed-on: https://chromium-review.googlesource.com/996638
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548234}