GitLab

In order to prevent Referrer chains from looping, add a timestamp
argument to both FindNavigationEvent and FindRetargetingNavigationEvent.
Then only allow the next event if it precedes the previous event
chronologically.

Bug: 864234
Change-Id: Ie5752096eb2571ecf24bdf22057ebc5c4d87adbd
Reviewed-on: https://chromium-review.googlesource.com/1141058Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575790}

The code for initializing the memory mapping from a ruleset file was
not properly checking for IO errors from lower level mmap utilities.

This CL accounts for that by adding a factory method to
MemoryMappedRuleset which returns nullptr if initializing the memory
mapped file fails. This is tested via a global boolean which simulates
mmap failures by always returning nullptr from the factory method.

Bug: 734102
Change-Id: Id9372d09c0c1abdd4eb26a6486a84e11cd7cc245
Reviewed-on: https://chromium-review.googlesource.com/1138336
Commit-Queue: Asanka Herath <asanka@chromium.org>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575789}

Bug: None
Test: None
Change-Id: I18651c7a5aae4535cf0c7b652e68735126b3fe6c
Reviewed-on: https://chromium-review.googlesource.com/1139111Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Muyuan Li <muyuanli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575788}

Renamed targets under //webrunner as follows:
  service_unittests -> webrunner_unittests
  runner_pkg -> webrunner_pkg
  runner_exe -> webrunner_exe
  runner -> webrunner

Bug: 852145
Change-Id: Id92d021d29e7fada81153d70440b6376052e3abd
Reviewed-on: https://chromium-review.googlesource.com/1138992Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575787}

Bug: 837501
Change-Id: I2c3473b7198a3f8a172552dfda07b91fec19f5da
Reviewed-on: https://chromium-review.googlesource.com/1136020Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575786}

InspectorDOMSnapshotAgent: expose and book layout nodes owned by pseudo elements under their owners.

Currently, only support before, after and first letter pseudo types.

Change-Id: Ifb10fecad1dbfb6b987eaa0bd0e7ccb4a222d13f
Reviewed-on: https://chromium-review.googlesource.com/1125511
Commit-Queue: Hidy Han <hidyhan@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575785}

The new names for the affected bots are:
  mac10.13_retina-blink-rel
  mac10.13_retina-blink-rel-dummy
  WebKit Mac10.13 (retina)

Bug: 863070
Change-Id: I0a9cfb1e0378f6fe2f900c84e0d73c16f1094d8d
Reviewed-on: https://chromium-review.googlesource.com/1136883Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575784}

https://skia.googlesource.com/skia.git/+log/b609e6dc6a02..3229e65886a0


git log b609e6dc6a02..3229e65886a0 --date=short --no-merges --format='%ad %ae %s'
2018-07-17 jvanverth@google.com Revert "Add some optimizations to PolyUtils"
2018-07-17 ziadb@google.com SkAR Java: drawing planes as paths
2018-07-17 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-07-17 jvanverth@google.com Add some optimizations to PolyUtils
2018-07-17 kjlubick@google.com Add SkFloat2Bits and Region stub
2018-07-17 caryclark@google.com build for gdb on linux
2018-07-17 caryclark@skia.org fix bookmaker build bot
2018-07-17 robertphillips@google.com Restore SkLightingShader and associated classes
2018-07-17 allanmac@google.com Bug fixes and improvements to SKC and HotSort.  Vulkan is WIP.
2018-07-17 caryclark@skia.org remove unused untested parts of text blob
2018-07-17 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 6fb8ba4e8660..d691aeeb956f (1 commits)


Created with:
  gclient setdep -r src/third_party/skia@3229e65886a0

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=bungeman@chromium.org

Change-Id: I8680e0eeffa0615b25d1b0e5c8767c4ba199f02f
Reviewed-on: https://chromium-review.googlesource.com/1140417Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#575783}

Chrome-side change. Logs CL: http://cl/200254698

Bug: 849781
Change-Id: I4348263c7e7bbfb868626141bc6a142cb738375d
Reviewed-on: https://chromium-review.googlesource.com/1102165
Commit-Queue: Nathan Parker <nparker@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Tim Schumann <tschumann@chromium.org>
Reviewed-by: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575782}

Bug: 859742
Change-Id: Ia6c15fac08867ccd81556e1cdf7e1b45620069a4
Reviewed-on: https://chromium-review.googlesource.com/1138991Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575781}

Since the downstream P code are upstreamed, this class becomes no-op.

part 1: http://crrev/c/1138815

Bug: 850652
Change-Id: Idfda4ec1cd583159fdabf8c1fedc35cf752c9099
Reviewed-on: https://chromium-review.googlesource.com/1137105
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575780}

Identical blocks are not forgotten across drains now.  Added test as well.

R: pmonette@chromium.org
Test: chrome_elf_unittests.exe, ThirdParty*
Bug: 769590
Change-Id: I1d3b7db15128746c25e6d8bcfce8f39d2251d67f
Reviewed-on: https://chromium-review.googlesource.com/1140512
Commit-Queue: Penny MacNeil <pennymac@chromium.org>
Reviewed-by: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575779}

It appears to be unneeded and it causes the fast/css/opacity-float.html
LayoutTest to fail.

Bug: 689306
Change-Id: I704a22a40fbdbfbb9fd98d6676ec0ce244d4a0ee
Reviewed-on: https://chromium-review.googlesource.com/1140208Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575778}

Forcing LayerTreeHostImpl to always swap shouldn't be necessary for the
browser UI compositor anymore. LayerTreeHostImpl has been changed to
always submit a CompositorFrame if the set of referenced surfaces has
changed.

It appears |must_always_swap| isn't necessary for layout tests either as
they still pass without it.

Bug: 851616
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I032264a23ba3b8c880f10d777cbe7b24372f0347
Reviewed-on: https://chromium-review.googlesource.com/1136804Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575777}

This CL updates TableViewEmptyView to use NSAttributedStrings rather
than using the UILabel equivalents.  This allows ChromeTableView
subclasses to define custom text styling if necessary.

Bug: 851962
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ib41dedfcb659ddfbe974db7d88b8867d6d9d5c20
Reviewed-on: https://chromium-review.googlesource.com/1135760Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575776}

This upstreams text-target.html, as well as a change to
client-rect.html. This also deletes the non-WPT copy of these
tests to avoid unnecessary test duplication.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Ic53b3be66ffa2b2dd5b77105eb2c8e02181bac81
Reviewed-on: https://chromium-review.googlesource.com/1136939Reviewed-by: Stefan Zager <szager@chromium.org>
Commit-Queue: Ali Juma <ajuma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575775}

dproy@ added histograms for longest input delays and timestamps in
http://crrev.com/c/1084058: this CL does the same for general input delays.

R=tdresser@chromium.org,rkaplow@chromium.org
CC=​​dproy@chromium.org

Bug: 862389
Change-Id: I4453b0b7338101098ca4521100abe3293add45c0
Reviewed-on: https://chromium-review.googlesource.com/1132108Reviewed-by: Steve Kobes <skobes@chromium.org>
Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575774}

https://chromium.googlesource.com/deps/inspector_protocol/+/0d4255502019144a5dec5669d7992165ae8924e7

Change-Id: I6a0f2fe8aae5cc79b7b01127c2d05cf296209e51
Reviewed-on: https://chromium-review.googlesource.com/1139098Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575773}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/b1e14adb..3df683e6

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I29d40266031f416da6259fed1ca419b52169ec53
Reviewed-on: https://chromium-review.googlesource.com/1140687Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#575772}

Bug: 830892
Change-Id: Id148e1503564e86f220a6a775aa9055294e465b1
Reviewed-on: https://chromium-review.googlesource.com/1140198Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Commit-Queue: Oliver Li <olivierli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575771}

This will be used in a subsequent CL to change the HTTP RTT
estimate of the count of end to end RTT observations is more than
a certain threshold.

Change-Id: I4268568e2c7df0c45651fdecb19ba59925430565
Bug: 834119
Reviewed-on: https://chromium-review.googlesource.com/1117771Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575770}

This reverts commit a3ec8289.

Reason for revert: win tester bot failure

Original change's description:
> Re-enable webrtc audio quality browsertests on windows.
> 
> Tests were previously disabled when they started failing (more context in linked bug). Re-enabling because tests pass locally on win7 machine.
> 
> Bug: 850936
> Change-Id: Ie1ab4e82daf2c0265e932237d3edf6b3399ee803
> Reviewed-on: https://chromium-review.googlesource.com/1139066
> Reviewed-by: Henrik Boström <hbos@chromium.org>
> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#575638}

TBR=hbos@chromium.org,marinaciocea@chromium.org

Change-Id: I1cf598f783dd33be1f8834c5d7baf01a20479ffd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 850936
Reviewed-on: https://chromium-review.googlesource.com/1140854Reviewed-by: Marina Ciocea <marinaciocea@chromium.org>
Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575769}

Previously, this string was "SMS Connect", but our UX team requested
that it be changed to "Android Messages".

Bug: 824568
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I8843cd070b60c3b0230ed6e9c5b9e08a88b940ce
Reviewed-on: https://chromium-review.googlesource.com/1140775Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575768}

R=lushnikov@chromium.org

Bug: none
Change-Id: Id2192b6ca53da504540c2528121b3ee7a0dd1761
Reviewed-on: https://chromium-review.googlesource.com/1132630
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575767}

Put the common logic in TabletModeWindowDragDelegate and create
TabletModeBrowserWindowDragDelegate and TabletModeAppWindowDragDelegate
to do special handling for browser windows and app windows.

*DragDelegate does almost everything other than updating the dragged
window (which is done by *DragController by either changing the dragged
window's bounds or transform).

Bug: 823769
Change-Id: Idc9e788f7e273a92fc783af347f62cd862be54bd
Reviewed-on: https://chromium-review.googlesource.com/1134503
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575766}

The test has recently become much flakier.

TBR=nednguyen@chromium.org
CC=mythria@chromium.org,ulan@chromium.org
NOTRY=true

Bug: 864718
Change-Id: Ief78f4e4525bb562416bfb293770ed0b905dc32c
Reviewed-on: https://chromium-review.googlesource.com/1141067Reviewed-by: Charlie Andrews <charliea@chromium.org>
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575765}

After the latest round of API changes, it's a drop-in replacement.

BUG=831073
R=blundell@chromium.org,tengs@chromium.org

Change-Id: I086340744a2df1763c29da879ca2f87465028fac
Reviewed-on: https://chromium-review.googlesource.com/1126256Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575764}

Using wpt-import in Chromium d74f01b7.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21501

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
igrigorik@chromium.org, panicker@chromium.org:
  external/wpt/performance-timeline

TBR=foolip

No-Export: true
Change-Id: I3e61664c718581f984e73e916a33d5f81288a6fe
Reviewed-on: https://chromium-review.googlesource.com/1140776
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575763}

This is needed to get frame sink ids for DedicatedWorkers' RAF.

Bug: 863698
Change-Id: I0bd86ac9271d3f00ee5cb00522896ff152ef7bb6
Reviewed-on: https://chromium-review.googlesource.com/1140278Reviewed-by: Justin Novosad <junov@chromium.org>
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575762}

TBR=perezju@chromium.org
NOTRY=true # test by PRESUBMIT

Bug: 863767
Change-Id: I210c158140e015f0a15ba9d34945fcda8f394d43
Reviewed-on: https://chromium-review.googlesource.com/1140917Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#575761}

This CL prepares moving VR code into a DFM. See go/chromevr-java-dfm for
more details.

This CL does the following:

- Add VrDelegate and VrIntentDelegate interfaces which represents the VR API the
  rest of Chrome can call.

- Add the interfaces implementation VrDelegateImpl, which forwards calls
  from Chrome into VR to the classes currently implementing those calls,
  i.e. VrShellDelegate and VrIntentUtils.

- Add the interfaces implementation VrDelegateFallback, which will be
  instantiated if the VR DFM is not present. For now, it will be
  instantiated if the GN arg enable_vr is false.

- Add VrModuleProvider, which is responsible for instantiating the correct
  interface implementations.

- Replaces all calls from outside of VR to VrShellDelegate and
  VrIntentUtils with calls to the new interfaces.

 - Moves most VR Java classes behind the enable_vr GN arg.

Bug: 862639
Change-Id: Iae88db612dc65930d915fb3187bd9426b56f9045
Reviewed-on: https://chromium-review.googlesource.com/1133319
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575760}

This makes ~AshService shutdown parts of GpuHost early in shutdown in hopes of
avoiding a deadlock between the raster thread and main thread.

BUG=none
TEST=none

Change-Id: I438ce9ec9eebf025abf7a5dc0f546792d2c6c9e7
Reviewed-on: https://chromium-review.googlesource.com/1140735Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575759}

This is mostly a revert of https://crrev.com/a0cf214082,
https://crrev.com/f03034d9a3c66, https://crrev.com/d2867e8cba3c,
and https://crrev.com/5fe56c3ef49a6 but some new CHECKs
added are retained as DCHECKs, and some trace instrumentation is
kept.

Bug: 857005
Change-Id: Iaa686c040122acc3d2a376c8af8c66732c1f9307
Reviewed-on: https://chromium-review.googlesource.com/1136458Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575758}

Only the first 30 seconds of the X11 session logs are kept. This
increases it to 5 minutes to capture more debugging output from the
session. For example, some session programs may be started more than
30s into the session (because of an X-GNOME-Autostart-Delay key or
the session is slow to start), and it can be helpful to see the
initial output from all startup programs.

Bug: 749215
Change-Id: I12ba7ca252719e6fba36afcd8995049c29204ec3
Reviewed-on: https://chromium-review.googlesource.com/1103542
Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575757}

Bug: 864192
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I363ac2306b0ae6c5d5eb45ac891931426e13d52a
Reviewed-on: https://chromium-review.googlesource.com/1140434Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575756}

NOTRY=true  # Flake

Bug: 857283
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: I28b99bebbd705045c2f62a74d1324af480483309
Reviewed-on: https://chromium-review.googlesource.com/1140688
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Simon Hatch <simonhatch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575755}

As the H264Accelerator can return a result indicating that additional data
(independently provided) is needed in order to proceed (e.g. a key is
required before the frame can be decrypted), pass the accelerator's result
up to H264Decoder::Decode() so that it can return the appropriate
result to the caller.

This CL also changes Decode() so that subsequent calls (after a
retryable result like kTryAgain or kRanOutOfSurfaces, but not kError)
resume by calling the method that previously failed again. If it
succeeds, then execution resumes from that point.

BUG=837455
TEST=new media_unittests pass

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I7fe9a8218df76aee15478d7bbf2ea516d6d2be83
Reviewed-on: https://chromium-review.googlesource.com/1117839
Commit-Queue: John Rummell <jrummell@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575754}

This change fixes a bug where shares mounted with a hostname rather than
an ip address are not remounted when a user logs out and back in.

Previously, we were storing the unresolved share_path rather than the
resolved share path that is used to mount the share.

Bug: 863513, 757625
Change-Id: I183200d9193c439f46a1609074706c5b2e2c0355
Reviewed-on: https://chromium-review.googlesource.com/1136863Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575753}

Continuation of work in bug 646094.

Preparing to activate an errorprone check to flag
context#getApplicationContext calls. The goal is to prevent storing the
resulting context as a class property, and instead use ContextUtils.

Bug: 846456
Change-Id: I059c13769179010146530e75b554acc29260abaa
Reviewed-on: https://chromium-review.googlesource.com/1140511Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Tiger Oakes <tigero@google.com>
Cr-Commit-Position: refs/heads/master@{#575752}

All implementations of this function do the same thing so we can just
call the constructor directly.

Change-Id: I9f1dfb6682302bf6294666895a7ffd2b716c1e58
Reviewed-on: https://chromium-review.googlesource.com/1139226Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575751}