GitLab

Get started tutorial code snippet was causing an error.
This update corrects this issue on tutorial page and completed file.

Bug: 834614
Change-Id: Ia3d61ef1510383b3b278ac957deeab047142fcd9
Reviewed-on: https://chromium-review.googlesource.com/1022950Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Crystal Lambert <crystallambert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552505}

Factor out "https://www.example.org/foo.dat" to a file scope constant in
spdy_network_transaction_unittest.cc.

Change-Id: I1fdb9d848d8213f8b3aa48e546370441e3d2e166
Reviewed-on: https://chromium-review.googlesource.com/1022293
Commit-Queue: Bence Béky <bnc@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552504}

Bug: 731555
Change-Id: I89002781928761b392645153658f90fb9f6f4ba9
Reviewed-on: https://chromium-review.googlesource.com/1022117Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552503}

This reverts commit ac6125e4.

Reason for revert: This change completely broke ChromeDriver for users
who run multiple instances of ChromeDriver. The seed for the new
random number generator can easily lead to same seed used by multiple
processes.

Original change's description:
> RandUtil: Add Mersene Twister Enginer to thread's local storage to avoid
> the overhead associated with seeding the generator.
> 
> One can do ~18 M (~26 M) calls per second when using
> unifom_int_distribution on top of Mersene engine versus <1M (~ 8M) calls
> per second when using the current implementation on POSIX and Windows,
> respectively.
> 
> Note that these figures are obtained when the generator is seeded once,
> otherwise the figure obtained for the suggested implementation would
> be <1M (this is for POSIX, we don't have the figure for windows).
> To that end, we use thread's local storage to seed the generator once.
> 
> Change-Id: I628d2e0ab882a9703e52b4007d53fa5cf49d4d47
> Reviewed-on: https://chromium-review.googlesource.com/982115
> Commit-Queue: Farah Charab <farahcharab@chromium.org>
> Reviewed-by: Gabriel Charette <gab@chromium.org>
> Reviewed-by: Alexander Timin <altimin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#550496}

TBR=gab@chromium.org,altimin@chromium.org,farahcharab@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I999423e955aa163c3863297ea9c81575a2ce8066
Reviewed-on: https://chromium-review.googlesource.com/1022250Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552502}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/263de54c..6b76faea

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: If710e264a4a418e26980fbda2011728cd810adff
Reviewed-on: https://chromium-review.googlesource.com/1021912Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552501}

Bug: 824834
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ia1ad9ddf170cd3b20f735d04074b3101023a3d05
Reviewed-on: https://chromium-review.googlesource.com/1021681
Commit-Queue: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552500}

The old code was reaching into ash to get the shelf alignment. This
won't work with out-of-process ash (see //ash/README.md). Convert to
using ash/public/cpp and profile pref.

This enables the first run browser_tests under mash.

Bug: 770866, 756057
Test: browser_tests --enable-features=Mash
Change-Id: I43b202ef255301f637593e24a588a42bacdc7fff
Reviewed-on: https://chromium-review.googlesource.com/1022523Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552499}

Bug: 835388
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I85a4f50b315dc37769d762a2de2d6e5f15a33261
Reviewed-on: https://chromium-review.googlesource.com/1022390
Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552498}

This CL adds four new metrics:
 - Logs an isolated/non-isolated bit per request
 - Logs real-delay per request
 - Logs the expected delay per request
 - Logs the queueing (i.e. unexpected) delay per request

Bug: 829042
Change-Id: Id31f3e062cda0f9b644466eb06be21b471a80d4e
Reviewed-on: https://chromium-review.googlesource.com/1021913Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552497}

The ExtensionFunction::GetAssociatedWebContentsDeprecated() method is
unpredictable and can return surprising values in certain circumstances.
It is deprecated and should be removed to ensure that callers are using
the WebContents they expect.

Update the bookmarks-related APIs (bookmarks and bookmarkManagerPrivate)
to use GetSenderWebContents() instead.

Bug: 461394
Change-Id: Ie65a5bca0a029946175ae38e75bdc0a4213dbadc
Reviewed-on: https://chromium-review.googlesource.com/1022115Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552496}

Also write parametrized unittest to cover new functionality as well
as a number of existing test cases.

Bug: 554220
Change-Id: Ib26b842e87bda13fe72f2a2a8fbf35e3d3580673
Reviewed-on: https://chromium-review.googlesource.com/1022292Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552495}

Updates the background color of Omnibox in Material Refresh.

Only affects behavior when Touchable or MD Refresh flag is on.

Bug: 823535
Change-Id: I2bf12f72011d78855edc51207f078128d9181aed
Reviewed-on: https://chromium-review.googlesource.com/1019735Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552494}

Per offline discussion w/ dcheng@, initial security concerns have been
satisfied.

Change-Id: I7915b78ce1e7d137bf0476482769822a60ffc6a9
Reviewed-on: https://chromium-review.googlesource.com/1022712Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#552493}

This effectively reverts one file in r551457 which was confusing. Add a
comment to explain what is going on.

BUG=834172

Change-Id: I27279382d1b6bbc08688a31a3dc308a791bbc37f
Reviewed-on: https://chromium-review.googlesource.com/1020068Reviewed-by: Sean Kau <skau@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552492}

Migrates from the deprecated thing to the not-deprecated thing.

Bug: 799482
Change-Id: Ic77e6a450de3b2deb03009c5d7eea17550504757
Reviewed-on: https://chromium-review.googlesource.com/999307
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552491}

This can happen legitimately (after thinking through it, I decided that trying
to prevent it would cause more potential bugs than it would solve), and in this
case, the InfoBarView has no parent.  Null-check before dereffing parent().

This is a minimal patch to make it suitable for merging to the M67 branch; a
unittest is coming separately.

BUG=834728
TEST=none

Change-Id: I1061f3a21be18f41a106098cfbc12a4c7d15b61e
Reviewed-on: https://chromium-review.googlesource.com/1019877Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552490}

- Roll src/media/cdm/api/ 57e20546b..163f87884 (1 commit)
    2018-04-17 xhwang cdm: Add CDM_11 interface

- Add CDM_11 support. But since the interface is still in development
  the support is not enabled by default.

- Update CDM_10 implementation to adapt to the interface change that
  RequestCdmProxy() has been removed. CDM_10 support is not enabled
  by default yet.

- Update browser_tests to run tests using CDM_11.

Bug: 733821
Change-Id: Id0c51468f1d426bb7445398862e8f8ffedad34a7
Reviewed-on: https://chromium-review.googlesource.com/1020881Reviewed-by: John Rummell <jrummell@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552489}

This reverts commit 5e1aa79b.

Reason for revert: broke some tests, see https://crbug.com/835379

Bug:835379

Original change's description:
> ShapeDetection: Parse landmarks of the detected face on Mac Vision
> 
> Update the mojom interface definition of landmark to match the Spec, and adjust
> the usage in services/blink/LayoutTests.
> Export eyes and mouth landmarks that detect with Mac Vision Framework, the points
> are normalized to the bounding box of the detected face, with the origin at the
> bounding box of the detected face's lower-left corner.
> 
> Link Mac 10.13 build bots [1] and Face Detection demo[2] here.
> 
> [1] https://ci.chromium.org/buildbot/chromium.fyi/Chromium%20Mac%2010.13/
> [2] https://codepen.io/miguelao/pen/PmJWro
> 
> BUG=799319
> 
> Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng
> Change-Id: Id034721a517e4ab2a6b9aa0e3eec9d10997b5b80
> Reviewed-on: https://chromium-review.googlesource.com/982579
> Reviewed-by: Miguel Casas <mcasas@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Reilly Grant <reillyg@chromium.org>
> Reviewed-by: Mark Mentovai <mark@chromium.org>
> Commit-Queue: Junwei Fu <junwei.fu@intel.com>
> Cr-Commit-Position: refs/heads/master@{#552217}

TBR=dcheng@chromium.org,reillyg@chromium.org,mcasas@chromium.org,junwei.fu@intel.com,mark@chromium.org

Change-Id: Ia6de675508ad324e12b4b9e98ae510b12d06b672
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 799319
Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng
Reviewed-on: https://chromium-review.googlesource.com/1022891Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552488}

https://chromium.googlesource.com/webm/libvpx.git/+log/be5df6080154..3b460db214b5

$ git log be5df6080..3b460db21 --date=short --no-merges --format='%ad %ae %s'
2018-04-19 martin configure: Use both check_header and check_lib for pthreads
2018-04-18 marpan vp9:aq-mode=3: Keep perc_refresh fixed for screen content mode.
2018-04-18 marpan vp9: Add condition of real-time mode to scene detection.
2018-04-18 marpan vp9: Rate control fix for CBR mode.
2018-04-18 marpan vp9: Remove limit on QP on key frame for CBR.
2018-04-16 jianj SVC: Fix duplicated run of svc datarate tests.
2018-04-16 marpan vp9: Changes for scene detection overshoot and SVC.
2018-04-17 linfengz Update variance avx2 functions
2018-04-17 marpan vp9: Remove this_key_frame_forced setting for CBR.
2018-04-16 linfengz Update variance sse2 functions
2018-04-16 jianj vp9: fix multiple run for vp9 datarate tests using one bitrate.
2018-04-14 martin configure: Test linking pthreads before using it
2018-04-12 jianj vp9: refactor vp9 datarate test for better sharding.
2018-04-13 jianj Clean up is_two_pass_svc.
2018-04-13 jianj Clean up svc comment in vp9_bitstream.c
2018-04-12 jianj Silence warning when built with --enable-internal-stats.
2018-04-11 jianj vp9 svc: Refactor svc datarate test for better sharding.
2018-04-09 jzern vpx_image: remove unused image formats
2018-03-29 paulwilkins Add extra case to wq_err_divisor()

Created with:
  roll-dep src/third_party/libvpx/source/libvpx
R=johannkoenig@google.com

Change-Id: I1a128f710a06e272100a7e96288022f9580ca5a3
Reviewed-on: https://chromium-review.googlesource.com/1022114Reviewed-by: Johann Koenig <johannkoenig@google.com>
Commit-Queue: Marco Paniconi <marpan@google.com>
Cr-Commit-Position: refs/heads/master@{#552487}

This is a preliminary change to remove the posix source exclusion
filter in a future commit.

Bug: 835405
Change-Id: I62942475e2e3b14c1fb94623213ad9b36307b5a0
Reviewed-on: https://chromium-review.googlesource.com/1022310
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552486}

There are two syntaxes to declare an Objective-C block taking
no arguments and returning no value (so of type void(^)()):
1. ^{ ... } or 2. ^() { ... }.

The syntax 1. appears to be the most popular in the codebase
with at the time of writing 11643 references while 2. only
had 58.

Conversion was automated with the following command:

    sed -i '' -e 's/\^ *() *{/^{/' $(git grep -l '\^ *() *{')

Bug: none
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ib5c609989af96a145e593c9747af041e4c175f2d
Reviewed-on: https://chromium-review.googlesource.com/1022714Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552485}

This reverts commit c24c2363.

Reason for revert: https://chromium-review.googlesource.com/c/chromium/src/+/1018590 broke webkit

Original change's description:
> Reland "Only retry failed tests for layout tests"
> 
> This reverts commit 23ea7f24.
> 
> Reason for revert: Issue fixed
> 
> Original change's description:
> > Revert "Only retry failed tests for layout tests"
> > 
> > This reverts commit ecb97ada.
> > 
> > Reason for revert: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/73246 looks invalid
> > 
> > Original change's description:
> > > Only retry failed tests for layout tests
> > > 
> > > Recently layout tests have been fairly flaky; this is causing extra load
> > > on the CQ. Every time layout tests fails, they are retried without patch
> > > to determine if the failure is a flake or a failure at tip of tree. This
> > > means that layout tests are running more than other test suites, and
> > > since layout tests take a long time to run, we end up consuming more
> > > capacity from our swarming pool than we should.
> > > 
> > > Isolated script tests don't have the ability to retry only the tests
> > > that failed, which is what other test suites do. This CL changes that so
> > > that layout tests, when re-run without the patch, retry on the tests that
> > > fail, which should significantly reduce swarming load and cycle time for
> > > running layout tests without patch.
> > > 
> > > Bug: 533481
> > > Change-Id: I1f23f6e57bcfbc44f80f11a0a96ca74d84ae8423
> > > Reviewed-on: https://chromium-review.googlesource.com/1015843
> > > Commit-Queue: Stephen Martinis <martiniss@chromium.org>
> > > Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> > > Reviewed-by: John Budorick <jbudorick@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#551821}
> > 
> > TBR=dpranke@chromium.org,martiniss@chromium.org,jbudorick@chromium.org
> > 
> > Change-Id: Ia6092ae71aad64689cdac37e6cd6524d087ff428
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 533481
> > Reviewed-on: https://chromium-review.googlesource.com/1018161
> > Reviewed-by: Stephen Martinis <martiniss@chromium.org>
> > Commit-Queue: Stephen Martinis <martiniss@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#551877}
> 
> TBR=dpranke@chromium.org,martiniss@chromium.org,jbudorick@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 533481
> Change-Id: If8c572258d9ed3abc020bc5bad56d1b06107ee0f
> Reviewed-on: https://chromium-review.googlesource.com/1022552
> Reviewed-by: Stephen Martinis <martiniss@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Commit-Queue: Stephen Martinis <martiniss@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#552482}

TBR=dpranke@chromium.org,martiniss@chromium.org,jbudorick@chromium.org

Change-Id: Ibd7819d1adb43895e33b74622438aa61517a036d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 533481
Reviewed-on: https://chromium-review.googlesource.com/1022558Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552484}

The function was only ever called with a block wrapped into a
base::Closure via base::BindBlockArc, so change the function
to take a block directly and create the closure internally.

Rename the function to RunBlockOnIOThread to reflect its new
prototype.

Bug: none
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I42fd666f51b21a345d99b866d72984fcb2292cca
Reviewed-on: https://chromium-review.googlesource.com/1020455
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: Mohammad Refaat <mrefaat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552483}

This reverts commit 23ea7f24.

Reason for revert: Issue fixed

Original change's description:
> Revert "Only retry failed tests for layout tests"
> 
> This reverts commit ecb97ada.
> 
> Reason for revert: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/73246 looks invalid
> 
> Original change's description:
> > Only retry failed tests for layout tests
> > 
> > Recently layout tests have been fairly flaky; this is causing extra load
> > on the CQ. Every time layout tests fails, they are retried without patch
> > to determine if the failure is a flake or a failure at tip of tree. This
> > means that layout tests are running more than other test suites, and
> > since layout tests take a long time to run, we end up consuming more
> > capacity from our swarming pool than we should.
> > 
> > Isolated script tests don't have the ability to retry only the tests
> > that failed, which is what other test suites do. This CL changes that so
> > that layout tests, when re-run without the patch, retry on the tests that
> > fail, which should significantly reduce swarming load and cycle time for
> > running layout tests without patch.
> > 
> > Bug: 533481
> > Change-Id: I1f23f6e57bcfbc44f80f11a0a96ca74d84ae8423
> > Reviewed-on: https://chromium-review.googlesource.com/1015843
> > Commit-Queue: Stephen Martinis <martiniss@chromium.org>
> > Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> > Reviewed-by: John Budorick <jbudorick@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#551821}
> 
> TBR=dpranke@chromium.org,martiniss@chromium.org,jbudorick@chromium.org
> 
> Change-Id: Ia6092ae71aad64689cdac37e6cd6524d087ff428
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 533481
> Reviewed-on: https://chromium-review.googlesource.com/1018161
> Reviewed-by: Stephen Martinis <martiniss@chromium.org>
> Commit-Queue: Stephen Martinis <martiniss@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#551877}

TBR=dpranke@chromium.org,martiniss@chromium.org,jbudorick@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 533481
Change-Id: If8c572258d9ed3abc020bc5bad56d1b06107ee0f
Reviewed-on: https://chromium-review.googlesource.com/1022552Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552482}

Once download becomes a service, Chrome needs to start download without
content::DownloadManager.
Split some DownloadManager functionalities into InProgressDownloadManager.
The InProgressDownloadManager will manage the InProgressCache,
and own the UrlDownloadHandlers.
This CL moves the regular URL download and navigation interception logic
into InProgressDownloadManager, so that InProgressDownloadManager now
owns the UrlDownloadHandlers.

BUG=803135

Change-Id: I97c81b9f9f3d88d5823fe8b94456e5b4d033a029
Reviewed-on: https://chromium-review.googlesource.com/1012987Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552481}

https://chromium.googlesource.com/catapult.git/+log/19f413e51156..219bbf110903

$ git log 19f413e51..219bbf110 --date=short --no-merges --format='%ad %ae %s'
2018-04-20 nednguyen Add 'skia' to the list of monorail project name

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: Ia3e7987f2e25b3b405658a41c6a2f1bef2ad0e89
Reviewed-on: https://chromium-review.googlesource.com/1022120
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#552480}

This is a preliminary change to remove the posix source exclusion
filter in a future commit.

Bug: 835405
Change-Id: Ic1cff01e66cedbe0542b86d823d8a1df4bbe69c9
Reviewed-on: https://chromium-review.googlesource.com/1022312
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552479}

It seems 'opengl' does not cover Mac configurations. Rephrase the
expectation.

Bug: 832238
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I493a86bc9c1c594f64fae6de6b11adbde4b33007
Tbr: kbr@chromium.org
No-Try: True
Reviewed-on: https://chromium-review.googlesource.com/1022731Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552478}

Seems reasonable that a trailing semicolon may come from the page
content itself, esp. since it is both an attribute separator in
CSS and a statement separator in JavaScript, and subject to mis-
interpretation when one is confused with the other.

Bug: 833793
Change-Id: Ic935c77d01c53957426ed4b02f43ab92fc27d697
Reviewed-on: https://chromium-review.googlesource.com/1015602Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552477}

Feedback from UI review is that this is intrusive (e.g. having Twitter
Lite installed as a PWA, but still viewing tweets in the browser).

BUG=782120

Change-Id: I3b9c622217916decaf49b1d1fdba14fbfa1b1824
Reviewed-on: https://chromium-review.googlesource.com/1015447
Commit-Queue: Ben Wells <benwells@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552476}

Fixes a bug where form_activity events were not being processed because
the early return condition was checking the opposite of what was desired.

Change-Id: I91e3a3c50253413559e4fbfbfc7890a3f491e8a6
Reviewed-on: https://chromium-review.googlesource.com/1022516Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552475}

https://pdfium.googlesource.com/pdfium.git/+log/e61e2f3d34ef..dd2a629f9ede

$ git log e61e2f3d3..dd2a629f9 --date=short --no-merges --format='%ad %ae %s'
2018-04-20 thestig Add CPDF_PatternCS::GetPatternRGB(const PatternValue& value).

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Ib37af720176746f67d4c267bb50630b69615c809
Reviewed-on: https://chromium-review.googlesource.com/1022478
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#552474}

This is a preliminary change to remove the posix source exclusion
filter in a future commit.

Bug: 835405
Change-Id: I6f9ca7dda2679bf7b4b1bf896ab734b35e5a3f3b
Reviewed-on: https://chromium-review.googlesource.com/1022330
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552473}

This is a preliminary change to remove the posix source exclusion
filter in a future commit.

Bug: 835405
Change-Id: I2159ba20f38c901754e19add2ae4952000f43455
Reviewed-on: https://chromium-review.googlesource.com/1022127
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552472}

Details in internal bug 78282910.

Change-Id: Ie6a26f0f1ecbc937b83644e12ae9c87b6ef66410

Bug: 835425
Change-Id: Ie6a26f0f1ecbc937b83644e12ae9c87b6ef66410
Reviewed-on: https://chromium-review.googlesource.com/1022253
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552471}

This reverts commit e3ce4282.

Reason for revert: Causing failures on webkit linux trusty leak bot https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/17952

Original change's description:
> Webkit layout test runner: Add option for zero tests executed
> 
> Adds --zero-tests-executed-ok, which makes the layout test runner exit
> with an ok status if zero tests are executed. This is important for
> re-running layout tests without patch, which we do on tryservers to
> check if the test was being flaky.
> 
> Bug: 533481
> Change-Id: I7d6bcd805b99818fdf82ecb88e71863ff72b72e7
> Reviewed-on: https://chromium-review.googlesource.com/1018590
> Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
> Reviewed-by: Jeff Carpenter <jeffcarp@chromium.org>
> Reviewed-by: Robert Ma <robertma@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Commit-Queue: Stephen Martinis <martiniss@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#552426}

TBR=qyearsley@chromium.org,dpranke@chromium.org,martiniss@chromium.org,jeffcarp@chromium.org,robertma@chromium.org

Change-Id: Ibfe5f1bc3c02354a975d058c5d6338d0762c6e34
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 533481
Reviewed-on: https://chromium-review.googlesource.com/1022555Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Jesse Doherty <jwd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552470}

TBR=smut

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Iac3cb6a37e632caf623a673622be4003a3f76014
Reviewed-on: https://chromium-review.googlesource.com/1022393
Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org>
Reviewed-by: iOS Autoroller <ios-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552469}

This is a reland of d52a1146

Original change's description:
> Temporarily disable angle_vulkan_deqp_tests.
>
> Unblocks the Vulkan roll (issues with http://crbug.com/643346).
>
> Bug: angleproject:2393
> Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> Tbr: kbr@chromium.org
> No-Try: True
> Change-Id: Icd41d0ba9abbbdd5a8d52e9f391716dbef674a34
> Reviewed-on: https://chromium-review.googlesource.com/951648
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Commit-Queue: Jamie Madill <jmadill@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#541458}

Bug: angleproject:2393
No-Try: True
Tbr: kbr@chromium.org
Change-Id: Ia72558523cbc0fcf6a609bf1ee8689e8ebf70ed8
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1022554
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552468}

This includes some base::Value cleanup in the validation code.

Bug: 832165
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id83fa0d88f6171011d7287d371a91974d14ecb78
Reviewed-on: https://chromium-review.googlesource.com/1022331Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552467}

This is a preliminary change to remove the posix source exclusion
filter in a future commit.

Bug: 835405
Change-Id: I278653320c22348d5125add79044e68e016c35d5
Reviewed-on: https://chromium-review.googlesource.com/1022128
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552466}