GitLab

When the Browser is destroyed, all OverlayRequests are cancelled.
However, if there is a presented overlay, |presenting_| will still be
true.  The active request is moved from the WebState to the
|removed_request_awaiting_dismissal_| variable until it is finished
being dismissed.

This CL checks that the active request is non-null before checking
whether the presentation context is capable of presenting its UI with
its new capabilities.  Additionally, the cancelled request is
destroyed when the Browser is destroyed so that its completion
callback can be executed.

Bug: 1065564
Change-Id: I12f4ae9b2d6090b631590a18d0314d2175822490
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135153
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757601}

https://webrtc.googlesource.com/src.git/+log/f7065f441485..5185df5cad73

git log f7065f441485..5185df5cad73 --date=short --first-parent --format='%ad %ae %s'
2020-04-08 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 32ec1c1c..e20438c5 (757394:757496)

Created with:
  gclient setdep -r src/third_party/webrtc@5185df5cad73

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I6abfbda315372e9f76a5474077b6c75bcebf1036
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142484Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#757600}

This CL moves chromeOS strings open network strings  from
settings_strings.grdp to chromeos_strings.grdp.
This CL continues the process of moving all chromeOS specific strings.

Bug: 967883
Change-Id: I32cb1c74f0a827665c105b47e5e6e762872e7e1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142574Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com>
Cr-Commit-Position: refs/heads/master@{#757599}

Bug: 1060448
Change-Id: I54a1681f9fbf05b6ec08eea8811e58f029e4d8fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140924Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Commit-Queue: Muyao Xu <muyaoxu@google.com>
Cr-Commit-Position: refs/heads/master@{#757598}

Switches away from synthetic dimensions (e.g.
"intel-hd-630-win10-stable"), as they should be unnecessary with the
implementation of the OR operator for swarming dimensions.

Bug: 1057886
Change-Id: If7ee72caef8d1a6346f827c9cd2065f2c957cee7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138508
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757597}

https://swiftshader.googlesource.com/SwiftShader.git/+log/63ed0e445fa5..1cba0a9c3a8a

git log 63ed0e445fa5..1cba0a9c3a8a --date=short --first-parent --format='%ad %ae %s'
2020-04-08 bclayton@google.com Regres: Post coverage results even if the test lists have not changed.
2020-04-08 amaiorano@google.com CMake: split out all src/OpenGL targets into their own CMakeLists
2020-04-08 amaiorano@google.com CMake: split out SwiftShader GL deps into separate files
2020-04-08 amaiorano@google.com CMake: clean up dependencies
2020-04-08 bclayton@google.com Add SystemBenchmarks.
2020-04-08 bclayton@google.com VkCommandBuffer: Remove static Cast() method

Created with:
  gclient setdep -r src/third_party/swiftshader@1cba0a9c3a8a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: swiftshader-team+autoroll@google.com
Change-Id: Ia7f87d05a2e8d10e8a6fc53b6acecbb05a4c7fa6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142209Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#757596}

The ExtensionContextMenuModel looks at the action type in order to
determine if context menu items match. Instead of using a bespoke enum,
use ActionInfo::Type directly (with a base::Optional<> to indicate no
action).

This also:
- Removes a ternary that treated TYPE_ACTION the same as TYPE_BROWSER
- Removes the action type as a member variable, since its only used in
  one place.

Finally, this helps pave the way for introducing an "action" context
for menus.

Bug: 893373
Change-Id: Ibef23864c8a849f7248cd6b73ef1dfe728962a58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132531Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757595}

https://pdfium.googlesource.com/pdfium.git/+log/afc869eaff5b..595e98f87513

git log afc869eaff5b..595e98f87513 --date=short --first-parent --format='%ad %ae %s'
2020-04-08 thestig@chromium.org Add FPDFFormFillEmbedderTest.HasFormFieldAtPointForXFADoc.
2020-04-08 thestig@chromium.org Add a <medium> to simple_xfa.{in,pdf}.
2020-04-08 thestig@chromium.org Add FPDFFormFillEmbedderTest.KeyPressWithNoFocusedAnnot.
2020-04-08 amit@pspdfkit.com Fix FindPageIndex() search algorithm.
2020-04-08 thestig@chromium.org Roll v8/ 1668abddd..5deecef68 (111 commits)
2020-04-07 tsepez@chromium.org Cover CJX_Script::stateless() from JavaScript test

Created with:
  gclient setdep -r src/third_party/pdfium@595e98f87513

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: pdfium-deps-rolls@chromium.org
Change-Id: Ia1211074f63cbbdb5a60241bf9373c33341ae77f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142482Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#757594}

In order to allow decoding off the GPU main thread, this CL starts to
clean up some of the threading issues in D3D11VideoDecoder.  Most of
it is already separating "decoder thread" and "main thread" work, but
this cleans up some of the remaining instances.

This CL doesn't actually change threads, though it does cause an
extra post during init and when sending pictures.  However, both
of these likely cause no visible latency, since they're not sync.

Change-Id: Ib5ea5c40c465efe129e0e9096c218d277e4af53c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118219
Commit-Queue: Frank Liberato <liberato@chromium.org>
Reviewed-by: Ted Meyer <tmathmeyer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757593}

CL adds <title>, <link>s and <meta name=assert> entries to the
original test, and moves it to external/wpt/css/filter-effects/.

Target location/name:
external/wpt/css/filter-effects/effect-reference-feimage-002.html

Associated TestExpectations entries are also updated.

BUG=968791,1063749
R=fs@opera.com

Change-Id: I5f386156497b891abbd46dd8b4c600274de316a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141595
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#757592}

When not clickable, the PaymentRequestRowView needs to disable its
Button behavior but still allow its children to receive events.
View::SetEnabled(false) will disable both. This changes it to just set
the Button state instead.

Fixed: 1068872
Change-Id: I3ee43a6f4fd9d9c48578ba4f5c7b90e67243897f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142147Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757591}

According to the HTML Standard [1]:

> An element with the tabindex attribute specified is interactive
> content.

In a subsequent review [2], this clause is reaffirmed by the editor of
HTML. Thus, we implement this accordingly.

This commit also adds comprehensive testing for all kinds of interactive
content, which have differential treatment by the <label> element
relative to other elements.

[1]: https://html.spec.whatwg.org/C/#the-tabindex-attribute
[2]: https://github.com/whatwg/html/issues/5414

Fixed: 1065048
Change-Id: I8deff810fead2c9170e18dd4d06dc642f68e6742
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122369
Commit-Queue: Timothy Gu <timothygu@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757590}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/3d1d9352..2f3157ba

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Iecc415335c1d3edf3cf6203a5ac7987fc6d97908
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141349Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#757589}

The ForceLoadAtTop origin trial feature provides the same functionality
as the ForceLoadAtTop document policy (see bug). Since the document
policies feature has not shipped yet, this origin trial bridges this
gap to provide an opt-out for scroll to text.

Intent to experiment:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/ONn6qsdwHUo/zHqyNL46BQAJ

Bug: 1047900
Change-Id: I3c29470775158f6dcb84ec3ddb9f76cbda79ae6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134935
Commit-Queue: Nick Burris <nburris@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757588}

This renames "flag-ui.md" to "developer-ui.md." This reorders the doc to
put flag UI content in its own section, and adds an empty section for
the crash UI.

This adds the user guide to the navbar.

Bug: 1058571
Test: tools/md_browser/md_browser.py
Test: Upload to gerrit > open file > click "gitiles"
Change-Id: I8ec1ba45e0e9461164298df13d6cb21df087c99e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142376Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757587}

Non-immersive fullscreen mode (i.e. youtube video pressed with
app fullscreen button) is too easy to exit by accident by tapping on
the top/bottom edge. This CL changes that logic to be a swipe instead.

The swipe is same logic as shelf swipe but needs to be started on the
edge. Also moved tests to a new file.

Test: added tests
Bug: 497784
Change-Id: Id197d1109d39d89467d844d8b82c72f9a3547540
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138552Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757586}

Bug: 1068792
Change-Id: Ide572da6ab9bb79e4aeb5c029c711f3feed456fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141439Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Lily Chen <chlily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757585}

Fix and reland https://crrev.com/c/2133237 which was reverted in
https://crrev.com/c/2141207.

Add a new field to SiteforCookies which is used to indicate if |this|
would be the same when considered with schemeful same-site.

The field is updated in the browser and renderer when th computation for
a sub-frame's SiteForCookies is done.

This CL is groundwork for implementing schemeful same-site and thus
nothing is done with this new field yet.

Tbr:chlily@chromium.org,dcheng@chromium.org,morlovich@chromium.org

Bug: 1030938
Change-Id: Ie532e548a9842682170e8f97c7a44337013bbcbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142133
Commit-Queue: Steven Bingler <bingler@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
Reviewed-by: Lily Chen <chlily@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Steven Bingler <bingler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757584}

This removes WebView's logic for backfilling install date with
PackageManager, as well as its special handling of UMA enabled date.
This code can be removed since we've been persisting the relevant prefs
for a few milestones (since M79 and M80). This also removes the
now-obsolete histogram.

This completely deletes aw_metrics_service_client_unittest.cc, since all
logic lives in //components/embedder_support/android/metrics/ now.

After this change, clients who haven't already persisted these values
will get the following values:
* A client with client_id but no install date will initialize install
  date to the current time (with rounding). This is consistent with
  Chrome.
* A client with client_id but no UMA enabled date will leave enabled
  date empty.
* A client without client_id will be treated like a first-time client,
  and will receive a client_id, initialize both install date and UMA
  enabled date to the current time (with rounding). This is consistent
  with Chrome.

Fixed: 1012025, 995544, 1066015
Test: N/A
Change-Id: I07b63795fda2be2e01765ca0493282bc2e5f835e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138269Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757583}

If one attempts to show multiple paint previews of the same tab we
currently layer multiple atop each other resulting in prior versions
being orphaned and stuck in the Tab's ContentView. Instead we should
prevent showing multiple times.

We could optionally add a toast here to indicate an abort occurred,
but it would be better to just use the UI elements we intend to use for
other usecases when they are ready.

Bug: 1069177
Change-Id: I0251a17cd7ce819c9d2644a3efe58d9d8b6204da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142398
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: Mehran Mahmoudi <mahmoudi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757582}

This will help with debugging sync inside ChromeWebView

Bug: 1062743
Change-Id: Id36978b79f7f733a6fdc74706689321155c443a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108907
Commit-Queue: John Wu <jzw@chromium.org>
Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757581}

Often testers and users need to generate system logs for debugging.
(See issue for details on why this is important / helpful).

Currently these only include logs gathered by debugd, and Chrome user
logs.

Feedback reports also gather "device logs" (chrome://device-logs) that
can be helpful for investigating networking issues.

This CL provides a separate section for writing system_logs.txt.zip to
the Downloads directory instead of the individual files gathered by
debugd, with text explaining the differences and encouraging the use
of system_logs for attaching to issues or sending to developers since
that file is compatible with logprocessor and Android Bug Tool for
easier analysis.

Note: No existing functionality has been removed.

Bug: 841441
Change-Id: I1d0423eff8c6e43cfec0b4d24e81e174ef09a1af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136049
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757580}

This reverts commit 6c9ac769.

Reason for revert: LegacyCleanupsTest.Do fails deterministically (Step "setup_unittests" failing on 2 builder(s)). See https://crbug.com/1069212 for more information.

Original change's description:
> Remove multi-install remnants
> 
> The multi-install support was deactivated in 2017 but there were still
> many remnants remaining in the Chromium code base.  These remnants have
> been a source of friction for changes being made in the install and
> update infrastructure.
> 
> Some additional house-keeping is included by reviewer request.
> 
> TBR=rsesek@chromium.org
> NOTRY=TRUE
> 
> Bug: 1067489
> Change-Id: I75d6f633a5ec2132470e3c88fd64c9d080e5c58b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135203
> Reviewed-by: Greg Thompson <grt@chromium.org>
> Reviewed-by: Robert Sesek <rsesek@chromium.org>
> Commit-Queue: Greg Thompson <grt@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#757502}

TBR=rsesek@chromium.org,grt@chromium.org,jxiang@google.com,brianman@microsoft.com

Change-Id: Idc8798de6abde47451f7276b616139c53bb081f3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1067489, 1069212
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141009Reviewed-by: Darwin Huang <huangdarwin@chromium.org>
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757579}

This CL in conjunction with https://crrev.com/c/2142163 allows us to
better distinguish java build steps.

Example:
Time by build-step type:
  10.1 s weighted time to generate 678 .mojom-shared.o files (5555.1 s elapsed time sum)
  11.9 s weighted time to generate 1 .resource_ids files (11.9 s elapsed time sum)
  13.3 s weighted time to generate 296 .bytecode-rewritten.jar files (407.3 s elapsed time sum)
  15.4 s weighted time to generate 311 .jetified.jar files (505.0 s elapsed time sum)
  17.6 s weighted time to generate 6141 .stamp files (3093.7 s elapsed time sum)
  21.3 s weighted time to generate 244 .javac.jar files (1588.1 s elapsed time sum)
  26.1 s weighted time to generate 160 .lint.stamp files (2545.7 s elapsed time sum)
  29.6 s weighted time to generate 162 .errorprone.stamp files (1592.9 s elapsed time sum)
  62.4 s weighted time to generate 319 .dex.jar files (1794.8 s elapsed time sum)
 146.9 s weighted time to generate 21403 .o files (244220.0 s elapsed time sum)
418.0 s weighted time (291862.9 s elapsed time sum, 698.2x parallelism)

Bug: 1067273
Change-Id: Id0ac5ef63c3b0a9f4849ade5e20c9eb896f93917
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142395Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757578}

At a fundamental level, TrustTokenStore requires that all of its
url::Origin arguments have unique serializations, in order to key
persistent state by their serializations. It currently enforces this by
requiring that all of its operations' origin parameters be non-opaque
and either HTTP or HTTPS.

SuitableTrustTokenOrigin is a url::Origin wrapper encoding slightly
stricter preconditions (IsPotentiallyTrustworthy and HTTP or HTTPS) under
which an origin is suitable for use in a Trust Tokens operation.

This change modifies TrustTokenStore's interface to take
SuitableTrustTokenOrigins rather than url::Origins.

SuitableTrustTokenOrigin's properties are not exactly the same as what
TrustTokenStore needs to require in order to satisfy its contract (put
in state keyed to an origin, get out state corresponding to the same
origin), but all use of the store is expected to be of origins that
satisfy SuitableTrustTokenOrigin's requirements, so the difference
between the preconditions it enforces and TrustTokenStore's current
interface seems mostly academic.

This change makes the interface much simpler (not to mention safer) as
preconditions can now be enforced implicitly rather than through method
comments and DCHECKs.

R=csharrison

Bug: 1042962
Change-Id: I38db356efe0d85f76662d814ee973c0e2a5c9349
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134598
Commit-Queue: David Van Cleve <davidvc@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Auto-Submit: David Van Cleve <davidvc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757577}

Bug: 1025622
Change-Id: I3a704f734cb8c69bb5fc2ce14b0ac6ce71c630d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135898Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757576}

https://chromium.googlesource.com/openscreen.git/+log/e998a6b46ddd..56e977406c83

git log e998a6b46ddd..56e977406c83 --date=short --first-parent --format='%ad %ae %s'
2020-04-08 jophba@chromium.org Change mixin name from jessie to stretch
2020-04-08 jophba@chromium.org Move from jessie to strech
2020-04-08 jophba@chromium.org Add jessie mixin to arm64_debug trybot

Created with:
  gclient setdep -r src/third_party/openscreen/src@56e977406c83

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/openscreen-chromium
Please CC jophba@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: jophba@chromium.org
Change-Id: I741e3540a16587b8a50c9afce3e0f79fc6078297
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142207Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#757575}

Prior to this CL, the ordering of the manually assigned nodes is not
preserved. Nodes were assigned in tree-order. In addition, assignment
is not absolute. A slotable node can be assign to multiple slots, and
where it appears is when the assigned slot first appear in a tree-order
traversal, not the last slot the node is assigned to.

This CL does two things. One, the order of manually assigned node is
preserved. Two, assignment is absolute. The implementation uses a
HeapHashMap, candidate_assigned_slot_map_, to keep track of
assignment node -> slot. It uses this map during node assignment to
find if another assigned slot exists. When found, the node is
removed from the previously assigned slot.

Preserving the ordering of manually assigned nodes is done in
HTMLSlotElement::UpdateManuallyAssignedNodesOrdering(). This is called
at the end of SlotAssignment::RecalcAssignment(). RecalcAssignment()
walks the ShadowHost's children in tree-order, so the assigned node
could be out of order from how these nodes were assigned.  I thought
about making a separate function for manually assigned nodes, looping
though assigned nodes instead. But I decided against it at this point
due to the complexity of the recalc function.

For Reference: point 1 in this comment is addressed by this CL.
https://github.com/whatwg/html/issues/3534#issuecomment-537802687


Bug: 869308
Change-Id: Idc45cb593313b00f13cd5f29df8972bfe246ecce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103403Reviewed-by: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Yu Han <yuzhehan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757574}

With this feature enabled, the following changes will be in effect:
1) ResizeObserverSize inteface will be exposed
2) Content box, border box, and device pixel border box can be
observed by the resize observer

Intent to Prototype and Ship:
groups.google.com/a/chromium.org/d/msg/blink-dev/_j6K_xSxWj0/fbn4kzx9AgAJ

Bug: 1027684
Change-Id: Iea04bbfd24ad6508dad04bc8bb218709926cb6d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138117Reviewed-by: Daniel Libby <dlibby@microsoft.com>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Sahir Vellani <sahir.vellani@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#757573}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ac1817c5d036..237b8541c13f

git log ac1817c5d036..237b8541c13f --date=short --first-parent --format='%ad %ae %s'
2020-04-08 kahinds@microsoft.com Fix color contrast for string, symbol, and regex object values
2020-04-08 tvanderlippe@chromium.org Use typescript-eslint parser for localizability pipeline

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@237b8541c13f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1066549
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Ife4b7a1900ad4b123f7ad5efcc2540f214ccaa76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142477Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#757572}

Removed test-only methods from CastRunner, WebContentRunner and
CastComponent that were previously used in
cast_runner_integration_tests.

1. Removed CastRunner and WebContentRunner constructors that take
web.Context. Now context is always created in WebContentRunner.
2. Removed test-only methods.
3. Updated TestComponentContext to allow initialization with all
services cloned from /svc.

The tests now inject a script into the frame in order to test
functionality that was previously tested with the test-only methods.

Bug: 1062351
Change-Id: I169651b68e0e9344d3450371db1485d9046c5c16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135154
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757571}

TBR=govind@chromium.org

Change-Id: I76305d78e09b70a7a1f8be1b503137362a47e2df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142472Reviewed-by: Ben Mason <benmason@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Commit-Queue: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757570}

- Edit policy_templates.json to enable the policy on ios.
- Add EGtest to verify that the policy sets the pref properly.
- Encapsulate a helper function to verify bool type policy in EGtest.

Bug: 1065143
Change-Id: I75b240a0f14dedf25819d0fd6160de999325cdbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138291
Commit-Queue: Tina Wang <tinazwang@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: sebsg <sebsg@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757569}

This needs to move to a shared location so that the same code can
be used by the Chromoting host.

Change-Id: If860352ef8583d47f268d5cb5b964e3c7f0a2f25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141214Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Gary Kacmarcik <garykac@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757568}

Add a private method NicknameAndLastFourDigits to return "Nickname
****1234" string and introduce HasValidNickname function to check
whether the nickname is valid.

Also introduce experiment flag and expose public method
NicknameOrNetworkAndLastFourDigits(), it will return
"Nickname  ****1234" when experiment flag is on && nickname is valid
and return "Network  ****1234" when disabled or invalid nickname.

Follow up will be update the credit card suggestion value/label using
NicknameOrNetworkAndLastFourDigits().

Bug: 1059087
Change-Id: I92603d1ca8c4113dbafba017677b09c27b7010d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138154
Commit-Queue: Sujie Zhu <sujiezhu@google.com>
Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Siyu An <siyua@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757567}

Bug: 1068792
Change-Id: I47df5c385a7b5fc67cca14ac92a94b2d1ceb32c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141142Reviewed-by: Wei Li <weili@chromium.org>
Commit-Queue: Lily Chen <chlily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757566}

This change will allow Voice search to have access to a Browser in
preparation for classes to be Browser-scoped.

Bug: 790886
Change-Id: Ib80e432e1a84df0c868bcf5b12d4c98138028695
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138169
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757565}

This reland adjusts the PrivacyPageTests cleanup function to ensure all
tests start with a default route of chrome://settings/

Original change's description:
> Ensure cookie_controls_mode is set with block_third_party_cookies
>
> To ensure that the two related preferences, cookie_controls_mode and
> block_third_party_cookies remain in a consistent state, this CL updates
> the existing block_third_party_cookies toggle located in settings
> to update both preferences.
>
> Bug: 1068144
> Change-Id: Ia64cb37c766a3143c6ac986efc67e87283852a8c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134261
> Reviewed-by: Christian Dullweber <dullweber@chromium.org>
> Reviewed-by: dpapad <dpapad@chromium.org>
> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com>
> Cr-Commit-Position: refs/heads/master@{#757019}

Bug: 1068144
Change-Id: Icfe851c8e0300f328e5441393ec3cc4aa8113def
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141912Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com>
Cr-Commit-Position: refs/heads/master@{#757564}

This CL makes home screen shortcuts and WebAPKs use
CustomTabNightModeStateController as part of the WebAPK/TWA unification
effort.

BUG=1067105

Change-Id: Ifd6f06825a3a8ac4610ec4b0a53dfaf3941d98be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133379
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Glenn Hartmann <hartmanng@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757563}

Although proguard is run in release, incremental install always uses the
debug dex files, and we so we don't bother running proguard.

This elimnates a FileNotFound log message when launching an apk that was
build with is_java_debug=false incremental_install=true

Change-Id: I5a955ca2b076ebd1bc0f13a28191b72364603ebe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142633
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757562}