- 25 May, 2018 40 commits
-
-
Ehsan Karamad authored
Unlike frames, plugin elements (<embed> and <object>) are updated when their layout tree is rebuilt. However, due to an oversight, <embed> or <object> elements displaying subframes would only have the associated content view (FrameView) torn down, leaving a dangling content frame. This led to some interesting side effects: - When transitioning from a local frame to a plugin, the content frame would remain live, with JS still happily running. - When transitioning from a remote frame to a plugin, - When navigating a remote frame from one URL to another, the element would stop updating since the FrameView would be torn down but a new one would never be created. Note that this was not (as much of) a problem for local frames, since local frames re-create the LocalFrameView on every navigation. With this CL, if a plugin element has an associated content frame, use that to clean up the state associated with the element when the layout tree is detached. This can cause the browser context to be re-created: this matches the behavior of Edge and Firefox. Note that there is still one edge case where Blink behaves oddly: if the navigation fails and should display fallback content, the content frame still remains attached. This will be addressed in followups. Link to whatwg issue: https://github.com/whatwg/html/issues/3576 Bug: 776510, 781880 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Id18605fbe602ea6c0076c1d579345cdcf28cc984 Reviewed-on: https://chromium-review.googlesource.com/996314 Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#561768}
-
Stuart Langley authored
Currently change_list_loader and directory_loader only work for the users default corpus. We can fix this by passing the team_drive_id and the root_entry_path as parameters during construction rather then just assuming the users default corpus root. With this change we can not use directory_loader and change_list_loader to also processes changes from team drives by passing the appropriate team_drive_id and root_entry_path. Bug: 835703, 833690 Change-Id: I5ba3ed8fa3323dfd520c9e1837934eeef79a30a7 Reviewed-on: https://chromium-review.googlesource.com/1068642 Commit-Queue: Stuart Langley <slangley@chromium.org> Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Cr-Commit-Position: refs/heads/master@{#561767}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 376a94c1. With Chromium commits locally applied on WPT: 7a0d5e18 "[Mojo Blob URLs] Handle more navigation cases." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/18539 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=kereliuk No-Export: true Change-Id: I79c8700e152738718535e8f26d1b63c37f6ac966 Reviewed-on: https://chromium-review.googlesource.com/1072694 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#561766}
-
Trent Apted authored
Flaky. TBR=fsamuel@chromium.org,phoglund@chromium.org Bug: 846554 Change-Id: I4eb5ef90717fd417aae68ef843365ad7cafaa87f Reviewed-on: https://chromium-review.googlesource.com/1073031 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#561765}
-
chcunningham authored
Using "max" minimizes the chance of creating gaps in the buffered range due to bad estimates (see bug). We previously used "min" out fear that max would trigger bad audio splicing. But this CL deprecates splicing on overlapped audio buffers that contain estimated durations. This is safe after UMA demonstrated that no one splices on these buffers at this time. This CL also removes the additional info about estimation confidence from StreamParserBuffer. This was originally added to see if it would help us preserve some portion of desired splices... but there were no splices to save, so it's just needless complexity. Bug: 396634 Test: New unit test, Verified fixed repro from bug Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ic0d533759b2abc269f52a05c1275d33b223fb863 Reviewed-on: https://chromium-review.googlesource.com/1068215Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#561764}
-
Xing Liu authored
Currently when user removes files in download home, the actual file is not getting deleted on Android M, the Android DownloadManager may not delete the file when calling DownloadManager.remove(). This bug is introduced in: https://chromium.googlesource.com/chromium/src/+/63c0b59001b40d4221aa87c332828793e5090690 between commit 13 and 14: https://chromium-review.googlesource.com/c/chromium/src/+/577720/13..14/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryItemWrapper.java We need to return false here to let DownloadManagerUI to delete the actual file in here: https://chromium.googlesource.com/chromium/src/+/68.0.3439.0/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java#164 In native code, we only remove the history db record for completed download, and in Java, we remove the download through Android DownloadManager. Bug: 844713 Change-Id: Idf6e5ec870eaef92aaa8698c27b2c1ab283679e6 Reviewed-on: https://chromium-review.googlesource.com/1072424Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#561763}
-
Michael Lippautz authored
Add unit tests that make sure that visitor dispatch reaches the expected leafs. Bug: chromium:841830 Change-Id: I7dba068b66759312a41adfd0a2090af8b007e6fe Reviewed-on: https://chromium-review.googlesource.com/1072212Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#561762}
-
Tsuyoshi Horo authored
The signature header was removed from the response headers in the spec. https://github.com/WICG/webpackage/commit/f4ca17d1377bed966fdba85c03adbd798cfb5a96 (Chromium implementation is not updated yet.) So we should show the all "signature" information. Bug: 830505 Change-Id: I1e922806e2febedb66c3f4e1614d5277a6012e3d Reviewed-on: https://chromium-review.googlesource.com/1069948 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#561761}
-
Trent Apted authored
Already disabled on msan. Flaky elsewhere. TBR=rdevlin.cronin@chromium.org Bug: 846555 Change-Id: I30716c163306275720934ed0f19b3becc2488ae5 Reviewed-on: https://chromium-review.googlesource.com/1073029Reviewed-by:
-
Trent Apted authored
Flaky. It's already skipped on Mac. TBR=bokan@chromium.org Bug: 846494 Change-Id: I91e92bdb56c82c9a26bc6ff26e81ef256f9e7f9d Reviewed-on: https://chromium-review.googlesource.com/1072224Reviewed-by:
-
Tsuyoshi Horo authored
It is useful when debugging the certificate especially when failed to load the signed exchange. (When succeeded, we can view the certificate in Security panel) This CL also changes "certUrl" to optional in PDL file, because this could be null according to the spec. Bug: 830505 Change-Id: I710d91bc43bd414d03aca7d4e3dfdb9342b10500 Reviewed-on: https://chromium-review.googlesource.com/1055407 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
-
Sam McNally authored
Add implementations of chrome.fileManagerPrivate.getEntryProperties() and chrome.fileManagerPrivate.pinDriveFile() that forward requests to DriveFS via Mojo. Bug: 844292 Change-Id: I3c9d487869f864e46fb9e3275b0caae4158c5262 Reviewed-on: https://chromium-review.googlesource.com/1069961Reviewed-by:
Stuart Langley <slangley@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#561757}
-
Trent Apted authored
Maybe a rebaselining issue TBR=dgrogan@chromium.org Bug: 846557 Change-Id: I4c27cb7b162c06fcc740e1c8283d8d802bf173b7 Reviewed-on: https://chromium-review.googlesource.com/1073027Reviewed-by:
-
Emily Stark authored
This CL adds two metrics of interest for the recurrent interstitial UI that is shown when the user sees the same error code multiples times. The metrics record how often the recurrent interstitial is shown (split by overridable/nonoverridable) and when the user proceeds through a recurrent interstitial, so that we can check whether the clickthrough rate is higher for recurrent interstitials than normal SSL interstitials. I've also added an additional parameter to the field trial to control whether the recurrent error message is actually displayed on the interstitial. This allows us to configure an experiment group in which recurrent errors are tracked and histograms are recorded but the recurrent error message isn't actually shown, so that we can compare clickthrough rates for identical error conditions with and without the recurrent error message showing up. Bug: 839969 Change-Id: I3739b193b9d35e9d75dc584a77514a22a5f1356b Reviewed-on: https://chromium-review.googlesource.com/1071069 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#561755}
-
Xing Liu authored
This CL adds metrics for download location change feature, including: 1. Type of the download location dialog. 2. Result of showing the location dialog. 3. The directory picked by the user. Bug: 792775 Change-Id: I746edc3ca863ac9bacddb8cfdc5cabed66c3d8d1 Reviewed-on: https://chromium-review.googlesource.com/1071101 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
-
Chris Harrelson authored
Bug: 823365 Change-Id: If472892ad0baae4aa6352b8ce37eb61fb84e5fdc Reviewed-on: https://chromium-review.googlesource.com/1072412 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#561753}
-
Kent Tamura authored
Bindings code depends on blinkbuild. Change-Id: I0ce9b37b8a3ca951beb352a78193874531cb0682 Reviewed-on: https://chromium-review.googlesource.com/1072209Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#561752}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c02f8a85059d..0e97383613e5 $ git log c02f8a850..0e9738361 --date=short --no-merges --format='%ad %ae %s' 2018-05-24 wangxianzhu [Tracing] Remove unused resize_sensor.html and css-element-queries Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I0b40463945f848bec8bd0677cd054a2400191428 Reviewed-on: https://chromium-review.googlesource.com/1072960Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#561751}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: Ife23e22e9bf986e42c1ca35dea0bd0bfbcb44fb1 Reviewed-on: https://chromium-review.googlesource.com/1072564Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#561750}
-
rbpotter authored
Switching the order of event firing and setting turning valid caused the input to be temporarily disabled when validity changed from false to true. Revert the previous change and depend on the errorState_ instead of pages.valid. This ensures that |disabled| will always update second. Bug: 846268 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I0b4df89dc8e75fc3ba4bfc2e2018fae2aff2cf50 Reviewed-on: https://chromium-review.googlesource.com/1071827 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#561749}
-
Scott Violet authored
intercepts_events only applies at an Embedding, so that tracking at WindowServiceClient was misleading. This moves tracking of this state to Embedding. This patch shouldn't change anything, it just moves tracking of intercepts_events to where it applies (applying at the client level wasn't right, and came from old code). BUG=837684 TEST=covered by tests Change-Id: I99f9a0b32b046ee70215fb15727904a1ea346853 Reviewed-on: https://chromium-review.googlesource.com/1072369 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#561748}
-
chaopeng authored
Change-Id: Ib9c68b67b6032cc4a07038c517588b2bc18f494b Reviewed-on: https://chromium-review.googlesource.com/1072517Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Cr-Commit-Position: refs/heads/master@{#561747}
-
Alice Boxhall authored
- Rename "ShouldShowFocusRingOnMouseFocus" to "MayTriggerVirtualKeyboard" - Remove UserActionElementSet::WasFocusedByMouse() and replace with Document::LastFocusType() - Move WillCallDefaultEventHandler() implementation, which checks whether the most recent event was from the keyboard and forces style recalculation if one has occurred, up to Node from HTMLFormControlElement - Tracks HadKeyboardEvent() on Document as well - Adds many more tests for the existing :focus-visible behaviour This lays the groundwork for some future changes: - Triggering :focus-visible matching on keyboard events when an element is already focused - Potentially moving the default focus ring drawing logic out of LayoutTheme and delegating to the :focus-visible matching logic instead. Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I5dc0a00c9068dc16bcd36a1c52c706646378ca50 Reviewed-on: https://chromium-review.googlesource.com/1060717 Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#561746}
-
Mounir Lamouri authored
Removed some code that can simply rely on the Blink PictureInPictureController and made use of the DisplayType() in WMPI. Bug: None Change-Id: I7f6aac46cdd99c8a35d9ae95e1e3024e11f54960 Reviewed-on: https://chromium-review.googlesource.com/1069214 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
apacible <apacible@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#561745}
-
Stuart Langley authored
Upon reading the full list of team drives that a user has access to, if we discover any drives that are still in resource metadata but no longer in the list returned from the server we will recursively delete them. Bug: 715355 Change-Id: I1e7d4c8f9de95413a2b62c5ce07fb7672342e41c Reviewed-on: https://chromium-review.googlesource.com/1071277 Commit-Queue: Stuart Langley <slangley@chromium.org> Reviewed-by:
-
tzik authored
When MockWebMIDIAccessor works as a loopback device, it delays the data dispatch. However, it passes an expiring buffer when posting the task. That causes a UAF on a layout test. Bug: 846182 Change-Id: I016da63055fecc7c4d2eeb3f8f7286135b4020a2 Reviewed-on: https://chromium-review.googlesource.com/1071367Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
-
Brad Lassey authored
Change-Id: Icd703a923a5ec6c461b71adaff0be12769513e0d Reviewed-on: https://chromium-review.googlesource.com/1070805Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Brad Lassey <lassey@chromium.org> Cr-Commit-Position: refs/heads/master@{#561742}
-
Tao Bai authored
Bug: 839646 Change-Id: Ibfeee6aefedcc4c46b432d1f2df02089d521d214 Reviewed-on: https://chromium-review.googlesource.com/1065204Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ba1627086779..b2eda420234d $ git log ba1627086..b2eda4202 --date=short --no-merges --format='%ad %ae %s' 2018-05-24 jmadill dEQP: Add attrib init helper function. 2018-05-24 jmadill Fix style inconsistency in packed enum json. 2018-05-24 jmadill D3D9: Fix incorrect parameter to setBlendDepthRasterStates. 2018-05-24 brandon1.jones Use os.path.join instead of slashes 2018-05-24 jmadill Order packed enums according to JSON. 2018-05-24 jmadill Move packed enum code to common/ 2018-05-16 tobine Roll to latest LVL as of 5/16/18 2018-05-24 jmadill Fix run_code_generation for huge diffs. 2018-05-17 jmadill dEQP: Add EGL 1.5 getPlatformDisplay. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=lucferron@chromium.org Change-Id: Id428453daca5c336546485d3b24056383b70b99a Reviewed-on: https://chromium-review.googlesource.com/1072922 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#561740}
-
Tatsuhisa Yamaguchi authored
Bug: 637351 Test: manually verified as in the bug Change-Id: I27c833a2a9514af9b105126d1db2d0adffe358c0 Reviewed-on: https://chromium-review.googlesource.com/1059369 Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#561739}
-
Timothy Loh authored
Bug: 839676 Change-Id: I203a06e7c4136f0d359d265010bd9b74ee08426a Reviewed-on: https://chromium-review.googlesource.com/1071492 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#561738}
-
Trent Apted authored
This reverts commit 8f1ca782. Reason for revert: ash_unittests failing since https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/5825 on SplitViewTabDraggingTest.DragMaximizedWindow SplitViewTabDraggingTest.DragSnappedWindow errors like Received signal 11 <unknown> 000000000000 #4 0x7fe9f7749306 MallocBlock::FromRawPointer() #5 0x7fe9f7745daa DebugDeallocate() #6 0x7fe9f7773a73 tc_free #7 0x7fe9f77061ad (anonymous namespace)::TCFree() #8 0x7fe9f7705cf3 ShimCppDelete #9 0x7fe9f77056e5 operator delete() #10 0x7fe9f9832475 ash::wm::WindowState::DeleteDragDetails() #11 0x7fe9f977aa09 ash::DragWindowResizer::~DragWindowResizer() Also FindIt Says So :). Original change's description: > Cros splitscreen: Implement the tab dragging feature in tablet mode. > > It's an initial implementation of the feature. > > See the UI mock: https://docs.google.com/presentation/d/1zCV2v5rXFUndWC5ECMKj06i5WNbRJ-uZWyZTFxU8dEE/edit#slide=id.g21b4c071a9_0_116 > > See Doc for expected behaviors: https://docs.google.com/document/d/1rm8_JyTY883IiNNis6LGtI1jsx_WHCWm5KY7hwAGOe8/edit#heading=h.i5t24a7vxw8j > > See recorded video: https://drive.google.com/open?id=1KcqAyHrxj6zheSEkgGz-ozlg7mILrmxT > > 1) Add a new feature flag --enable-features=DragTabInTabletMode And also expose > it to chrome flag --enable-drag-tabs-in-tablet-mode > 2) Only tab(s) area can be dragged. > 3) For a maximized window, its tab(s) can be dragged out to create a new window > to either be maximized or snapped to one side of the screen, or can also be > merged back to the original window > 4) For a snapped window, its tab(s) can be dragged out to create a new window to > snap to either side of the split, or can also be merged to an existing window > to either side of the split > > Change-Id: Ieb2e8921d5c116a83e1b7998d992f8e32a904099 > Reviewed-on: https://chromium-review.googlesource.com/1020294 > Commit-Queue: Xiaoqian Dai <xdai@chromium.org> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#561620} TBR=sky@chromium.org,oshima@chromium.org,xdai@chromium.org Change-Id: If981a184d7fba350ad3776fdb2236bef6cf61b9f No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1072969Reviewed-by:
-
Trent Apted authored
If a toolkit-views MenuRunner is destroyed while a menu is open, the menu is closed. Often this occurs because the ui::MenuModel is also about to be destroyed. Normally this is fine. However, if an event has already been generated by the user to select a menu item, which hasn't yet been processed by the event queue, it's possible for a retained NSMenu to still have access to the ui:MenuModel raw pointer via its delegate (the Cocoa MenuController), causing an error. To fix, reset the MenuController when a MenuRunnerImplCocoa is released in this way. MenuRunnerImplCocoa has the only reference to MenuController so this will cause its -[MenuController dealloc] to clear itself as a delegate of the NSMenu it's still showing. Adds MenuRunnerImplCocoa.MenuRunnerImplCocoa which tickle the asan bots without the fix. Bug: 823373 Change-Id: I9fc08108569a80f6b1c279f4eeef89f4a14d9dcf Reviewed-on: https://chromium-review.googlesource.com/1071275 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#561736}
-
Trent Apted authored
This reverts commit a745fe44. Bug: 846551 Reason for revert: Suspected for failures in * http/tests/devtools/audits2/audits2-limited-run.js * http/tests/devtools/audits2/audits2-successful-run.js since https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.11%20%28dbg%29/16181 Original change's description: > DevTools: [Audits] Roll Lighthouse to v3.0-beta > > Bug: 772558, 846211 > Change-Id: I4f74ea0d4a84908d2e7c4ccfe7035ee421bdf023 > Reviewed-on: https://chromium-review.googlesource.com/1070532 > Commit-Queue: Paul Irish <paulirish@chromium.org> > Reviewed-by: Pavel Feldman <pfeldman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#561412} TBR=pfeldman@chromium.org,paulirish@chromium.org,phulce@chromium.org Change-Id: I71f125736ac908f37c3d90988b85de51f4fb283c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 772558, 846211 Reviewed-on: https://chromium-review.googlesource.com/1073008Reviewed-by:
-
Sahel Sharify authored
This cl removes the NON_BUBBLING_GESTURE from ScrollInputType since it is only used in layer_tree_host_impl_unittest.cc. On a follow up cl, I am gonna add AUTOSCROLL to the ScrollInputType. Bug: 845960 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I5c63225416e41a3a7586ac7a710fe9b472b53a10 Reviewed-on: https://chromium-review.googlesource.com/1070432 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
-
Jinsuk Kim authored
This CL deletes the API |ContentViewCore.isAlive| and lets the callsites use |WebContents.isDestroyed| (after negation) instead. !CVC.isAlive() and WebContents.isDestroyed() basically serve the same purpose that indicate WebContents (and its associated objecs) are in the destroyed state. Once they return true, no calls should be made on WebContents. WebContents now defines |mIsAlive| for the deleted api to be replaced with !WebContents.isDestroyed(). It is set to false by CVC.destroy() or native WebContentsAndroid dtor, whichever comes first, to indicate that WebContents is on its way to destruction. (WebContents.destroy() also leads to setting it to false by way of WebcontentsAndroid dtor). Bug: 598880 Change-Id: I8aa864e4efdd5c326e62c284bbda5987dc0e60a5 Reviewed-on: https://chromium-review.googlesource.com/1058728Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#561733}
-
Amos Lim authored
Use android.support.v4.content.ContextCompat#startForegroundService(Context, Intent) instead of ContextUtils.startForegroundService(Context, Intent). Bug: 769683 Change-Id: I3989dd04257e1f8ebe61228d6ec6876f04c9faba Reviewed-on: https://chromium-review.googlesource.com/1065958Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Hwanseung Lee <hwanseung@chromium.org> Cr-Commit-Position: refs/heads/master@{#561732}
-
Tetsui Ohkubo authored
This CL adds a base class for detailed view controllers in UnifiedSystemTray. A detailed view controller is owned by UnifiedSystemTrayController, and its lifetime is limited to during the detialed view is shown. For the usage of DetailedViewControllerBase, see an example of network detailed view: https://crrev.com/c/1071490 (which is still WIP). This CL also adds SystemTrayItemDetailedViewController. This class is there in order to incrementally remove the hack, and will be removed before launch. Design doc: go/cros-qs-restyling TEST=manual BUG=835733 Change-Id: I8391dd6360946f0b6cb6fc99f0644d37d824a704 Reviewed-on: https://chromium-review.googlesource.com/1071547 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
-
Nicholas Verne authored
This lets Concierge correctly associate a VM with the current user Bug: 842561 Change-Id: Id313c9d7514575850ba4961afe968acd7d797ec9 Reviewed-on: https://chromium-review.googlesource.com/1072210 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#561730}
-
Tom Anderson authored
Currently, all executables and shared libraries are expected to add the exe_and_shlib_deps dependency manually. However, it is easy to forget to do this. In such cases, the build will likely fail at the link step due to missing libc++ symbols. It may not be obvious how to fix this issue. This CL adds exe_and_shlib_deps as an implicit dependency to executable and shared_library targets so that developers don't have to manually add it. BUG=845700 R=dpranke TBR=torne Change-Id: I30edcf0bcd6559b1aaa211a42863b04bc57d4d99 Reviewed-on: https://chromium-review.googlesource.com/1069720 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#561729}
-
