- 14 Feb, 2014 40 commits
-
-
jln@chromium.org authored
> Setuid sandbox: exit(2) on SIGABRT > > The setuid sandbox waits on its one child and then dies > afterwards. > > When receiving SIGABRT, instead of dumping core, simply exit the > process. There is no interesting information to be gathered from > knowing that the process is inside waitid(2), one should look at > the child process instead. > > This patch hopes to reduce red herrings. > > BUG=334345 > NOTRY=true > R=jorgelo@chromium.org > > Review URL: https://codereview.chromium.org/165673002 TBR=jln@chromium.org Review URL: https://codereview.chromium.org/164373005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251269 0039d316-1c4b-4281-b951-d872f2087c98
-
tzik@chromium.org authored
Review URL: https://codereview.chromium.org/163013002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251268 0039d316-1c4b-4281-b951-d872f2087c98
-
davidben@chromium.org authored
Dead code. It became unused in https://codereview.chromium.org/146983002. BUG=none Review URL: https://codereview.chromium.org/165223005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251267 0039d316-1c4b-4281-b951-d872f2087c98
-
aurimas@chromium.org authored
SCTs viewer is only used by Views and should not be included in other platforms. TBR=newt BUG=326023 Review URL: https://codereview.chromium.org/163983003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251266 0039d316-1c4b-4281-b951-d872f2087c98
-
jln@chromium.org authored
The setuid sandbox waits on its one child and then dies afterwards. When receiving SIGABRT, instead of dumping core, simply exit the process. There is no interesting information to be gathered from knowing that the process is inside waitid(2), one should look at the child process instead. This patch hopes to reduce red herrings. BUG=334345 NOTRY=true R=jorgelo@chromium.org Review URL: https://codereview.chromium.org/165673002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251265 0039d316-1c4b-4281-b951-d872f2087c98
-
horo@chromium.org authored
BUG=329786 Review URL: https://codereview.chromium.org/165793002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251264 0039d316-1c4b-4281-b951-d872f2087c98
-
bruening@google.com authored
due to data races raised on the tsan v2 bot. BUG=343802 > Trace event micro-optimization: use finer grained lock. > > GetCategoryGroupEnabledInternal is a hotspot. > It traverses an append-only list, so it's safe to use a finer-grained lock, > and avoid it altogether for the "fast path", i.e., when the category is > already known. > > BUG= > > Review URL: https://codereview.chromium.org/144423009 TBR=bulach@chromium.org Review URL: https://codereview.chromium.org/163613006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251262 0039d316-1c4b-4281-b951-d872f2087c98
-
mkearney@chromium.org authored
Review URL: https://codereview.chromium.org/164923002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251259 0039d316-1c4b-4281-b951-d872f2087c98
-
wtc@chromium.org authored
Remove the client_address member from QuicCryptoNegotiatedParameters. Replace it by the client_address_ member of QuicConnectionLogger. Add kCADR support to CryptoHandshakeMessage::DebugStringInternal. R=jar@chromium.org,rch@chromium.org BUG=none TEST=none Review URL: https://codereview.chromium.org/159143007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251258 0039d316-1c4b-4281-b951-d872f2087c98
-
groby@chromium.org authored
Mirrors Views' IMAGE_GRID macro, reducing boilerplate code. BUG=none R=rsesek@chromium.org Review URL: https://codereview.chromium.org/160253005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251257 0039d316-1c4b-4281-b951-d872f2087c98
-
bengr@chromium.org authored
This new header conforms to RFC 2616. With this change, both the old and new header will be supported. Eventually, support for the old header will be removed. BUG=340333 Review URL: https://codereview.chromium.org/156373002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251256 0039d316-1c4b-4281-b951-d872f2087c98
-
xhwang@chromium.org authored
So that the string can be directly copied into histograms.xml. BUG=111542 Review URL: https://codereview.chromium.org/164253002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251255 0039d316-1c4b-4281-b951-d872f2087c98
-
tapted@chromium.org authored
To track effectiveness of the app launcher install education pages in enabling users to find, and start using, the app launcher when it is auto-enabled upon installing the first v2 packaged app from the Web Store. Histogram recording committed in http://crrev.com/250348. BUG=314235 Review URL: https://codereview.chromium.org/156963005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251254 0039d316-1c4b-4281-b951-d872f2087c98
-
davemoore@chromium.org authored
BUG=None TEST=None Review URL: https://codereview.chromium.org/165383002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251253 0039d316-1c4b-4281-b951-d872f2087c98
-
tonyg@chromium.org authored
Previously, we didn't properly clear all the network caches. 1. DNS and predictor caches were left in tact. This was fixed by calling the net benchmarking extension methods. 2. Live resources in the memory cache were left in tact. This is fixed by navigating to about:blank to destroy the old renderer. Also, --enable-net-benchmarking is supported on the stable channel, so we can remove the workaround. With this, cold loads are consistent on Android: *RESULT cold_times: page_load_time= [4637,4493,4479,4564,4611,4549] ms Avg cold_times: 4555.500000ms Sd cold_times: 62.602716ms RESULT warm_times_by_url: http___www.youtube.com_watch?v_LIJOhk6FscY= [2122,2104,2079,2094] ms Avg warm_times_by_url: 2099.750000ms Sd warm_times_by_url: 18.043928ms BUG= Review URL: https://codereview.chromium.org/165193002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251252 0039d316-1c4b-4281-b951-d872f2087c98
-
aurimas@chromium.org authored
BUG=326023 TBR=cpu Review URL: https://codereview.chromium.org/165253003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251250 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-release@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251248 0039d316-1c4b-4281-b951-d872f2087c98
-
gbillock@chromium.org authored
R=markusheinz@chromium.org Review URL: https://codereview.chromium.org/153973005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251246 0039d316-1c4b-4281-b951-d872f2087c98
-
groby@chromium.org authored
The field accessor functions for the Views test helpers only obtain values from sections that are actually active. (By virtue of the way the Views dialog is built). Match OSX to do the same. NOTRY=true BUG=none R=estade@chromium.org Review URL: https://codereview.chromium.org/162813004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251245 0039d316-1c4b-4281-b951-d872f2087c98
-
oshima@chromium.org authored
BUG=334280 TEST=WorkspaceWindowResizerTestSticky.StickToBothEdgeAndWindow Review URL: https://codereview.chromium.org/163833003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251244 0039d316-1c4b-4281-b951-d872f2087c98
-
msw@chromium.org authored
Patch Set 1 here is Lei's original patch: https://codereview.chromium.org/109623005/ That was reverted for causing http://crbug.com/343042 This performs the same cleanup without the print preview regression. (keeps ConstrainedWebDialogDelegateViewViews::CreateNonClientFrameView) BUG=166075 TEST=No behavior/appearance changes; no dialog frame regressions (print preview or otherwise). TBR=wittman@chromium.org,sky@chromium.org,thestig@chromium.org Review URL: https://codereview.chromium.org/165073002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251243 0039d316-1c4b-4281-b951-d872f2087c98
-
alekseys@chromium.org authored
BUG=176158 Review URL: https://codereview.chromium.org/158983004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251242 0039d316-1c4b-4281-b951-d872f2087c98
-
msw@chromium.org authored
TextButton will be deprecated soon; use LabelButton. Use views::Border as the AvatarLabelBorder base class. Other minor cleanup. BUG=155363 TEST=No regressions of this Windows/CrOS/LinuxAura supervised user UI. R=sky@chromium.org Review URL: https://codereview.chromium.org/163953006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251241 0039d316-1c4b-4281-b951-d872f2087c98
-
mangini@chromium.org authored
(this is a fresh copy of https://codereview.chromium.org/121713002/ with correct BaseURL) BUG=340702 NOTRY=true Review URL: https://codereview.chromium.org/149673004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251240 0039d316-1c4b-4281-b951-d872f2087c98
-
vitalybuka@chromium.org authored
BUG=317027 Review URL: https://codereview.chromium.org/163393005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251239 0039d316-1c4b-4281-b951-d872f2087c98
-
danakj@chromium.org authored
LayerIterator takes 4 parameters. One is the FrontToBack ordering but that is now the only option. The other 3 are for the type of layers, render surfaces, and the render surface layer list. The latter two are now already available as typedefs off of Layer and LayerImpl, so we only need Layer/LayerImpl in the template arguments. R=enne BUG=YAK Review URL: https://codereview.chromium.org/156603005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251238 0039d316-1c4b-4281-b951-d872f2087c98
-
kalman@chromium.org authored
R=mangini@chromium.org TBR=yoz@chromium.org Review URL: https://codereview.chromium.org/165353004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251237 0039d316-1c4b-4281-b951-d872f2087c98
-
mariakhomenko@chromium.org authored
Moves AddMatchToMap method to the common base class. Adds method parameters so that both SearchProvider and ZeroSuggestProvider can use this method. For SearchProvider this is a pure refactoring. I added some helper classes in SearchProvider to avoid duplicating code. For ZeroSuggestProvider, this introduces some additional functionality on top of what it used to have. Mainly the method may record additional metadata on the AutocompleteMatch. This metadata is not currently used by zero suggest provider and as far as I can tell will not in any way affect the operation of zero suggest provider today. In the future, some of the metadata recorded will actually be useful (e.g. I am planning to take advantage of deletion_url). BUG=338955 TBR=mpearson Review URL: https://codereview.chromium.org/158053002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251236 0039d316-1c4b-4281-b951-d872f2087c98
-
viettrungluu@chromium.org authored
R=sky@chromium.org Review URL: https://codereview.chromium.org/164693002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251235 0039d316-1c4b-4281-b951-d872f2087c98
-
kmadhusu@chromium.org authored
Creates a new helper function to extract search terms from the URL irrespective of the availability of InstantExtendedEnabledParam. Previously, InstantSearchPrerenderer invoked chrome::GetSearchTermsFromURL() to extract search terms from the search page url. chrome::GetSearchTermsFromURL() returns a valid non-empty string iff the url has an InstantExtendedEnabledParam("&espv"). If the query extraction is turned off, the search request url will not have an InstantExtendedEnabledParam. In those cases, chrome::GetSearchTermsFromURL() returns an empty string to the InstantSearchPrerenderer. To extract search terms for InstantSearchPrerenderer, we should not depend on the query extraction flag or the Instant support state of the page. Follow up of crrev.com/151813002. BUG=none TEST=none Review URL: https://codereview.chromium.org/141893009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251234 0039d316-1c4b-4281-b951-d872f2087c98
-
miu@chromium.org authored
BUG=256870 Review URL: https://codereview.chromium.org/165063002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251233 0039d316-1c4b-4281-b951-d872f2087c98
-
scottmg@chromium.org authored
BUG=341941,94925 TBR=vclarke@chromium.org Review URL: https://codereview.chromium.org/165803002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251232 0039d316-1c4b-4281-b951-d872f2087c98
-
mseaborn@chromium.org authored
This file is being added to the Chromium repo and removed from the NaCl repo. BUG=https://code.google.com/p/nativeclient/issues/detail?id=3787 TEST=NaCl SDK trybots R=binji@chromium.org, bradnelson@google.com Review URL: https://codereview.chromium.org/164323003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251230 0039d316-1c4b-4281-b951-d872f2087c98
-
hubbe@chromium.org authored
Revert of Replace PO2TS::GetPrimaryAccountId() with SMB::GetAuthenticatedAccountId. (https://codereview.chromium.org/150003004/) Reason for revert: http://build.chromium.org/p/chromium.linux/builders/Linux%20GTK%20Builder/builds/497 Original issue's description: > Replace PO2TS::GetPrimaryAccountId() with SMB::GetAuthenticatedAccountId. > > The functionality is the same, just moving the code to a new place. > > NOTRY=True > BUG=333995 > R=bauerb@chromium.org, brettw@chromium.org, joaodasilva@chromium.org, nhiroki@chromium.org, noms@chromium.org, rlarocque@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251221 TBR=joaodasilva@chromium.org,noms@chromium.org,bauerb@chromium.org,rlarocque@chromium.org,sky@chromium.org,nhiroki@chromium.org,brettw@chromium.org,rogerta@chromium.org NOTREECHECKS=true NOTRY=true BUG=333995 Review URL: https://codereview.chromium.org/165543004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251228 0039d316-1c4b-4281-b951-d872f2087c98
-
michaelpg@chromium.org authored
Test that the expected languages and keyboard layouts are available in the OOBE network screen. BUG=327034 R=nkostylev@chromium.org, achuith@chromium.org Review URL: https://codereview.chromium.org/153473004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251227 0039d316-1c4b-4281-b951-d872f2087c98
-
rdevlin.cronin@chromium.org authored
Add a missing break statement in developer_private_api.cc (I'm actually shocked this didn't cause runtime errors). TBR=finnur@chromium.org Review URL: https://codereview.chromium.org/163863003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251226 0039d316-1c4b-4281-b951-d872f2087c98
-
kalyan.kondapally@intel.com authored
We guard all calls to AppendNativeEventMask with X11 platform checks. It appends native masks and are defined only on X11 platform. This CL adds the missing check in AppendNativeEventMask. Review URL: https://codereview.chromium.org/164223002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251225 0039d316-1c4b-4281-b951-d872f2087c98
-
dtseng@google.com authored
BUG=343580 TBR=avi@chromium.org Review URL: https://codereview.chromium.org/163233005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251224 0039d316-1c4b-4281-b951-d872f2087c98
-
noamsml@chromium.org authored
It is an unused class from back when we thought we may want to have multi-account support in the devices page. BUG= Review URL: https://codereview.chromium.org/163943005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251223 0039d316-1c4b-4281-b951-d872f2087c98
-
gbillock@chromium.org authored
R=benwells@chromium.org BUG=332115 Review URL: https://codereview.chromium.org/152143003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251222 0039d316-1c4b-4281-b951-d872f2087c98
-