GitLab

This crash is caused by the following DOM structure (achieved via)
DOM manipupation:

blink::HTMLBRElement
    blink::HTMLMapElement
        blink::Text
        blink::Text
        blink::HTMLAreaElement

Note that the <br> tag has children, which is not possible via markup,
but can be generated easily with JavaScript.

In AXPosition::CreatePositionBeforeObject, the crash occurs here:

  const AXObject* parent = child.ParentObjectIncludedInTree();
  DCHECK(parent); // parent is nullptr

While there is technically a parent node in the DOM, there is no layout
node, since the tree is corrupted. The AXObject implementation for
this depends on either a valid parent node or a layout node (see
AXImageMapLink::ComputeParent). Creating an AXPosition in this state
results in the nullptr deference listed above.

An alternative would be to generate a parent specifically for
AXImageMapLink in this scenario, however I dropped that approach when
it became clear that the layout and accessibility engines hit lots of
DCHECKS when the DOM tree is invalid (as they should).

Instead, the approach taken here is to add additional resilience in
AXPosition to handle invalid parent/child relationships.

Bug: 996525
Change-Id: I598e4ac930d4caeb10ce74f6328d3a75eb9580fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830012
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703459}

See bug for full description.

Now if a tab wants to open another tab in the same group, but the other
tab would open in a different window, the group is not assigned. Calling
TabStripModel::InsertWebContentsAt() with params specifying a group that
does not exist at all in the tabstrip is (and should be) an invalid
operation.

Bug: 1011140
Change-Id: I34d9cf15ec74b96f9c5c53878f76f124fcca4d57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839015
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Auto-Submit: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703458}

By default, API transitions are disallowed.

Bug: 1011467
Change-Id: I88c537b26964443bb825c68092a9d7087d03c06b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846034Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703457}

https://skia.googlesource.com/skia.git/+log/25f416465e8d..38f0a4972a24

git log 25f416465e8d..38f0a4972a24 --date=short --no-merges --format='%ad %ae %s'
2019-10-07 csmartdalton@google.com Add GL_QCOM_TILED_RENDERING as an optional interface
2019-10-07 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-10-07 borenet@google.com [infra] Remove broken commit from go.sum
2019-10-07 brianosman@google.com Particle gallery: Add two more examples

Created with:
  gclient setdep -r src/third_party/skia@38f0a4972a24

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC kjlubick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=kjlubick@google.com

Bug: None
Change-Id: Ib587276ab78e06232fd43b991acc2497bd95f6a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845941Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#703456}

Fix all related tests.

Bug: 1008444
Change-Id: Idff548f6f9547960cb81c931e72015578bd8cf29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826991
Commit-Queue: Caroline Rising <corising@chromium.org>
Reviewed-by: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703455}

Hairlines were deprecated as part of our style long ago, but not
removed. Doing an A/B test with a "webby UI" separator first requires
this change, as we cannot guarantee pixel sizing for separators.

Still to do:
 - Replace drawn separators with a separator view in most cases
 - Simplify BrowserView and BrowserViewLayout
 - Add Webby UI separator
 - [Re]start A/B test (but safe for Beta/Stable)

Bug: 993502
Change-Id: I00c9182cb884a284060c3f9742758d694348e165
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842617Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703454}

During a payment process the merchant can change details of the
paymentRequest in response to changes in shipping address, etc. The
browser redacts the unnecessary fields from Updated payment details
before sending it to the Payment Handler.

This cl changes the redacting logic so that shipping information is
included in redacted details only when shipping is requested and the
payment handler is responsible for handling shipping address.

Bug: 984694
Change-Id: I0f5e93cb27e91565425167bfc796908c67dcd747
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842292Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Sahel Sharify <sahel@chromium.org>
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703453}

This CL is a clone of ajwong's CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1838540

This simulates an actual delete and should expose any unexpected dependencies
on RenderView::render_widget_.

This CL removes the test HandleIPCsInSwappedOutState since the test is
no longer applicable. Swapped out RenderWidgets are being removed.

Bug: 912193
Change-Id: If7241e6d69a81398cd765b7ee2f2136e08831f80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838991
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Auto-Submit: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703452}

Saved passwords should be consider consumer like
Gmail accounts and password protection warning trigger
policy should default to phishing only.

Bug: 1010764
Change-Id: Iad51602e1ccdef3b43b83ad2f053ee109e728eac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842410Reviewed-by: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Bettina Dea <bdea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703451}

I recently realized that Switch Access did not follow the convention
used by all other accessibility component extensions for naming this
function. This re-aligns the naming for code clarity.

Bug: None
Change-Id: I0b015a25e3f7fa45add834ba4401504fa31151e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674640Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Cr-Commit-Position: refs/heads/master@{#703450}

This patch updates the css for the console pin pane so that it never
exceeds 50% of the outer window.

Issue 884137 shows that when the console window height is small, the
live expression pane can overflow the console input pane making it
impossible to type into the console. This is due to the pin pane css
setting a max-height of 200px regardless of the height of the outer
window.

The fix is to update the css so that pane has a max height of 50% but
the inner container uses 200px so that it will have a height of the
smaller of the two. Allowing users to always see the input area.

See: https://imgur.com/a/GS8yA8h


Bug: 884137
Change-Id: I85337f7391a882ca107a30be2bf5c2a12f261787
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837527Reviewed-by: John Emau <John.Emau@microsoft.com>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: James Lissiak <jalissia@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#703449}

There was a bug that BaseSessionController holds weak reference to
callbacks to avoid holding callback references unnecessary. This was to
prevent potential memory leaks, however the BaseNotificationController
instance was somehow dereferenced in public release build (perhaps due
to some optimization).

This causes Cast/MediaFling to not set up media notification and
MediaSession properly.

This CL fixes the issue by making BaseSessionController holding strong
references. Clients are responsible to remove the callbacks when not
needed.

Bug: 978940
Change-Id: If2146cd2a5c3036897c61cf842e7054182b46055
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1843959Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Commit-Queue: Zhiqiang Zhang <zqzhang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703448}

The job-sheets* IPP attribute is behaving unexpectedly; until
crbug.com/1010629 is resolved, we'll just drop these attributes to not gate
printing via cups_proxy.

Bug: crbug.com/1010629
Test: confirmed printing via lp with the cups_proxy succeeds
Change-Id: I5e5443647a3d7d4d7a1834d524eacd22688851df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838491
Commit-Queue: Luum Habtemariam <luum@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703447}

First step for implementing usage of the
Windows.Devices.Geolocation WinRT API in Chromium to enable the
geolocation api to provide a more accurate geolocation position
if available, this CL:
  - Introduces a feature flag (disabled by default) to add
    a LocationProvider implementation using the
    Windows.Devices.Geolocation API.
  - Adds a skeleton LocationProviderWinrt.

Bug: 968883
Change-Id: I0a739551a13266ff22cb3de8b1480165916f25c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814391
Commit-Queue: Peter Lavallee <pelavall@microsoft.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703446}

Bug: 932256

Change-Id: I0621e289ba149b619f3c97905d7abec371e6821d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1667548Reviewed-by: Jian Li <jianli@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Commit-Queue: Dan H <harringtond@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703445}

This patchset contains two changes to the referrer policy browsertests:

1. Refactor the "reduced referrer granularity flag" tests to use
a parameterized test---this will allow easy expansion to test additional
capping logic, e.g. the "no referrers at all" flag, which is currently
missing test coverage. (This will be remedied by a follow-on CL.)
2. Add tests for subresource requests (by registering a test
server callback to inspect the `Referer` headers sent along with
the requests).

R=jochen

Bug: 1004486
Change-Id: I9bc13fe536f04829e69ba0443c6d724ffb113750
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842005
Commit-Queue: David Van Cleve <davidvc@chromium.org>
Reviewed-by: Dominic Farolino <dom@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703444}

https://webrtc.googlesource.com/src.git/+log/99a209624835..7c06777ab088

git log 99a209624835..7c06777ab088 --date=short --no-merges --format='%ad %ae %s'
2019-10-07 danilchap@webrtc.org Cleanup includes in modules/include/module_common_types.h
2019-10-07 saza@webrtc.org Delete voice_detection() pointer to submodule
2019-10-07 terelius@webrtc.org Add 100 ms network delay to the SupportsFlexFEC* tests.
2019-10-07 srte@webrtc.org Removes rtp_transport checks in AudioSendStream

Created with:
  gclient setdep -r src/third_party/webrtc@7c06777ab088

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: chromium:None
Change-Id: I1d9aa7d1a7c70eb1b7c32bb16ccd96571058ac80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845939Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#703443}

This moves the performance manager and the graph implementation
as well as the public API to a new component.

Bug: 953031
Change-Id: Ie96011bbe615e31f183da8aae24a20b6e9c79228
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829911
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Cait Phillips <caitkp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703442}

This change moves some of the commit checks from RenderFrameHostImpl into
ChildProcessSecurityPolicyImpl so that it will be easier to implement opaque origin checks
in a follow-up CL. There should be no behavior changes introduce by this CL.

Bug: 991607
Change-Id: Icda9b08ba5e08e153d028d64309f35da8ab68dd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836596Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Aaron Colwell <acolwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703441}

Bug: None
Change-Id: Icb9652eca5eb06eb568a420758c12d601d83ed11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846031
Commit-Queue: Dan Beam <dbeam@chromium.org>
Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703440}

RevocableInterfacePtr is going away. Just use a mojo::Remote instead.

BUG=978694

Change-Id: I61e9d334150822271ddc1e401e2c13c488482a85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841236Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Mario Sanchez Prada <mario@igalia.com>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703439}

Bug: 1011638
Change-Id: I4930f3a0b5fd3de08bcfd52f6f68777bdb28ed80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845224Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703438}

The CL makes sure that FrameNavigationEntry::initiator_origin is
persisted and restored by session restore.  This means that the
correct Sec-Fetch-Site is replayed after session restore (this was
broken before this CL and is now checked by a new browser test).

Bug: 976055
Change-Id: Ia655deb7b799e39e6ec240be914a65f9b6938e94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679162
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703437}

In the latest iteration of display locking, we use content-size and
rely on size containment instead of DisplayLockInducesSizeContainment.

This patch removes the unneeded code paths.

R=chrishtr@chromium.org, ikilpatrick@chromium.org, cbiesinger@chromium.org

Bug: 1011398
Change-Id: I8be4d32c82755b0033b4b6bf65cf2107d7d3b89a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844060
Commit-Queue: vmpstr <vmpstr@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703436}

Bug: 687946
Change-Id: Ia198f20b0640a2d4ee5fe0be6448be5fcc492683
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844999Reviewed-by: Manuel Rego <rego@igalia.com>
Commit-Queue: Manuel Rego <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#703435}

Removes manual highlight-path setting for bookmarks_bar_view.cc and
custom_tab_bar_view.cc.

Bug: chromium:1007546
Change-Id: I6023231a9f8ae9871b00e673dda4647d11328240
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842499Reviewed-by: Taylor Bergquist <tbergquist@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703434}

https://swiftshader.googlesource.com/SwiftShader.git/+log/036463457e5f..ae022faf53b9

git log 036463457e5f..ae022faf53b9 --date=short --no-merges --format='%ad %ae %s'
2019-10-07 amaiorano@google.com Add support for configurable subpixel precision
2019-10-07 amaiorano@google.com Use correct values for sampleStandardLocations

Created with:
  gclient setdep -r src/third_party/swiftshader@ae022faf53b9

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=swiftshader-team+autoroll@google.com

Bug: chromium:b/141676114,chromium:b/141380498
Change-Id: I97a8df103c68300a32606b4c347083244664454a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845654Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#703433}

Not launching.

Bug: None
Change-Id: I438edc1ba630f0b629e101c9d963981ac32cbcf3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758829Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Ramya Nagarajan <ramyan@chromium.org>
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703432}

Change-Id: I8373457c77dfa0ebacb02e8aeaa8de8b2a328eb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841670Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: David Dorwin <ddorwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703431}

This CL avoids calling layered_api::ResolveFetchingURL()
when built-in modules are disabled, to make the layered_api method
only called with built-in modules enabled (and keep a DCHECK() for this).

This CL also introduces a constructor for the empty ImportMap
to avoid further adding extra parameters to ImportMap ctor call sites.

Bug: 1010751
Change-Id: I12d124494b40a9f34c2a88d1e9a5a55198c92c5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839429
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703430}

Reverse the additions of IA2 localized_extended_roles for nodes without explicit aria-roledescription

A number of changes to add UIA LocalizedRoleDescriptions (and fix other
AAM mappings) for various elements, starting with
https://chromium-review.googlesource.com/c/chromium/src/+/1713867,
also opportunistically added matching IA2 localized_role_descriptions.

This turns out to regress JAWS announcements for some element types,
as JAWS does not expect these role descriptions to be present on nodes
without an explicit aria-roledescription.

The safest course here is to rewire things such that the new IA2
localized_role_descriptions are removed, while all the UIA changes are
kept in place.

Bug: 1005231
Change-Id: Ia268b2aae563b313590e10f1058b8f0454f168e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829768
Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#703429}

Extract constant files to a separate target from infobars_ui target. So
that EG2 tests can include only the constants target to access the
constants, without pulling app related targets.

Bug: 917114, 987646

Change-Id: Ic79579d955e84f8c6ae0b6c524280f0b6893bd01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842613Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703428}

LocalHistoryZeroSuggestProviderTest uses a
FakeAutocompleteProviderClient, but that class requires a very
particular creation an destruction sequence.

This CL fixes this problem, which was causing issues on ASAN bots.

In the future we should fix the FakeAutocompleteProviderClient API to
make it more obvious that it has special creation destruction
requirements.

Bug: 1010691
Change-Id: Ia5b11b548720fade377e1f9c573105213e71f975
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845991
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703427}

Change machine_level_user_cloud_policy_register_helper.h|cc to
  chrome_browser_cloud_management_helper.h|cc.
Change MachineLevelUserCloudPolicyRegistrar to
  ChromeBrowserCloudManagementRegistrar. Also change its memeber variable
  or function from *Policy* to *CloudManagement*.

Bug: 1010704
Change-Id: I7852de8d53ea0ff2b508e8f2f0b9ef762ce79c5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838332Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703426}

This is a temporary patch that is not well refactored but seems to make the following case work properly:
* Init webgl context with low-power gpu, switch tab to one using high-power, and switch back. It renders correctly now before the os switch back to low-power.

This patch doesn't work with:
* Same tab switching case where user allocated multisampled buffer under a webgl 2 context
* Same tab switching case with preseverDrawingbuffer: true.

We'd better land this patch after the gpu pixel test is landed.

Bug: 681341
Change-Id: I9c834d11ee0456545600819f2322dceb38f8a59a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812102Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Shrek Shao <shrekshao@google.com>
Cr-Commit-Position: refs/heads/master@{#703425}

Bug: 1008864
Change-Id: I992c7e31e4d31c0e815af6ec64812e7a76c2f1c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832721
Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703424}

There were some situations where list box options were not being
deselected when the selection moved to a different option. This had
the affect of screen readers getting the information which wasn't
correct. This fixes that by marking the listbox as dirty to ensure the
list box options remain in sync when the selection changes.

Bug: 980368
Change-Id: Icff41b23218ce2db7ac5437be642371894a92b07
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821902Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Jessica Tallon <jtallon@igalia.com>
Cr-Commit-Position: refs/heads/master@{#703423}

Screenshots:
* before: screen/GHotFhVJu1t
* after: screen/aV7D35oyJnx, screen/fszSEX5BcAV

R=huanzhong@chromium.org

Bug: 967668
Change-Id: Id766f0c655cb2dbf31c148fe0fd212370e5e787e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841743Reviewed-by: Huanzhong Huang <huanzhong@chromium.org>
Commit-Queue: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703422}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4102985e1427..107c97c8377d

git log 4102985e1427..107c97c8377d --date=short --no-merges --format='%ad %ae %s'
2019-10-07 raphael.kubo.da.costa@intel.com gclient_utils: Stop using execfile()

Created with:
  gclient setdep -r src/third_party/depot_tools@107c97c8377d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=agable@chromium.org

Bug: chromium:984182
Change-Id: I2d9b3e49f2161991f0daf1951f558e6bd6db220c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845653Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#703421}

SCHEMA_ALLOW_INVALID_TOPLEVEL and
SCHEMA_ALLOW_INVALID_TOPLEVEL_AND_ALLOW_UNKNOWN are not used.

SCHEMA_ALLOW_UNKNOWN_TOPLEVEL is only used in Chromoting where it's
a no-op to change it to SCHEMA_ALLOW_UNKNOWN as all Chromoting policies
RemoteAccess* are either boolean or string policies.

So, it's safe to delete these 3 strategies.
The next step is to remove SCHEMA_STRICT.

Bug: 969706
Change-Id: I9cc2f4e80840724afcd150d3cc0940a7160a6587
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836194Reviewed-by: Alexander Hendrich <hendrich@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703420}