- 17 Nov, 2017 40 commits
-
-
Jose Dapena Paz authored
Original CL: https:/crrev.com/c/767427/ > As a first step towards moving all the ATK object implementation to > ui/accessibility, we will make AXPlatformNodeAuraLinux implement as much > as possible of the features implemented only in > BrowserAccessibilityAuraLinux ATK object. > > This patch prepares AtkPlatformNodeAuraLinux to load different Atk > interfaces. Changes: - Change initalization of AuraLinuxApplication so AXNodeData is initialized before AXPlatformNode accesses to it avoiding MSAN crash. Bug: 784583,785106 Change-Id: I59804d1e859dc95fae3af06747aaa21043aed05e Reviewed-on: https://chromium-review.googlesource.com/774888 Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#517557}
-
Xiaohui Chen authored
Refactored assistant availability check to a central location. Also added a notification when policy is disabled. BUG=b:69167025 TEST=run with test domain account, see entry points disabled Change-Id: I18a3b47c4ffa8ce8cb3d18eb30315cbfec83f16d Reviewed-on: https://chromium-review.googlesource.com/776117 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#517556}
-
Egor Pasko authored
Suggesting to have prefix 'experimental.' in the benchmark name until it reaches alert-level quality. Depends on the metric being introduced in catapult with this change: https://chromium-review.googlesource.com/763232 Bug: 760498 Change-Id: Iea10f3fcb646e8533c49244b721f93fe13dd5872 Reviewed-on: https://chromium-review.googlesource.com/768738Reviewed-by:
Egor Pasko <pasko@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#517555}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/48661839..4f332747 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I695f7e02f271dc2ce25adf4ea5ea1c6a0f532be6 Reviewed-on: https://chromium-review.googlesource.com/776081Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#517554}
-
Xianzhu Wang authored
When one uses run-webkit-tests --reset-results <virtual test>, the intent is probably to rebaseline the virtual baseline instead of the existing non-virtual baseline in the fallback path. Now let it match this intent. This provides a convenient way to rebaseline a virtual test locally. Change-Id: Ibadcc51b3493582ef70027f6b5aea9550f5d510f Reviewed-on: https://chromium-review.googlesource.com/775784 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#517553}
-
khmel authored
Bug: 785203 Test: Manually Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8be2dc7d674e238a86ce696a0e76cf3061ca72b2 Reviewed-on: https://chromium-review.googlesource.com/775622Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Yury Khmel <khmel@google.com> Cr-Commit-Position: refs/heads/master@{#517552}
-
Zijie He authored
HostSessionOptions is under host folder, it cannot be referred by components within protocol / codec folders. Bug: chromium:781432 Change-Id: I23fe466b8ee60f1761797507d2ae9131a9752c56 Reviewed-on: https://chromium-review.googlesource.com/776197Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Zijie He <zijiehe@chromium.org> Cr-Commit-Position: refs/heads/master@{#517551}
-
Tom Sepez authored
Change-Id: I4054f494566b4755d7bd9e411b47f390e0c83458 Reviewed-on: https://chromium-review.googlesource.com/773498 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#517550}
-
Peter Boström authored
These strings were previously referenced in non-java code but are now only referenced by their R.string equivalents in android_chrome_strings.grd. Bug: chromium:783396 Change-Id: I2230169954a8e78fa3a1e50b95c0348e9a47dce2 Reviewed-on: https://chromium-review.googlesource.com/776338 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#517549}
-
Jun Cai authored
This CL fixes some ErrorPageTest by using test server instead of URLRequestMockHTTPJob::GetMockUrl(). Bug: 776589 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I4c14d6e6f15b2435eb6bd3ca22afe3ad6b7a8a11 Reviewed-on: https://chromium-review.googlesource.com/772872Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Yuzhu Shen <yzshen@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#517548}
-
Eugene But authored
Verified callbacks correctness with NavigationCallbacksTest.FailedNavigation integration test. Before this CL DidStartNavigation was called twice (second time for presenting error in Native Content). DidFinishNavigation was called once (also for presenting NativeContent). First DidStartNavigation did not have a matching DidStartNavigation call. This CL removes DidStartNavigation/DidFinishNavigation callbacks for for presenting error in Native Content and adds balanced DidFinishNavigation callback in handleLoadingError:. Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I3c34fb9190c6c057015d5bfc6575a8b4c20f08d7 Reviewed-on: https://chromium-review.googlesource.com/777225 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#517547}
-
Olga Sharonova authored
DCHECK() is defined like this when DCHECKs are off: #define DCHECK(condition) EAT_STREAM_PARAMETERS << !(condition) see [https://cs.chromium.org/chromium/src/base/logging.h?type=cs&sq=package:chromium&l=867] and DCHECK_CALLED_ON_VALID_THREAD() is defined to nothing in that case, so streaming version of it does not compile, see example: [https://build.chromium.org/p/tryserver.chromium.chromiumos/builders/chromeos-daisy-rel/builds/4095/steps/compile%20%28with%20patch%29/logs/stdio] Bug: Change-Id: I4959c08b2a6181051b8a74b0babef36abad83df9 Reviewed-on: https://chromium-review.googlesource.com/776595 Commit-Queue: Olga Sharonova <olka@chromium.org> Reviewed-by:
-
Sadrul Habib Chowdhury authored
Update code in content/browser to not always assume mus is hosting viz, and instead make the code more explicit. For now, mus does still host viz, of course, but that will change soon. BUG=786453 Change-Id: I51d22cbcf2da2d9c5f5ebcdb14d3fe5c0400b519 Reviewed-on: https://chromium-review.googlesource.com/775755Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#517545}
-
Victor Costan authored
Bug: Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: I1012d437fe91f243a33c3a2b03d59f9adc2edebc Reviewed-on: https://chromium-review.googlesource.com/775628Reviewed-by:
Misha Efimov <mef@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#517544}
-
David Bokan authored
Looks like the Blink rename missed converting a call-site of the ViewportDescription() getter into GetViewportDescription(). This meant the call-site was using the type's constructor which led us to report the stats for a default ViewportDescription. This patch fixes the breakage and adds tests to ensure we catch this sooner next time. Bug: 783523 Change-Id: I33ca9add76a524553e103c2ad0bae9afb9ac03be Reviewed-on: https://chromium-review.googlesource.com/775589Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#517543}
-
Hajime Hoshi authored
Change-Id: Id53c410dbfdfcdd24e463ab7e96482d030205696 Reviewed-on: https://chromium-review.googlesource.com/776553 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#517542}
-
Erik Chen authored
This CL has three components: 1) The bulk of the logic in OOP HP was refactored into ProfilingTestDriver. 2) Adds a java instrumentation test, along with a JNI shim that forwards into ProfilingTestDriver. 3) Creates a new apk: chrome_public_apk_for_test that contains the same content as chrome_public_apk, as well as native files needed for (2). chrome_public_apk_test now targets chrome_public_apk_for_test instead of chrome_public_apk. Other ideas, discarded: * Originally, I attempted to make the browser_tests target runnable on Android. The primary problem is that native test harness cannot fork or spawn processes. This is difficult to solve. More details on each of the components: (1) ProfilingTestDriver * The TracingController test was migrated to use ProfilingTestDriver, but the write-to-file test was left as-is. The latter behavior will likely be phased out, but I'll clean that up in a future CL. * gtest isn't supported for Android instrumentation tests. ProfilingTestDriver has a single function RunTest that returns a 'bool' indicating success. On failure, the class uses LOG(ERROR) to print the nature of the error. This will cause the error to be printed out on browser_test error. On instrumentation test failure, the error will be forwarded to logcat, which is available on all infra bot test runs. (2) Instrumentation test * For now, I only added a single test for the "browser" mode. Furthermore, I'm only testing the start with command-line path. (3) New apk * libchromefortest is a new shared library that contains all content from libchrome, but also contains native sources for the JNI shim. * chrome_public_apk_for_test is a new apk that contains all content from chrome_public_apk, but uses a single shared library libchromefortest rather than libchrome. This also contains java sources for the JNI shim. * There is no way to just add a second shared library to chrome_public_apk that just contains the native sources from the JNI shim without causing ODR issues. * chrome_public_test_apk now has apk_under_test = chrome_public_apk_for_test. * There is no way to add native JNI sources as a shared library to chrome_public_test_apk without causing ODR issues. Finally, this CL drastically increases the timeout to wait for native initialization. The previous timeout was 2 * CriteriaHelper.DEFAULT_MAX_TIME_TO_POLL, which flakily failed for this test. This suggests that this step/timeout is generally flaky. I increased the timeout to 20 * CriteriaHelper.DEFAULT_MAX_TIME_TO_POLL. Bug: 753218 Change-Id: Ic224b7314fff57f1770a4048aa5753f54e040b55 Reviewed-on: https://chromium-review.googlesource.com/770148 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Cr-Commit-Position: refs/heads/master@{#517541}
-
Avi Drissman authored
BUG=696454 Change-Id: I7ea839d6c9135c639b1a8a68843721142d4bf81c Reviewed-on: https://chromium-review.googlesource.com/776123Reviewed-by:
Eric Lawrence <elawrence@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
-
Xianzhu Wang authored
Repaint overlay visualizes the repaint rectangles in the text results of repaint tests. This CL brings the feature in the legacy results.html into the new test expectations page. Also slightly tweak the handling of keyboard navigation. Change-Id: I8240e38449287ac899a33a691f0e234e74575ad1 Reviewed-on: https://chromium-review.googlesource.com/776094Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#517539}
-
src-internal-roller@chromium.org authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/03c0eed54814..d79c2901f5f8 $ git log 03c0eed54..d79c2901f --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src-internal BUG=773489 The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=phajdan.jr@chromium.org Change-Id: I573802b204c6ea717fe5d8ba21ea91d2e7b2616c Reviewed-on: https://chromium-review.googlesource.com/777387Reviewed-by:
src-internal-roller . <src-internal-roller@chromium.org> Commit-Queue: src-internal-roller . <src-internal-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#517538}
-
Mehran Mahmoudi authored
Change In-Product Help UI strings (http://go/cs-iph-strings). Also fix a bug in IPH that caused a NullPointerExcepetion. Bug: 784561 Change-Id: Icad33dbacc12d8c4d186b119f90c6262ac0cf976 Reviewed-on: https://chromium-review.googlesource.com/769678 Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#517537}
-
Zijie He authored
This change adds a BandwidthEstimator interface and use it in WebrtcFrameSchedulerSimpler, so we can use different implementations to evaluate the bandwidth without fully relying on WebRTC. Currently the implementation is still WebrtcBandwidthEstimator; this change should have no logic impact. Bug: chromium:781432 Change-Id: I9f910e2d5e5c441d7f324c549e77e1786e5ed046 Reviewed-on: https://chromium-review.googlesource.com/776009 Commit-Queue: Zijie He <zijiehe@chromium.org> Reviewed-by:
-
Yuqian Li authored
Change-Id: I7da84064c8aca5841261833f0a7fa954fbf4f062 Reviewed-on: https://chromium-review.googlesource.com/757643 Commit-Queue: Yuqian Li <liyuqian@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#517535}
-
Robert Ma authored
Bug: 613387 Change-Id: I3696db30690ea6bd7de673989e2846ec186bea25 Reviewed-on: https://chromium-review.googlesource.com/775758 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#517534}
-
Caleb Rouleau authored
This prevents the waterfall from retrying failures of media_perftests. Bug: 785554 Change-Id: I5d2e044a6749c938bae1bfbf567717971623cb77 Reviewed-on: https://chromium-review.googlesource.com/773464 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#517533}
-
Evan Stade authored
Many subclasses of BrowserWithTestWindowTest create a profile manager or a ScopedTestingLocalState on their own, and this obviates the need for both. I came across this because I tried to add a reference to the browser's profile manager in production code and a unit test started failing. Rather than adding yet another TestingProfileManager in some local test class, it's added to the base class. Bug: none Change-Id: I91541165044cf58793262cca79efb00a3c9eab29 Reviewed-on: https://chromium-review.googlesource.com/768255 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
-
Krishna Govind authored
TBR=mmoss@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I38515a1b3f3a4056e6fafcf14f6d6e72ca5d3d21 Reviewed-on: https://chromium-review.googlesource.com/776066 Commit-Queue: Michael Moss <mmoss@chromium.org> Reviewed-by:
Alex Mineer <amineer@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#517531}
-
Alexey Kozyatinskiy authored
We do not support enum splitted into parts in protocol. It is preparation step before landing improved version of our code generator which will generate only used types. R=dgozman@chromium.org Bug: chromium:778796 Change-Id: I2eceb334b81e59bdb8f4c6ce415f907b7207d0da Reviewed-on: https://chromium-review.googlesource.com/775663 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#517530}
-
Xiaocheng Hu authored
Bug: 771398 Change-Id: Ibe4053be6d8b35e351e71b2e7be28e47ef41d472 Reviewed-on: https://chromium-review.googlesource.com/776406 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#517529}
-
Ashley Enstad authored
BUG=chromium:786430 Change-Id: I6e7b2878295566a15f482f932d0ba033e38daab2 Reviewed-on: https://chromium-review.googlesource.com/777029 Commit-Queue: Ashley Enstad <ashleymarie@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
-
Dmitry Skiba authored
Library loading is the first thing that happens when a renderer starts navigating to a page. NativeLibraryPreloader is called during loading and is responsible for majority of the loading time. However, unlike library loading, preloading doesn't need to know command line of the child process, and thus can happen earlier. This CL preloads libraries when a child process is bound, which speeds up navigation for warmed up renderers. Bug: 783913 Change-Id: I3bffdc613717bfc61e038a2525cd96c5d0f0c0c3 Reviewed-on: https://chromium-review.googlesource.com/757561 Commit-Queue: Dmitry Skiba <dskiba@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#517527}
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/12ab00b4d856..c296255c7ee7 $ git log 12ab00b4d..c296255c7 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I0b313642c156c74dfa3ffc639df8a9ea53ec3c1a Reviewed-on: https://chromium-review.googlesource.com/777222Reviewed-by:
WebRTC Roll Bot <webrtc-autoroll@chromium.org> Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#517526}
-
wutao authored
Currently Launcher state transition animation is using layer animation element of BoundsElement, which will SetBoundsFromAnimation on each OnProgress. This will generate additional overhead with a whole commit every frame. This cl converts it to use ThreadedTransformTransition, which will let compositor optimize and accelerate the animation. Bug:786209 Test:On Cyan and EVE Average Smoothness Improved: Cyan: 1x slow-down-compositing-scale-factor: 88% -> 100% 10x slow-down-compositing-scale-factor: 63% -> 73% 1x slow-down-compositing-scale-factor: 93% -> 99% 5x slow-down-compositing-scale-factor: 46% -> 59% EVE: Change-Id: I960421d89762ff7fcb7c4e230d98137cd3e61170 Reviewed-on: https://chromium-review.googlesource.com/776195 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#517525}
-
John Budorick authored
Bug: 782848 Change-Id: I9def38ec856a99a20cedf5f3595ee38b0cef2c8e Reviewed-on: https://chromium-review.googlesource.com/777022Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#517524}
-
Donn Denman authored
Removes the deprecated onReparentingFinished in favor of the new method onActivityAttachmentChanged. Updates callers of the old method. Bug: Change-Id: I67920b1caea804281972fbac32f91cd4509c281f Reviewed-on: https://chromium-review.googlesource.com/775733Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#517523}
-
Dominic Mazzoni authored
The goal of an accessibility hit test is to take (x, y) coordinates and map it to an element in the accessibility tree. When there are iframes, the hit test first goes to the parent frame, and if the result is an iframe element, we have to ping back to the browser process and pong to the child frame's renderer to hit test recursively. Previously this worked correctly on desktop platforms but didn't work on Chrome OS, which uses the same renderer accessibility code but doesn't share the same content/browser/accessibility implementation. Fix it just by moving that browser-side child frame hit test ping/pong to RenderFrameHostimpl. Note: this could be more efficient using RWHInputEventRouter, but that would be a much larger refactoring. Tracking that in bug 785987. Bug: 770248 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I7bdc15114f1599be5ffd9604db365d64adc0fb5c Reviewed-on: https://chromium-review.googlesource.com/747202Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#517522}
-
Mathieu Perreault authored
Currently holding on to app_locale but will soon also gain Address normalization tools. This is functionality neutral. Bug: 767931 Test: existing Change-Id: I2dfbf93b4e6b8b891c0f78b4fcde615dedf37b1e Reviewed-on: https://chromium-review.googlesource.com/775813 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#517521}
-
Jamie Madill authored
https://chromium.googlesource.com/chromium/buildtools.git/+log/9c40f80c9998..461b345a815c $ git log 9c40f80c9..461b345a8 --date=short --no-merges --format='%ad %ae %s' 2017-11-17 jmadill Add migration code for no_exceptions configs. 2017-11-16 thomasanderson Fix typo: fuschia -> fuchsia 2017-11-16 thomasanderson Always hide libunwind symbols on desktop Linux Created with: roll-dep src/buildtools TBR=brettw@chromium.org BUG=727437 Change-Id: I6dd70fd5ae642dd6a861e02913469f65e333bd19 Reviewed-on: https://chromium-review.googlesource.com/777031Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#517520}
-
Christopher Grant authored
This paves the way to plug in an AutocompleteController, and associated UI. Also, drive URL bar and WebVR toast state via model, as omnibox will require some of the same data. BUG=777542 R=vollick Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I29e96b5318e0d90b5530c12166db9fe780dba276 Reviewed-on: https://chromium-review.googlesource.com/772393 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Biao She <bshe@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#517519}
-
Mike Baxley authored
There is an EarlGrey method that does the same thing. Bug: 638674 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ic4c0d8af6397477a1653367aeddf8b8ff060f70f Reviewed-on: https://chromium-review.googlesource.com/777385 Commit-Queue: Mike Baxley <baxley@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
-
