- 17 Jul, 2019 40 commits
-
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3a51b0e9d143..b04e2561be34 git log 3a51b0e9d143..b04e2561be34 --date=short --no-merges --format='%ad %ae %s' 2019-07-17 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision b5dcfdfc..5f1aeb93 (678230:678364) 2019-07-17 crodbro@webrtc.org Add config to specify raw audio priority bitrate including overhead. Created with: gclient setdep -r src/third_party/webrtc@b04e2561be34 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I72e67edcd5a7661f2b30b29a143c2fe3a64abbfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706723Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#678465}
-
Matthew Mourgos authored
- Add new constants used for dense shelf changes and put the usage of these constants behind the dense shelf flag. Bug: 973483 Change-Id: I54fdba8cfb34f8bc72d2220f59c360e29adc5d39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682250 Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#678464}
-
Erik Chen authored
Previously, Chromium used a hermetic toolchain. This was basically a full install of Xcode, which has OS version dependencies. This CL keeps the hermetic toolchain, since it's necessary for clang + code coverage. Compilation of Chrome now uses a separate package of binaries from Xcode. This consists of a whitelist of the OS-version agnostic binaries from Xcode. These binaries do not have [relevant] OS version dependencies. Change-Id: Ie6f30b4b6b3ccd4a7538feb73d6828cfa4a02891 Bug: 965663 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673572Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#678463}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/223c459965a8..49b659419343 Created with: gclient setdep -r src-internal@49b659419343 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=pdr@google.com,grt@google.com Change-Id: Ie6bd4f6e05f2cd95e2933f601fdf79005f79e127 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706394Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#678462}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fad9fbc3c4da..d7639aff1001 git log fad9fbc3c4da..d7639aff1001 --date=short --no-merges --format='%ad %ae %s' 2019-07-17 halcanary@google.com Samples: clean up cruft 2019-07-17 fmalita@chromium.org [skottie] Remove deprecated loadImageAsset API 2019-07-17 mtklein@google.com split deaths() out of other analysis 2019-07-17 reed@google.com search for 'main' explicitly Created with: gclient setdep -r src/third_party/skia@d7639aff1001 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=nifong@google.com Change-Id: I3c76f1800f230d6fb782178b50629e9186da7554 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707064Reviewed-by:
-
Eric Karl authored
Now that viz is required, remove non-viz code from CompositorImpl and DelegatedFrameHostAndroid. Bug: 978640 Change-Id: Ia18074ea6d43baaaa0129cd48593db9a93db27c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677233 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#678460}
-
Alex Cooper authored
Adds deprecation warnings to both the flag description and the console when accessing getVRDisplays (the first entry point into WebVR), which point towards using WebXR which will be favored once it has shipped. Bug: 982472,982474 Change-Id: I4acf2dd91b20f31e67529f3f5c687ad0c5f964c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704037 Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#678459}
-
Kristi Park authored
Remove the 1 second delay before the reorder flow starts, which was not a good user experience. Screencast: https://drive.google.com/open?id=1qgzQ13d1_eZ95Wj1p7LkFeX2jt1Yhkai Bug: 963561 Change-Id: I4b9896855ef73d7b85b46e1d92eaa166666ca6ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706913Reviewed-by:
Kyle Milka <kmilka@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#678458}
-
Becky Zhou authored
+ Don't run animation when the checked state is first initialized + Add a workaround to fix an issue that clearing image tint list on L doesn't refresh the drawable state Bug: 895866, 983686 Change-Id: Id5be04a2877439aafc4da61d15bec0ca486bf26d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700466Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#678457}
-
Albert Chaulk authored
The client will use GRPC to talk to cast_shell to create and manage webviews. One RPC corresponds to a given webview and input and commands and send over this channel. Presentation is handled by wayland/exo and associating a wayland surface with a webview TEST=local test w/ desktop cast_shell & wayland_fullscreen_client BUG=b/132811925 Change-Id: I8f0da747805973174c46f1d824758c6c2ee04674 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678288 Commit-Queue: Albert Chaulk <achaulk@chromium.org> Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#678456}
-
Michael Giuffrida authored
Remove Demo Mode feature flags that have been default-enabled on Stable for 2+ milestones. Bug: None Change-Id: Ic3dd93fd3e1dfb44ba51139e3a90baf707f9e818 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699308 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#678455}
-
Alexei Svitkine authored
MockInputApi was returning MockFile objects instead of strings from LocalPaths() API, which apparently trips up Windows Python APIs, but not Unix ones. Bug: 984360 Change-Id: I0a14cc07a9406d84d6b20d104d002fe67cc4ae86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706577Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#678454}
-
Michael Giuffrida authored
Add Germany and Japan to country selector during Demo Mode setup and enroll the device into the corresponding OU. I've already created the corresponding admin-de and admin-jp users and OUs in the admin console and verified that enrolling into either of these countries works. Bug: 983278 Test: Start Demo Mode setup at Welcome screen; set up using Germany or Japan Change-Id: Ie2dbef900546fc5efb3638556c069c92d9d6f045 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699195Reviewed-by:
-
Sam Fortiner authored
This change introduces the following histogram. Compositing.Renderer.PercentPictureLayersWithTextButLCDTextDisabled.<suffix> The percentage of picture layers that include a DrawTextBlobOp but do not allow LCD-text to be used. The suffix is LessThan10, 10To30, or MoreThan30. This will be used to understand how composition decisions affect text quality. Change-Id: I8f1c2a76705d07b833631a0c8717a089eb71bb65 Bug: 984346 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693804Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Sam Fortiner <samfort@microsoft.com> Cr-Commit-Position: refs/heads/master@{#678452}
-
Alex Cooper authored
Purely mechanical changes to swap the order of params from the helpers in xr-test-utils.js to match those from webxr_util.js so that porting tests can be more straightforward. Does not address the potentially more complicated work of only one sessionMode or the test harness handling the baseLayer yet. Bug: 981003 Change-Id: I5a57b814582b88297a98c64c1fa452fe22736ee0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704697 Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#678451}
-
Mario Sanchez Prada authored
Convert the implementation and clients in the browser and renderer processes (i.e. blink::FindInPage, content::FindInPageClient) to the new types, as well as the signature of the FindInPage::SetClient() method as defined in the find_in_page.mojom file. Bug: 955171, 978694 Change-Id: I4511bb238333fe846e0e681c225dbceaa05dcf6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1701849Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#678450}
-
Nate Fischer authored
This modifies several scripts to call devil_chromium.Initialize() correctly, rather than to call script_common.InitializeEnvironment(), to use the better environment defaults provided by devil_chromium. This should reduce adb server restarts by using a consistent adb binary across all scripts. Bug: 978697 Test: Run each script with -vv, verify it defaults to the correct adb binary Test: Run each script with -vv and --adb-path, verify it uses the specified adb Change-Id: Ib792dbeacec36f5fc6cd68593d27dc947fcfc2d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705314Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#678449}
-
Harry Cutts authored
See go/cros-gesture-properties-dbus-design (Google internal only, sorry) for more details about the full design. Bug: 952054 Test: call the `GetProperty` method with this command (substituting a valid device ID): dbus-send --print-reply --system \ --dest=org.chromium.GesturePropertiesService \ /org/chromium/GesturePropertiesService \ org.chromium.GesturePropertiesServiceInterface.GetProperty \ int32:"$DEVICE_ID" string:"Log Path" Change-Id: I4b663486cf22a50f9e46611e50d35da287099fcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1589449 Commit-Queue: Harry Cutts <hcutts@chromium.org> Reviewed-by:Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#678448}
-
Istiaque Ahmed authored
This CL also runs the same test in SW based extension and non SW based extension (event page). Bug: None Test: Test only change, no changes expected. Change-Id: Iea29ddcc672b6045353a20bd0e4012e40f35abc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700650Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#678447}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c44d2c7919d7..0efe516eeaef git log c44d2c7919d7..0efe516eeaef --date=short --no-merges --format='%ad %ae %s' 2019-07-17 jmadill@chromium.org Fix egl.h compatiblity. 2019-07-17 geofflang@chromium.org Update the documentation on ANGLE's two reviewer policy. 2019-07-17 hao.x.li@intel.com Rename data_dir to angle_data_dir in GN files Created with: gclient setdep -r src/third_party/angle@0efe516eeaef The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Bug: None Change-Id: Ib4ba5643b4f6ca0d9de9de701309a2bcf81cbd0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706392Reviewed-by:
-
chrome-bot authored
Updated to this build from today: https://ci.chromium.org/p/celab/builders/ci/Windows/b8907660573818690112 Mostly reliability improvements (around RunCommand & logging). The only significant functionality change is RunCommand's default shell is powershell, which doesn't change anything most of the time except in one test where we were using cmd.exe's if syntax. Change-Id: I3aa3eb72cb14710db7b06c423fb398f110aa613b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707060Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Auto-Submit: Mathieu Binette <mbinette@google.com> Cr-Commit-Position: refs/heads/master@{#678445}
-
Wei-Yin Chen (陳威尹) authored
Add a Finch parameter "max-duty-cycle" (default 0.2) as a rate limit for the DynamicResource RecyclerView used in Grid Tab Switcher. When getBitmap() takes 10ms, max-duty-cycle = 0.2 means the refresh would be suppressed for the following 40ms so that the duty cycle (= 10 / (10 + 40)) wouldn't exceed 20%. The RecyclerView is invalidated too frequently for few visual changes. Rate-limiting the capturing reduces wasting processing power, and makes Tab-to-GTS transition animation more smooth. Bug: 964406 Change-Id: Ie3d395260c8f018f608c41b56fdcb2aff3da1c42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703805 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#678444}
-
Steve Becker authored
content::PushMessagingService is a "push service-agnostic interface that the Push API uses for talking to push messaging services like GCM." This change updates the PushMessagingService interface to improve compatibility with other push services by removing GetEndpoint(). The change also updates the PushMessagingService callbacks for subscribe() and getSubscription() to include the endpoint URL. The new callbacks provide the endpoint URL without using GetEndpoint(). Before this change, PushMessagingService::GetEndpoint() returned the absolute URL of the push service. content::PushMessagingManager created a subscription's endpoint URL by appending the subscription ID to the return value from PushMessagingService::GetEndpoint(). This scheme does not work for all push services. For example, Microsoft's push service may use a different domain for each subscription. Additionally, Microsoft's push service endpoints do not include the subscription ID. This change moves endpoint URL construction from endpoint URL construction from the content layer to the chrome layer enables Chromium embedders to replace GCM with another push service without updating the content layer. content: :PushMessagingManager to PushMessagingServiceImpl. Moving Change-Id: Ifb5ee1dc8455d1dcbc34c52c29bc40de7e97476a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704989Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Steve Becker <stevebe@microsoft.com> Cr-Commit-Position: refs/heads/master@{#678443}
-
Ryan Sleevi authored
With the introduction of QuicParams, it's now possible to default-construct a QuicParams. However, it's not self-documenting what those defaults are. As many of them are actually constants from the header themselves, align the class to initialize in-place, making it more obvious. This also updates the various time-delta based parameters of QuicParams to use base::TimeDelta, making it easier to ensure safe math, while freeing callers from needing to know about whether the units were _seconds or _milliseconds. Several members of the class already followed this pattern, this just aligns all of them. Bug: None Change-Id: Id1661af6736740dd470d713843d37b2af9b7134a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707095Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#678442}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/a552be46f95c..97028a5397fd git log a552be46f95c..97028a5397fd --date=short --no-merges --format='%ad %ae %s' 2019-07-17 yyanagisawa@chromium.org Revert "goma_util: Set default goma PLATFORM to 'chromeos' and force update." Created with: gclient setdep -r src/third_party/chromite@97028a5397fd The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I0fb2e88b2234b19fcf028cbcf35fd38066bf099b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707059Reviewed-by:
-
Harsh Patel authored
Address rewriter rules are now compressed grit resources that are uncompressed by address_rewriter.cc. This results in binary size savings of about ~33kb. Bug: 958792 Change-Id: Id39c04c20027b9663cd7f6ed6e56aa96a368c513 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695815 Commit-Queue: Harsh Patel <harshpa@google.com> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#678440}
-
Vladimir Levin authored
This patch adds a display locking fuzzer with the wpt tests as the corpus. This is using a content fuzzer base to help with the loading, and rafs a few times depending on input. R=chrishtr@chromium.org, rakina@chromium.org Change-Id: I1f1f3dd5e7711158cc1f7a148c226395939cf8d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677008 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#678439}
-
Ian Kilpatrick authored
This adds an additional bit to the NGInlineItemsBuilder similar to the is_empty_inline bit. This new bit is only true if we only have floats/OOF-positioned children present. Using this information the NGBlockNode::FirstChild / NextSibling implementations will either return an NGInlineNode (representing all the inline-level children) or just the first float/OOF node. Bug: 980908 Change-Id: I0d695fbfa4535861fe510d2e973622437627126f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704317 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#678438}
-
Anastasia Helfinstein authored
Bug: 958081 Change-Id: I1f3455e433a74faccde6b2c74f5c371cff201d90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666430Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#678437}
-
Jeffrey Kardatzke authored
We already grab the chrome log, and also grabbing the PREVIOUS log will help with diagnosing Chrome crashes. Bug: 979897 Test: Manually verified in feedback report Change-Id: If2be64ca0106097dda4693f24dac6f2e50a92e62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704033 Auto-Submit: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#678436}
-
Brian Geffon authored
As previously discussed this CL refactors the WorkingSetTrimmer into a mechanism concept and adds support for ChromeOS. After this CL is submitted the second step will be to refactor the existing observer into a platform specific policy pattern. Bug: 973963 Change-Id: Iacfc70a37f5b0a8519575359a6f842c2cd1f03f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696306Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Brian Geffon <bgeffon@chromium.org> Cr-Commit-Position: refs/heads/master@{#678435}
-
Adenilson Cavalcanti authored
The portable implementation in base is nicely written and tested but could be made way faster by using SIMD and crypto instructions. Enters BoringSSL: its SHA1 implementation is highly optimized for many architectures, actively maintained and tested. It will make SHA1 *way* faster on Intel (6x), ARMv7 (8x) and ARMv8 (between 16x to 21x faster). Plus adds a performance benchmark to measure the speed (MB/s) of the hash implementation. Unfortunately, thanks to NaCL we still got keep the portable implementation around for the time being (until it is finally removed). Change-Id: Ifc4b6a82a0d36e5157b1fa6d94760c32197b570c Bug: 974341 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661110Reviewed-by:
Adenilson Cavalcanti <cavalcantii@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> Cr-Commit-Position: refs/heads/master@{#678434}
-
Philip Rogers authored
This was missed in https://crrev.com/678392 and caused bot failures. NOTRY=true TBR=ikilpatrick@chromium.org Bug: 985079 Change-Id: I42b429dfb328e2f56cf469a036c87a675108e185 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706784Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#678433}
-
Khushal authored
When downgrading the GL version exposed to skia, we only override the GL version string. Also override the GLSL version string to ensure it is consistent with exposed GL version. R=piman@chromium.org Bug: 978354 Change-Id: I7863e627ce32863f796dd708f866aaab9d321a4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703267 Commit-Queue: Khushal <khushalsagar@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#678432}
-
Lei Zhang authored
Linux/Android has a PrintPagesNative() that is only slightly different from the Win/Mac one. Merge them and get rid of print_render_frame_helper_linux.cc. Change-Id: I3e8cc83fc8043753b6549e5df97854382fdfc1e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706029 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#678431}
-
Stephen Chenney authored
The test was waiting on a compositor frame, but not hit test data. This change converts it to use the HitTestRegionObserver to directly detect hit test region availability. Bug: 876323 Change-Id: I394b333da42acaa36cb957037ff60907dcc8a7bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707168 Auto-Submit: Stephen Chenney <schenney@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
-
Lei Zhang authored
In https://crrev.com/560879, PrintRenderFrameHelper::PrintPagesNative() started to consider the scale factor. The Linux version of PrintPagesNative() applied it consistently to every page using GetScaleFactor(), but the Windows/Mac version of PrintPagesNative() is missing a GetScaleFactor() call for the first page. The comments for patch set 15 of the CL say PrintPagesNative() is most commonly used for printing with the system dialog, where the scale factor is always 1, so the missing GetScaleFactor() call does not matter in this case. The only time when the scale factor may be set to some other value is for headless printing. Likely nobody noticed because: - Headless printing on Win/Mac is uncommon. - Headless printing with a different scale factor is uncommon. - The combination of the two is rare. Nevertheless, the missing GetScaleFactor() should be added. Change-Id: Ic4318e3bd0a9537e0170454cbdfcb7015efad237 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705643Reviewed-by:
-
dpapad authored
Bug: None Change-Id: I2e1e7dfe3d02c8330bc3739e19207e53215e97f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706813 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#678428}
-
Takuto Ikuta authored
Running some tests on xenial requires libcgmanager0 and its dependencies. https://bugs.chromium.org/p/chromium/issues/detail?id=981731#c23 I confirmed this makes device_unittests passed in Xenial https://chromium-swarm.appspot.com/task?id=4617aa5f91516710 Without this, it failed like https://chromium-swarm.appspot.com/task?id=4617a6eb7134ed10 Bug: 981731 Change-Id: I638e3ca842af0a4c403e58b2bf407faef8ea55df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699060Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#678427}
-
Kristyn Hamasaki authored
-Removed GetCustomProperties() and AppendLayerProperties() -Update ViewElement unit tests and add matched style tests -Remove any unnecessary functions from CSSAgent Change-Id: I45c048b36b476b026aa14c80366bade7487ff0af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700396 Commit-Queue: Kristyn Hamasaki <khamasaki@google.com> Reviewed-by:
Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#678426}
-
