GitLab

This moves the code into the toolkit_views source list and gates Aura
specific code behind build flags.

Additionally, this links up DesktopMediaPicker::Create in a manner
similar to ScreenCaptureNotificationUI::Create[Cocoa].

BUG=726005,657883
NOAUTOREVERT=true
Need to investigate any failure on the Mac Bot. Not reproducible locally.

Change-Id: I9ece0b875268495d70154378c7608c3e1bae2938
Reviewed-on: https://chromium-review.googlesource.com/1102042
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569095}

Change-Id: Id68cad067bb35f3b11bd8828806860110e8aaf79
Reviewed-on: https://chromium-review.googlesource.com/1103304
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569094}

- Restores pointer events (including scrolling) to HTML preview.
- Prevents accidentally focusing inputs/links inside the preview
  iframe when tabbing via keyboard.

Bug: 849204
Change-Id: Iea5dc6117decbe1d9e746139dd5974a8bfb45c62
Reviewed-on: https://chromium-review.googlesource.com/1107250Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569093}

Test: manual
Bug: 842394
Change-Id: Iaf1bb8bb94da5b6d2e60009a21b02bde894f1326
Reviewed-on: https://chromium-review.googlesource.com/1105196
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569092}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b65b611d7571..081487b9fb06


git log b65b611d7571..081487b9fb06 --date=short --no-merges --format='%ad %ae %s'
2018-06-20 nodir@google.com Add yapf


Created with:
  gclient setdep -r src/third_party/depot_tools@081487b9fb06

The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: Iedaec63159ed547924f8454a9602cbb50d1522af
Reviewed-on: https://chromium-review.googlesource.com/1109077Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#569091}

Bug: 790336, 790329
TBR: tandrii
Change-Id: I59216a9c02e079979c7e5e43b53801630558829b
Reviewed-on: https://chromium-review.googlesource.com/1109302Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: Ryan Tseng <hinoka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569090}

Fix the naviagtionUrl of ExploreSitesCategoryTile by appending the id to
the end of GetCatalogUrl().

Bug: 852075
Change-Id: Id1608d7fe379f0788b109dd8dea6c63c5eb8189a
Reviewed-on: https://chromium-review.googlesource.com/1108975Reviewed-by: Cathy Li <chili@chromium.org>
Commit-Queue: Yafei Duan <romax@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569089}

For multiple download completion, we just show the check icon without
starting animation. However since we are using AnimatedVectorDrawables,
this leaves the icon blank for certain android versions if we don't use
the animation. Refactored the XML file to separate out the path data and
animations. Using VectorDrawable instead of AnimatedVectorDrawable to
create the non-animated icon fixes this issue.

Bug: 853918
Change-Id: Idd4c86be74a4b620e24f058aa9907253029c7c39
Reviewed-on: https://chromium-review.googlesource.com/1107251Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569088}

This CL adds a test that sends an extension event early in the
extension lifetime, specifically after EventRouter sees a listener
registration, shortly after Service Worker is being registered.
This demonstrates that event dispatch works correctly before SW
registration contains an active worker. The registration would contain
installing_worker() in scenario.

This is a regression test for change
0c08a348

Bug: 850792
Change-Id: Ifab379cf60a105c806280fc5c27972f919632eac
Reviewed-on: https://chromium-review.googlesource.com/1091705
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569087}

And instead uses features::IsAshInBrowserProcess(). This is necessary to
support --enable-features=OopAsh and --enable-features=Mash. This also will
allow us to get rid of ash::Config entirely.

BUG=854336
TEST=covered by test

Change-Id: Iddc53634b925e7c30fc33ec52ffa362730ecf59c
Reviewed-on: https://chromium-review.googlesource.com/1108349
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569086}

This patch adds the ability to swipe the bottom toolbar to switch
between the next and previous tab (like the top toolbar). A new
property to the bottom toolbar model that allows for a swipe
handler to be set on the view. In the case of the bottom toolbar,
the same handler that is applied to the top toolbar is used.
Currently the bottom toolbar also supports "swipe down to enter
the tab switcher", this will be handled in a follow-up patch.

Bug: 847620
Change-Id: Ifc74b500fc70a81cd58ab0ba8998a31c113fd04e
Reviewed-on: https://chromium-review.googlesource.com/1100080Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Pedro Amaral <amaralp@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569085}

This event is currently generated even if DirectShow is used as default.
The intent was to generate it only if MediaFoundation is the default but
is not supported.

Bug: 853916
Change-Id: I5d1b49809bdaf37f885b06de23526ad8fbe1439c
Reviewed-on: https://chromium-review.googlesource.com/1105193Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569084}

This implements getWebChromeClient in the support library glue and
boundary_interfaces, and declares that the APK supports the Feature.

Bug: 853030
Test: (in support lib) ./gradlew :webkit:connectedAndroidTest
Test: android_webview/tools/run_cts.py (on O device, to verify CTS)
Change-Id: I9e19a017b6bfc05d287c1d8c2c112eea86f65c4f
Reviewed-on: https://chromium-review.googlesource.com/1107273
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569083}

This patch adds a new WPT that hit tests the empty region in an inline
element above a child with smaller font size (i.e., smaller height), and
expects to hit the inline element itself.

This helps us add related implementation in LayoutNG, since no existing
test case tests this behavior yet.

Bug: 851075
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Ic538681530e17ea0d5fc49612376e30bdcf563d8
Reviewed-on: https://chromium-review.googlesource.com/1108560Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569082}

The class and its feature is not being used in the class at all. It
also removes redundant the "input" buffer from the render call chain.

Bug: 854229
Change-Id: I4d7ff0142a2548391b739d9d5194365b5acad98d
Reviewed-on: https://chromium-review.googlesource.com/1108439
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Reviewed-by: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569081}

This CL migrates the session management part of MediaRouter.
CreateRouteRequest is not used and we are using route selection
to let CAF start sessions automatically.

Change-Id: I58d267418d9afd11f4f44520e8ca8ad94e82388b
Reviewed-on: https://chromium-review.googlesource.com/1006358Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Commit-Queue: Zhiqiang Zhang <zqzhang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569080}

Currently OnSetupError receives a string for the details of the
error, and then it is printed out through LOG(ERROR).

This CL changes the interface so that OnSetupError just receives
a boolean, which indicates if the failure needs powerwash or not.
The logging of the details happens within DemoSetupController.

The flag is not used within CL. An upcoming CLL (on top of
I9b4fabbb6e87e921e305ccfe78e49e5eb172a10f) will consume this flag
and update the error message.

BUG=827290
TEST=unit_tests

Change-Id: I1942109a572eb09ed947ba67ac6cf946e8aa05a1
Reviewed-on: https://chromium-review.googlesource.com/1107011
Commit-Queue: Jun Mukai <mukai@chromium.org>
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569079}

When admin sets password protection trigger pref to OFF, we should clear
already captured enterprise passwords.
These enterprise passwords include GSuite sync password as well as
passwords captured from enterprise login page.

Bug: 851058
Change-Id: I3d932d0b5008d9c62fdc2ae387bf1e81ccada4d4
Reviewed-on: https://chromium-review.googlesource.com/1103297
Commit-Queue: Jialiu Lin <jialiul@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569078}

BUG=internal b/110226508
TEST=Manual. Doesn't disconnect after renderer exits

Change-Id: Ide2bb4ff6cbb95d14f5f301d0de8c23cd88d3f3e
Reviewed-on: https://chromium-review.googlesource.com/1102171
Commit-Queue: Bailey Forrest <bcf@chromium.org>
Reviewed-by: Stephen Lanham <slan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569077}

As part of initialisation, RootWindowController 'activates' the
KeyboardController by adding its container window as a child of another
window (the "real" ash keyboard container). KeyboardController then
observes the parent change and runs some code.

We flip this around by having KeyboardController activate itself on
a given window.

Change-Id: I9df13eda82e96ab7c7463fe218719ec1f2f7ef8f
Bug: 849980
Reviewed-on: https://chromium-review.googlesource.com/1098751
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569076}

The original purpose of this code was to make sure the task manager
(among other windows) wouldn't be restored off-screen even if the
saved coordinates were off-screen, e.g. due to the last display it
was on having been removed. However, the rest of
AdjustSavedWindowPlacementChromeOS is sufficient to accomplish that
and the minimum visibility flag/functionality in Ash is currently
redundant.

Bug: 826456
Change-Id: Icd922ff244eab2c8ff1b12179a123917a0f7245b
Reviewed-on: https://chromium-review.googlesource.com/1107102
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569075}

The jump across languages seems unnecessary.

Original CL (Dec 14):
https://codereview.chromium.org/763253005/

Introduction of java histogram recording (Jan 15):
https://codereview.chromium.org/794273004

This looks like just a case that was never migrated.

BUG=

Change-Id: Ie6ebacc60afb0ddd46c87b16256f424431bbfd86
Reviewed-on: https://chromium-review.googlesource.com/1108576
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569074}

This affects chrome.enterprise.platformKeys.challengeMachineKey and
chrome.enterprise.platformKeys.challengeUserKey

Bug: crbug.com/854695
Change-Id: I7c1cd9a42c218b0266f297cf95cad9ca268944e6
Reviewed-on: https://chromium-review.googlesource.com/1108930Reviewed-by: Yves Arrouye <drcrash@chromium.org>
Commit-Queue: Jimmy Hastings <jhastings@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569073}

Since b9adeda8 ("Use function pointers in Vulkan") vulkan_tests
crashes on my system.

The reason is that gpu::VulkanFunctionPointers has a different definition
in different compilation units due different VK_USE_PLATFORM_* defines.

We could export those defines, but since portable code has no business
calling these extension functions, this moves the extension functions out
of the public bindings instead.

Keeping platform extensions internal also means that most code won't get
the namespace pollution that Xlib inflicts just by including
<vulkan/vulkan.h> (global macros defined by X11.h actually break later
inclusion of gtest.h, for example).

In order to make encapsulation of the X bits work, this also fixes a typo
where we include vulkan_factory.cc instead of vulkan_factory.h.

Bug: 851997
Test: vulkan_tests on X11

Change-Id: I4ebde71c68528595a3eb21be72c50d65c357a7af
Reviewed-on: https://chromium-review.googlesource.com/1108504Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Chris Blume <cblume@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569072}

Since they could be 4 core or 8 core.

Bug: 840631
TBR: tandrii
Change-Id: I23e40e9912116f06905b6f31eff74548c5a5afda
Reviewed-on: https://chromium-review.googlesource.com/1109017Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: Ryan Tseng <hinoka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569071}

A series of tab capture related failures in Viz, tracked in 810389, have since
been resolved. This reenables them.

Further a previous Mac failure was fixed, but not re-enabled in
IndependentOTRProfileManagerTest.DeleteImmediatelyWhenBrowsersAlreadyClosed.
This re-enables it.

Furthermore we had disabled ConstrainedWebDialogBrowserTest as a part of initial
speculation of all Mac browser_tests failures. However that variant is currently
offline as the errors were more widespread than first thought. This removes it
from the filter as is was not a Viz failure, and the Mac config currently
doesn't run.

TBR=kylechar@chromium.org
TEST=viz_browser_tests
FeedbackTest.*
LoginFeedbackTest.Basic
IndependentOTRProfileManagerTest.DeleteImmediatelyWhenBrowsersAlreadyClosed
ConstrainedWebDialogBrowserTest.*

Bug: 810389
Change-Id: I0c20b38bde95215a81155b0bc2f13f876be57528
Reviewed-on: https://chromium-review.googlesource.com/1109023Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569070}

The replacement drop cursor was being drawn with a rectangle
in the background selection color but the text was unchanged,
causing contrast problems in some environments.  This fix
renders the text using standard selection machinery so the
background and foreground colors change together.

Bug: 853678
Change-Id: Ia641ada5100f0b88173ff6b21e776ab686553f96
Reviewed-on: https://chromium-review.googlesource.com/1106697
Commit-Queue: Orin Jaworski <orinj@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569069}

replace std::find() with base::containsValue()
at components/safe_browsing and components/search_engine
and components/signin

Bug: 561800
Change-Id: I0b100cd3e058cdf506cc59a6cf5ee4b6ee844c1a
Reviewed-on: https://chromium-review.googlesource.com/1107429Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com>
Cr-Commit-Position: refs/heads/master@{#569068}

This is one of several patches that will remove the sequence version of
supportedMethods member. This patch stops using it by removing the
related code in renderer side.
  - [1/2] This patch
  - [2/2] https://crrev.com/c/1108057

The value of |supportedMethods| was changed from array to string, but
the name was left as a plural to maintain compatibility with existing
content on the Web. But it might reduce readability in implementation
perspective. So, using [ImplmenetedAs] extended attribute, this patch
just change a plural to |supportedMethod| internally.

Intent to remove:
  https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/JAnUvBqXElU

Bug: 754779
Change-Id: I90e50a218b3e8d9e0d92e4b6293835a9b038231c
Reviewed-on: https://chromium-review.googlesource.com/1078687Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#569067}

replace std::find() with base::containsValue()
at components/update_client and components/url_matcher
and components/viz.

Bug: 561800
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: If9e7a59fa41dec078dc7a8901d91dec390504f9b
Reviewed-on: https://chromium-review.googlesource.com/1107426Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com>
Cr-Commit-Position: refs/heads/master@{#569066}

In VirtualKeyboardController, we query the keyboard container window to
determine which display it is on. As we're getting rid of the container,
we need to query the keyboard contents window instead. This should be
fine as keyboard contents always has the same bounds as the container.

Since we now need keyboard contents window for VirtualKeyboardController
/ KeyboardLayoutDelegate, we need to create the keyboard contents window
before calling the layout delegate in |PopulateKeyboardContents|.

Bug: 849980
Change-Id: I3f39358f8d500df0e864a5e88c526ac7a220b467
Reviewed-on: https://chromium-review.googlesource.com/1096586
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569065}

Change-Id: Iadb76c4c2165ee269ff72154365a6469873b3f1e
Reviewed-on: https://chromium-review.googlesource.com/1108506
Commit-Queue: Maria Khomenko <mariakhomenko@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569064}

Migrate the LayoutTestBrowserMain and BlinkTestController classes to use
the quit closure registered with the content::Shell by the default main
message loop, to exit it, rather than QuitCurrent*Deprecated().

Bug: 844016
Change-Id: I0b7e8249df6ed62757e5bb27c51dd16b35e0e4a6
Reviewed-on: https://chromium-review.googlesource.com/1106814Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569063}

This CL implements the PerformanceEventTiming entry of type "firstInput"
whose explanation can be found at:
https://github.com/WICG/event-timing#first-input-timing

Bug: 841224, 851484
Change-Id: I40d799f1920ec2fc5fb9140a5e5faec6642a7f03
Reviewed-on: https://chromium-review.googlesource.com/1103230Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569062}

Previously WindowTreeHost::Create() was taking one argument for bounds.
That didn't allow to pass any other window initialization parameters.
Updated Create() to take PlatformWindowInitProperties instead of bounds.
Also updated it to return std::unique_ptr<> instead of raw pointer.

Bug: 829980
Change-Id: I8789cf9c8fb4deaca86eaff128f125cf7490994a
Reviewed-on: https://chromium-review.googlesource.com/1105130Reviewed-by: Sergey Volk <servolk@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569061}

Convert AppLauncherTabHelper to a policy decider,  and update the RequestInfo
structure to take recent user interaction boolean.
Use the ApplauncherTabHelper to check for user interaction / request frame
and allow/reject requests based on that.


Bug: 850760
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I3413958ce7fedb01e3d8e4f2bafe0a7b022e759e
Reviewed-on: https://chromium-review.googlesource.com/1101497
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569060}

Add the MediaRemoter implementation to the Mirroring Service. Mainly
ported over from the existing Media Router extension code.

Bug: 734672
Change-Id: I7dd8a0dab122f452e96c3fa6b188a92ebefd9c3d
Reviewed-on: https://chromium-review.googlesource.com/1086421
Commit-Queue: Xiangjun Zhang <xjz@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569059}

Reland "Added relational propertyvalues to GetPropertyValue, which allows UI Automation to access relations from an automation element"

This reverts commit f30471c5.

Reason for revert: Test failures don't appear to be related in any way. This is accessibility code that hasn't been turned on yet, i.e. it should never be running.

Original change's description:
> Revert "Added relational propertyvalues to GetPropertyValue, which allows UI Automation to access relations from an automation element"
> 
> This reverts commit a65d8a04.
> 
> Reason for revert: I think this broken the layout tests on 32-bit Win10, see https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win10/36552
> 
> Original change's description:
> > Added relational propertyvalues to GetPropertyValue, which allows UI Automation to access relations from an automation element
> > 
> > R=​nektar@chromium.org,dmazzoni@chromium.org
> > 
> > Bug: 844149
> > Change-Id: I7e92097761057c8fb795582098f54daeb00ef204
> > Reviewed-on: https://chromium-review.googlesource.com/1099434
> > Commit-Queue: Nektarios Paisios <nektar@chromium.org>
> > Reviewed-by: Nektarios Paisios <nektar@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#567899}
> 
> TBR=dmazzoni@chromium.org,nektar@chromium.org,suproteem@chromium.org
> 
> Change-Id: I0efca59b219cc9432d14e68f340c3dff12f4ef76
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 844149
> Reviewed-on: https://chromium-review.googlesource.com/1103502
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Commit-Queue: Dirk Pranke <dpranke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#567904}

TBR=dmazzoni@chromium.org,dpranke@chromium.org,nektar@chromium.org,suproteem@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 844149
Change-Id: I0fc68b9b611e0b90b6fc5cf73bdf709020fba079
Reviewed-on: https://chromium-review.googlesource.com/1108937Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569058}

Add the document title in app.js instead of print_preview_new.html.
This also ensures that the title will exist in debug build browser tests
that only create print-preview-app.

Bug: 773928
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ia9f7c01291a03011b3ffa5ec11618ed9688d4a6a
Reviewed-on: https://chromium-review.googlesource.com/1108539Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569057}

https://pdfium.googlesource.com/pdfium.git/+log/b6b01cb2cbaf..cc4802edc4fa


git log b6b01cb2cbaf..cc4802edc4fa --date=short --no-merges --format='%ad %ae %s'
2018-06-20 npm@chromium.org Fix a couple of CPDF_DefaultAppearance::GetFont usages
2018-06-20 tsepez@chromium.org Avoid more .c_str() usage, part 3


Created with:
  gclient setdep -r src/third_party/pdfium@cc4802edc4fa

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:853238
TBR=dsinclair@chromium.org

Change-Id: Ic52e974886de5023884a44852335bf096e1f0ebf
Reviewed-on: https://chromium-review.googlesource.com/1108897Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#569056}