- 27 Sep, 2018 22 commits
-
-
Findit authored
This reverts commit dee92446. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 594509 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZGVlOTI0NDZmNzhhYzcwMzYxZGU1OWFlMjI0OTM5YmU4ZjgyMzk4Zgw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.win/Win%207%20Tests%20x64%20%281%29/43524 Sample Failed Step: network_service_browser_tests Sample Flaky Test: WebRequestUnresponsiveListenerTest.WebRequestListenerNeverResponds/0 Original change's description: > [Extensions] Add a test for webRequestBlocking listeners that are killed > > Add a test that exercises behavior for a webRequestBlocking listener > that never returns, and then the tab is closed. Do this with two > flavors: > - A listener in the extension's background page, where the > RenderProcessHost is shutdown. > - A listener in an extension tab, which is then closed. > > Verify that in both cases, navigation is unblocked when the extension > listener goes away. > > Inspired by, but not in any way a fix for, https://crbug.com/877543. > > Change-Id: Id918d6d5f7bf5d8235f1386ef48838bffaa1b50c > Reviewed-on: https://chromium-review.googlesource.com/1188942 > Commit-Queue: Devlin <rdevlin.cronin@chromium.org> > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Reviewed-by: Karan Bhatia <karandeepb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#594509} Change-Id: I2c9ebb07e448747ca7f83e51470e1d5e96edc9bd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 889701 Reviewed-on: https://chromium-review.googlesource.com/1247527 Cr-Commit-Position: refs/heads/master@{#594550}
-
Stuart Langley authored
Explority work to see if we can track down when an FSP is asked to get metadata for a caller that doesn't want any metadata. Bug: 587231 Change-Id: I5133016dd9bf01aeb66dc92010c8998d29067642 Reviewed-on: https://chromium-review.googlesource.com/1240553Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#594549}
-
dpapad authored
- wrap <style is="custom-style"> with <custom-style> - move custom-style inside <body> Bug: 884030 Change-Id: Ic45df6d1846fdf6f6ee0cc5e23523779489bdb34 Reviewed-on: https://chromium-review.googlesource.com/1244833 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#594548}
-
Yuichiro Hanada authored
Bug: b/111833294 Test: Open Hangouts app and enable a11y keyboard in laptop mode, then confirm a11y keyboard shows up by clicking on the text field. Change-Id: Ibf8202b572939dd8040918f9c64fab01ce6de306 Reviewed-on: https://chromium-review.googlesource.com/1221407 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#594547}
-
Tetsui Ohkubo authored
Swipe control view is specific to Chrome OS, so we should move them to ash/message_center from ui/message_center. This CL also does other minor cleanups (PS#2). TEST=trybot pass BUG=none Change-Id: Ie6ed64119d0d9b7d7005ac581c9322dae8df9edb Reviewed-on: https://chromium-review.googlesource.com/1245077Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#594546}
-
Aga Wronska authored
Run about_ui_unittest. Manually perform offline demo mode setup. Bug: 857275 Test: Run wizard controller and demo setup browser tests. Change-Id: Ife8f6daa3d8fb87f2adf31350845efa67463b939 Reviewed-on: https://chromium-review.googlesource.com/1244476 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#594545}
-
Pavel Feldman authored
Change-Id: I573cc9766e05d24eb9288c7bd5cd25a53c1d0b72 Reviewed-on: https://chromium-review.googlesource.com/1247186 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#594544}
-
Jennifer Apacible authored
Change-Id: I1839a621a3b7b92dfbdef896675c3e3384399601 Reviewed-on: https://chromium-review.googlesource.com/1246591 Commit-Queue: apacible <apacible@chromium.org> Reviewed-by:
CJ DiMeglio <lethalantidote@chromium.org> Cr-Commit-Position: refs/heads/master@{#594543}
-
Ryan Hansberry authored
Bug: 883883 Change-Id: I6cb4ad9db6a8f24d15eae91a318f55ff6296698a Reviewed-on: https://chromium-review.googlesource.com/1246684 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#594542}
-
Thomas Tangl authored
Strings in the Dice settings promos and in the sync opt-in dialog are updated. Screenshots: https://drive.google.com/drive/folders/1_0_w_XxtReLR1JVwYZv5Wmow9zxHqFNO?usp=sharing Bug: 889262, 872825 Change-Id: I8a784136587c365d5592f252ff49a186db927715 Reviewed-on: https://chromium-review.googlesource.com/1246454 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#594541}
-
Aidan authored
When profile is loaded, parse the bookmark tree to find the total count. Adds and tests new bookmark stat, which saves to a new histogram. The collection method is run in the profile manager class, after it has been initialized. Bug: 245392 Change-Id: I6a72549e2cbc197e92de4edbcf7b362212ff2c39 Reviewed-on: https://chromium-review.googlesource.com/1238901Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#594540}
-
Ben Kelly authored
R=jsbell@chromium.org Bug: 720919 Change-Id: I1fc7b1f5847bdc5795b256c11f86b6c59c181962 Reviewed-on: https://chromium-review.googlesource.com/1241333Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#594539}
-
Jordy Greenblatt authored
Note that fixing the bolded header in this CL applies to all the setup flow headers. I also refactored so that top margin of the 'additional content' slot is determined page-by-page and made a min-height for the 'message' slot because it made the padding a little easier to follow. Spec: https://drive.google.com/file/d/1UqHV67OrdGT0_G0L98nV5IVr26OkHu9F/view?usp=sharing Screenshot of new Password page: http://screen/dZpuf7kq8Mp There were two minor changes made since that annotated screenshot. (1) The margin between the photo and email was increased from 4 to 8 px (2) The email is set slightly lower relative to the user photo (the <div> containing them is not using 'align-item: center' Change (1) is straight out of the spec above. Change (2) is tentative pending confirmation or explicit specs from UX. Bug: 878643 Change-Id: I3032617f8bd14ee74973dcbf5727e83e1f0e7438 Reviewed-on: https://chromium-review.googlesource.com/1246960 Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/a42c3f899d04..10f3ee914d20 git log a42c3f899d04..10f3ee914d20 --date=short --no-merges --format='%ad %ae %s' 2018-09-26 lannm@chromium.org Add scripts/repo_sync_manifest Created with: gclient setdep -r src/third_party/chromite@10f3ee914d20 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Icb6607f780f98bdd34ca72d8e649bd6a99234b96 Reviewed-on: https://chromium-review.googlesource.com/1247071Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594537}
-
David Bertoni authored
Bug: 847237 Change-Id: I4718a8ea2d4b6d2b74d632f06f614dd042f04a07 Reviewed-on: https://chromium-review.googlesource.com/1246941Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#594536}
-
Luciano Pacheco authored
keyIdentifier is deprecated and replaced by "key" argument in KeyboardEvent. Additionally our use of this was pretty inconsistent, so removed it completely. Change-Id: I35d6ba9660830b6c419f2a6e106bbde5162cf4b7 Reviewed-on: https://chromium-review.googlesource.com/1245080 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#594535}
-
Joe Downing authored
This CL updates KeyboardLockServiceImpl to release its mojo binding if the RenderFrameHost instance it is linked to is destroyed. Bug: 888678 Change-Id: Icea5fe1a5c76df4d71fa4e78c423e49828664637 Reviewed-on: https://chromium-review.googlesource.com/1246290 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 085c55b5. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25357 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-method-id NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: I7753b19a7ebfeb4c2d52b1741c3add515f48a049 Reviewed-on: https://chromium-review.googlesource.com/1247031 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#594533}
-
Alexander Alekseev authored
This CL updates subtitles in oobe-dialogs to be Roboto google-grey-700. And also fixes an incorrect updateLocalizedContent propagation which could lead to error. Bug: 888211 Change-Id: I41af02233e5331ef13d155998fa6eb1b5510cd0c Reviewed-on: https://chromium-review.googlesource.com/1239721 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#594532}
-
David Black authored
Previously the painter for our mask layer was a round rect with all corners of the same corner radius. This caused us to clip content that appeared in the upper right and left corners. Now, the painter for our mask layer only rounds the lower right and left corners to avoid painting outside container bounds. This prevents content in the upper corners of our contents from being clipped. See bug for before/after. Bug: b:116626523 Change-Id: I5295a4ec22217aa35c973a5f8fc29fee47a1d1af Reviewed-on: https://chromium-review.googlesource.com/1244337Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#594531}
-
Filip Gorski authored
* Adding handling of the onUrlUpdated signal in cases where FetchHelper is considers the tab current, but the URL context changed. Bug: 889518 Change-Id: Ibbf3e57e5861ac0d9fccce7abda946b4dbb6c48a Reviewed-on: https://chromium-review.googlesource.com/1246592Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#594530}
-
Bo Liu authored
Less jarring on a page with white background. Bug: 884819 Change-Id: I40ef521090d6146ba0abe2f78de0656d824988ef Reviewed-on: https://chromium-review.googlesource.com/1247030Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#594529}
-
- 26 Sep, 2018 18 commits
-
-
Cathy Li authored
Does not load images yet. Also looks very ugly. Bug: 867488 Change-Id: I9acf386718bdd5aefdd1f87f0b31210fc61a102b Reviewed-on: https://chromium-review.googlesource.com/1242295 Commit-Queue: Cathy Li <chili@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
-
Takuto Ikuta authored
This is to speed up compile of headless_browser_impl. On linux, compile time of headless_browser_impl.cc reduced from 22 seconds to 8 seconds. Change-Id: I0645dfc245894e83762711f419d9634e57077ccb Reviewed-on: https://chromium-review.googlesource.com/1245000Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1b71de973c63..44b480c37a8b Created with: gclient setdep -r src-internal@44b480c37a8b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I2a4e7949f03f5ee49cd4f751b6978d506cfb314e Reviewed-on: https://chromium-review.googlesource.com/1247083Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594526}
-
Jonathan Metzman authored
Bug: 888363 Change-Id: Idfb7c644fa3294ad11327609b4b39eacfd3f5dd2 Reviewed-on: https://chromium-review.googlesource.com/1238917Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#594525}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/620aaef23380..59d6ace5cb99 git log 620aaef23380..59d6ace5cb99 --date=short --no-merges --format='%ad %ae %s' 2018-09-26 primiano@google.com fuzzers: re-introduce conditional around fuzzers 2018-09-26 primiano@google.com Merge "Roll clang and switch to fsanitize=fuzzer-no-link" Created with: gclient setdep -r src/third_party/perfetto@59d6ace5cb99 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: If7ee8be219fc5abb9b55c9af8991118a692afb97 Reviewed-on: https://chromium-review.googlesource.com/1246839Reviewed-by:
-
Tatiana Buldina authored
By default ChromeDriver creates new log file, option '--append-log' allows to append log file. Bug: chromedriver:586 Change-Id: Ibcbcad66a3afbf5bff0fbbf2046a1fc694395290 Reviewed-on: https://chromium-review.googlesource.com/1247027Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#594523}
-
Renjie authored
In QuicStreamFactory::Job, chances are host resolution won't return synchronously. While waiting for the host resolution callback, the stale host resolver will be queried, and a connection from the stale host result will be established but not confirmed. After host resolution returns, the two IP addresses will be compared. If they match, the connection will be confirmed. Otherwise the connection from stale host will be closed and connection from the fresh resolution will be established. Bug: 787942 Change-Id: I7a5f78ec42e97778d7c7d200f4d8ac894611fd19 Reviewed-on: https://chromium-review.googlesource.com/1186112 Commit-Queue: Renjie Tang <renjietang@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#594522}
-
Stephen Chenney authored
Missed this update before committing the original patch. TBR=chrishtr@chromium.org Change-Id: I4fcda12146e7920615e4939785c39b8f220bc005 Reviewed-on: https://chromium-review.googlesource.com/1204671Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#594521}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7a3197bae3ca..5ea41fc89b26 git log 7a3197bae3ca..5ea41fc89b26 --date=short --no-merges --format='%ad %ae %s' 2018-09-26 brianosman@google.com Remove more SkColorSpaceXform (and friends) Created with: gclient setdep -r src/third_party/skia@5ea41fc89b26 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=bsalomon@chromium.org Change-Id: Ifd164163359f27950f45811893df257a09402c6b Reviewed-on: https://chromium-review.googlesource.com/1247084Reviewed-by:
-
Ria Jiang authored
Change-Id: Idceb9322ce688d3993c0a1712dd7b70d35aad304 Reviewed-on: https://chromium-review.googlesource.com/1246642Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Ria Jiang <riajiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#594519}
-
Kyle Horimoto authored
The previous approach used a behavior, meaning that any Polymer element which needs to access the JS Mojo API needs to create its own InterfacePtr to the Mojo service. In a follow-up CL, I will be adding a new client of this interface, so it would have been wasteful to create two separate connections to the service. This CL converts this behavior to a class-based approach which utilizes a singleton class which stores a single instance of the pointer. Bug: 884058 Change-Id: I0b2c13677309b9949a0f26d2f11dd40ea8f15b1c Reviewed-on: https://chromium-review.googlesource.com/1247035Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/bfcdc913c418..80564a56ec85 git log bfcdc913c418..80564a56ec85 --date=short --no-merges --format='%ad %ae %s' 2018-09-26 stevenperron@google.com Keep analyses live in unrolling (#1929) 2018-09-26 antiagainst@google.com VK_KHR_shader_atomic_int64 covers OpAtomic{Load|Store} 2018-09-26 dj2@everburning.com Remove use of SetContextMessageConsumer from binary_parse_test (#1925) 2018-09-26 jaebaek@google.com Validator: OpGroupNonUniformBallotBitCount validation (#1486) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@80564a56ec85 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I83fbc3bfd07e2f7713db3c67f7e907693d9044a1 Reviewed-on: https://chromium-review.googlesource.com/1247070Reviewed-by:
-
Bailey Berro authored
- Makes add dialog share fields stretch the full width of the dialog - Adds width styling mix-in to cr-searchable-drop-down - Updates add printer styling to be consistent after removing fixed width styling from cr-searchable-drop-down Bug: chromium:887111 Change-Id: Ibcb9c67b90cff9d0c5bf0c8cc058b6d218cb1f1a Reviewed-on: https://chromium-review.googlesource.com/1244614 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#594516}
-
David Bokan authored
When an element is position: fixed and specifies a value for bottom, we want it to stick to the bottom of the viewport as the URL bar hides (and the renderer is moved up). However, we missed the special case where both top and bottom are specified. We can't resize the element in real time but it's more intuitive to have the element stick to the screen top. This also exposed an issue in how we raster the area exposed by the URL bar. Since we don't resize the viewport layers until the finger is lifted, the raster code needs to adjust the visible rect by the amount the URL bar is hidden. This was done by always adding the entire top controls height in the pending tree. This was guarded by an ANDROID ifdef which meant the test added here didn't get its benefit and produced unrastered tiles. I removed the ifdef (URL bar hiding is now also available on ChromeOS) and improved the expansion to make it more exactly match the amount of extra visible area. Bug: 846322 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I02700e08e8254a64405c3adb1a7a123b65468f44 Reviewed-on: https://chromium-review.googlesource.com/1235123 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#594515}
-
Morten Stenshorne authored
Extra care is needed when the legend is an orthogonal writing mode root. We need to do what we do in min/max calculation for such children in the regular block layout algorithm. Fieldset padding is also special, since it's included in the fieldset content anonymous child, but we have to take care of it ourselves anyway, in case there is no such child (empty fieldset, or fieldset with just a legend). Bug: 875235 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: If26d8a59ae1514085f40e5a9e1ecee007997e7ad Reviewed-on: https://chromium-review.googlesource.com/1245363 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#594514}
-
Robert Sesek authored
Most of these were referenced by Cocoa code that has now been deleted. Bug: 832676 Change-Id: I96a54b283912b30455de753d2a689db464c35e64 Reviewed-on: https://chromium-review.googlesource.com/1246865 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#594513}
-
Xianzhu Wang authored
Now exclude cases of using null output clip for an effect node if the out-of-flow descenant's containing block has the same clip as the current clip. This lets PaintChunksToCcLayers and PropertyTreeManager go through the more optimized path for more cases. Bug: 879173 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I5c9e0006dc678c36b752823293f08355a194578b Reviewed-on: https://chromium-review.googlesource.com/1246686Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#594512}
-
Robert Sesek authored
Bug: 832676 Change-Id: I1e386194f2925fd6b8d5ce594bb2372c2a6422ff Reviewed-on: https://chromium-review.googlesource.com/1246727 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
