GitLab

Since TabGrid/Group is no-op for Tablets, disable both features for
Tablets from client-side.

Bug: 1108468
Change-Id: I9b26c7ecd4f260b1903a0f40e1e86c985101d8b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363644
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Auto-Submit: Yue Zhang <yuezhanggg@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799509}

Mic permissions for Crostini landed in M84 and hasn't caused any issues.
Removing the flag (that was enabled by default) and any code that used
it.

Tests: Tested on DUT and ran browser tests
Bug: 1016193
Change-Id: I4a099791500f9291013c6ee28b9e97548ff0c95e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352257
Commit-Queue: Daniel Ng <danielng@google.com>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Fergus Dall <sidereal@google.com>
Cr-Commit-Position: refs/heads/master@{#799508}

Show a Cloud Print deprecation warning at the top of the destinations
dialog if any of the destinations are being deprecated.

Screenshot of change: https://imgur.com/GClle7p

Bug: 1112581
Change-Id: I42d7086ea0da2f2443d2a59dd540e6aafdf78472
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361046
Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799507}

This CL adds the SetSharesheetSize function to SharesheetController
which can be called to resize the sharesheet to a given size. The
anchor position in the sharesheet bubble is updated to accommodate
the new bubble sizing.

Bug: 1097623
Change-Id: I0093c4b7ae69119928d677bed12cd19ca7d64e1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362067
Commit-Queue: Melissa Zhang <melzhang@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799506}

Bug: 1087726
Change-Id: If56fc0d80ca435e16bc764af49079dd25c6f88e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362053
Commit-Queue: Timothy Loh <timloh@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Auto-Submit: Timothy Loh <timloh@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799505}

This reverts commit ef0ab61f.

Reason for revert: The test still fails: https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-rel/1158

Original change's description:
> Revert "[Sheriff] Disable the test"
> 
> This reverts commit af48c8e6.
> 
> Reason for revert: Test works now.
> 
> Original change's description:
> > [Sheriff] Disable the test
> > 
> > Disable the failing test on Linux.
> > 
> > Bug=1108205
> > TBR=miu@chromium.org
> > 
> > Change-Id: Ie388ca75a2fadce937d613994847217e7f9579fc
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310271
> > Reviewed-by: Hayato Ito <hayato@chromium.org>
> > Commit-Queue: Hayato Ito <hayato@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#790745}
> 
> TBR=miu@chromium.org,hayato@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Change-Id: I4c43284f7d4a0fec1cd4c05fc375f1f4d406526b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361023
> Reviewed-by: Yuri Wiitala <miu@chromium.org>
> Commit-Queue: Yuri Wiitala <miu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#799428}

TBR=miu@chromium.org,hayato@chromium.org

# Not skipping CQ checks because this is a reland.

Change-Id: Ibc06b68b65131cc9f3220ec36084f89eaf08ce59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362494Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799504}

This checks for the existence of the file and skips adding it
as a parameter if it doesn't exist.

Also removes classes from the prebuilt output jar since they
cannot be actually included in the build - they are required
only for the desugaring step.

Bug: 105675
Change-Id: Ib1e86fb25cb4607a18278446c4b35606f179e076
R: agrieve@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363555
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799503}

This test is flaky also on macOS.

TBR=clamy@chromium.org

Bug: 796135
Change-Id: I8275f5c3267ed072e3eed79e81c93067ecc94c50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362052Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799502}

Use back_forward_cache/no-favicon.html as the test page, as favicons are
known to cause issues for BFCache tests, as seen with
ChromeBackForwardCacheBrowserTest. Fix a few nits along the way.

This is a precursor to https://crrev.com/c/2353886, which will trigger
flaky behavior without this CL.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android-bfcache-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-bfcache-rel

Bug: 956832
Change-Id: I62dbb2c05542a7ed027f400c7000b87f5d64b6da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361535Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799501}

Add a deprecation warning message for Cloud and Privet printers under
the ChromeOS print preview destination select.

Screenshot of change: https://imgur.com/cZqYwba

Bug: 1112581
Change-Id: Idffd0ff25f3182db3546dca9f89b0dfd21d4bccf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359159
Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799500}

We have a extensions as a source_set, which is included by multiple
different places.

That results in ODR problem. Here is the error:

ninja: Entering directory `out/libfuzzer/'
[1/1] Regenerating ninja files
[14/16] ACTION //tools/v8_context_snapshot:generate_v8_context_snapshot(//build/toolchain/linux:clang_x64)
FAILED: v8_context_snapshot.bin
python ../../build/gn_run_binary.py ./v8_context_snapshot_generator --output_file=v8_context_snapshot.bin
=================================================================
==406548==ERROR: AddressSanitizer: odr-violation (0x7ff00fcc6660):
  [1] size=64 'vtable for ui::WorkspaceExtension' ../../ui/platform_window/extensions/workspace_extension.cc
  [2] size=64 'vtable for ui::WorkspaceExtension' ../../ui/platform_window/extensions/workspace_extension.cc
These globals were registered at these points:
  [1]:
    #0 0x55d60fc1539d  (/home/msisov/code/chromium/src/out/libfuzzer/v8_context_snapshot_generator+0x3a439d)
    #1 0x7ff00fca72eb  (/home/msisov/code/chromium/src/out/libfuzzer/libozone.so+0x51d2eb)

  [2]:
    #0 0x55d60fc1539d  (/home/msisov/code/chromium/src/out/libfuzzer/v8_context_snapshot_generator+0x3a439d)
    #1 0x7ff00a4bc22b  (/home/msisov/code/chromium/src/out/libfuzzer/libx11_window.so+0x5a22b)

==406548==HINT: if you don't care about these errors you may set ASAN_OPTIONS=detect_odr_violation=0
SUMMARY: AddressSanitizer: odr-violation: global 'vtable for ui::WorkspaceExtension' at ../../ui/platform_window/extensions/workspace_extension.cc
==406548==ABORTING
./v8_context_snapshot_generator failed with exit code 1
ninja: build stopped: subcommand failed.

One of the solutions is to switch from source_set to component. However,
it looks too much to have a separate component just for that. Instead,
squash extensions with platform_window component.

Change-Id: I2ac2cf464b64bb863543468438ae81a2032223c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362888Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com>
Cr-Commit-Position: refs/heads/master@{#799499}

This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
gbiv@chromium.org. Additional context: https://crbug.com/805539

Please note that, despite rolling to chrome/android, this profile is
used for both Linux and Android.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/afdo-chromium-autoroll
Please CC gbiv@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: gbiv@chromium.org
Change-Id: I2bfa69d94d6d0be6ae6e0152e0898f651ca53354
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363801Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#799498}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1d251f6f077f..cf6f2d3ab620

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC hajimehoshi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1085419,chromium:1105693,chromium:1115361
Tbr: hajimehoshi@google.com
Change-Id: I7266089e4fd24f8b0339f0fed8969821eb5866be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363499Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#799497}

This is a reland of f82a08ba together
with a fix for the failing tests.

Original change's description:
> Add Remote Apps Mojo service
>
> This CL adds a Mojo service for Remote Apps. The service is a thin layer
> which mainly forwards calls to the RemoteAppsManager.
>
> Only extensions under the imprivata_in_session_extension behavior feature
> have access to the API.
>
> Bug: 1101208
> Change-Id: Ieaf9f6839ba22d86cb3fba8fa64afe49ade8e6ce
> DD: go/remote_apps_mojo
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332615
> Commit-Queue: Jit Yao Yap <jityao@google.com>
> Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
> Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> Reviewed-by: Sam McNally <sammc@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#798551}

TBR=xiyuan@chromium.org,antrim@chromium.org,rdevlin.cronin@chromium.org,sammc@chromium.org,ortuno@chromium.org

Bug: 1101208
Change-Id: If11de6983195af24b404897c0ea87befc8f85f82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360067Reviewed-by: Alexander Hendrich <hendrich@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Jit Yao Yap <jityao@google.com>
Cr-Commit-Position: refs/heads/master@{#799496}

Prior we re-launched upon a successful rename so the file was
reloaded with the correct name. crrev/c/2352586 changes that but we
forgot to update it in the untrusted context.

Also adds tests for it.

Bug: b/165431994
Change-Id: I3b17c88b40ed563e043be7bb0b70c3dc098caeaa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362169
Commit-Queue: David Lei <dlei@google.com>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799495}

This is intended to replace the NativePrintersBulkBlacklist policy.
The old policy will still be used in the absence of the new one for at
least a few releases of Chrome.

BUG=chromium:1098049

Change-Id: I473dbe34e2d4de7ffcd91b5254b6414a4364357d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341218Reviewed-by: Sean Kau <skau@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Brian Malcolm <bmalcolm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799494}

Using wpt-import in Chromium de77910b.

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=foolip@google.com

No-Export: true
Change-Id: Ia5fdd50bb49f0b2c48f88279cadab7e41aa16067
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362631Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#799493}

TBR=jkrcal@chromium.org

Bug: 1021930
Change-Id: I3d542632c89a5834d5339a6a9d488dfb8d62eba6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362363Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799492}

This reverts commit c8d093ac.

Reason for revert: Test failures on ChromeOS https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/7829

Original change's description:
> ambient: Use different backend servers
> 
> This patch configs the dev channel to use testing server. But users can
> overwrite it with a flag.
> 
> Bug: b/148692733
> Test: manual
> Change-Id: I967281bc1421c37d9c1ff74a0815d6a6da570da3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342134
> Commit-Queue: Tao Wu <wutao@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#799318}

TBR=xiyuan@chromium.org,xiaohuic@chromium.org,wutao@chromium.org

Change-Id: Ic364ef7c1f701b7a36b6503e8d330995de5dcecb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: b/148692733
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363508Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799491}

When chrome_public_smoke_test has a crash, our test runner does not
notice and so does not collect tombstones.

This changes the "are there tombstones" logic to look for a tombstone
message in logcat rather than looking to see if any tests crashed.

Bug: 1117540
Change-Id: Ic0594f0d8dcb2cb8c7280ade9d8d5133c890614f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363075Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799490}

Although Intel's driver supports RGB10A2 overlay format, driver problems
still exist in checking overlay's capability, which blocks playing hdr
video through overlay.

This CL adds a workaround for Intel's hardware (Icelake or later), to
ensure play hdr video through RGB10A2 overlay. In future, this
workaround could be remove if overlay capability checking bugs are fixed
in Intel's driver.

Bug: 1062184
Change-Id: If18383edb0339c3c7701febdb34bdd7d736f323a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340414Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Richard Li <richard.li@intel.com>
Cr-Commit-Position: refs/heads/master@{#799489}

Bug: 1110661
Change-Id: Ie74c57d6221407e8583790ad9e1108bcb3875e5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363298
Commit-Queue: Xiaodan Zhu <zxdan@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799488}

Add a deprecation warning message for Cloud and Privet printers under
the destination select.

Note: This change is only for non-CrOS desktop. CrOS changes will be
applied in a chained CL.

Screenshot of change: https://imgur.com/cZqYwba

Bug: 1112581
Change-Id: I2057cab0daa8d6f169ae6255172970a84b2803f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353731
Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799487}

Makes V8ContextSnapshotImpl not depend on unnecessary code and data
if !defined(USE_V8_CONTEXT_SNAPSHOT).

Bug: 839389
Change-Id: I349292e52b465e5836e8ade7791be24a1e39af78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362066Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799486}

Adding closure compilation for:
link_container_test
media_size_settings_test
margins_settings_test

Bug: 1000989
Change-Id: Ie7b2a06e157591e3a27eec9d46933ae8853237ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360502
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799485}

Bug: 1060775
Test: appr.tc/?vsbr=500&vsc=vp9 on rammus
Test: video_encode_accelerator_tests --codec=vp9 on rammus
Change-Id: I45ef96aec373b05383680c54245fc0d0000b7579
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359816
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799484}

The old handling of exitFirstRun() simply relaunched the pending intent.
This turned out to be a problem because the intent dispatcher read the
durable settings for if the FRE was needed, and would decide it was.
Interestingly, there can only be one FirstRunActivity active at a time,
and so the relaunch was actually ignored. This would cause the existing
FirstRunActivity get stuck because the replacement activity was never
started.

This fixes the problem by introducing a new "ephemeral" static variable
that remembers we just decided to skip the FRE, so the next intent
dispatch/routing will be aware of this decision.

Bug: 1106987
Change-Id: Id8502956236f76c93091452fe580ae0d6fea2c80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343553Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Wenyu Fu <wenyufu@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799483}

To assist in the investigation of how uninitialized
Tabs are appearing in getDomain()

Bug: 1116613
Change-Id: Ia0ab0d7aca20d724fd1200b1fdbe1a2f951f9633
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363485
Commit-Queue: David Maunder <davidjm@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799482}

Slightly clean up the CrOS destination status code by using a computed
property to set |statusText_|. This allows the removal of the observer
on |destination| and manual calls of updateStatusText_(). Additionally,
remove the stale shouldShowStatus_() function.

Change-Id: I50011717b9643f137fdd67f12c580adcae289776
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357070
Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799481}

https://chromium.googlesource.com/angle/angle.git/+log/573931528077..5b4f6e3193cf

2020-08-19 jmadill@chromium.org Vulkan: Add overlay widget for RP buffer count.
2020-08-18 jmadill@chromium.org Feedback Loop Redesign 1/3: Framebuffer Serials.
2020-08-18 lehoangq@gmail.com Metal: autogen format caps from json
2020-08-18 jmadill@chromium.org Vulkan: Add DS ReadOnly mode to Framebuffer/RP caches.
2020-08-18 lehoangq@gmail.com Metal: Fix missing image view for texture from IOSurface.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: cnorthrop@google.com
Change-Id: If969d7b027c7a322ddc7d3fe0a1148745c8886e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363498Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#799480}

R=dschinazi@chromium.org

Change-Id: I954d49604fef3be1b7a50205db5d08441f4226a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360232
Commit-Queue: David Schinazi <dschinazi@chromium.org>
Reviewed-by: David Schinazi <dschinazi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799479}

According to the HTML standard, 'align' attribute for a LEGEND element
should be mapped to justify-self property.
Our layout code handles text-align for LEGEND, and doesn't handle
justify-self.  We'd like to investigate possibility to change the
behavior.

This CL has no behavior changes.

Bug: 880822
Change-Id: I86427f172d7ee317d13f60fa78d5478135543174
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362487
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799478}

The commas are forgot in the kVaapiFunctionNames initialization.
Thus it initializes the first element and the second or later
element is nullptr. SIGSEGV is caused in attempting to log the
name because the char's pointer is nullptr.

Bug: b:162962069
Test: video_encode_accelerator_tests on atlas
Change-Id: Ifbb081b8e92350df5b83510087a042b7213bc377
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362378
Auto-Submit: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799477}

TBR=sandersd@chromium.org

Bug: 1117613
Change-Id: If6ea1284f6733f490f8510c73f09040dbaac0605
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362069Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799476}

Currently HelpAndFeedback is not modularized, so a modularized fragment
is not able to use it due to circular dependency.

In this CL, create a feedback module and introduce two interfaces as a
workaround:
* HelpAndFeedbackLauncher, which is used to launch a help and feedback
page in an activity. HelpAndFeedback implements this interface.
* FragmentHelpAndFeedbackLauncher, which is used to inject
HelpAndFeedbackLauncher to a fragment. Any fragment that needs to
launch a help page implements this interface.

The safe_browsing module will depend on this new module to launch a
help page.

Bug: 1115758,1117343
Change-Id: I3d9d76f0ba87db26ae5bbe853f7b6cc38eb9353a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359749
Commit-Queue: Xinghui Lu <xinghuilu@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799475}

This CL renames default_text_color_tertiary to
default_text_color_disabled and replaces any uses that aren't disabled
with default_text_color_secondary. It also updates
TextAppearance.*.Tertiary and its uses accordingly.

Bug: 1097357
Change-Id: Ib14fdfbaa3941f4c4ab3aaa6ee8175d25758a565
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360559
Commit-Queue: Sinan Sahin <sinansahin@google.com>
Reviewed-by: Lijin Shen <lazzzis@google.com>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799474}

This is a reland of crrev.com/799230, which was rolled back due to a
mismatch between the OS_CHROMEOS macro and the |isChromeOS| WebUI
constant on Lacros. (crbug.com/1111985). Use grit preprocessing instead.

Add a deprecation warning message for the "Save to Drive" destination
under the destination select.

Screenshot of change: https://imgur.com/ix1GjIB

Bug: 1112581
Change-Id: Icf3caa35b0efce83f440f8c8583edbf96a209290
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364000Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799473}

The global media controls UI displays the audio devices connected to
the system. This change allows the UI to refresh the devices it shows
as availability changes.

Because of an existing bug in device update processing on linux
(crbug.com/1112480) a new class for monitoring these changes was
created. The implementation for linux will poll the system whereas the
implementation for all other OSes will be notified of changes.

Bug: 1113944
Change-Id: I0d285ff0486fc1fb1307b5d78a5a998dcde131ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341181
Commit-Queue: Noah Rose Ledesma <noahrose@google.com>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799472}

This reverts commit 132e1deb.

Reason for revert: Android ASAN bot compilation failures: https://ci.chromium.org/p/chromium/builders/ci/Android%20ASAN%20%28dbg%29/26489

Original change's description:
> Add -noverify to build commands to improve runtime (local builds only)
> 
> The flag is guarded by treat_warnings_as_errors=false so that it
> will apply only to local developer builds.
> 
> Results from //tools/android/build_speed/benchmark.py base_java_sig:
> With change:
> base_java_sig: 68.0s avg (68.8s, 67.2s)
> base_java_sig: 68.4s avg (68.6s, 68.2s)
> 
> Without change:
> base_java_sig: 69.4s avg (69.3s, 69.5s)
> base_java_sig: 69.7s avg (69.7s, 69.7s)
> 
> time out/Debug/bin/run_base_junit_tests:
> With Change:
> real 0m22.741s
> real 0m23.543s
> 
> Without change:
> real 0m23.176s
> real 0m24.328s
> 
> Bug: 1117222
> Change-Id: I4bfd742165468bf9538e6fa0dc8f35daa9e0f23f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313299
> Commit-Queue: Andrew Grieve <agrieve@chromium.org>
> Auto-Submit: Andrew Grieve <agrieve@chromium.org>
> Reviewed-by: Peter Wen <wnwen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#799285}

TBR=wnwen@chromium.org,agrieve@chromium.org

Change-Id: I82f411e5dab89c361a30c33e9103bd8561f19765
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1117222
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362493Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799471}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=govind@chromium.org

Change-Id: I171b3d6aafc73c402f7b287cf0293363c72f9f98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363261Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#799470}