- 02 Aug, 2019 40 commits
-
-
Tomasz Śniatowski authored
Make the metadata machinery on Android use output_extension in shared_library and similar targets if it is set, so the gathered metadata matches the actual names of built binaries. GN shared_library targets can set a custom 'output_extension' (for example, to explicitly always have a .so extension and never .cr.so) and the Android metadata machinery should work with that. Test: set output_extension on a solib and build Android Bug: 980569 Change-Id: I12fb2b31e753adf81bac86c07e10aa913de51969 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730155 Auto-Submit: Tomasz Śniatowski <tsniatowski@vewd.com> Commit-Queue: Tomasz Śniatowski <tsniatowski@vewd.com> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#683668}
-
Michael Thiessen authored
Fixes handling of intent URLs in touchless mode. window.open('intent://...'); should now fire the BROWSABLE intent as expected. We do this by special casing the 'new window opens in CCT' logic to ignore intent:// schemes, and handle the resulting New Tab View Intent with the ExternalNavigationHandler. Bug: 983699 Change-Id: Ic28930db53686ae46c55496554e7388d12aa937c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733458Reviewed-by:Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#683667}
-
Robbie McElrath authored
This moves Feature set up in SSLErrorHandlerDateInvalidTest to the constructor rather than the SetUp method to make sure it gets set before things start checking for Features. Bug: 989225 Change-Id: If4b781ee37534bb8100a781aa99cecab8ad7f06d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732151Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#683666}
-
Richard Knoll authored
While we check the native notification platform bridge for the currently shown notifications, new ones might be added to the database. This will ignore all entries that are added after we started querying the OS. Bug: 988376 Change-Id: I5931a50fc5756987e095a19dbaed62045997f8ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732100Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#683665}
-
Wez authored
Tests use //ui/aura/test/test_screen.cc, which under Fuchsia calls InitializeViewTokenAndPresentView(), which creates a token and invokes fuchsia.ui.policy.Presenter.Present(). This may cause the presenter service to be started, if not already running, which may lead to crashes or logspam. Bug: DX-1801 Change-Id: I65f1ff5e86557d236de8df58cea351b265627a4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729514 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#683664}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/01915c0dd073..149f3f197897 git log 01915c0dd073..149f3f197897 --date=short --no-merges --format='%ad %ae %s' 2019-08-02 halcanary@google.com tools/sk_app: fWindowContext is unique_ptr<> 2019-08-02 mtklein@google.com add vbroadcastss(Ymm, GP64, int) 2019-08-02 halcanary@google.com sk_app, editor: cursor blink Created with: gclient setdep -r src/third_party/skia@149f3f197897 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@google.com Bug: None Change-Id: I5a590d56efea8d18df082ffc10083240670d0968 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733474Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683663}
-
Evan Stade authored
Bug: 268984 Change-Id: Ie41cb913d29ad690b9364d9c478c7a3c4771f607 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730591Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#683662}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I45dcee4561a33901f8c505629d933585662feccf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733570Reviewed-by:
-
Sam Maier authored
Binary-Size: We were mistakenly not doing this Bug: 965189 Change-Id: I03f64ec6b81ab9da97b3ef9258c7dec17706f91d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730845 Commit-Queue: Sam Maier <smaier@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Sam Maier <smaier@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#683660}
-
Ken Rockot authored
r680551 landed a partial fix which corrected the issue specifically for single-process mode, but the more general bug is that a UtilityProcessHost can still call UtilityProcessHost::Client::OnProcessTerminatedNormally() even if a process was never launched. This fixes the bug in all cases by ensuring that |launch_state_| is |kLaunchComplete| before invoking OnProcessTerminatedNormally(). This state is only set once process launch has successfully completed. Bug: 987448 Change-Id: I5c419cdb16b8f8b67058fdad0385b499552354e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733011Reviewed-by:
-
Tim Volodine authored
Move files that are still used in the network service code path to the /network_service directory. The idea is that the old /net directory is going to eventually disappear. BUG=989842,989104 Change-Id: I28a39353a9b4f4d6cecf04fb78df328272cfdefa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733547 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#683658}
-
rbpotter authored
Bug: 965770 Change-Id: I9e78f603d8649bd05ccff37c59a5a3f18c2c1623 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714324Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#683657}
-
Ian Wells authored
Refresh suggestions in the background with more urgency to bring Feed's background fetching in line with Zine's. Bug: 988165 Change-Id: I412ad34a7ec6c1b6c3ec3bf5e089ee2a0854e77f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730090 Commit-Queue: Ian Wells <iwells@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#683656}
-
Matt Simmons authored
R=yusufo@chromium.org Bug: 989638 Change-Id: I15558b826884ba4762f8d2e30bf3556798cfbb97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730526Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Matt Simmons <mattsimmons@chromium.org> Cr-Commit-Position: refs/heads/master@{#683655}
-
Miah Sanchez authored
Removed because this tast test is no longer failing. BUG=chromium:968155 TEST=Manual. Change-Id: Iaba0c34b16e2fb970af4295f919bf9e878e2f18d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732149Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Miah Sanchez <miahsanchez@google.com> Cr-Commit-Position: refs/heads/master@{#683654}
-
Peter Kotwicz authored
This CL makes chrome/browser/webapps OWNERS also OWNERS of WebAPK metrics in chrome/browser/metrics BUG=None Change-Id: I874c8560e0bfd393ad85b3ff85030d668bb2b993 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733115Reviewed-by:
-
Matt Menke authored
There is no IOThread anymore, and it's really testing browser/net stuff, so move it in there. The new name is NetworkQualityEstimatorBrowserTest, since that's what all the tests are checking. I removed on test for PAC script downloads that are hung during shutdown, as that's no longer an issue the browser process has to worry about - that's now a concern just for the NetworkService. Bug: 934009 Change-Id: Ic7e042c83c767a2ee8674bad12ce3dea53508c21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730857Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b43eb88b..75502974 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I10ac03e3680f4e8e5fe127c05385da0c1ccab049 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731647Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683651}
-
Ken Rockot authored
This eliminates the existence of the "chrome" and "chrome_renderer" services as well as general support for embedder-provided process-wide browser and renderer Service Manager services. Remanining browser<->renderer interfaces which used these services have been migrated to use direct receiver binding via content.mojom.ChildProcess or content.mojom.ChildProcessHost messages. Change-Id: I74f012aafe77fdcbbba8d93d193d3ded8d63d445 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729968Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
-
Max Moroz authored
Also removed "Custom options" section as it doesn't need to be advertised anymore. The only real usecase we still may have is `close_fd_mask`, but it's discouraged and we better use it on a case-by-case basis, when it's inevitable. Bug: 539572, 827228 Change-Id: I036303e1da0c844be4c3970ba5351651a2251a89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729847 Commit-Queue: Max Moroz <mmoroz@chromium.org> Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#683649}
-
Eric Foo authored
Bug: 977050 Change-Id: I8d646c24f67bc07d9653c8b42b4e782aaa4b89c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732690 Auto-Submit: Eric Foo <efoo@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#683648}
-
Jan Wilken Dörrie authored
This change modifies the leak_detection_api.proto to have the same package name as the server side definition. Bug: 986298 Change-Id: I259b4c78c59dc9898a212a88f294e9b20414086a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732079 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#683647}
-
Carlos Caballero authored
MessageLoopForIO will go away soon use ScopedTaskEnvironment instead. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you believe your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=nparker@chromium.org Change-Id: I70d76f6297874ac4a35bfe5e52a5033a081b09be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733533 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Commit-Queue: Nathan Parker <nparker@chromium.org> Cr-Commit-Position: refs/heads/master@{#683646}
-
Mike Reed authored
Bug: skia:9293 Change-Id: I5adae8c65415ffa96af2c636aa93581a2658be2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733435 Commit-Queue: Mike Reed <reed@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#683645}
-
Changwan Ryu authored
This should be landed after the upstream fix https://chromium-review.googlesource.com/c/chromium/src/+/1730313 and the downstream fix https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/1560327 land. Bug: 817644 Change-Id: I66a986374804b8e6642275ee08c2412458c12258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730781Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#683644}
-
Etienne Bergeron authored
This CL is renaming the GetActualFontNameForTesting to GetActualFontName. This function will be used in future CL. The difference between GetFontName and GetActualFontName is related to font mapping. The requested font name is the one the user is asking for and the mapped is the one used. We are exposing it since we want to get rid of the difference between GDI and DirectWrite: GDI name=Meiryo UI --> font-name:Arial actual-name:Arial DirectWrite name=Meiryo UI --> font-name:Meiryo UI actual-name:Segoe UI The GDI (e.g. PlatformFontWin) was the only one where the requested font was lost and were using the mapped font. Since that class is going away, the use of FontName and ActualFontName make sense. R=robliao@chromium.org, asvitkine@chromium.org Bug: 944227 Change-Id: I7a351c35a13ef07799c783454f206d76851ce02f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733437 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:Robert Liao <robliao@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#683643}
-
Daniel Cheng authored
Bug: 978579 Change-Id: I382b9da1d8aec0199355374ed6930a730b7e4562 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731788Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#683642}
-
Xiaoqian Dai authored
Refactoring CL. No functional change. Bug: None Change-Id: I6e6027b5994e48d3ebafb7ec09062600763b0d28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726665Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#683641}
-
Rayan Kanso authored
Keep track of how often the Contacts API is used by measuring calls to navigator.contacts.select. Bug: 990364 Change-Id: I10177d894d4e68be275fcf2fe7cf7c87ade0b311 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731847 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Auto-Submit: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
-
Carlos Caballero authored
MessageLoopForIO will go away soon use ScopedTaskEnvironment instead. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you believe your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=mmenke@chromium.org Change-Id: I2abffb81e28b6afcf29a9e0d96b1eff8163c130e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733494 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#683639}
-
Carlos Caballero authored
MessageLoopForIO will go away soon use ScopedTaskEnvironment instead. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you believe your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=carlosil@chromium.org Change-Id: I8a40cda13a2956cddde98da24717da74081f8457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733609 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#683638}
-
Brendan Hansknecht authored
Add navigationListVerticalScroll test. Rename navigationScrollsWhenClipped to navigationListHorizontalScroll. Add TODO to cleanup navigationListHorizontalScroll. Test: browser_tests --gtest_filter="FilesApp*navigationList*Scroll" Bug: 966807 Change-Id: Ia1a3eade2b9fbbe1341db2333ee4939dc13eb8a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726871 Commit-Queue: Brendan Hansknecht <bhansknecht@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#683637}
-
Mugdha Lakhani authored
We sometimes change the actual delay after which a periodicsync event is fired based on other registrations for the origin. Update what we show in Devtools so it corresponds to the actual delay_until set on the registration. Bug: 989524, 990207 Change-Id: Ie74b5cf1c4e48d58fb1b165aec54597cc018bc71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733487Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#683636}
-
Matt Menke authored
Previously, http_server_properties_impl.h included on broken_alternative_services.h which included http_server_properties.h. Since HttpServerPropertiesImpl is the only implementation of HttpServerProperties, I want to merge the two files, but that would result in a circular dependency due to the aforementioned dependency. This CL moves the alternative services-related members of http_server_properties.h into alternative_services.h, which broken_alternatives_services.h now depends on. Bug: 984996 Change-Id: Ibb037219662ea0c3eab534c1bf9b7c0f3ef4c32c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724752 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#683635}
-
Tim Volodine authored
Remove code that is not used anymore with the network service enabled. BUG=989104 Change-Id: If77bd19df957e6cb34f165cdafbe87a5e72c1fda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731932Reviewed-by:
-
Sky Malice authored
virtual/blink-cors/http/tests/fetch/serviceworker/thorough/redirect-loop-base-https-other-https.html virtual/blink-cors/http/tests/fetch/serviceworker/thorough/access-control-base-https-other-https.html TBR: zmin@chromium.org Bug: 990175, 990176, 989863 Change-Id: I7a58b9d6efad18a0fc8c3fe66d1f5f39d341ad24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732155 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
-
Carlos Caballero authored
MessageLoopForIO will go away soon use ScopedTaskEnvironment instead. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you believe your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=donnd@chromium.org Change-Id: Iffa04b1db906d1a04a73529a01711aa782a11971 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733597 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#683632}
-
Aya ElAttar authored
Upon entering the fullscreen/locked-fullscreen while the chromeVox panel is working, You can see an empty bar in the top of the screen. 1. The fullscreen rect y dimension starts after the height of the chromeVox panel, and as we don't want the chromeVox panel to be displayed, its height should be removed from the calculations. UPDATE: This issue got fixed by another colleague. So I added a unittest, and removed two workarounds were added to fix this issue in the locked-fullscreen mode. (one was to disable chromevox panel upon starting the lockedscreen mode, and the other was to hide the vox panel specifically for the locked fullscreen mode) When a window is set to fullscreen screen_util::GetFullscreenWindowBoundsInParent & AccessibilityPanelLayoutManager::UpdateWindowBounds() are called twice with this stacktraces order: [23272:23272:0723/164119.757770:ERROR:screen_util.cc(47)] ayaaa #0 0x0000081162bc base::debug::CollectStackTrace() #1 0x0000080a6c88 base::debug::StackTrace::StackTrace() #2 0x000009a8b57c ash::screen_util::GetFullscreenWindowBoundsInParent() #3 0x000009b93e62 ash::wm::DefaultState::UpdateBoundsFromState() #4 0x000009b93da4 ash::wm::DefaultState::EnterToNextState() #5 0x000009b93c2e ash::wm::DefaultState::HandleTransitionEvents() #6 0x000009b92e3e ash::wm::WindowState::OnWindowPropertyChanged() #7 0x000008d085f6 aura::Window::AfterPropertyChange() #8 0x0000082c62fc ui::PropertyHandler::SetPropertyInternal() #9 0x000008d0324c ui::PropertyHandler::SetProperty<>() #10 0x000009268956 views::Widget::SetFullscreen() #11 0x00000a088c28 BrowserView::ProcessFullscreen() #12 0x000009f48638 FullscreenController::EnterFullscreenModeInternal() #13 0x000009f47c98 FullscreenController::ToggleFullscreenModeInternal() #14 0x000009f47bba FullscreenController::ToggleBrowserFullscreenMode() #15 0x00000a0b45a8 (anonymous namespace)::BrowserWindowStateDelegate::ToggleFullscreen() #16 0x000009b93fc0 ash::wm::ToggleFullScreen() #17 0x000009b9177e ash::wm::WindowState::OnWMEvent() #18 0x000009a153ca ash::accelerators::ToggleFullscreen() #19 0x000009a13f72 ash::(anonymous namespace)::HandleToggleFullscreen() #20 0x000009a12332 ash::AcceleratorControllerImpl::AcceleratorPressed() #21 0x000009253988 ui::AcceleratorManager::Process() #22 0x000009ac225a ash::PreTargetAcceleratorHandler::ProcessAccelerator() .... #80 0x0000eae970a2 __libc_start_main [23272:23272:0723/164121.271202:ERROR:accessibility_panel_layout_manager.cc(103)] ayaaa #0 0x0000081162bc base::debug::CollectStackTrace() #1 0x0000080a6c88 base::debug::StackTrace::StackTrace() #2 0x000009a190fa ash::AccessibilityPanelLayoutManager::UpdateWindowBounds() #3 0x0000099ebd12 display::DisplayManager::NotifyMetricsChanged() #4 0x0000099ebf5a display::DisplayManager::UpdateWorkAreaOfDisplay() #5 0x000009a33610 ash::WindowTreeHostManager::UpdateWorkAreaOfDisplayNearestWindow() #6 0x000009a94ec6 ash::ShelfLayoutManager::UpdateBoundsAndOpacity() #7 0x000009a93680 ash::ShelfLayoutManager::SetState() #8 0x000009a932be ash::ShelfLayoutManager::UpdateVisibilityState() #9 0x000009b96428 ash::WorkspaceLayoutManager::SetChildBounds() #10 0x000009b8f6e4 ash::wm::SetBoundsInScreen() #11 0x000009276346 views::NativeWidgetAura::SetBounds() #12 0x000009225b72 views::BubbleDialogDelegateView::SizeToContents() #13 0x000009269980 views::Widget::OnNativeWidgetMove() #14 0x000009276cd4 views::NativeWidgetAura::OnBoundsChanged() #15 0x00000a0b4332 BrowserFrameAsh::OnBoundsChanged() #16 0x000008d0978c aura::Window::OnLayerBoundsChanged() #17 0x000008d19a6e ui::Layer::SetBoundsFromAnimation() #18 0x000008d0730c aura::Window::SetBoundsInternal() #19 0x000009b929a6 ash::wm::WindowState::SetBoundsDirect() #20 0x000009b93f0e ash::wm::DefaultState::UpdateBoundsFromState() #21 0x000009b93da4 ash::wm::DefaultState::EnterToNextState() #22 0x000009b93c2e ash::wm::DefaultState::HandleTransitionEvents() #23 0x000009b92e3e ash::wm::WindowState::OnWindowPropertyChanged() #24 0x000008d085f6 aura::Window::AfterPropertyChange() #25 0x0000082c62fc ui::PropertyHandler::SetPropertyInternal() #26 0x000008d0324c ui::PropertyHandler::SetProperty<>() #27 0x000009268956 views::Widget::SetFullscreen() #28 0x00000a088c28 BrowserView::ProcessFullscreen() #29 0x000009f48638 FullscreenController::EnterFullscreenModeInternal() #30 0x000009f47c98 FullscreenController::ToggleFullscreenModeInternal() #31 0x000009f47bba FullscreenController::ToggleBrowserFullscreenMode() #32 0x00000a0b45a8 (anonymous namespace)::BrowserWindowStateDelegate::ToggleFullscreen() #33 0x000009b93fc0 ash::wm::ToggleFullScreen() #34 0x000009b9177e ash::wm::WindowState::OnWMEvent() #35 0x000009a153ca ash::accelerators::ToggleFullscreen() #36 0x000009a13f72 ash::(anonymous namespace)::HandleToggleFullscreen() #37 0x000009a12332 ash::AcceleratorControllerImpl::AcceleratorPressed() #38 0x000009253988 ui::AcceleratorManager::Process() #39 0x000009ac225a ash::PreTargetAcceleratorHandler::ProcessAccelerator() #40 0x000009ab4ebe wm::AcceleratorFilter::OnKeyEvent() .... #97 0x0000eae970a2 __libc_start_main [23272:23272:0723/164123.029099:ERROR:screen_util.cc(47)] ayaaa #0 0x0000081162bc base::debug::CollectStackTrace() #1 0x0000080a6c88 base::debug::StackTrace::StackTrace() #2 0x000009a8b57c ash::screen_util::GetFullscreenWindowBoundsInParent() #3 0x000009b93764 ash::wm::DefaultState::SetMaximizedOrFullscreenBounds() #4 0x000009b9367a ash::wm::DefaultState::HandleWorkspaceEvents() #5 0x000009b5ac5e ash::wm::BaseState::OnWMEvent() #6 0x000009b9177e ash::wm::WindowState::OnWMEvent() #7 0x000009b968e6 ash::WorkspaceLayoutManager::AdjustAllWindowsBoundsForWorkAreaChange() #8 0x000009b96af8 ash::WorkspaceLayoutManager::OnDisplayMetricsChanged() #9 0x0000099ebd12 display::DisplayManager::NotifyMetricsChanged() #10 0x0000099ebf5a display::DisplayManager::UpdateWorkAreaOfDisplay() #11 0x000009a33610 ash::WindowTreeHostManager::UpdateWorkAreaOfDisplayNearestWindow() #12 0x000009a94ec6 ash::ShelfLayoutManager::UpdateBoundsAndOpacity() #13 0x000009a93680 ash::ShelfLayoutManager::SetState() #14 0x000009a932be ash::ShelfLayoutManager::UpdateVisibilityState() #15 0x000009b96428 ash::WorkspaceLayoutManager::SetChildBounds() #16 0x000009b8f6e4 ash::wm::SetBoundsInScreen() #17 0x000009276346 views::NativeWidgetAura::SetBounds() #18 0x000009225b72 views::BubbleDialogDelegateView::SizeToContents() #19 0x000009269980 views::Widget::OnNativeWidgetMove() #20 0x000009276cd4 views::NativeWidgetAura::OnBoundsChanged() #21 0x00000a0b4332 BrowserFrameAsh::OnBoundsChanged() #22 0x000008d0978c aura::Window::OnLayerBoundsChanged() #23 0x000008d19a6e ui::Layer::SetBoundsFromAnimation() #24 0x000008d0730c aura::Window::SetBoundsInternal() #25 0x000009b929a6 ash::wm::WindowState::SetBoundsDirect() #26 0x000009b93f0e ash::wm::DefaultState::UpdateBoundsFromState() #27 0x000009b93da4 ash::wm::DefaultState::EnterToNextState() #28 0x000009b93c2e ash::wm::DefaultState::HandleTransitionEvents() #29 0x000009b92e3e ash::wm::WindowState::OnWindowPropertyChanged() #30 0x000008d085f6 aura::Window::AfterPropertyChange() #31 0x0000082c62fc ui::PropertyHandler::SetPropertyInternal() #32 0x000008d0324c ui::PropertyHandler::SetProperty<>() #33 0x000009268956 views::Widget::SetFullscreen() #34 0x00000a088c28 BrowserView::ProcessFullscreen() #35 0x000009f48638 FullscreenController::EnterFullscreenModeInternal() #36 0x000009f47c98 FullscreenController::ToggleFullscreenModeInternal() #37 0x000009f47bba FullscreenController::ToggleBrowserFullscreenMode() #38 0x00000a0b45a8 (anonymous namespace)::BrowserWindowStateDelegate::ToggleFullscreen() #39 0x000009b93fc0 ash::wm::ToggleFullScreen() #40 0x000009b9177e ash::wm::WindowState::OnWMEvent() #41 0x000009a153ca ash::accelerators::ToggleFullscreen() #42 0x000009a13f72 ash::(anonymous namespace)::HandleToggleFullscreen() #43 0x000009a12332 ash::AcceleratorControllerImpl::AcceleratorPressed() #44 0x000009253988 ui::AcceleratorManager::Process() #45 0x000009ac225a ash::PreTargetAcceleratorHandler::ProcessAccelerator() #46 0x000009ab4ebe wm::AcceleratorFilter::OnKeyEvent() .... #103 0x0000eae970a2 __libc_start_main [23272:23272:0723/164124.932334:ERROR:accessibility_panel_layout_manager.cc(103)] ayaaa #0 0x0000081162bc base::debug::CollectStackTrace() #1 0x0000080a6c88 base::debug::StackTrace::StackTrace() #2 0x000009a190fa ash::AccessibilityPanelLayoutManager::UpdateWindowBounds() #3 0x000009ab0dea ash::Shell::NotifyFullscreenStateChanged() #4 0x000009b96a4c ash::WorkspaceLayoutManager::OnPostWindowStateTypeChange() #5 0x000009b92738 ash::wm::WindowState::NotifyPostStateTypeChange() #6 0x000009b93ddc ash::wm::DefaultState::EnterToNextState() #7 0x000009b93c2e ash::wm::DefaultState::HandleTransitionEvents() #8 0x000009b92e3e ash::wm::WindowState::OnWindowPropertyChanged() #9 0x000008d085f6 aura::Window::AfterPropertyChange() #10 0x0000082c62fc ui::PropertyHandler::SetPropertyInternal() #11 0x000008d0324c ui::PropertyHandler::SetProperty<>() #12 0x000009268956 views::Widget::SetFullscreen() #13 0x00000a088c28 BrowserView::ProcessFullscreen() #14 0x000009f48638 FullscreenController::EnterFullscreenModeInternal() #15 0x000009f47c98 FullscreenController::ToggleFullscreenModeInternal() #16 0x000009f47bba FullscreenController::ToggleBrowserFullscreenMode() #17 0x00000a0b45a8 (anonymous namespace)::BrowserWindowStateDelegate::ToggleFullscreen() #18 0x000009b93fc0 ash::wm::ToggleFullScreen() #19 0x000009b9177e ash::wm::WindowState::OnWMEvent() #20 0x000009a153ca ash::accelerators::ToggleFullscreen() #21 0x000009a13f72 ash::(anonymous namespace)::HandleToggleFullscreen() #22 0x000009a12332 ash::AcceleratorControllerImpl::AcceleratorPressed() #23 0x000009253988 ui::AcceleratorManager::Process() #24 0x000009ac225a ash::PreTargetAcceleratorHandler::ProcessAccelerator() #25 0x000009ab4ebe wm::AcceleratorFilter::OnKeyEvent() ... #82 0x0000eae970a2 __libc_start_main Bug: 945794,959786 Change-Id: If04f70f2c71563e9660c18ca942ef4b798ebcd3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702312 Commit-Queue: Aya Elsayed <ayaelattar@google.com> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Ivan Šandrk <isandrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#683631}
-
Matt Simmons authored
R=yusufo@chromium.org Change-Id: I2835007aa3449fcecd258a0ada14a00b5e1ec0ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730503Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/06eacf44d50f..01915c0dd073 git log 06eacf44d50f..01915c0dd073 --date=short --no-merges --format='%ad %ae %s' 2019-08-02 bsalomon@google.com GrCaps::supportedWritePixelsColorType takes CT/format rather than config. 2019-08-02 michaelludwig@google.com Update skottie/sksg to use new filter factories 2019-08-02 michaelludwig@google.com Update docs and samplecode to use new image filter factories 2019-08-02 michaelludwig@google.com Update fuzzer to use new image filter factories 2019-08-02 bungeman@google.com Tweak css3 weight score, prevent ties. 2019-08-02 senorblanco@chromium.org First implementation of GrDawnProgramBuilder. Created with: gclient setdep -r src/third_party/skia@01915c0dd073 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@google.com Bug: None Change-Id: I9973214a99d06d800f0130c681a1ea5c24f3dfd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733467Reviewed-by:
-
