- 04 Dec, 2019 40 commits
-
-
Peng Huang authored
This CL supports overlays with SkiaOutputDeviceBufferQueue via GLSurface. However this CL doesn't change the code in features::IsUsingSkiaRenderer() at [1], so SkiaRenderer is not used with Android surface control. [1] https://cs.chromium.org/chromium/src/components/viz/common/features.cc?type=cs&sq=package:chromium&g=0&l=76 TODO: * Refactor overlay related code out of GLSurface to a new class. those code is not GL related. * Use the new class to replace gl_surface_ in SkiaOutputDeviceBufferQueue. * Turn on SkiaRenderer with Android surface control. * Long term, we plan to use viz::BufferQueue for overlays. We need refactor overlay related code from SkiaOutputDevice* to a service side BufferQueue on GPU thread. Bug: 1012401 Change-Id: Ic66072cad8df72a1e4375a895ac4af5fde42a5f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949270 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#721491}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bb1785937ac6..c68502c177c6 Created with: gclient setdep -r src-internal@c68502c177c6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1017165 Tbr: jbudorick@google.com Change-Id: I738208bb62ee45fde96add382e87e1839814711d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950663Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721490}
-
Thomas Lukaszewicz authored
Removed references to hardcoded values for all control menu components and piped color access through native theme. Added appropriate color ids and native theme values for relevant platforms. Bug: 1003612 Change-Id: I013fed6425a8d74cd59288ef77898dd835e58d34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949105Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#721489}
-
Brandon Goddard authored
This change rebaselines and re-enables datagrid layout tests that were previously disabled in order to land https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1881219 This effectively reverts https://chromium-review.googlesource.com/c/chromium/src/+/1893144 Bug: 963183 Change-Id: I61d58e8417cafac067cca298f025ee1300def544 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904033Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Brandon Goddard <brgoddar@microsoft.com> Cr-Commit-Position: refs/heads/master@{#721488}
-
Olya Kalitova authored
Adds offline scenario to Crostini configuration dialog. If Crostini configuration failed while internet connection was missing dialog informs user that Chromebook is offline and user can retry configuration by hitting retry button. Bug: 1029809 Change-Id: I6a5e006b5acb7300568eb6a40d9636725c229a12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947655Reviewed-by:
Nic Hollingum <hollingum@google.com> Commit-Queue: Olya Kalitova <okalitova@chromium.org> Cr-Commit-Position: refs/heads/master@{#721487}
-
Kevin Ellis authored
Double rAF start of the test to avoid starting the animation while too busy to handle updates in a timely manner. Bug: 1029541 Change-Id: I3e0e665f0b4b9dd6f6a87d84d207b0c18a1b51c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946668 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#721486}
-
Hugo Holgersson authored
DeflateIfOverlapped() was introduced in SpatNav's very first WebKit commit [1], seemingly, to get some support for certain overlapping elements. It seems like we no longer need it... Since crrev.com/c/1605696, SpatNav better supports generic overlapping rects. The spec [2] that formalizes Chromium's SpatNav implementation never included it either. [1] https://trac.webkit.org/browser/webkit/trunk/ WebCore/page/SpatialNavigation.cpp?rev=55543 [2] https://drafts.csswg.org/css-nav-1/ Bug: 770147, 1000578 Change-Id: I498ccdb5032d97c89a5c015c893a2e5f08edd1f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949785 Commit-Queue: Hugo Holgersson <hholgersson@fb.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#721485}
-
Ali Juma authored
This adds the file as an EG2 target, updates #includes, and replaces calls to helpers that can't be used in EG2. This also adds a ProgressIndicatorAppInterface class that provides a matcher for MDCProgressViews with a given progress value. Bug: 987646 Change-Id: I88b8bc9496bf962acbba59d855205cf19cf97fd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949266 Commit-Queue: Ali Juma <ajuma@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#721484}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/98d4bce4..2b3800c4 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7f1fed78e8b3196d533d88692715164777b02269 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950583Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721483}
-
Alex Chau authored
- RemoveKey was accidentally added in https://crrev.com/c/1944502 - Added test to verify JWT payload and base64 url decode public key Bug: 1029747, 1029483 Change-Id: I248b80898839846a0b0832cf333e49b2c29a8c84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950532Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#721482}
-
Jonathan Backer authored
Bug: 967716 Change-Id: I009d6d13d4392f1c0609b684831ccdf07a9665c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925505 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#721481}
-
Vadym Doroshenko authored
Bug: 959776 Change-Id: I3c6a42ab454d57b7072fc1b752ea1dcb1c7c5991 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945817Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#721480}
-
Balazs Engedy authored
This is a reland of c8b3dc82. The previous attempt to land led to a compile error, because it clashed with a concurrently landed CL (crrev.com/c/1944173), which added an #include to `adaptive_notification_permission_ui_selector.h`, which is renamed by this CL. Relanding this verbatim, the other CL will be rebased on top of this one. Original change's description: > Socialize QuietNotificationPrompt prefs. > > Decouple call sites that wish to check the quiet UI state (or the promo > state) from AdaptiveNotificationPermissionUiSelector, and instead make > this call sites consult QuietNotificationPermissionUIState, which acts > a thin layer to read/write preferences. > > Rename AdaptiveNotificationPermissionUiSelector to > AdaptiveQuietNotificationPermissionUiEnabler to better reflect the new > responsibility of this class is to merely toggle a setting, the actual > UI will be selected by the PermissionRequestManager. > > This CL also renames `permission_features.h`, for consistency, to > `quiet_notification_permission_ui_config.h`. > > Bug: 1028642, 1030216 > Change-Id: If52dfab3532a473399091bf4291e863cf70142f0 > TBR: battre@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948892 > Commit-Queue: Balazs Engedy <engedy@chromium.org> > Reviewed-by: Natalie Chouinard <chouinard@chromium.org> > Reviewed-by: Martin Šrámek <msramek@chromium.org> > Reviewed-by: Andy Paicu <andypaicu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#721449} Bug: 1028642, 1030216 Change-Id: I6bf5a7fa51da10fd8b7a8cdd7eecca236fbefb1d TBR: msramek@chromium.org, chouinard@chromium.org, battre@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950526Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#721479}
-
Friedrich Horschig authored
Most likely, `std::move(*quit_task).Run();` could be called twice for the same |quit_task| at times. By introducing a RunLoop, it doesn't matter (anymore) how often the loop is quit. This should fix the flaky crashes of this test as described in the linked bug. Bug: 1030275 Change-Id: I9509d474cc950362996f31a879034fb01ca5303c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948895 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
-
Marian Fechete authored
This CL moves ownership of user_data to the Controller, and ensures that we can resume the CollectUserDataAction (by keeping the previous user data/model). In order to achieve this, the CL also moves ownership of the collect user data options to the action. When a new proto is sent by a subsequent CollectUserDataAction, the proto options take precedence over any existing user_data values. This allows the backend to control whether it wants to resume a previous partial action or whether to start one from scratch. There are some outstanding items to resolve in future CLs. Bug: b/140019232 Change-Id: Ia177573c6ebab4cc674909f58141a8d6977350ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949786 Commit-Queue: Marian Fechete <marianfe@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#721477}
-
Andreas Haas authored
The code there could already deal with size_t, so just use ByteLengthAsSizeT instead. R=haraken@chromium.org Bug: chromium:1008840 Change-Id: I11f6c83b6871ed949c5b1a766a499c3306e12dec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949800Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#721476}
-
Andreas Haas authored
The code there could already deal with size_t anyways, so just use byteLengthAsSizeT. R=haraken@chromium.org Bug: chromium:1008840 Change-Id: I8cc34d8b91963967e7a58b33d53f03c622aab9af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949799Reviewed-by:
-
Nazerke authored
This CL - adds the source file to sources list, - adds required gn dependencies, - links to both eg1 and eg2 frameworks, _ adds helpers into SigninEarlGreyUtils used in accounts_table_egtests. Bug: 866147 Change-Id: I4435f82551f44a242f04e7af1dfd9d8a70583a06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903191 Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
-
Antonio Gomes authored
... to use THREAD_CHECKER instead. Blink does not currently make use of sequences. BUG=787254 R=guidou@chromium.org Change-Id: Ie46eaacaae2b8c62e2e8e5d8944719d9e1bca8c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948326 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#721473}
-
Jaeyong Bae authored
This patch means handling exception when we got redirect header without location value from server. Bug: 891738 Change-Id: I5fd781cbe94262123a08bcc185bf88f91027878b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897375 Commit-Queue: Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#721472}
-
Tien Mai authored
The original revert was done prematurely to fix a build break but this change was not the cause of the build break. This reverts commit 6c8601ff. Reason for revert: <INSERT REASONING HERE> Original change's description: > Revert "Include compatibility checks when submitting policy_templates.json." > > This reverts commit d44d94c6. > > Reason for revert: I think this is the cause for this tree-closing failure: > https://ci.chromium.org/p/chromium/builders/ci/win32-archive-rel/7768 > > Original change's description: > > Include compatibility checks when submitting policy_templates.json. > > > > This will change the presubmit checks for policy_templates.json to > > ensure that policy changes are backwards compatible with policies > > definitions that have already shipped. > > > > Bug: 1026330 > > Change-Id: If054d2376397432c66d948eaf0d2d42d5db13a0b > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925190 > > Reviewed-by: Sergey Poromov <poromov@chromium.org> > > Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> > > Commit-Queue: Tien Mai <tienmai@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#721123} > > TBR=pastarmovj@chromium.org,poromov@chromium.org,tienmai@chromium.org > > Change-Id: I0ac66ee107a0ad25675e149192b47868653c525c > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1026330 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949265 > Reviewed-by: Takumi Fujimoto <takumif@chromium.org> > Commit-Queue: Takumi Fujimoto <takumif@chromium.org> > Cr-Commit-Position: refs/heads/master@{#721139} TBR=pastarmovj@chromium.org,poromov@chromium.org,takumif@chromium.org,tienmai@chromium.org Change-Id: I4ad04786c13ad4cf8be57399489e0bf311cd6fb6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1026330 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950744Reviewed-by:
Tien Mai <tienmai@chromium.org> Commit-Queue: Tien Mai <tienmai@chromium.org> Cr-Commit-Position: refs/heads/master@{#721471}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/52d49231905d..e4327893aa50 git log 52d49231905d..e4327893aa50 --date=short --first-parent --format='%ad %ae %s' 2019-12-04 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update Devtools DEPS. 2019-12-04 yangguo@chromium.org Introduce AUDITS_OWNERS and remove redundant OWNERS entries Created with: gclient setdep -r src/third_party/devtools-frontend/src@e4327893aa50 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Idbcb424f0ce159e360ffcf3afc7b94f83d7ed453 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950441Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721470}
-
Kevin Ellis authored
100ms is likely not enough time to ensure that the animation can be paused on all test configurations. Failures are more prevalent when run in a composited test environment, but also appear when run outside of a virtual test suite. To avoid needing to wait an extended period of time for the finished state. The animation duration is reduced back to 100ms once the pause state has been detected. Bug: 986019 Change-Id: Ib1a07cb495ef8b9f40ec4032d835ce758d3a5f70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949111Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 10f96d6f. With Chromium commits locally applied on WPT: 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." a2a91a99 "Allow another touch start happen when there are active touch points" 85b61e6b "[resource-timing] Ensure workerStart is protected by TAO" a75430aa "Fix appcache tests." a50e7e60 "Move `Sec-Fetch-User` to SetSecFetchMetadataHeaders." 83e4a43b "Refactor VRPose to fit better with WebXr concepts" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: Iaeb08901fc15c6c63a560c5200078c6986308d5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949649Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721468}
-
kylechar authored
Unthrottling clients as soon as they acked any begin frame was not effective in preventing a huge backlog of OnBeginFrame() IPCs from building up. Instead of allowing any ack to unthrottle, instead count the number of sent BeginFrameArgs and received BeginFrameAcks. To avoid problems where clients don't properly ack all OnBeginFrame() messages but are still responsive, if the client acks the latest BeginFrameArgs then we treat it like they have acked all outstanding begin frames. Bug: 1011441 Change-Id: I9d0b73a189945d03c4e0590b1acea52df020ee03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947186 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#721467}
-
Jan Wilken Dörrie authored
This change that adds base::Value::ClearList() as a convenient way to completely clear a list Value. Bug: 646113 Change-Id: I83d2a1b8f51595ca0e70b88d66013ea600fd4b98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949798Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#721466}
-
ckitagawa authored
Adds a base class for creating keyed services based that use paint previews. This class will expose all the necessary APIs for using paint previews such that no other API surface for paint previews should be required for features using them. Classes that extend this service should manage: - Lifecycle of paint previews (deletion, etc.) - Handling incognito/off-the-record behavior Bug: 1030269 Change-Id: I982da36f7a2ca3e04c3d3575747a25cf8461d1cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887728Reviewed-by:
Ian Vollick <vollick@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#721465}
-
Robert Kaplow authored
Bug: 1016906 Change-Id: I1e682a4bfd221463baa95849a73586b0e3c993cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943534Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Auto-Submit: Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#721464}
-
Fergal Daly authored
This test class was renamed in https://crrev.com/c/1933847 TBR=altimin@chromium.org Bug: 1030673 Change-Id: I617ad5f589ff92676e76aa2bf485d786b1255bec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950264Reviewed-by:
Fergal Daly <fergal@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#721463}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/dc7697bc61e9..7e9dc4222803 git log dc7697bc61e9..7e9dc4222803 --date=short --first-parent --format='%ad %ae %s' 2019-12-04 borenet@google.com [infra] Auto-submit the CL to update supported branch configs Created with: gclient setdep -r src/third_party/skia@7e9dc4222803 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bsalomon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bsalomon@google.com Change-Id: I4c3569c05b4964cb96128fc4c3649bfe66698993 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950436Reviewed-by:
-
Mohamed Amir Yosef authored
This reverts commit 6c72bce2. Reason for revert: Caused test failures on linux-chromeos-dbg https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/15583 Original change's description: > Install PluginVM DLC > > PluginVM DLC should be installed when the PluginVM tools are not rootfs > present and skip/handle the install when rootfs resident. > > The call to |PathExists()| is not used as it is a blocking call on the > UI thread, instead the dlcservice error indicating an invalid DLC is > used to determine whether PluginVM has been enabled as a DLC (rootfs > resident or not). > > Bug: b:143104338 > Test: Manual startup of PluginVM > Change-Id: Id028711c98cc4cc91ef1e0b234cbf48084cc3eb3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924723 > Commit-Queue: Timothy Loh <timloh@chromium.org> > Auto-Submit: Jae Hoon Kim <kimjae@chromium.org> > Reviewed-by: Timothy Loh <timloh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#721333} TBR=timloh@chromium.org,kimjae@chromium.org Change-Id: I4d21b8264bbde9151511a77788c692298d5d7f15 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:143104338 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950507Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#721461}
-
Mathias Bynens authored
DevTools CLs that change the User-Agent emulation functionality: - https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1949544 - https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1947533 - https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1944335 CL that temporarily accepted failure for this test: https://chromium-review.googlesource.com/c/chromium/src/+/1948883 Bug: chromium:1029031 Change-Id: If44999af9a66405641c00bef9002645bbfe00a39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949795 Commit-Queue: Mathias Bynens <mathias@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Auto-Submit: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#721460}
-
Rayan Kanso authored
This reverts commit 6e91b688. Reason for revert: Broke the build - https://ci.chromium.org/p/chrome/builders/ci/android-internal-chromium-tot/44960 - https://ci.chromium.org/p/chrome/builders/ci/arm64-builder-rel/20383 Original change's description: > Added IPH for the mini-infobar notification permission prompt (android) > > As part of the new quieter notification prompt, add IPH for the android > quieter notification permission prompt. To be shown the first time > the setting is enabled. > > This is controlled by using the functions: > * AdaptiveNotificationPermissionUiSelector::ShouldShowPromo > * AdaptiveNotificationPermissionUiSelector::PromoWasShown > > Quick mock of how this is supposed to look: > https://docs.google.com/document/d/1hsp1j08yzIK6M6G7pbsdEihU8CLN7QQ3V2iAxESrqQM/edit?usp=sharing > > Bug: 1029595 > Change-Id: I3c90dda846a70396f1130c2ad6dcfc3622b9b25f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944173 > Commit-Queue: Andy Paicu <andypaicu@chromium.org> > Reviewed-by: Brian White <bcwhite@chromium.org> > Reviewed-by: Matthew Jones <mdjones@chromium.org> > Reviewed-by: Kamila Hasanbega <hkamila@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Reviewed-by: Balazs Engedy <engedy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#721442} TBR=nyquist@chromium.org,engedy@chromium.org,dtrainor@chromium.org,bcwhite@chromium.org,mdjones@chromium.org,bsazonov@chromium.org,andypaicu@chromium.org,hkamila@chromium.org Change-Id: Id1c9af183ed460c6e0e1159c66ec561236b13d2e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1029595 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950527Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#721459}
-
David Van Cleve authored
We currently count page-level referrer policies set by the Referrer-Policy header, but there's no corresponding counter for page-scoped policies set by the <meta> tag. Change-Id: I6f614fcc28dc58be07a029d06363325841912af1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948491Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#721458}
-
Sergio Villar Senin authored
It's only used inside Blink so it does not make sense to expose it. As it is no longer part of the public API, we're renaming WebEditingCommandType to EditingCommandType. Bug: 919392 Change-Id: I22e9ffa7ac9717d57cfc006ee7061ea8eb1ab0d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949793Reviewed-by:
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<HTMLImageElement> and DynamicTo<HTMLImageElement> as new downcast helper 2. Use IsA<HTMLImageElement>(element) in place of IsHTMLImageElement(element) Bug: 891908 Change-Id: I008724434d88a9c2870765ce1d2d6e503f595dab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948667 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#721456}
-
Mikhail Khokhlov authored
TBMv3 metrics are an experimental feature so far, so it doesn't make sense to spam production logs with it. Bug: 1030508 Change-Id: I966c0b7c9111f23b2f566abb5c3846e855338782 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949468 Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Auto-Submit: Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#721455}
-
Balazs Engedy authored
This reverts commit c8b3dc82. Reason for revert: Broke android compile. https://ci.chromium.org/p/chromium/builders/ci/Android%20Release%20(Nexus%205X)/26945 Original change's description: > Socialize QuietNotificationPrompt prefs. > > Decouple call sites that wish to check the quiet UI state (or the promo > state) from AdaptiveNotificationPermissionUiSelector, and instead make > this call sites consult QuietNotificationPermissionUIState, which acts > a thin layer to read/write preferences. > > Rename AdaptiveNotificationPermissionUiSelector to > AdaptiveQuietNotificationPermissionUiEnabler to better reflect the new > responsibility of this class is to merely toggle a setting, the actual > UI will be selected by the PermissionRequestManager. > > This CL also renames `permission_features.h`, for consistency, to > `quiet_notification_permission_ui_config.h`. > > Bug: 1028642, 1030216 > Change-Id: If52dfab3532a473399091bf4291e863cf70142f0 > TBR: battre@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948892 > Commit-Queue: Balazs Engedy <engedy@chromium.org> > Reviewed-by: Natalie Chouinard <chouinard@chromium.org> > Reviewed-by: Martin Šrámek <msramek@chromium.org> > Reviewed-by: Andy Paicu <andypaicu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#721449} TBR=battre@chromium.org,engedy@chromium.org,msramek@chromium.org,andypaicu@chromium.org,chouinard@chromium.org Change-Id: I096f295d07422e0c69192de1d147c87956305f58 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1028642, 1030216 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950524Reviewed-by:
-
Finnur Thorarinsson authored
Bug: 1029056, 656015 Change-Id: I63d2c7b650ddd64dcb48ef89a4179bea5e3b2ec8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949477 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Auto-Submit: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/10bac4e42d06..7ff7c98ede3e git log 10bac4e42d06..7ff7c98ede3e --date=short --first-parent --format='%ad %ae %s' 2019-12-04 perezju@chromium.org [Telemetry] Allow benchmarks to specify TBMv3 metrics Created with: gclient setdep -r src/third_party/catapult@7ff7c98ede3e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1012687 Tbr: sadrul@google.com Change-Id: Ia873d794d426284993f776d7ca32e39d45b13a8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950250Reviewed-by:
-
