- 21 May, 2019 40 commits
-
-
Jan Krcal authored
Printers sync runs on the UI thread but so far uses a proxy delegate that posts tasks from UI thread to UI thread. This CL simplifies that and employs a forwarding delegate that runs tasks synchronously. After this CL, all data types running on the UI thread will have forwarding delegates. Bug: 867801 Change-Id: I08e261323a9caa816899dd924f09ecdee69ec936 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621907 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#661732}
-
sczs authored
Bug: 963604 Change-Id: I0756aadcc3573eeb917e1ab097d2a16e64f2c584 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621077Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#661731}
-
sczs authored
Whenever the Banner was being dismissed by swiping up the safe area margins would push the banner content down. This fixes that. Bug: 911864 Change-Id: I3d51529c9d94fa6f0198da407f72ac3b3fa2f089 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621687Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/aaa114368e1b..97716c01324e git log aaa114368e1b..97716c01324e --date=short --no-merges --format='%ad %ae %s' 2019-05-21 hta@webrtc.org Implement max-channels for SCTP datachannels. 2019-05-21 srte@webrtc.org Adds IsEmpty to SampleStats. Created with: gclient setdep -r src/third_party/webrtc@97716c01324e The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:943976 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie5a52e189d3af9be618d91d661623b7d48b5bb8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621976Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#661729}
-
BUG=762641 TBR=minch@google.com Change-Id: I9abb3aad8bfd39bd83e1eb1e9bfa676e2ede8bad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622185Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#661728}
-
Huanzhong Huang authored
How TableViewDetailIconCell layouts its detailTextLabel depends on the current content size category (font size): detailTextLabel comes after textLabel for a non-accessibility font size; detailTextLabel is laid below textLabel for an accessibility font size. Currently detailTextLabel is set to have a right text alignment. This is correct only for cases with a non-accessibility font size (when detailTextLabel is laid after textLabel). This change is to adjust TableViewDetailIconCell so that the detailTextLabel has a left text alignment when current content size category is an accessibility category. (For simplicity, the above description assumes the system language being left-to-right; right-to-left languages are correctly handled by this change.) Bug: 935350 Change-Id: If990da70fb0fcc3bb9f63ec7be1112a651444e41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609897Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> Cr-Commit-Position: refs/heads/master@{#661727}
-
Denis Kuznetsov authored
Bug= b:130322365 Change-Id: I9b1e68d53650a17e145d7fd62d5cee0d88dae541 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615204Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#661726}
-
James Cook authored
Introduce a public SystemTrayTestApi interface, with a factory function implemented inside //ash. This allows tests to use synchronous calls into ash, rather than mojo async waiters. Bug: 958219 Change-Id: I3ba10b27b630f8c69f5b195485c6ec2c09265ec0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606962Reviewed-by:
Jun Mukai <mukai@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#661725}
-
Denis Kuznetsov authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/48dde549792d..da0aa1219dc8 $ git log 48dde5497..da0aa1219 --date=short --no-merges --format='%ad %ae %s' 2019-05-08 itspeter runtime_probe: skeleton to report VPD data Created with: roll-dep src/third_party/cros_system_api Bug=b:130322365 Change-Id: Iaeb1739f614aca018b3bbd54fac19c57831ccc98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621913Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
-
Peter E Conn authored
This code should have no behavioural change - it's just a small CL to split the code out and add tests. Bug: 964914 Change-Id: I0a6d3b356931ddaa7863f490cddc4009195a8495 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621174Reviewed-by:
Pavel Shmakov <pshmakov@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#661723}
-
Gauthier Ambard authored
This CL moves the NativeCode part of WebController out to LegacyNativeContentController. This object exposes an API to interact with the NativeContent. Its delegate (the WebController) contains the rest of the methods to allow interactions with the rest of content. It also moves the ownership of the NativeContent from WebControllerContainerView to the LegacyNativeContentController. The WebControllerContainerView can access the NativeContent through its delegate. Bug: 956523 Change-Id: Ie92be0afc95c5e77499bb7d62d3dab15c962a3b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1587891Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#661722}
-
Lutz Justen authored
This reverts commit 6244e906. Reason for revert: Fix test for real this time (reland + CL:1621130). Original change's description: > Revert "Reland "Add dialog to add Kerberos accounts"" > > This reverts commit 42829c6b. > > Reason for revert: The test is still broken > > Original change's description: > > Reland "Add dialog to add Kerberos accounts" > > > > This reverts commit 3335a801. > > > > Reason for revert: Fixed the test (see diff PS1 - PS2). > > > > Original change's description: > > > Revert "Add dialog to add Kerberos accounts" > > > > > > This reverts commit 3f0c9943. > > > > > > Reason for revert: Broke CrSettingsPeoplePageKerberosAccountsTest.All on linux-chromeos-dbg. See https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/12486 for first failing build. > > > > > > Original change's description: > > > > Add dialog to add Kerberos accounts > > > > > > > > Adds a Chrome OS-only dialog to add Kerberos accounts and displays it > > > > in the Kerberos Accounts settings page when the 'Add account' button > > > > is clicked there. The dialog is functional, but needs further polish > > > > and UX review. > > > > > > > > The functionality is guarded by the KerberosEnabled policy (off by > > > > default, cannot be enabled so far except for dev purposes). > > > > > > > > BUG=chromium:952238 > > > > TEST=Turn on KerberosEnabled policy, e.g. in YAPS or with a json file on > > > > the DUT in /etc/opt/chrome/policies/managed/ with contents > > > > { "KerberosEnabled": true } > > > > (requires writeable rootfs). Note that there's no admin console UI > > > > yet. On Chromebook, navigate to chrome:settings/kerberosAccounts, > > > > click Add account. Verify that the 'Add Kerberos Account' dialog > > > > opens. You might be able to log in with an Active Directory account > > > > (e.g. chromeadm-lab.com), but at the time of writing the Kerberos > > > > system daemon is not ready, so you should see some error. > > > > > > > > Change-Id: I94c07c8cbbb59c9b4153929c88a534a9a36210f6 > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596427 > > > > Commit-Queue: Lutz Justen <ljusten@chromium.org> > > > > Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> > > > > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#661355} > > > > > > TBR=stevenjb@chromium.org,dpapad@chromium.org,ljusten@chromium.org > > > > > > Change-Id: Ic5615c3ab21cef87bb707d60fabeb7e6fc033815 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: chromium:952238 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621467 > > > Reviewed-by: Fergus Dall <sidereal@google.com> > > > Commit-Queue: Fergus Dall <sidereal@google.com> > > > Cr-Commit-Position: refs/heads/master@{#661542} > > > > TBR=stevenjb@chromium.org,dpapad@chromium.org,ljusten@chromium.org,sidereal@google.com > > > > Change-Id: Ie24a3aad23924f85d29902aebfe35cd7b63f6a50 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: chromium:952238 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620628 > > Reviewed-by: Lutz Justen <ljusten@chromium.org> > > Commit-Queue: Lutz Justen <ljusten@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#661646} > > TBR=stevenjb@chromium.org,dpapad@chromium.org,ljusten@chromium.org,sidereal@google.com > > Change-Id: I23559808c98200730271493c72d028cd58f4ee37 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: chromium:952238 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621034 > Reviewed-by: Madeleine Barowsky <mbarowsky@chromium.org> > Commit-Queue: Madeleine Barowsky <mbarowsky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#661711} TBR=stevenjb@chromium.org,dpapad@chromium.org,ljusten@chromium.org,mbarowsky@chromium.org,sidereal@google.com Change-Id: I37ced4409351bceda9648c46b79608fe04ba2fa9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:952238 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621137Reviewed-by:
Madeleine Barowsky <mbarowsky@chromium.org> Commit-Queue: Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#661721}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/69fc6ea2..9c07b13a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia0f53f83365644d3374eebb9499fd75bb888b5ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621971Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#661720}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3fb150370062..55d3d90ebb7a git log 3fb150370062..55d3d90ebb7a --date=short --no-merges --format='%ad %ae %s' 2019-05-21 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (nontrivial). Created with: gclient setdep -r src/third_party/skia@55d3d90ebb7a The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@google.com Change-Id: I4ab3bb7f9bc6b6d0540f0f10f86b67a6dd90e7c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621972Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/5655d8f9f189..3782c7a455dc git log 5655d8f9f189..3782c7a455dc --date=short --no-merges --format='%ad %ae %s' 2019-05-21 perezju@chromium.org [Telemetry] Refuse to connect to older Chrome versions Created with: gclient setdep -r src/third_party/catapult@3782c7a455dc The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:962883 TBR=crouleau@google.com Change-Id: Ifb0b71aac8141b4f292b57b25ef8a261047277ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621974Reviewed-by:
-
Sergey Poromov authored
Change-Id: I33d0cff58fc5974afe575cd28f039c443c02450c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1249582Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#661717}
-
Bailey Berro authored
Rename IsNotification to IsNotificationDisplayed to more clearly convey the functionality. Change-Id: I4cfa84b8211b016f9ea867263080deb230e83c6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621356 Auto-Submit: Bailey Berro <baileyberro@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#661716}
-
Morten Stenshorne authored
TBR=eae@chromium.org Bug: 829028,964183 Change-Id: I2f5a85a7f77978dee4c225c7a95a0b7caf14411c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621169Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#661715}
-
Sidney San Martín authored
For longer documents, RenderWidgetHostViewCocoa only gets a chunk of text around the current selection. This change fixes -selectedRange to return an absolute range instead of one relative to the available text. Bug: 42434 Change-Id: If3f9377676de3f125a1f00d5de687c0cef53fc08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621387Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#661714}
-
Sylvain Defresne authored
FaviconService's callbacks are only invoked once but they predate the introduction of base::OnceCallback so they are declared as base::Callback which correspond to base::RepeatingCallback. Change them to use base::OnceCallback to reflect that they will only be invoked once. This will allow removing the pattern base::Passed(std::moved(...)) in the call to base::Bind() in a followup CL. Change MockFaviconService to remove a workaround for old version of gMock that did not support move-only parameters. Removing the workaround required also removing the PostReply and other action template to instead use lambdas (ByMove cannot be used as it is limited to Return action as far as I can tell). Bug: 759710, 714018 Change-Id: Id721ce07a3f1b305b326c84465259f7b45424798 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613181 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Adds a flag to experiment with scheduling garbage collections based on global memory knowledge in V8. Bug: 948807 Change-Id: I96ea0e33bb61b09e67ea40aa4cb198ed0de23d13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619794Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#661712}
-
Madeleine Barowsky authored
This reverts commit 42829c6b. Reason for revert: The test is still broken Original change's description: > Reland "Add dialog to add Kerberos accounts" > > This reverts commit 3335a801. > > Reason for revert: Fixed the test (see diff PS1 - PS2). > > Original change's description: > > Revert "Add dialog to add Kerberos accounts" > > > > This reverts commit 3f0c9943. > > > > Reason for revert: Broke CrSettingsPeoplePageKerberosAccountsTest.All on linux-chromeos-dbg. See https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/12486 for first failing build. > > > > Original change's description: > > > Add dialog to add Kerberos accounts > > > > > > Adds a Chrome OS-only dialog to add Kerberos accounts and displays it > > > in the Kerberos Accounts settings page when the 'Add account' button > > > is clicked there. The dialog is functional, but needs further polish > > > and UX review. > > > > > > The functionality is guarded by the KerberosEnabled policy (off by > > > default, cannot be enabled so far except for dev purposes). > > > > > > BUG=chromium:952238 > > > TEST=Turn on KerberosEnabled policy, e.g. in YAPS or with a json file on > > > the DUT in /etc/opt/chrome/policies/managed/ with contents > > > { "KerberosEnabled": true } > > > (requires writeable rootfs). Note that there's no admin console UI > > > yet. On Chromebook, navigate to chrome:settings/kerberosAccounts, > > > click Add account. Verify that the 'Add Kerberos Account' dialog > > > opens. You might be able to log in with an Active Directory account > > > (e.g. chromeadm-lab.com), but at the time of writing the Kerberos > > > system daemon is not ready, so you should see some error. > > > > > > Change-Id: I94c07c8cbbb59c9b4153929c88a534a9a36210f6 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596427 > > > Commit-Queue: Lutz Justen <ljusten@chromium.org> > > > Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> > > > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#661355} > > > > TBR=stevenjb@chromium.org,dpapad@chromium.org,ljusten@chromium.org > > > > Change-Id: Ic5615c3ab21cef87bb707d60fabeb7e6fc033815 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: chromium:952238 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621467 > > Reviewed-by: Fergus Dall <sidereal@google.com> > > Commit-Queue: Fergus Dall <sidereal@google.com> > > Cr-Commit-Position: refs/heads/master@{#661542} > > TBR=stevenjb@chromium.org,dpapad@chromium.org,ljusten@chromium.org,sidereal@google.com > > Change-Id: Ie24a3aad23924f85d29902aebfe35cd7b63f6a50 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: chromium:952238 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620628 > Reviewed-by: Lutz Justen <ljusten@chromium.org> > Commit-Queue: Lutz Justen <ljusten@chromium.org> > Cr-Commit-Position: refs/heads/master@{#661646} TBR=stevenjb@chromium.org,dpapad@chromium.org,ljusten@chromium.org,sidereal@google.com Change-Id: I23559808c98200730271493c72d028cd58f4ee37 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:952238 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621034Reviewed-by:
-
Victor Vasiliev authored
This replaces manual calls to url::Initialize() with a new initializer based on C++11 local static variables. As those are thread-safe, so is the new method. Also replace Shutdown() with code that resets the URL scheme registry. The old method actually released the memory used, but this is only relevant when loading //url as a dynamic library (i.e. something that probably already wouldn't work well), and all actual callers use it as a reset method. Change-Id: Iad546bbf690991ea3e40e008737998a2c230be8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600497 Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#661710}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/dc4f4a5b1582..ac05c2a27a7e git log dc4f4a5b1582..ac05c2a27a7e --date=short --no-merges --format='%ad %ae %s' 2019-05-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/glslang/src 6e384fef6c0f..27ec91958501 (2 commits) Created with: gclient setdep -r src/third_party/angle@ac05c2a27a7e The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@google.com Change-Id: I83744a82fa9195d4114474e33d0fc1bafd055643 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621523Reviewed-by:
-
Monica Basta authored
Updated the orderfile pipeline to support generation of an orderfile based on the new instrumentation call graph information. To enable using the call graph instrumention, set |--use-call-graph|. This CL uses the counts of how many a pair of (caller, callee) was recorded to define the distance between them. It then constructs the neighbors, and uses the existing clustering algorithm to produce the orderfile. Bug: 963833 Change-Id: Idd07a7a0aa5e00d87581fc68fe60374fe426d24c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615022Reviewed-by:
Matthew Cary <mattcary@chromium.org> Commit-Queue: Monica Basta <msalama@google.com> Cr-Commit-Position: refs/heads/master@{#661708}
-
Alexander Hendrich authored
This CL... * adds a new extension (also hosted on chrome webstore), which is whitelisted for the sign-in screen. * adds a new test case for this whitelisted extension to signin_profile_apps_policy_browsertest.cc * checks that the whitelisted extension has the new "login_screen_extension" type introduced in CL 1533910. DD: go/dd-login-screen-extensions Bug: 957573, 938943 Test: unit_tests --gtest_filter=SigninProfileExtensionsPolicy* Change-Id: I184235439d7aa0534cc1b72f90e144e5b12e11c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584275 Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#661707}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c9cac42e2459..e911f3927c33 git log c9cac42e2459..e911f3927c33 --date=short --no-merges --format='%ad %ae %s' 2019-05-21 primiano@google.com Merge "Add helper class for heap-based protozero messages" Created with: gclient setdep -r src/third_party/perfetto@e911f3927c33 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I759ebf9785cef1b2f732d42486a8b7863a654034 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621522Reviewed-by:
-
Mihai Sardarescu authored
This CL removes allowSwitchSyncAccount argument from creating a settings nav controller having sync as its root view controller as it is always set to YES. Bug: NONE Change-Id: I207a841cc2941a5ad5cf546e5914be5f3ce53f77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620635 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/10c8210fcdf5..98b3487874c0 Created with: gclient setdep -r src-internal@98b3487874c0 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=mbarowsky@google.com,sidereal@google.com Change-Id: I589782ed799acee77d9bc2ee3c3e903038f8e055 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621970Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#661704}
-
Mihai Sardarescu authored
This CL ensures that recent tabs opens the Sync and Google services when the user taps on enable sync from the recent tabs. This CL does not add any earl grey test - that will be added separately. Bug: 963434 Change-Id: I2531db4e3a23999487bde38c546587be076d0252 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620633Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#661703}
-
Peter Kasting authored
This reduces the number of functions and makes the naming and functionality more coherent. Bug: 870384 Change-Id: I67586068ddd32463ad72f0f923540ec6d7bdf737 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610486 Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#661702}
-
Nico Weber authored
- Use global DYNAMIC_ANNOTATIONS defines instead of having redundant WTF_USE defines that are also global and set at exactly the same time. Removes a global define in debug and in tsan builds. - Remove WTF_ANNOTATE_BENIGN_RACE_SIZED, WTF_ANNOTATE_HAPPENS_BEFORE, WTF_ANNOTATE_HAPPENS_AFTER which are all not used. - Add a comment pointing out that the remaining function works by virtue of having a magic name that's hardcoded in the tsan runtime. While here, also stop globally defining _HAS_ITERATOR_DEBUGGING on Windows when using libc++ (since _HAS_ITERATOR_DEBUGGING is a Microsoft standard library thing). No intended behavior change. Bug: 961767 Change-Id: I1adec49a2404b4e07dd5270ff64072ca7ebae7c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619831 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Jeffrey Cohen authored
Bug: 961913 Change-Id: I7e06ec2ad5280a811b45405596ebc85bec54842b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621345 Commit-Queue: sebsg <sebsg@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#661700}
-
Lutz Justen authored
Fixes CrSettingsPeoplePageKerberosAccountsTest.All on linux-chromeos-dbg. route.html is required for KERBEROS_ACCOUNTS used by the test. i18n_setup.html is needed for strings.js. Addendum to CL:1620628. TBR=stevenjb@chromium.org,dpapad@chromium.org,ljusten@chromium.org,sidereal@google.com BUG=chromium:952238 TEST=Test succeeds in debug Change-Id: Id68b8db7d811cde4d704f1cb39393c2c1346ab87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621130Reviewed-by:
Lutz Justen <ljusten@chromium.org> Commit-Queue: Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#661699}
-
Dominic Battre authored
Extend the expiration of these two histograms: PasswordManager.FirstWaitForUsernameReason PasswordManager.FirstRendererFillingResult Robustness is still a core goal of our team and we need to track it. Bug: 960029 Change-Id: I5fb905d4127ad556d7f875fa9922f3d9dc9da893 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621908 Auto-Submit: Dominic Battré <battre@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#661698}
-
Noel Gordon authored
Enable the piex wasm feature flag by default: to use use it to extract raw image preview images instead of peix nacl. Bug: 904630 Change-Id: I26fccc36f07fa04d044a9b1dc7beb872d1dc5df9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616836 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#661697}
-
sczs authored
Bug: 945478 Change-Id: I3e9811cc1ca39f99fe19eb75a75c89b0521b32e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621071 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#661696}
-
chrome://appsMarc Treib authored
Followup to https://crrev.com/c/1615027. Bug: none Change-Id: I36ecc95f484b792b79d959fdb4a8b855d44dd691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614183 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#661695}
-
Jordan Demeulenaere authored
This CL puts the Autofill Assistant content inside a scrollable container, such that there is always only a single ScrollView inside our BottomSheet. Doing this has the advantages of making the code simpler, and fixes the bug related to ScrollView children that were not clipped. Videos: * Before: http://go/aa-scroll-before * After: http://go/aa-scroll-after Onboarding: * Before: https://screenshot.googleplex.com/UCp5LVDhMee.png * After: https://screenshot.googleplex.com/x86jJ6Bw9RO.png Change-Id: I7e1652ac3f4b36cd4704f5b4a55174465b2c0edb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619815 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#661694}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I83f60188a4c2aada7b01e2a652e4d3e92e777de5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621975Reviewed-by:
-
