- 20 Mar, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/6893e71405a3..c75272708a80 git log 6893e71405a3..c75272708a80 --date=short --no-merges --format='%ad %ae %s' 2019-03-19 chrome-bot@chromium.org Update config settings by config-updater. 2019-03-19 nednguyen@google.com cros_extract_deps: improve docstring of cros_extract_deps.ExtractDeps 2019-03-19 gmx@chromium.org Enable the new tcmalloc on ten more boards Created with: gclient setdep -r src/third_party/chromite@c75272708a80 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: Ie04c12ce71d9204a9b2faa0b8dfec6bbcb72eb8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531348Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#642337}
-
CJ DiMeglio authored
Bug: 825444 Change-Id: Icfba401d61cdaac52bbe94d9fe89c6afdc6b857d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531694Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Cr-Commit-Position: refs/heads/master@{#642336}
-
Jinsuk Kim authored
The newly added flags, if turned on, always delegates overscroll swipes to websites. Bug: 865567 Change-Id: I1eb017c89f6519e64d34e097e9a115ea2f19d581 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527948 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#642335}
-
Erik Luo authored
This is a reland of df31273e Original change's description: > DevTools: optimize Styles sidebar for reading property values > > SSP UI changes > - Curly brace, Source link color less dark > - Source links are more aggressively truncated > - "Inherited from" separators have less noise > > Screenshot: https://imgur.com/a/SwpWkGs > > Bug: 929536 > Change-Id: I43b2252998f7d723b8ec88f0e908e751fe150c86 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1460448 > Commit-Queue: Erik Luo <luoe@chromium.org> > Reviewed-by: Joel Einbinder <einbinder@chromium.org> > Cr-Commit-Position: refs/heads/master@{#642093} TBR=einbinder@chromium.org Bug: 929536 Change-Id: I1a67b4243cbe0409337faf7a53c620123cb23a5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531692Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#642334}
-
Nigel Tao authored
Also add some App Service icon related TODOs. BUG=826982 Change-Id: Ic253de5a6f8a45f667db272833219aee72e51ac3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524397 Commit-Queue: Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#642333}
-
sczs authored
Bug: 911864 Change-Id: Ia14654e5a2afacbdca48a5c703818d1d5682d0bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531235 Commit-Queue: Sergio Collazos <sczs@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Auto-Submit: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#642332}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/b488d9c8d805..f79e15b85174 git log b488d9c8d805..f79e15b85174 --date=short --no-merges --format='%ad %ae %s' 2019-03-19 thestig@chromium.org Only define UTF16ToWChar() on relevant platforms. 2019-03-19 tsepez@chromium.org CFX_SeekableStreamProxy should not be an IFX_SeekableStream. 2019-03-19 thestig@chromium.org Roll base/trace_event/common/ 211b3ed9d..936ba8a96 (3 commits) 2019-03-19 thestig@chromium.org Roll tools/code_coverage/ 16298755a..0e34d1463 (8 commits) 2019-03-19 tsepez@chromium.org Add unit test for CXF_SeekableStreamProxy. 2019-03-19 thestig@chromium.org Roll build/ a721f3327..e51ca1d98 (227 commits) Created with: gclient setdep -r src/third_party/pdfium@f79e15b85174 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ibddaec829683ca6f5f58040addea8a23bbe51cab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530464Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/2dc0303903b1..f2564656e7af git log 2dc0303903b1..f2564656e7af --date=short --no-merges --format='%ad %ae %s' 2019-03-19 chrisforbes@google.com Wire up BuiltInWorkgroupId to compute pipeline 2019-03-19 chrisforbes@google.com Carry decorations down type tree in WalkExplicitLayoutAccessChain 2019-03-19 chrisforbes@google.com Add support for push constants Created with: gclient setdep -r src/third_party/swiftshader@f2564656e7af The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/126871859,chromium:b/128690261,chromium:b/128872954,chromium:b/128690261,chromium:b/128872954 TBR=swiftshader-team+autoroll@chromium.org Change-Id: Ic34c84f043c69374fd37adcf019df26294644d71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530465Reviewed-by:
-
liberato@chromium.org authored
In order to determine which features are most predictive for a learning task, this CL adds the beginnings of a random feature subset selection algorithm. The idea is that clients will select a random subset of features, and the learning results will reflect a model trained on just those features. Currently, since we're reporting results via UMA, we allow only a subset of size one for importance measuring. This makes it easier to report results on a single histogram. Change-Id: I33aa9659c13e07376a9ff801dda030f76567fa75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531107Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#642329}
-
Devlin Cronin authored
The ActivityLogPrivate API's test extension had handling for OS-specific tests and disabled tests, but neither of those are used in practice. Remove the unnecessary logic. Bug: None Change-Id: I55b34aacb40cab6a2049af57e91d98d0f363610e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529717Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#642328}
-
Philip Rogers authored
This check is wrong because we cannot skip setting the dirty bits. This check dates back to a time when the rects were synchronously calculated which would have required layout information: https://chromium.googlesource.com/chromium/src/+/3ab811935da94c0afc143978a4ca3721788c770f Change-Id: Icc46b97b6fed64972d028676f43022f60935ae94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528483Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#642327}
-
Kunihiko Sakamoto authored
It lacked expectation for virtual tests. TBR=wangxianzhu@chromium.org Bug: 619103 No-Try: true Change-Id: I33f00c3ba3e0644cbcf06b8e826146d2d39a32d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529897Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#642326}
-
Harley Li authored
An object's properties appears to be editable by double-clicking is misleading, because the modified values are not written back to the storage. Change-Id: Idd40bfd4bbbfa3d5528276ff04754e05bb460ab8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531602 Commit-Queue: Haihong Li (Harley) <hhli@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#642325}
-
Austin Tankiang authored
Currently when saving a file, the file picker defaults to only showing files with the same filetype as the one being saved. This can be confusing, so change the default to showing all files instead. Does not affect the file picker when opening or uploading files - that still defaults to being filtered to acceptable filetypes. Bug: 758674 Change-Id: I64a6413eb46740353af8aaf0fa0d9f2807e81f05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527944 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#642324}
-
Eugene But authored
These methods should be used instead of CRWSessionController's methods which is null when slim-nav is enabled. Bug: 899827 Change-Id: I6b345c72d736902d5755b47e6bdcd72ace9b7e9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529186 Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#642323}
-
Mark Pearson authored
This came up from a discussion at the metrics meetup last December. Frankly, I'm not sure this is the right place in the doc to put this section, nor am I positive this is the right phrasing. Or perhaps it's too long and I don't need the example. Change-Id: I12a42c713cda93a04616d6509475d8f34c4f26af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531649Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#642322}
-
Esmael El-Moslimany authored
Bug: 943480 Change-Id: I3988474e822ce29e5e16eb15b089a85f6345b171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529409Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#642321}
-
Tony de Luna authored
WebUI sign in screen is shown in both OOBE flow and multiple users account picker screen. The system shelf shows a different set of buttons in the sing in screen depending on the value of session state. We want to modify session state when coming from OOBE flow because buttons are not colored correctly. We should not modify session state when coming from multi-login flow, because we would showing an incorrect set of buttons. BUG=943510 Change-Id: Icfce815ddad2a0fb915d18a86882e39fa9f2b46a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531309 Commit-Queue: Tony De Luna <tonydeluna@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#642320}
-
Esmael El-Moslimany authored
Bug: 939158 Change-Id: I335869ed50d1adc10b27a4e4037d5fbbdfc2bd25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531423 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
-
Min Qin authored
This CL fixes 2 issues: 1. When resuming, download is not using the existing content URI for target path and intermediate path 2. after target determination, no need to set the display name again if it has already been set. Otherwise, it will infer the file name from the content URI, and use a number as file name BUG=943758 Change-Id: Id4cd912b8a8be5731911e6f7c8e1ad420f94a739 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531508Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#642318}
-
Sinan Sahin authored
Bug: 934605 Change-Id: I0c6f69a8c8e2c8d46b44776a1de7661dad2aa5b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526487Reviewed-by:
Becky Zhou <huayinz@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#642317}
-
Maks Orlovich authored
The gMock use got in the way of making something that ought to be a OnceCallback such since it has some limitations with respect to move-only types. Also, the tests weren't usefully distinguishing on whether the code was waiting for Load or LoadForKey to complete first; they do now. Plus, this group of test had its own ways of doing things totally different from everything else; now things standardize on the simpler MockPersistentCookieStore. Change-Id: I933386d311b6cce3fc230944e206b94cd1c0fff2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529074Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#642316}
-
Esmael El-Moslimany authored
Bug: 736891 Change-Id: Ica1ea0462499c7fd9582d3c6774041cec238b85d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506569 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#642315}
-
Charlie Reis authored
This reverts commit 9ab465d9. Reason for revert: We have enough data to diagnose the crashes. Original change's description: > Add diagnostics to catch commits of URLs in incompatible processes. > > These should be removed once we have some data indicating how it is > occurring in practice. > > BUG=931895 > > Change-Id: Ic8977b194892328a32d1db6f4492f9bb84938ba4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524835 > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Commit-Queue: Charlie Reis <creis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#641079} TBR=creis@chromium.org,nasko@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 931895 Change-Id: I1b52d81ed2ac2b89a8b6208650035f79d6714cfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530833Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#642314}
-
Robert Liao authored
This is a run of run-clang-tidy.py -checks="-*,modernize-use-override" -header-filter=ui/views/* \\src\\ui\\views\\ BUG=940732 TBR=sky@chromium.org Change-Id: I30fd8d209039d7f357ae38b240afd4b110e8f94d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530839Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#642313}
-
Jonathan Backer authored
This usage is consistent with what we do in {Raster,GLES2}DecoderImpl::Destroy. If you fail to do this, you may end up in an inconsistent state where a context passes IsCurrent, but no GL bindings are bound. - ~GLContextVirtual will call SetCurrent(nullptr) and SetCurrentGL(nullptr) in parent dtor ~GLContext - Another context (e.g. shared_context_ or virtual context) may have GLContext::IsCurrent return true that method only checks driver state (e.g. eglGetCurrentContext()). Bug: 942579 Change-Id: I9d7967b7618e68f5edd1b617083492f4f77f1cf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531011Reviewed-by:Antoine Labour <piman@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#642312}
-
Victor Fei authored
Implemented Compare of ITextRangeProvider with associated unittests. Bug: 928948 Change-Id: I396b518cb76786bb9fad7acf58594c3ee9e653e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527864 Commit-Queue: Victor Fei <vicfei@microsoft.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#642311}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2d29261e94ed..3580425baa28 git log 2d29261e94ed..3580425baa28 --date=short --no-merges --format='%ad %ae %s' 2019-03-19 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-03-19 dpranke@chromium.org Revert "Remove exception for relative CIPD" Created with: gclient setdep -r src/third_party/depot_tools@3580425baa28 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ifaa4c5afe3c77ca05ac69903179f24ff52358cab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531345Reviewed-by:
-
Luciano Pacheco authored
Add role=dialog to cr.ui.BaseDialog to keep Chromevox restricted to dialog's elements, instead of cycling through all focus-able elements in the DOM. Change cr.ui.BaseDialog to have aria-label so Chrovevox reads it as "$DIALOG Dialog ...". These combined fix the Files app issue when opening "Open With...", "More actions" and "Change default..." dialogs to be announced by when they're opened, instead of only announcing its contents. Bug: 889149 Change-Id: I7c53bb53b44279810a4ff255793aba1f1ad47f5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527912Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#642309}
-
Saman Sami authored
Rather than hard-coding the estimated draw time, calculate it from the BeginFrame interval. Change-Id: I5fc7494d5c08cf8ef84a55f1c672c173caf75bd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529621 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#642308}
-
Dmitry Gozman authored
We currently have a race between: - AppCacheBackendImpl::RegisterHost call coming over it's own mojo pipe and looking for precreated AppCacheHost; - Destroying NavigationRequest, which destroys NavigationHandleImpl, which destroys AppCacheHavigationHandle which posts a task to destroy precreated AppCacheHost on IO thread. To combat this, we take AppCacheHavigationHandle from committed NavigationRequest before destroying it and keep it around in RenderFrameHostImpl. This measure keeps in a common case when we commit navigation and reach for app cache host. However, we still cannot assert that we always have a precreated host because browser can decided to destroy the frame immediately (together with RenderFrameHostImpl and AppCacheHavigationHandle), while renderer asks for the AppCacheHost. The best thing we can do in this case is stall AppCacheHost registration until renderer's frame is inevitably destroyed by the browser's request. This is a speculative fix for crashes in issue 941903. Some existing tests, e.g. http/tests/misc/iframe-reparenting-id-collision.html, easily expose the race, but since they are not using AppCache, we don't hit the crash point from the bug. Bug: 941903 Change-Id: I3925d0b9ab9655235b524da561d0e8ba8345fb4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529381Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#642307}
-
Findit authored
Revert "DevTools: add Page.frameRequestedNavigation, deprecate Page.frameScheduledNavigation and frameClearedScheduledNavigation" This reverts commit a8016f0c. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 642246 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2E4MDE2ZjBjYmE0MmQzNWUwNDdkMDUwMDJjNDZjMDNiZTM4MGExNmEM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.win/Win7%20Tests%20%281%29/89416 Sample Failed Step: webkit_layout_tests Original change's description: > DevTools: add Page.frameRequestedNavigation, deprecate Page.frameScheduledNavigation and frameClearedScheduledNavigation > > - add FrameRequestedNavigation probe that gets dispatched whenever client-initiated navigation request is sent to browser and carries reason for navigation; > - expose the above as Page.frameRequestedNavigation > - deprecate Page.frameScheduledNavigation and Page.frameClearedScheduledNavigation; > > > Change-Id: Ia652b5381c22b68962a6f568e7cb18456dc0269a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524706 > Commit-Queue: Andrey Kosyakov <caseq@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#642246} Change-Id: Ibb40f45320d12e3196136265078316358150897c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531713 Cr-Commit-Position: refs/heads/master@{#642306}
-
Josh Nohle authored
Creates an implementation of CryptAuthEnrollmentManager to be used for CryptAuth v2 Enrollment. This implementation, CryptAuthV2EnrollmentManagerImpl, will replace the v1 implementation, CryptAuthEnrollmentManagerImpl. While the API for the abstract class is not ideally suited for CryptAuth v2, using it will allow for a smoother transition from v1 to v2. Bug: 899080 Change-Id: I3ba278cf7987810687fa199db61a258c36f70e69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1440201 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#642305}
-
Alex Danilo authored
Change https://chromium-review.googlesource.com/c/chromium/src/+/1217747/ introduced a side-effect that causes the entire input field to be selected on a focus event. In the gallery app this caused the Width input field to be fully selected when doing an image resize. This change explicitly sets the selection to the end of the field as it used to work before the regression. This CL is the second attempt as the original CL 1453696 was reverted in https://chromium-review.googlesource.com/c/chromium/src/+/1519947 due to https://bugs.chromium.org/p/chromium/issues/detail?id=931157. Bug: 914741 Tests: Ran all browser and unit tests, manually checked as well. Change-Id: I95bd7cc31ccbd0631201414142cfe9b4cf44073f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525253Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#642304}
-
sangseok.jang authored
Change the use of constexpr where it is needed. But, tests and example code need to be arranged. Bug: 940125 Change-Id: Ie072337a887a499fd003c0692784fe0a1fec7728 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517482Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Sangseok Jang <sangseok.jang@navercorp.com> Cr-Commit-Position: refs/heads/master@{#642303}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/78e6a4c1ff67..7b49eeb4960b git log 78e6a4c1ff67..7b49eeb4960b --date=short --no-merges --format='%ad %ae %s' 2019-03-19 fmalita@chromium.org [skottie] Turn on AA for solid layers 2019-03-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 0e712410582f..2dc0303903b1 (1 commits) 2019-03-19 ethannicholas@google.com Revert "more relaxed precision decorations for SPIR-V output" 2019-03-19 halcanary@google.com Docs: fix more case-sensitive names 2019-03-19 fmalita@chromium.org [skottie] Initial camera support 2019-03-19 michaelludwig@google.com Respect strict constraint in drawEdgeAAImageSet Created with: gclient setdep -r src/third_party/skia@7b49eeb4960b The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@chromium.org Change-Id: I3fbb870e4018108b6730c9ec5b6cff1ef0256987 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531343Reviewed-by:
-
Toni Barzic authored
The user image screen is not shown during (in session) OOBE anymore, so it's safe to assume screen manager will not have it (it's not being created any longer). BUG=942257 Change-Id: I551a800ec762cf35c749511fa949ffbec0219c4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529479Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#642301}
-
Adrienne Walker authored
This prevents resizing a vector to a fake and extremely large size. Bug: 942428 Change-Id: I020b9b3eb3516dfcfc65d4687ce4e3a5a0e3a9ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526305 Auto-Submit: enne <enne@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
-
Zhang Xiangze authored
In gpu driver bug item 172, the description is "Use GL_INTEL_framebuffer_CMAA on ChromeOS" while the workaround name is "disable_framebuffer_cmaa". It's confusing when it is shown in chrome://gpu page. "Use CMAA on ChromeOS" description is displayed on all platforms(Windows, Android, etc). Except on ChromeOS when CMAA is enabled, "Use CMAA on ChromeOS" is not shown in chrome://gpu page. This patch changes the workaround name to use_framebuffer_cmaa and makes "Use CMAA" only showing up in chrome://gpu when CMAA is enabled. Bug:943416 Change-Id: Iedfe4e353e1f16f91d7bae7ec1f7e432ead70a03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527868 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#642299}
-
Kelvin Jiang authored
This CL is a preparatory CL for iron-list and removes the expand/collapse animation from the stream item. To make the stream item a more lightweight component while still maintaining functionality, iron-collapse is replaced with a div with a hidden property and contents of #activity-item-main-row are now in the slot for cr-expand-button. Bug: 932768 Change-Id: Iad7bdcc0ce44d1f3b40600c2d953586da7e00d9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525621Reviewed-by:
-
