- 02 Aug, 2018 40 commits
-
-
Adam Langley authored
It broke because of the test that the response RP ID hash was actually the hash of the RP ID. (Which isn't true when using an AppID hash.) Obviously we were missing test coverage here, so add that now that it's easy to do with VirtualFidoDevice. (Confirmed that the test failed before the rest of these changes and passes now.) Change-Id: Ibd3b39339500e24f00c4f6c12ab4405ae0596107 Reviewed-on: https://chromium-review.googlesource.com/1159522Reviewed-by:
Jun Choi <hongjunchoi@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#580197}
-
Adam Rice authored
Make proxy.pac resolution for WebSockets work for Windows and Mac when the --winhttp-proxy-resolver flag is supplied. These platforms don't support passing WebSocket URLs to the proxy.pac file. Convert ws and wss URLs to http and https before passing them to proxy.pac. This matches the behaviour of the vendor browsers on these platforms. Add a WebSocket end-to-end test to verify that WebSockets can be accessed via a proxy specified in proxy.pac. Since preflighting proxy credentials makes the tests really complicated, add an extra mode to testserver.py for a vanilla proxy that doesn't require auth. BUG=862121 Change-Id: I63b318b7f6d3083a6c21f5811bb27966d17cb02a Reviewed-on: https://chromium-review.googlesource.com/1143093 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#580196}
-
Matt Menke authored
The only code outside of net/ / services/network that does direct proxy resolutions appears to be the two PPAPI consumers. This CL updates them both to use the new API. Bug: 810950 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I643605dfe2d8b67626ea8b84ee793b2c88b66e12 Reviewed-on: https://chromium-review.googlesource.com/1136875Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#580195}
-
chcunningham authored
Adds call to SigninManager::SignIn(...) as part of TestSuccessfulSignin helper method. This is needed to simulate real signin and becomes critical with upcoming changes* to FakeSigninManager. *https://chromium-review.googlesource.com/c/chromium/src/+/1154985 Bug: 806781 Change-Id: I973859ef52bcddd978429dbb4ce9d913224c7b0d Reviewed-on: https://chromium-review.googlesource.com/1160492 Commit-Queue: Chrome Cunningham (In Paris) <chcunningham@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#580194}
-
Eugene But authored
This integration tests now test TitleWasChanged, which is not navigation or load callback. Bug: None Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic78b2758ac2ba92dece1034dc92328ce7b30cd1d Reviewed-on: https://chromium-review.googlesource.com/1159332Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#580193}
-
Eric Robinson authored
This CL adds tests to the AdTracker to verify that resources loaded by an ad script are marked properly ad ads during loaded. This does not work properly for images currently due to crbug.com/848916. Bug: 848916, 863446 Change-Id: I6643ec24c16ec7dceb9c60fd150046b86cb008ac Reviewed-on: https://chromium-review.googlesource.com/1140196Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Eric Robinson <ericrobinson@chromium.org> Cr-Commit-Position: refs/heads/master@{#580192}
-
Christos Froussios authored
It is flaky on mac_chromium_rel_ng Bug: 870259 No-try: True No-presubmit: True Change-Id: I73ac22cce3d7d03ce2f36c90d79e8a829fe28100 Reviewed-on: https://chromium-review.googlesource.com/1160543Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#580191}
-
Thomas Tangl authored
When a unified consent service is disabled while unified consent is given, unified consent is revoked. This can happen when a synced preference is turned off on another machine or MetricsReporting is disabled on another profile. Bug: 867480 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I2dfe0127a86ccb718f4f6414f42c7c22eb8dc117 Reviewed-on: https://chromium-review.googlesource.com/1151324 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#580190}
-
Mikel Astiz authored
We do this for the control methods to the delegate to simplify tests, by migrating away from ProxyModelTypeControllerDelegate. Instead, ForwardingModelTypeControllerDelegate is introduced, currently used in tests only but with the goal to be adopted more broadly (see crbug.com/867801). A proxy processor is still in use, and that still requires some nested loops, but that's left out for future patches. Bug: 855010,867801 Change-Id: I1933355fee2093bf006830cde334c644f4391020 Reviewed-on: https://chromium-review.googlesource.com/1160642 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#580189}
-
tzik authored
After this CL, WTF::Bind refuses to bind STACK_ALLOCATED objects. And to do that, this adds a marker to STACK_ALLOCATED macro in allocator.h, and adds WTF::IsStackAllocatedType<> to type_traits.h that detects the marker. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ibee83e3f457619af0e117584dae3bc4a7a33a51c Reviewed-on: https://chromium-review.googlesource.com/1160424Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#580188}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/649929af2140..b07deb3fc1f5 git log 649929af2140..b07deb3fc1f5 --date=short --no-merges --format='%ad %ae %s' 2018-08-02 art-snake@yandex-team.ru Rework of CPDF_Parser::GetLastObjNum. Created with: gclient setdep -r src/third_party/pdfium@b07deb3fc1f5 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Idb9f2e95b3550c107a6c459192f8c8dd1d5d51f0 Reviewed-on: https://chromium-review.googlesource.com/1160601Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580187}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8319a20f..7b323896 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8f4724714cac89463e0dc536126b24030ceeb5b8 Reviewed-on: https://chromium-review.googlesource.com/1160343Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580186}
-
Kuo-Hsin Yang authored
Remove unused base class and json files. Bug: chromium:777664 Change-Id: I06323e435e2acb9b471a2e733f80dae92f4d94ce Reviewed-on: https://chromium-review.googlesource.com/1160129Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#580185}
-
lanwei authored
Since we start to switch to TSF from IMM32 in IME on Windows, we want to rename InputMethodWin class to InputMethodWinImm32 to distinguish these two input methods. Bug: 657623 Change-Id: I70fc2f6ee319fd050e06e5937c10dbf4996681f7 Reviewed-on: https://chromium-review.googlesource.com/1159351Reviewed-by:
Shu Chen <shuchen@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#580184}
-
Mythri Alle authored
Update the fetch interface of GeneratedCodeCache to send response time and data instead of just raw data. This will make it cleaner when using it and also make it consistent with the write interface. Bug: chromium:812168 Change-Id: Ic460bbbf15788caf04946a35b5cb3ba356cd212e Reviewed-on: https://chromium-review.googlesource.com/1154539Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#580183}
-
tzik authored
After this CL, base::BindOnce and base::BindRepeating rejecting pointers to ref-counted objects that have zero ref count. So that we can avoid a pattern of racy case like below in most cases: If a ref-counted class |Foo| posted a task that contains |this| as a receiver like this: Foo::Foo() { base::PostTask(FROM_HERE, base::BindOnce(&Foo::Bar, this)); } base::BindOnce retains a reference, and PostTask may release the reference before the construction of Foo completes, that happen when PostTask fails or the task runs soon. As the result, `new Foo()` may return stale pointer. Bug: 866456 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_mojo;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I2c7e8efcbd74fda49d183dbb782f94b0d7cf6af3 Reviewed-on: https://chromium-review.googlesource.com/1144813 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#580182}
-
Ned Nguyen authored
This reverts commit e63be647. Reason for revert: breaking generate_build_files on chromium.perf/Win Builder Perf Original change's description: > Add logging and chrome_utils directories > > Bug: 830892 > Change-Id: I8c121dff724dea526a7cc7ce198da51cc1b8d045 > Reviewed-on: https://chromium-review.googlesource.com/1158719 > Reviewed-by: Joe Mason <joenotcharles@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Christian Dullweber <dullweber@chromium.org> > Commit-Queue: Oliver Li <olivierli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580163} TBR=pkasting@chromium.org,joenotcharles@chromium.org,dullweber@chromium.org,olivierli@chromium.org Change-Id: I295b58fdf9300e681b985c93b6f68b0ec0702da0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 830892 Reviewed-on: https://chromium-review.googlesource.com/1160881Reviewed-by:
-
Nasko Oskov authored
TBR=alexmos@chromium.org Bug: 662160 Change-Id: Ice66d0146daf565cf0119a040175641e3b6af791 Reviewed-on: https://chromium-review.googlesource.com/1160586Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#580180}
-
Max Moroz authored
This reverts commit aaa73d4c. Reason for revert: Apparently glob.glob doesn't work with expressions line {value1,value2} :( Original change's description: > Do not bundle compiler-rt libraries (ASan,UBSan,Profile) for Android on i686. > > This change removes 6+ MB of binaries from the build tools bundle: > 3.7M lib/linux/libclang_rt.asan-i686-android.so > 2.5M lib/linux/libclang_rt.ubsan_standalone-i686-android.so > 80K lib/linux/libclang_rt.profile-i686-android.a > > It also can break some workflows, but as discussed in person, there is a good > chance that no one is using those libraries on i686 arch. > > > Bug: 866225 > Change-Id: Ifbc85e542359681f60f19f52e5bd7a8a7e1655f3 > Reviewed-on: https://chromium-review.googlesource.com/1158708 > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Max Moroz <mmoroz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#579854} TBR=thakis@chromium.org,hans@chromium.org,mmoroz@chromium.org Change-Id: Ic009c159a98be684a9dec8ea5aec364e83d7389d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 866225 Reviewed-on: https://chromium-review.googlesource.com/1160801Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#580179}
-
Aldo Culquicondor authored
A controller delegate is responsible for updating the controller, detect gestures and produce a model to be sent to the Ui. This CL introduces 2 delegates for VrShellGl, one for production and one for testing. This is the first step on a major refactoring on which VrShellGl disappears in favor of a cross platform RenderLoop, composed of platform specific delegates for each of its functions. A revert to https://crrev.com/c/1121670 was needed to get the chrome_public_test_vr_apk built properly. Bug: 767282, 848494 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ib68f975ce4e5e39fc7ebb5cf386b400f48039f4e Reviewed-on: https://chromium-review.googlesource.com/1151623Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Amirhossein Simjour <asimjour@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Cr-Commit-Position: refs/heads/master@{#580178}
-
Anita Woodruff authored
- Presubmit still enforces that this interface is used instead of Notification(Compat).Builders directly - the main benefit being that it's harder to forget to initialize a notification channel, since both implementations initialize the channel in their constructors. - We'd like to keep this presubmit and this class may yet be used for even greater purposes, hence removing the TODO since it's not going away any time soon. R=peter@chromium.org Change-Id: Id6f4d80b37763b3a44a4a2d94dd1f6c6958a99da Reviewed-on: https://chromium-review.googlesource.com/1160641Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#580177}
-
Dominick Ng authored
This addresses a bug where tapping the installable ambient mini-infobar on Chrome for Android may not correctly trigger the add to home screen dialog. The root cause is that the user gesture requirement for calling beforeinstallpromptevent.prompt() is checked in the browser, not the renderer, because some platforms are only just rolling out the requirement. As a result, calling prompt() without a user gesture invalidates all weak pointers when it terminates, including the weak pointer used by the mini-infobar to trigger the add to home screen dialog. This CL fixes the bug by checking the user gesture in the renderer, and not dispatching to the browser unless the gesture is present. This means that the banner pipeline will not invalidate weak pointers when a user gesture is not present. BUG=869780 TBR=mkwst@chromium.org Change-Id: Iee7dfc76401e7141707b2d7b2e6ac5e24297ac4b Reviewed-on: https://chromium-review.googlesource.com/1158305Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#580176}
-
Anita Woodruff authored
R=peter@chromium.org Bug: 841419 Change-Id: I91e8b4a0d90ed5ef3a1d97068a890e8363d458cd Reviewed-on: https://chromium-review.googlesource.com/1160309Reviewed-by:
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/64cc576b1fa7..174d7f61ba90 git log 64cc576b1fa7..174d7f61ba90 --date=short --no-merges --format='%ad %ae %s' 2018-08-02 benjaminwagner@google.com [infra] Ensure Build-Mac backfill tasks can find Xcode. Created with: gclient setdep -r src/third_party/skia@174d7f61ba90 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: I199773e29c3248846f1c0f3a55e697fb1a6bc6c1 Reviewed-on: https://chromium-review.googlesource.com/1160401Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580174}
-
Oleh Prypin authored
(based on previous work by magjed@) Bug: 867475 Change-Id: I1c292e163b251bbddf3d114dbcaed2e22239d625 Reviewed-on: https://chromium-review.googlesource.com/1150179Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Oleh Prypin <oprypin@chromium.org> Cr-Commit-Position: refs/heads/master@{#580173}
-
Sam Maier authored
Currently, AsyncTask.execute() defaults to the SERIAL_EXECUTOR. This exector is good for preventing concurrency errors since it guarantees serial execution, but bad for performance since the entire app shares this single queue. It looks like this callsite can use the THREAD_POOL_EXECUTOR instead, since this use doesn't appear to rely on the concurrency guarantees that SERIAL_EXECUTOR provides. Bug: 869907 Change-Id: I5280674dd8afefbbfbcadbf0b41acf2aaba0b8a1 Reviewed-on: https://chromium-review.googlesource.com/1159207Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#580172}
-
Ramin Halavati authored
Preferences related to Spell Check are removed from the persistent storage list for incognito mode. After this CL, if these preferences are changed from incognito mode, they are only stored in memory and won't affect user profile. Bug: 861722 Change-Id: I09b64981a24f918cd62d82e487b265b4a0179a7b Reviewed-on: https://chromium-review.googlesource.com/1159368 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#580171}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c988ddf7b193..9ac709a1b2a5 git log c988ddf7b193..9ac709a1b2a5 --date=short --no-merges --format='%ad %ae %s' 2018-08-02 anthonyalridge@google.com Add tests for graph data. Created with: gclient setdep -r src/third_party/catapult@9ac709a1b2a5 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:866423 TBR=sullivan@chromium.org Change-Id: I7a14362aa1157eeb6f815a42eaacc4ca78ced02d Reviewed-on: https://chromium-review.googlesource.com/1160561Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580170}
-
Sam Maier authored
Currently, AsyncTask.execute() defaults to the SERIAL_EXECUTOR. This exector is good for preventing concurrency errors since it guarantees serial execution, but bad for performance since the entire app shares this single queue. It looks like this callsite can use the THREAD_POOL_EXECUTOR instead, since this use doesn't appear to rely on the concurrency guarantees that SERIAL_EXECUTOR provides. Bug: 869907 Change-Id: I09f794fe73c706019ce42f16b505d9a1ee1757ea Reviewed-on: https://chromium-review.googlesource.com/1159268Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#580169}
-
Morten Stenshorne authored
When calculating the overflow rectangle while laying out an anonymous block that's the containing block of the first part of an inline that forms a continuation chain, we'll jump into the neighbor anonymous block that's part of the continuation chain, to get its outline rectangles. This is a meaningless thing to do if the blocks haven't been laid out yet. In fact, I don't think the outlines in the neighbor continuations should be included at all in former anonymous blocks' overflow, but all this CL does is to bail if layout isn't up to date. Multicol generally DCHECKs that we have laid out when someone tries to read out stuff that depends on layout. Also cleaned up LayoutInline::AddOutlineRectsForContinuations(), to avoid duplicate code. I suspected that the coding style checker would complain about the missing curly braces anyway. Bug: 863453 Change-Id: Ifeb14454c54396135927e33ec7a08e6091c20503 Reviewed-on: https://chromium-review.googlesource.com/1156403 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#580168}
-
Sam Maier authored
Currently, AsyncTask.execute() defaults to the SERIAL_EXECUTOR. This exector is good for preventing concurrency errors since it guarantees serial execution, but bad for performance since the entire app shares this single queue. It looks like this callsite can use the THREAD_POOL_EXECUTOR instead, since this use doesn't appear to rely on the concurrency guarantees that SERIAL_EXECUTOR provides. Bug: 869907 Change-Id: Ia90e016f9948ad87d577ddb8ac24dd27450f36e4 Reviewed-on: https://chromium-review.googlesource.com/1158988Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#580167}
-
Marc Treib authored
This test wants to exercise RequestStop() before the backend (i.e. SyncEngine) is initialized. It did so by calling RequestStop() on the ProfileSyncService before Initialize(), which is not legal - Initialize() must be called immediately after construction, and in particular, before any other methods on the service are called. This CL fixes it by calling Initialize() first, but setting up a FakeSyncEngine that won't immediately get initialized. Bug: 856179 Change-Id: I03a80a30e1bed67a0e829b4936811173f3ef8390 Reviewed-on: https://chromium-review.googlesource.com/1160494Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#580166}
-
Christos Froussios authored
It is flaky TBR=dewittj@chromium.org Bug: 870295 Change-Id: I319bd6b5038cb384dea15fb23c8d0173aa3cf0ff Reviewed-on: https://chromium-review.googlesource.com/1160621Reviewed-by:
-
Martin Robinson authored
The newly shareable attribute code can be used for ATK on Aura Linux because the attributes exposed should be exactly the same on this platform. This change also adds some basic unit tests to ensure that attributes are exposed properly through ATK. Bug: 866612 Change-Id: Id46ab2108d9ead6ab88b5e172b6b25e615f47cca Reviewed-on: https://chromium-review.googlesource.com/1156399 Commit-Queue: Martin Robinson <mrobinson@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#580164}
-
Olivier Li authored
Bug: 830892 Change-Id: I8c121dff724dea526a7cc7ce198da51cc1b8d045 Reviewed-on: https://chromium-review.googlesource.com/1158719Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#580163}
-
Marc Treib authored
Trying to set a decryption passphrase while it's not required triggers a DCHECK in ProfileSyncService. For that reason, onPassphraseEntered already checks that the engine is (still) initialized. This CL adds an explicit check that a passphrase is required, since it's possible that the engine has actually shut down *and restarted* in the meantime. This problem was exposed by https://crrev.com/c/1148392, but I believe it's always been there, just extremely unlikely to occur. It's basically https://crbug.com/507557 which was never fully fixed. Bug: 856179 Change-Id: I6f7cfc9643c0c93fadbd6ecbc0e39364791e3451 Reviewed-on: https://chromium-review.googlesource.com/1158366Reviewed-by:
-
Morten Stenshorne authored
No need to have separate NG lines for tests that behave exactly as in legacy. TBR=eae@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I89c6a65287aba250c8287e26c7983040e145b960 Reviewed-on: https://chromium-review.googlesource.com/1158415Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#580161}
-
Mohamed Amir Yosef authored
This CL extracts some utility methods for converting a bookmark node to a bookmark specifics and vice verse into a new file bookmark_specifics_conversions This is in preparation for a later CL that will requies access to the same functionality. Bug: 516866 Change-Id: Iaa9f11320d9db8b8c0479aaf0137cfdbf5e2cef0 Reviewed-on: https://chromium-review.googlesource.com/1160227 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
-
Peter K. Lee authored
Bug: 870151 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I8e1fc458e9316be19e35b5e0f3edaefb5d3244f3 Reviewed-on: https://chromium-review.googlesource.com/1132564Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#580159}
-
Sylvain Defresne authored
IdentityManager is the recommended API to access the Google account used by the user and SigninManager is deprecated. Convert ClearBrowsingDataHandler to the new API. Bug: 798411 Change-Id: I3dc831307cac65dd42369d7482b9a0b794f02048 Reviewed-on: https://chromium-review.googlesource.com/1126384 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#580158}
-
