- 17 May, 2019 40 commits
-
-
Ben Mason authored
Bug: 964451 Change-Id: I27f4a28ade2cee226c5a65b366d9aaeda503d0ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618013Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#661003}
-
Mehran Mahmoudi authored
This addresses some comments from UX review on settings for touchless devices. More information on the bug. Bug: 962562,963515,961904 Change-Id: I6146f1dbddbb580748074ad201c82f267e5306ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613709 Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#661002}
-
Tobias Sargeant authored
Fixes: 963456 Bug: 939312,963456 Change-Id: Ia3d040d396cfaffe1d8ca68fd51cda42beed7e01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613985 Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Anna Malova <amalova@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#661001}
-
rbpotter authored
This CL changes PrintPreviewHandler to obtain the sign in state from the identity service, and send this with initial settings. This will eventually allow Print Preview to set the initial cloudPrintState without querying the cloud print server. Bug: 961359 Change-Id: I4382801b7e9a474e3664966d1794e4f4d6b0a7a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616329 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#661000}
-
Sky Malice authored
Bug: 956737 Change-Id: I0283330437fb75a973b92281c4237ba14b3a44ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614077Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#660999}
-
Xianzhu Wang authored
This uses the same mechanism used in https://chromium-review.googlesource.com/c/chromium/src/+/1612358 for LayoutInline. The new code favors LayoutNG for performance, to avoid back-and-forth flipping in some cases for LayoutNG and allow that for Legacy. Also fix an issue of unnecessary flipping for SVG text. Change-Id: I70dc61807d2284a3cdda1fd4733b7ab2bfdd00e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615680 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#660998}
-
Yutaka Hirano authored
It is used only once, so let's inline it. This change also removes std::function use which is currently banned. Bug: 963306 Change-Id: I532ceb3707196c0c21a3aed8ae8c154467cd5fca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614648 Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Luna Lu <loonybear@chromium.org> Reviewed-by:
Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#660997}
-
Xiyuan Xia authored
Get rid of the following code path: AppListMenuModelAdapter::Delegate -> AppListControllerImpl (AppListViewDelegate) -> AppListClient -> ChromeAppListModelUpdater/ChromeSearchResult -> AppContextMenu (SimpleMenuModel::Delegate) It is no longer needed because SimpleMenuModel is passed directly to app list code and has AppContextMenu as its delegate to handle the menu. Bug: 958134 Change-Id: Ieee6ee26869ec6b14dc7ebced45c84064d60ac3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617907Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#660996}
-
Mirko Bonadei authored
ABSL is trying to be -Wundef clean and sending a patch for these macros seems overkill. They are used inside a __APPLE__ block with this pattern: #if defined(TARGET_OS_IPHONE) && TARGET_OS_IPHONE #endif Bug: None Change-Id: I863d099dcc3a2588388afab24a61be89884b392b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612913Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#660995}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bbaaf61f1d99..85e6c29b6f88 Created with: gclient setdep -r src-internal@85e6c29b6f88 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:891734 TBR=beverloo@google.com,collinbaker@google.com,bcwhite@google.com,tasak@google.com Change-Id: I607f49869d9f97495f4d330705a8ec0f54999d03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618061Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#660994}
-
Andrew Grieve authored
This allows it to be brotli-compressed, saving 560kb for both SystemWebview.apk and TrichromeWebview.apk. The Monochrome Webview Stub APK continues to use licenses as an asset. Moves WebViewApplication from glue/ -> apk/ and renames it to "WebViewApkApplication" in order to not conflict with not-yet-updated downstream glue/ code. Bug: 734846 Change-Id: Icb0655057eae4ef80117f59cb060c1f596abf646 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612660Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#660993}
-
Denis Kuznetsov authored
BUG=b:129924393 Change-Id: I0f7cf9a05d2bd4e5e8cb01e467ccecb3d28d7e9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614182 Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#660992}
-
Chandani Shrestha authored
This change provides fixes for these issues: Problem: The content title was heading role Fix: Added heading role of level 1 Problem: Aria-label was missing in drop-downs Fix: Added aria-label in drop-downs Tested keyboard navigation - navigate up/down drop-down items using arrow keys - Checkbox is checked/unchecked using space bar - Tab into/out (no tab traps) Tested screen reader - reads checkbox label - reads items selected from the drop down list Bug: 963183 Change-Id: Iaab2dd37323427215f765b3d7bbef885861c210f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605506 Commit-Queue: Chandani Shrestha <chshrest@microsoft.com> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#660991}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d7e41546c030..1ca7ce3f76a5 git log d7e41546c030..1ca7ce3f76a5 --date=short --no-merges --format='%ad %ae %s' 2019-05-17 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-05-17 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@1ca7ce3f76a5 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I641f6ef5b83c2c02f9a202af63ffa43326f66e6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616958Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#660990}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b45ee83cc7c0..f3fa60010e45 git log b45ee83cc7c0..f3fa60010e45 --date=short --no-merges --format='%ad %ae %s' 2019-05-17 brianosman@google.com Implement postfix ++/--, and use the correct 1 for floats Created with: gclient setdep -r src/third_party/skia@f3fa60010e45 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Change-Id: Ic69b16d58ede72b1e013cffc4ff7aa9679e5a8b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617396Reviewed-by:
-
John Delaney authored
Add a UKM event with metadata for each ad frame observed on a page load. Records overall performance statistics (bytes/cpu), as well as metadata such as whether the ad is cross origin, it's size, etc. This will greatly simplify the number of metrics we are recording as we will not need to split out all UMA by visible/non-visible/etc. These metrics will prevent the need for new UMA to address the impact of ad interventions. As a lot of this UKM duplicates existing UMA, so we will reuse the existing tests. Once these metrics are landed, duplicate UMA metrics can be removed on a case by case basis depending on usefulness/simplicity. Bug: 951480 Change-Id: I19c2a63f496fd84250e0318491da1753ca9d2771 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562619Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#660988}
-
Jacques Newman authored
This re-lands this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1535171 Which was reverted here: https://chromium-review.googlesource.com/c/chromium/src/+/1610026 Original Change's description: > Refactor to handle ignored nodes that pass into the browser AX tree > > * Introduces the concept of "in the tree" vs "ignored" in Blink without > changing the actual behavior. No ignored nodes are sent to the browser > accessibility tree. > * Adds new function IsIgnoredPassThrough, for use when an object is > ignored, but should be passed through to the browser-side anyways. > This will be used to allow different types of ignored nodes to pass > through, instead of all at once. > * Refactors browser-side code to walk only the unignored tree. > > Bug: 651614 > > Change-Id: Idbd85949a8505f8a03a08e3e002bb893619d6757 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535171 > Commit-Queue: Jacques Newman <janewman@microsoft.com> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Alice Boxhall <aboxhall@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#659089} Change additional to original change: The original change caused a crash because GetUnignoredChildCount was called on a parent with dangling pointers in its children vector. This was previously acceptable as child_count only relied on the length of the vector, not its contents. This issue has been mitigated by caching the unignored child count, similar to how the unignored index in parent is cached. Bug: 651614 Change-Id: I90b09237862d17848113fb084b9b08b60e12999f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609590Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Commit-Queue: Jacques Newman <janewman@microsoft.com> Cr-Commit-Position: refs/heads/master@{#660987}
-
Brian White authored
This reverts commit 81046e57. Reason for revert: Mac ASAN tests are failing: https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Tests%20%281%29?limit=200 This seems the most likely culprit between the last good and when the (very frequent) failures began. https://chromium.googlesource.com/chromium/src.git/+log/17f09d5d92fc142fae6863b6c0d8bae17355ab95..8dde0a59b1362fc7a19186ca686cd5c6960003f5 [33545:775:0516/215851.235197:ERROR:vt_video_encode_accelerator_mac.cc(517)] VTCompressionSessionCreate failed: -12908 [90mtracing_service_impl.cc:[0m [39mConfigured tracing, #sources:2, duration:0 ms, #buffers:1, total buffer size:12 KB, total sessions:1[0m [90mshared_memory_arbiter_im[0m [31mShared memory buffer overrun! Stalling[0m ... Original change's description: > Migrate blink::MediaStreamVideoSource to WTF::Bind > > This CL is the 3rd out of n CLs to convert modules/mediastream/ > away from base::Bind{Once,Repeating} to their respective Blink/WTF > counterparts. > > In this particular CL, a weak reference of MediaStreamVideoSource is > passed to VideoTrackAdapter ctor to avoid double-bind methods with > CrossThreadBind -> ConvertToBaseCallback -> CrossThreadBind. > > R=dgozman@chromium.org, guidou@chromium.org > CC=blink-reviews-vendor@chromium.org > > BUG=923394 > > Change-Id: Ibd75c5fef80bef1a4328c4abb007fb07efbcc095 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594114 > Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#660725} TBR=haraken@chromium.org,hiroshige@chromium.org,guidou@chromium.org,tonikitoo@igalia.com,tzik@chromium.org Change-Id: I082573534da71adbb7b56a70d3b34ccd15272ba2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 923394 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616857Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#660986}
-
Robert Sesek authored
Bug: 958976 Change-Id: I7fc2bcdb8f2fadeab82a88a8c9b5a66c5b1aca25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618041Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
-
Gayane Petrosyan authored
This reverts commit 1843462f. Reason for revert: Color calculation is too long and freezes the browser for 1-2sec. Original change's description: > [NTP] Calc and store custom background color V2. > > When user selects new custom background, use thumbnail from image > collections to fetche and calculate calculate the most frequent color on > the image. The calculated color is then stored in prefs with the rest of > the background info. > > Bug: 874325 > Change-Id: I5905b583f22174a491749543e922512e6b47caf0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612235 > Commit-Queue: Gayane Petrosyan <gayane@chromium.org> > Reviewed-by: Nicolas Ouellet-Payeur <nicolaso@chromium.org> > Reviewed-by: Gayane Petrosyan <gayane@chromium.org> > Reviewed-by: Kyle Milka <kmilka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#660899} TBR=gayane@chromium.org,kmilka@chromium.org,nicolaso@chromium.org Change-Id: Id7ce0fd7255fcacd7322777e32d914defd8003d8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 874325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616855Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#660984}
-
Mehran Mahmoudi authored
This shows the progressbar that includes the current URL when the activity is resumed. Bug: 961404 Change-Id: I61bbc4ac02006c39b3e32d8615489bcc785719ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617646Reviewed-by:
-
James MacLean authored
This reverts commit fb42e13e. Reason for revert: MSAN test failing. Original change's description: > Refactor to remove RenderWidget::PageScaleFactorChanged(). > > This refactor moves the logic in RenderWidget::PageScaleFactorChanged() > to RenderWidget::SetPageScaleStateAndLimits(). This removes the need for > RenderViewImpl::PageScaleFactorChanged() to call GetWidget(). > > This is a re-land of > https://chromium-review.googlesource.com/c/chromium/src/+/1614080. > > TBR=dcheng@chromium.org > TBR=collinbaker@chromium.org > > Bug: 924336 > Change-Id: Id076ddc805c62069984181914f3722d4d081a3b3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617064 > Reviewed-by: James MacLean <wjmaclean@chromium.org> > Commit-Queue: James MacLean <wjmaclean@chromium.org> > Cr-Commit-Position: refs/heads/master@{#660834} TBR=dcheng@chromium.org,wjmaclean@chromium.org,collinbaker@chromium.org Change-Id: Ied08b30c3363b2cee0d3e01994b06e50835bb27d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 924336 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616739Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#660982}
-
Yutaka Hirano authored
No one inherits it, so replace protected with private. Also make it a final class. Bug: None Change-Id: Icc7d927c711514f9a64d29290826ae3f824f33bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616876 Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Luna Lu <loonybear@chromium.org> Reviewed-by:
-
Lan Wei authored
This reverts commit 9a00ff2b. Reason for revert: <INSERT REASONING HERE> Merge to M75 beta is failed, so I need to reland it in master and then try to merge it again to M75. Original change's description: > Use IMM32 instead of TSF on Win7. > > On Windows 7, there are many IMM32-based IMEs are relying on IMM32 > support. We should continue supporting those legacy IMEs on Win7. We > should disable TSF on Win7 and use IMM32. All other Windows platforms > are not affected. > > Bug: 963558 > Change-Id: I8f77afbdb734c355f4393880e80fafd98e25ae88 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613974 > Reviewed-by: Yohei Yukawa <yukawa@chromium.org> > Commit-Queue: Siye Liu <siliu@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#660261} TBR=yukawa@chromium.org,siliu@microsoft.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 963558 Change-Id: I4341bed006e86e756a21997c167c9526c6ce2901 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618010Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#660980}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/c5202e607426..b6220d071585 git log c5202e607426..b6220d071585 --date=short --no-merges --format='%ad %ae %s' 2019-05-17 thestig@chromium.org Avoid an integer overflow in CJBig2_SDDProc::DecodeHuffman(). Created with: gclient setdep -r src/third_party/pdfium@b6220d071585 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:963885 TBR=pdfium-deps-rolls@chromium.org Change-Id: I84780ac8a160f39fb1465fcc4aaf9ce12a59fccb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616960Reviewed-by:
-
Pavel Yatsuk authored
In this change: - Remove getActivity() from TouchlessContextMenuManager.Delegate and adjust consumers. Implementation of handleMenuItemClick should supply context - Remove TouchlessExploreSitesSiteViewBinder and optimize code around it. BUG=959317 R=dewittj@chromium.org,dominickn@chromium.org Change-Id: Ie30ee4a5448fb67fc7d01b4ae2f9322fbfc556ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615832Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#660978}
-
Stephen Martinis authored
Bug: 888810 Change-Id: I5a751c764fe5b43c9604b52abf7d4b6e73a19d98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618021 Auto-Submit: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#660977}
-
Erik Jensen authored
Instead of attempting to maintain a persistent identifer for our mobile clients, create a unquie UUID to be used for the session. Change-Id: I284c76480ce19c19e39bfb4acc4af02be160fe1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613961 Commit-Queue: Erik Jensen <rkjnsn@chromium.org> Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#660976}
-
David Tseng authored
This change: - reports network changes - does not report signal changes on the same network name - splits the connection status string into name (e.g. connected to foobar) description (e.g. weak signal) which are more semantically meaningful for ChromeVox - omits hints for ChromeVox alerts Bug: 955815 Change-Id: I0972026772a2f523af51a9c77016d6ec47818ab9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614123 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#660975}
-
Adam Langley authored
With r660884, the “rotate” animation now sets the visibility of the layer and so we no longer need to override it and use the “fade” animation instead to avoid DCHECKs. This effectively reverts r659735. Change-Id: I6fbbc47a606b0bb9cbf8017e14b9f3719c16f887 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617207 Commit-Queue: Adam Langley <agl@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#660974}
-
John Lee authored
Bug: 964448 Change-Id: Ia44cae0803d49bf16c5df3bb945f0c8ea2841c49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617095 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#660973}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/09eabed99d0e..52bfbd35fc96 git log 09eabed99d0e..52bfbd35fc96 --date=short --no-merges --format='%ad %ae %s' 2019-05-17 ynovikov@chromium.org docs: Update Android Test Instructions reference 2019-05-17 syoussefi@chromium.org Vulkan: Tighten descriptor stage usage hints Created with: gclient setdep -r src/third_party/angle@52bfbd35fc96 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@google.com Change-Id: I31ebfd54dcebd3343f075130350bad9548ca1d1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618007Reviewed-by:
-
Lloyd Pique authored
When processing systrace events, a decimal timestamp in seconds like "123.456000" was being parsed as a pair of int32_t's separated by the dot, and then converted into an microsecond integer value by scaling the integer seconds value appropriately, and adding the fractional part. However if the number of seconds was large enough, the multiplication would overflow an int32_t, resulting in an incorrect timestamp being computed, which then caused those events to be filtered out as they were not in the expected range. The fix was to simply implicitly convert to an int64_t to hold the result of the multiplication. This was enough to fix the bug. However the parsing makes a potentially unsafe and unchecked assumption that the number of digits after the decimal point is always the expected amount. If it was ever different, the computed timestamps would be incorrect. I also went and corrected most of the code to use a uniform type for the timestamp of uint64_t, as parts of the code used int64_t, and other parts used double. Doubles are still used however for JSON serialization and deserialization. To verify the timestamp parsing, I added some specific tests to the unit test. TEST=Unit tests pass, arc-graphics-tracing works BUG=b:132907802 Change-Id: I8608fae90eb4708f5c6abd7088ca4b859aeab91f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616325Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Lloyd Pique <lpique@chromium.org> Cr-Commit-Position: refs/heads/master@{#660971}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/cd707e6f223e..62ad1eeb0e6b git log cd707e6f223e..62ad1eeb0e6b --date=short --no-merges --format='%ad %ae %s' 2019-05-17 sugoi@google.com Allow ImageView to cast compressed texture into other formats 2019-05-17 bclayton@google.com LLVMReactorDebugInfo: Fix warning that function may end without return. 2019-05-17 bclayton@google.com CMakeLists: Allow the sanitizers to be enabled for GCC Created with: gclient setdep -r src/third_party/swiftshader@62ad1eeb0e6b The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Change-Id: Iebf8e696de5ebcf20b2fb0d4573c5f7f0938a92d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618006Reviewed-by:
-
sczs authored
Creates a Histogram and enum for an InfobarBadgeTapped either active or inactive. Adds IsInfobarBadgeActive flag to InfobarBadgeTabHelper, this is needed to update the active state whenever switching webstates.* *Unit test update coming up in a followup CL since I want to keep this one simple, and testing that requires some changes to the unittest setup. Bug: 892376, 963482 Change-Id: I5d2f62bdac3d930929674b315ac6e7d54ba9b385 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612362 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#660969}
-
Koji Ishii authored
This patch implements a specialized painter for `::first-line` background for LayoutNG. LayoutNG tried to avoid this special code by inserting anonymous inline box. Because the spec[1] states "behaves similar to that of an inline-level element" and that it can utilize existing paint code for regular inline boxes. However, special code to build and manage LayoutObject tree is getting bigger and bigger. It's started to be more complex than writing a special code in paint. This approach is more similar to what legacy does. [1] https://drafts.csswg.org/css-pseudo-4/#first-line-styling Bug: 963575 Change-Id: I69120ccf44fe9055d68181b83dc1bc4b91c542d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611700Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#660968}
-
Justin Cohen authored
Bug: 964323 Change-Id: Ibf17edb4b9f736887c8c6ebfd81d8e59e838124c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618042 Commit-Queue: Justin Cohen <justincohen@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#660967}
-
Jesse Selover authored
This CL is part of a larger project to remove the LOAD_DO_NOT_* privacy load flags and replace them with the allow_credentials setting. See https://crbug.com/799935, https://docs.google.com/document/d/1ntn9N7Ce2jozvvpWI0XbzJ7lJdwUjJXK07wp7rxrIN4, and go/allow-credentials-tracker for the motivation and progress of this change. This is the only place where a request is configured with LOAD_DO_NOT_SEND_COOKIES without either of the other two load flags. The request currently saves cookies, but doesn't send them. I've conservatively put allow_credentials = true on this request, which will cause the saved cookies to be sent. If your service doesn't require cookies then it should be allow_credentials = false. Bug: 799935 Change-Id: Ibd435acc810359482ec97d633637e42dc53923a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600546 Commit-Queue: Jesse Selover <jselover@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: Jesse Selover <jselover@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#660966}
-
Mason Freed authored
This feature has received 3LGTM's on the I2S: see [1]. SHERIFFS: If this commit causes layout (or other) tests to fail, especially anything related to filters or backdrop-filter, feel free to revert it. There are some known bugs (see [2]) but none should have much impact. Perhaps the most impactful is [3], which is that when running with GPU rendering disabled (--disable-gpu), backdrop-filter is not fully implemented. That is in progress now, but I would like to begin gathering other latent bugs. [1] https://groups.google.com/a/chromium.org/forum/m/#!topic/blink-dev/GRl1_Qy97jM [2] https://bugs.chromium.org/p/chromium/issues/list?can=2&q=label%3ATopic-Backdrop-Filter [3] https://crbug.com/916318 Bug: 497522 Change-Id: Ib2241d45e59b7b68e9e3073fd4e32028d93a2d64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614683 Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Ojan Vafai <ojan@chromium.org> Commit-Queue: Ojan Vafai <ojan@chromium.org> Cr-Commit-Position: refs/heads/master@{#660965}
-
David Bokan authored
This reverts commit 07da8ba6. Reason for revert: Causing issues in 962784 and 951901 Original change's description: > Reland "Recreate DirectManipulationHelper when every LRWHH UpdateParent" > > This is a reland of 61450bbc > > Original change's description: > > Recreate DirectManipulationHelper when every LRWHH UpdateParent > > > > Compositor and window event target is associated with window's parent. We call > > LRWHH UpdateParent when window's parent update, includes window's parent > > actually update and window initialize. Recreate DirectManipulationHelper on > > every window's parent update helps keep DirectManipulationHelper lifecycle > > tracking simpler. We also make CompositorAnimationObserver owned by > > DirectManipulationHelper. > > > > With this changes, we start the DirectManipulation event polling when > > DirectManipulationHelper created and stop when it destroyed. The issue should be > > fix since event polling start no more depends on DM_POINTERHITTEST. > > > > > > This also includes 2 refactoring changes: > > > > 1. Move CompositorAnimationObserver into DirectManipulationHelper. > > 2. Call ZoomToRect to reset viewport of DirectManipulation when viewport is > > actually transformed in RUNNING - READAY sequence. > > > > Bug: 914914 > > Change-Id: I0a63f9a407e0231d631e64f2b22a9975471f2fd9 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547049 > > Reviewed-by: Scott Violet <sky@chromium.org> > > Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#649342} > > TBR=sky@chromium.org > > Bug: 914914 > Change-Id: Ic0c8aa84d21fe7a88fd9d3552dbd5ffdb6adcc4f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562582 > Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> > Reviewed-by: Jianpeng Chao <chaopeng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#649682} TBR=sky@chromium.org,chaopeng@chromium.org Bug: 914914,951293,951901,956579 Change-Id: I4252717e2f708643b1d6b3f8305c32142a1a2735 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618008Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#660964}
-
