GitLab

This is part of a migration that replaces the old
<histogram-suffixes> syntax that was used to denote groups
of histogram to the new patterned histogram syntax.

Bug: 758782
Change-Id: Ie2ee45f2b0493b3a4784c348d1561db3460d7b59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511851Reviewed-by: Weilun Shi <sweilun@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Karthika Pai <karthikapai@google.com>
Cr-Commit-Position: refs/heads/master@{#823333}

Verify that the user agent returns click/auxclick/contextmenu as pointerevents.

Bug: 989958
Change-Id: I02757ef704b605471614829177cba24a73b6c8db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513801
Commit-Queue: Liviu Tinta <liviutinta@chromium.org>
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823332}

R=oshima@chromium.org

Bug: 1099418
Change-Id: Ib3753a2dbc80995b69e4da6b0ef1221934f99310
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511717
Auto-Submit: Nick Yamane <nickdiego@igalia.com>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823331}

Implement conversion from PNG to JPG image format when requested by user
on scanning UI. Add unit tests to verify functionality.

Bug: b:161237869
Change-Id: I8d21a0d7ddff0ddb3635b45b133f3869ec3e61cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507574
Commit-Queue: Kyra Moed <kmoed@google.com>
Reviewed-by: Jesse Schettler <jschettler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823330}

BUG=1140235

Change-Id: Id1bd1ac23529ebb871fa7eeeccea3bee1ab3a74f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506369Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Hardik Goyal <hardikgoyal@chromium.org>
Auto-Submit: Hardik Goyal <hardikgoyal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823329}

This CL renames two AppCacheQuotaClient methods, NotifyAppCacheReady ->
NotifyStorageReady, and NotifyAppCacheDestroyed ->
NotifyServiceDestroyed, to clarify when the methods will get called.

This CL does not introduce any functional changes.

Bug: 1016065
Change-Id: I52238c731bcf805212d24bf744519adaf7a78374
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514666
Auto-Submit: Victor Costan <pwnall@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823328}

This will be used when translating paths for drag and drop.

Bug: 1144138
Change-Id: Ib6be0c4c219d5b9fe63ed205a22edb2675e7318c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513957
Commit-Queue: Jason Lin <lxj@google.com>
Reviewed-by: Jason Lin <lxj@google.com>
Auto-Submit: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823327}

The issue has been fixed in V8.

Bug: 1137143
Change-Id: I513cb3e606586d694f094b46d326e09c75235a90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514803
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823326}

TBR=govind@chromium.org

Change-Id: I1cefeef1741b2d518cdf66db1e3151e2e6271b86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512807Reviewed-by: Ben Mason <benmason@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Commit-Queue: Ben Mason <benmason@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823325}

More builder macro cleanup.

Bug: 1130078
Change-Id: Idf4127c8ebb3c71b1bc7a9710e58d629899710d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510738
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Auto-Submit: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823324}

Previously we recorded pod click events but we actually want to record
and differentiate show events vs close events. Show events will be used
to derive an approximation of feature DAU/WAU/MAU.

Bug: 1131266
Change-Id: I8e1104141626692131037d7396f20f7c2fe8121e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514671Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#823323}

- -Wfinal-dtor-non-final-class warns on classes with final dtors but
  not final classes.
- Error messages are better when the class is marked final.
- Fix existing issues in code base and a follow up will remove warning
  exemption.

Bug: 999886
Test: no errors building
Change-Id: I54b64f21213b7d02138ab67fcc68607f6fca9dc1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508199
Auto-Submit: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823322}

Reorder the initializaton of dispather and mediator so that
mediator can receive a correctly initialized dispatcher

Bug: 1144644
Change-Id: I8bc63b2444c32a4e9e8f3459a4a3ea15fe506ca8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514772
Auto-Submit: Lijin Shen <lazzzis@google.com>
Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823321}

After the gtest sharding bug is fixed, now we can see the correct runtime of the gtests and update it for better sharding.

Bug: chromium:1130157
Change-Id: Iafd46041207c0160350dbd39b2cd5bc5d20d0cce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514799
Auto-Submit: Wenbin Zhang <wenbinzhang@google.com>
Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823320}

Change-Id: I0e1ccb72d54caacec495f003e0a61c974354e4c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514801Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823319}

Round x,y coordinates in sendMouseClick so that the caller doesn't need
to take care of rounding.
Signed-off-by: Shannon Chen <shannc@chromium.org>
Bug: None
Change-Id: I0523c6bdb8dea7c77e33285feae4375ea4abd845
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514741
Commit-Queue: Shannon Chen <shannc@google.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823318}

Add "Login.ArcContinueBootImpulseTime" metric to track the
time taken to execute continue-arc-boot impulse.

See https://crrev.com/c/2512710 for code that emits the metric

BUG=b:165173640
TEST=deploy to dut and verify the new metric is present in

chrome: //histograms
Change-Id: I6dee096fc1665f402f4adfb898fd1dc56ddc86d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512724
Commit-Queue: Muhammad Hasan Khan <mhasank@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823317}

Before this patch, a closed frame could return a null origin, but the
payment operation continued and eventually triggered an assert that
checked for non-null origin.

This patch checks for null origin and aborts payment if that's detected.
The origin and URL of the render frame host is marked nullable for
clarity.

After this patch, if a closed frame returns a null origin, then payment
is aborted, so the assert is not triggered.

Bug: 1129578
Change-Id: I0d6404a6f425ce2e814d8d6fa177609a52d14641
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511710
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823316}

Add rule for conformance/rendering/draw-arrays-out-of-bounds.html in
webgl2_conformance_gles_passthrough_tests to suppress failures.

Bug: 1143323
Change-Id: I190079d0c307e0dff987769ebb6e7b57e507dc7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514508
Commit-Queue: kylechar <kylechar@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Auto-Submit: kylechar <kylechar@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823315}

Fixed: 1089866, 1089865, 1089864, 1046191, 972892
Bug: 1089866, 1089865, 1089864, 1046191, 972892
Change-Id: I60e2ad08e3f0ea5dd676a00d61338aa47c2d4aca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510770Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823314}

https://swiftshader.googlesource.com/SwiftShader.git/+log/b0e426fcf955..eaf1c53544a7

2020-11-02 sugoi@google.com Merge changes If776b87d,I27098964
2020-11-02 capn@google.com Consistently remove double colon from llvm namespace
2020-11-02 capn@google.com Emulate gather/scatter for MSan builds
2020-11-02 capn@google.com Prevent 'most vexing parse' issue

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: swiftshader-team+autoroll@google.com
Change-Id: I17d6d9b14f99d8d2ab717b811d90db4e6f6c75f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514510Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#823313}

When a native click accessibility operation is performed on an option
element that is part of a select popup, we mark the option as selected,
then do a native click on the parent select to dismiss it. This
sequence of operations ends up not firing `input` and `change` events,
which normally happens as part of the popup being dismissed by the
click in the normal case.

However, the AccessKeyAction for option takes care of this, so we
perform that operation instead of directly setting the option as
selected.


Bug: 1143990
Change-Id: Ied6023b4b2aee759575eebf75a32b7f2720f3068
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508884Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Victor Fei <vicfei@microsoft.com>
Commit-Queue: Daniel Libby <dlibby@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#823312}

crrev.com/c/2505739 makes the promos hidden by default until it is
decided whether the promo can be shown or not. Promos now remain hidden
until the promo loaded event or a window resize event is fired where
visibility of the promo is recalculated externally based on whether or
not it overlaps with the most-visited tiles.

This change coordinates these two steps by firing the promo loaded event
after the promo's visibility is determined internally. It also uses a
consistent mechanism for controlling the promo's visibility internally
and externally, i.e., 'hidden' attr aka 'display: none;'

Fixed: 1144624, 1143366
Change-Id: I3b2d2d86e56e0baba3f8042077a07aa0b6ce20a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514667Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823311}

Bug: dawn:455
Change-Id: Iaa5e5baf06de4e255b29f3c1a23a103ae8e00320
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493380
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823310}

R=liberato

Change-Id: I1dea9e0b00675145a57d29318d0fa1e6c3cb6347
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510916Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Reviewed-by: Ted Meyer <tmathmeyer@chromium.org>
Commit-Queue: Ted Meyer <tmathmeyer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823309}

Specifically:
 - Update remaining usages of js/util.js to explicitly pull-in
   js/assert.js.
 - Update webui_resources.grd to not use flattenhtml=true for
   JS files.
 - Remove "// <include src=..." directives from affected files

This is in preparation of moving such files over to the
auto-generated webui_generated_resources.grd, which (purposefully)
no longer supports flattenhtml.

Bug: 1132403
Change-Id: Idb9e4df54348c3eac3cbe7152893e3d5c5bd82a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503833
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Auto-Submit: dpapad <dpapad@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823308}

In particular, migrate SocketsUdpApiTest.SocketsUdpExtension
and SocketApiTest.SocketUDPExtension.

This CL introduces a new C++ TestUdpEchoServer class, which echoes
back the data it receives over an ephemeral UDP socket, and makes
those two tests use it.

They had been the only consumers of the SpawnedTestServer's UDP_ECHO
mode, so once this lands, that mode can be removed from the test
server.

The reason for migrating tests off of SpawnedTestServer is that
it has been a source of flaky failures and timeouts for years,
so everything that can use an in-process C++ server should be
doing so.

Bug: 492672
Change-Id: Iec532fc94ee9c33c612fca3d9392388b594707e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513787Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823307}

https://chromium.googlesource.com/catapult.git/+log/584ab491091a..888c272811ad

2020-11-02 dproy@chromium.org Fix some tracing UI tests under the polyfill

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC sadrul@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1111537
Tbr: sadrul@google.com
Change-Id: I6dd0c3cb0c5cd9b10dffd43926fa194e00b82749
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514506
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#823306}

The retry behaviour of the WebView data directory lock is now
well-understood and we're not going to change the code any further;
remove the retry count metric.

Also remove the metric logging when init has already been started
previously - this has shown that a very small number of apps are
actually hitting this case and only in a very tiny percentage of cases.
Just remove the metric and don't introduce any new check for this
condition; these apps will either work or not and it's not worth us
worrying about it.

Fixed: 1142488
Change-Id: I90b85e999ca74ebecdc66c2ac7e11aa4b0bf1d2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498110
Auto-Submit: Richard Coles <torne@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Caitlin Fischer <caitlinfischer@google.com>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823305}

In particular, migrate SocketsTcpApiTest.SocketTcpExtension,
SocketsTcpApiTest.SocketTcpExtensionTLS, and
SocketApiTest.SocketTCPExtension.

The second test was using SpawnedTestServer in HTTPS mode, which
could be directly replaced with EmbeddedTestServer in HTTPS mode.
The other two uses the SpawnedTestServer in TCP echo mode. Rather
than write a TCP echo server in C++, this CL switches them over
to use the EmbeddedTestServer in HTTP mode, matching the TLS socket
API test.

The reason for migrating tests off of SpawnedTestServer is that
it has been a source of flaky failures and timeouts for years,
so everything that can use the EmbeddedTestServer or other in-process
C++ servers should be doing so.

Bug: 492672
Change-Id: I655a77abc5a552f6a4edc5edfe3302abdf67fd7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513568Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823304}

We are using the word "sample" in too many ways. Try to move to less
ambiguous terminology.

Bug: 973801
Change-Id: I4d1feeeef22e756e82952e4b53a2a6615dac8715
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510240
Auto-Submit: Asanka Herath <asanka@chromium.org>
Commit-Queue: Alex Turner <alexmt@chromium.org>
Reviewed-by: Alex Turner <alexmt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823303}

This CL adds a IsBetterThanEngineWithConflictingKeyword method to
TemplateURL in an attempt to introduce a total ordering where we can
decide consistently across clients whether a given TemplateURL is
better than another one with a conflicting keyword.

There's already something very similar called:
TemplateURLService::BestEngineForKeyword(), which this CL replaces.

There's also TemplateURLService::IsLocalTemplateURLBetter() which
this CL leaves alone, but I hope to replace that with this new method
too as a followup.

My goal is that if every client can agree on which conflicting
TemplateURL is better than another, then we can resolve sync conflicts
in a consistent way.

One major caveat: Because the sync GUIDs are not globally unique,
it's possible to have a true tie, so there's no total ordering yet.
I hope to fix this once I can make the sync GUIDs globally unique.

Moreover, IsLocalTemplateURLBetter() privileges the default search
provider, which we probably have to keep doing. That would also be an
obstacle to this idea.

Bug: 1022775
Change-Id: I9249222cb10d2c34c3bc0a90da37fe88c52a6218
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511256
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823302}

This CL adds and uses DeleteWithRetry, which will work extremely hard to
delete a files or an empty directory.

mini_installer.exe extracts a number of files into a working directory
of its creation and deletes these files and directory after running
setup.exe. This deletion is known to fail from time to time (e.g., when
racing against termination of setup.exe's crashpad handler or against
A/V scanners). DeleteWithRetry should eliminate this class of failures
(except where the other entity takes more than ten seconds to relinquish
control over a file).

This CL also retires the temp dir fallback metric that had been reported
via ExtraCode1 and replaces it with a new metric that reports the max
number of retries required to delete any single item. We hope that this
is far lower than 100 (the max).

BUG=516207,1138157

Change-Id: I96d8cda32058987201d0cef36ec0a6d6976e9069
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503951
Commit-Queue: Greg Thompson <grt@chromium.org>
Reviewed-by: James Forshaw <forshaw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823301}

This change adds a check before creating a new chooser dialog that the
web contents it is being displayed over is the currently active one.

Bug: 1143057
Change-Id: I3a4e6fdb1745f2994e0e998fc2346d7485d118c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505746
Auto-Submit: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Andy Paicu <andypaicu@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823300}

Change-Id: I6580d6544444c9c78deb280d2d7c35094c16a07a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511856
Commit-Queue: Jamie Walch <jamiewalch@chromium.org>
Reviewed-by: Joe Downing <joedow@google.com>
Cr-Commit-Position: refs/heads/master@{#823299}

Removes DISALLOW_COPY_AND_ASSIGN and replaces it with explicit
deletions.

Bug: 1113981
Change-Id: I8deba3663a6ded97bf13c3398c199a8623a13bbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513808
Commit-Queue: Bo Majewski <majewski@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823298}

This prevents the slider views from awkwardly overlapping with the
shelf.

Bug: 1136564
Change-Id: I83551c6c5c2efb244d245a1055238ba6841d96c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499641
Commit-Queue: Angus McLean <angusmclean@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Tim Song <tengs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823297}

Roll Chrome Linux PGO profile from chrome-linux-master-1604318145-b605b3c459c88318c18e2e9d5bcf292a903238e1.profdata to chrome-linux-master-1604339911-22c5796f1ee7929b52f85640391db819ccf5f295.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Ie0c5af72b0cff2d0976d2712b5b6f9ce7288b411
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514839Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#823296}

After https://chromium-review.googlesource.com/c/chromium/src/+/2510772,
the toolchain "android_clang_arm" defines "arm_float_abi" but in case
this is not the default toolchain (e.g. current_cpu != "arm"),
"arm_float_abi" is not declared.

This CL makes sure that is always declared.

Bug: 1144188
Change-Id: Ic8b3791f9db037549b25ab3f13f3aa27518c4c0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512899Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823295}

The default scan-to path is the active user's My files folder. Remove
the TODO that states the check for this path should be removed and
combine the various checks into a single if statement.

Bug: 1059779
Change-Id: I1ad09b67e5fd7d80a6fe711bec22673a43d3eb43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510860Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Jesse Schettler <jschettler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823294}