GitLab

BUG=417463

Review URL: https://codereview.chromium.org/655693003

Cr-Commit-Position: refs/heads/master@{#300675}

Mark three histograms obsolete and add new ones in histograms.xml to enable access to histograms renamed
in https://crrev.com/12710005.

BUG=425723

Review URL: https://codereview.chromium.org/637413007

Cr-Commit-Position: refs/heads/master@{#300674}

When right click on an extension browser action in the Omnibox, the contextual
drop down says "Manage", which is unclear. Make the string to be more specific
such as "Manage Extensions".
The string's casing matches the platform; i.e. "Manage Extensions" for Mac,
"Manage extensions" everywhere else.

grd file changes:
Modifying 1 line label and 1 line desc text each in title case and in non title
case responsible for the label in: chrome/app/generated_resources.grd

BUG=418691
R=rouslan@chromium.org

TEST=
1) Launch chrome and install few extensions.
2) Right click an extension and observe
3) The context menu option for managing extensions should be string
   "Manage Extensions" on MAC, "Manage extensions" everywhere else.

Committed: https://crrev.com/4b4b173612017d0e45c2be082fb6f23baa79dc2a
Cr-Commit-Position: refs/heads/master@{#300516}

Review URL: https://codereview.chromium.org/659663004

Cr-Commit-Position: refs/heads/master@{#300673}

Cr-Commit-Position: refs/heads/master@{#300672}

This picks up in android_tools:
Updated SDK build tools to 21.0.1 and removed old versions.
Upgrade NDK to r10c.

And in breakpad:
Update breakpad to support Android NDK r10c
Fixing the Mac Inspector build by adding the launch_report dependency to the breakpadUtilities dylib project after it got pulled out from Inspector.mm.
Refactor .so name detection logic in minidump/linux_dumper.
The process uptime computation when the Windows out-of-process Crash Generation Server is used is done by subtracting the crashing process creation time from the current time when the crash is generated.
Linux multiprocess crash reporter: use pipe instead of socketpair in the client.
Remove workaround for Linux credential-passing bug.

TBR=brettw, danakj
NOTRY=true
BUG=424680, 425077, 358831

Review URL: https://codereview.chromium.org/671633003

Cr-Commit-Position: refs/heads/master@{#300671}

Make the copyrights scanner to use InputApi instead of accessing system
modules directly.

Convert manual unit tests for the scanner into automatic that now run as
a presubmit check for related changes in android_webview/tools/*

BUG=343104
NOTRY=true

Review URL: https://codereview.chromium.org/667723002

Cr-Commit-Position: refs/heads/master@{#300670}

It's a trivial change. The next swarming_client/ DEPS roll will enforce that no
further regression occurs.

TBR=vadimsh@chromium.org
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/636283010

Cr-Commit-Position: refs/heads/master@{#300669}

BUG=422235
R=bartfab@chromium.org

Review URL: https://codereview.chromium.org/671513014

Cr-Commit-Position: refs/heads/master@{#300668}

That means that when chrome://inspect is closed device is released.

BUG=387067

Review URL: https://codereview.chromium.org/644963003

Cr-Commit-Position: refs/heads/master@{#300667}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/9fdcfe1..f6b3ead

TBR=aboxhall@chromium.org,kochi@chromium.org

Review URL: https://codereview.chromium.org/673613002

Cr-Commit-Position: refs/heads/master@{#300666}

BUG=267281
TEST=None

Review URL: https://codereview.chromium.org/673573002

Cr-Commit-Position: refs/heads/master@{#300665}

Sets a const bool member when AIC is constructed and uses that member to access the stream AGC setting on the correct thread. Same member also enables or disables power logging.

In short: should reduce logging for all non-WebRTC clients.

BUG=408967
TEST=WebRTC clients checking DVLOGs.

Review URL: https://codereview.chromium.org/663123002

Cr-Commit-Position: refs/heads/master@{#300664}

This is done so that ADM::Device could have access to AndroidWebSocket's private members in order to close all sockets when device is released.

BUG=387067

Review URL: https://codereview.chromium.org/620183002

Cr-Commit-Position: refs/heads/master@{#300663}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/95c55ab..9fdcfe1

TBR=aboxhall@chromium.org,kochi@chromium.org

Review URL: https://codereview.chromium.org/668063003

Cr-Commit-Position: refs/heads/master@{#300662}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/655253008

Cr-Commit-Position: refs/heads/master@{#300661}

Currently, the 'Licenses' link in the App Info dialog only opens the
license page of the first shared module the app uses. Changed it to open
all licenses for shared modules that provide them in separate tabs, then
close the dialog.

BUG=422116

Review URL: https://codereview.chromium.org/653293004

Cr-Commit-Position: refs/heads/master@{#300660}

This will need a recipe-side change to pass the paths known to recipe
(from the path recipe module) and properties (from the properties
recipe module).

Each of these key-value pairs is passed as two command line arguments,
so that parsing them is easy and rock solid (avoids escaping issues),
and is also easy to convert to dict python-side.

BUG=422235
R=iannucci@chromium.org

Review URL: https://codereview.chromium.org/649683005

Cr-Commit-Position: refs/heads/master@{#300659}

Add permissions dropdowns to the PageInfo dialog on Android,
which alter the content setting for the website currently
being visited. Also add a 'Copy URL' button and a 'Done'
button.

BUG=365528

Review URL: https://codereview.chromium.org/620983002

Cr-Commit-Position: refs/heads/master@{#300658}

This implementation brings in several improvements for blending:
- it's done faster, due to reducing the number of readbacks.
- the backdrop doesn't suffer any transformation, so the result is more
  correct.
- the results are similar to the ones obtained using the software paths.
- blending is always applied after filters, even when the filters
  can be expressed using a color matrix.

The initial experiment: https://codereview.chromium.org/555133002/.

BUG=243223

Review URL: https://codereview.chromium.org/658483003

Cr-Commit-Position: refs/heads/master@{#300657}

Also revert https://codereview.chromium.org/579813002

BUG=404012

Review URL: https://codereview.chromium.org/665113002

Cr-Commit-Position: refs/heads/master@{#300656}

Over the original patch that got reverted, this takes into account that
the android device can be in a different orientation. If the nexus
device happens to be in portrait mode in the lab, it will report a
480x640 resolution rather than 640x480, so this reland accounts for
that.

The main purpose of this test is to test the capture path on Android,
i.e. that we can acquire the device's built-in webcam. If we happen to
run on a device without a camera, we'll quietly succeed the test.

BUG=323921
R=tommi

Review URL: https://codereview.chromium.org/663793003

Cr-Commit-Position: refs/heads/master@{#300655}

When we schedule the RenderContent() faster than the VSync signals.
The program will be blocked at SwapBuffer() and affect the performance of
both video decoding and rendering.

Now we change the code to schedule the RenderContent() base on the
VSync signals so that we won't be blocked at SwapBuffer().

BUG=415901
TEST=Run the vda_unittest on link and peach_pit

Review URL: https://codereview.chromium.org/590403004

Cr-Commit-Position: refs/heads/master@{#300654}

We used to not be able to tell audio packetsSent from video packetsSent
in the WebRTC stats reports, but with this patch we can. I use the fact
that all video-send metrics will come with other video-send metrics, so
we can classify a report based on what's in it (for instance, a report
with audioInputLevel in it will be an audio-send report).

This fixes buggy output where the code would merge data from send
and receive metrics, for instance leading to packets received sequences
like 10, 20, 15, 30, which doesn't make sense.

BUG=412787

Review URL: https://codereview.chromium.org/665123009

Cr-Commit-Position: refs/heads/master@{#300653}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=pneubeck@chromium.org

Review URL: https://codereview.chromium.org/660123003

Cr-Commit-Position: refs/heads/master@{#300652}

The color format parameter is hard coded for AndroidVideoEncodeAccelerator, we'd
better add negotiation with the codec for supported color formats.

BUG=423602

Review URL: https://codereview.chromium.org/648613003

Cr-Commit-Position: refs/heads/master@{#300651}

Also update some tests accordingly.

BUG=

Review URL: https://codereview.chromium.org/664313004

Cr-Commit-Position: refs/heads/master@{#300650}

NOTRY=true
BUG=425600

Review URL: https://codereview.chromium.org/637863006

Cr-Commit-Position: refs/heads/master@{#300649}

blink::WebFileChooserParams has a flag to show whether the receiver
(WebFileChooserCompletion) needs local paths of files or not.

The CL conveys the flag to the file chooser dialog so that the dialog does not
create snapshot file when the receiver does not need local paths.

BUG=126902

Review URL: https://codereview.chromium.org/663293002

Cr-Commit-Position: refs/heads/master@{#300648}

BUG=267281
TEST=None

Review URL: https://codereview.chromium.org/640223006

Cr-Commit-Position: refs/heads/master@{#300647}

Added util.querySelector(), which throws error if the query doesn't find an element.
Using it and assert(), ensure the existence of elements which are queried in initialization process of FileManager.
Some trivial fixes for type-check errors are also included.

BUG=406995
TEST=run browser_tests

Review URL: https://codereview.chromium.org/667933003

Cr-Commit-Position: refs/heads/master@{#300646}

from blank page (about:blank) that has been loaded in WebUI-bindings-enabled renderer.

This currently reproduces in process models other than default
process-per-site(-instance) as they only enforce new renderer
on webui-vs-regular navigations and fail to recognize that about:blank
might have been loaded in WebUI (as per http://crbug.com/42547).

This CL includes the browser test that reproduces this problem
and verifies the fix.

BUG=424526

Review URL: https://codereview.chromium.org/659293002

Cr-Commit-Position: refs/heads/master@{#300645}

BUG=425396,414026

Review URL: https://codereview.chromium.org/643773004

Cr-Commit-Position: refs/heads/master@{#300644}

Summary of changes available at:
https://chromium.googlesource.com/chromium/deps/icu52/+log/8ac906f..6ea11f3

https://chromium.googlesource.com/chromium/deps/icu52/+log/6ea11f3..d8b2a9d

In addition, change the encoding menu, encoding preferences, and browser tests accordingly;
1. unify iso-8859-1 with windows-1252 in the menu (the name to use is windows-1252)
2. update the encoding preference (default encoding, etc) for various locales.
3. update the test result/expectation.

Re-enable tests disabled in https://codereview.chromium.org/643993004/

TBR=jsbell@chromium.org
BUG=412053
TEST=browser_tests
    BrowserEncodingTest.TestEncodingAutoDetect
    BrowserEncodingTest.TestOverrideEncoding
    EncodingAliases/BrowserEncodingTest.TestEncodingAliasMapping
    SavePageBrowserTest.FileNameFromPageTitle
    SavePageBrowserTest.SaveCompleteHTML
    PrefsTabHelperBrowserTest.WebPrefs
TEST=net_unittest --gtest_filter="*ilenameUtil*"
TEST=base_unittests --gtest_filter="*Conv*"
TEST=Blink: fast/encoding/*
TEST=http://www.w3.org/International/tests/repository/encoding/indexes/results-indexes
TEST=http://www.w3.org/International/tests/repository/encoding/indexes/results-aliases
TEST=http://www.w3.org/International/tests/repository/run?manifest=encoding/indexes&test=windows-1253_test
TEST=http://www.w3.org/International/tests/repository/run?manifest=encoding/indexes&test=windows-874_test

Review URL: https://codereview.chromium.org/649413002

Cr-Commit-Position: refs/heads/master@{#300643}

TBR=dominich@chromium.org,thestig@chromium.org
BUG=417463

Review URL: https://codereview.chromium.org/666563003

Cr-Commit-Position: refs/heads/master@{#300642}

Start with __lookupGetter__, __defineGetter__, and __defineSetter__.

R=maruel@chromium.org
BUG=425829

Review URL: https://codereview.chromium.org/670043002

Cr-Commit-Position: refs/heads/master@{#300641}

R=brettw@chromium.org

Review URL: https://codereview.chromium.org/670833003

Cr-Commit-Position: refs/heads/master@{#300640}

BUG=422641
Test=Load chrome with the following flags:
--out-of-process-pdf, --enable-mime-handler-view
Load a PDF in a <webview>, e.g. use the webview-sample/browser app:
https://chrome.google.com/webstore/detail/edggnmnajhcbhlnpjnogkjpghaikidaa
and navigate to a PDF.
Right clicking the PDF should bring context menu to correct
position relative to the cursor.

Review URL: https://codereview.chromium.org/667273002

Cr-Commit-Position: refs/heads/master@{#300639}

Following https://codereview.chromium.org/649183007/ , I've updated the
histograms file on the Chrome side.

Review URL: https://codereview.chromium.org/663393002

Cr-Commit-Position: refs/heads/master@{#300638}

Revert of Add gclient hook to download prebuilt mojo_shell (patchset #7 id:120001 of https://codereview.chromium.org/667853002/)

Reason for revert:
gclient sync fails to execute download_shell_binary.py

Original issue's description:
> Add gclient hook to download prebuilt mojo_shell
>
> This adds a gclient hook that downloads prebuilt mojo_shell binaries
> from google storage (linux only for now) and gyp/gn flags to toggle
> using these prebuilt binaries instead of ones built from source. This
> also adds a helper script that uploads a locally built mojo_shell binary
> to the appropriate place in google storage.  The versioning scheme is:
>
> *) mojo/public/VERSION contains an identifier (committish currently) for
>   the mojo public SDK. The mojo_shell binary must match the interfaces
>   defined in this version of mojo/public/.
>
> *) gs://mojo/shell/$VERSION/$PLATFORM.zip contains a prebuilt mojo_shell
>   binary for a particular version. $PLATFORM for now must be linux-x64,
>   but we can add more later as needed.
>
> gclient runhooks downloads the shell binary referred to by
> mojo/public/VERSION if it is available for the host platform to
> mojo/public/tools/prebuilt/ and updates mojo/public/tools/prebuilt/VERSION
> to tag the version downloaded if successful. On subsequent runs the hook
> will check this against mojo/public/VERSION and avoid downloading again if
> the binary is up to date.
>
> This also adds variables to the GYP and GN builds that control if building
> 'mojo' builds a mojo_shell binary from source or copies the prebuilt binary
> into the outdir.  They both default to false for now.
>
> R=abarth@chromium.org
>
> Committed: https://crrev.com/e098527822f3e25fb5b86c1441f7ce6e4c2cfdc8
> Cr-Commit-Position: refs/heads/master@{#300600}

TBR=abarth@chromium.org,jamesr@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/670073002

Cr-Commit-Position: refs/heads/master@{#300637}

Insertion handle is showing when we long press on readonly input
elements, which is not correct. This change takes care of correcting
it by counter measuring inside isEditableNode() API.

BUG=

Review URL: https://codereview.chromium.org/660343003

Cr-Commit-Position: refs/heads/master@{#300636}