GitLab

Revert of Make landmines work on local builds too (patchset #3 of https://codereview.chromium.org/457003004/)

Reason for revert:
Apparently this requires win_toolchain.json to exist, but I'm not sure how it's supposed to get there (as seen on a clobber build):


Traceback (most recent call last):
  File "src/build/landmines.py", line 132, in <module>
    sys.exit(main())
  File "src/build/landmines.py", line 119, in main
    gyp_environment.SetEnvironment()
  File "C:\b\build\slave\win_trunk\build\src\build\gyp_environment.py", line 33, in SetEnvironment
    vs_toolchain.SetEnvironmentAndGetRuntimeDllDirs()
  File "C:\b\build\slave\win_trunk\build\src\build\vs_toolchain.py", line 33, in SetEnvironmentAndGetRuntimeDllDirs
    with open(json_data_file, 'r') as tempf:
IOError: [Errno 2] No such file or directory: 'C:\\b\\build\\slave\\win_trunk\\build\\src\\build\\win_toolchain.json'

Original issue's description:
> Make landmines work on local builds too
> 
> Moves (some of) gyp environment setup out of gyp_chromium into separate
> module, and shares that between gyp_chromium and landmines.py.
> 
> landmines.py is added as the first entry in DEPS hooks so that it can
> clobber the entire build directory before running other hooks that
> extract/generate into the build dir.
> 
> R=iannucci@chromium.org
> BUG=400011
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289099

TBR=scottmg@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=400011

Review URL: https://codereview.chromium.org/469623002

Cr-Commit-Position: refs/heads/master@{#289158}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289158 0039d316-1c4b-4281-b951-d872f2087c98

R=avi@chromium.org

Review URL: https://codereview.chromium.org/461313002

Cr-Commit-Position: refs/heads/master@{#289157}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289157 0039d316-1c4b-4281-b951-d872f2087c98

Replace "phone" with "Android phone" in the notification body.

BUG=402269
R=tengs@chromium.org

Review URL: https://codereview.chromium.org/460283002

Cr-Commit-Position: refs/heads/master@{#289155}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289155 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert: uninitialize memory access

http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Mac%20%28valgrind%29%282%29/builds/29469/steps/memory%20test%3A%20content/logs/stdio

> Use RE string pattern matching for blacklist strings.
> 
> Including cpu_brand, gl_vendor, gl_renderer, gl_extension, driver_vendor,
> and machine_model_name.
> 
> BUG=396578
> TBR=piman@chromium.org
> TEST=gpu_unittests
> 
> Review URL: https://codereview.chromium.org/452293002

TBR=zmo@chromium.org

Review URL: https://codereview.chromium.org/465163002

Cr-Commit-Position: refs/heads/master@{#289154}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289154 0039d316-1c4b-4281-b951-d872f2087c98

Added SHADOW_TYPE_RECTANGULAR_ALWAYS_ACTIVE which lets the window always use the active shadow.

BUG=None

Review URL: https://codereview.chromium.org/455543004

Cr-Commit-Position: refs/heads/master@{#289153}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289153 0039d316-1c4b-4281-b951-d872f2087c98

It is possible for the gesture recognizer to report
a NULL target for a gesture event, in which case
we should not attempt event dispatch. An early return
already exists in
WindowEventDispatcher::DispatchGestureEvent() to
guard against this possibility, so add a similar
check to WindowEventDispatcher::ProcessGestures().

BUG=384962
TEST=WindowEventDispatcherTest.CallToProcessedTouchEvent

Review URL: https://codereview.chromium.org/450413002

Cr-Commit-Position: refs/heads/master@{#289152}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289152 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=GestureProviderTest.ZeroRadiusBoundingBox

Review URL: https://codereview.chromium.org/464013002

Cr-Commit-Position: refs/heads/master@{#289151}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289151 0039d316-1c4b-4281-b951-d872f2087c98

instead of suppressing memory issue.

BUG=403177
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/469603002

Cr-Commit-Position: refs/heads/master@{#289150}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289150 0039d316-1c4b-4281-b951-d872f2087c98

BUG=401588

Review URL: https://codereview.chromium.org/454253004

Cr-Commit-Position: refs/heads/master@{#289149}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289149 0039d316-1c4b-4281-b951-d872f2087c98

> Deleting unused SSL images
> 
> These images remain from the recent SSL interstitial upgrade, but are no
> longer needed.
> 
> BUG=
> R=dbeam@chromium.org
> 
> Review URL: https://codereview.chromium.org/464523002

TBR=felt@chromium.org

Review URL: https://codereview.chromium.org/467993003

Cr-Commit-Position: refs/heads/master@{#289148}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289148 0039d316-1c4b-4281-b951-d872f2087c98

The SetAlphaShape bugs have been fixed:
* HiDPI Shape: crrev.com/394193003
* Null Shape: crrev.com/456943004

BUG=324071,374440

Review URL: https://codereview.chromium.org/453173002

Cr-Commit-Position: refs/heads/master@{#289147}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289147 0039d316-1c4b-4281-b951-d872f2087c98

These images remain from the recent SSL interstitial upgrade, but are no
longer needed.

BUG=
R=dbeam@chromium.org

Review URL: https://codereview.chromium.org/464523002

Cr-Commit-Position: refs/heads/master@{#289146}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289146 0039d316-1c4b-4281-b951-d872f2087c98

TBR=zhaoqin@chromium.org
BUG=https://code.google.com/p/drmemory/issues/detail?id=1584

Review URL: https://codereview.chromium.org/467963003

Cr-Commit-Position: refs/heads/master@{#289145}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289145 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit r284737.

It's no longer needed since build_pnacl_newlib plus
enable_${arch} no longer imply that the pexe should be
translated. That's controlled by the 
translate_pexe_with_build flag instead.

Also remove the adhoc uses of enable_x86_32: 0, etc.
now that pexe -> nexe is off by default.

BUG=none

Review URL: https://codereview.chromium.org/433943004

Cr-Commit-Position: refs/heads/master@{#289144}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289144 0039d316-1c4b-4281-b951-d872f2087c98

Previously PepperPortAllocator was using only the first STUN server
because cricket::PortConfiguration didn't support more than one STUN
server.

Review URL: https://codereview.chromium.org/456013002

Cr-Commit-Position: refs/heads/master@{#289143}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289143 0039d316-1c4b-4281-b951-d872f2087c98

I missed that RVContextMenu::IsCommandIdEnabled has NOTREACHED() and my refactoring was causing DCHECK failure.
I'll refactor a bit more to make each group modular when lazyboy@ is back.

BUG=401926
TEST=covered by RenderViewContextMenuTest.IsCustomCommandIdEnabled

Review URL: https://codereview.chromium.org/453993002

Cr-Commit-Position: refs/heads/master@{#289142}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289142 0039d316-1c4b-4281-b951-d872f2087c98

In the CL

commit 46d8f4c5
Author: alokp@chromium.org <alokp@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date:   Fri Jul 18 21:36:55 2014 +0000

    Move adb_profile_chrome to profile_chrome.

    This is being done with the intention to port this tool to other
    platforms. The first step is to move the existing code to a common
    location.

    Review URL: https://codereview.chromium.org/402803005

We moved adb_profile_chrome to a new location, update its path in
android_systrace_profiler.py accordingly.

BUG=None
TEST=run benchmark with --profiler=android-systrace and no complaining of can't
find adb_profile_chrome

Review URL: https://codereview.chromium.org/460123002

Cr-Commit-Position: refs/heads/master@{#289140}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289140 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#289139}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289139 0039d316-1c4b-4281-b951-d872f2087c98

IsCounterClockwise is a busy function,See performance and discussion:
https://groups.google.com/a/chromium.org/forum/#!topic/graphics-dev/aSvAbzcgbos

This patch reduce IsCounterClockwise() from 8mul+3add+4sub to 4mul+2add+2sub,
and performance doubled in real micro-bench.

R=danakj@chromium.org

Review URL: https://codereview.chromium.org/458113002

Cr-Commit-Position: refs/heads/master@{#289138}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289138 0039d316-1c4b-4281-b951-d872f2087c98

Whenever a Views textfield is going to show touch handles, it should
first check that it has focus or not. If not, the handles should not be
shown. This might be because the textfield is disabled or it is
explicitly set to be non-focusable, among other reasons.

BUG=323956

Review URL: https://codereview.chromium.org/103293004

Cr-Commit-Position: refs/heads/master@{#289137}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289137 0039d316-1c4b-4281-b951-d872f2087c98

Preserve full libcronet.so for crash log symbolication.
Upstream proguard.cfg changes.

BUG=396781

Review URL: https://codereview.chromium.org/463493005

Cr-Commit-Position: refs/heads/master@{#289136}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289136 0039d316-1c4b-4281-b951-d872f2087c98

BUG=401853

Review URL: https://codereview.chromium.org/453673003

Cr-Commit-Position: refs/heads/master@{#289135}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289135 0039d316-1c4b-4281-b951-d872f2087c98

In the static build mojo_surfaces_service and some examples were linking
against both mojo_system and mojo_system_impl, which doesn't work.

R=erg@chromium.org

Review URL: https://codereview.chromium.org/468563002

Cr-Commit-Position: refs/heads/master@{#289134}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289134 0039d316-1c4b-4281-b951-d872f2087c98

R=brettw@chromium.org

Review URL: https://codereview.chromium.org/461903002

Cr-Commit-Position: refs/heads/master@{#289133}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289133 0039d316-1c4b-4281-b951-d872f2087c98

We have recently removed usage of these deprecated fields from the code. This CL removes them from the protos too.

Review URL: https://codereview.chromium.org/467753002

Cr-Commit-Position: refs/heads/master@{#289130}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289130 0039d316-1c4b-4281-b951-d872f2087c98

Followup from https://codereview.chromium.org/419673004

BUG=397554

Review URL: https://codereview.chromium.org/460583002

Cr-Commit-Position: refs/heads/master@{#289129}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289129 0039d316-1c4b-4281-b951-d872f2087c98

This will match the behavior on ChromeOS and ensure that users without
notifications will not be annoyed by the Chrome notifications center
icon in the status tray.

BUG=401215

Review URL: https://codereview.chromium.org/459123002

Cr-Commit-Position: refs/heads/master@{#289128}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289128 0039d316-1c4b-4281-b951-d872f2087c98

    
This removes the use of memory pressure signals from discardable memory
system and instead introduces an explicit call for reducing emulated
discardable memory that the renderer can call when all widgets are hidden
until we have a better mechanism in place.
    
BUG=398087
TEST=base_unittests,content_browsertests

Review URL: https://codereview.chromium.org/448173002

Cr-Commit-Position: refs/heads/master@{#289127}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289127 0039d316-1c4b-4281-b951-d872f2087c98

BUG=402212
TBR=rlarocque@chromium.org

Review URL: https://codereview.chromium.org/468703002

Cr-Commit-Position: refs/heads/master@{#289126}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289126 0039d316-1c4b-4281-b951-d872f2087c98

Sam has been working on chromedriver since Oct. 2013 and he has contributed over 50 CLs and reviewed around 20 CLs.
So I recommend that we add Sam as an owner of chromedriver.

R=craigdh@chromium.org

Review URL: https://codereview.chromium.org/469523002

Cr-Commit-Position: refs/heads/master@{#289120}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289120 0039d316-1c4b-4281-b951-d872f2087c98

calling WebContents, not whatever the "associated" WebContents is.

BUG=402318
R=fsamuel@chromium.org, jamescook@chromium.org

Review URL: https://codereview.chromium.org/458323002

Cr-Commit-Position: refs/heads/master@{#289118}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289118 0039d316-1c4b-4281-b951-d872f2087c98

Start including Checkstyle 5.7 binary to use for Java style presubmit
checks.

BUG=318404
NOTRY=true
R=brettw@chromium.org, yfriedman@chromium.org

Review URL: https://codereview.chromium.org/451313002

Cr-Commit-Position: refs/heads/master@{#289117}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289117 0039d316-1c4b-4281-b951-d872f2087c98

Ash GetLocalProcessWindowAtPointImpl should ignore windows in the
mouse cursor container.

BUG=399309
R=oshima@chromium.org, sky@chromium.org
TBR=sky@chromium.org
TEST=verify that tab merging works with large cursors.

Review URL: https://codereview.chromium.org/468603002

Cr-Commit-Position: refs/heads/master@{#289116}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289116 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert: see crbug.com/403098

> [Sync] Cleanup datatype configuration error handling.
> 
> The FailedDataTypeHandler is now informed immediately of failures, including
> datatype errors, and is therefore authoritative source for all errors. As such,
> partial success is no longer tracked and the various ModelTypeSets for error
> types in configure results are removed.
> 
> BUG=368834,403098
> 
> Review URL: https://codereview.chromium.org/420633002

TBR=zea@chromium.org

Review URL: https://codereview.chromium.org/468643002

Cr-Commit-Position: refs/heads/master@{#289115}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289115 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert: see crbug.com/403098

> [Sync] Use OnSingleDataTypeUnrecoverableError for all errors
> 
> This removes the disable callback from all datatype controllers as well
> as the DisableDataType method from the PSS, in favor of
> OnSingleDataTypeUnrecoverable error (which now accepts a SyncError).
> 
> BUG=368834,403098
> TBR=bauerb@chromium.org
> 
> Review URL: https://codereview.chromium.org/436733002

TBR=zea@chromium.org

Review URL: https://codereview.chromium.org/465113002

Cr-Commit-Position: refs/heads/master@{#289113}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289113 0039d316-1c4b-4281-b951-d872f2087c98

process_file_template would fail when the template argument was a string instead of a list, but the previous behavior (and the documentation) describes it as being able to take a string or a list as an argument.

It would also fail if the result was not an absolute file. This is required for most uses of sources expansions, but not for process_file_template which just returns the strings of whatever the results were. This adds "AsStrings" version of the sources expansions writer.

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/462103004

Cr-Commit-Position: refs/heads/master@{#289112}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289112 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert: see crbug.com/403098

> [Sync] Don't synchronously stop datatypes that encounter errors
> 
> The datatype logic may be operating unders assumptions that break when
> the type is stopped from under it, possibly triggering crashes.
> 
> BUG=402595,403098
> 
> Review URL: https://codereview.chromium.org/462863002

TBR=zea@chromium.org

Review URL: https://codereview.chromium.org/467923002

Cr-Commit-Position: refs/heads/master@{#289111}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289111 0039d316-1c4b-4281-b951-d872f2087c98

Properly write outputs of actions that have no sources list. Previously this would lead to empty output lists in a build rule because the writer code was trying to apply the sources list to the output substitutions list. However, for actions, the output is the literal file list and should have no substitutions.

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/461153002

Cr-Commit-Position: refs/heads/master@{#289109}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289109 0039d316-1c4b-4281-b951-d872f2087c98

This handles nested third_party directories.

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/462063002

Cr-Commit-Position: refs/heads/master@{#289106}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289106 0039d316-1c4b-4281-b951-d872f2087c98

so that it can handle negative errors (like 0.999)

BUG=None
R=danakj@chromium.org

Review URL: https://codereview.chromium.org/467813002

Cr-Commit-Position: refs/heads/master@{#289105}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289105 0039d316-1c4b-4281-b951-d872f2087c98