- 22 Jul, 2020 40 commits
-
-
Mustaq Ahmed authored
The user activation was added as part of crbug.com/765266 to be able to differentiate "pasting through right-click context" from a JS initiated paste command. Since UAv2 shipped in M72 the transient user activation from a right click event is now available to the ExecuteCommand by design. So we don't need the synthetic activation. Fixed: 1103842 Change-Id: Ied918ff20451ee5efb2dc11e97601ab9c95ad9fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311142 Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#790834}
-
Michael Lippautz authored
Will be used in a Finch experiment. Bug: chromium:1107901 Change-Id: I68ea04be372ef2a931519c6d63916ed6001d7a26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312816Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#790833}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6e1eb168a544..01373555fef7 2020-07-22 adlai@google.com Remove GrContext variant of SkImage::isValid If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: Id98b3d8c87b2f6643b4008fc01abb28c050c31ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312530Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790832}
-
Wojciech Dzierżanowski authored
This gathers some pieces of MediaSession-specific logic spread across WebMediaPlayer implementations and moves them to MediaSession-specific code area. The aim is for the WMPD interface to be for conveying generic media-related events (metadata changes, play/pause, etc.), and for MediaSessionController to be the consumer of these events that is able to process them to make MediaSession-specific decisions (activate/suspend MediaSession when unmuted playback starts, etc.). This also enables future changes like teaching MediaSessionController to activate MediaSession upon entering Picture-in-Picture even if media is not playing. Bug: 1091203 Change-Id: I8b2d29c0fe40f8ef80234fe832c4fd50878c1f4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308423 Commit-Queue: Wojciech Dzierżanowski <wdzierzanowski@opera.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#790831}
-
Eric Willigers authored
On Android, the Share Service now checks that the Web Share API is enabled by feature policy. Remaining work: crbug.com/1108163 Generate FeaturePolicyFeature enum from mojom TBR=rouslan@chromium.org Bug: 1079104 Change-Id: I9e9061e06f4cd39ebbc3ab33a8a1fc44e2ae366d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306124Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#790830}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a30bbb68c2e3..8af044eac104 2020-07-22 ahaas@chromium.org [v8][wasm] Introduce metric for compilation tierup If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1084929 Tbr: wenbinzhang@google.com Change-Id: I8f120edffb1fdf3268b7414a379f3ab260fb5e90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312356Reviewed-by:
-
Lei Zhang authored
With the XCursorLoader changes in https://crrev.com/789288, comparisons for |render_version_| do not work if |render_version_| is never set. Make sure |render_version_| is valid before comparing it. Bug: 1066670 Change-Id: I10c3c43d9b42403747fd073aa065ab3e8d00ed0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310961Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#790828}
-
Anatoliy Potapchuk authored
Bug: 1015383 Change-Id: I196327e40dcc0dd79c092e265e29134395bc1f9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309431Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#790827}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/97471695..99a565b6 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I594e546ec535f10e08ad795b59210a1338d75297 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312736Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790826}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/62b67239f59e..f3c72fdf8246 2020-07-22 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from b99a6a727318 to 11fa4d0d5694 (3 revisions) 2020-07-22 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Tools from 50e737c82347 to 3b36fdc64014 (1 revision) 2020-07-22 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 97f9923235cf to f272427bda39 (7 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: Ie132b31c9d6f2ce27e677337766753722a96dc9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312519Reviewed-by:
-
Viviane Yang authored
Separate methods for finding service_worker_version (can be reused for other events) and message delivery functions. This CL prepares the PushMessagingRouter class to support PushSubscriptionChange events. Additionally, |service_worker_context| is removed from DeliverMessageEnd since it is not used. Bug: 1107744 Change-Id: Iad371fdb68d50cc0c0dc73a1a1661613e18753da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308710Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Viviane Yang <viviy@google.com> Cr-Commit-Position: refs/heads/master@{#790824}
-
Irina Fedorova authored
Bug: 377410 Change-Id: I35dc3360d44d761ae39e11eed5939075659434a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312099Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Irina Fedorova <irfedorova@google.com> Cr-Commit-Position: refs/heads/master@{#790823}
-
Victor Hugo Vianna Silva authored
Two aspects overlooked in crrev.com/c/2309699. - One test in BookmarkTest also needs to be updated now that the promo in the bookmarks UI is also shown when DecoupleSyncFromAndroidMasterSync is enabled. - In testToggleChromeSyncFromSettings(), if the master sync is not enabled in the beginning of the test when the feature is enabled, the waitForLastNotificationCompleted() call after disabling the toggle hangs, since no notification is triggered when setMasterSyncAutomatically() doesn't actually change the state of the toggle. Bug: 1105795 Change-Id: Iaba8da32b99bac16c6103d71f63169453752c969 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312418Reviewed-by:
-
Saho Kobayashi authored
State Description and SELECTED can be annotated as kDescription. Append them when the node has both. Bug: b/154433831 Test: AccessibilityNodeInfoDataWrapperTest.appendkDescription Change-Id: I5b052cd38617f1b4766af3fdc5f61d3d40fb2a28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310055 Commit-Queue: Saho Kobayashi <sahok@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Reviewed-by:
Hiroki Sato <hirokisato@chromium.org> Cr-Commit-Position: refs/heads/master@{#790821}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1595397501-73227feb72e80d042b6cedd93932654832bac5dd.profdata to chrome-mac-master-1595418891-a8621ba8b81fb74c2c9632ebc3dbb1023038eccd.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com Change-Id: Iad38808e1042208064657c4bda470d08b850a167 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312528Reviewed-by:
-
sandromaggi authored
As proposed by UX. This adds a recovery path for STOPPED state. When the user clicks "back" the |Controller| enters STOPPED with recovery option enabled and shows the user a pre-prepared UI (defined by strings through client settings). While STOPPED, the |ScriptExecutor| does not continue to execute any actions. Same as completely shutting down, it also does not inform the backend about any of this. When resuming, the |ScriptExecutor| acts as if nothing happened, picking off from the last action. Bug: b/158521476 Change-Id: Ia64551c3c8efb96c1bcc88a3e067ed944b6bc974 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243217 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Marian Fechete <marianfe@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#790819}
-
Robert Sesek authored
These were observed in https://crbug.com/1063349#c8. Bug: 1063349 Change-Id: I86cf9b5d643812101c2d80b67096c38f76706008 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311273Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#790818}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6651f11ef8de..e9817f52a1a2 2020-07-22 aerotwist@chromium.org Migrates root to devtools_entrypoint If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1101738 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I786ce445504c68e54411e2a4326af8fcb197ab6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312523Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a5d9c1a45c2b..6c1278acd658 2020-07-22 mbonadei@webrtc.org Inclusive language in PRESUBMIT.py. 2020-07-22 sprang@webrtc.org Minimizes risk of probes being late when using TaskQueuePacedSender. 2020-07-21 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 3a98cccc..6b2bcf62 (790410:790515) 2020-07-21 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision abd2dc65..3a98cccc (790286:790410) 2020-07-21 jasonlon@google.com Implemented Android Demo Application for VoIP API 2020-07-21 titovartem@webrtc.org Add list of local_addresses for network stats object 2020-07-21 danilchap@webrtc.org Do not propage RTPFragmentationHeader into rtp_rtcp If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic2dc66ee74bf1853828426d8fd85405f7e0515b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312522Reviewed-by:
-
arthursonzogni authored
I assumed a V8 context executing code was always happening from a non-destroyed frame. This is not true. For instance, some code from testharness.js was executed many postMessage, while its frame was deleted. Code from CheckCoopAccess was executing: ``` if (accessing_window->GetFrame()->IsCrossOriginToParentFrame()) ───┬──────────────────────── └──> nullptr ``` Bug: 1108256 Change-Id: Ieb317db033495b7510a4a05c6ca7b9ab41a615d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312696Reviewed-by:Camille Lamy <clamy@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#790815}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/53a32034a451..20440b51438f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC orphis@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: orphis@google.com Change-Id: Ic75042d744a272b20afbd505383631aac2e44519 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312518Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790814}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f628e927. With Chromium commits locally applied on WPT: a02f2df5 "Implement Storage Access commands for TestDriver" 9c2ef271 "[COOP report] Add support for report-only" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: Ib16516cbf08a67134f7c79eac83bb7ec3881f21a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312258Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790813}
-
Hiroki Nakagawa authored
As a part of the Onion Soup project, this CL moves CodeCacheLoaderImpl from content/renderer/loader/ to blink/renderer/platform/exported/. In addition to that, this CL renames following files: - CodeCacheLoader => WebCodeCacheLoader - CodeCacheLoaderImpl => CodeCacheLoader Bug: 860403 Change-Id: Ib1e4cfdb8aa37192d2e665f698f6e3090c7a62ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310270 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#790812}
-
Philip Pfaffe authored
Test expectation updated after landing CL 2245146. Bug: chromium:1083146, chromium:1107339 Change-Id: Ide9338ee0f34234270b0264c38f0b41274ca6502 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306254Reviewed-by:
Simon Zünd <szuend@chromium.org> Commit-Queue: Philip Pfaffe <pfaffe@chromium.org> Cr-Commit-Position: refs/heads/master@{#790811}
-
Maksim Ivanov authored
Refactor the code of form "CHECK(base::PathService::Get(...))" with the alias function base::PathService::CheckedGet(). This is a pure refactoring CL - no change of functionality is expected. Bug: none Change-Id: Ia4a04a51fd6f3c7ec4fca0a9bf5cb27224dfc5f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288631 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#790810}
-
Side Yilmaz authored
This CL replaces deprecated functions of IdentityServicesProvider with the newer service getters with profile parameter. |mProfile| instance variable stores the profile coming from constructor and this CL passes |mProfile| to IdentityServicesProvider class. Since IdentityServicesProvider return null for off-the-record profile, there is an additional null check for identity manager. Bug: 1041781, 1075562 Change-Id: I9966e7177e81d2e0bb45b5b8c93e29e8715b7747 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307235Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#790809}
-
Olesia Marukhno authored
Bug: 1098660 Change-Id: I3036489ce3b939d9668c6fa374c465caf8f98a2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292290 Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#790808}
-
Victor Hugo Vianna Silva authored
Bug: 1060128 Change-Id: I9a5a117b84ae6913942dfba1dd438b6ad501a8c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312476 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
-
dizg authored
Bug: 1105865 Change-Id: I0f1091e2068e4a1cfff0e6eee9b2898a74e4a945 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308416 Commit-Queue: Diana Zagidullina <dizg@google.com> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#790806}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/11fa4d0d5694..9165cbb4f40d 2020-07-22 johnkslang@users.noreply.github.com Merge pull request #2354 from ben-clayton/limit-visibility If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,timvp@google.com Change-Id: I6a9ef911894db468a2ccff97f1d71a5e331c20c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312296Reviewed-by:
-
Olesia Marukhno authored
Accelerators are processed on MacOS without doing the manual redirect to bubble's anchor widget so this code doesn't need to be included in Mac. I exclude it here because it appears that it breaks processing accelerators by the bubble (ex. copy text). Bug: 1106654 Change-Id: I4837d6aec4175dd170632678047755b62c5e1b53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303720Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/15011595..97471695 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0e6ce2e3d5146e9497413a4855f3adbdcb8829af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311538Reviewed-by:
-
Yuki Shiino authored
Bug: 839389 Change-Id: Ib7824eca25aa23cb949d3d998d410d09db93ef60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306110 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#790802}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/9dd9a4b88264..6651f11ef8de 2020-07-22 szuend@chromium.org Migrate 'front_end/browser_sdk' to 'devtools_entrypoint' 2020-07-22 szuend@chromium.org Migrate 'front_end/dom_extension' to 'devtools_entrypoint' 2020-07-22 jacktfranklin@chromium.org Fix bad border colour on computed styles If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1101738 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I204cf0441473ec429690d3897830cffc81fe9df9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311953Reviewed-by:
-
Side Yilmaz authored
This CL replaces deprecated functions of IdentityServicesProvider with the newer service getters with profile parameter. Since back up is only available in regular mode, it is safe to pass always regular profile to IdentityServicesProvider functions. Note: This CL does not make any behaviour change. Bug: 1041781, 1075562 Change-Id: Iced1c7c721491e8e24eb747c5e6a65cadc64801a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307290Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#790800}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/14ddd018d942..53a32034a451 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC orphis@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1104817 Tbr: orphis@google.com Change-Id: I8c8ff6f08ee22e8fb50b5801f66e0e6c3310428b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311952Reviewed-by:
-
Boris Sazonov authored
Fixes an ANR that happens on Chrome startup. Now, if the list of accounts is not available when launchSigninPromoIfNeeded is invoked, the promo is suppressed. Bug: b/160838338 Change-Id: Ibbdbfc2f0adc7ae40fe22568f5607c2c4a9f42c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303443Reviewed-by:
Alice Wang <aliceywang@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#790798}
-
Maksim Ivanov authored
* Add "onCertificatesUpdateRequested" event, to supersede the "onCertificatesRequested" event. * Add "onSignatureRequested" event, to supersede the "onSignDigestRequested" event. * Add "reportSignature" method, to supersede the old way of responding to the callback passed with the "onSignDigestRequested" event. * Add "Algorithm" enum, to supersede the old "Hash" enum. * Add "Error" enum. * Change data structure to anticipate passing certificate chains instead of only leaf client certificate. Main goals behind those changes: * Avoid nested callback-in-event APIs that required custom binding code. * Switch to the generic term "algorithm" that is more appropriate than "hash" for newer schemes like RSA-PSS. * Pass unhashed data instead of prehashed, in order to be compatible with newer schemes like Ed25519. * Pave the way for providing more data from the middleware, like certificate chains or error codes. Bug: 1078761 Change-Id: Ie004974a578baafb13424b570920645d112b612d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246682 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Fabian Sommer <fabiansommer@chromium.org> Cr-Commit-Position: refs/heads/master@{#790797}
-
Yuki Shiino authored
base::CheckedPtr<T> should behave as if it's a raw pointer. When an implicit conversion from U* to T* is allowed, similarly an implicit conversion from CheckedPtr<U> to CheckedPtr<T> should be allowed, too. This patch supports such an upcast of CheckedPtr<T>. Bug: 1073933 Change-Id: I0b93c95f44cf27849a96ea14c2025fd3f4a5b7e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303409Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#790796}
-
Saurabh Nijhara authored
This CL fixes the following bugs as per UI feedback :- 1) Makes notification warning level as critical if time remaining is equal to less than one week in case of auto update expiration because the device would be blocked for further use post that. 2) Displays warning time (in the notification) in weeks. The logic of when to show time is weeks is kept simple at the moment. As discussed with UX need to show warning in weeks if number of day remaining is a multiple of 7. Bug: 1106768 Change-Id: I8d8049a69117b4c13c76dcff51c7248b64350c6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302760 Commit-Queue: Saurabh Nijhara <snijhara@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
-
