- 26 May, 2020 40 commits
-
-
Colin Blundell authored
This ensures that the autofill framework won't kick off autofill in the URL bar. The user could still manually trigger autofill by long-pressing on the URL bar and selecting the autofill prompt that pops up. That seems not necessary to fix as that flow will not be possible in the WebLayer embedder. If it were to be fixed, it would need to be fixed at the level of the shared AutofillActionModeCallback. Bug: 1083479 Change-Id: I468b7e729139747479b0f5f6a641a3345fc007af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212125Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#771715}
-
Yutaka Hirano authored
Bug: 1086353 Change-Id: I4613a1271a985a9e01b6652c34dcb27cb6f83859 Tbr: ricea@chromium.org No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215654Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#771714}
-
Alice Wang authored
This CL adds JNI code to open account picker bottom sheet in the web sign-in flow. Bug: 1041876 Change-Id: I3dcdeb0ae8ec9960362bae5ebcfbf2999d126bcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204021 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#771713}
-
Dominick Ng authored
Call TestWebAppProvider::Start() in the tests to stop the App Service waiting for web apps to be published. BUG=1082884 Change-Id: I051a43fa56e739e22e9b1a70e6edf58f0a49b600 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214587Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#771712}
-
Hitoshi Yoshida authored
This CL updates some IDLs to catch up each spec. There are no or tiny behavior changes. Bug: 839389 Change-Id: I7710fcb259e404608955545817fc38cb1f751d93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213660Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#771711}
-
Kent Tamura authored
This CL ports TextAlignmentForLine() and AdjustInlineDirectionLineBounds() of LayoutRubyBase and LayoutRubyText to LayoutNG. This CL doesn't affect production because new behavior is behind a disabled runtime flag. Bug: 1069817 Change-Id: I5e09f0a46ff505f15daccea11f13c66444dc9876 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214589 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#771710}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1c203f436263..17c11a2291ec If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yhirano@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: yhirano@google.com Change-Id: I1e96e97b230500e5af0f1fb289ad7c1e7bedf062 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215724Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771709}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8e61a29bd9b4..bd6ecc479f9e 2020-05-26 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2280600f8cfe4b0779c6e64e0bd077c42a8108c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215728Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771708}
-
Bence Béky authored
https://quiche.googlesource.com/quiche.git/+log/7f483b5ee54c..8aff71f6f3e1 $ git log 7f483b5ee..8aff71f6f --date=short --no-merges --format='%ad %ae %s' 2020-05-21 renjietang In QUIC, when TLS 0-rtt is rejected, disable early data in all cached session tickets that are associated with that server. 2020-05-21 dschinazi Introduce QUIC version draft-28 2020-05-21 dschinazi Modernize comments in quic_versions.h 2020-05-21 fayang Notify quic crypto client handshaker about connection close. client side only, protected by existing gfe2_reloadable_flag_quic_notify_handshaker_on_connection_close. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: Iec5b9db5b157b376d40832036d2406ab9d7f9e1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212937 Auto-Submit: Bence Béky <bnc@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#771707}
-
Phillis Tang authored
Fix WebAppBadgingBrowserTest to wait for service workers to be active before testing sending messages to sub app service worker. Bug: 1085547 Change-Id: Ie24b192b4d2f5654f300d935e11a50637df52ea4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213021 Commit-Queue: Phillis Tang <phillis@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#771706}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a11b55fed243..b5479f2a80cf 2020-05-26 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps 2020-05-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 10bf4a61 to 9f39a47c (208 revisions) 2020-05-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from c746ac65e9d6 to 7ff01bb15d40 (5 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1085627 Tbr: westont@google.com Change-Id: Iacf876570c6a44e577939ebe1b4f9ae29e1a8a69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215726Reviewed-by:
-
Marja Hölttä authored
Bug: v8:7193 Change-Id: I67da5487192d4a9bc4aa7a24fd340a7ed6e231a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214882Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#771704}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/34a30f39c0d1..f3393ea589ec 2020-05-26 dberris@chromium.org auto-bisect: Validate more input parameters If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC eseckler@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1086315 Tbr: eseckler@google.com Change-Id: I2040eb1880af53916bf23ba235dc77b7ed253b1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215722Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8f48f7c5. With Chromium commits locally applied on WPT: 9c36a269 "Reduce cross frame messages in feature-policy-nested-subframe-policy.https.sub.html" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: I03d7e41317c9fa6473383ce970e7dd144e107a21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215499Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771702}
-
sandromaggi authored
This adds unit tests for * IsCompleteContact * IsCompleteShippingAddress * IsCompleteCreditCard This change rearranges the |IsCompleteCreditCard| checks to be more easily understandable without changing the behaviour of the function as a whole. Bug: none Change-Id: I0ed6bc657737b69e362e588156d8befbbadacfd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214889 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#771701}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/d2af84ffde20..79dcb2a5abbd 2020-05-26 capn@google.com Document helper invocations being considered active If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I6026656fbaff9411ca9675ee095ea6244c5fea75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215571Reviewed-by:
-
Kinuko Yasuda authored
This inner class (URLLoaderRequestController) was introduced because the most of loading related code used to need to run on IO thread (while NavigationURLLoader itself needs to run on UI thread), while now everything can just run on UI thread. This change merges URLLoaderRequestController back to NavigationURLLoaderImpl. It looks like a lot more code cleanup can be made but leaving those TODOs in order to make the diff relatively cleaner. (The diff still looks a bit broken but no major changes are made in the existing code) Changed NavigationURLLoaderImpl's some method names too to avoid confusion (because now it also needs to have URLLoaderClient methods) * OnRequestStarted --> NotifyRequestStarted * OnReceiveResponse --> NotifyResponseStarted * OnReceiveRedirect --> NotifyRequestRedirected * OnComplete --> NotifyRequestFailed Bug: 1068896 Change-Id: I9d9dc5acf06816dc1bc73fd24a9b7ed4bb915dbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212189 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#771699}
-
Marc Treib authored
Also change the default value for its TTL parameter to 14 days (instead of 28), which is the value that's launching. Bug: 1034915 Change-Id: I0cef3d09878af50a4d465122f2ff8f84f4eccd99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214387 Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#771698}
-
Adam Rice authored
This commit updates the renderer to use mojo datapipe to transfer WebSocket mesasge to the network service, which later sends out the message with appropriate framing. It adds new ProducePendingData() and ProduceData() functions to write pending messages to the datapipe. It also adds mojo SimpleWatcher and OnWritable callback function in case when the data pipe is unavailable at the moment. This also updates the unittests to stop testing the quota system, and start testing the new datapipe transfer. This commit is a follow-up CL from the following CL: https://chromium-review.googlesource.com/c/chromium/src/+/2071189 Design Doc: https://docs.google.com/document/d/1YWj1z9r8wxemGdod6S2tkchudhp6PvNaH3qSO0oucfY/ This is a rebase of https://chromium-review.googlesource.com/c/chromium/src/+/2089564, originally by Keita Suzuki. Bug: 1056030 Change-Id: Ic57abc92b95dad0765c55945439ced5adaf227b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206556Reviewed-by:
-
Toni Barzic authored
When moving accessibility focus to home button, instead of just tapping the button, also send a kHover accessibility event. The hover event is generally sent after tap, but with a delay. ChromeVox expects the kHover event to properly recognize home button as the currently selected node, and to properly handle Search + R command (if the hover event is not received in time, the command will fail, and ChromeVox will report that no elements are focused - just as is the case in the reported test failures). BUG=1085875 Change-Id: I89de078ce623ad4b03ed8c6b32465f633dd6a4a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214606 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#771696}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e01c229a07aa..a11b55fed243 2020-05-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from cc5cda0f997d to 79dcb2a5abbd (5 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: westont@google.com Change-Id: Ie72c71347757e69c6f4dfb16628ea3a2ce9d58be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215573Reviewed-by:
-
Jit Yao Yap authored
Sync server-side changes from https://critique-ng.corp.google.com/cl/310015223, https://critique-ng.corp.google.com/cl/303392879, https://critique-ng.corp.google.com/cl/290992058, https://critique-ng.corp.google.com/cl/308723953, https://critique-ng.corp.google.com/cl/304090152, https://critique-ng.corp.google.com/cl/312266437 and https://critique-ng.corp.google.com/cl/313028916. Change-Id: I1faff600d862ddde984cc5c630ad5b6706102d2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214522Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Jit Yao Yap <jityao@google.com> Cr-Commit-Position: refs/heads/master@{#771694}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1590450490-dfe3a2767592cf1fef58c82e2923048de4d8a852.profdata to chrome-win32-master-1590465515-9ef099e12f3ab5051489e8b99894f13fb77c0985.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I77ee266312b8c6c5698d5dddd6fb1d487df4d1b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215580Reviewed-by:
-
Moja Hsu authored
This CL adds brightness, contrast, saturation, sharpness, pan and tilt support. built-in camera of eve. Test pan and tilt on huddly go camera. Pass CtsCameraTestCases on eve. Bug: b:148527288 Test: Test brightness, contrast, saturation and sharpness on the Change-Id: Id3d277889f0dde482cf8d546b7b226d1c0f0e5f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164347 Commit-Queue: Hsu Wei-Cheng <mojahsu@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#771692}
-
Yuki Shiino authored
Supports per-feature property installation on global objects, in which case properties need to be installed on platform objects rather than on prototype objects. Bug: 839389 Change-Id: Iff39ecac36caae3484f55e9aa9b979969f612494 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215381Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#771691}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1590436328-8ca81bf83e48383e494f6148a12f47de3c24866f.profdata to chrome-win64-master-1590465515-28d774c5c7210687b1a5c5f3f06bd85a638d1e44.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I7d610dd94b9820b01e6eab4752ee44e383cb5dc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215578Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes "click-in-margins-inside-editable-div.html" to utilize |selection_test()| for ease of maintenance and help to implementing EditingNG. Bug: 707656, 679977 Change-Id: I3e7ade497a40b0f0beb22a5213a2e02341f39f5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214593 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1590450490-b86845d32533b3cef7698719a5d33e1fd402b06c.profdata to chrome-mac-master-1590465515-790c6cf05617ff0779c93cfed8e1f71b6e306b53.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I73bd8a6706c432c9aec65287055f23e1788119cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215576Reviewed-by:
-
Yutaka Hirano authored
Bug: 1071189 Change-Id: I9b2d956d63268e9d8a21f5a216950a991775b6f9 Tbr: yosin@chromium.org No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215531Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/445b6ec24fcd..1c203f436263 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yhirano@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: yhirano@google.com Change-Id: I35cb4cf43fd5f7fa763a4933d4f3137ad0f2c25e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215570Reviewed-by:
-
Noel Gordon authored
After CL:2215150 toast button labels are shorter and do not take up too much space in the <files-toast> element display width anymore. Address the related TODO: apply CCS max-width to the container, per the files-ng design spec. Bug: 1002391 Change-Id: Ife0ed39509a03195dcd92d1025f8071a3c8901a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214810 Auto-Submit: Noel Gordon <noel@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#771685}
-
Kent Tamura authored
The content of the function was very small. This CL folds SelectType::DidSelectOption() into call sites, and makes it a pure virtual function. Note that ScrollToSelection() for MenuListSelectType is empty. So MenuListSelectType::DidSelectOption() doesn't need it. This CL has no behavior changes. Bug: 1052232 Change-Id: I1b483118546c15788d683b97e83da931619fe18b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215146 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Jiewei Qian authored
A low resolution clock could result in an install_duration of 0. This trips the DCHECK that |install_duration| is positive. This CL changes to this DCHECK to test for non-negative, so it won't be triggered when chrome is running with a low resolution clock. Fixed: 1085403 Change-Id: I63bf90ee6d287e09e0cbb955568f2ae3c2ffa0f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212237 Commit-Queue: Jiewei Qian <qjw@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#771683}
-
Kenichi Ishibashi authored
This CL partially reverts crrev.com/c/2214582 not to use |remote_storage_control_| yet. Looks like we need to bind the remote on a separate sequence. Bug: 1055677 Change-Id: I6c82d6c7150bd5405a92d5bac2ff0517f7aff925 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215386Reviewed-by:
-
Noel Gordon authored
Bug: 1002391 Change-Id: I8a85271e20c3d46bff851645bd0bc596feabb433 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215150 Commit-Queue: Noel Gordon <noel@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium e05bfc85. With Chromium commits locally applied on WPT: 9c36a269 "Reduce cross frame messages in feature-policy-nested-subframe-policy.https.sub.html" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: I116552a4af7e8aa17297d1a735134fa045f60425 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215410Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6789018a71c1..7ff01bb15d40 2020-05-25 j.vigil@samsung.com EGL: Add missing sync entry points 2020-05-25 jonahr@google.com GL: Entry points for GL_OES_texture_cube_map_array If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: I43c71b50f6693c398923aa9f771d76282ac6db92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212639Reviewed-by:
-
Hitoshi Yoshida authored
Bug: 839389 Change-Id: I9cb055a6b2c7c4072516ccc6a18282c78bba0765 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215387 Auto-Submit: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Omid Tourzan authored
Add a FilesTransferDetails flag to support toggling of file transfer details feature. Flag is disabled by default with milestone expiry set to M88. Bug: 953308 Change-Id: I5101e5331824898485eb72fa4f13484e38aad692 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212119Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: I3513d21c4af320700269118b3b573a794125a6c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154356 Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Reviewed-by:
-
