GitLab

The non-const parameter was causing issues with ubsan because ANGLE is
compiled with lasted typedefs.

BUG=820848
TBR=piman@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I366e101fb8c42edec1d381e27cb55a51283f4e09
Reviewed-on: https://chromium-review.googlesource.com/969083Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545858}

Shrinks monochrome_apk dex by 53kb uncompressed, 17kb compressed.
Shrinks method_count by 1400.

Bug: 620323
Change-Id: Ie9f7c37a20895ecd1d3f1f17357a663252a1be36
Reviewed-on: https://chromium-review.googlesource.com/981052Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545857}

TBR=ashleymarie@chromium.org
NOTRY=true

Bug: 825224
Change-Id: Ifd87513095452f298ac9bf5ba5e44dd1f59c94df
Reviewed-on: https://chromium-review.googlesource.com/981128Reviewed-by: Emily Hanley <eyaich@chromium.org>
Commit-Queue: Emily Hanley <eyaich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545856}

Change-Id: I19d2d75acb589d0e1af6562cdd84ab3c75abd0bc
Reviewed-on: https://chromium-review.googlesource.com/979772Reviewed-by: Patrick Noland <pnoland@google.com>
Commit-Queue: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545855}

This DCHECK was made obsolete by
9b88406d, since it stopped using the
"pending resource" flag for <use>.

Bug: 825460
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ie1202097eb2172ef9ed3866e3a6575fbe4aa09db
Reviewed-on: https://chromium-review.googlesource.com/980252Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#545854}

This CL migrates FirstRun and sign-in activities to support library
fragments (android.support.v4.app.Fragment instead of
android.app.Fragment).
Rationale for this migration:
1. Framework version of fragments are getting deprecated in Android P.
2. Enables use of getChildFragmentManager, getParentFragment, etc., on
all API versions.

Bug: 825789
Change-Id: I2079f211b03e4df1d169c1568d764763bb677bd1
Reviewed-on: https://chromium-review.googlesource.com/980335Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545853}

Fixes two VR test failures:
1. MockVrDaydreamApi not working properly.
2. DeepLinkedApp tests getting stuck in relaunch loops due to
    the relaunch logic not working properly with the DON flow
    skipped.

Bug: 825248

Change-Id: Iee43fc55f8160bb4fdbbc4f60de8b67f64a3d8e9
Reviewed-on: https://chromium-review.googlesource.com/978887
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545852}

We need a ProcessManager to exist in order to load background
pages but like everything extension-related it is lazy created

Bug: b/73768170
Test: load extension at start verify background script prints occur


Change-Id: I63ccc58ee819ec0435646c296ceb0d7678c433cc
Reviewed-on: https://chromium-review.googlesource.com/959343Reviewed-by: Kevin Schoedel <kpschoedel@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Albert Chaulk <achaulk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545851}

This test is failing consistently on Android in addition to having been
flaky on Linux when the Network Service flag is enabled:

* ResourceDispatcherHostBrowserTest.PageTransitionClientRedirect

Bug: 818445
Change-Id: Icf555652a3c78126e28753bfc2e7b8878fe47460
Tbr: jam@chromium.org
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/981123Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545850}

Bug: None
Change-Id: I4bb6b63d8b47c281d644f24702100a23b33c029f
Reviewed-on: https://chromium-review.googlesource.com/979032
Commit-Queue: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545849}

Otherwise, EXPECT_CALL macros tend to get ugly quickly.

Bug: None
Change-Id: I24584a7ea0d4ec324b84c7c55cf313a4407da419
Reviewed-on: https://chromium-review.googlesource.com/980533
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545848}

Prior to this CL, both ui::Compositor and DelegatedFrameHost used the
same ParentLocalSurfaceIdAllocator to allocate LocalSurfaceIds. This is
technically not incorrect, but it's super confusing when debugging.
Each embedding should have a different embed_token (previously called nonce),
and this violated this (untested) assumption.

This CL fixes that. This CL also drops the class member variables that store
the LocalSurfaceId for ui::Compositor and DelegatedFrameHost because the
ParentLocalSurfaceIdAllocator instead tracks the last ID.

Bug: 672962
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I0c4f1810045272b52b037bd263c5dd906c983f8f
Reviewed-on: https://chromium-review.googlesource.com/976743
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545847}

While doing stylus button text selection, focus is mainly
on the stylus button press and text selection is anchored
by the stylus button. In that case touch handle has less
significance (same with touch long press drag selection).
So we can hide touch handles during stylus button selection
and can show after stylus button selection is concluded.

Bug: 771667
Change-Id: I9dccaabfd5fafccb68c1f0bce23bba36cea9061f
Reviewed-on: https://chromium-review.googlesource.com/685054Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: AJITH KUMAR V <ajith.v@samsung.com>
Cr-Commit-Position: refs/heads/master@{#545846}

This allows a LayoutChild to have layout performed on it, which will
return a Fragment - with the correct inline and block sizes.

These Fragments cannot be positioned yet, (next patch).

The LayoutChild will be laid out with an available inline/block size of
zero by default, and optionally can accept a fixed-inline/block size,
which it must respect.

Bug: 726125
Change-Id: Ie4386b8f6cd6ccec3f9e52ff332322101058836d
Reviewed-on: https://chromium-review.googlesource.com/962870
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545845}

This method just returns a member since r544824.

Bug: 813232
Change-Id: I7e8ee5e33b559f0fca0c5ee3f2cb7dc9837458a0
Reviewed-on: https://chromium-review.googlesource.com/980825Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545844}

Adds Async TraceEvents to track the splashscreen and how long it is
visible.

Bug: 822816
Change-Id: I9a75001830d36cb7f0a35d0cb4d04511242d74fd
Reviewed-on: https://chromium-review.googlesource.com/978453Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Dmitry Skiba <dskiba@chromium.org>
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545843}

CustomFrameViewAsh uses this mmode to turn on/off, enable/disable
buttons on caption.

Close button is always on for now. I'll have to investigate if this
has to be enabled for ARC++ apps.

BUG=822960, b/33693796
TEST=Covered by unit tests.

Change-Id: I67fe2278b255ecd81e800209c52d51f9b4a3eb78
Reviewed-on: https://chromium-review.googlesource.com/975422Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545842}

Chanes:
The entire tray_accessibility_browsertest.cc should be moved to ash/.
This CL is one step closer.

Bug: 594887
Test: trybot tests
Change-Id: I503065ce0f371260272b7da44541a83a8a89bdeb
Reviewed-on: https://chromium-review.googlesource.com/979705Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Qiang Xu <warx@google.com>
Cr-Commit-Position: refs/heads/master@{#545841}

This CL makes the lightweight FRE use a DualControlLayout for the
buttons. This causes the buttons to stack vertically if there
is not enough room for the buttons to be side by side. The button
text in Ukranian is too long for the buttons to be side by side.

BUG=821051

Change-Id: I87fa04dc36f7efe74967723f5bc09f54c1caf8ec
Reviewed-on: https://chromium-review.googlesource.com/974294
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545840}

The test NonBlockingEventBrowserTest is an overloaded term. The test actually blocks
the Renderer's Main Thread, via its own javascript event handlers. It does this
 in order to verify the compositor sending an INPUT_EVENT_ACK_STATE_SET_NON_BLOCKING.
As well as to force scrolling to be handled by the Compositor on the Impl thread.

This name is confusing, and makes debugging difficult. Especially as some test
utils rely on sending IPC::Messages to the Renderer from the Browser. These IPCs
are recieved by the Main thread. If that thread is blocked the testing utils
never get processed.

TEST=CompositorEventAckBrowserTest

Change-Id: Id498be917400373830b3661045f75bcdc29f26ae
Reviewed-on: https://chromium-review.googlesource.com/978789
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545839}

The scrim needs to obscure different views depending on which view
triggered it. In the case of the bottom sheet it needs to cover the
top toolbar, but it shouldn't cover the toolbar when the omnibox is
focused.

This change temporarily moved the scrim in the view hierarchy while
the bottom sheet is open so that it covers the top toolbar. When the
sheet is closed, it is moved back to its original position.

BUG=824432

Change-Id: Ic7e462b09aeb02eae51c725dc811eaf66f2d1c6f
Reviewed-on: https://chromium-review.googlesource.com/973889
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545838}

BUG=internal b/76197553

Change-Id: Ib8e564a8503b1a4941222c6e59584d632ba96264
Reviewed-on: https://chromium-review.googlesource.com/979292
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545837}

ResourceDispatcherHost pushes pending load state of all frames to the UI
thread once every 250 milliseconds when there's a pending load.  This
happens even when the UI thread is blocked.  Apparently it's causing an
OOM when the UI thread is blocked.  Whatever is blocking the UI thread
is another issue entirely, but we shouldn't use unbounded memory in the
browser process.  This CL prevents load state updates from being sent
until the previous set was ACKed by the UI thread.

This is a reland of https://chromium-review.googlesource.com/978383,
which was reverted in https://chromium-review.googlesource.com/979674
for causing crashes after the RDH was shut down (Which should now be
fixed).

Bug: 824869
Change-Id: I84e594baefa6b246898e7df77abddaaa1a66fa0c
TBR: jam@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/980593
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545836}

The weekend canary branching failed, so it needs to be manually brought back in
sync for another run.

R=govind@google.com

Bug: 825555
Change-Id: Ifedb6c4a72bd58e3da9d855375a7563df343b52d
Reviewed-on: https://chromium-review.googlesource.com/981113Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545835}

https://w3c.github.io/webauthn/#sec-assertion-privacy says that we
should be careful that sites can't probe information about
authenticators.

In this case the user has touched an authenticator for a registration
but denied consent to supply direct attestation information. Currently
we let the registration timeout. But with this change we'll return an
error to the site immediately.

Change-Id: Icccbdb4f3b56824d2ea5114e7edae4db988f36f9
Reviewed-on: https://chromium-review.googlesource.com/978951Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545834}

Bug: 734095
Change-Id: I936ce7cba93d5c0d3a895c287325167bb6b8f754
Reviewed-on: https://chromium-review.googlesource.com/978588Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545833}

This makes the wayland server instance keep track of when
displays are added and removed. wl_output globals are created
and destroyed in order to match the current display
configuration.

Bug: 824449
Change-Id: I99a3642cda2b1e3c868988738c531172d2db83ed
Reviewed-on: https://chromium-review.googlesource.com/979614
Commit-Queue: David Reveman <reveman@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545832}

Auto-resize could cause a surface invariants violation in the following
case:

1. RenderWidget issues an auto-resize of size A1.
2. RenderWidget allocates a sequence number and tells RenderWidgetHostImpl about size A1.
3. RenderWidgetHostImpl gives RenderWidget a LocalSurfaceId for size A1.
4. RenderWidget tells the compositor about size A1 and LocalSurfaceId A1.
5. RenderWidget issues an auto-resize of size B (clears the LocalSurfaceId in the compositor).
6. RenderWidget issues an auto-resize of size A2 (same as A1).
7. RenderWidget allocates a sequence number and tells RenderWidgetHostImpl about size A2.
8. RenderWidget issues an auto-resize of size C (clears the LocalSurfaceId in the compositor).
9. RenderWidgetHostImpl gives RenderWidget a LocalSurfaceId for size A2 (same as A1).
10. RenderWidget tells the compositor about size C and LocalSurfaceId A1/A2.
11. BOOM! Surface Invariants Violation! cc is using LocalSurfaceId A1 for both size A1 and C!

This is a typical ABA style problem because on Mac we will not allocate a new LocalSurfaceId
unless the size actually changes. This CL solves the problem by allocating a new sequence
number every time the size changes from the perspective of the renderer, that way we can
map each LocalSurfaceId to a particular resize despite resize throttling happening.

Bug: 672962
TBR: piman@chromium.org
Change-Id: I6e7c0ccef3e2a478a5cc2544533487696374d672
Reviewed-on: https://chromium-review.googlesource.com/976809
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545831}

The backend requires this value to be set even though it is unused for
CrOS. This fixes device enrollment.

Bug: 76096024
Test: None, but E2E tests will be added shortly
Change-Id: Idbfcb61294f420a8eedf612d262b41df0428e432
Reviewed-on: https://chromium-review.googlesource.com/980814Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545830}

Bug: chromium:757440
Change-Id: Ie8a5d0ee4f311514e18603ae0ce643f0623a253f
Reviewed-on: https://chromium-review.googlesource.com/980212
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545829}

Show clusters of suggestions using TreeNode's.

BUG=822942

Change-Id: Ifaaf90cfe8dd2247588b3efcf3db50e982047119
Reviewed-on: https://chromium-review.googlesource.com/978625Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545828}

The component doesn't exist when the VR build flag isn't set, like on
x86 builds.

Bug: 825839
Change-Id: I396adac0b3d7cb4cff4a06de657017de8bb3bac6
Reviewed-on: https://chromium-review.googlesource.com/980715
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Yash Malik <ymalik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545827}

The SitePerProcessHitTestBrowserTest helper functions to set the
screen position from a position in a widget are incorrect when the
point is not in the coordinate space of the root.

Bug: None
Change-Id: I8e2c2e21f50fb61c0f41265383d23774e432e60e
Reviewed-on: https://chromium-review.googlesource.com/973547Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Ria Jiang <riajiang@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545826}

Change-Id: I4a7333eeb228e825a78ba5bc84a4cb5f7531ef42
Reviewed-on: https://chromium-review.googlesource.com/979737Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545825}

This avoids hitting the DCHECK in WorkletAnimation::WorkletAnimation in
the case where --disable-threaded-animations is specified.

Bug: 825127
Change-Id: I5e2eb0684e472d5a88f40ad07f19f73c0118b627
Reviewed-on: https://chromium-review.googlesource.com/980234Reviewed-by: Majid Valipour <majidvp@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545824}

This patch adds the base direction to NGPhysicalLineBoxFragment.

The base direction is also known as the paragraph direction, and
explained in [UAX#9].

While this is computed and used in layout, it turned out that
selection and editing needs this value.

[UAX#9]: http://unicode.org/reports/tr9/

Bug: 636993
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I2888d36bef7f465f4afacf11e5ca52f6418221a4
Reviewed-on: https://chromium-review.googlesource.com/980393Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545823}

This does C++11ification.

This also does a partial Callback cleanup, only of the instances
where it was obvious what they were. Further cleanup is
left for later.

This also removes ancient cleanup code that has been
cleaning up profiles for 4.5 years now. All the profiles
have been cleaned up by now.

BUG=295882, 714018

Change-Id: I26da23e1a49aa0f776ec1f9ca1310d9254dee3af
Reviewed-on: https://chromium-review.googlesource.com/979613Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545822}

Badges no longer support opacity settings on colors.
Updated documentation to reflect this.

Bug: 623573
Change-Id: I850e3f91980e2ab74efaf795c00cdcdbb749315d
Reviewed-on: https://chromium-review.googlesource.com/979072Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Crystal Lambert <crystallambert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545821}

Skia currently dumps wrapped objects, and Chrome tries to alias these
objects with Chrome's own dumps. This isn't always possible, so instead
this change uses a new Skia API to ask Skia to skip dumping these.

Bug: 795358
Change-Id: Iee3dbbb09037cb84fa8a33f0512cb2a54ef42f32
Reviewed-on: https://chromium-review.googlesource.com/979773Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545820}

This reverts commit 3e261e9b.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 545798 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzNlMjYxZTliMDBlZWI4YTA4MTJkNDc2OGIxN2FhYjMyNDkzODhhNzEM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium/Android/83350

Sample Failed Step: compile

Original change's description:
> Android: Add extra fields related to resources to crash reports.
> 
> This CL adds two fields to Android crash reports. Specifically:
> 1. custom_themes: Whether or not the user has apps installed for using
> custom themes. This should help debug obscure resources related
> crashes.
> 2. resources_version: The product version as stored in resources.arsc.
> This should help us detect if we tried to load resources from the old
> apk during an update.
> 
> Bug: 820591
> Change-Id: I1e2b36ec5640bb1376f83452851eaa5319d0f32f
> Reviewed-on: https://chromium-review.googlesource.com/969597
> Commit-Queue: Eric Stevenson <estevenson@chromium.org>
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Reviewed-by: agrieve <agrieve@chromium.org>
> Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#545798}

Change-Id: I05779ad74a74437faed311583f7249f0e60614b2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 820591
Reviewed-on: https://chromium-review.googlesource.com/981012
Cr-Commit-Position: refs/heads/master@{#545819}