- 06 Dec, 2019 40 commits
-
-
kylechar authored
Three tests are flaking, mark them as flaky until root cause can be investigated. Bug: 965268, 1031095, 1031567 Change-Id: I8b0a85f1385250abca8264278ec2dcd97531dcba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956017 Commit-Queue: kylechar <kylechar@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Auto-Submit: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#722668}
-
khmel@chromium.org authored
This removes marking window as ARC app from shelf to exo which owns ARC window. Now all such operations are centralized in exo. TEST=ARC functionality is preserved. unit tests BUG=None Change-Id: Iaa7205733b2299ce7986a19f984e498dced50ccb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955818 Commit-Queue: Yury Khmel <khmel@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#722667}
-
Vladimir Levin authored
This fixes a bug that happens in an interplay of find in page and mutating locked subtrees. We don't paint the subtree, and the DCHECK happens during the self painting phase of the element. This change ensures that the DCHECK is aware of display locking. R=chrishtr@chromium.org Change-Id: Ib58adaffab9e11d2d813fe54a56ea3aa72ddfd32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956038 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#722666}
-
Michael Spang authored
The IS_CHROMECAST define is declared in 16 different places, which is risky especially if the define is used in a header file. Move this to a common buildflag header in //build, alongside the chrome branding flags. This flag needs to be in a widely scoped location, since we don't know if we're allowed to use //chromecast until we check the flag's value. OS_CHROMEOS uses a global #define for this, and that would work here, but global ifdefs are discouraged. There are few enough uses of IS_CHROMECAST that having explicit dependencies on a buildflag header isn't too onerous. No functional change. Bug: 1030969 TBR=kylechar@chromium.org, dgozman@chromium.org, benwells@chromium.org, kbr@chromium.org, dalecurtis@chromium.org, reillyg@chromium.org, foolip@chromium.org Change-Id: I48d9ffccde7e7a680ce572f15a8ba1ef11adcc6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951981 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#722665}
-
Avery Musbach authored
is_previous_layout_right_side_up_ shall be updated for clamshell/tablet transition, even in cases where OnDisplayMetricsChanged is not called. Fixed: 1029181 Change-Id: I9706c4273de1e632da01e019d54a825b39acd219 Bug: 1029181 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948918 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
-
Devlin Cronin authored
Create a new class, ExtensionActionViewControllerUnitTest, which subclasses ToolbarActionsBarTest, and add common utility methods in that test class. Also move ToolbarActionsBarTest::SetActionWantsToRunOnTab() to this new class, as it was only used in these tests. This reduces a lot of the repeated boilerplate code in the ExtensionActionViewController related unittests, and will make adjusting them for the ExtensionsMenu behavior easier. No behavior change is expected. Bug: 984654 Change-Id: Ic85832939187d04dd64ff0e9ef995cd86a8f5925 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940881 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#722663}
-
Adrienne Walker authored
As a part of moving to storage service, the indexeddb code can't depend on BrowserThread::IO and will need some other new IO thread. To handle this, the idb context now exposes an IOTaskRunner (which for now is still the browser IO thread) which is plumbed everywhere that is needed. Change-Id: Idef64cb47ab4483b2584ce6d7b19aee25d6add18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954724Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#722662}
-
Sven Zheng authored
https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29 https://ci.chromium.org/p/chromium/builders/ci/ToTWin%28dll%29 They don't fail anymore for CleanerSandboxInterfaceTest. So consider the fix works. I don't see it's necessary to make the resetacl more general(i.e. pass in base::FilePath) for now. But it is in a general place. Let me know if a general signature is favorable. Bug: 956016 Change-Id: I870e01dfa62a09ada372985dc5d9c9dcdc01b328 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956145 Commit-Queue: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#722661}
-
Peter Boström authored
Uses the ExtensionsContainer interface instead of ToolbarActionsBar to show NTP and DSE warning bubbles. This fixes crashes (DCHECKs) when using DDG or other default-search-engine extensions. This also adds the NTP extensions trigger to ExtensionsToolbarContainer which was used to be able to verify the fix on Linux. Bug: chromium:985834, chromium:999100 Change-Id: I42b884f2ba7b1978be52daf194abe24f21f453de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956078 Commit-Queue: Peter Boström <pbos@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Auto-Submit: Peter Boström <pbos@chromium.org> Reviewed-by:
Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#722660}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7471ec58dc43..dca1c7eb4884 Created with: gclient setdep -r src-internal@dca1c7eb4884 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1024588 Tbr: jbudorick@google.com Change-Id: I7a03802ecbc17a75b65bc5c44dd484868dd22cc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956019Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#722659}
-
Alex Cooper authored
The OpenVR SDK has made some changes that we need since the last time it was updated. Primarily, this is the addition of the method: GetAppContainerFilePaths and a few other updates intended to allow the SDK to work better in the AppContainer version of the WebXr device process. Some prototyping will still need to be done before this can actually be achieved, but doing this first roll better enables that and sets up a (hopefully) smaller diff if another roll is needed due to any issues discovered during prototyping. Fixed:845255 Change-Id: I6f9af21df282b3fe90cd9855aefd4b4ff9cc3c56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935411Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#722658}
-
Sean Harrison authored
Changes between reland 1 and reland 2: 1.) Added lazy load ensure load to relevant privacy subpage tests. > Changes between original submission and reland: > 1.) Privacy-page subpages are now in lazy_load.html > 2.) Fixed bug that erroneously showed "privacy" in the settings menu of "Guest" mode settings. > 3.) Fixed bug where going to chrome://settings/clearBrowsingData didn't work unless the advanced section was expanded when the flag for this change was disabled. > 4.) Reordered a few settings rows to match the most current mocks. >> Revert "Friendly Privacy Setting Initial Redesign" >> This reverts commit 544412a4. >> Reason for revert: Performance and functional regressions >> https://bugs.chromium.org/p/chromium/issues/detail?id=1024034#c5 >>> Original change's description: >>> Friendly Privacy Setting Initial Redesign > >>> This CL does 3 things: > >>> 1) The order of rows in the privacy page is affected, regardless of the value of the "privacySettingsRedesignEnabled" flag. > >>> 2) The privacy-page is moved to the "basic", only when the "privacySettingsRedesignEnabled" flag is on. > >>> 3) A "more" expansion button is introduced in the privacy-page only when the "privacySettingsRedesignEnabled" flag. >>> Bug: 1014143 >>> Change-Id: I678e81aa3b67acd2ae41eeda355cd3b32a5b4088 >>> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872094 >>> Commit-Queue: Sean Harrison <harrisonsean@chromium.org> >>> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> >>> Cr-Commit-Position: refs/heads/master@{#714287} Change-Id: I127cdd31a404f4c7df0d75650e762536fcefd053 Bug: 1031520 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950954 Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#722657}
-
Jun Mukai authored
Lots of warning messages started appearing, and it turns out that the existing 'code' subcommand was deprecated. Simply using private-code would be good enough. Bug: 1030484 Test: build Change-Id: I0c73c003de7a31d1b324170da37cdc3dacd022a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955908Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#722656}
-
Tommy Li authored
This is a reland of 197dd2b5 This is an unedited reland. The old one was reverted because of a crash, but this CL should fix the crash, making this reland safe: https://chromium-review.googlesource.com/c/chromium/src/+/1955787 Original change's description: > [omnibox] ZeroSuggestProvider: classify search results w/ input text > > Currently, when we get search suggest results back from > ZeroSuggestProvider, nothing is bolded. This is inconsistent with > as-you-type search suggestions. > > The root cause is that we purposely set AutocompleteInput::input_text > to an empty string for all ZeroSuggest queries, to avoid leaking the > user's current URL. (The URL is separately included in eligible). > > The lack of bolding is an unintended side effect. > > This CL fixes that, by re-classifying all the search suggest results > that come back with the real input text on the client side. > > This is primarily intended to improve On Focus Query Refinements, > but this will affect all ZeroSuggest modes that return search results > from a non-empty omnibox. (Should not affect NTP). > > Note nothing is bolded at all when the input text is empty (on NTP). > > Navigational suggestions are not affected by this CL. They are > currently not bolded at all. > > Bug: 963173 > Change-Id: I7982c780f4b03f3d2b4992051d291fe1cd86f4b7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947765 > Reviewed-by: manuk hovanesian <manukh@chromium.org> > Commit-Queue: Tommy Li <tommycli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#721114} Bug: 963173 Change-Id: I4a6d1195a47cab19ef4cc9e1b3756e3f6ab9f20c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954250Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#722655}
-
Steven Bingler authored
For every cookie included in a request log metrics on the scheme that the cookie was set by relative to the scheme of the request url. Bug: 1028984 Change-Id: Icce3970a7cfe5212d4059e3e1256db633fb451c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938035 Commit-Queue: Steven Bingler <bingler@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#722654}
-
Sergey Ulanov authored
Now integration tests will launch WebEngine with --enable-logging=stderr and dup it's own stderr to WebEngine. Bug: 1009099 Change-Id: I9b0e15f22fc7a758ccdc5e78a3548a34bca6651d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956225 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#722653}
-
liberato@chromium.org authored
D3D11VideoDecoder is crashing periodically with a null |decode_cb_|. It's unclear how this is happening. This CL checks for the null callback and skips it, to prevent the crash. It also adds some debugging that hopefully will tell us where the null callback is coming from: - Provided to Decode() - Popped off the buffer queue in DoDecode - Cleared elsewhere Bug: 1012464 Change-Id: Idc4eb1842aa98989b9ceea30ed5aa769f0a63ce6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954735Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#722652}
-
Vikas Soni authored
6 pixel video tests are now expected to pass on SkiaRenderer Vulkan for android after some bug fixes. Hence removing them from test expectation. Bug: 991291 Change-Id: Ifc98a2b674dbd27c3980df6e69b139201eaa58dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954258Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#722651}
-
Oriol Brufau authored
These tests use properties that are not currently allowed by the spec. Therefore they are not part of the basic ::marker functionality. BUG=1031667 Change-Id: I79743233bdcee10715bf34bca56c49c7168832b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955729Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#722650}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/f3883e32a739..170f685582e1 git log f3883e32a739..170f685582e1 --date=short --first-parent --format='%ad %ae %s' 2019-12-06 kmoon@chromium.org Add utility for filter-encoding PDF streams 2019-12-06 patrik@pspdfkit.com Allow reading font name from Windows `name` table entry. Created with: gclient setdep -r src/third_party/pdfium@170f685582e1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I15c3c786e6b81d1c17a27aa69951c8aaee3adfef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956084Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#722649}
-
Chris Lu authored
This change adds TranslateInfobarMetricsRecorder, which will be used by the Translate Messages logic to log Translate-specific Modal and Banner events. This change also replicates existing Translate histogram metrics logging in the TranslateInfobarController in InfobarTranslateCoordinator. Those histograms are moved to the translate_constants file. Bug: 1014959 Change-Id: I72fcb71569017a5d3d15f42bd19cf901a260411f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949730 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#722648}
-
Elly Fong-Jones authored
Here is the overall plan of attack here: Currently, there are three key classes: * ExtensionInstalledBubble is a BubbleDelegate (bad) * ExtensionInstalledBubbleUi is a BubbleUi (bad) * ExtensionInstalledBubbleView is a BubbleDialogDelegateView (good) The ideal end state is that all clients of ExtensionInstalledBubble directly use ExtensionInstalledBubbleView instead, and then the former two classes are deleted. To get to that state, we: 1) Iteratively break every dependency from EIBV to EIB or EIBU, so that eventually an EIBV can be constructed without an EIB or EIBU - we do this by passing data from the EIB or EIBU into the EIVB's constructor directly so that it has it without asking the EIB. 2) Once EIBV does not depend on EIB or EIBU, make EIBV public (promote it into a header file), then have ShowExtensionInstalledBubble (the only non-test entry point to EIB) call EIBV directly 3) Delete EIB & EIBU :) Bug: 496955 Change-Id: Ic013bf89badf507d13599ff92ebc50b6afa50f58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954739Reviewed-by:
-
Antonio Gomes authored
This CL merges web_rtc_stats.h into the rtc_stats.h, and deletes it. The former is a collection of adhoc testing and production method declarations, as well as an alias, solely used within Blink. It is the last web_rtc_xxx.h header in the Blink API layer, finally being moved down to renderer/. BUG=919392, 787254 R=guidou@chromium.org, haraken@chromium.org Change-Id: I057fb72f474cecc79fb7d067deb2e351719f9116 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953386 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#722646}
-
Xida Chen authored
Currently the number of throughput UKM reporting is un-expectedly low on canary channel. We suspect that the sampling logic could cause that. This CL removes the sampling logic. Once we confirm that the reason is the sampling, we will likely invent another sampling logic. Bug: 1029964 Change-Id: I104de8f63ef261a72a9d93edeae2fd62a8235e3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946872Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#722645}
-
Etienne Bergeron authored
Remove the ICU iterator and use the precomputed graphemes from RenderText. The precomputed graphemes are landed here: https://chromium-review.googlesource.com/c/chromium/src/+/1945277/ Bug: 1025561 Change-Id: I9680250b24c00de9399e243b0d8a1ee9aca11a0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952026 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#722644}
-
Michael Spang authored
This is a reland of 4430b4c3 Original change's description: > display: Deduplicate display transform code with overlay transform code > > Display rotation transforms are a subset of overlay transforms, so we can > reuse OverlayTransformToTransform to compute display rotation matrices. > > Bug: 1019015 > > Change-Id: I95d099323cb866ccc4b9cea404e1e6f8f2dfff65 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913604 > Commit-Queue: Michael Spang <spang@chromium.org> > Reviewed-by: Khushal <khushalsagar@chromium.org> > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Reviewed-by: Mitsuru Oshima (OOO - back on Dec 2nd) <oshima@chromium.org> > Cr-Commit-Position: refs/heads/master@{#717832} TBR=oshima@chromium.org,sadrul@chromium.org,kenrb@chromium.org,kenrb@chromium.org Bug: 1019015 Change-Id: I3eaa7819971e9ebd51329f22506cb6bb905d429a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931131 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#722643}
-
Elly Fong-Jones authored
This change: 1) Removes BubbleController::GetName and its various implementations 2) Removes BubbleController::GetVisibleTime and its various implementations 3) Cleans up ExtensionInstalledBubbleBrowserTest to not depend on GetName Bug: 496955 Change-Id: Iee271ea4d4dbae96f8dd77e2ce2be87bd36ecc3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954260 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#722642}
-
Ana Salazar authored
Report animation smoothness for the transition into the hotseat in the HomeLauncher. The original change caused use-of-uninitialized-value flaky tests. These were caused because the HotseatTransitionAnimator could outlive the ShelfWidget in some tests. This is a possible fix for the issue by avoiding the destruction of |hotseat_transition_animator_| until the Shelf Widget is destroyed, thus destroying the animator itself. Shelf Widget destruction occurs usually after Shutdown(). Original CL: http://crrev.com/c/1917941 Bug: 1022178, 1022177, 1028255, 1030222 Change-Id: Ibf2030df7408704e8aa96ca863bcd55ba333174f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954355Reviewed-by:
-
Xiaoqian Dai authored
This CL fixed two issues: - The window jittering issue during dragging. It's because on Krane, we can still get small scroll update events even the finger is still. To avoid the window jittering, we only update the window if the scroll update value is large enough. - Overview never fade in issue. It's caused by the same reason. The small scroll update event will restart the show-overview-timer each time the event comes in thus prevent overview from showing up. We only restart the time if the scroll update value is large enough. Bug: 1031382, 1031381, 997885 Change-Id: Ie1f4ad0d6b504f12e2d9ccc9f73cc54c7169d716 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955906 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
-
Andrew Luo authored
Bug: 1019521 Change-Id: I3a4e75f5d640760268435766bdd7efc2fa1c36f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941072Reviewed-by:
Luke Z <lpz@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#722639}
-
llin@chromium.org authored
Bug: b/144316700 Test: manual test Change-Id: I5b0abdfe3358a2416a213bf0661cac560869b312 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955803 Commit-Queue: Li Lin <llin@chromium.org> Reviewed-by:
-
Kurt Horimoto authored
This is provided alongside OverlayRequests added to request queues and manages cancelling the request if its corresponding InfoBar is removed from its InfoBarManager. Bug: 1030357 Change-Id: Ic6644864cb7a5f6a89cca7b84baa090258415dea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951723 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
-
Renjie Tang authored
Data frames will now be coalesced into one. Change-Id: Ibd65d7098cbb81d96d1325333867892cd3ce2c4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956008Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#722636}
-
Sergey Ulanov authored
crrev.com/722312 added the service to most .cmx files, but missed tests-with-exec.cmx . Bug: 1027048 Change-Id: Ic5a0dd85ea5b7b0c483f9466006f5d7ec6983fd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956004 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#722635}
-
Aran Gilman authored
Change-Id: I50943050017711479968fb1359af05d15f0199bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931538Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Aran Gilman <gilmanmh@google.com> Cr-Commit-Position: refs/heads/master@{#722634}
-
chrome://componentsDemetrios Papadopoulos authored
- Moving ComponentsDomHandler to its own .h/cc files, and renaming to ComponentsHandler. - Moving some logic from ComponentsUI to ComponentsHandler so that proper lifetime methods (OnJavascriptAllowed/Disallowed) can be leveraged. This is in preparation of migrating this page to JS modules. Bug: 1028829 Change-Id: I530c439b3e659f3b1b5e5dc3ef05f2a3df88559e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939893 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#722633}
-
James Cook authored
Chrome OS SplitSettingsSync has a separate control for syncing OS data types that isn't controlled by the browser's sync-the-feature. Change ModelType::PRINTERS and WIFI_CONFIGURATIONS to run when the transport layer is enabled when kSplitSettingsSync is enabled. They already have checks for the OS sync feature being enabled. Bug: 1013466, 1031549 Test: updated sync_integration_tests Change-Id: If7fae05bda53bb68d2bcde0ce2fab6a9a7f7d416 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954361 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#722632}
-
Daniel Murphy authored
Bug: 1027737 Change-Id: I6afe294f787a2450516e5a9728e2ec1798e5cd83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955823 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Auto-Submit: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#722631}
-
Avery Musbach authored
Overview and clamshell split view shall end if you double click the edge of the split view window where it meets the overview grid. Fixed: 1006950 Change-Id: I24c1901814724cf24275e947749baf5a408bb648 Bug: 1006950 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951124 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#722630}
-
Aga Wronska authored
AppActivityRegistry class is responsible for: * collecting information about app state and usage * combining app usage information with restrictions from policy * storing the data between the sessions This changelist creates the skeleton of the class and will be followed with remaining functionality implementation. Bug: 1015658 Change-Id: I306830f756c974371551493379f6edb510f6e5c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954448Reviewed-by:
-
