GitLab

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e90e5fe206c9..f3c5fefedbf9

git log e90e5fe206c9..f3c5fefedbf9 --date=short --no-merges --format='%ad %ae %s'
2019-10-03 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-10-03 ehmaldonado@chromium.org git-cl: Clean-up
2019-10-03 ehmaldonado@chromium.org git-cl: Better warning message for legacy buckets.
2019-10-03 ehmaldonado@chromium.org depot_tools: Run git_footers_test on Python 3.
2019-10-03 ehmaldonado@chromium.org depot_tools: Run git_common_test in Python 3
2019-10-03 ehmaldonado@chromium.org git-cl: Set CC from watchlists only on first upload
2019-10-03 dbeam@chromium.org Make presubmit bark at FIXED= in CL description
2019-10-03 dbeam@chromium.org Support "Fixed:" syntax in BugsFromDescription()
2019-10-03 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).

Created with:
  gclient setdep -r src/third_party/depot_tools@f3c5fefedbf9

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=agable@chromium.org

Bug: chromium:976104,chromium:1009809,chromium:1009809,chromium:1010499
Change-Id: I069b1442b937fdd975e68fb28625182d750e9116
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838761Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#702663}

Bug: 1003433
Change-Id: Ib6f675338ddea2c5239325349ce07f2f97c67d96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838995
Commit-Queue: Dan Beam <dbeam@chromium.org>
Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702662}

https://android.googlesource.com/platform/external/perfetto.git/+log/19400f0641be..d897a1016473

git log 19400f0641be..d897a1016473 --date=short --no-merges --format='%ad %ae %s'
2019-10-03 primiano@google.com Merge "build: gcc9/gcc6 support and cross fixes"
2019-10-03 primiano@google.com Merge "Remove perfetto_src_tracing_ipc static lib target"
2019-10-03 lalitm@google.com Merge "traceconv: add support for printing traces with compressed packets"
2019-10-03 lalitm@google.com Merge "trace_processor: implement "hash" sql function"
2019-10-03 ssid@google.com Merge "Parse process descriptor to set process names"

Created with:
  gclient setdep -r src/third_party/perfetto@d897a1016473

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=perfetto-bugs@google.com

Bug: None
Change-Id: I922d0e531cb0231b229627d415540cf927854c22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838368Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#702661}

This CL also turns on Pixel_CanvasDisplayLinearRGBAccelerated2D test

Bug: 974383
Change-Id: I6401731f3630a4a54825486eeea793ab05472266
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834676Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702660}

Bug: 982762
Change-Id: Ic29c8ab1f5bbdd55cc88cd1ae73194cb6b12aa95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836980Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Cait Phillips <caitkp@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702659}

https://chromium.googlesource.com/angle/angle.git/+log/c847a75f95be..1f08ab28305d

git log c847a75f95be..1f08ab28305d --date=short --no-merges --format='%ad %ae %s'
2019-10-03 jmadill@chromium.org Re-land "GN: Componentize vulkan back-end build."
2019-10-03 geofflang@chromium.org GL: Refactor BlitGL program types into tuples of enums.
2019-10-03 timvp@google.com Only enable shader array size restrictions for HLSL
2019-10-03 jonahr@google.com Keep state up to date after bindBufferBase/Range

Created with:
  gclient setdep -r src/third_party/angle@1f08ab28305d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=cwallez@google.com

Bug: chromium:990368
Change-Id: Ic934880752c80bbeb26e261da2d68a64aa17d028
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838704Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#702658}

This is a reland of aaa2ec5c with fix from patchset 1 to 2 due to conflict with r702520.

Original change's description:
> Add weblayer browser_tests APK so we can run the tests on Android.
>
> The Shell C++ class isn't used on Android (unlike in content_shell) because we want to consume WebLayer there using the idiomatic Java API. At the same time, we want to write browser tests the same way for all platforms. So fake this by creating a Shell that reuses the existing BrowserController class that was created by Java.
>
> Change-Id: I946957f39eb79cff2e84c8abda56eed98b28d0a0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815884
> Reviewed-by: Clark DuVall <cduvall@chromium.org>
> Commit-Queue: John Abd-El-Malek <jam@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#702563}

TBR=cduvall@chromium.org

Change-Id: I425b7b15d9f742a25a5b7c9dd306067ca29e551b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838953Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702657}

- Proto change for custom suppresion duration support in impression.

Bug: 1005954
Change-Id: I309d1579aea526361e1bd7fd6828fb8ad5d77416
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836996Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Hesen Zhang <hesen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702656}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f585476f768e..2fe87ab48664


Created with:
  gclient setdep -r src-internal@2fe87ab48664

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: Ifddb9fe77d580379c1ed05ceec75656106a48635
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838150Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#702655}

Bug: 922145
Change-Id: I51fa49a5bad90a46c57778829d67d5813af1a199
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838533Reviewed-by: Andrew Luo <aluo@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Auto-Submit: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702654}

Changes:
- Infobar buttons are keyboard accessible

Infobar button focus:
https://imgur.com/a/z9r8wvt

Reduced button size and added margin (current implementation):
https://imgur.com/ZElowjJ

Bug: 963183

Change-Id: Ied028e357be961cc70fde45b952ce8dbf4a7c384
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657229
Commit-Queue: Michael Liao <michael.liao@microsoft.com>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702653}

Measure the time it takes for the extension to handle a key event.

Bug: 1009903
Change-Id: I4099ab7071d0cbbb414e534b3790d36763553d14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832854Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Keith Lee <keithlee@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702652}

Right now they are not aligned and since guard names are typically long,
aligning them *might* be helpful to some.

Example:
Header using the wrong include guard name FOOBARX_H_
  foobar.h:1

***************
Expected: u'FOOBAR_H_'
Found: u'FOOBARX_H_'
***************

With the CL:
***************
Expected: u'FOOBAR_H_'
Found:    u'FOOBARX_H_'
***************

Bug: None
Change-Id: I4c51b602a8da3bcb2db405def2d6193519cdea87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836001Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702651}

When we try to open a singleton tab from a tab-less window (can't open
new tabs), it won't search for that singleton in the window that it
eventually opens the tab in, and thus could open a second copy in that
window. This CL causes it to first search more broadly for singletons
from tab-less windows. This should cause it to find the singleton in
that situation.

Bug: 939388
Change-Id: I96ff82925382e1db545b078b17cade11998711c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837972
Commit-Queue: Kevin Bailey <krb@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702650}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/43e91961..5fb11187

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ia03b0b0aef2a375f5ec48e7c4abcc2595bd6b393
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839052Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#702649}

Bug: 1005568
Change-Id: Ieefa04403bfa29bb1c93de5316375fad9205b113
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836714Reviewed-by: Keith Lee <keithlee@chromium.org>
Commit-Queue: Keith Lee <keithlee@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702648}

This clears the visibility of search results and assistant, while
the visibility of horizontal page container (i.e. apps grid)
remains. I thought SetActiveState() will update that, but actually
it does nothing if the target page is not visible. As the result,
this can cause nothing to be shown in the app-list.

BUG=b/142069648
TEST=manually, app_list_unittests

Change-Id: I6e50b7e1b2f2234bd347ac5b7fdef35ecbe8522d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838303Reviewed-by: Tao Wu <wutao@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702647}

Bug: 922145
Change-Id: Iabea0d27059ad64d76a72f80b4a3d88e97e6f6f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836598Reviewed-by: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Andrew Luo <aluo@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702646}

The meaning of the parameter was not obvious at callsites, confusing
with layer's element id. Also the parameter was used in tests only,
and we already have SetScrollElementId() for the same purpose.

Change-Id: I62b0b6ad732389b419f351ac266cfdec73742fdc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839034
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Auto-Submit: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702645}

When UIA was enabled, Narrator was timing out because it calls
TextRange::GetAttributeValue a lot when trying to navigate between
paragraphs.

This function was iterating using AXRange, which is relatively
expensive.  However, since we're just collecting text attribute values,
we don't actually need to iterate over all the text positions... we just
need to iterate the anchor positions.

This change also introduces a test-case for GetAttributeValue.

Bug: 1011057
Change-Id: I624e5fccefe88918ad289c0185a501ef290bde48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838373
Commit-Queue: Ian Prest <iapres@microsoft.com>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#702644}

of GetReputationStatusWithEngagedSites to make more sense.

This CL removes an extraneous comment about skipping top domains. It
doesn't make sense to pass DomainInfo to
GetReputationStatusWithEngagedSites, when this method can easily
calculate that information, and its caller, GetReputationStatus, never
uses this information outside of passing it on. This CL also includes
fixes a few transitively included header files.

Change-Id: I528d1f22aaee2b46d8758fec2dfa0e7185f3b419
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838535Reviewed-by: Joe DeBlasio <jdeblasio@chromium.org>
Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org>
Commit-Queue: Aidan Beggs <beggs@google.com>
Cr-Commit-Position: refs/heads/master@{#702643}

Some of the tab discarder code are not used any more.

(1) We stop recording total_tab_count and mru_index in the
    ForegroundedOrClosed event because we think it makes more sense to
    capture these in the TabMetrics event which we are already doing.

    Related changes include:
    (1.1) Deprecating MRUIndex and TotalTabCount in the ukm event
          ForegroundedOrClosed.
    (1.2) Removing mru_index and total_tab_count from
          ForegroundedOrClosedMetrics
    (1.3) Stopping observing WillCloseAllTabs and CloseAllTabsStopped
    (1.4) Removing TabActivityWatcher::all_closing_tabs_


(2) LogOldestNTabFeatures() is also removed because it is unused.

Bug: 1007136
Change-Id: I25a7b9dbd471804d4680db2e95e80646ca1acb50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817871Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Charles . <charleszhao@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Charles . <charleszhao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702642}

This will significantly reduce the amount of includes required when
building ash_unittests and chrome.

Bug: 996418
Change-Id: Ic9988b1d144f0c422b63d68aafcee20f7860e41c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836277
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702641}

There was quite a bit of repetition in
ChromeContentBrowserClient::CreateThrottlesForNavigation.  This CL helps
avoid this, by changing:

  std::unique_ptr<content::NavigationThrottle> foo_throttle =
        FooThrottle::MaybeCreateThrottleFor(handle);
  if (foo_throttle)
    throttles.push_back(std::move(foo_throttle));

to:

  MaybeAddThrottle(&throttles, FooThrottle::MaybeCreateThrottleFor(handle));

Bug: 1003957
Change-Id: I6b9d110f101e246b4f8e70b242f8d20798b3aadc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838911
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702640}

This CL makes the dismiss X focusable. This fixes an issue where a user
could not dismiss with the keyboard.

Bug: 1011062
Change-Id: Id35723360abd4619096f1e3a57ec0c3412af32fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838295Reviewed-by: Jazz Xu <jazzhsu@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702639}

This is better served with a FillLayout and Bounds Change View Observer.

BUG=1005568
TEST=browser_tests AppWindowBrowserTest.*

Change-Id: I7c93be420241fc95c67479ae14a6c8a49d075890
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827943
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Auto-Submit: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702638}

Bug: 1002733
Change-Id: Ia01ca067072f2383b76571afb1ca4f864b60c8f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836851
Commit-Queue: Min Chen <minch@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702637}

The non-layout portions of LoadPageInfo() have moved to LoadPageSizes(),
which manages page loading/unloading and computing page sizes. The page
sizes are then passed on to the layout code remaining in LoadPageInfo(),
which finishes initializing each page's layout rectangle.

A future change will take advantage of this split to compute multiple
layouts from the same page size information.

No test changes, as this is an internal refactoring affecting private
methods of PDFiumEngine only, with no publicly testable surface.

Bug: 885110
Change-Id: Ie146d17032dc2e482a0ea0ce27b0bab79deeddfc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838527
Commit-Queue: K Moon <kmoon@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702636}

This is an initial cl for back gesture affordance. Many other issues
will be solved in following up cls. e.g, fling event support;
make affordance can be moved on y-axis movement; affordance should not
under frame area, etc.

Recorded video:
https://drive.google.com/file/d/1p7T-RiHU8nhaKmyAgrqA_bqITkCDBi7p/view?usp=sharing

Bug: 1002733
Change-Id: I89c02372babf2d562e56717c7966df2e8e5405f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834826
Commit-Queue: Min Chen <minch@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702635}

Fixes for the following issues in StreamProcessorHelper
1. Inputs packets were released prematurely when resetting the stream.
2. Output packets from previous streams were not ignored.
3. Reset() wasn't resetting the stream.

Bug: 1011117
Change-Id: I907590d92a92052bb3ed9518dd17b0eaa668403e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838169Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Auto-Submit: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702634}

Use decode('utf-8') to turn bytes into a string.
This works in Python 2 and 3.

Tested by running this script under Python 2 and 3.

Bug: 941669
Change-Id: I0cc4e58031f67867f56d37e47e54ef3dd7a49416
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838258
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Auto-Submit: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702633}

Bug: 1008994
Change-Id: I2d47ea71df0bca8d68b40f14e85637f85ffee714
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838921Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Commit-Queue: Matt Mueller <mattm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702632}

This CL exposes methods in TabGroupUtils to use SharedPreferences for
tab group naming and adds unit tests.

Bug: 1001738
Change-Id: I0d550e82cafe70b1ca7db9534bbc57c597b7d8e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837714Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702631}

Replaces zero-width GetPreferredSize().

Bug: chromium:992972
Change-Id: I2029887e6e88c5ed76d4163925640ebc449bf404
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838996
Commit-Queue: Peter Boström <pbos@chromium.org>
Commit-Queue: Charlene Yan <cyan@chromium.org>
Auto-Submit: Peter Boström <pbos@chromium.org>
Reviewed-by: Charlene Yan <cyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702630}

This adds the no-log directive to the iokit property restrictions, and
allows two harmless properties to be read as well.

Bug: 1008423
Change-Id: I4707befc1f566d109dd4cb5e1e9a116c148edbd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835688Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Greg Kerr <kerrnel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702629}

To avoid weird interactions, stop OpenURLFromTab from creating a new group if the source tab is pinned.

Bug: 992508
Change-Id: I144cb5c276e386d2a63da96f3b4992e6b1400a69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832158
Commit-Queue: Connie Wan <connily@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Reviewed-by: Taylor Bergquist <tbergquist@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702628}

It is not clear why this only fails on L/M, but
BiMap#remove(Object) is derived from Map#remove(Object) and should
only accept key as parameter.

Bug: 1010552
Change-Id: I00bf337ac1eb88f4868558e8a795f0d131c42657
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838158Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702627}

These session behave identically to the previous sample ("Magic Window")
with the exception that you cannot enter VR, and there are multiple
sessions instead of a single one.

Change-Id: Ic26649a5576cba3643ff903fc0c12fccbfe2afd8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835267Reviewed-by: Jacob DeWitt <jacde@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Will Cassella <cassew@google.com>
Cr-Commit-Position: refs/heads/master@{#702626}

Additionally, slightly refactor DetermineNewSelectedIndex() so that it feels less upside-down: handle the "closing inactive tab" case first. Judging by the tests and the way this is called in TabStripModel::DetachWebContentsImpl(), this is the intended order of behavior.

I wasn't able to manually reproduce a case where a grouped tab has an opener. I believe this is actually a different bug in groups: when a tab is opened by an opener, it doesn't get grouped. I'll log this separately (it's already in the Remaining Work doc for Tab Groups). For now, I kept the group logic after the opener logic, so that in most cases it will continue to behave as before.

From my experimentation, this works as expected when closing multiple tabs at once, including if they're non-consecutive or in different groups. The behavior just falls back to closing one tab at a time, so it will respect the group of the rightmost tab, which is the last to become active (see TabStripModel::DetachWebContentsImpl()).

Bug: 992512
Change-Id: I347fc52c0b0a2b5aca84a3ad2e4a6264bf8b11ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834641
Commit-Queue: Connie Wan <connily@chromium.org>
Reviewed-by: Taylor Bergquist <tbergquist@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702625}

Use content URI will show the download in files app
once it completes. Since the target file path is given,
there is no need to generate content URIs.

BUG=1010451

Change-Id: Icb61e403a25e837400893d114737155d64f35b1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838698Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702624}