GitLab

BUG=341493
NOTRY=True
NOTREECHECKS=true
R=benm@chromium.org

Review URL: https://codereview.chromium.org/168283003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252037 0039d316-1c4b-4281-b951-d872f2087c98

See details in issue.

BUG=344931

> Add GetDeviceSupportedFormats to Win DirectShow.
> 
> Extracted pixel format translation logic to 
> TranslateMediaSubtypeToPixelFormat().
> 
> BUG=309554, 314161
> 
> Review URL: https://codereview.chromium.org/156583004

TBR=mcasas@chromium.org

Review URL: https://codereview.chromium.org/163023005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252036 0039d316-1c4b-4281-b951-d872f2087c98

Most people don't use this parameter and get arm binaries. This is
still the default, so this change shouldn't affect most people.

Folks should instead pass -Dtarget_arch to gyp. (Or, soon, envsetup will stop
clobbering GYP_DEFINES, then you can just add target_arch to your GYP_DEFINES.)
Note that in gyp land, 'mips' is called 'mipsel' and 'x86' is called 'ia32'.
'arm' stays 'arm'.

So for example, instead of running

  . build/android/envsetup.sh --target-arch=mips
  android_gyp

you'd run

  . build/android/envsetup.sh
  android_gyp -Dtarget_arch=mipsel

I updated the bots I was able to find to pass the -D flag in addition to
--target-arch. After this CL here is in, I'll update the bots to stop passing
--target-arch, and then I'll make --target-arch a hard error in this script for
a while, to make sure nobody still uses it.

BUG=330631,34476
R=torne@chromium.org
TBR=yfriedman

Review URL: https://codereview.chromium.org/171903002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252034 0039d316-1c4b-4281-b951-d872f2087c98

The bots tells this CL broke most of the webrtc browser tests on Mac.
http://chromegw/i/internal.chromium.webrtc/builders/Mac%20Tester


BUG=344912
TEST=webrtc bots.

> Do not send a frame swap ack from the browser until the frame is drawn
> 
> Code to do this was recently removed because it was no longer being
> used in r241225 (https://codereview.chromium.org/116103002). This is
> now necessary again to throttle renderers when using CoreAnimation.
> 
> Frames are acked only when they are drawn. Both the CoreAnimation and
> the non-CoreAnimation paths are changed to behave this way. By virtue
> of the fact that the non-CoreAnimation path draws immediately, this
> should have no functional effect on that path.
> 
> This differs from the mechanism deleted in the aforementioned patch in
> two ways.
> 
> First, it uses a scoped_ptr of a struct instead of a vector of pairs to
> store the information about the swap being returned. This should improve
> readability in that the ack has struct names instead of just first and
> second in the pair, and in that the scoped_ptr does not suggest support
> for multiple pending swaps (which does not exist).
> 
> Second, it does makes RWHVMac ack frames more aggressively when
> inside a draw call, rather than adding a call from RWHImpl to the view,
> to effect the ack (which is what the old way does).
> 
> BUG=340133
> 
> Review URL: https://codereview.chromium.org/165703002

TBR=ccameron@chromium.org

Review URL: https://codereview.chromium.org/172633002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252031 0039d316-1c4b-4281-b951-d872f2087c98

It corrects a mistake which does not assign the output device id to the member of the dispatcher.

NOTRY=true

BUG=344818
TEST=http://localhost:8080/hangout_services_test.html works with device selection.
R=joi@chromium.org

Review URL: https://codereview.chromium.org/172243003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252025 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252022 0039d316-1c4b-4281-b951-d872f2087c98

> Roll to r13493
> 
> R=rmistry@google.com
> 
> Review URL: https://codereview.chromium.org/167973005

TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/171603006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252021 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
R=mkwst@chromium.org

Review URL: https://codereview.chromium.org/166273013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252019 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252018 0039d316-1c4b-4281-b951-d872f2087c98

R=rmistry@google.com

Review URL: https://codereview.chromium.org/167973005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252017 0039d316-1c4b-4281-b951-d872f2087c98

This path will fix the heap-use-after-free bug.

BUG=343661,344750

Review URL: https://codereview.chromium.org/171943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252010 0039d316-1c4b-4281-b951-d872f2087c98

Reverted due to memory leaks:
http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASAN%20Tests%20%281%29/builds/15922

> Refactor the TrayAudio code so that it can be used by other platforms.
> The motivation here is to introduce the volume slider tray UI into
> Windows Ash.
> 
> This change does not actually add tray audio UI to other platforms,
> only moves some non-chromeos specific things out of the chromeos
> platform folders, so that we can hook in the native Audio APIs
> of other platforms to the tray UI.
> 
> At a high level, this change does the following:
> 
> 1) Move tray_audio out of chromeos/ so that other platforms can
> use the UI that it provides.
> 2) Decouples TrayAudio from CrasAudioHandler by introducing a
> new delegate, in a similar vein to what is done with all the other
> handlers (e.g. the BluetoothHandler)
> 3) Move the additional views (VolumeView, etc) to their own files
> so they can be used by other platforms as well.
> 
> TEST=
>  On CrOS physical device, verified that:
>  1) Keyboard volume buttons function appropriately and display the
>     volume view
>  2) AudioDetailView still is accessible at the correct times
>  3) Adjusting the volume (via the keyboard shortcuts or via the
>     slider) correctly change the output volume.
>  4) UI still behaves correctly (e.g. icons update as the volume
>     changes, mute button works, etc).
> 
> BUG=227247
> 
> Review URL: https://codereview.chromium.org/163953007

TBR=zturner@chromium.org

Review URL: https://codereview.chromium.org/170843009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252009 0039d316-1c4b-4281-b951-d872f2087c98

BUG=339373
R=ricea@chromium.org

Review URL: https://codereview.chromium.org/158663003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252008 0039d316-1c4b-4281-b951-d872f2087c98

This is a part of the flag clean up effort.
Since --disable-drive flag is now a user configurable (by chrome:settings)
preference, we don't need a flag.

BUG=344738
TBR=mnissler@chromium.org

Review URL: https://codereview.chromium.org/171843003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252004 0039d316-1c4b-4281-b951-d872f2087c98

BUG=34815

Review URL: https://codereview.chromium.org/166233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252003 0039d316-1c4b-4281-b951-d872f2087c98

Previously, D-Bus clients were deleted after the system bus was
shut down. This order was not desirable because D-Bus clients
could access the system bus in their destructors, even though the
system bus was already shut down.

BUG=344270
TEST=Chrome shuts down cleanly as before
R=hashimoto@chromium.org, stevenjb@chromium.org

Review URL: https://codereview.chromium.org/166593005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252002 0039d316-1c4b-4281-b951-d872f2087c98

Text and Binary opcodes cannot appear in the middle of a message, and
the Continuation opcode cannot appear at the start.

Fail the channel if violations of this rule are found.

BUG=343105
TEST=net_unittests, layout tests

Review URL: https://codereview.chromium.org/157033013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252001 0039d316-1c4b-4281-b951-d872f2087c98

Previously when WebSocketBasicStream split a frame that arrived in
several chunks, it would copy the reserved bits from the first frame
onto all subsequent frames.

However, the permessage-deflate extension requires that the RSV1 bit
only be set on the first frame of the message.

For compatability with permessage-deflate, clear the reserved bits on
second and subsequent frames when splitting a frame.

BUG=343507
TEST=net_unittests --gtest_filter=WebSocket*

Review URL: https://codereview.chromium.org/171883002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252000 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251999 0039d316-1c4b-4281-b951-d872f2087c98

BubbleDelegateView::CreateNonClientFrameView mirrors in RTL.
(arrow horizontal positions/anchoring are flipped in RTL UI)
BrowserActionsContainer::ShowPopup should not do the same.
See before and after pictures at http://crbug.com/150696

BUG=150696
TEST=RTL (--lang=he) UI browser/page action extension popups should be anchored at the top left and shouldn't be cut off.
R=sky@chromium.org

Review URL: https://codereview.chromium.org/168723004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251998 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dsinclair
NOTRY=True

Review URL: https://codereview.chromium.org/171883003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251997 0039d316-1c4b-4281-b951-d872f2087c98

(I was missing RemoveObserver in one of the tests and as a result ASAN tests were catching use-after-free.)


Rename input_method_property to input_method_menu_item, and move to ash/ime.


BUG=342336, 343044

Review URL: https://codereview.chromium.org/169033003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251996 0039d316-1c4b-4281-b951-d872f2087c98

The ChromeOS shelf currently uses the oldest navigation entry's URL to
find the extension to group with on the shelf. This can cause a single
browser window to associate with no launcher item, rendering the
browser window inaccessible. It's also possible to have a changing
launcher item because navigation entries get pruned.

This CL uses the browser's app name to determine the extension for a
hosted app window.

It also causes app tabs to group with a bookmark app if no extension
has a matching extent.

BUG=340590

Review URL: https://codereview.chromium.org/153623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251995 0039d316-1c4b-4281-b951-d872f2087c98

Only happens if the testrunner methods are invoked with invalid
arguments. Protect against that.

BUG=344762
R=dcarney@chromium.org

Review URL: https://codereview.chromium.org/171423004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251994 0039d316-1c4b-4281-b951-d872f2087c98

BUG=303491

Review URL: https://codereview.chromium.org/137663008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251993 0039d316-1c4b-4281-b951-d872f2087c98

BUG=342106

Review URL: https://codereview.chromium.org/171583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251992 0039d316-1c4b-4281-b951-d872f2087c98

This CL centers the app list for ChromeOS when the --enable-experimental-app-list flag
is on as a followup to https://codereview.chromium.org/162753002 .

BUG=344442

Review URL: https://codereview.chromium.org/168733003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251991 0039d316-1c4b-4281-b951-d872f2087c98

chrome.windows.create has been obsolete and should not be used.

BUG=343317
TEST=manually tested

Review URL: https://codereview.chromium.org/171563003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251990 0039d316-1c4b-4281-b951-d872f2087c98

Earlier versions of ISO 14496-12 indicated that the upper 2 bits of
the sample_info was reserved and must be 0. The current version of
ISO 14496-12:2012 now allows these bits to be non-zero so we need to
remove the check so the content will play. The new non-zero values are
not needed by the current code so we don't need any extra logic.

BUG=344737

Review URL: https://codereview.chromium.org/166323005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251989 0039d316-1c4b-4281-b951-d872f2087c98

BUG=343835

Review URL: https://codereview.chromium.org/166263002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251988 0039d316-1c4b-4281-b951-d872f2087c98

Generated using:
> git grep -l pp_ifdef | xargs sed -i "s:pp_ifdef('\([^']\+\)'):\1:g"

BUG=343235

Review URL: https://codereview.chromium.org/171763004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251987 0039d316-1c4b-4281-b951-d872f2087c98

This patch adds an IPC for iframe parameter initialization when it has
been swapped out for out of process rendering.

It changes where CrossProcessFrameConnector is being created because
it was being created too late; it is much more useful for it to be able
to receive messages from the swapped out frame as soon as that frame is
swapped out.

There is currently no mechanism for dynamically changing the size of an
iframe. It is not yet clear how this will be implemented in Blink.

Dependency on Blink CL: https://codereview.chromium.org/135163006/

R=creis@chromium.org, jam@chromium.org
BUG=325803

Review URL: https://codereview.chromium.org/132383005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251986 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251985 0039d316-1c4b-4281-b951-d872f2087c98

The leak was caused by the modular testing not forcing the run-and-clear of
clean-up callbacks.  This left a callback owned by the object which increment
the refcount of the object.  These callbacks should be removed and a different
method of ensuring cleanup should be employed.

Ideally we can find a way to get rid of the ref-counting on the object to avoid
this sort of issue in the future, but currently the operation manager lives on
the IO thread and the Operation must work on the FILE thread.  A sequenced task
queue or a worker may be useful.

Previous CL: https://codereview.chromium.org/149313003/

BUG=292956
BUG=337883
BUG=335404

Review URL: https://codereview.chromium.org/170713007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251984 0039d316-1c4b-4281-b951-d872f2087c98

Also updated Udacity Mobile Web Development Course link

Review URL: https://codereview.chromium.org/170753003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251983 0039d316-1c4b-4281-b951-d872f2087c98

Rename some functions to be more meaningful:
- RWHVMac::scale_factor -> RWHVMac::ViewScaleFactor
- RWHVCocoa::deviceScaleFactor_ -> RWHVMac::backing_store_scale_factor
- ::ScaleFactor(NSView*) -> ScaleFactorForView(NSView*)

Move code to update the scale factor of the backing store from
being in RWHVCocoa::updateTabBackingStoreScaleFactor to be
in RWHVMac::UpdateBackingStoreScaleFactor.

Work around a bug where updating the contentsScale of a
CAOpenGLLayer that dynamically changes its isAsynchronous
property results in corruption by re-creating the CAOpenGLLayer
when a change in scale factor is detected.

BUG=245900

Review URL: https://codereview.chromium.org/171763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251982 0039d316-1c4b-4281-b951-d872f2087c98

When using a non X11 build with Ozone, we still have dependencies on
X11. This patch tries to hide X11 and related dependencies when
use_x11=0

Review URL: https://codereview.chromium.org/148643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251981 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Cast: Added a EncodingEventSubscriber to cast sender app. (https://codereview.chromium.org/162103002/)

Reason for revert:
Broke 32 bit bots, printf() usage is non-portable.

Original issue's description:
> Cast: Added a EncodingEventSubscriber to cast sender app.
> 
> - Logs encoded uncompressed raw events for the first X seconds to a file path Y, where X and Y
>   can be specified by the user.
> - Also outputs some basic stats.
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251972

TBR=hclam@chromium.org,imcheng@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/170283009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251980 0039d316-1c4b-4281-b951-d872f2087c98

The Indexed DB page cycler has been replaced by a real benchmark. So we no
longer need the age-old hacks to do idb testing via a page cycler.

BUG=196406
TBR=cmumford@chromium.org

Review URL: https://codereview.chromium.org/148093016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251979 0039d316-1c4b-4281-b951-d872f2087c98

With dev-mode highlighting (on stable/beta channel, or with the --force-dev-mode-highlighting=1 flag), in Views, unpacked extension browser action iicons (such as the ones in this test) are given a different background. Adjust our test expectations accordingly.

This patch also cleans up the other BrowserActionApiTests somewhat.

BUG=333008
TEST=browser_tests --gtest_filter=BrowserActionApiTest.DynamicBrowserAction --force-dev-mode-highlighting=1

Review URL: https://codereview.chromium.org/170843005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251978 0039d316-1c4b-4281-b951-d872f2087c98