- 25 Jun, 2019 40 commits
-
-
Hwanseung Lee authored
Use enum class instead of enum for BoxLayout::Orientation enum class is more type safety. Bug: 940736 Change-Id: Ib4a0bdb834fdd47ffd6c02e70cac27e36823a824 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614649Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#671921}
-
Dan Beam authored
This reverts commit a5646d5a. Reason for revert: Crashes 5 tests on Win 7 Tests x64 (1): https://ci.chromium.org/p/chromium/builders/ci/Win%207%20Tests%20x64%20%281%29/55573 Original change's description: > Remove NOTIFICATION_FULLSCREEN_CHANGED > > Replace with an observer interface on FullscreenController. > > Bug: 268984 > Change-Id: I1af2056e870af56b2f436a3aa8c6a54ed0ff44fb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666148 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Evan Stade <estade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#671901} TBR=sky@chromium.org,estade@chromium.org Change-Id: I793c04325fa1e4e9e6fb07256e01ff81c22e3b0d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 268984 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672139Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#671920}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/73c4a7c3567a..2cfafaf4aa25 git log 73c4a7c3567a..2cfafaf4aa25 --date=short --no-merges --format='%ad %ae %s' 2019-06-25 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-06-24 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@2cfafaf4aa25 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Idc017cfecb7ec6fe4e3acec91f1aa3570dad5b9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674675Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#671919}
-
John Lee authored
This CL also removes unused #promo-description CSS. Bug: 973674 Change-Id: I983058cc19a8276fb36a2c124cfee5c7eca96bd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674593Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#671918}
-
Kevin Strohbehn authored
Bug: 931909 Change-Id: I8353dbd4c78949c74ab2c33a1f6ae753a0100e47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674499Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Kevin Strohbehn <ginko@google.com> Cr-Commit-Position: refs/heads/master@{#671917}
-
Istiaque Ahmed authored
This CL exposes ServiceWorkerContextProxy to ContentRendererClient's DidInitializeServiceWorkerContextOnWorkerThread, so that extensions/ can query the state of AllowWindowInteraction() through it via ServiceWorkerGlobalScope. This allows Service Worker based extensions to call extension APIs that require user interaction to be present, in onnotificationclick handler. This CL adds test for this feature. Bug: 977629 Change-Id: I28df9ee0724dbc76f5525d9111416e9180ad3d5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673253 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#671916}
-
Cliff Smolinsky authored
The native Windows tooltip doesn't support dark theme and it has some accessibility issues with the text scaling settings. By using the aura tooltips we can solve both of these problems together. This change completely enables Windows to use TooltipAura, behind a Feature flag. Included in this change is an increase to the maximum width of tooltips from 400px to 800px in order to better match the native tooltip and avoid some of the early truncation issues described by https://bugs.chromium.org/p/chromium/issues/detail?id=292738 (which ChromeOS currently suffers from). On Windows transparency will not be allowed because it doesn't meet accessibility requirements. This change also adds a border when transparency is not allowed. Bug: 971686 Change-Id: I8c644d4e73510fcead9021c930924b09af4c80a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650466Reviewed-by:
-
Evan Stade authored
Two consumers: - PluginStatusPrefSetter - was unused, so it's deleted. - ChromePluginServiceFilter - the action taken when receiving the notification can be moved to the notification's source, i.e. PluginPrefs. Note that the enable status can only change for the pdf viewer plugin, so it wasn't a very aptly-named notification (at this point in history). Bug: 268984 Change-Id: I1aebd7d90f8e70c3031d7e7911bb1388c8e88c8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671849Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Auto-Submit: Evan Stade <estade@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#671914}
-
Luciano Pacheco authored
Change the background color when the file is selected and is the lead (currently focused) to be blue, instead of gray. Claire approves! :-) Bug: 968478 Change-Id: I5dc33104a7fe37abaddb5817c58f83a1c796f383 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672612 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#671913}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/dd3ef1e78819..eb66fe4e15e8 git log dd3ef1e78819..eb66fe4e15e8 --date=short --no-merges --format='%ad %ae %s' 2019-06-24 tiborg@chromium.org Move uses-sdk to GN. Created with: gclient setdep -r src/third_party/angle@eb66fe4e15e8 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:891996 TBR=syoussefi@google.com Change-Id: I4c1f10da53d9d95150a9f1e520bcfb3601796951 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674625Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d32b1ad1..d3a6eb96 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I54a7278b9b884c0d1ae84e06efe82cacf5dc23f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672801Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#671911}
-
Hao Zhang authored
4 digit specialization of cc-exp, use that specialization. Change-Id: I910a30d9bfd617cd22959e1c1eeb9a3b0f702fae Bug: 971402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1410084 Commit-Queue: Hao Zhang <hozhng@google.com> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Cr-Commit-Position: refs/heads/master@{#671910}
-
Dan Beam authored
TBR=xiaohuic@chromium.org BUG=978267 Change-Id: Iad449bb6308db01ef8bf3e38a1c6364ae0f44732 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674749Reviewed-by:
-
Vlad Tsyrklevich authored
Use WaitForMultiprocessTestChildExit() instead of base::Process::WaitForExitWithTimeout() to wait for multiprocess test child processes to complete. It's identical to WaitForExitWithTimeout() on macOS/Windows/Linux but also works on Android. (Android tests don't fork so they use a special process monitoring mechanism.) Bug: 973167 Change-Id: I3c3f10a155d4ea9058404ae7474cfacdcf2ed402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1668335 Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#671908}
-
John Budorick authored
This CL: - removes perfetto_unittests entirely, because it isn't running on any other android bot - adds android+asan-specific filters for content_browsertests and unit_tests Bug: 790202 Change-Id: I361069217c4c52a49e48a8e53c23bb238f495879 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674592 Commit-Queue: John Budorick <jbudorick@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#671907}
-
Alexey Baskakov authored
InstallWebAppWithOptions shouldn't dcheck AreWebAppsUserInstallable. Remove DCHECKs from WebAppInstallManager: Let WebAppInstallTask only DCHECKs it (WebAppInstallTask is a leaf node and it is used by WebAppInstallManager anyway). In general, this is go/chromium-profile-types again. Bug: 977823 Change-Id: I1c5f0cfcef363cad9cfdd92e69decd64022f707e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672091Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#671906}
-
Dan Beam authored
This reverts commit 3bceb8a7. Reason for revert: Seems to have broken IndexedDBBrowserTest.NegativeDBDataVersion IndexedDBBrowserTest.NegativeDBSchemaVersion On various bots: https://ci.chromium.org/p/chromium/builders/ci/KitKat%20Phone%20Tester%20%28dbg%29/14978 https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Tests%20%281%29/54305 Original change's description: > [IndexedDB] Open sequence cleaned up with better failure handling. > > The previous open sequence was really hard to understand and only > sometimes recovered the database. This change cleans this up. See the > document here for more info: > https://docs.google.com/document/d/1jX6OOQJ0aLrWAeqYLtARXPFawUlJPbHNIKAK-0vmFHU/edit#heading=h.5qhp88d21pi0 > > Bug: 862456 > Change-Id: Ib8fa4e48c0154451e8ab787bc0086a57759f05d0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665433 > Commit-Queue: Daniel Murphy <dmurph@chromium.org> > Reviewed-by: Victor Costan <pwnall@chromium.org> > Reviewed-by: Chase Phillips <cmp@chromium.org> > Cr-Commit-Position: refs/heads/master@{#671765} TBR=cmp@chromium.org,dmurph@chromium.org,pwnall@chromium.org Change-Id: I9e851fce26bd9feb351c76bec8e418cbd09799a0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 862456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674623Reviewed-by:
-
Dominic Farolino authored
In content::NavigationControllerImpl::NavigateFromFrameProxy we pull RenderFrameHost::FrameTreeNode out into a separate variable but rarely use it. This CL uses the variable in locations were we previously computed its value. Bug: N/A Change-Id: Ic5ef6e209b2c5146d7d62a8b884d61c150c1100a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673172Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#671904}
-
Rose Garcia authored
Added flag for new Switch Access text input improvements that will be made. Bug:978232 Change-Id: I97c2349fb28f3651f74bf9eaa3646d3c168bfa34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674471 Commit-Queue: Rose Garcia <rosalindag@google.com> Reviewed-by:
Katie Dektar <katie@chromium.org> Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#671903}
-
Kyle Milka authored
Cursor should be set to 'default' instead of 'none'. Bug: 977948 Change-Id: I2d4619f26bd33524718c1d3993fc6162fa2a3485 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674410 Commit-Queue: Kyle Milka <kmilka@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Auto-Submit: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#671902}
-
Evan Stade authored
Replace with an observer interface on FullscreenController. Bug: 268984 Change-Id: I1af2056e870af56b2f436a3aa8c6a54ed0ff44fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666148Reviewed-by:
-
Nate Fischer authored
No change to logic, only docs. This adds an explainer for class verification (focusing on ART), and tips for debugging class verification errors, including list_class_verification_failures.py. Bug: 918221, 855796 Test: tools/md_browser/md_browser.py Test: Upload to gerrit > open file > click "gitiles" Change-Id: I28c0e5fb337fe0f126106b6e5bc6a5001ce24167 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663589Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#671900}
-
Peter Boström authored
Changes the detection mechanism for the ToolbarIconContainerView highlight border so that it is active when either: * The container is mouse hovered but the main view is not. * Any child view has focus. * Any child view is in the pressed state. Bug: chromium:932818, chromium:943702 Change-Id: I388a4b78a43ddd05b3dd2623321f92938110ba0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674629Reviewed-by:
Siyu An <siyua@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#671899}
-
Jacob DeWitt authored
Verifies the following behavior for WebXR Gamepads: 1) Changes to the button and input axis values for the mock gamepad object make their way through all the plumbing and on to the session's input source's Gamepad. 2) Changing button and input axis values cause the Gamepad to be updated in-place. XRInputSource and Gamepad objects should not be re-created in this case and an inputsourceschange event should not be fired. Bug: 976978 Change-Id: I6de7a45e357e6900eccca103741dddc33fc9d495 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673083Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Jacob DeWitt <jacde@chromium.org> Cr-Commit-Position: refs/heads/master@{#671898}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/91032f8cd7ea..e2439cc929f9 git log 91032f8cd7ea..e2439cc929f9 --date=short --no-merges --format='%ad %ae %s' 2019-06-24 rmistry@google.com Add to lottieweb blacklist 2019-06-24 rmistry@google.com Do not retry G3 tryjobs 2019-06-24 nigeltao@google.com Pause Wuffs' getFrameCount in incremental decode 2019-06-24 jvanverth@google.com Reland "Prefer using GrOvalOpFactory over GrFillRRect for circles and axis-aligned circular roundrects." 2019-06-24 bsalomon@google.com Fix GrColorType name for half float RG. 2019-06-24 egdaniel@google.com Add defaults for GrProtected on createBackendTexture. 2019-06-24 csmartdalton@google.com Rename "preferredInternalSampleCount" to "internalMultisampleCount" 2019-06-24 herb@google.com Remove getGlyphIDMatrics type calls. 2019-06-24 rmistry@google.com [lottie-web-perf] Make similar to skottie-wasm-perf 2019-06-24 rmistry@google.com [skottie-wasm-perf] Make sure we are drawing to 1000x1000 2019-06-24 bsalomon@google.com Fix EGLImageTest asserts on Android 2019-06-24 robertphillips@google.com Reduce GrCaps' reliance on GrPixelConfig 2019-06-24 brianosman@google.com Install runtime check error handler in RTC builds 2019-06-24 bsalomon@google.com GrColorSpaceInfo stores SkAlphaType. 2019-06-24 halcanary@google.com experimental/editor: progress on newlines 2019-06-24 benjaminwagner@google.com Shuffle jobs to the NVIDIA_Shield (2 of 2) 2019-06-24 mtklein@google.com fix Dockerfile? 2019-06-24 mtklein@google.com add bit_clear 2019-06-24 fmalita@chromium.org [skottie] Run resources "GMs" on Lottie bots 2019-06-24 emircan@google.com Enable creating protected vulkan backend 2019-06-24 mtklein@google.com split out Analysis struct from Instruction 2019-06-24 mtklein@google.com embed val_to_reg in Builder::Instruction 2019-06-24 mtklein@google.com refactor to remove the need for death schedule 2019-06-24 mtklein@google.com split ID -> Reg,Val 2019-06-24 mtklein@google.com simplify instructions back to one immediate 2019-06-24 benjaminwagner@google.com Shuffle jobs to the NVIDIA_Shield (1 of 2) 2019-06-24 brianosman@google.com Particles: SkScalar -> float Created with: gclient setdep -r src/third_party/skia@e2439cc929f9 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:971936 TBR=djsollen@google.com Change-Id: Idf71d667024df6aa2bb0da6b733c8d64490d1164 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674621Reviewed-by:
-
Dongheun Kang authored
Bug: none Change-Id: I3636b34d6f87f9db732f1263cc3f2eddeb39335f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670527Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#671896}
-
Nicholas Hollingum authored
We weren't freeing some objects that wayland allocates (and expects us to free for ourselves). Bug: 977600 Change-Id: I6e5441e92ec5e951d3e3ad3b9c431a7b3690d60c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672078Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#671895}
-
tby authored
Previously, we had two copies of each Record, Train, and Rank method for the ranker and each predictor: one that took a query and one that didn't. The idea was that predictors (and therefore the ranker) was set up to either work in a zero-state or condition-based environment, and clients should only call the appropriate methods. This has limitations, in particular, zero-state predictors can't be used in an ensemble model along with condition-based ones. This CL removes the distinction between these methods. Specific changes are as follows: 1. Predictors now only have Train(target, condition) and Rank(condition) methods. The non-condition versions have been deleted. 2. The Ranker's zero-state Train and Rank methods are now just shortcuts for having an empty-string condition. 3. All predictors labelled ZeroStateX have been renamed to just X. It seems most of our predictors won't use the condition and, in order to incorporate a condition, will be wrapped in some kind of ConditionalPredictor. So it makes sense for the default naming to not specify zero-state-ness, as the current names are very verbose. Bug: 921444 Change-Id: I5273715501319cda951b717d755e1abb559d4dd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670668 Commit-Queue: Tony Yeoman <tby@chromium.org> Reviewed-by:
Charles . <charleszhao@chromium.org> Cr-Commit-Position: refs/heads/master@{#671894}
-
Sergey Ulanov authored
Now system logs from the target system (running under qemu) are stored in a separate file in the output directory. A separate CL will remove these logs from tests stdout. Bug: 869753 Change-Id: Ife0993605add5f0eb2e1422879e7df0fedabb31b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674667 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#671893}
-
Antoine Labour authored
Making sure there are at least 2 owners after I leave. This CL was uploaded by git cl split. R=dnicoara@chromium.org Change-Id: Ib08fe6f8c354dbd7f9dc6c3c91caa693a493579a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674611 Auto-Submit: Antoine Labour <piman@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#671892}
-
Rakina Zata Amni authored
There are paths in the layout code where layout of the children of an element is done even when NormalChildNeedsLayout/PosChildNeedsLayout aren't dirty, and display locked elements fail in those cases because we remove the self-dirty layout bits with the assumption that the child dirty bits will be there and will be restored in future updates/unlocks. This CL adds notifications of blocked child layouts, so the next time the subtree is allowed to be updated we can make sure those blocked child traversals will happen, even if NeedsLayout() is false on the locked element. Bug: 966458 Change-Id: I12f2f82af475243ca2dcf91df643294332e20e2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652892Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#671891}
-
Kevin Strohbehn authored
This changes traversal to use a 'selection' similar to omnibox that is wholly managed by a single object. This change is currently behind a flag, and will be default-on in a follow up CL by June 25th Bug: 931909 Change-Id: I828605ca77a87829eded327ab8a6198097450ecf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607502 Commit-Queue: Kevin Strohbehn <ginko@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#671890}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/material-components/material-components-ios/+log/e90aa11c4be3..dc0267693ad4 git log e90aa11c4be3..dc0267693ad4 --date=short --no-merges --format='%ad %ae %s' 2019-06-24 codyleeweaver@gmail.com Merge branch 'release-candidate' into stable Created with: gclient setdep -r src/ios/third_party/material_components_ios/src@dc0267693ad4 The AutoRoll server is located here: https://autoroll.skia.org/r/material-components-ios-chromium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:ios-internal-mdc TBR=bling-p10-rolls@google.com Change-Id: Iba5873a192896f050519af4008ab5c1ed0bff4bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674784Reviewed-by:
-
Julie Jeongeun Kim authored
This CL is a part of moving access token management to OAuth2AccessTokenManager. It moves RequestParameters to OAuth2AccessTokenManager and TokenCache type definition which uses RequestParameters also is moved. Bug: 967598 Change-Id: I62d268f634c91caf61d792110206f5a01751f006 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670132 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#671888}
-
Yilkal Abe authored
This reverts commit b916e68c. Bug: 977019 Original change's description: > Enable feedback from power button menu in KioskNext sessions > > Bug: 967931 > > Change-Id: I302a4eb12ff69c117c0254fdc86d1a2323231180 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647454 > Reviewed-by: James Cook <jamescook@chromium.org> > Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> > Commit-Queue: Yilkal Abe <yilkal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#667308} TBR=jamescook@chromium.org,michaelpg@chromium.org,yilkal@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 967931 Change-Id: I279992966d55b8ba140f488bbac798efb515f11f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674189Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#671887}
-
Peter Kasting authored
Bug: 956419 Change-Id: I6f769800f1deb20461d4148b28d4b03d23310de2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657355 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#671886}
-
Dana Fried authored
Because Linux/CrOS do not respect hit test transparency, the top shadow of bubbles fights for mouse events with the window underneath. This causes unacceptable flicker with tab hover cards on Linux and ChromeOS. As a temporary fix until the real culprit can be addressed (a much larger effort; see crbug/978134), on the affected platforms we move hover cards down slightly and slightly raise the bottom of the hit test area for tabs up slightly to compensate. This is not ideal from a UX standpoint but it is the only solution available at the current time for an issue that is otherwise a release blocker. Bug: 972582 Change-Id: I91f0583f8c6c4dfb912c4ea75e07a437fc770f02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674290 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#671885}
-
Sangseok Jang authored
The function "AddItem" add invisible empty menu for extension overflow menu. It might be workaround to resolve appkit menus bug. But, it might be resolve. The empty menu added before extension overflow menu is invisible, but it has margins. So, the exetension overflow menu view in AppMenu looks different in Windows and Mac. Bug: NONE Change-Id: Iba0b944f688b42a42d2e83716209770acae689e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669136Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Sangseok Jang <sangseok.jang@navercorp.com> Cr-Commit-Position: refs/heads/master@{#671884}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e3905cd79dbe..754e19056745 Created with: gclient setdep -r src-internal@754e19056745 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=tzik@google.com,dbeam@google.com,huanzhong@google.com Change-Id: Ifc8580e7c4977b2052c79f6c94226d812d83ebee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674302Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#671883}
-
Lukasz Anforowicz authored
Bug: 888079 Change-Id: Ic05a6d37c1457239330036149537f260a8c05bdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669879 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#671882}
-
