GitLab

https://chromium.googlesource.com/openscreen.git/+log/81d10f5dd7f5..c48f5ba0b57d

2020-10-07 btolsch@chromium.org Fix leak of listening tcp sockets

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/openscreen-chromium
Please CC jophba@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: jophba@chromium.org
Change-Id: I50f9b39f99710674bb27032499e663a37b577de0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459248Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#814926}

Part one of what's likely to be a three step process to remove
VRDisplayInfo entirely and start sending view information as an
array of views rather than and explicit left and right eye.

Removes the VRDisplayInfo instance previously stored on the
XRSession, and begins tracking the session's internal view
changes as an array (though they are still supplied to the
session as left/right.)

Bug: 998146
Change-Id: I0a86e43fca74ba9cd48f1e33a9033da2e899ed4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446837
Commit-Queue: Brandon Jones <bajones@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814925}

We're investigating some Trust Tokens issuance failures that seem to be
because of some fetch API error that leads to
ResourceError::GetResourceRequestBlockedReason() returning
ResourceRequestBlockedReason::kOther.

This happens in one of two cases:
(1) Some code explicitly failed a request with kOther
(2) The request failed with ERR_BLOCKED_BY_CLIENT or
ERR_BLOCKED_BY_RESPONSE, but *not* with a
network::mojom::BlockedByResponseReason.

One case falling in bucket 2 is extensions' WebRequest API, which sets
ERR_BLOCKED_BY_CLIENT but doesn't fail requests with a
BlockedByResponseReason. This CL expands the WebRequest logic to set an
extended resource error, which should make it possible to distinguish
WebRequest blocks from other block reasons described in the prior
paragraph.

Bug: 1128174
Change-Id: I6d6255c8ba695a73b19efec69e8c3f45017724f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451571
Commit-Queue: David Van Cleve <davidvc@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814924}

See attached bug.

Bug: 1135317
Change-Id: I4a60b5266b20e246bea14e9330fa41c8a743091d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458747Reviewed-by: Collin Baker <collinbaker@chromium.org>
Commit-Queue: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814923}

This CL adds a flag for the reverse scrolling features:

- kReverseScrollGestures: enable reverse scroll gestures

Bug: 1107183
Change-Id: Id1f918bacbca2726300927e7bf0e680b9237053b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419922
Commit-Queue: Xiaodan Zhu <zxdan@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814922}

conformance/glsl/constructors/glsl-construct-bvec3.html is flaky on
ChromeOS VMs.

Bug: 1136106
Change-Id: I601b2f2a87f7fc9d84b13b47f6401231e3b4daf3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458286Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Shrek Shao <shrekshao@google.com>
Cr-Commit-Position: refs/heads/master@{#814921}

https://android.googlesource.com/platform/external/perfetto.git/+log/91ab730685a6..3419b3b485ba

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: I7fe73f97c1b4e7dbf1d16c079cfbed2f0c18427f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458891Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#814920}

Add Generate DIR_METADATA files and remove metatada from OWNERS files for //ppapi.

R=bbudge@chromium.org

Bug: 1113033
Change-Id: I6b9b22d4d041d2ceb54a1467922087a6a35a3029
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454630
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Bill Budge <bbudge@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814919}

If we have a PASS result, it means one of two things:

  i. The test passed and has no baseline file.
  ii. The test failed, but matches its baseline file exactly.

In either case, producing a diff is not interesting for the test author.

Bug: None
Change-Id: I3b81eacc958176b3b8ccea27ba10b8c445d3a1ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446779
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Luke Z <lpz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814918}

https://dawn.googlesource.com/dawn.git/+log/2ee68783068c..4171134daf9d

2020-10-07 cwallez@chromium.org Buffer: Validate the offset is aligned to 8
2020-10-07 cwallez@chromium.org Roll our copy of the Vulkan headers.
2020-10-07 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from a388d56d9968 to 28ae1471bf2c (1 revision)
2020-10-07 dsinclair@chromium.org Re-enable disabled test.
2020-10-07 cwallez@chromium.org Buffer: Disallow unmapping when unmapped.
2020-10-07 cwallez@chromium.org dawn_wire: Guarantee OOM on MAX_SIZE_T sized buffers.
2020-10-07 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from c9110b93cb8a to a388d56d9968 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC kainino@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: kainino@google.com
Change-Id: I771883e0e8ba87a5025016182d978e8b133140ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459247Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#814917}

The TLS prober will be used by network diagnostics routines to establish
a secure socket connection with a host.

BUG=chromium:956783
TEST=unit_tests --gtest_filter=TlsProberTest.*

Change-Id: If472b036054b1b0e3013a98f3927f1a6a4334b9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393560
Commit-Queue: Kartik Hegde <khegde@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814916}

These methods are the same as before. They just take their arguments in
a different order, which now matches the C syscalls.

Change-Id: I864b4593adbab59ec636f65b26ea463a11f45e3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458784
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814915}

This CL adds a |SourceType| enum to represent three different
notification item types: local media sessions, cast sessions, and
Presentation requests.
The device selector view should only show up for local media sessions.

Bug: b/161610050, 1107162
Change-Id: I45ac39af46e9aa931795fd5bb763f9c0c56c1f42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453891
Commit-Queue: Muyao Xu <muyaoxu@google.com>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814914}

Moving MouseLock emulation into the browser found that
the RenderWidgetHostViewMac::HasFocus always returned false
for WebTests. It is reasonable to simulate the view having
focus in WebTests so call OnFirstResponderChanged appropriately.

BUG=1097816

Change-Id: Id0a87cea174ac308bf73103a90fff678b30d429e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459568Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814913}

This enum is getting used more and more widely, so this CL just moves
it to its own header so that client code does not need to include the
tab helper.

No behaviorial changes.

Bug: 1136174
Change-Id: I729062549f9c04b676692c46c21cfbdef690fd63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458287
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814912}

Blink tests on Linux/ChromeOS use the FontConfig sysroot, so system
fonts do not affect test results. Use the same mechanism to make
pdf_unittests hermetic.

With hermetic tests, pdf_unittests should no longer be flaky on Linux.
As such, also revert https://crrev.com/814622 to re-enable some disabled
test cases on Linux.

Bug: 1070165,1134056
Change-Id: Ib70670e16a8f51daf91956bfecfbd696fa3eb916
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454376
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: K. Moon <kmoon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814911}

This reverts commit 436c119d.

Reason for revert: An edge case for platforms without ARC++ was not handled correctly.

Original change's description:
> Disable unmount-on-suspend for FUSE
>
> This removes the code for unmounting the FUSEs (filesystem in userspace)
> on suspend. Instead of unmounting to resolve the FUSE/freeze on suspend
> race condition, we will be using powerd code that orders freeze using
> freezer cgroups.
>
> Crostini still has some work left to do before this can be done for it,
> so unmount on suspend for its FUSE, sshfs, will be done in a later
> patch.
>
> Test: "suspend_stress_test -c 2500" on device
> Bug: b/134792837
> Change-Id: Icb8f9e309f6780e6f935be550c6c4e048a44b1fd
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336869
> Commit-Queue: Derek Basehore <dbasehore@chromium.org>
> Reviewed-by: Joel Hockey <joelhockey@chromium.org>
> Reviewed-by: Sergei Datsenko <dats@chromium.org>
> Reviewed-by: James Cook <jamescook@chromium.org>
> Reviewed-by: David Munro <davidmunro@google.com>
> Cr-Commit-Position: refs/heads/master@{#811950}

TBR=jamescook@chromium.org,achuith@chromium.org,dbasehore@chromium.org,joelhockey@chromium.org,dats@chromium.org,davidmunro@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: b/134792837
Change-Id: Ia50e43dceeb0eea448d6fdf7232af328a9a1fd1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451400Reviewed-by: David Munro <davidmunro@google.com>
Reviewed-by: Sergei Datsenko <dats@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Derek Basehore <dbasehore@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814910}

Define a new item type for files added to the holding space via nearby
sharing functionality.

Nearby shared files will be shown in the downloads section of the
holding space and will be persisted.

Bug: 1130625
Change-Id: I6da1da172a7de5e4f3ae3c321434376ffc80a38f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450053Reviewed-by: David Black <dmblack@google.com>
Reviewed-by: Weilun Shi <sweilun@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Ana Salazar <anasalazar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814909}

Previously on edge case screens, we use |LabelButton|, which is
unfocusable by default, for buttons without background. But these
buttons need to be focusable during tab traversal and accessibility
mode.

This CL introduces |InterstitialViewButton| as a subclass of
|RoundedLabelButton|. It handles both types of buttons (with and
without background), and it's focusable with a rounded rectangle focus
ring and shares common setup of the system menu buttons.

Screenshot when the button is on focus:
https://screenshot.googleplex.com/AKv42vcGDSsTYGV.png

BUG=1106937,1126208

Change-Id: I7511f8f10a0cb4abc07283d7fcee7ac79bacae31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450844Reviewed-by: Tim Song <tengs@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Meilin Wang <meilinw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814908}

Add point scanning button for later on to enable point scanning.
Signed-off-by: Shannon Chen <shannc@chromium.org>
Bug: 1061537
Change-Id: I0f691bd485fd348118b62fbe816d44fde2201628
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450924
Commit-Queue: Shannon Chen <shannc@google.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814907}

Bug: 772945
Change-Id: I193a9d4c9ce2aae9b83c1f7450f6af511bcba687
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458648
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814906}

- Test SelfVisualOverflowRect and VisualOverflowRect
  instead of LocalVisualRect and VisualOverflowRect to be more focus on
  visual overflow rects. LocalVisualRect is less interesting than
  SelfVisualOverflowRect because the former is almost directly based on
  the latter and the latter is more used.

- Enable the tests for CompositeAfterPaint

- Add a test for overflow: clip

Change-Id: I50c15a28114b5a3537b205245ac18bcf84a869d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458868Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814905}

Change-Id: I7d1ee16697795b502c176a16755ca3433c8fdd3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458773
Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org>
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814904}

Add the functionality to open settings page in the settings buttons
of PhoneHub bubble and PhoneHub notification.

BUG=1106937,1126208

Change-Id: I751c0dfb227c5d0d0d0e47f6fd97753a460e530a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453872
Commit-Queue: Andre Le <leandre@chromium.org>
Reviewed-by: Tim Song <tengs@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814903}

This CL deletes the mechanism to intercept attempts to download Adobe
Flash at get.adobe.com/flashplayer. This was previously used to issue
permission requests.

We're deleting this now.

Note this also disables changing of the Flash permission via permission
popup. We don't need that anymore either.

Bug: 1069832
Change-Id: I2c08625cff7648bdc353c1a15100f170ff86db00
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458506Reviewed-by: Raymes Khoury <raymes@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814902}

When the test is terminated for some reason, the test result list is empty. The current usage of all() to check the empty list will return true, and thus incorrectly interpretted as 'all tests are skipped'.

This CL added a check to the list itself before calling all().

Bug: chromium:1136140
Change-Id: I308ee8cd21a611b6e7f25c0996cdf3528d7ebe1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458886
Auto-Submit: Wenbin Zhang <wenbinzhang@google.com>
Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814901}

Bug: 1125150
Test: browser_tests --gtest_filter=DiagnosticsApp*
Change-Id: Ic4abe2d2789e56f5a764a7475bbdc2c3b902a00c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446772Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Michael Checo <michaelcheco@google.com>
Cr-Commit-Position: refs/heads/master@{#814900}

This CL introduces SafeBrowsingQueryManager, which manages URL
queries on the IO thread and notifies observers on the UI thread
when they are finished.  This was created to have a model object
that stored the NavigationItem ID associated with a particular
URL check request.  The previous approach assumed that when a
sub frame UnsafeResource was encountered, it was always from the
last-committed NavigationItem, but this heuristic is not always
correct, so the ID is stored in the query.

Using the query manager, UnsafeResource.navigation_url can be
reliably set to the correct value and used to drive the allow-
list decisions for those resources. In particular, the
navigation_url for main frame queries is simply the query url,
but the navigation_url for subframe queries is the url of the
corresponding main frame, obtained from the main frame's
NavigationItem. This means that a user decision to allow a
navigation to an unsafe subframe is associated with the
main frame URL rather than the subframe URL, matching other
platforms.

Patch originally by kkhorimoto@chromium.org, rebased and
landed by ajuma@.

Bug: 1084741, 1084735
Change-Id: I789535991a6ec05ec635d93b878a3cadd20dfc7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217092
Commit-Queue: Ali Juma <ajuma@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Ali Juma <ajuma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814899}

Previously downloads were only persisted by the DownloadManager. Moving
forward, we want to be able to update holding space items when their
backing files are renamed/moved, but this will leave us unable to
restore any renamed/moved downloads unless we persist them ourselves.

Persisting downloads ourselves also greatly simplifies holding space
restoration on start up due to removal of the one-off case for
downloads.

Bug: 1136173
Change-Id: I867a793449f9668f9899c75f057af7a0d35174af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458387Reviewed-by: Ahmed Mehfooz <amehfooz@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#814898}

https://android.googlesource.com/platform/external/perfetto.git/+log/3419b3b485ba..9fb07662e436

2020-10-07 treehugger-gerrit@google.com Merge "get.perfetto.dev: filter out urls"
2020-10-07 treehugger-gerrit@google.com Merge "processor: Update descriptor track names from first event's name"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: Ic31f4e2587a2ac45c4b8213ff35191eb7db30ac5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458646Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#814897}

Bug: 1134338
Change-Id: I17c4512511911db84d4485fff143cd0d570d57e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454797Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814896}

- Some settings pages use min adjective/max adjective while others use
  min superlative/max superlative, this CL updates a page that used
  min superlative/max superlative to use min adjective/max, as most
  sliders currently use min adjective/max. I went through all pages and
  confirmed that only text to speach uses superlative/max superlative.
- Confirmed with UI (mikinm@).

screenshot: https://screenshot.googleplex.com/8VSH24Jfc3W8TUH.png

Bug: 1032258
Change-Id: Icf574864093f999b81ee2d0e7ed4bbd61617dd22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458446Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com>
Cr-Commit-Position: refs/heads/master@{#814895}

https://android.googlesource.com/platform/external/perfetto.git/+log/91ab730685a6..3419b3b485ba

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: Ie7871e645a3e82f31956ad0d3c6e2ef0d9a7a256
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459186Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#814894}

Bug: 1111517
Change-Id: Iaee9abe6e4adf0bb4f65b94099906b8e8b801a80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453376Reviewed-by: Sinan Sahin <sinansahin@google.com>
Commit-Queue: Ben Goldberger <benwgold@google.com>
Cr-Commit-Position: refs/heads/master@{#814893}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll
Please CC chonggu@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: chonggu@google.com
Change-Id: I62f7c20bfded7344fd21dc1d6058485f2960197e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458706Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#814892}

We have already classified all NotifyUserActivation callers with a
notification-type to distinguish between actual vs various synthesized
user activations.  This CL adds histograms to count the number of times
activation-gated-APIs are actually affected by each notification-type in
the wild.  If a synthetic trigger turns out to be unnecessary, we would
blindly remove them.  We will then investigate the remaining
ones one-by-one.

For each class of activation-gated-APIs [1], we are counting the number
of "successful" API calls for each notification-type.  To be precise:

- For sticky user activation, the very first notification-type is
  considered to be the effective trigger.

- For transient user activation, the last (unexpired) "real" user
  activation (of type kInteraction) is considered to be the effective
  trigger.  If there is no such activation, the last (unexpired)
  synthetic activation is considered instead.

- For Consuming APIs, the effective trigger is the same as in the
  transient case above.

[1] https://html.spec.whatwg.org/multipage/interaction.html#user-activation-gated-apis

Bug: 1103249
Change-Id: I6db044125ff93835ce63a00b6e3ca0d9f3499e4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437486
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814891}

Previously, this would fail unless the "use" field was omitted.

Bug: 641499
Change-Id: Iedfbc6e9ead9a5b1355e0611af8a4f0101b2cba8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457968
Commit-Queue: Eric Roman <eroman@chromium.org>
Reviewed-by: Matt Mueller <mattm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814890}

Fixed: 1136181
Change-Id: Iaa1049d67195d1292749dbe30b3e2a2da6bd4fc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458586
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Commit-Queue: Wei Li <weili@chromium.org>
Auto-Submit: Collin Baker <collinbaker@chromium.org>
Reviewed-by: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814889}

If the GL_EXT_discard_framebuffer extension is available, use it to
discard the depth and stencil buffers earlier, in ResolveIfNeeded.
This attempts to avoid resolves and flushes of these attachments
from tile memory to main memory when using implicit antialiasing.

Continue invalidating the framebuffer, including the color buffer, upon
BindFramebuffer in FinishPrepareTransferableResourceGpu.

Small updates to two related web tests,
fast/webgl/webgl-composite-modes-repaint.html and
fast/webgl/webgl-composite-modes-tabswitching.html .

Bug: 784743
Change-Id: I6184b35bc867fbaba6540889da6d1783d7b40083
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351388
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: James Darpinian <jdarpinian@chromium.org>
Reviewed-by: Shrek Shao <shrekshao@google.com>
Cr-Commit-Position: refs/heads/master@{#814888}

We need a way to determine how an operation on a range which
may overlap with a region intersects. The kernel will notify for
ranges of memory which may span several regions or even be a portion
of a region. This new helper determines how they overlap and returns
the pieces that remain along with the intersection.

Bug: chromium:1067833
Change-Id: I83ab545ec6176105047762e9ba0d7af208255553
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453796Reviewed-by: Matthew Denton <mpdenton@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Brian Geffon <bgeffon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814887}